[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/750#issuecomment-136305163 Code LGTM and travis passes but I do not know what to test and the analysis gives a lot of new issues fro findbugs which I am sure have nothing to do with this PR but make me fail wary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-136305158 Code LGTM and travis passes but I do not know what to test and the analysis gives a lot of *solved* issues from findbugs which I am sure have nothing to do with this PR but make me fail wary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-136306330 @DaanHoogland this is just the UI :) Alright 2LGTM, merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/751 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-136264200 @remibergsma @karuturi @abhinandanprateek @jburwell @DaanHoogland @miguelaferreira review please? (same as #750) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/750#issuecomment-135663086 Please see the experimental analysis shared here: https://github.com/apache/cloudstack/pull/751#issuecomment-135661968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-135661968 Did some API request size and time comparisons for various pagesizes against a large template collection (more than 4000 templates across 30+ zones); Page Size | API response size (KB) | Time (ms) - | -- | - 20 | 15.8 | 360 100 | 77.1 | 366 150 | 117 | 448 200 | 157 | 408 250 | 199 | 440 500 | 402 | 791 Based on this data, on the lowest side pagesize of 100 seems alright for the time taken vs the payload size, but has more risk on a lower reduced list size (not enough to render a scroll); on the higher side pagesize of 200-250 seems alright considering roughly similar time. Refs: ps=20  ps=100  ps=150  ps=200  ps=250  ps=500  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/751 CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/temp⦠â¦late listing Due to aggregation of templates and isos on the UI/client side, it could result that for each page we could end up having lesser templates/isos listed to have the scroll shown that triggers infinite scrolling. The fix is to use similar approach as in projects.js, to use the maximum pagesize of 500. In theory, there is still a chance if there are 500 zones with the same template being listed resulting in only one aggregated template which could cause the scroll to not get shown; but in practice I believe this fix should work for most users. (cherry picked from commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd) Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack master-CLOUDSTACK-8766 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/751.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #751 commit 9fe2404d83035ee3829fe134d08627a9fd8e1da6 Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-08-27T07:01:04Z CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing Due to aggregation of templates and isos on the UI/client side, it could result that for each page we could end up having lesser templates/isos listed to have the scroll shown that triggers infinite scrolling. The fix is to use similar approach as in projects.js, to use the maximum pagesize of 500. In theory, there is still a chance if there are 500 zones with the same template being listed resulting in only one aggregated template which could cause the scroll to not get shown; but in practice I believe this fix should work for most users. (cherry picked from commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd) Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/750 CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/temp⦠â¦late listing Due to aggregation of templates and isos on the UI/client side, it could result that for each page we could end up having lesser templates/isos listed to have the scroll shown that triggers infinite scrolling. The fix is to use similar approach as in projects.js, to use the maximum pagesize of 500. In theory, there is still a chance if there are 500 zones with the same template being listed resulting in only one aggregated template which could cause the scroll to not get shown; but in practice I believe this fix should work for most users. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.5-CLOUDSTACK-8766 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/750.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #750 commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-08-27T07:01:04Z CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing Due to aggregation of templates and isos on the UI/client side, it could result that for each page we could end up having lesser templates/isos listed to have the scroll shown that triggers infinite scrolling. The fix is to use similar approach as in projects.js, to use the maximum pagesize of 500. In theory, there is still a chance if there are 500 zones with the same template being listed resulting in only one aggregated template which could cause the scroll to not get shown; but in practice I believe this fix should work for most users. Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-135403152 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/750#issuecomment-135403029 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-134872958 I've add a similar fix for listing iso/zone page and also added code that would de-dupe any isos and templates in the main list view. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134873788 I've updated the PR to fix the same issue for listing isos and also addition code to de-dupe list iso and template results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134952809 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-135201596 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-135201859 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134508369 @karuturi the sharedFunctions.js defines a global pagesize (fixed to value 20) See in the screenshot; the listTemplates call does not call the API with a page, pagesize - this causes the infinite scroll to flood the list every time to drag it if the number of zones exceed what could fit in that table view. This patch fixes that.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134509669 @karuturi this is the screenshot from chrome devtools with the UI fix, as you can see pagination is implemented  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-134523852 thanks @karuturi the screenshots are from a 4.5 env, I've tested this on 4.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134522578 tested it and confirm the behaviour in the screenshots before and after the fix. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-134522790 :+1: as per #740 (I havent tested it on 4.5) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/739 CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template⦠⦠listing Uses listViewDataProvider to implement pagination on listTemplates API requests in the UI, when a template's zone tab is viewed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-8766 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/739.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #739 commit 95c76efc3944aab9a620559a026fe37e53d8f53d Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-08-25T05:59:21Z CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template listing Uses listViewDataProvider to implement pagination on listTemplates API requests in the UI, when a template's zone tab is viewed. Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134504869 What is the page size? can you attach a screenshot? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/740 CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template⦠⦠listing Uses listViewDataProvider to implement pagination on listTemplates API requests in the UI, when a template's zone tab is viewed. (cherry picked from commit 95c76efc3944aab9a620559a026fe37e53d8f53d) This from the other PR, for master branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-8766-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #740 commit 1ad2f848adcccdf23a73b3ee43d05470e95c8d30 Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-08-25T05:59:21Z CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template listing Uses listViewDataProvider to implement pagination on listTemplates API requests in the UI, when a template's zone tab is viewed. (cherry picked from commit 95c76efc3944aab9a620559a026fe37e53d8f53d) Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
