Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-11 Thread Saksham Srivastava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/#review26049
---



test/integration/component/test_ip_reservation.py


When you create a network without gateway nad subnet mask, you are using 
the zone level cidr.
In case the zone level cidr is not 10.1.1.0/24 all the tests will fail.
while creating the network use gateway and subnet mask also.



test/integration/component/test_ip_reservation.py


Same issue here also. Use gateway and subnet mask.



test/integration/component/test_ip_reservation.py


In case the vm creation fails the test itself will fail, it will be good to 
skip the test in that case.



test/integration/component/test_ip_reservation.py


Adding an addition check of None will prevent future NPEs


- Saksham Srivastava


On Sept. 11, 2013, 10:09 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14079/
> ---
> 
> (Updated Sept. 11, 2013, 10:09 a.m.)
> 
> 
> Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> marvin tests for IP Address reservation within a network 
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ip_reservation.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py fa4cc82 
> 
> Diff: https://reviews.apache.org/r/14079/diff/
> 
> 
> Testing
> ---
> 
> ran successfully on  my local advanced zone setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-12 Thread Anshul Gangwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/
---

(Updated Sept. 12, 2013, 8:05 a.m.)


Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.


Changes
---

updated the patch with suggested changes


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266


Repository: cloudstack-git


Description
---

marvin tests for IP Address reservation within a network 


Diffs (updated)
-

  test/integration/component/test_ip_reservation.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py fa4cc82 

Diff: https://reviews.apache.org/r/14079/diff/


Testing
---

ran successfully on  my local advanced zone setup


Thanks,

Anshul Gangwar

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-12 Thread Anshul Gangwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/
---

(Updated Sept. 12, 2013, 11:13 a.m.)


Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.


Changes
---

updated the patch with some modifications which will reduce the execution time 
of tests considerably


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266


Repository: cloudstack-git


Description
---

marvin tests for IP Address reservation within a network 


Diffs (updated)
-

  test/integration/component/test_ip_reservation.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py fa4cc82 

Diff: https://reviews.apache.org/r/14079/diff/


Testing
---

ran successfully on  my local advanced zone setup


Thanks,

Anshul Gangwar

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-15 Thread Saksham Srivastava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/#review26130
---

Ship it!


Looks good. Can a committer have a look and apply the patch.

- Saksham Srivastava


On Sept. 12, 2013, 11:13 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14079/
> ---
> 
> (Updated Sept. 12, 2013, 11:13 a.m.)
> 
> 
> Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> marvin tests for IP Address reservation within a network 
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ip_reservation.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py fa4cc82 
> 
> Diff: https://reviews.apache.org/r/14079/diff/
> 
> 
> Testing
> ---
> 
> ran successfully on  my local advanced zone setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-16 Thread Anshul Gangwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/
---

(Updated Sept. 16, 2013, 11:11 a.m.)


Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.


Changes
---

removed the extraneous parameters from virtual_machine json


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266


Repository: cloudstack-git


Description
---

marvin tests for IP Address reservation within a network 


Diffs (updated)
-

  test/integration/component/test_ip_reservation.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py fa4cc82 

Diff: https://reviews.apache.org/r/14079/diff/


Testing
---

ran successfully on  my local advanced zone setup


Thanks,

Anshul Gangwar

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-16 Thread abhinav roy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/#review26137
---

Ship it!


Ship It!

- abhinav roy


On Sept. 16, 2013, 11:11 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14079/
> ---
> 
> (Updated Sept. 16, 2013, 11:11 a.m.)
> 
> 
> Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> marvin tests for IP Address reservation within a network 
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ip_reservation.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py fa4cc82 
> 
> Diff: https://reviews.apache.org/r/14079/diff/
> 
> 
> Testing
> ---
> 
> ran successfully on  my local advanced zone setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-17 Thread Prasanna Santhanam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14079/#review26201
---

Ship it!


master, 4.2-forward

- Prasanna Santhanam


On Sept. 16, 2013, 11:11 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14079/
> ---
> 
> (Updated Sept. 16, 2013, 11:11 a.m.)
> 
> 
> Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> marvin tests for IP Address reservation within a network 
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ip_reservation.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py fa4cc82 
> 
> Diff: https://reviews.apache.org/r/14079/diff/
> 
> 
> Testing
> ---
> 
> ran successfully on  my local advanced zone setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>