Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review48626
---


Commit 0f85e649b64b38cf80bc1e86ac15b206bef65117 in cloudstack's branch 
refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0f85e64 ]

CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from 
CloudStack


- ASF Subversion and Git Services


On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated March 13, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Saksham Srivastava]

> On March 13, 2014, 4:55 p.m., Alena Prokharchyk wrote:
> > Also why don't start routers in parallel? First, get all the router nics in 
> > one query like John suggested, then span start process for routers in 
> > separate threads, check the status of each job using Future.

Sure I will do that.


- Saksham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review37066
---


On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated March 13, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Saksham Srivastava]

> On March 13, 2014, 4:46 p.m., John Burwell wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 756
> > 
> >
> > Two queries are executed in this for loop which puts stress on the 
> > database and slows down the application.  Furthermore, this for loop 
> > appears to be performing in-memory join and filter operations.  Please 
> > refactor into a single query performed by the most appropriate DAO.

I guess I completely misunderstood the last comment by you, now it makes 
complete sense to me. Thanks for the suggestion John, I will update my patch 
with a single query.


- Saksham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review37061
---


On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated March 13, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review37066
---


Also why don't start routers in parallel? First, get all the router nics in one 
query like John suggested, then span start process for routers in separate 
threads, check the status of each job using Future.

- Alena Prokharchyk


On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated March 13, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review37064
---


Also why don't start routers in parallel? First, get all the router nics in one 
query like John suggested, then span start process for routers in separate 
threads, check the status of each job using Future.

- Alena Prokharchyk


On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated March 13, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[John Burwell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review37061
---



server/src/com/cloud/vm/UserVmManagerImpl.java


Two queries are executed in this for loop which puts stress on the database 
and slows down the application.  Furthermore, this for loop appears to be 
performing in-memory join and filter operations.  Please refactor into a single 
query performed by the most appropriate DAO.


- John Burwell


On March 13, 2014, 3:31 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated March 13, 2014, 3:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/
---

(Updated March 13, 2014, 7:31 a.m.)


Review request for cloudstack, John Burwell and Murali Reddy.


Bugs: CLOUDSTACK-5999
https://issues.apache.org/jira/browse/CLOUDSTACK-5999


Repository: cloudstack-git


Description
---

When a guest is rebooted from CloudStack, if the virtual router managing the 
guest network of that guest is down, CloudStack will not start the virtual 
router.
However the router is started in case the guest vm is stopped and then started.
To mantain similarity between the 2 process it is necessary to start the VR in 
case it is not running.
The fix will address the same.


Diffs
-

  server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 

Diff: https://reviews.apache.org/r/17736/diff/


Testing
---

Testing:
1) vm in a single guest network :
   vm Reboot : If the VR is stopped: VR is first started and then 
the VM reboots.
   vm Reboot : If the VR is running, VM reboots as it used to.
vm Stop/Start continue to work the same.

2)  vm having nics in multi networks :
   vm Reboot : If VR in any/all network is stopped: VRs are first 
started and then the VM reboots.
   vm Reboot : If the VRs are running, VM reboots as it used to.
vm Stop/Start continue to work the same.

3) vpc :
   Tested the above scenarios for vpc also, works fine.

Patch applies cleanly.
Build passes succesfully.
FindBug is passed.
Rebased against latest master.


Thanks,

Saksham Srivastava

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/
---

(Updated March 13, 2014, 7:02 a.m.)


Review request for cloudstack, John Burwell and Murali Reddy.


Bugs: CLOUDSTACK-5999
https://issues.apache.org/jira/browse/CLOUDSTACK-5999


Repository: cloudstack-git


Description
---

When a guest is rebooted from CloudStack, if the virtual router managing the 
guest network of that guest is down, CloudStack will not start the virtual 
router.
However the router is started in case the guest vm is stopped and then started.
To mantain similarity between the 2 process it is necessary to start the VR in 
case it is not running.
The fix will address the same.


Diffs (updated)
-

  server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 

Diff: https://reviews.apache.org/r/17736/diff/


Testing (updated)
---

Testing:
1) vm in a single guest network :
   vm Reboot : If the VR is stopped: VR is first started and then 
the VM reboots.
   vm Reboot : If the VR is running, VM reboots as it used to.
vm Stop/Start continue to work the same.

2)  vm having nics in multi networks :
   vm Reboot : If VR in any/all network is stopped: VRs are first 
started and then the VM reboots.
   vm Reboot : If the VRs are running, VM reboots as it used to.
vm Stop/Start continue to work the same.

3) vpc :
   Tested the above scenarios for vpc also, works fine.

Patch applies cleanly.
Build passes succesfully.
FindBug is passed.
Rebased against latest master.


Thanks,

Saksham Srivastava

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/
---

(Updated Feb. 7, 2014, 9:26 a.m.)


Review request for cloudstack, John Burwell and Murali Reddy.


Changes
---

Updated the patch.


Bugs: CLOUDSTACK-5999
https://issues.apache.org/jira/browse/CLOUDSTACK-5999


Repository: cloudstack-git


Description
---

When a guest is rebooted from CloudStack, if the virtual router managing the 
guest network of that guest is down, CloudStack will not start the virtual 
router.
However the router is started in case the guest vm is stopped and then started.
To mantain similarity between the 2 process it is necessary to start the VR in 
case it is not running.
The fix will address the same.


Diffs (updated)
-

  server/src/com/cloud/vm/UserVmManagerImpl.java 81be19f 

Diff: https://reviews.apache.org/r/17736/diff/


Testing
---

Testing:
1) vm in a single guest network :
   vm Reboot : If the VR is stopped: VR is first started and then 
the VM reboots.
   vm Reboot : If the VR is running, VM reboots as it used to.
vm Stop/Start continue to work the same.

2)  vm having nics in multi networks :
   vm Reboot : If VR in any/all network is stopped: VRs are first 
started and then the VM reboots.
   vm Reboot : If the VRs are running, VM reboots as it used to.
vm Stop/Start continue to work the same.

3) vpc :
   Tested the above scenarios for vpc also, works fine.

Patch applies cleanly.


Thanks,

Saksham Srivastava

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review33921
---



server/src/com/cloud/vm/UserVmManagerImpl.java


Thanks John for the comments.
Created single list and now using new utility to grab the domain router for 
the network.


- Saksham Srivastava


On Feb. 5, 2014, 8:46 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated Feb. 5, 2014, 8:46 a.m.)
> 
> 
> Review request for cloudstack and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 81be19f 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

[John Burwell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review33792
---



server/src/com/cloud/vm/UserVmManagerImpl.java


The nested for loop of select queries is a scalability issue.  Please 
refactor to join the nics and routers to create one list to traverse.



server/src/com/cloud/vm/UserVmManagerImpl.java


The content of this log message makes no sense to an operator.  Why do they 
care that a router has been found?  Please change to something like the 
following:

  "Restarting virtual router  () due to guest VM  
restart."

This log message feels more like an INFO not a WARN. 


- John Burwell


On Feb. 5, 2014, 3:46 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> ---
> 
> (Updated Feb. 5, 2014, 3:46 a.m.)
> 
> 
> Review request for cloudstack and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
> https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 81be19f 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> 1) vm in a single guest network :
>vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>