Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41606 --- Commit b6fabfecf28b33feafcc1beaac44bc550386e737 in cloudstack's branch refs/heads/4.4 from Gabor Apati-Nagy [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b6fabfe ] CLOUDSTACK-6255 UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks - ASF Subversion and Git Services On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 24, 2014, 9:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties 8abe874 ui/dictionary.jsp ebe71b6 ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
On April 22, 2014, 5:55 p.m., Brian Federle wrote: Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? Gabor Apati-Nagy wrote: Thanks for reviewing. Yes this is intentional. On that screen, we allow only VpcVirtualRouter for all services except Connectivity that has 3 providers available. Thanks Gabor. The only modification to make then is to add the readonly=readonly attribute to the input box, assuming the user cannot change this value. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 --- On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 15, 2014, 10:41 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties bfa9600 ui/dictionary.jsp f4d380c ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 6494704 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 50e12f9 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
On April 22, 2014, 6:55 p.m., Brian Federle wrote: Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? Gabor Apati-Nagy wrote: Thanks for reviewing. Yes this is intentional. On that screen, we allow only VpcVirtualRouter for all services except Connectivity that has 3 providers available. Brian Federle wrote: Thanks Gabor. The only modification to make then is to add the readonly=readonly attribute to the input box, assuming the user cannot change this value. Good catch. But instead of making them readonly, I decided to change these back to dropdowns (with one item in them)- so it is displayed like at all other places, so there is no chance for confusion. Please see the modified patch. Thanks - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 --- On April 15, 2014, 11:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 15, 2014, 11:41 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties bfa9600 ui/dictionary.jsp f4d380c ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 6494704 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 50e12f9 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 24, 2014, 10:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Changes --- Changed provider selectors from inconsistent textboxes to dropdowns on Add vpc Offering page Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs (updated) - client/WEB-INF/classes/resources/messages.properties 8abe874 ui/dictionary.jsp ebe71b6 ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41400 --- Ship it! Ship It! - Brian Federle On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 24, 2014, 9:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties 8abe874 ui/dictionary.jsp ebe71b6 ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41401 --- Commit 156b08af5f3cbc76ee341cfda8da3f8d15a7ed8b in cloudstack's branch refs/heads/master from Gabor Apati-Nagy [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=156b08a ] CLOUDSTACK-6255 UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks - ASF Subversion and Git Services On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 24, 2014, 9:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties 8abe874 ui/dictionary.jsp ebe71b6 ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41402 --- Commit 83e5ea9812cb57eb214ec9548671b0404914ae9b in cloudstack's branch refs/heads/4.4-forward from Gabor Apati-Nagy [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=83e5ea9 ] CLOUDSTACK-6255 UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks - ASF Subversion and Git Services On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 24, 2014, 9:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties 8abe874 ui/dictionary.jsp ebe71b6 ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 --- Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? - Brian Federle On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 15, 2014, 10:41 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties bfa9600 ui/dictionary.jsp f4d380c ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 6494704 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 50e12f9 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
On April 22, 2014, 6:55 p.m., Brian Federle wrote: Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? Thanks for reviewing. Yes this is intentional. On that screen, we allow only VpcVirtualRouter for all services except Connectivity that has 3 providers available. - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 --- On April 15, 2014, 11:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 15, 2014, 11:41 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties bfa9600 ui/dictionary.jsp f4d380c ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 6494704 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 50e12f9 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
