Re: Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/#review20478 --- server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java https://reviews.apache.org/r/10942/#comment42203 acl_id for gateway cannot be null server/src/com/cloud/network/vpc/VpcManagerImpl.java https://reviews.apache.org/r/10942/#comment42202 Import should be replaced with single imports setup/db/db/schema-410to420.sql https://reviews.apache.org/r/10942/#comment42201 acl_id for vpc_gateway can be not null field. gateway will be associated witl acl at all times - Kishan Kavala On May 10, 2013, 12:52 p.m., Jayapal Reddy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- (Updated May 10, 2013, 12:52 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs - api/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f api/src/com/cloud/network/NetworkService.java bea92dc api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/firewall/NetworkACLService.java 5f068a3 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d server/src/com/cloud/network/NetworkServiceImpl.java 7045eff server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 1d901d9 server/src/com/cloud/network/vpc/NetworkACLManager.java 1b1e958 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 67547c6 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 2844dcb server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 server/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f server/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java ef5478b server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java a483291 setup/db/db/schema-410to420.sql 8fdf0a0 Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
Re: Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- (Updated May 13, 2013, 10:14 a.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Changes --- Updated the merge conflicts and review comments Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs (updated) - api/src/com/cloud/network/NetworkService.java 5d4fd67 api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/vpc/NetworkACLService.java 0258333 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062 core/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 6d7e0e7 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d server/src/com/cloud/api/ApiResponseHelper.java 7b4c1f9 server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java dbfd88c server/src/com/cloud/network/vpc/NetworkACLManager.java 0ff3e88 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 71d6da4 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 7c50d90 server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcManagerImpl.java 9993c06 server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java 2886af4 server/test/com/cloud/vpc/NetworkACLManagerTest.java dc53b2b server/test/org/apache/cloudstack/privategw/AclOnPrivateGwTest.java PRE-CREATION setup/db/db/schema-410to420.sql 6e74537 test/integration/smoke/test_network_acl.py 300fff9 test/integration/smoke/test_privategw_acl.py PRE-CREATION Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
Re: Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- (Updated May 13, 2013, 1:14 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Changes --- Updated review comments Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs (updated) - api/src/com/cloud/network/NetworkService.java 4a6a84f api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/vpc/NetworkACLService.java 0258333 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062 core/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java db50f3f engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 7ce3b93 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 9f6a9f0 server/src/com/cloud/api/ApiResponseHelper.java 7b2bb03 server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java dbfd88c server/src/com/cloud/network/vpc/NetworkACLManager.java 0ff3e88 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 71d6da4 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 7c50d90 server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcManagerImpl.java b70ede8 server/test/com/cloud/vpc/MockVpcManagerImpl.java 3835c2e server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java 0f12c43 server/test/com/cloud/vpc/NetworkACLManagerTest.java dc53b2b server/test/com/cloud/vpc/NetworkACLServiceTest.java 145efb4 server/test/org/apache/cloudstack/privategw/AclOnPrivateGwTest.java PRE-CREATION setup/db/db/schema-410to420.sql 136d61b test/integration/smoke/test_network_acl.py 300fff9 test/integration/smoke/test_privategw_acl.py PRE-CREATION Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
Re: Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/#review20484 --- Ship it! commit 2d950e2858a2c67a41dd69d368a7432b00f64233 - Kishan Kavala On May 13, 2013, 1:14 p.m., Jayapal Reddy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- (Updated May 13, 2013, 1:14 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs - api/src/com/cloud/network/NetworkService.java 4a6a84f api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/vpc/NetworkACLService.java 0258333 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062 core/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java db50f3f engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 7ce3b93 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 9f6a9f0 server/src/com/cloud/api/ApiResponseHelper.java 7b2bb03 server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java dbfd88c server/src/com/cloud/network/vpc/NetworkACLManager.java 0ff3e88 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 71d6da4 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 7c50d90 server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcManagerImpl.java b70ede8 server/test/com/cloud/vpc/MockVpcManagerImpl.java 3835c2e server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java 0f12c43 server/test/com/cloud/vpc/NetworkACLManagerTest.java dc53b2b server/test/com/cloud/vpc/NetworkACLServiceTest.java 145efb4 server/test/org/apache/cloudstack/privategw/AclOnPrivateGwTest.java PRE-CREATION setup/db/db/schema-410to420.sql 136d61b test/integration/smoke/test_network_acl.py 300fff9 test/integration/smoke/test_privategw_acl.py PRE-CREATION Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
Re: Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- (Updated May 10, 2013, 12:52 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Changes --- Updated diff file. Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs (updated) - api/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f api/src/com/cloud/network/NetworkService.java bea92dc api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/firewall/NetworkACLService.java 5f068a3 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d server/src/com/cloud/network/NetworkServiceImpl.java 7045eff server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 1d901d9 server/src/com/cloud/network/vpc/NetworkACLManager.java 1b1e958 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 67547c6 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 2844dcb server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 server/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f server/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java ef5478b server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java a483291 setup/db/db/schema-410to420.sql 8fdf0a0 Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
Re: Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- (Updated May 9, 2013, 12:08 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Changes --- Updated the diff Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs (updated) - api/src/com/cloud/network/NetworkService.java 5d4fd67 api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/vpc/NetworkACLService.java 0258333 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062 core/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d server/src/com/cloud/api/ApiResponseHelper.java 9548062 server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 1d901d9 server/src/com/cloud/network/vpc/NetworkACLManager.java 0ff3e88 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 71d6da4 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 7c50d90 server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java cd1373c server/test/com/cloud/vpc/NetworkACLManagerTest.java dc53b2b server/test/org/apache/cloudstack/privategw/AclOnPrivateGwTest.java PRE-CREATION setup/db/db/schema-410to420.sql 8a42812 test/integration/smoke/test_network_acl.py 300fff9 test/integration/smoke/test_privategw_acl.py PRE-CREATION Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
Review Request: ACL on private gateway feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ --- Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy. Description --- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs - api/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f api/src/com/cloud/network/NetworkService.java bea92dc api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 api/src/com/cloud/network/firewall/NetworkACLService.java 5f068a3 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d server/src/com/cloud/network/NetworkServiceImpl.java 7045eff server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 1d901d9 server/src/com/cloud/network/vpc/NetworkACLManager.java 1b1e958 server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 67547c6 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 2844dcb server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 server/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f server/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java ef5478b server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java a483291 setup/db/db/schema-410to420.sql 8fdf0a0 Diff: https://reviews.apache.org/r/10942/diff/ Testing --- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy
