Re: Review Request: Selenium Headless configuration using PhantomJS

[Chip Childers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review21978
---


Was this committed?  I see a "Ship It" from Edison.

- Chip Childers


On May 2, 2013, 12:08 a.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated May 2, 2013, 12:08 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -
> 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
>   test/selenium/smoke/main.py 86bb930 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Re: Review Request: Selenium Headless configuration using PhantomJS

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review20037
---

Ship it!


Ship It!

- edison su


On May 2, 2013, 12:08 a.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated May 2, 2013, 12:08 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -
> 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
>   test/selenium/smoke/main.py 86bb930 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Re: Review Request: Selenium Headless configuration using PhantomJS

[Parth Jagirdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/
---

(Updated May 2, 2013, 12:08 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, and edison su.


Changes
---

Adding command line Param for MS IP.


Description
---

Selenium Headless configuration using PhantomJS.

Fixed Readme Typos, and added an extra field for PhantomJS and How to configure 
Management Server IP.


This addresses bug Cloudstack-2282.


Diffs (updated)
-

  test/selenium/ReadMe.txt 30b0e0d 
  test/selenium/lib/initialize.py e8cc49a 
  test/selenium/smoke/Login_and_Accounts.py c5132d9 
  test/selenium/smoke/main.py 86bb930 

Diff: https://reviews.apache.org/r/10846/diff/


Testing
---

NA.


Thanks,

Parth Jagirdar

Re: Review Request: Selenium Headless configuration using PhantomJS

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review20012
---



test/selenium/smoke/Login_and_Accounts.py


For this kind of global configurations, what we did in marvin, is that, 
inject global configurations into each unit test case. For example, we can add 
a command line option(mgt server ip) in test/selenium/smoke/main.py, then 
inject mgt server ip address into each unit test case:  setattr(test, 
"base_url", "http://mgt-serv-ip-got-from-command-line:8080/";), then inside each 
unit test, self.base_url is already initialized.


- edison su


On May 1, 2013, 5:48 p.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated May 1, 2013, 5:48 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -
> 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Re: Review Request: Selenium Headless configuration using PhantomJS

[Parth Jagirdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/
---

(Updated May 1, 2013, 5:48 p.m.)


Review request for cloudstack, David Nalley, Chip Childers, and edison su.


Changes
---

Updating the diff


Description
---

Selenium Headless configuration using PhantomJS.

Fixed Readme Typos, and added an extra field for PhantomJS and How to configure 
Management Server IP.


This addresses bug Cloudstack-2282.


Diffs (updated)
-

  test/selenium/ReadMe.txt 30b0e0d 
  test/selenium/lib/initialize.py e8cc49a 
  test/selenium/smoke/Login_and_Accounts.py c5132d9 

Diff: https://reviews.apache.org/r/10846/diff/


Testing
---

NA.


Thanks,

Parth Jagirdar

Re: Review Request: Selenium Headless configuration using PhantomJS

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review20009
---


Did you attache a wrong patch?

- edison su


On April 30, 2013, 5:56 p.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated April 30, 2013, 5:56 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -
> 
>   
> framework/ipc/src/org/apache/cloudstack/framework/messagebus/MessageBus.java 
> 4aa007d 
>   
> framework/ipc/src/org/apache/cloudstack/framework/messagebus/MessageBusBase.java
>  5b7af4d 
>   framework/ipc/test/org/apache/cloudstack/messagebus/TestMessageBus.java 
> PRE-CREATION 
>   framework/ipc/test/resources/MessageBusTestContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Re: Review Request: Selenium Headless configuration using PhantomJS

[Parth Jagirdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/
---

(Updated April 30, 2013, 5:56 p.m.)


Review request for cloudstack, David Nalley, Chip Childers, and edison su.


Changes
---

Removed password from build/replace.properties


Description
---

Selenium Headless configuration using PhantomJS.

Fixed Readme Typos, and added an extra field for PhantomJS and How to configure 
Management Server IP.


This addresses bug Cloudstack-2282.


Diffs (updated)
-

  framework/ipc/src/org/apache/cloudstack/framework/messagebus/MessageBus.java 
4aa007d 
  
framework/ipc/src/org/apache/cloudstack/framework/messagebus/MessageBusBase.java
 5b7af4d 
  framework/ipc/test/org/apache/cloudstack/messagebus/TestMessageBus.java 
PRE-CREATION 
  framework/ipc/test/resources/MessageBusTestContext.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/10846/diff/


Testing
---

NA.


Thanks,

Parth Jagirdar

Re: Review Request: Selenium Headless configuration using PhantomJS

[David Nalley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review19935
---



test/selenium/smoke/Login_and_Accounts.py


I worry that this file is going to frequently change for anyone who is 
testing and committing. 

Can we rename this file to test/selenium/Log_and_Accounts.py.default with 
instructions to change it and then add test/selenium/Log_and_Accounts.py to 
.gitignore? 


- David Nalley


On April 29, 2013, 11:35 p.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated April 29, 2013, 11:35 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -
> 
>   build/replace.properties 265f335 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Re: Review Request: Selenium Headless configuration using PhantomJS

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review19931
---



build/replace.properties


Hmm, you shouldn't need to modify this file any more? As the db setup is 
moved to utils/conf/db.properties


- edison su


On April 29, 2013, 11:35 p.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated April 29, 2013, 11:35 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -
> 
>   build/replace.properties 265f335 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Review Request: Selenium Headless configuration using PhantomJS

[Parth Jagirdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/
---

Review request for cloudstack, David Nalley, Chip Childers, and edison su.


Description
---

Selenium Headless configuration using PhantomJS.

Fixed Readme Typos, and added an extra field for PhantomJS and How to configure 
Management Server IP.


This addresses bug Cloudstack-2282.


Diffs
-

  build/replace.properties 265f335 
  test/selenium/ReadMe.txt 30b0e0d 
  test/selenium/lib/initialize.py e8cc49a 
  test/selenium/smoke/Login_and_Accounts.py c5132d9 

Diff: https://reviews.apache.org/r/10846/diff/


Testing
---

NA.


Thanks,

Parth Jagirdar