Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24093 --- Review 13009 PASSED the build test The url of build cloudstack-master-with-patch #66 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/66/ - Jenkins Cloudstack.org On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 4:12 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 9:31 a.m.) Review request for cloudstack and Prasanna Santhanam. Changes --- Offering cleanup removed Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs (updated) - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24106 --- Commit eae874918d717ba06d0ab18ece6e4a7a2f28471b in branch refs/heads/master from Sowmya Krishnan [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eae8749 ] CLOUDSTACK-3744 Fixed order of cleanup objects, removed offerings cleanup Signed-off-by: Prasanna Santhanam t...@apache.org (cherry picked from commit 08c82883f6bcc18804c88633c9c85764c5d22417) - ASF Subversion and Git Services On July 29, 2013, 9:31 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 9:31 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24107 --- Commit 08c82883f6bcc18804c88633c9c85764c5d22417 in branch refs/heads/4.2 from Sowmya Krishnan [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=08c8288 ] CLOUDSTACK-3744 Fixed order of cleanup objects, removed offerings cleanup Signed-off-by: Prasanna Santhanam t...@apache.org - ASF Subversion and Git Services On July 29, 2013, 9:31 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 9:31 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24108 --- Ship it! Ship It! - Prasanna Santhanam On July 29, 2013, 9:31 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 9:31 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24082 --- test/integration/component/test_netscaler_nw_off.py https://reviews.apache.org/r/13009/#comment47926 I think you should remove the ntwk offering altogether from cleanup. Network offerings currently do not delete if the account's network deployed from that offering isn't shutdown in time. Since offerings are lightweight and do not consume physical/virtual resources, we should defer them from the cleanup process. - Prasanna Santhanam On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 4:12 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
On July 29, 2013, 4:35 a.m., Prasanna Santhanam wrote: test/integration/component/test_netscaler_nw_off.py, line 613 https://reviews.apache.org/r/13009/diff/1/?file=330048#file330048line613 I think you should remove the ntwk offering altogether from cleanup. Network offerings currently do not delete if the account's network deployed from that offering isn't shutdown in time. Since offerings are lightweight and do not consume physical/virtual resources, we should defer them from the cleanup process. Reason to wait on cleanup in this test is to remove the Netscaler devices added as part of the test. Those could be used for other tests. To remove the device, we need to wait on clean up of the networks as well. So we aren't really waiting on network offering cleanup. - Sowmya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24082 --- On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 4:12 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
On July 29, 2013, 4:35 a.m., Prasanna Santhanam wrote: test/integration/component/test_netscaler_nw_off.py, line 613 https://reviews.apache.org/r/13009/diff/1/?file=330048#file330048line613 I think you should remove the ntwk offering altogether from cleanup. Network offerings currently do not delete if the account's network deployed from that offering isn't shutdown in time. Since offerings are lightweight and do not consume physical/virtual resources, we should defer them from the cleanup process. Sowmya Krishnan wrote: Reason to wait on cleanup in this test is to remove the Netscaler devices added as part of the test. Those could be used for other tests. To remove the device, we need to wait on clean up of the networks as well. So we aren't really waiting on network offering cleanup. Although, i could still remove the offering cleanup too... Will do that. - Sowmya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24082 --- On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 4:12 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
