Review Request 13495: CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well

2013-08-12 Thread Saksham Srivastava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13495/
---

Review request for cloudstack and Devdeep Singh.


Bugs: CLOUDSTACK-4189


Repository: cloudstack-git


Description
---

Listing out dedicated zones with zone id is returning all dedicated zones.
Issue: search criteria was always passing null for the zoneid.
Fixed the issue by setting zoneId inplace of datacenter id.


Diffs
-

  server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 6c91ce7 

Diff: https://reviews.apache.org/r/13495/diff/


Testing
---

list dedicatedzone with zoneid now returns correct dedicated zone.


Thanks,

Saksham Srivastava



Re: Review Request 13495: CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well

2013-08-12 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13495/#review24995
---


Commit 2eceb7dcbe767f0f8a6cc3fb15655fb10d330406 in branch refs/heads/4.2 from 
Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2eceb7d ]

CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a 
domain, shows other zones dedicated as well


- ASF Subversion and Git Services


On Aug. 12, 2013, 12:28 p.m., Saksham Srivastava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13495/
 ---
 
 (Updated Aug. 12, 2013, 12:28 p.m.)
 
 
 Review request for cloudstack and Devdeep Singh.
 
 
 Bugs: CLOUDSTACK-4189
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Listing out dedicated zones with zone id is returning all dedicated zones.
 Issue: search criteria was always passing null for the zoneid.
 Fixed the issue by setting zoneId inplace of datacenter id.
 
 
 Diffs
 -
 
   server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 6c91ce7 
 
 Diff: https://reviews.apache.org/r/13495/diff/
 
 
 Testing
 ---
 
 list dedicatedzone with zoneid now returns correct dedicated zone.
 
 
 Thanks,
 
 Saksham Srivastava
 




Re: Review Request 13495: CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well

2013-08-12 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13495/#review24997
---


Commit 5510bca9e5223730dc469b443b50d26550533360 in branch refs/heads/master 
from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5510bca ]

CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a 
domain, shows other zones dedicated as well


- ASF Subversion and Git Services


On Aug. 12, 2013, 12:28 p.m., Saksham Srivastava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13495/
 ---
 
 (Updated Aug. 12, 2013, 12:28 p.m.)
 
 
 Review request for cloudstack and Devdeep Singh.
 
 
 Bugs: CLOUDSTACK-4189
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Listing out dedicated zones with zone id is returning all dedicated zones.
 Issue: search criteria was always passing null for the zoneid.
 Fixed the issue by setting zoneId inplace of datacenter id.
 
 
 Diffs
 -
 
   server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 6c91ce7 
 
 Diff: https://reviews.apache.org/r/13495/diff/
 
 
 Testing
 ---
 
 list dedicatedzone with zoneid now returns correct dedicated zone.
 
 
 Thanks,
 
 Saksham Srivastava
 




Re: Review Request 13495: CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well

2013-08-12 Thread Devdeep Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13495/#review24999
---

Ship it!


Ship It!

- Devdeep Singh


On Aug. 12, 2013, 12:28 p.m., Saksham Srivastava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13495/
 ---
 
 (Updated Aug. 12, 2013, 12:28 p.m.)
 
 
 Review request for cloudstack and Devdeep Singh.
 
 
 Bugs: CLOUDSTACK-4189
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Listing out dedicated zones with zone id is returning all dedicated zones.
 Issue: search criteria was always passing null for the zoneid.
 Fixed the issue by setting zoneId inplace of datacenter id.
 
 
 Diffs
 -
 
   server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 6c91ce7 
 
 Diff: https://reviews.apache.org/r/13495/diff/
 
 
 Testing
 ---
 
 list dedicatedzone with zoneid now returns correct dedicated zone.
 
 
 Thanks,
 
 Saksham Srivastava