Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

> On Dec. 4, 2013, 2:06 p.m., daan Hoogland wrote:
> > Bharat, neither version 4 nor version 3 of your patch apply to master. Also 
> > I noted the ticket number in the commit comment changed from 5160 to 5161. 
> > Can you explain.

Hi Dann,

This change is already shipped to master, closing this review request. Also you 
are right that the ticket number changed.I have linked the bugs in jira. so 
that one can see both the issues for tracking purposes.

thanks,
Bharat.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29732
---


On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Dec. 3, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 6fc8b54 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 
>   
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
>  ad957d5 
>   
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java
>  8c58227 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 4e25493 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
>  5dd15ce 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  71e8b7d 
>   server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29732
---


Bharat, neither version 4 nor version 3 of your patch apply to master. Also I 
noted the ticket number in the commit comment changed from 5160 to 5161. Can 
you explain.

- daan Hoogland


On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Dec. 3, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 6fc8b54 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 
>   
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
>  ad957d5 
>   
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java
>  8c58227 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 4e25493 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
>  5dd15ce 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  71e8b7d 
>   server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29707
---


Commit e5cfe948186b825d2b28c99ce2915a5ca8498aff in branch refs/heads/master 
from Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e5cfe94 ]

CLOUDSTACK-5160 add a map to specify the custom compute parameters in the 
deployvm api.

Signed-off-by: Jayapal 


- ASF Subversion and Git Services


On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Dec. 3, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 6fc8b54 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 
>   
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
>  ad957d5 
>   
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java
>  8c58227 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 4e25493 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
>  5dd15ce 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  71e8b7d 
>   server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/
---

(Updated Dec. 3, 2013, 10:53 a.m.)


Review request for cloudstack, Jayapal Reddy and Koushik Das.


Changes
---

patch for 4.3


Bugs: CLOUDSTACK-5160
https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Repository: cloudstack-git


Description
---

use a map to specify the custom parameters in the deployvm api Instead of one 
parameter for each.

https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Diffs (updated)
-

  api/src/com/cloud/vm/UserVmService.java 6fc8b54 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 
  
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
 ad957d5 
  
engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java
 8c58227 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4e25493 
  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
 5dd15ce 
  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 71e8b7d 
  server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c 

Diff: https://reviews.apache.org/r/15875/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/
---

(Updated Dec. 3, 2013, 8:52 a.m.)


Review request for cloudstack, Jayapal Reddy and Koushik Das.


Bugs: CLOUDSTACK-5160
https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Repository: cloudstack-git


Description
---

use a map to specify the custom parameters in the deployvm api Instead of one 
parameter for each.

https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Diffs (updated)
-

  api/src/com/cloud/vm/UserVmService.java ac14da7 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java f075082 
  engine/schema/src/com/cloud/event/UsageEventVO.java 2278103 
  server/src/com/cloud/vm/UserVmManagerImpl.java d3dd356 

Diff: https://reviews.apache.org/r/15875/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

> On Nov. 27, 2013, 12:56 p.m., daan Hoogland wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 2724
> > 
> >
> > Is there a guarantee that the parameter is castable to Long?

sorry for the delay in reply, was working on another patch.

This will throw a number format exception if the rootdkisk size value is not a 
number. fixed this by using a parser in NumberUtils.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29485
---


On Dec. 3, 2013, 6:20 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Dec. 3, 2013, 6:20 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java ac14da7 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java f075082 
>   server/src/com/cloud/vm/UserVmManagerImpl.java d3dd356 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/
---

(Updated Dec. 3, 2013, 6:20 a.m.)


Review request for cloudstack, Jayapal Reddy and Koushik Das.


Changes
---

Incorporated a review comment and rebased with master.


Bugs: CLOUDSTACK-5160
https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Repository: cloudstack-git


Description
---

use a map to specify the custom parameters in the deployvm api Instead of one 
parameter for each.

https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Diffs (updated)
-

  api/src/com/cloud/vm/UserVmService.java ac14da7 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java f075082 
  server/src/com/cloud/vm/UserVmManagerImpl.java d3dd356 

Diff: https://reviews.apache.org/r/15875/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29485
---



server/src/com/cloud/vm/UserVmManagerImpl.java


Is there a guarantee that the parameter is castable to Long?


- daan Hoogland


On Nov. 27, 2013, 11:12 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Nov. 27, 2013, 11:12 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 444c47a 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java 67fea00 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/
---

Review request for cloudstack, Jayapal Reddy and Koushik Das.


Bugs: CLOUDSTACK-5160
https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Repository: cloudstack-git


Description
---

use a map to specify the custom parameters in the deployvm api Instead of one 
parameter for each.

https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Diffs
-

  api/src/com/cloud/vm/UserVmService.java 444c47a 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e 
  engine/schema/src/com/cloud/service/ServiceOfferingVO.java 67fea00 
  server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 

Diff: https://reviews.apache.org/r/15875/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar