[GitHub] cloudstack-docs pull request: Update host-allocation.xml
Github user phillipkent closed the pull request at: https://github.com/apache/cloudstack-docs/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: modify description for name parameter in ...
GitHub user phillipkent opened a pull request: https://github.com/apache/cloudstack/pull/98 modify description for name parameter in ListVMsCmd.java The name parameter causes a substring match, not an exact match, which needs to be documented. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phillipkent/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit d4523c577813b9c21df55bd18776bee6ad872588 Author: Phillip Kent Date: 2015-03-05T12:30:26Z modify description for name parameter in ListVMsCmd.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: fix to file /en-US/host-allocation.x...
GitHub user phillipkent opened a pull request: https://github.com/apache/cloudstack-docs/pull/10 fix to file /en-US/host-allocation.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/phillipkent/cloudstack-docs fix-file-host-allocation-xml Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 5abcfc26b96efd9c3da4e536c5437bee6da424fb Author: Phillip Kent Date: 2015-03-05T12:53:21Z fix to file /en-US/host-allocation.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: fix to file /en-US/host-allocation.x...
Github user phillipkent closed the pull request at: https://github.com/apache/cloudstack-docs/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: fix to file /en-US/host-allocation.x...
Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-docs/pull/10#issuecomment-77360266 Sorry, I realised I was looking in the wrong place. The fix was already done, so closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Update requester.py
GitHub user phillipkent opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11 Update requester.py urllib.quote_plus() requires the option safe="*" (that is, the * character is not encoded) to be consistent with CloudStack's internal encoder/decoder. Without this, API calls containing the * character will fail API authentication. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phillipkent/cloudstack-cloudmonkey fix_urllib_quote_plus Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-cloudmonkey/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 46b84a6ef713f939ce03b5e613d133ddbc70338f Author: Phillip Kent Date: 2015-12-19T15:47:56Z Update requester.py urllib.quote_plus() requires the option safe="*" (that is, the * character is not encoded) to be consistent with CloudStack's internal encoder/decoder. Without this, API calls containing the * character will fail API authentication. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Update requester.py
Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-170278540 @bhaisaab The commands that I tested were to set or modify the displaytext/displayname for a network or virtual machine, such as " update network id=x displaytext='*test* " . I need to try your example and check that I understand what is going on. I do accept that * is not a very likely symbol to use, however it should work with breaking anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Update requester.py
Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-171242939 @bhaisaab I tested a clean virtualenv install of Cloudmonkey 5.3.2 (from PyPy) and also a clone of the latest Cloudmonkey from github (Python version is 2.7.6). Both of those give me authentication failure when passing a '*' in the command string. The endpoint I am testing is CloudPlatform 4.3.2 (with customisations). Can it be an issue for v4.3.2 but not in later version? I will investigate further and try to diagnose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Update requester.py
Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-206907782 @bhaisaab : Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: Add note in dev.rst about use of the...
GitHub user phillipkent opened a pull request: https://github.com/apache/cloudstack-docs/pull/17 Add note in dev.rst about use of the safe option in urllib.quote_plus() There is a mismatch between the URL encoding behavior of Python and CloudStack's internal URL encoder (Java URLEncoder): Python encodes * (asterisk) characters, while Java does not. When an API call contains a * character, an authentication failure will occur because the computed signatures will not agree. The solution is to add the option "safe = '*'" to Python's urllib.quote_plus(). NOTE: I can only test this problem on CloudStack version 4.3.2 and I don't have access to later versions where the behavior might be different. But the issue was confirmed by @bhaisaab for Cloudmonkey (see https://github.com/apache/cloudstack-cloudmonkey/pull/11). You can merge this pull request into a Git repository by running: $ git pull https://github.com/phillipkent/cloudstack-docs dev_add_urllib_safe_option Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 152589eb15ec87167472b3d1f340445d87e66a7a Author: Phillip Kent Date: 2016-04-08T12:30:28Z Add note in dev.rst about use of the safe option in Python urllib.quote_plus() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: Add note in dev.rst about use of the...
Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-docs/pull/17#issuecomment-207598302 @bhaisaab Just to clarify, the problem isn't when * is between other characters, it is a * anywhere in the request URL which will lead to disagreement of the signatures when CS attempts to validate the incoming API request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: fix bug in using readline in ...
GitHub user phillipkent opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/13 fix bug in using readline in Windows I found a bug with use of 'readline' for Python 2.7 on Windows 7. Cloudmonkey fails to run with this error: File âc:\python27\lib\site-packages\cloudmonkey\cloudmonkey.pyâ line 70 module> If âlibeditâ in readline.__doc__ TypeError: argument of type âNoneTypeâ is not iterable It requires modification of cloudmonkey.py at line 70. The error and fix are the same as reported here: http://bugs.python.org/issue18852 https://hg.python.org/cpython/rev/3070fdd58645 Note: I haven't tested this for Cloudmonkey in other Windows versions, or other Python versions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phillipkent/cloudstack-cloudmonkey fix_bug_windows_readline Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-cloudmonkey/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 3d9d7795cdc9e3337a3493f2f370d801c4b4b96b Author: Phillip Kent Date: 2016-04-26T10:21:01Z fix bug in using readline in Windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
