Re: [IMP] Code Freeze (was: End of code freeze)
Carsten Ziegeler wrote:
Joerg Heinicke wrote:
snip/
Shame on all of us ;) Maybe we all have to stand a beer to
Carsten at next CocoonGetTogether as the release is rescued.
Yes, yes, yes! Hmm, let me think, we will have approx. 150 attendees
for two days, that makes 75 beers for me per day. I think, that's ok.
Really? You will have to drink them *all*!
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Orixo, the opensource XML business alliance - http://www.orixo.com
RE: [IMP] Code Freeze (was: End of code freeze)
Sylvain Wallez wrote: Carsten Ziegeler wrote: Joerg Heinicke wrote: snip/ Shame on all of us ;) Maybe we all have to stand a beer to Carsten at next CocoonGetTogether as the release is rescued. Yes, yes, yes! Hmm, let me think, we will have approx. 150 attendees for two days, that makes 75 beers for me per day. I think, that's ok. Really? You will have to drink them *all*! Yes, I know. A day has 24 hours with 60 minutes each hour, this makes ..ehm...1440 minutes. So I have to drink a beer approx. every...uhmm.. 19 minutes. Ok, this makes me think: do we talk about 0.3l or 0.5l ? This would either be 22,5l or 35,5l. Now, I don't see a problem with the alcohol contained in this amount, but I fear I'm not able to drink more than 8 litres of any fluid a day. Damn! So, what do you think about an auction of the beer? Carsten
[IMP] Code Freeze (was: End of code freeze)
To increase the confusion :) I think we should stick to the code freeze as I see the chance for a release tomorrow. As far as I see it, we have the vetos from Reinhard and Joerg (Vadim revoked), and it seems that these vetos stand and fall with the memory leak bug, so all we have to do is: fix the bug, revoke the vetos, do the release. I just committed a fix for the bug which imho should work. So we only need one to cross-check this. (I really start to like calling out code freeze, end of code freeze and repeating this over and over again) Carsten
RE: [IMP] Code Freeze (was: End of code freeze)
Yeah, the confusion with the memory bug was partly due to me. After your original fix that still had a problem with the reader I introduced the bug again when I tried to fix that. I agree that your latest fix should definitely work. In fact I took the opertunity to install anteater and whereas before I could run the test script for this bug 4300 times before memory creeped up to 115MB I am now at iteration number 5500 and seeing a stable 50MB's. I haven't yet voted, but +1 for releasing! Unico Carsten Ziegeler wrote: To increase the confusion :) I think we should stick to the code freeze as I see the chance for a release tomorrow. As far as I see it, we have the vetos from Reinhard and Joerg (Vadim revoked), and it seems that these vetos stand and fall with the memory leak bug, so all we have to do is: fix the bug, revoke the vetos, do the release. I just committed a fix for the bug which imho should work. So we only need one to cross-check this. (I really start to like calling out code freeze, end of code freeze and repeating this over and over again) Carsten
RE: [IMP] Code Freeze (was: End of code freeze)
Unico Hommes wrote: Yeah, the confusion with the memory bug was partly due to me. After your original fix that still had a problem with the reader I introduced the bug again when I tried to fix that. I agree that your latest fix should definitely work. In fact I took the opertunity to install anteater and whereas before I could run the test script for this bug 4300 times before memory creeped up to 115MB I am now at iteration number 5500 and seeing a stable 50MB's. I haven't yet voted, but +1 for releasing! Thanks Unico for the info! So, Reinhard and Joerg, what do you think? Carsten Carsten Ziegeler wrote: To increase the confusion :) I think we should stick to the code freeze as I see the chance for a release tomorrow. As far as I see it, we have the vetos from Reinhard and Joerg (Vadim revoked), and it seems that these vetos stand and fall with the memory leak bug, so all we have to do is: fix the bug, revoke the vetos, do the release. I just committed a fix for the bug which imho should work. So we only need one to cross-check this. (I really start to like calling out code freeze, end of code freeze and repeating this over and over again) Carsten
Re: [IMP] Code Freeze (was: End of code freeze)
Sorry to butt in guys :) But I was wondering if anyone could commit the patch for bug 26854 (Flow redirecting) http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26854 I am pretty sure it will fix 26571, and maybe 25437 and 22132. I am cvs illiterate, and can't figure out how to patch my own copy here :( (I am only yapping cause i got all excited when it looked like the release was going to be postphoned) JD Carsten Ziegeler wrote: Unico Hommes wrote: Yeah, the confusion with the memory bug was partly due to me. After your original fix that still had a problem with the reader I introduced the bug again when I tried to fix that. I agree that your latest fix should definitely work. In fact I took the opertunity to install anteater and whereas before I could run the test script for this bug 4300 times before memory creeped up to 115MB I am now at iteration number 5500 and seeing a stable 50MB's. I haven't yet voted, but +1 for releasing! Thanks Unico for the info! So, Reinhard and Joerg, what do you think? Carsten Carsten Ziegeler wrote: To increase the confusion :) I think we should stick to the code freeze as I see the chance for a release tomorrow. As far as I see it, we have the vetos from Reinhard and Joerg (Vadim revoked), and it seems that these vetos stand and fall with the memory leak bug, so all we have to do is: fix the bug, revoke the vetos, do the release. I just committed a fix for the bug which imho should work. So we only need one to cross-check this. (I really start to like calling out code freeze, end of code freeze and repeating this over and over again) Carsten
Re: [IMP] Code Freeze (was: End of code freeze)
Le Mercredi, 11 fév 2004, à 16:11 Europe/Zurich, Carsten Ziegeler a écrit : To increase the confusion :) I think we should stick to the code freeze as I see the chance for a release tomorrow... A release would be good as it looks like all known blockers are gone. FYI I cannot help integrating the patch for bug 26753 before the end of this week, but if someone can do it I'll find some time to try my test scenario again (as per my bugzilla comment 2004-02-09 10:42). ...(I really start to like calling out code freeze, end of code freeze and repeating this over and over again) Could make a cool game: If someone says Carsten says code freeze - everybody throws their hands in the air If some says only code freeze - don't throw your hands in the air. And you loose if you don't do this right. We'll try this at the next GetTogether ;-) -Bertrand
Re: [IMP] Code Freeze (was: End of code freeze)
On Wed, Feb 11, 2004 at 04:50:57PM +0100, Carsten Ziegeler wrote: Unico Hommes wrote: Yeah, the confusion with the memory bug was partly due to me. After your original fix that still had a problem with the reader I introduced the bug again when I tried to fix that. I agree that your latest fix should definitely work. In fact I took the opertunity to install anteater and whereas before I could run the test script for this bug 4300 times before memory creeped up to 115MB I am now at iteration number 5500 and seeing a stable 50MB's. I haven't yet voted, but +1 for releasing! Thanks Unico for the info! So, Reinhard and Joerg, what do you think? Carsten These are the bugs that are still open against the release: 25203 SQLTransformer: duplicate namespace declaration when serializing XML 26186 Memory Leak caused by cocoon:// protocol 26751 Cocoon gets web-app_2_2.dtd from flres.java.Sun.COM at startup 26753 [PATCH] Persistent store or cache corruption? With the fix/unfix cycles, I am not completely sure what their status is now. Would you please clarify the up-to-the-minute status of each? --Tim Larson
Re: [IMP] Code Freeze (was: End of code freeze)
On 11 Feb 2004, at 17:10, Bertrand Delacretaz wrote: We'll try this at the next GetTogether ;-) Don't tempt me into thinking about the new edition already - I still want to get something else done this year as well. ;-) /Steven -- Steven Noelshttp://outerthought.org/ Outerthought - Open Source Java XMLAn Orixo Member Read my weblog athttp://blogs.cocoondev.org/stevenn/ stevenn at outerthought.orgstevenn at apache.org
Re: [IMP] Code Freeze (was: End of code freeze)
These are the bugs that are still open against the release: 25203 SQLTransformer: duplicate namespace declaration when serializing XML 26186 Memory Leak caused by cocoon:// protocol 26751 Cocoon gets web-app_2_2.dtd from flres.java.Sun.COM at startup 26753 [PATCH] Persistent store or cache corruption? Is there any reason why 25887 [PATCH] Fix for caching of nested aggregations is not in this list? Not sure why it was never reviewed but it's a fairly straightforward bug to reproduce. Jorg
RE: [IMP] Code Freeze (was: End of code freeze)
I have been eyeing it :-) because I think it is a major bug as well. But I decided that I knew too little about the consequences of your fix to apply it so shortly before the release. So, unless another committer is willing to take the risk I would suggest we postpone this one until after the release. Unico JD Daniels wrote: Sorry to butt in guys :) But I was wondering if anyone could commit the patch for bug 26854 (Flow redirecting) http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26854 I am pretty sure it will fix 26571, and maybe 25437 and 22132. I am cvs illiterate, and can't figure out how to patch my own copy here :( (I am only yapping cause i got all excited when it looked like the release was going to be postphoned) JD Carsten Ziegeler wrote: Unico Hommes wrote: Yeah, the confusion with the memory bug was partly due to me. After your original fix that still had a problem with the reader I introduced the bug again when I tried to fix that. I agree that your latest fix should definitely work. In fact I took the opertunity to install anteater and whereas before I could run the test script for this bug 4300 times before memory creeped up to 115MB I am now at iteration number 5500 and seeing a stable 50MB's. I haven't yet voted, but +1 for releasing! Thanks Unico for the info! So, Reinhard and Joerg, what do you think? Carsten Carsten Ziegeler wrote: To increase the confusion :) I think we should stick to the code freeze as I see the chance for a release tomorrow. As far as I see it, we have the vetos from Reinhard and Joerg (Vadim revoked), and it seems that these vetos stand and fall with the memory leak bug, so all we have to do is: fix the bug, revoke the vetos, do the release. I just committed a fix for the bug which imho should work. So we only need one to cross-check this. (I really start to like calling out code freeze, end of code freeze and repeating this over and over again) Carsten
Re: [IMP] Code Freeze (was: End of code freeze)
Bertrand Delacretaz wrote:
Le Mercredi, 11 fév 2004, à 16:11 Europe/Zurich, Carsten Ziegeler a
écrit :
To increase the confusion :) I think we should stick to the code
freeze as I
see the chance for a release tomorrow...
A release would be good as it looks like all known blockers are gone.
FYI I cannot help integrating the patch for bug 26753 before the end
of this week, but if someone can do it I'll find some time to try my
test scenario again (as per my bugzilla comment 2004-02-09 10:42).
...(I really start to like calling out code freeze, end of code
freeze and
repeating this over and over again)
Could make a cool game:
If someone says Carsten says code freeze - everybody throws their
hands in the air
If some says only code freeze - don't throw your hands in the air.
And you loose if you don't do this right.
We'll try this at the next GetTogether ;-)
Bertrand explains a well known child group game in french-speaking
countries which is names Jacques a dit, which translates to Jack
said: you must do what follows Jacques a dit, but must absolutely no
do it otherwise. If you fail to do it right, you quit the game.
Now about the code freeze / unfreeze / refreeze / release, I let you
decide as I'm currently too swamped to follow closely the flow.
This makes me think: we could use continuations to model what's
currently going on here ;-)
function release() {
var codeFreeze = cocoon.createContinuation();
fixBugs(bugzilla);
if (bugzilla.openBugs() != null) {
// restart
codeFreeze(codeFreeze);
}
makeDistro();
}
Sylvain (obviously ousing continuations too much)
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Orixo, the opensource XML business alliance - http://www.orixo.com
Re: [IMP] Code Freeze (was: End of code freeze)
Le Mercredi, 11 fév 2004, à 17:37 Europe/Zurich, Sylvain Wallez a écrit : ...I let you decide as I'm currently too swamped to follow closely the flow... What, Sylvain not following the flow? I thought you were a Flow expert ;-) -Bertrand
Re: [IMP] Code Freeze (was: End of code freeze)
Sylvain Wallez wrote:
Bertrand Delacretaz wrote:
Le Mercredi, 11 fév 2004, à 16:11 Europe/Zurich, Carsten Ziegeler a
écrit :
To increase the confusion :) I think we should stick to the code
freeze as I
see the chance for a release tomorrow...
A release would be good as it looks like all known blockers are gone.
FYI I cannot help integrating the patch for bug 26753 before the end
of this week, but if someone can do it I'll find some time to try my
test scenario again (as per my bugzilla comment 2004-02-09 10:42).
...(I really start to like calling out code freeze, end of code
freeze and
repeating this over and over again)
Could make a cool game:
If someone says Carsten says code freeze - everybody throws their
hands in the air
If some says only code freeze - don't throw your hands in the air.
And you loose if you don't do this right.
We'll try this at the next GetTogether ;-)
Bertrand explains a well known child group game in french-speaking
countries which is names Jacques a dit, which translates to Jack
said: you must do what follows Jacques a dit, but must absolutely
no do it otherwise. If you fail to do it right, you quit the game.
Now about the code freeze / unfreeze / refreeze / release, I let you
decide as I'm currently too swamped to follow closely the flow.
This makes me think: we could use continuations to model what's
currently going on here ;-)
function release() {
var codeFreeze = cocoon.createContinuation();
fixBugs(bugzilla);
if (bugzilla.openBugs() != null) {
// restart
codeFreeze(codeFreeze);
}
makeDistro();
}
Sylvain (obviously ousing continuations too much)
Arf.
I guess it is cocoon.createWebContinuation(), isn't it ?
I say that because you explained it to me this afternoon (GMT+1) on the
white board in front of us.
(I found it funny to discuss here when we are standing next to each
other in the same room !)
Jacques a dit : finissons notre boulot au lieu de pêter un plomb sur la
mailing-liste ! (I don't know the translation for that)
.Thibs.
RE: [IMP] Code Freeze (was: End of code freeze)
Memory Leak has gone. Regards, Michael -- GMX ProMail (250 MB Mailbox, 50 FreeSMS, Virenschutz, 2,99 EUR/Monat...) jetzt 3 Monate GRATIS + 3x DER SPIEGEL +++ http://www.gmx.net/derspiegel +++
[OT] Re: [IMP] Code Freeze (was: End of code freeze)
[this is really off-topic now]
Thibault Cantegrel wrote:
Sylvain Wallez wrote:
snip/
Bertrand explains a well known child group game in french-speaking
countries which is names Jacques a dit, which translates to Jack
said: you must do what follows Jacques a dit, but must absolutely
no do it otherwise. If you fail to do it right, you quit the game.
Now about the code freeze / unfreeze / refreeze / release, I let you
decide as I'm currently too swamped to follow closely the flow.
This makes me think: we could use continuations to model what's
currently going on here ;-)
function release() {
var codeFreeze = cocoon.createContinuation();
fixBugs(bugzilla);
if (bugzilla.openBugs() != null) {
// restart
codeFreeze(codeFreeze);
}
makeDistro();
}
Sylvain (obviously ousing continuations too much)
Arf.
I guess it is cocoon.createWebContinuation(), isn't it ?
I say that because you explained it to me this afternoon (GMT+1) on
the white board in front of us.
(I found it funny to discuss here when we are standing next to each
other in the same room !)
Jacques a dit : finissons notre boulot au lieu de pêter un plomb sur
la mailing-liste ! (I don't know the translation for that)
Thibault, this is a very bad practice to write things that other people
can't understand. So here it is: let's finish our work instead of
writing silly things on the mailing list (more familiar words are used,
though).
Hey, why so? Welcome to the Cocooners' friendly chat room ;-P
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Orixo, the opensource XML business alliance - http://www.orixo.com
[OT] Re: [IMP] Code Freeze (was: End of code freeze)
Bertrand Delacretaz wrote:
Le Mercredi, 11 fév 2004, à 17:37 Europe/Zurich, Sylvain Wallez a écrit :
...I let you decide as I'm currently too swamped to follow closely
the flow...
What, Sylvain not following the flow? I thought you were a Flow expert
;-)
Actually, I meant flood. Now, notice how you make a difference between
flow and Flow. These are obviously different words ;-)
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Orixo, the opensource XML business alliance - http://www.orixo.com
Re: [OT] Re: [IMP] Code Freeze (was: End of code freeze)
Sylvain Wallez wrote:
[this is really off-topic now]
Thibault Cantegrel wrote:
Sylvain Wallez wrote:
snip/
Bertrand explains a well known child group game in french-speaking
countries which is names Jacques a dit, which translates to Jack
said: you must do what follows Jacques a dit, but must absolutely
no do it otherwise. If you fail to do it right, you quit the game.
By the way, in our part of the world, this is called Simon says. No
idea who Simon is.
Geoff
Now about the code freeze / unfreeze / refreeze / release, I let you
decide as I'm currently too swamped to follow closely the flow.
This makes me think: we could use continuations to model what's
currently going on here ;-)
function release() {
var codeFreeze = cocoon.createContinuation();
fixBugs(bugzilla);
if (bugzilla.openBugs() != null) {
// restart
codeFreeze(codeFreeze);
}
makeDistro();
}
Sylvain (obviously ousing continuations too much)
Arf.
I guess it is cocoon.createWebContinuation(), isn't it ?
I say that because you explained it to me this afternoon (GMT+1) on
the white board in front of us.
(I found it funny to discuss here when we are standing next to each
other in the same room !)
Jacques a dit : finissons notre boulot au lieu de pêter un plomb sur
la mailing-liste ! (I don't know the translation for that)
Thibault, this is a very bad practice to write things that other people
can't understand. So here it is: let's finish our work instead of
writing silly things on the mailing list (more familiar words are used,
though).
Hey, why so? Welcome to the Cocooners' friendly chat room ;-P
Sylvain
RE: [IMP] Code Freeze (was: End of code freeze)
I'm a little unclear. Is the code frozen or melting? Will there be a release this week? I hope so. I really want to pick up 2.1.4 for our development. Ralph
Re: [IMP] Code Freeze (was: End of code freeze)
On 11.02.2004 16:42, Unico Hommes wrote:
Yeah, the confusion with the memory bug was partly due to me. After your
original fix that still had a problem with the reader I introduced the
bug again when I tried to fix that.
So the lastconsumer null test really works, you only broke it with your
reader fix. I guess you have to stand a beer to Carsten :)
And we all have not reviewed the patch correctly as the problem is obvious:
if (lc == null) {
lc = anObject;
}
if (lc != null) {
//always true
//executing code introducing memory leak in special cases
}
Shame on all of us ;) Maybe we all have to stand a beer to Carsten at
next CocoonGetTogether as the release is rescued.
Joerg
RE: [IMP] Code Freeze (was: End of code freeze)
Joerg Heinicke wrote:
On 11.02.2004 16:42, Unico Hommes wrote:
Yeah, the confusion with the memory bug was partly due to me. After
your original fix that still had a problem with the reader I
introduced the bug again when I tried to fix that.
So the lastconsumer null test really works, you only broke it
with your
reader fix. I guess you have to stand a beer to Carsten :)
And we all have not reviewed the patch correctly as the
problem is obvious:
if (lc == null) {
lc = anObject;
}
if (lc != null) {
//always true
//executing code introducing memory leak in special cases
}
Exactly it. I have to plead guilty. It's not too bad though, I'd gladly
buy Carsten a beer :-D
Unico
RE: [OT] Re: [IMP] Code Freeze (was: End of code freeze)
Geoff Howard wrote: Sylvain Wallez wrote: [this is really off-topic now] Thibault Cantegrel wrote: Sylvain Wallez wrote: snip/ Bertrand explains a well known child group game in french-speaking countries which is names Jacques a dit, which translates to Jack said: you must do what follows Jacques a dit, but must absolutely no do it otherwise. If you fail to do it right, you quit the game. By the way, in our part of the world, this is called Simon says. No idea who Simon is. And the dutch would say about that Joost mag het weten (Only Joost knows or more freely God only knows, not implying Joost is God of course, any Joost that is) Joost is just somebody's first name, nobody knows who exactly. Kinda like Simon or God really. Uhm, perhaps I should shut up now ;-) Unico
RE: [OT] Re: [IMP] Code Freeze (was: End of code freeze)
By the way, in our part of the world, this is called Simon says. No idea who Simon is. And the dutch would say about that Joost mag het weten (Only Joost knows or more freely God only knows, not implying Joost is God of course, any Joost that is) Joost is just somebody's first name, nobody knows who exactly. Kinda like Simon or God really. Uhm, perhaps I should shut up now ;-) If I'm right we Dutch would call the game alle vogels vliegen (all birds fly and then start replacing the animal and the behaviour). Ok, it's late here too and I finally made a teeny weeny bit of progression after a week of troubles. Bye, Helma
RE: [IMP] Code Freeze (was: End of code freeze)
Joerg Heinicke wrote:
Yeah, the confusion with the memory bug was partly due to me. After
your original fix that still had a problem with the reader I
introduced the bug again when I tried to fix that.
So the lastconsumer null test really works, you only broke it
with your reader fix. I guess you have to stand a beer to Carsten :)
Yuppi!
And we all have not reviewed the patch correctly as the
problem is obvious:
if (lc == null) {
lc = anObject;
}
if (lc != null) {
//always true
//executing code introducing memory leak in special cases }
Shame on all of us ;) Maybe we all have to stand a beer to
Carsten at next CocoonGetTogether as the release is rescued.
Yes, yes, yes! Hmm, let me think, we will have approx. 150 attendees
for two days, that makes 75 beers for me per day. I think, that's ok.
So, +1 Joerg :)
Carsten
RE: [IMP] Code Freeze (was: End of code freeze)
Unico Hommes wrote: Exactly it. I have to plead guilty. It's not too bad though, I'd gladly buy Carsten a beer :-D Actually this was a nice one. I had to look more than twice to see that as well :) But, I just noted down the beer so I won't forget it :) Carsten
