[jira] Commented: (COCOON-1758) Form locale never used in JXMacros
[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12428388
]
Marc Portier commented on COCOON-1758:
--
Adding the svn-update references to ease tracking:
http://svn.apache.org/viewvc?view=revrevision=427436
http://svn.apache.org/viewvc?view=revrevision=430438
Form locale never used in JXMacros
--
Key: COCOON-1758
URL: http://issues.apache.org/jira/browse/COCOON-1758
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
Reporter: Philippe Gassmann
Assigned To: Antonio Gallardo
Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
The JXMacroHelper is created with : jx:set var=cformsHelper
value=#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}/
So the locale is get from sitemap parameters.
the locale attribute of the form is then never used.
I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1758) Form locale never used in JXMacros
[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427261
]
Simone Gianni commented on COCOON-1758:
---
The code in jx-macros actually calls cocoon.parameter.getParameter('locale').
Unfortunately, if a locale is not specified, this brings to an exception, since
a default value is not given.
This beaks compatibility with previous 2.1 versions, and in general IMMO having
to specify explicitly a local for every form template is verbose.
I think this should be substituted with getParameter('locale',null), and
subseguently in the JXMacrosHelper the given locale must be used, if present,
otherwise the request one, otherwise the default one.
I have this fix on my version, but wanted to know if this is the intended
behaviour before committing.
Form locale never used in JXMacros
--
Key: COCOON-1758
URL: http://issues.apache.org/jira/browse/COCOON-1758
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
Reporter: Philippe Gassmann
Assigned To: Antonio Gallardo
Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
The JXMacroHelper is created with : jx:set var=cformsHelper
value=#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}/
So the locale is get from sitemap parameters.
the locale attribute of the form is then never used.
I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1758) Form locale never used in JXMacros
[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427267
]
Antonio Gallardo commented on COCOON-1758:
--
Thanks for the feedback Simone. You are fully right. I reviewed the Carlos
patch against the repository and is not the same. I recall I did some tests
before committing to checking if this is working as expected. After testing,
for some reason I forgot to revert my test changes. In short:
I bad commit was:
cocoon.parameters.getParameter('locale')
and patch reads:
cocoon.parameters.getParameter('locale','')
(please note the empty string as default value.
I am going to commit the fix to the fix, right now. :-)
Thanks again for spotting the issue.
Form locale never used in JXMacros
--
Key: COCOON-1758
URL: http://issues.apache.org/jira/browse/COCOON-1758
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
Reporter: Philippe Gassmann
Assigned To: Antonio Gallardo
Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
The JXMacroHelper is created with : jx:set var=cformsHelper
value=#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}/
So the locale is get from sitemap parameters.
the locale attribute of the form is then never used.
I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1758) Form locale never used in JXMacros
[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427268
]
Antonio Gallardo commented on COCOON-1758:
--
The fix is now on the repository. Please cross check if this works. Thanks
again for spotting the error.
Form locale never used in JXMacros
--
Key: COCOON-1758
URL: http://issues.apache.org/jira/browse/COCOON-1758
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
Reporter: Philippe Gassmann
Assigned To: Antonio Gallardo
Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
The JXMacroHelper is created with : jx:set var=cformsHelper
value=#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}/
So the locale is get from sitemap parameters.
the locale attribute of the form is then never used.
I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1758) Form locale never used in JXMacros
[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12367199
]
Philippe Gassmann commented on COCOON-1758:
---
Your patch does not solve the problem ; I think the management of locale in
forms has to be deeply refactored
Form locale never used in JXMacros
--
Key: COCOON-1758
URL: http://issues.apache.org/jira/browse/COCOON-1758
Project: Cocoon
Type: Bug
Components: Blocks: Forms
Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
Reporter: Philippe Gassmann
Assignee: Jean-Baptiste Quenot
Attachments: 20060201-cocoon-forms-1758
The JXMacroHelper is created with : jx:set var=cformsHelper
value=#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}/
So the locale is get from sitemap parameters.
the locale attribute of the form is then never used.
I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1758) Form locale never used in JXMacros
[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12367201
]
Philippe Gassmann commented on COCOON-1758:
---
I will try to provide a patch ASAP.
Form locale never used in JXMacros
--
Key: COCOON-1758
URL: http://issues.apache.org/jira/browse/COCOON-1758
Project: Cocoon
Type: Bug
Components: Blocks: Forms
Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
Reporter: Philippe Gassmann
Assignee: Jean-Baptiste Quenot
Attachments: 20060201-cocoon-forms-1758
The JXMacroHelper is created with : jx:set var=cformsHelper
value=#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}/
So the locale is get from sitemap parameters.
the locale attribute of the form is then never used.
I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
