RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-06 Thread Carsten Ziegeler
Unico Hommes wrote
> 
> There are currently two related anteater test cases that don't pass:
> 
> The first one shows that calling a flow function that does 
> not cause any redirection is not an error, which it should IIRC.
> 
> redirect.xml:57: Starting
> http://localhost:///samples/test/redirect/donothing-from-flow
> redirect.xml:59: Running test [ResponseCode: 404]
> Failure: expected response code '404', got 'HTTP/1.1 200 OK'
> 
> The second one is that doing a map:redirect-to in a pipeline 
> that is called from flow with sendPage does not work.
> 
> bug26571SendPageRedirectTo.xml:33: Starting 
> http://localhost:///samples/test/sendpage-redirect/test-bad
> bug26571SendPageRedirectTo.xml:35: Running test [ResponseCode: 302]
> Failure: expected response code '302', got 'HTTP/1.1 200 OK'
> 
I just run them with 2.1.5 and both fail there as well :( At least
the new code is not worse than the one from 2.1.x :)
Anyways, yes, we should try to fix this. Thanks!

Carsten



Re: [CVS] Flow bug in redirections? Test case inside.

2004-06-05 Thread Unico Hommes
Carsten Ziegeler  s-und-n.de> writes:

> 
> Antonio Gallardo wrote:
> > 
> > Hi Carsten:
> > 
> > It works now! Many thanks!
> > 
> > I think another beer is on the way. Perhaps with this the 
> > count reach 3! :-D
> > 
> > PS: Antonio started to think seriously to open a bank account 
> > to store money to buy Carsten beers. 
> > 
> Great idea! What about a PayPal account were people can make donations?
> 
> Ok, let's get serious again: are there any other problems with internal
> pipeline calls or redirects?
> 

There are currently two related anteater test cases that don't pass:

The first one shows that calling a flow function that does not cause any
redirection is not an error, which it should IIRC.

redirect.xml:57: Starting
http://localhost:///samples/test/redirect/donothing-from-flow
redirect.xml:59: Running test [ResponseCode: 404]
Failure: expected response code '404', got 'HTTP/1.1 200 OK'

The second one is that doing a map:redirect-to in a pipeline that is called from
flow with sendPage does not work.

bug26571SendPageRedirectTo.xml:33: Starting
http://localhost:///samples/test/sendpage-redirect/test-bad
bug26571SendPageRedirectTo.xml:35: Running test [ResponseCode: 302]
Failure: expected response code '302', got 'HTTP/1.1 200 OK'

--
Unico



RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Carsten Ziegeler
Antonio Gallardo wrote:
> 
> Hi Carsten:
> 
> It works now! Many thanks!
> 
> I think another beer is on the way. Perhaps with this the 
> count reach 3! :-D
> 
> PS: Antonio started to think seriously to open a bank account 
> to store money to buy Carsten beers. ;-)
> 
Great idea! What about a PayPal account were people can make donations?

Ok, let's get serious again: are there any other problems with internal
pipeline calls or redirects?

Carsten



RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Antonio Gallardo
Hi Carsten:

It works now! Many thanks!

I think another beer is on the way. Perhaps with this the count reach 3! :-D

PS: Antonio started to think seriously to open a bank account to store
money to buy Carsten beers. ;-)

Best Regards,

Antonio Gallardo


RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Carsten Ziegeler
Should work now - please cross-check.

Thanks
Carsten 

> -Original Message-
> From: Antonio Gallardo [mailto:[EMAIL PROTECTED] 
> Sent: Friday, June 04, 2004 3:25 PM
> To: [EMAIL PROTECTED]
> Subject: RE: [CVS] Flow bug in redirections? Test case inside.
> 
> Carsten Ziegeler dijo:
> > Antonio Gallardo [mailto:[EMAIL PROTECTED]
> >>
> >> Hi:
> >>
> >> I setted this breakpoints:
> >>
> >> 1-o.a.c.components.flow.javascript.fom.FOM_Cocoon.java at line 261.
> >>
> >> 2-
> >> o.a.c.components.flow.javascript.fom.FOM_JavaScriptInterpreter
> >> .java at line 837
> >>
> >> 3-o.a.c.components.flow.AbstractInterpreter.java at line 171
> >>
> >> I posted the 3 breakpoints to draft the route the problem 
> follow. It 
> >> is a problem in the sendPage from Javaflow. I think, the last 
> >> breakpoint is the most important because until it all is OK.
> >>
> >> I wonder if the problem is in the hint we post store for the 
> >> redirector (3 file at line 179).
> >>
> > Hmm, this hint is in 2.1.5 as well, so as it worked there 
> for you, I 
> > think this is not the problem.
> > I think I found the problem it seems to be in the tree processor.
> > Give me some minutes to verify this.
> 
> Thanks!
> 
> BTW, I found a simpler test case:
> 
> 1- Replace line 171 in 
> cocoon-2.1/build/webapp/samples/flow/jxcalc/calc.js
> with:
> 
> var uri = "/samples/flow/jxcalc/page/getNumber" + name.toUpperCase();
> 
> It must work.
> 
> Best Regards,
> 
> Antonio Gallardo.
> 
> 



RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Antonio Gallardo
Carsten Ziegeler dijo:
> Antonio Gallardo [mailto:[EMAIL PROTECTED]
>>
>> Hi:
>>
>> I setted this breakpoints:
>>
>> 1-o.a.c.components.flow.javascript.fom.FOM_Cocoon.java at line 261.
>>
>> 2-
>> o.a.c.components.flow.javascript.fom.FOM_JavaScriptInterpreter
>> .java at line 837
>>
>> 3-o.a.c.components.flow.AbstractInterpreter.java at line 171
>>
>> I posted the 3 breakpoints to draft the route the problem
>> follow. It is a problem in the sendPage from Javaflow. I
>> think, the last breakpoint is the most important because
>> until it all is OK.
>>
>> I wonder if the problem is in the hint we post store for the
>> redirector (3 file at line 179).
>>
> Hmm, this hint is in 2.1.5 as well, so as it worked there for you,
> I think this is not the problem.
> I think I found the problem it seems to be in the tree processor.
> Give me some minutes to verify this.

Thanks!

BTW, I found a simpler test case:

1- Replace line 171 in cocoon-2.1/build/webapp/samples/flow/jxcalc/calc.js
with:

var uri = "/samples/flow/jxcalc/page/getNumber" + name.toUpperCase();

It must work.

Best Regards,

Antonio Gallardo.


RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Carsten Ziegeler
Antonio Gallardo [mailto:[EMAIL PROTECTED] 
> 
> Hi:
> 
> I setted this breakpoints:
> 
> 1-o.a.c.components.flow.javascript.fom.FOM_Cocoon.java at line 261.
> 
> 2- 
> o.a.c.components.flow.javascript.fom.FOM_JavaScriptInterpreter
> .java at line 837
> 
> 3-o.a.c.components.flow.AbstractInterpreter.java at line 171
> 
> I posted the 3 breakpoints to draft the route the problem 
> follow. It is a problem in the sendPage from Javaflow. I 
> think, the last breakpoint is the most important because 
> until it all is OK.
> 
> I wonder if the problem is in the hint we post store for the 
> redirector (3 file at line 179).
> 
Hmm, this hint is in 2.1.5 as well, so as it worked there for you,
I think this is not the problem. 
I think I found the problem it seems to be in the tree processor.
Give me some minutes to verify this.

Carsten



RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Antonio Gallardo
Hi:

I setted this breakpoints:

1-o.a.c.components.flow.javascript.fom.FOM_Cocoon.java at line 261.

2- o.a.c.components.flow.javascript.fom.FOM_JavaScriptInterpreter.java at
line 837

3-o.a.c.components.flow.AbstractInterpreter.java at line 171

I posted the 3 breakpoints to draft the route the problem follow. It is a
problem in the sendPage from Javaflow. I think, the last breakpoint is the
most important because until it all is OK.

I wonder if the problem is in the hint we post store for the redirector (3
file at line 179).

I choosed to don't touch nothing, because I don't know enough how it works
and I don't want to break other things around.

I hope this helps to discover the bug.

Best Regards,

Antonio Gallardo


Carsten Ziegeler dijo:
> Hi Antonio,
>
> just to be sure: did B to D work in 2.1.4/2.1.5 as you expect or
> do they produce they same error?
>
> Carsten
>
>> -Original Message-
>> From: Antonio Gallardo [mailto:[EMAIL PROTECTED]
>> Sent: Thursday, June 03, 2004 4:13 PM
>> To: [EMAIL PROTECTED]
>> Subject: [CVS] Flow bug in redirections? Test case inside.
>>
>> Hi:
>>
>> I have 2 days with this problem. Here is a test case of the
>> redirection problem in flow:
>>
>> 1-Build Cocoon with samples.
>> 2-Run ./cocoon.sh servlet
>> 3-Copy $COCOON_HOME/build/webapp/samples/flow to
>> $COCOON_HOME/build/webapp/samples/flowbug
>> (we need it because we will make a call from flowbug to flow.
>>
>> 4-Change line 38 in
>> $COCOON_HOME/build/webapp/samples/flowbug/jxcalc/calc.js to any of:
>>
>> A-var uri = "samples/flow/jxcalc/page/getNumber" +
>> name.toUpperCase(); B-var uri =
>> "/samples/flow/jxcalc/page/getNumber" + name.toUpperCase();
>> C-var uri = "//samples/flow/jxcalc/page/getNumber" +
>> name.toUpperCase(); D-var uri =
>> "///samples/flow/jxcalc/page/getNumber" + name.toUpperCase();
>>
>> 5- On a browser, connect to:
>>
>> http://localhost:/samples/flowbug/jxcalc/
>>
>> You will get:
>> --
>> A-No pipeline matched request:
>> samples/flowbug/jxcalc/samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> samples/flowbug/jxcalc/samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: It is OK. There does not exist in relative path.
>> --
>> B-No pipeline matched request: samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: Why? It must go to the redirection in flow directory
>> using the sitemap that is in flow dir!
>>
>> --
>> C-No pipeline matched request: /samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> /samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: Again, why? As above, the link exists!
>> --
>> D-No pipeline matched request: //samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> //samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: Again, why? As above, the link exists!
>> --
>>
>> It will never go to the requested path!
>>
>> If it works, it would be the same as:
>>
>> http://localhost:/samples/flow/jxcalc/page/getNumberA
>>
>> And we would need to receive a diferent error:
>>
>> org.apache.cocoon.ProcessingException: Failed to execute pipeline.:
>> file:/home/agallardo/workspace/cocoon-2.1/build/webapp/samples
>> /flow/jxcalc/screens/getNumberA.xml:30:72:org.apache.commons.j
>> xpath.JXPathException:
>> No value for xpath: $cocoon/continuation/id
>>
>> Now the question is what is affecting that?
>>
>> Best Regards,
>>
>> Antonio Gallardo
>>
>>
>



RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Antonio Gallardo
Carsten Ziegeler dijo:
> Hi Antonio,
>
> just to be sure: did B to D work in 2.1.4/2.1.5 as you expect or
> do they produce they same error?

I think yes. In our an application we have a similar model. We have shared
dialogs. The dialogs are called from others flows (similar as the sample).
Some days ago it works from the CVS, but know it does not work. BTW, we
don't touched nothing on the application. So it must work as expected.

Please see the problem I am going crazy with that. I guess the problem is
related to switching contexts. I will post more info soon.

Best Regards,

Antonio Gallardo

>
> Carsten
>
>> -Original Message-
>> From: Antonio Gallardo [mailto:[EMAIL PROTECTED]
>> Sent: Thursday, June 03, 2004 4:13 PM
>> To: [EMAIL PROTECTED]
>> Subject: [CVS] Flow bug in redirections? Test case inside.
>>
>> Hi:
>>
>> I have 2 days with this problem. Here is a test case of the
>> redirection problem in flow:
>>
>> 1-Build Cocoon with samples.
>> 2-Run ./cocoon.sh servlet
>> 3-Copy $COCOON_HOME/build/webapp/samples/flow to
>> $COCOON_HOME/build/webapp/samples/flowbug
>> (we need it because we will make a call from flowbug to flow.
>>
>> 4-Change line 38 in
>> $COCOON_HOME/build/webapp/samples/flowbug/jxcalc/calc.js to any of:
>>
>> A-var uri = "samples/flow/jxcalc/page/getNumber" +
>> name.toUpperCase(); B-var uri =
>> "/samples/flow/jxcalc/page/getNumber" + name.toUpperCase();
>> C-var uri = "//samples/flow/jxcalc/page/getNumber" +
>> name.toUpperCase(); D-var uri =
>> "///samples/flow/jxcalc/page/getNumber" + name.toUpperCase();
>>
>> 5- On a browser, connect to:
>>
>> http://localhost:/samples/flowbug/jxcalc/
>>
>> You will get:
>> --
>> A-No pipeline matched request:
>> samples/flowbug/jxcalc/samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> samples/flowbug/jxcalc/samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: It is OK. There does not exist in relative path.
>> --
>> B-No pipeline matched request: samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: Why? It must go to the redirection in flow directory
>> using the sitemap that is in flow dir!
>>
>> --
>> C-No pipeline matched request: /samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> /samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: Again, why? As above, the link exists!
>> --
>> D-No pipeline matched request: //samples/flow/jxcalc/page/getNumberA
>>
>> org.apache.cocoon.ResourceNotFoundException: No pipeline
>> matched request:
>> //samples/flow/jxcalc/page/getNumberA
>>
>> COMMENT: Again, why? As above, the link exists!
>> --
>>
>> It will never go to the requested path!
>>
>> If it works, it would be the same as:
>>
>> http://localhost:/samples/flow/jxcalc/page/getNumberA
>>
>> And we would need to receive a diferent error:
>>
>> org.apache.cocoon.ProcessingException: Failed to execute pipeline.:
>> file:/home/agallardo/workspace/cocoon-2.1/build/webapp/samples
>> /flow/jxcalc/screens/getNumberA.xml:30:72:org.apache.commons.j
>> xpath.JXPathException:
>> No value for xpath: $cocoon/continuation/id
>>
>> Now the question is what is affecting that?
>>
>> Best Regards,
>>
>> Antonio Gallardo
>>
>>
>



RE: [CVS] Flow bug in redirections? Test case inside.

2004-06-04 Thread Carsten Ziegeler
Hi Antonio,

just to be sure: did B to D work in 2.1.4/2.1.5 as you expect or
do they produce they same error?

Carsten 

> -Original Message-
> From: Antonio Gallardo [mailto:[EMAIL PROTECTED] 
> Sent: Thursday, June 03, 2004 4:13 PM
> To: [EMAIL PROTECTED]
> Subject: [CVS] Flow bug in redirections? Test case inside.
> 
> Hi:
> 
> I have 2 days with this problem. Here is a test case of the 
> redirection problem in flow:
> 
> 1-Build Cocoon with samples.
> 2-Run ./cocoon.sh servlet
> 3-Copy $COCOON_HOME/build/webapp/samples/flow to 
> $COCOON_HOME/build/webapp/samples/flowbug
> (we need it because we will make a call from flowbug to flow.
> 
> 4-Change line 38 in
> $COCOON_HOME/build/webapp/samples/flowbug/jxcalc/calc.js to any of:
> 
> A-var uri = "samples/flow/jxcalc/page/getNumber" + 
> name.toUpperCase(); B-var uri = 
> "/samples/flow/jxcalc/page/getNumber" + name.toUpperCase(); 
> C-var uri = "//samples/flow/jxcalc/page/getNumber" + 
> name.toUpperCase(); D-var uri = 
> "///samples/flow/jxcalc/page/getNumber" + name.toUpperCase();
> 
> 5- On a browser, connect to:
> 
> http://localhost:/samples/flowbug/jxcalc/
> 
> You will get:
> --
> A-No pipeline matched request:
> samples/flowbug/jxcalc/samples/flow/jxcalc/page/getNumberA
> 
> org.apache.cocoon.ResourceNotFoundException: No pipeline 
> matched request:
> samples/flowbug/jxcalc/samples/flow/jxcalc/page/getNumberA
> 
> COMMENT: It is OK. There does not exist in relative path.
> --
> B-No pipeline matched request: samples/flow/jxcalc/page/getNumberA
> 
> org.apache.cocoon.ResourceNotFoundException: No pipeline 
> matched request:
> samples/flow/jxcalc/page/getNumberA
> 
> COMMENT: Why? It must go to the redirection in flow directory 
> using the sitemap that is in flow dir!
> 
> --
> C-No pipeline matched request: /samples/flow/jxcalc/page/getNumberA
> 
> org.apache.cocoon.ResourceNotFoundException: No pipeline 
> matched request:
> /samples/flow/jxcalc/page/getNumberA
> 
> COMMENT: Again, why? As above, the link exists!
> --
> D-No pipeline matched request: //samples/flow/jxcalc/page/getNumberA
> 
> org.apache.cocoon.ResourceNotFoundException: No pipeline 
> matched request:
> //samples/flow/jxcalc/page/getNumberA
> 
> COMMENT: Again, why? As above, the link exists!
> --
> 
> It will never go to the requested path!
> 
> If it works, it would be the same as:
> 
> http://localhost:/samples/flow/jxcalc/page/getNumberA
> 
> And we would need to receive a diferent error:
> 
> org.apache.cocoon.ProcessingException: Failed to execute pipeline.:
> file:/home/agallardo/workspace/cocoon-2.1/build/webapp/samples
> /flow/jxcalc/screens/getNumberA.xml:30:72:org.apache.commons.j
> xpath.JXPathException:
> No value for xpath: $cocoon/continuation/id
> 
> Now the question is what is affecting that?
> 
> Best Regards,
> 
> Antonio Gallardo
> 
>