RE: Incompatible change Request.getRequestURI()
> Volker Schmitt wrote: > > In our eCommerce Portal we have something like a > PartnerSelection which is needed by different modules > OrderCreate/OrderStatus/Prices. So the idea was to use one > pipeline for this PartnerSelection screen. If the selection > is finished the flow will continue with the next application > screen. We are not using flow in the moment. What we have > done is a forward to the PartnerSelection and then dep. on > the "requestURI" a redirect back to the application screen. > > So the use case is, using the same page from different > locations in the application without using the same URL. We > also need the diffent URL's for the same page to manage the > menu correctly (highlight the current location). > Hmm, ok, so you could for example use flow or you could use a workaround like storing the original request uri in an request attribute before the redirect and refer to that value (or something similar). Now, I don't say, that a forward doesn't make sense at all, so it would be interesting to see what others think about it. Carsten
RE: RE: RE: Incompatible change Request.getRequestURI()
>Volker Schmitt wrote: >> >> Ok, so I am not able to do a forward anymore, which doesn't >> do a redirect? >> So I am now missing a feature ;-) >> Isn't it better to have a forward and a redirect? >Hmm, don't know. What is your use case for a forward? In our eCommerce Portal we have something like a PartnerSelection which is needed by different modules OrderCreate/OrderStatus/Prices. So the idea was to use one pipeline for this PartnerSelection screen. If the selection is finished the flow will continue with the next application screen. We are not using flow in the moment. What we have done is a forward to the PartnerSelection and then dep. on the "requestURI" a redirect back to the application screen. So the use case is, using the same page from different locations in the application without using the same URL. We also need the diffent URL's for the same page to manage the menu correctly (highlight the current location). >Carsten >> >> Volker
RE: Incompatible change Request.getRequestURI()
Ralph Goers wrote: > > Ouch. > > Presumably this is mixed in with other fixes, etc. meant for > 2.1.5. That would mean that if the release management > proposal you made is followed no more maintenance can be done > on 2.1 unless this is pulled out. Hmm, basically yes. I will come up with a proposal for this soon. Carsten
RE: RE: Incompatible change Request.getRequestURI()
Volker Schmitt wrote: > > Ok, so I am not able to do a forward anymore, which doesn't > do a redirect? > So I am now missing a feature ;-) > Isn't it better to have a forward and a redirect? Hmm, don't know. What is your use case for a forward? Carsten > > Volker
RE: RE: Incompatible change Request.getRequestURI()
Ok, so I am not able to do a forward anymore, which doesn't do a redirect? So I am now missing a feature ;-) Isn't it better to have a forward and a redirect? Volker > It's a feature. We discussed this incompatible change some weeks > ago and voted to do it as now an internal redirect is a real > internal redirect, so there is no difference to an external > redirect anymore. > PS: This is another candidate to make a 2.2 release next. > Carsten >> -Original Message- >> From: [EMAIL PROTECTED] >> [mailto:[EMAIL PROTECTED] >> Sent: Thursday, April 22, 2004 8:46 PM >> To: [EMAIL PROTECTED] >> Subject: Incompatible change Request.getRequestURI() >> >> I have updated from Cocoon 2.1.2 to the current HEAD and >> found out, that there is a diffent behavior in the return >> value of Request.getRequestURI(). >> If an external request forward the request to an internal >> cocoon pipeline and in this internal pipeline >> Request.getRequestURI() is called the 2.1.2 release return >> the URI of the external Request and the current version >> return the URI of the internal request. >> In the new version there is a new method >> RequestWrapper.setRequestURI() which is called from >> TreeProcessor$ForwardEnvironmentWrapper.setInternalRedirect(). >> This call change the value to the internal URI. In the old >> version the RequestWrapper allways returns the value of the >> external HttpRequest. >> >> So the question is, is this a bug or a feature ? ;-) If it is >> a feature, my problem is, that I am not able to get the >> external URI anymore. >> >> WDYT? >> >> Thanks, >> >> Volker >> >> >>
RE: Incompatible change Request.getRequestURI()
Ouch. Presumably this is mixed in with other fixes, etc. meant for 2.1.5. That would mean that if the release management proposal you made is followed no more maintenance can be done on 2.1 unless this is pulled out. One thing I really don't understand is how Cocoon's CVS is set up. In projects I have worked on new development is always on head. When a release is done a branch is made and all maintenance occurs on that branch (and is merged into the head). From discussion here, it sounds like instead Cocoon has different repositories for different releases. I'm just curious as to why. Ralph -Original Message- From: Carsten Ziegeler [mailto:[EMAIL PROTECTED] Sent: Thursday, April 22, 2004 12:04 PM To: [EMAIL PROTECTED] Subject: RE: Incompatible change Request.getRequestURI() It's a feature. We discussed this incompatible change some weeks ago and voted to do it as now an internal redirect is a real internal redirect, so there is no difference to an external redirect anymore. PS: This is another candidate to make a 2.2 release next. Carsten
RE: Incompatible change Request.getRequestURI()
It's a feature. We discussed this incompatible change some weeks ago and voted to do it as now an internal redirect is a real internal redirect, so there is no difference to an external redirect anymore. PS: This is another candidate to make a 2.2 release next. Carsten > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 22, 2004 8:46 PM > To: [EMAIL PROTECTED] > Subject: Incompatible change Request.getRequestURI() > > I have updated from Cocoon 2.1.2 to the current HEAD and > found out, that there is a diffent behavior in the return > value of Request.getRequestURI(). > If an external request forward the request to an internal > cocoon pipeline and in this internal pipeline > Request.getRequestURI() is called the 2.1.2 release return > the URI of the external Request and the current version > return the URI of the internal request. > In the new version there is a new method > RequestWrapper.setRequestURI() which is called from > TreeProcessor$ForwardEnvironmentWrapper.setInternalRedirect(). > This call change the value to the internal URI. In the old > version the RequestWrapper allways returns the value of the > external HttpRequest. > > So the question is, is this a bug or a feature ? ;-) If it is > a feature, my problem is, that I am not able to get the > external URI anymore. > > WDYT? > > Thanks, > > Volker > > >
