RE: [VOTE] Release commons-fileupload 1.2.1 (rc4)
FYI, this RC builds and tests OK on the 9 SDKs I tested [1] Gary [1] http://garygregory.com/os/builds/index.html#commons-fileupload-1.2.1 Thank you, Gary > -Original Message- > From: Jochen Wiedmann [mailto:[EMAIL PROTECTED] > Sent: Friday, January 18, 2008 1:46 PM > To: Jakarta Commons Developers List > Subject: [VOTE] Release commons-fileupload 1.2.1 (rc4) > > Hi, > > I have prepared a release candidate 4 of commons-fileupload > 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of > changes since rc3 and things that I haven't changes, > can be found below. > > As usual, the proposed distributables can be found on > > http://people.apache.org/~jochen/commons-fileupload/dist > > The proposed site (unchanged since rc3) is on > > http://people.apache.org/~jochen/commons-fileupload/site > > > Thanks, > > Jochen > > > [ ] +1 > [ ] =0 > [ ] -1 > > > Changes since 1.2.1rc3: > > - Upgraded commons-parent to version 7. This means, in particular, > that the maven-remote-resources-plugin is no longer used. > - MD5 and SHA1 checksums now have the binary flag (*) > - Fixed the copyright in the Javadoc bottom > - Building with Ant and Java 1.3.1 works again. > > Other comments: > > > What does "(optional)" mean in the Dependencies section under Commons IO? > > It means optional. Commons-IO is required only, if you intend to use > the DiskFileItem. > > > > What commands are needed to build and test the code? > > The same than for most other commons projects: > > ant > maven build > mvn install > > Choose what you prefer. > > > I could not find the information on the site. > > May be. However, if that is the case, then it was the same for at > least the previous two releases and it wasn't a blocking issue at the > time. > > > Also, build.xml seems to be out of date, as it refers to junit 3.8.1. > > I don't think this is a problem. > > > -- > Look, that's why there's rules, understand? So that you think before > you break 'em. > > -- (Terry Pratchett, Thief of Time) > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[continuum] BUILD SUCCESSFUL: Commons Validator
Online report :
http://vmbuild.apache.org/continuum/buildResult.action?buildId=39103&projectId=170
Build statistics:
State: Ok
Previous State: Error
Started at: Sat 19 Jan 2008 19:57:30 -0800
Finished at: Sat 19 Jan 2008 19:58:21 -0800
Total time: 50s
Build Trigger: Schedule
Build Number: 21
Exit code: 0
Building machine hostname: vmbuild.apache.org
Operating system : Linux(unknown)
Java Home version :
java version "1.4.2_15"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_15-b02)
Java HotSpot(TM) Client VM (build 1.4.2_15-b02, mixed mode)
Builder version :
Maven version: 2.0.7
Java version: 1.4.2_15
OS name: "linux" version: "2.6.20-16-server" arch: "i386"
SCM Changes:
Changed: niallp @ Tue 15 Jan 2008 13:04:51 -0800
Comment: upgrade to commons-parent-7
Files changed:
/commons/proper/beanutils/trunk/pom.xml ( 612219 )
/commons/proper/betwixt/trunk/pom.xml ( 612219 )
/commons/proper/chain/trunk/pom.xml ( 612219 )
/commons/proper/cli/trunk/pom.xml ( 612219 )
/commons/proper/codec/trunk/pom.xml ( 612219 )
/commons/proper/collections/trunk/pom.xml ( 612219 )
/commons/proper/commons-sandbox-parent/trunk/pom.xml ( 612219 )
/commons/proper/configuration/trunk/pom.xml ( 612219 )
/commons/proper/daemon/trunk/pom.xml ( 612219 )
/commons/proper/dbcp/trunk/pom.xml ( 612219 )
/commons/proper/dbutils/trunk/pom.xml ( 612219 )
/commons/proper/digester/trunk/pom.xml ( 612219 )
/commons/proper/discovery/trunk/pom.xml ( 612219 )
/commons/proper/el/trunk/pom.xml ( 612219 )
/commons/proper/email/trunk/pom.xml ( 612219 )
/commons/proper/fileupload/trunk/pom.xml ( 612219 )
/commons/proper/io/trunk/pom.xml ( 612219 )
/commons/proper/jci/trunk/pom.xml ( 612219 )
/commons/proper/jexl/trunk/pom.xml ( 612219 )
/commons/proper/jxpath/trunk/pom.xml ( 612219 )
/commons/proper/lang/trunk/pom.xml ( 612219 )
/commons/proper/launcher/trunk/pom.xml ( 612219 )
/commons/proper/logging/trunk/pom.xml ( 612219 )
/commons/proper/math/trunk/pom.xml ( 612219 )
/commons/proper/modeler/trunk/pom.xml ( 612219 )
/commons/proper/net/trunk/pom.xml ( 612219 )
/commons/proper/pool/trunk/pom.xml ( 612219 )
/commons/proper/primitives/trunk/pom.xml ( 612219 )
/commons/proper/proxy/trunk/pom.xml ( 612219 )
/commons/proper/scxml/trunk/pom.xml ( 612219 )
/commons/proper/transaction/trunk/pom.xml ( 612219 )
/commons/proper/validator/trunk/pom.xml ( 612219 )
/commons/proper/vfs/trunk/pom.xml ( 612219 )
Dependencies Changes:
No dependencies changed
Build Defintion:
POM filename: pom.xml
Goals: clean deploy
Arguments: --batch-mode -DaltDeploymentRepository=vmbuild.repo::default::file://localhost/home/continuum/data/commons -Pci
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Java 1.4
Description:
Test Summary:
Tests: 354
Failures: 0
Total time: 21624
Output:
[INFO] Scanning for projects...
[INFO]
[INFO] Building Commons Validator
[INFO]task-segment: [clean, deploy]
[INFO]
[INFO] [clean:clean]
[INFO] Deleting directory /home/continuum/data/working-directory/170/target
[INFO] Deleting directory
/home/continuum/data/working-directory/170/target/classes
[INFO] Deleting directory
/home/continuum/data/working-directory/170/target/test-classes
[INFO] Deleting directory /home/continuum/data/working-directory/170/target/site
[INFO] [antrun:run {execution: javadoc.resources}]
[INFO] Executing tasks
[copy] Copying 2 files to
/home/continuum/data/working-directory/170/target/apidocs/META-INF
[INFO] Executed tasks
[INFO] [antrun:run {execution: javascript.compress}]
[INFO] Executing tasks
compress:
compressor-specified:
download-compressor-check:
download-compressor:
compress-files:
[echo] Compressing JavaScript files using lib/custom_rhino-0.4.3.jar
[mkdir] Created dir:
/home/continuum/data/working-directory/170/target/classes/org/apache/commons/validator/javascript
[echo] Compressing commons-validator-1.4-SNAPSHOT.js
compress-file:
[
[continuum] BUILD FAILURE: Commons Compress (Sandbox)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=39077&projectId=176 Build statistics: State: Failed Previous State: Failed Started at: Sat 19 Jan 2008 19:36:02 -0800 Finished at: Sat 19 Jan 2008 19:36:25 -0800 Total time: 23s Build Trigger: Schedule Build Number: 0 Exit code: 1 Building machine hostname: vmbuild.apache.org Operating system : Linux(unknown) Java Home version : java version "1.4.2_15" Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_15-b02) Java HotSpot(TM) Client VM (build 1.4.2_15-b02, mixed mode) Builder version : Maven version: 2.0.7 Java version: 1.4.2_15 OS name: "linux" version: "2.6.20-16-server" arch: "i386" SCM Changes: Changed: niallp @ Wed 16 Jan 2008 05:26:26 -0800 Comment: Remove Jakarta references, fix site generation errors Files changed: /commons/sandbox/compress/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/compress/trunk/src/site/xdoc/index.xml ( 612447 ) /commons/sandbox/compress/trunk/src/site/xdoc/issue-tracking.xml ( 612447 ) /commons/sandbox/csv/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/csv/trunk/src/site/xdoc/index.xml ( 612447 ) /commons/sandbox/csv/trunk/src/site/xdoc/issue-tracking.xml ( 612447 ) /commons/sandbox/exec/trunk/pom.xml ( 612447 ) /commons/sandbox/exec/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/finder/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/finder/trunk/src/site/xdoc/index.xml ( 612447 ) /commons/sandbox/finder/trunk/src/site/xdoc/issue-tracking.xml ( 612447 ) /commons/sandbox/i18n/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/id/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/id/trunk/xdocs/navigation.xml ( 612447 ) /commons/sandbox/id/trunk/xdocs/uuid.xml ( 612447 ) /commons/sandbox/javaflow/trunk/pom.xml ( 612447 ) /commons/sandbox/javaflow/trunk/src/site/site.xml ( 612447 ) /commons/sandbox/js2j/trunk/assembly/pom.xml ( 612447 ) /commons/sandbox/js2j/trunk/src/site ( 612447 ) /commons/sandbox/js2j/trunk/src/site/site.xml ( 612447 ) Changed: niallp @ Wed 16 Jan 2008 20:03:01 -0800 Comment: Add logo to m2 build Files changed: /commons/sandbox/compress/trunk/src/site/resources ( 612701 ) /commons/sandbox/compress/trunk/src/site/resources/images (from /commons/sandbox/compress/trunk/src/site/xdoc/images:612456) ( 612701 ) /commons/sandbox/compress/trunk/src/site/site.xml ( 612701 ) Changed: niallp @ Sat 19 Jan 2008 01:19:28 -0800 Comment: Update to released version 3 of commons-sandbox-parent pom Files changed: /commons/sandbox/commons-build-plugin/pom.xml ( 613379 ) /commons/sandbox/compress/trunk/pom.xml ( 613379 ) /commons/sandbox/csv/trunk/pom.xml ( 613379 ) /commons/sandbox/exec/trunk/pom.xml ( 613379 ) /commons/sandbox/finder/trunk/pom.xml ( 613379 ) /commons/sandbox/i18n/trunk/pom.xml ( 613379 ) /commons/sandbox/id/trunk/pom.xml ( 613379 ) /commons/sandbox/javaflow/trunk/pom.xml ( 613379 ) /commons/sandbox/js2j/trunk/pom.xml ( 613379 ) /commons/sandbox/monitoring/trunk/pom.xml ( 613379 ) /commons/sandbox/openpgp/trunk/pom.xml ( 613379 ) /commons/sandbox/performance/trunk/pom.xml ( 613379 ) /commons/sandbox/pipeline/trunk/pom.xml ( 613379 ) Dependencies Changes: No dependencies changed Build Defintion: POM filename: pom.xml Goals: clean deploy Arguments: --batch-mode -DaltDeploymentRepository=vmbuild.repo::default::file://localhost/home/continuum/data/commons -Pci Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Java 1.4 Description: Test Summary: Tests: 26 Failures: 3 Total time: 9005 Output: [INFO] Scanning for projects... [INFO] [INFO] Building Commons Compress (Sandbox) [INFO]task-segment: [clean, deploy] [INFO] [INFO] [clean:clean] [INFO] Deleting directory /home/continuum/data/working-directory/176/target [INFO] Deleting directory /home/continuum/data/working-directory/176/target/classes [INFO] Deleting directory /home/continuum/data/working-d
[continuum] BUILD FAILURE: Commons Codec
Online report :
http://vmbuild.apache.org/continuum/buildResult.action?buildId=39075&projectId=159
Build statistics:
State: Failed
Previous State: Error
Started at: Sat 19 Jan 2008 19:34:13 -0800
Finished at: Sat 19 Jan 2008 19:34:30 -0800
Total time: 16s
Build Trigger: Schedule
Build Number: 6
Exit code: 1
Building machine hostname: vmbuild.apache.org
Operating system : Linux(unknown)
Java Home version :
java version "1.4.2_15"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_15-b02)
Java HotSpot(TM) Client VM (build 1.4.2_15-b02, mixed mode)
Builder version :
Maven version: 2.0.7
Java version: 1.4.2_15
OS name: "linux" version: "2.6.20-16-server" arch: "i386"
SCM Changes:
Changed: niallp @ Tue 15 Jan 2008 13:04:51 -0800
Comment: upgrade to commons-parent-7
Files changed:
/commons/proper/beanutils/trunk/pom.xml ( 612219 )
/commons/proper/betwixt/trunk/pom.xml ( 612219 )
/commons/proper/chain/trunk/pom.xml ( 612219 )
/commons/proper/cli/trunk/pom.xml ( 612219 )
/commons/proper/codec/trunk/pom.xml ( 612219 )
/commons/proper/collections/trunk/pom.xml ( 612219 )
/commons/proper/commons-sandbox-parent/trunk/pom.xml ( 612219 )
/commons/proper/configuration/trunk/pom.xml ( 612219 )
/commons/proper/daemon/trunk/pom.xml ( 612219 )
/commons/proper/dbcp/trunk/pom.xml ( 612219 )
/commons/proper/dbutils/trunk/pom.xml ( 612219 )
/commons/proper/digester/trunk/pom.xml ( 612219 )
/commons/proper/discovery/trunk/pom.xml ( 612219 )
/commons/proper/el/trunk/pom.xml ( 612219 )
/commons/proper/email/trunk/pom.xml ( 612219 )
/commons/proper/fileupload/trunk/pom.xml ( 612219 )
/commons/proper/io/trunk/pom.xml ( 612219 )
/commons/proper/jci/trunk/pom.xml ( 612219 )
/commons/proper/jexl/trunk/pom.xml ( 612219 )
/commons/proper/jxpath/trunk/pom.xml ( 612219 )
/commons/proper/lang/trunk/pom.xml ( 612219 )
/commons/proper/launcher/trunk/pom.xml ( 612219 )
/commons/proper/logging/trunk/pom.xml ( 612219 )
/commons/proper/math/trunk/pom.xml ( 612219 )
/commons/proper/modeler/trunk/pom.xml ( 612219 )
/commons/proper/net/trunk/pom.xml ( 612219 )
/commons/proper/pool/trunk/pom.xml ( 612219 )
/commons/proper/primitives/trunk/pom.xml ( 612219 )
/commons/proper/proxy/trunk/pom.xml ( 612219 )
/commons/proper/scxml/trunk/pom.xml ( 612219 )
/commons/proper/transaction/trunk/pom.xml ( 612219 )
/commons/proper/validator/trunk/pom.xml ( 612219 )
/commons/proper/vfs/trunk/pom.xml ( 612219 )
Changed: ggregory @ Tue 15 Jan 2008 15:40:49 -0800
Comment: Fix Javadoc copyright year.
Files changed:
/commons/proper/codec/trunk/build.xml ( 612313 )
Changed: ggregory @ Tue 15 Jan 2008 15:44:54 -0800
Comment: Fix Javadoc copyright year once and for all.
Files changed:
/commons/proper/codec/trunk/build.xml ( 612315 )
Dependencies Changes:
No dependencies changed
Build Defintion:
POM filename: pom.xml
Goals: clean deploy
Arguments: --batch-mode -DaltDeploymentRepository=vmbuild.repo::default::file://localhost/home/continuum/data/commons -Pci
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Java 1.4
Description:
Test Summary:
Tests: 192
Failures: 1
Total time: 678
Output:
[INFO] Scanning for projects...
[INFO]
[INFO] Building Commons Codec
[INFO]task-segment: [clean, deploy]
[INFO]
[INFO] [clean:clean]
[INFO] Deleting directory /home/continuum/data/working-directory/159/target
[INFO] Deleting directory
/home/continuum/data/working-directory/159/target/classes
[INFO] Deleting directory
/home/continuum/data/working-directory/159/target/test-classes
[INFO] Deleting directory /home/continuum/data/working-directory/159/target/site
[INFO] [antrun:run {execution: javadoc.resources}]
[INFO] Executing tasks
[copy] Copying 2 files to
/home/continuum/data/working-directory/159/target/apidocs/META-INF
[INFO] Executed tasks
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:compile]
[INFO] Compiling
Re: Cobertura + downloaded sites concern
On 20/01/2008, Paul Benedict <[EMAIL PROTECTED]> wrote: > Henri, > > How do you know that the reports are GPL? I knew Cobertura is written under > GPL, but how does that extend to the report generation? > The problem is with the Javascript files that are used to display the results. > Paul > > On Jan 19, 2008 1:51 PM, Henri Yandell <[EMAIL PROTECTED]> wrote: > > > Just wanting to share concern about a couple of things: > > > > 1) Using Cobertura. It's reports are GPL. > > 2) Including sites in downloads. > > > > If we have a component with Cobertura turned on, and with the site > > included in the distribution, then things are very unhappy. > > > > Findbugs doesn't seem to be the same issue - it's LGPL, but the > > reports don't appear to contain any LGPL JavaScript. > > > > Currently we have Cobertura in: > > > > commons-sandbox-parent/pom.xml > > dbcp/pom.xml > > io/pom.xml > > jci/pom.xml > > jexl/pom.xml > > lang/pom.xml > > math/pom.xml > > betwixt/project.xml > > codec/project.xml > > collections/project.xml > > collections_jdk5_branch/project.xml > > configuration/project.xml > > dbcp/project.xml > > io/project.xml > > lang/project.xml > > math/project.xml > > primitives/project.xml > > validator/project.xml > > > > Looking at upcoming releases, IO does not distribute the site and > > FileUpload does but doesn't have any suspicious looking reports. > > > > Do we want to play it safe and either not include Cobertura (and other > > reports with similar problems), or not have downloaded sites? Or keep > > it as it is and make this something we have to look at on every RC > > check? > > > > Hen > > > > - > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Cobertura + downloaded sites concern
On 1/19/08, Henri Yandell <[EMAIL PROTECTED]> wrote: > Just wanting to share concern about a couple of things: > > 1) Using Cobertura. It's reports are GPL. > 2) Including sites in downloads. > > If we have a component with Cobertura turned on, and with the site > included in the distribution, then things are very unhappy. > > Findbugs doesn't seem to be the same issue - it's LGPL, but the > reports don't appear to contain any LGPL JavaScript. > See Niall's effort at doing similar for Cobertura reports here: http://svn.apache.org/viewvc?view=rev&revision=609834 > Do we want to play it safe and either not include Cobertura (and other > reports with similar problems), or not have downloaded sites? I chose the former for [scxml]. > Or keep > it as it is and make this something we have to look at on every RC > check? We don't need another point of failure ;-) IMO, worth picking one of the two (or three) options above now (choice may not be the same for all components). -Rahul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Cobertura + downloaded sites concern
Henri Yandell a écrit : Just wanting to share concern about a couple of things: 1) Using Cobertura. It's reports are GPL. 2) Including sites in downloads. If we have a component with Cobertura turned on, and with the site included in the distribution, then things are very unhappy. Findbugs doesn't seem to be the same issue - it's LGPL, but the reports don't appear to contain any LGPL JavaScript. Currently we have Cobertura in: commons-sandbox-parent/pom.xml dbcp/pom.xml io/pom.xml jci/pom.xml jexl/pom.xml lang/pom.xml math/pom.xml betwixt/project.xml codec/project.xml collections/project.xml collections_jdk5_branch/project.xml configuration/project.xml dbcp/project.xml io/project.xml lang/project.xml math/project.xml primitives/project.xml validator/project.xml Looking at upcoming releases, IO does not distribute the site and FileUpload does but doesn't have any suspicious looking reports. Do we want to play it safe and either not include Cobertura (and other reports with similar problems), or not have downloaded sites? Or keep it as it is and make this something we have to look at on every RC check? Not including Cobertura reports (and similar ones) seems sufficient to me. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Cobertura + downloaded sites concern
Henri, How do you know that the reports are GPL? I knew Cobertura is written under GPL, but how does that extend to the report generation? Paul On Jan 19, 2008 1:51 PM, Henri Yandell <[EMAIL PROTECTED]> wrote: > Just wanting to share concern about a couple of things: > > 1) Using Cobertura. It's reports are GPL. > 2) Including sites in downloads. > > If we have a component with Cobertura turned on, and with the site > included in the distribution, then things are very unhappy. > > Findbugs doesn't seem to be the same issue - it's LGPL, but the > reports don't appear to contain any LGPL JavaScript. > > Currently we have Cobertura in: > > commons-sandbox-parent/pom.xml > dbcp/pom.xml > io/pom.xml > jci/pom.xml > jexl/pom.xml > lang/pom.xml > math/pom.xml > betwixt/project.xml > codec/project.xml > collections/project.xml > collections_jdk5_branch/project.xml > configuration/project.xml > dbcp/project.xml > io/project.xml > lang/project.xml > math/project.xml > primitives/project.xml > validator/project.xml > > Looking at upcoming releases, IO does not distribute the site and > FileUpload does but doesn't have any suspicious looking reports. > > Do we want to play it safe and either not include Cobertura (and other > reports with similar problems), or not have downloaded sites? Or keep > it as it is and make this something we have to look at on every RC > check? > > Hen > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
Re: [configuration] DatabaseConfiguration - should it escape SQL?
On 19/01/2008, Oliver Heger <[EMAIL PROTECTED]> wrote: > I created a ticket for this issue [1], so that it won't get lost. I've actually submitted a patch to fix the "problem". -- Cheers, Hasan Diwan <[EMAIL PROTECTED]> - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Handling of encoding in commons-parent
On 19/01/2008, Jochen Wiedmann <[EMAIL PROTECTED]> wrote: > Hi, > > I have just submitted a patch to commons-parent, which introduces two > new properties: commons.encoding and commons.docEncoding. The former > is the encoding of Java source files, the second is the encoding of > generated Javadoc files. > > This change was caused by the problems with the copyright symbol in > the commons-fileupload distribution. > Why not just use the © HTML tag? That should avoid any encoding issues. > I believe that noone will question the necessity to specify an > explicit encoding because the default encoding can't be used by > developer machines over all the world. The question remains, why I > choosed iso-8859-1 and not UTF-8, and in that point my choice is > surely questionable. > > UTF-8 would have been my personal preference, and I tried it first. > However, it simply didn't work to fix the above problem, and Firefox > still was displaying invalid characters. Hence iso-8859-1. > > Jochen > > P.S: I also upgraded the version of the maven-jar-plugin to 2.2, which > doesn't recreate jar files every time. > > -- > Look, that's why there's rules, understand? So that you think before > you break 'em. > > -- (Terry Pratchett, Thief of Time) > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Handling of encoding in commons-parent
Hi, I have just submitted a patch to commons-parent, which introduces two new properties: commons.encoding and commons.docEncoding. The former is the encoding of Java source files, the second is the encoding of generated Javadoc files. This change was caused by the problems with the copyright symbol in the commons-fileupload distribution. I believe that noone will question the necessity to specify an explicit encoding because the default encoding can't be used by developer machines over all the world. The question remains, why I choosed iso-8859-1 and not UTF-8, and in that point my choice is surely questionable. UTF-8 would have been my personal preference, and I tried it first. However, it simply didn't work to fix the above problem, and Firefox still was displaying invalid characters. Hence iso-8859-1. Jochen P.S: I also upgraded the version of the maven-jar-plugin to 2.2, which doesn't recreate jar files every time. -- Look, that's why there's rules, understand? So that you think before you break 'em. -- (Terry Pratchett, Thief of Time) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [configuration] DatabaseConfiguration - should it escape SQL?
Henri Yandell schrieb: On Jan 17, 2008 1:17 PM, Oliver Heger <[EMAIL PROTECTED]> wrote: Henri Yandell schrieb: Should the DatabaseConfiguration class be responsible for protecting against SQL Injection, or should we make sure the javadoc states that it offers no protection and leave that up to the user? Hen Adding a note about this topic to the documentation would certainly do no harm. From a short look at the code I think that chances for SQL Injection on a correctly initialized DatabaseConfiguration (i.e. the settings for the database table are valid) are pretty small: Everywhere PreparedStatements are used. Fortify was flagging for all the places where prepared statements are built from strings with variables in them - ie) columnName etc. I think this is a case of the SQL Injection worry being outside the scope of the library. For example; no one is concerned that java.sql has SQL Injection issues. +1 to the javadoc. Hen I created a ticket for this issue [1], so that it won't get lost. Oliver [1] https://issues.apache.org/jira/browse/CONFIGURATION-304 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [math] proposal: ZipfDistribution (code available)
Paul Cowan a écrit : Hi all, I'd like to propose adding a Zipf (or Zipfian) integer distribution to commons-math. The Zipf distribution is a distribution which (approximately) reflects many 'real-world' phenomena, e.g. the frequency of use of words in a language. This is a good idea. I have a patch available, including test case; per http://commons.apache.org/math/developers.html, I will add it to the wishlist and to Bugzilla (or Jira? I gather commons math uses Jira now but the page still says Bugzilla) and attach my patch if the response here is generally positive to the idea. You should open a ticket in Jira. We are currently working on the 1.2 release. This addition will not be included in this release. The next one will be 2.0. Note that the patch isn't perfect; in particular I've just stuck a method to calculate generalized harmonic numbers in the ZipfDistributionImpl class itself. I would suggest that a) it almost certainly shouldn't go there, and b) it could most certainly be done more efficiently (I'm using a simple cumulative loop), but I would like guidance on solving both of those issues from people who know the project and are better than me at mathematics (respectively). This will be discussed in the Jira comments system. Thanks Luc Cheers, Paul Cowan. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Cobertura + downloaded sites concern
Just wanting to share concern about a couple of things: 1) Using Cobertura. It's reports are GPL. 2) Including sites in downloads. If we have a component with Cobertura turned on, and with the site included in the distribution, then things are very unhappy. Findbugs doesn't seem to be the same issue - it's LGPL, but the reports don't appear to contain any LGPL JavaScript. Currently we have Cobertura in: commons-sandbox-parent/pom.xml dbcp/pom.xml io/pom.xml jci/pom.xml jexl/pom.xml lang/pom.xml math/pom.xml betwixt/project.xml codec/project.xml collections/project.xml collections_jdk5_branch/project.xml configuration/project.xml dbcp/project.xml io/project.xml lang/project.xml math/project.xml primitives/project.xml validator/project.xml Looking at upcoming releases, IO does not distribute the site and FileUpload does but doesn't have any suspicious looking reports. Do we want to play it safe and either not include Cobertura (and other reports with similar problems), or not have downloaded sites? Or keep it as it is and make this something we have to look at on every RC check? Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [configuration] DatabaseConfiguration - should it escape SQL?
On Jan 17, 2008 1:17 PM, Oliver Heger <[EMAIL PROTECTED]> wrote: > Henri Yandell schrieb: > > > Should the DatabaseConfiguration class be responsible for protecting > > against SQL Injection, or should we make sure the javadoc states that > > it offers no protection and leave that up to the user? > > > > Hen > > > > Adding a note about this topic to the documentation would certainly do > no harm. > > From a short look at the code I think that chances for SQL Injection on > a correctly initialized DatabaseConfiguration (i.e. the settings for the > database table are valid) are pretty small: Everywhere > PreparedStatements are used. Fortify was flagging for all the places where prepared statements are built from strings with variables in them - ie) columnName etc. I think this is a case of the SQL Injection worry being outside the scope of the library. For example; no one is concerned that java.sql has SQL Injection issues. +1 to the javadoc. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
On 19/01/2008, Oliver Heger <[EMAIL PROTECTED]> wrote: > +1 > > The build works for me in all variants as expected (on JDK 1.6). The > only minor nit I have is that the Copyright in the Javadocs still looks > a bit wired (at least on my browser): Instead of the Copyright character > I only get a "?". > Me too when I look at e.g.: http://people.apache.org/~jochen/commons-fileupload/site/apidocs/index.html or perhaps that was not regenerated? In the API docs generated by the Ant build, there is no Copyright footer at all. "maven dist" creates the Javadoc with OK Copyright symbols, but as mentioned before it fails before creating the archives. Not sure what M2 goal(s) correspond with M1 dist, but mvn package site:site assembly:assembly did seem to create the Javadocs with the correct copyright before failing with: [INFO] Unable to find information in class org.apache.commons.fileupload.FileUploadBase referring back to nested class org.apache.co mmons.fileupload.FileUploadBase$1 [INFO] [INFO] Trace net.sf.clirr.core.CheckerException: Unable to find information in class org.apache.commons.fileupload.FileUploadBase referring back to nested class org.apache.commons.fileupload.FileUploadBase$1 at net.sf.clirr.core.internal.bcel.BcelScopeHelper.getClassScope(BcelScopeHelper.java:127) at net.sf.clirr.core.internal.bcel.BcelJavaType.getDeclaredScope(BcelJavaType.java:141) at net.sf.clirr.core.internal.bcel.BcelJavaType.getEffectiveScope(BcelJavaType.java:145) at net.sf.clirr.core.Checker.runClassChecks(Checker.java:156) at net.sf.clirr.core.Checker.reportDiffs(Checker.java:136) at org.codehaus.mojo.clirr.AbstractClirrMojo.executeClirr(AbstractClirrMojo.java:227) at org.codehaus.mojo.clirr.ClirrReport.doReport(ClirrReport.java:249) Presumably I used the wrong M2 goals. What goal(s) are needed to create the site and archives? > Oliver > > Jochen Wiedmann schrieb: > > Hi, > > > > I have prepared a release candidate 4 of commons-fileupload > > 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of > > changes since rc3 and things that I haven't changes, > > can be found below. > > > > As usual, the proposed distributables can be found on > > > > http://people.apache.org/~jochen/commons-fileupload/dist > > > > The proposed site (unchanged since rc3) is on > > > > http://people.apache.org/~jochen/commons-fileupload/site > > > > > > Thanks, > > > > Jochen > > > > > > [ ] +1 > > [ ] =0 > > [ ] -1 > > > > > > Changes since 1.2.1rc3: > > > > - Upgraded commons-parent to version 7. This means, in particular, > > that the maven-remote-resources-plugin is no longer used. > > - MD5 and SHA1 checksums now have the binary flag (*) > > - Fixed the copyright in the Javadoc bottom > > - Building with Ant and Java 1.3.1 works again. > > > > Other comments: > > > >> What does "(optional)" mean in the Dependencies section under Commons IO? > > > > It means optional. Commons-IO is required only, if you intend to use > > the DiskFileItem. > > > > > >> What commands are needed to build and test the code? > > > > The same than for most other commons projects: > > > > ant > > maven build > > mvn install > > > > Choose what you prefer. > > > >> I could not find the information on the site. > > > > May be. However, if that is the case, then it was the same for at > > least the previous two releases and it wasn't a blocking issue at the > > time. > > > >> Also, build.xml seems to be out of date, as it refers to junit 3.8.1. > > > > I don't think this is a problem. > > > > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release commons-fileupload 1.2.1 (rc4)
+1 The build works for me in all variants as expected (on JDK 1.6). The only minor nit I have is that the Copyright in the Javadocs still looks a bit wired (at least on my browser): Instead of the Copyright character I only get a "?". Oliver Jochen Wiedmann schrieb: Hi, I have prepared a release candidate 4 of commons-fileupload 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of changes since rc3 and things that I haven't changes, can be found below. As usual, the proposed distributables can be found on http://people.apache.org/~jochen/commons-fileupload/dist The proposed site (unchanged since rc3) is on http://people.apache.org/~jochen/commons-fileupload/site Thanks, Jochen [ ] +1 [ ] =0 [ ] -1 Changes since 1.2.1rc3: - Upgraded commons-parent to version 7. This means, in particular, that the maven-remote-resources-plugin is no longer used. - MD5 and SHA1 checksums now have the binary flag (*) - Fixed the copyright in the Javadoc bottom - Building with Ant and Java 1.3.1 works again. Other comments: What does "(optional)" mean in the Dependencies section under Commons IO? It means optional. Commons-IO is required only, if you intend to use the DiskFileItem. What commands are needed to build and test the code? The same than for most other commons projects: ant maven build mvn install Choose what you prefer. I could not find the information on the site. May be. However, if that is the case, then it was the same for at least the previous two releases and it wasn't a blocking issue at the time. Also, build.xml seems to be out of date, as it refers to junit 3.8.1. I don't think this is a problem. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jaxme has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jaxme : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-jaxme-19012008.jar] identifier set to project name -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme. -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme-js. -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme-xs. -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme-api. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/project.xml -DEBUG- Maven project properties in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/project.properties -INFO- Project Reports in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/gump_work/build_commons-jelly_commons-jelly-tags-jaxme.html Work Name: build_commons-jelly_commons-jelly-tags-jaxme (Type: Build) Work ended in a state of : Failed Elapsed: 11 secs Command Line: maven --offline jar [Working Directory: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme] CLASSPATH: /usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-19012008.jar:/srv/gump/public/workspace/apache-commons/collections/build/commons-collections-19012008.jar:/srv/gump/public/workspace/commons-jelly/target/commons-jelly-19012008.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-19012008.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-19012008.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/xmlunit/target/commons-jelly-tags-xmlunit-19012008.jar:/srv/gump/public/workspace/apache-commons/jexl/dist/commons-jexl-19012008.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-19012008.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-19012008.jar:/srv/gump/public/workspace/dom4j/build/dom4j.jar:/srv/gump/public/workspace/jaxen/target/jaxen-19012008.jar:/srv/gump/ packages/ws-jaxme-0.5/lib/jaxme2-0.5.jar:/srv/gump/packages/ws-jaxme-0.5/lib/jaxmeapi-0.5.jar:/srv/gump/packages/ws-jaxme-0.5/lib/jaxmejs-0.5.jar:/srv/gump/packages/ws-jaxme-0.5/lib/jaxmexs-0.5.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/xmlunit/build/lib/xmlunit-19012008.jar - [javac] symbol : variable super [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressTypeHandler [javac] super.characters(pChars, pOffset, pLen); [javac] ^ [javac] /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/src/test/org/apache/ws/jaxme/examples/misc/address/impl/AddressTypeHandler.java:305: cannot find symbol [javac] symbol : variable super [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressTypeHandler [javac] super.init(pData); [javac] ^ [javac] /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/src/test/org/apache/ws/jaxme/examples/misc/address/impl/AddressTypeHandler.java:315: cannot find symbol [javac] symbol : method getData() [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressTypeHandler [javac] __handler_Name.init(getData()); [javac] ^ [javac] /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/src/test/org/apache/ws/jaxme/examples/misc/address/impl/AddressHandler.java:22: cannot find symbol [javac] symbol : method getData() [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressHandler [ja
