Re: [vfs] Lcurly=no (was: svn commit: r1802440 - /commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java

[Gary Gregory]

We had talked a long time ago about changing the style to the {} style
below but it was never done. Any IDE can automatically do that but I do not
know how to tell Eclipse for example to ONLY do that. So if we can live we
a tree-wide reformat, that's easy.

Gary

On Wed, Jul 19, 2017 at 5:15 PM, Bernd Eckenfels 
wrote:

> Hello.
>
> I am not sure about changing that. It looks to me like most of the VFS
> code uses opening braces on new lines. I actually agree with that style.
>
> I would also accept to change it, but then completely.
>
> In fact the checkstyle template specifies curly = nl
> https://github.com/apache/commons-vfs/blob/trunk/checkstyle.properties#L17
>
> Gruss
> Bernd
> --
> http://bernd.eckenfels.net
> _
> From: ggreg...@apache.org
> Sent: Donnerstag, Juli 20, 2017 1:56 AM
> Subject: svn commit: r1802440 - /commons/proper/vfs/trunk/
> core/src/test/java/org/apache/commons/vfs2/provider/jar/
> test/JarAttributesTestCase.java
> To: >
>
>
> Author: ggregory
> Date: Wed Jul 19 23:56:13 2017
> New Revision: 1802440
>
> URL: http://svn.apache.org/viewvc?rev=1802440=rev
> Log:
> Format for more standard brace usage.
>
> Modified:
> commons/proper/vfs/trunk/core/src/test/java/org/apache/
> commons/vfs2/provider/jar/test/JarAttributesTestCase.java
>
> Modified: commons/proper/vfs/trunk/core/src/test/java/org/apache/
> commons/vfs2/provider/jar/test/JarAttributesTestCase.java
> URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/
> src/test/java/org/apache/commons/vfs2/provider/jar/
> test/JarAttributesTestCase.java?rev=1802440=1802439&
> r2=1802440=diff
> 
> ==
> --- commons/proper/vfs/trunk/core/src/test/java/org/apache/
> commons/vfs2/provider/jar/test/JarAttributesTestCase.java (original)
> +++ commons/proper/vfs/trunk/core/src/test/java/org/apache/
> commons/vfs2/provider/jar/test/JarAttributesTestCase.java Wed Jul 19
> 23:56:13 2017
> @@ -30,19 +30,16 @@ import org.junit.Test;
> *
> * @version $Id$
> */
> -public class JarAttributesTestCase
> -{
> - private void printAttributes(final Map attributes)
> - {
> - for (final Map.Entry e : attributes.entrySet())
> - {
> +public class JarAttributesTestCase {
> +
> + private void printAttributes(final Map attributes) {
> + for (final Map.Entry e : attributes.entrySet()) {
> System.out.println("Key: " + e.getKey() + ", Value: " + e.getValue());
> }
> }
>
> @Test
> - public void testAttributes() throws Exception
> - {
> + public void testAttributes() throws Exception {
> final FileObject file = JarProviderTestCase.getTestJar(VFS.getManager(),
> "test.jar");
>
> final Map attributes = file.getContent().getAttributes();
> @@ -52,8 +49,7 @@ public class JarAttributesTestCase
> }
>
> @Test
> - public void testNestedAttributes() throws Exception
> - {
> + public void testNestedAttributes() throws Exception {
> final FileObject nested = JarProviderTestCase.getTestJar(VFS.getManager(),
> "nested.jar");
> final FileObject file = nested.resolveFile("test.jar");
>
>
>
>
>
>

Re: [daemon] moving to git ? and bump java version.

[Gary Gregory]

The code could be made better by fixing bug reported in JIRA...

Gary

On Wed, Jul 19, 2017 at 4:41 PM,  wrote:

>
> Yes, that's mentioned  in my previous mail, I was also curious to know from
> the C developers here in dev-list that how can we make *that* C code
> better? basically I'm looking findbug, checkstyle, jococo, junit
>  *equivalent* for C code.
>
> CodeSentry provide a cloud version for scanning opensource projects.
> Otherwise with cppcheck allows you to check for bugs
>
> Best Regards,
> Giorgio,
>

[vfs] Lcurly=no (was: svn commit: r1802440 - /commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java

[Bernd Eckenfels]

Hello.

I am not sure about changing that. It looks to me like most of the VFS code 
uses opening braces on new lines. I actually agree with that style.

I would also accept to change it, but then completely.

In fact the checkstyle template specifies curly = nl
https://github.com/apache/commons-vfs/blob/trunk/checkstyle.properties#L17

Gruss
Bernd
--
http://bernd.eckenfels.net
_
From: ggreg...@apache.org
Sent: Donnerstag, Juli 20, 2017 1:56 AM
Subject: svn commit: r1802440 - 
/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java
To: >


Author: ggregory
Date: Wed Jul 19 23:56:13 2017
New Revision: 1802440

URL: http://svn.apache.org/viewvc?rev=1802440=rev
Log:
Format for more standard brace usage.

Modified:
commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java

Modified: 
commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java?rev=1802440=1802439=1802440=diff
==
--- 
commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java
 (original)
+++ 
commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java
 Wed Jul 19 23:56:13 2017
@@ -30,19 +30,16 @@ import org.junit.Test;
*
* @version $Id$
*/
-public class JarAttributesTestCase
-{
- private void printAttributes(final Map attributes)
- {
- for (final Map.Entry e : attributes.entrySet())
- {
+public class JarAttributesTestCase {
+
+ private void printAttributes(final Map attributes) {
+ for (final Map.Entry e : attributes.entrySet()) {
System.out.println("Key: " + e.getKey() + ", Value: " + e.getValue());
}
}

@Test
- public void testAttributes() throws Exception
- {
+ public void testAttributes() throws Exception {
final FileObject file = JarProviderTestCase.getTestJar(VFS.getManager(), 
"test.jar");

final Map attributes = file.getContent().getAttributes();
@@ -52,8 +49,7 @@ public class JarAttributesTestCase
}

@Test
- public void testNestedAttributes() throws Exception
- {
+ public void testNestedAttributes() throws Exception {
final FileObject nested = JarProviderTestCase.getTestJar(VFS.getManager(), 
"nested.jar");
final FileObject file = nested.resolveFile("test.jar");

RE: [daemon] moving to git ? and bump java version.

[giorgio.zoppi]

Yes, that's mentioned  in my previous mail, I was also curious to know from
the C developers here in dev-list that how can we make *that* C code
better? basically I'm looking findbug, checkstyle, jococo, junit
 *equivalent* for C code.

CodeSentry provide a cloud version for scanning opensource projects.
Otherwise with cppcheck allows you to check for bugs

Best Regards,
Giorgio,

[GitHub] commons-imaging issue #29: Improve various unit tests style

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-imaging/pull/29
  
You're welcome.
However, have to get used to the importance of style topics yet ...

Regarding the GreyScaleRoundTripTest:
Yes.
However, I thing or better guess it has to do with the amount of memory the 
Travis instance got supplied with.
As its a free service I'd await it to have very less memory.
And the specific test needs on my local machine quit a lot of memory as 
there is a JUnit theory inside.
Therefore I guess a restart won't help.
However again, I can only guess and I'am sure only owners can play around 
with CI instance settings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #29: Improve various unit tests style

[jbduncan]

Github user jbduncan commented on the issue:

https://github.com/apache/commons-imaging/pull/29
  
Looks much better, thanks @TheRealHaui!

As I discussed in #28, I'm sure there's area for improvement on the 
whitespace/readability front, but that would require running `mvn 
checkstyle:check` and fixing the warnings it reports in a separate PR.

On a related note, Travis seems to complaining that GreyScaleRountripTest 
(unrelated to this PR AFAICT) killed the JVM process during testing. Perhaps 
Travis just needs to be restarted and the test will run properly? But I don't 
immediately know how one would restart Travis...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

[Matt Sicker]

I think so.

On 19 July 2017 at 10:46, Gary Gregory  wrote:

> On Jul 19, 2017 08:43, "Matt Sicker"  wrote:
>
> On 18 July 2017 at 15:02, Stefan Bodewig  wrote:
> >
> > We shouldn't remove any key that has been used to sign a release in the
> > past. No matter how long in the past :-)
> >
>
> What about expired keys?
>
>
> Can't those still be used to validate old releases?
>
> Gary
>
>
> --
> Matt Sicker 
>



-- 
Matt Sicker 

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

[Matt Sicker]

On 18 July 2017 at 15:02, Stefan Bodewig  wrote:
>
> We shouldn't remove any key that has been used to sign a release in the
> past. No matter how long in the past :-)
>

What about expired keys?

-- 
Matt Sicker 

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

[Gary Gregory]

On Jul 19, 2017 08:43, "Matt Sicker"  wrote:

On 18 July 2017 at 15:02, Stefan Bodewig  wrote:
>
> We shouldn't remove any key that has been used to sign a release in the
> past. No matter how long in the past :-)
>

What about expired keys?


Can't those still be used to validate old releases?

Gary


--
Matt Sicker 

Re: [all] Linking to sites will break or become misleading overtime.

[Gary Gregory]

I tried one approach for Commons Codec:

https://commons.apache.org/proper/commons-codec/

See the nav bar under Site Archives.

It's yet another thing to deal with during a release though.

Gary

On Jul 19, 2017 08:23, "Carl Hall"  wrote:

> This is a great idea.  Something that hits closer to home for me is how the
> API docs disappear for older versions.
>
> https://commons.apache.org/proper/commons-dbutils/apidocs/index.html
> vs.
> https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/apidocs/index.html
>
> For DbUtils, this is particularly interesting since the 1.6 release has
> been out for so long.
>
>
> On Tue, Jul 18, 2017 at 2:45 PM, Gary Gregory 
> wrote:
>
> > Hi All,
> >
> > A comment more than anything:
> >
> > In our DBCP 1.7 RC2 VOTE email thread in progress now, you can read:
> >
> > =
> >
> > On Tue, Jul 18, 2017 at 1:13 PM, Oliver Heger <
> > oliver.he...@oliver-heger.de>
> >  wrote:
> >
> > > Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and
> site
> > > look good.
> > >
> > > There is a bunch of checkstyle errors, especially in
> > > BaseResultSetHandler.java; but I assume they have been in there before,
> > > so not a blocker.
> > >
> >
> > Yeah, if you look at
> > https://commons.apache.org/proper/commons-dbutils/
> > checkstyle-aggregate.html
> > you'll see 1104 errors.
> >
> > =
> >
> > The page at the link I pasted:
> >
> > https://commons.apache.org/proper/commons-dbutils/
> > checkstyle-aggregate.html
> >
> > is about version 1.6 and works today but will be overwritten once we
> > publish 1.7 making tractability impossible.
> >
> > I wish we archived sites for all releases... which would be handy when
> > someone is stuck to using an old version.
> >
> > Then my link could have been:
> >
> > https://commons.apache.org/proper/commons-dbutils/1.6/
> > checkstyle-aggregate.html
> >
> > or something like that. I think a few components here and there do
> archive
> > old sites but we do not have a generic and automatic way to do that for
> all
> > components.
> >
> > Gary
> >
>

Re: [all] Linking to sites will break or become misleading overtime.

[Carl Hall]

This is a great idea.  Something that hits closer to home for me is how the
API docs disappear for older versions.

https://commons.apache.org/proper/commons-dbutils/apidocs/index.html
vs.
https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/apidocs/index.html

For DbUtils, this is particularly interesting since the 1.6 release has
been out for so long.


On Tue, Jul 18, 2017 at 2:45 PM, Gary Gregory 
wrote:

> Hi All,
>
> A comment more than anything:
>
> In our DBCP 1.7 RC2 VOTE email thread in progress now, you can read:
>
> =
>
> On Tue, Jul 18, 2017 at 1:13 PM, Oliver Heger <
> oliver.he...@oliver-heger.de>
>  wrote:
>
> > Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and site
> > look good.
> >
> > There is a bunch of checkstyle errors, especially in
> > BaseResultSetHandler.java; but I assume they have been in there before,
> > so not a blocker.
> >
>
> Yeah, if you look at
> https://commons.apache.org/proper/commons-dbutils/
> checkstyle-aggregate.html
> you'll see 1104 errors.
>
> =
>
> The page at the link I pasted:
>
> https://commons.apache.org/proper/commons-dbutils/
> checkstyle-aggregate.html
>
> is about version 1.6 and works today but will be overwritten once we
> publish 1.7 making tractability impossible.
>
> I wish we archived sites for all releases... which would be handy when
> someone is stuck to using an old version.
>
> Then my link could have been:
>
> https://commons.apache.org/proper/commons-dbutils/1.6/
> checkstyle-aggregate.html
>
> or something like that. I think a few components here and there do archive
> old sites but we do not have a generic and automatic way to do that for all
> components.
>
> Gary
>

[GitHub] commons-imaging issue #28: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-imaging/pull/28
  
Done in #29.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #29: Improve various unit tests style

[TheRealHaui]

GitHub user TheRealHaui opened a pull request:

https://github.com/apache/commons-imaging/pull/29

Improve various unit tests style

Code formatting changed as desired in #27 and #28.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TheRealHaui/commons-imaging 
improve-various-unit-tests-style

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-imaging/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #29


commit 5c8b1fcf92fdab412818b20175c617e3690fc060
Author: Michael Hausegger 
Date:   2017-07-13T20:12:46Z

increase-code-coverage-one Added Unit Tests to increase code coverage.

commit 471ac19d179a3eb167930f163117703cf7851aa8
Author: Michael Hausegger 
Date:   2017-07-13T21:00:31Z

increase-code-coverage-one Added Unit Tests to increase code coverage.

commit ff9adf8a87c3963dcc5a0f0be9668f1690f8fd45
Author: Michael Hausegger 
Date:   2017-07-13T21:14:08Z

increase-code-coverage-one Fixed failing test.

commit 489c8c33ad03e9f22762e0520670694f08659c57
Author: Michael Hausegger 
Date:   2017-07-15T21:39:54Z

increase-code-coverage-one Fix directory hierarchy problem.

commit d0c70bddfbeff23970702b339de938d6d2876d33
Author: Michael Hausegger 
Date:   2017-07-19T14:18:07Z

improve-various-unit-tests-style Improved code formatting.

commit 2e962d12698711f3614fe16ff75036c139d4d1fb
Author: Michael Hausegger 
Date:   2017-07-19T14:40:55Z

improve-various-unit-tests-style Changed various blank lines and blanks as 
requested.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui closed the pull request at:

https://github.com/apache/commons-imaging/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ANNOUNCE] Apache Commons Collections moved to git

[Gary Gregory]

On Jul 19, 2017 05:16, "Rob Tompkins"  wrote:


> On Jul 19, 2017, at 8:13 AM, Stefan Bodewig  wrote:
>
> On 2017-07-19, Rob Tompkins wrote:
>
>> The Apache Commons Collections component has been moved to git.
>
> Many thanks for doing that, Rob!
>
> Are you following some kind of playbook with the git migration? If so,
> we should add one point:
>
> * edit the svn:externals property of
>  https://svn.apache.org/repos/asf/commons/trunks-proper and remove the
>  entry for the component just migrated.

Good point, and no playbook here. I suppose we should either: 1. create
such a playbook, or 2. do the remainder of the repos so that such a
playbook is no longer needed. :-)


It would be good to put that in our wiki, other folks might want to pitch
in.

Gary


>
> Cheers
>
>Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ANNOUNCE] Apache Commons Collections moved to git

[Gary Gregory]

On Jul 19, 2017 05:13, "Stefan Bodewig"  wrote:

On 2017-07-19, Rob Tompkins wrote:

> The Apache Commons Collections component has been moved to git.

Many thanks for doing that, Rob!


+1 

Gary


Are you following some kind of playbook with the git migration? If so,
we should add one point:

* edit the svn:externals property of
  https://svn.apache.org/repos/asf/commons/trunks-proper and remove the
  entry for the component just migrated.

Cheers

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: commons-numbers git commit: NUMBERS-13: cosh() passes all tests

[Gilles]

Hi Eric.

Constants should be declared "static final".

Regards,
Gilles

On Wed, 19 Jul 2017 13:49:01 + (UTC), ericbarnh...@apache.org 
wrote:

Repository: commons-numbers
Updated Branches:
  refs/heads/complex-dev 1de701b3e -> c8db04d0a


NUMBERS-13: cosh() passes all tests


Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
Commit:

http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/c8db04d0
Tree: 
http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/c8db04d0
Diff: 
http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/c8db04d0


Branch: refs/heads/complex-dev
Commit: c8db04d0ac1001774b97fb7abe3f198a30500335
Parents: 1de701b
Author: Eric Barnhill 
Authored: Wed Jul 19 15:50:52 2017 +0200
Committer: Eric Barnhill 
Committed: Wed Jul 19 15:50:52 2017 +0200


--
 .../apache/commons/numbers/complex/Complex.java |  14 +
 .../commons/numbers/complex/CStandardTest.java  | 282 
+++

 2 files changed, 296 insertions(+)

--



http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/c8db04d0/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java

--
diff --git

a/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java

b/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java
index e4c0a71..4eae524 100644
---

a/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java
+++

b/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java
@@ -808,6 +808,20 @@ in the
  * @return the hyperbolic cosine of this complex number.
  */
 public Complex cosh() {
+if (real == 0 && imaginary == Double.POSITIVE_INFINITY) {
+return new Complex(Double.NaN, 0);
+} else if (real == 0 && Double.isNaN(imaginary)) {
+return new Complex(Double.NaN, 0);
+} else if (real == Double.POSITIVE_INFINITY && imaginary == 
0) {

+return new Complex(Double.POSITIVE_INFINITY, 0);
+} else if (real == Double.POSITIVE_INFINITY && imaginary ==
Double.POSITIVE_INFINITY) {
+return new Complex(Double.POSITIVE_INFINITY, 
Double.NaN);

+} else if (real == Double.POSITIVE_INFINITY &&
Double.isNaN(imaginary)) {
+return new Complex(Double.POSITIVE_INFINITY, 
Double.NaN);

+} else if (Double.isNaN(real) && imaginary == 0) {
+return new Complex(Double.NaN, 0);
+}
+
 return createComplex(Math.cosh(real) * Math.cos(imaginary),
  Math.sinh(real) * Math.sin(imaginary));
 }


http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/c8db04d0/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java

--
diff --git

a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java

b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
new file mode 100644
index 000..9c178f2
--- /dev/null
+++

b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
@@ -0,0 +1,282 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or 
more
+ * contributor license agreements.  See the NOTICE file distributed 
with
+ * this work for additional information regarding copyright 
ownership.
+ * The ASF licenses this file to You under the Apache License, 
Version 2.0
+ * (the "License"); you may not use this file except in compliance 
with

+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, 
software

+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
+ * See the License for the specific language governing permissions 
and

+ * limitations under the License.
+ */
+
+package org.apache.commons.numbers.complex;
+
+import org.apache.commons.numbers.complex.Complex;
+import org.apache.commons.numbers.complex.ComplexUtils;
+import org.junit.Assert;
+import org.junit.Ignore;
+import org.junit.Test;
+
+public class CStandardTest {
+
+private double inf = Double.POSITIVE_INFINITY;
+private double negInf = Double.NEGATIVE_INFINITY;
+private double nan = Double.NaN;
+private double pi = Math.PI;
+private double piOverFour = Math.PI / 4.0;
+private double piOverTwo = Math.PI / 2.0;
+private double threePiOverFour = 3.0*Math.PI/4.0;
+private Complex oneOne = new Complex(1, 1);
+private 

Re: [ANNOUNCE] Apache Commons Collections moved to git

[Rob Tompkins]

> On Jul 19, 2017, at 8:13 AM, Stefan Bodewig  wrote:
> 
> On 2017-07-19, Rob Tompkins wrote:
> 
>> The Apache Commons Collections component has been moved to git.
> 
> Many thanks for doing that, Rob!
> 
> Are you following some kind of playbook with the git migration? If so,
> we should add one point:
> 
> * edit the svn:externals property of
>  https://svn.apache.org/repos/asf/commons/trunks-proper and remove the
>  entry for the component just migrated.

Good point, and no playbook here. I suppose we should either: 1. create such a 
playbook, or 2. do the remainder of the repos so that such a playbook is no 
longer needed. :-)

> 
> Cheers
> 
>Stefan
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ANNOUNCE] Apache Commons Collections moved to git

[Stefan Bodewig]

On 2017-07-19, Rob Tompkins wrote:

> The Apache Commons Collections component has been moved to git.

Many thanks for doing that, Rob!

Are you following some kind of playbook with the git migration? If so,
we should add one point:

* edit the svn:externals property of
  https://svn.apache.org/repos/asf/commons/trunks-proper and remove the
  entry for the component just migrated.

Cheers

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Apache Commons Collections moved to git

[Rob Tompkins]

Hello all,

The Apache Commons Collections component has been moved to git. The new source 
repository location is:

https://git-wip-us.apache.org/repos/asf/commons-collections.git 


The old SVN source tree has been moved to an archive location:

https://svn.apache.org/repos/asf/commons/_moved_to_git/collections 


Cheers,
-Rob

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

[Jörg Schaible]

Hi Amey

Amey Jadiye wrote:

> I observed we have lot of keys in
> https://www.apache.org/dist/commons/KEYS, even keys of developers who
> might have resigned from commons, can we just
> review and  remove keys of developers who resigned or no more active ?

IMHO it depends on whether a key was used to sign a release.

Cheers,
Jörg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org