Re: JDK 16-EA issue

[Dalibor Topic]

Hi,

this looks like a bug, since "e hene" in Albanian means Monday. [0] 
Please file an issue, and let us know what the incident id is.


cheers,
dalibor topic


[0] https://en.wiktionary.org/wiki/e_h%C3%ABn%C3%AB

On 29.12.2020 19:27, Gary Gregory wrote:

Hi Rory and all,

Before I go through creating a bug, I wanted to run this one by you all 
first. All tests pass on Java 8 and 11. We have known failures on 15, 
and new ones on 16.


Just like Apache Commons Lang [https://github.com/apache/commons-lang 
] 
ran into issues


https://bugs.openjdk.java.net/browse/JDK-8248434 
 and
https://bugs.openjdk.java.net/browse/JDK-8248655 
)


on Java 15 now fixed on Java 16, we've found another that fails on Java 
15 and 16-ea+29 with locale sq_MK in our unit 
test org.apache.commons.lang3.time.Java15BugFastDateParserTest which you 
see in action here:


https://github.com/apache/commons-lang/runs/1622593373?check_suite_focus=true 



How to reproduce (requires git and Apache Maven):
git clone https://gitbox.apache.org/repos/asf/commons-lang.git 


mvn clean test

For example, we expect to parse a date into a certain value but we get 
an unexpected value:
Mon Feb 10 00:00:00 GMT+00:00 2003> but was: GMT+00:00 2003


Here it is in the build:

Error:  Tests run: 18, Failures: 16, Errors: 0, Skipped: 0, Time 
elapsed: 0.658 s <<< FAILURE! - in 
org.apache.commons.lang3.time.Java15BugFastDateParserTest
Error: 
  org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_AD(TriFunction)[1]  Time elapsed: 0.14 s  <<< FAILURE!

org.opentest4j.AssertionFailedError:
locale : sq_MK, formattedDate : mb.K./2003/shkurt/0010/0012//00/e 
paradites/e hënë, Java: 16-ea+29
  ==> expected:  but was: 12 12:00:00 GMT+00:00 2003>
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales(Java15BugFastDateParserTest.java:86)
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_AD(Java15BugFastDateParserTest.java:94)


In case the GitHub build falls off, here is the complete list of errors:

Error:  Tests run: 18, Failures: 16, Errors: 0, Skipped: 0, Time 
elapsed: 0.658 s <<< FAILURE! - in 
org.apache.commons.lang3.time.Java15BugFastDateParserTest
Error: 
  org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_AD(TriFunction)[1]  Time elapsed: 0.14 s  <<< FAILURE!

org.opentest4j.AssertionFailedError:
locale : sq_MK, formattedDate : mb.K./2003/shkurt/0010/0012//00/e 
paradites/e hënë, Java: 16-ea+29
  ==> expected:  but was: 12 12:00:00 GMT+00:00 2003>
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales(Java15BugFastDateParserTest.java:86)
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_AD(Java15BugFastDateParserTest.java:94)


Error: 
  org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_AD(TriFunction)[2]  Time elapsed: 0.04 s  <<< FAILURE!

org.opentest4j.AssertionFailedError:
locale : sq_MK, formattedDate : mb.K./2003/shkurt/0010/0012//00/e 
paradites/e hënë, Java: 16-ea+29
  ==> expected:  but was: 12 12:00:00 GMT+00:00 2003>
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales(Java15BugFastDateParserTest.java:86)
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_AD(Java15BugFastDateParserTest.java:94)


Error: 
  org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_BC(TriFunction)[1]  Time elapsed: 0.057 s  <<< FAILURE!

org.opentest4j.AssertionFailedError:
locale : sq_MK, formattedDate : p.K./2003/shkurt/0010/0012//00/e 
paradites/e shtunë, Java: 16-ea+29
  ==> expected:  but was: 12 12:00:00 GMT+00:00 2003>
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales(Java15BugFastDateParserTest.java:86)
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_BC(Java15BugFastDateParserTest.java:101)


Error: 
  org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales_Long_BC(TriFunction)[2]  Time elapsed: 0.033 s  <<< FAILURE!

org.opentest4j.AssertionFailedError:
locale : sq_MK, formattedDate : p.K./2003/shkurt/0010/0012//00/e 
paradites/e shtunë, Java: 16-ea+29
  ==> expected:  but was: 12 12:00:00 GMT+00:00 2003>
at 
org.apache.commons.lang3.time.Java15BugFastDateParserTest.testLocales(Java15BugFastDateParserTest.java:86)
at 
org.apa

[ JEXL ] Preparing release

[Henri Biestro]

Hello Team; Happy new year!

I'm trying (again) to release JEXL 3.2 and I'm stuck at the 'Maven release 
plugin' step in https://commons.apache.org/releases/prepare.html.

Despite the fact a 'maven site' from IntelliJ does succeed, a 'mv 
release:prepare -DtryRun' fails generating the Javadoc with a:
[INFO] [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on 
project commons-jexl3: MavenReportException: Error while generating Javadoc: 
[INFO] [ERROR] Exit code: 1 - 
/Users/henri.biestro/Java/Jexl/git/commons-jexl/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java:128:
 warning: no description for @param

The package is excluded in the configuration so I must be missing an obvious 
step somewhere else to let maven do its magic properly.
Any help appreciated :-)



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ JEXL ] Preparing release

[Gary Gregory]

You "should" fix the Javadoc warnings; -) or disable doclint.

Gary


On Tue, Jan 5, 2021, 12:06 Henri Biestro  wrote:

> Hello Team; Happy new year!
>
> I'm trying (again) to release JEXL 3.2 and I'm stuck at the 'Maven release
> plugin' step in https://commons.apache.org/releases/prepare.html.
>
> Despite the fact a 'maven site' from IntelliJ does succeed, a 'mv
> release:prepare -DtryRun' fails generating the Javadoc with a:
> [INFO] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs)
> on project commons-jexl3: MavenReportException: Error while generating
> Javadoc:
> [INFO] [ERROR] Exit code: 1 -
> /Users/henri.biestro/Java/Jexl/git/commons-jexl/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java:128:
> warning: no description for @param
>
> The package is excluded in the configuration so I must be missing an
> obvious step somewhere else to let maven do its magic properly.
> Any help appreciated :-)
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [ JEXL ] Preparing release

[John Patrick]

What version of java is the command line maven using and what is
intellij using for;
1. Settings -> "Build, Execution, Deployment" -> "Build Tools" ->
Maven -> Importing -> "JDK for importer"
2. Settings -> "Build, Execution, Deployment" -> "Build Tools" ->
Maven -> Runner -> "JDK for importer"
3. "Project Structure" -> Project -> "Project SDK"

As when running maven tasks within IntelliJ, I can never remember
which of 1, 2 or 3 is used.

1 is used when importing and refreshing maven projects, so if you have
conditional profiles with activation based upon jvm, changing this
might be needed.
2 i think is used when running tasks
3 is used when writing code, validating code and also compiling code.
3 i think is also used when running unit tests

Not sure if that will show other issues of fix this issue, hopefully
it maybe highlight if different jvm's are being used when comparing
inside and outside intellij.

John


On Tue, 5 Jan 2021 at 17:06, Henri Biestro  wrote:
>
> Hello Team; Happy new year!
>
> I'm trying (again) to release JEXL 3.2 and I'm stuck at the 'Maven release 
> plugin' step in https://commons.apache.org/releases/prepare.html.
>
> Despite the fact a 'maven site' from IntelliJ does succeed, a 'mv 
> release:prepare -DtryRun' fails generating the Javadoc with a:
> [INFO] [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on 
> project commons-jexl3: MavenReportException: Error while generating Javadoc:
> [INFO] [ERROR] Exit code: 1 - 
> /Users/henri.biestro/Java/Jexl/git/commons-jexl/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java:128:
>  warning: no description for @param
>
> The package is excluded in the configuration so I must be missing an obvious 
> step somewhere else to let maven do its magic properly.
> Any help appreciated :-)
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ JEXL ] Preparing release

[Gary Gregory]

I you are working toward a release, I recommend working with Maven on the
command line. You'll want to know exactly what is going on.

Gary


On Tue, Jan 5, 2021, 17:31 John Patrick  wrote:

> What version of java is the command line maven using and what is
> intellij using for;
> 1. Settings -> "Build, Execution, Deployment" -> "Build Tools" ->
> Maven -> Importing -> "JDK for importer"
> 2. Settings -> "Build, Execution, Deployment" -> "Build Tools" ->
> Maven -> Runner -> "JDK for importer"
> 3. "Project Structure" -> Project -> "Project SDK"
>
> As when running maven tasks within IntelliJ, I can never remember
> which of 1, 2 or 3 is used.
>
> 1 is used when importing and refreshing maven projects, so if you have
> conditional profiles with activation based upon jvm, changing this
> might be needed.
> 2 i think is used when running tasks
> 3 is used when writing code, validating code and also compiling code.
> 3 i think is also used when running unit tests
>
> Not sure if that will show other issues of fix this issue, hopefully
> it maybe highlight if different jvm's are being used when comparing
> inside and outside intellij.
>
> John
>
>
> On Tue, 5 Jan 2021 at 17:06, Henri Biestro  wrote:
> >
> > Hello Team; Happy new year!
> >
> > I'm trying (again) to release JEXL 3.2 and I'm stuck at the 'Maven
> release plugin' step in https://commons.apache.org/releases/prepare.html.
> >
> > Despite the fact a 'maven site' from IntelliJ does succeed, a 'mv
> release:prepare -DtryRun' fails generating the Javadoc with a:
> > [INFO] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs)
> on project commons-jexl3: MavenReportException: Error while generating
> Javadoc:
> > [INFO] [ERROR] Exit code: 1 -
> /Users/henri.biestro/Java/Jexl/git/commons-jexl/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java:128:
> warning: no description for @param
> >
> > The package is excluded in the configuration so I must be missing an
> obvious step somewhere else to let maven do its magic properly.
> > Any help appreciated :-)
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [ JEXL ] Preparing release

[Henri Biestro]

I'm working from the command line following the steps outlined in the doc.
I can not fix the Javadoc because these classes are generated by javacc, the 
whole package is intended to be ignored (excluded) and docLint is already off.
'mvn site' succeeds, 'mvn release:prepare -DtryRun' fails; it seems there 
release plugin is using a different configuration wrt javadoc generation.
..

org.apache.maven.plugins
maven-javadoc-plugin


*.internal:*.parser
public
none


..
I seek help, not diss.

On 2021/01/05 19:00:57, Gary Gregory  wrote: 
> You "should" fix the Javadoc warnings; -) or disable doclint.
> 
> Gary
> 
> 
> On Tue, Jan 5, 2021, 12:06 Henri Biestro  wrote:
> 
> > Hello Team; Happy new year!
> >
> > I'm trying (again) to release JEXL 3.2 and I'm stuck at the 'Maven release
> > plugin' step in https://commons.apache.org/releases/prepare.html.
> >
> > Despite the fact a 'maven site' from IntelliJ does succeed, a 'mv
> > release:prepare -DtryRun' fails generating the Javadoc with a:
> > [INFO] [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs)
> > on project commons-jexl3: MavenReportException: Error while generating
> > Javadoc:
> > [INFO] [ERROR] Exit code: 1 -
> > /Users/henri.biestro/Java/Jexl/git/commons-jexl/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java:128:
> > warning: no description for @param
> >
> > The package is excluded in the configuration so I must be missing an
> > obvious step somewhere else to let maven do its magic properly.
> > Any help appreciated :-)
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org