Re: [All] CP definitions

2018-09-21 Thread Gilles

On Fri, 21 Sep 2018 09:26:07 -0600, Gary Gregory wrote:
On Fri, Sep 21, 2018 at 7:05 AM Gilles  
wrote:



On Fri, 21 Sep 2018 08:52:37 -0400, Rob Tompkins wrote:
>> On Sep 20, 2018, at 9:31 AM, Gilles 


>> wrote:
>>
>> On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote:
 On Sep 20, 2018, at 3:10 AM, Benedikt Ritter 


 wrote:

 Hello,

 Reverting this change was discussed here [1]. It was a result 
of

 this
 commit [2] breaking multiple component builds. As Stefan points
 out the
 initial change does not make sense, since the componentId is
 always just
 the name without "commons-" (e.g. math4). But the folders for 
all

 the
 websites have the commons prefix (e.g. commons-math).

 I just restored the old (working) behavior. I'm fine with 
making

 things
 easier/more straight forward. But let's make sure that all the
 other
 components still work.
>>>
>>> I’m relatively indifferent to how we accomplish this. For the 
sake

>>> of
>>> discussion let our project.artifactId=commons-something where N
>>> represents the major version of the release with N being the 
empty
>>> string for a major version equal to 1. We still are stuck with 
half

>>> of
>>> our projects in one state for building with 
componentid=something

>>> and
>>> the other half with componentid=somethingN. Furthermore we need 
a

>>> properties representing both “something” as well as “somethingN”
>>> given
>>> that we have our dist urls and site urls not containing the 
major

>>> release version.
>>>
>>> Do you propose something other than:
>>>
>>> something
>>> somethingN
>>>
>>> and change [parent] back to
>>>
>>> 
>>>
>>>
>>>

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
>>> 
>>> 
>>
>> What about starting from maven requirements and try and avoid
>> redundancies (that ultimately lead to inconsistencies)?
>>
>> Given are
>>  
>>  
>
> I’m actually indifferent to how we approach this.

Discussion should be on what is
1. desirable
2. achievable

And, if you are willing to continue your work on this, it is
IMO desirable to take this opportunity to actually reduce the
level of redundancy found in the projects' POMs, with all their
slight variations that keep things more complicated than they
could be.

> I’m more just
> motivated to pick a direction and get it behind us.

Do you know whether it is possible to go in the direction
which I propose?



The original problem this solved is that components that did use a 
version
number in their artifact ID has to do to much redefining in their 
POMs.


We are now entering bike-shedding territory IMO.


Unfair.


As Sebb (IIRC) pointed out
elsewhere, a component does not have to update to a new CP version. 
If it

does, obviously, it has to adapt.


I don't agree: Components that used to delegate to CP should not start
doing everything by themselves because some CP update is not adequate
for all components.  Case in point: at some point, CP evolution broke
multi-module builds, while update was *required* to support newer JDK.


I sincerely believe that we are all
trying to make Commons better.


Didn't say otherwise.  Just that we cannot stay in the middle of
the river (meaning: some components cannot build).


There is no compatibility guarantees for our
internal components but of course we do not want to create headaches 
if we

do not have to.


Thank you.
Current headache is: How do I make "mvn site:stage" work for [RNG]?


We MUST make the distinction between an artifactId and
OtherID (pick names, today, packageId and componentId) which does not
include the major version number. That's what the current CP does and 
works
for some components that have been released. CP also reduces the 
amount of
properties you have to redefine in components, like the various URLs. 
My
POV here is that we can make adjustments to CP but there is no need 
for
some higher level discussion about "desirable" and "achievable". The 
goal
has been achieved IMO, using packageId and componentId, you can write 
POMs
that work for components that either have a version number or not in 
their

artifact IDs.


IMO conciseness would help. Not arguing further; those who do the work
will choose whatever suits them.

Gilles




Gary



Gilles

> @Benedikt - you
> have any thoughts on how we keep records of both “lang” as well as
> “lang3” in the parent for the sake of our surrounding ecosystem??
>
> -Rob
>
>>
>> Can the parent POM generate the properties values required by
>> the "Commons" infrastructure from those (using maven plugin
>> code, I guess)?
>>
>> E.g. generate "commons-lang" (a.o. to generate the path to the
>> web site's SVN repository) from
>>  commons-lang3
>>  3.9-SNAPSHOT
>>
>> [Side-effect would be to enforce the rule for changing top-level
>> package name in step with a new major version.]
>>
>> Best regards,
>> Gilles
>>
>>>
>>> If so, what is it? Let’s pick 

Re: [All] CP definitions

2018-09-21 Thread Rob Tompkins


> On Sep 21, 2018, at 11:26 AM, Gary Gregory  wrote:
> 
> On Fri, Sep 21, 2018 at 7:05 AM Gilles  > wrote:
> 
>> On Fri, 21 Sep 2018 08:52:37 -0400, Rob Tompkins wrote:
 On Sep 20, 2018, at 9:31 AM, Gilles 
 wrote:
 
 On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote:
>> On Sep 20, 2018, at 3:10 AM, Benedikt Ritter 
>> wrote:
>> 
>> Hello,
>> 
>> Reverting this change was discussed here [1]. It was a result of
>> this
>> commit [2] breaking multiple component builds. As Stefan points
>> out the
>> initial change does not make sense, since the componentId is
>> always just
>> the name without "commons-" (e.g. math4). But the folders for all
>> the
>> websites have the commons prefix (e.g. commons-math).
>> 
>> I just restored the old (working) behavior. I'm fine with making
>> things
>> easier/more straight forward. But let's make sure that all the
>> other
>> components still work.
> 
> I’m relatively indifferent to how we accomplish this. For the sake
> of
> discussion let our project.artifactId=commons-something where N
> represents the major version of the release with N being the empty
> string for a major version equal to 1. We still are stuck with half
> of
> our projects in one state for building with componentid=something
> and
> the other half with componentid=somethingN. Furthermore we need a
> properties representing both “something” as well as “somethingN”
> given
> that we have our dist urls and site urls not containing the major
> release version.
> 
> Do you propose something other than:
> 
> something
> somethingN
> 
> and change [parent] back to
> 
> 
> 
> 
> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
> 
> 
 
 What about starting from maven requirements and try and avoid
 redundancies (that ultimately lead to inconsistencies)?
 
 Given are
 
 
>>> 
>>> I’m actually indifferent to how we approach this.
>> 
>> Discussion should be on what is
>> 1. desirable
>> 2. achievable
>> 
>> And, if you are willing to continue your work on this, it is
>> IMO desirable to take this opportunity to actually reduce the
>> level of redundancy found in the projects' POMs, with all their
>> slight variations that keep things more complicated than they
>> could be.
>> 
>>> I’m more just
>>> motivated to pick a direction and get it behind us.
>> 
>> Do you know whether it is possible to go in the direction
>> which I propose?
>> 
> 
> The original problem this solved is that components that did use a version
> number in their artifact ID has to do to much redefining in their POMs.
> 
> We are now entering bike-shedding territory IMO. As Sebb (IIRC) pointed out
> elsewhere, a component does not have to update to a new CP version. If it
> does, obviously, it has to adapt. I sincerely believe that we are all
> trying to make Commons better. There is no compatibility guarantees for our
> internal components but of course we do not want to create headaches if we
> do not have to. We MUST make the distinction between an artifactId and
> OtherID (pick names, today, packageId and componentId) which does not
> include the major version number. That's what the current CP does and works
> for some components that have been released. CP also reduces the amount of
> properties you have to redefine in components, like the various URLs. My
> POV here is that we can make adjustments to CP but there is no need for
> some higher level discussion about "desirable" and "achievable". The goal
> has been achieved IMO, using packageId and componentId, you can write POMs
> that work for components that either have a version number or not in their
> artifact IDs.

I’ll try to over the next few days sort this out across all the projects 
consuming cp 47 so that we don’t see this problem again.

-Rob

> 
> Gary
> 
> 
>> Gilles
>> 
>>> @Benedikt - you
>>> have any thoughts on how we keep records of both “lang” as well as
>>> “lang3” in the parent for the sake of our surrounding ecosystem??
>>> 
>>> -Rob
>>> 
 
 Can the parent POM generate the properties values required by
 the "Commons" infrastructure from those (using maven plugin
 code, I guess)?
 
 E.g. generate "commons-lang" (a.o. to generate the path to the
 web site's SVN repository) from
 commons-lang3
 3.9-SNAPSHOT
 
 [Side-effect would be to enforce the rule for changing top-level
 package name in step with a new major version.]
 
 Best regards,
 Gilles
 
> 
> If so, what is it? Let’s pick it and move forward.
> 
> Cheers,
> -Rob
> 
> [Ref]
> June conversation on the matter as well.
> https://markmail.org/message/7xbk3zm6pornsrto
> 

Re: [All] CP definitions

2018-09-21 Thread Gilles

On Fri, 21 Sep 2018 08:52:37 -0400, Rob Tompkins wrote:
On Sep 20, 2018, at 9:31 AM, Gilles  
wrote:


On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote:
On Sep 20, 2018, at 3:10 AM, Benedikt Ritter  
wrote:


Hello,

Reverting this change was discussed here [1]. It was a result of 
this
commit [2] breaking multiple component builds. As Stefan points 
out the
initial change does not make sense, since the componentId is 
always just
the name without "commons-" (e.g. math4). But the folders for all 
the

websites have the commons prefix (e.g. commons-math).

I just restored the old (working) behavior. I'm fine with making 
things
easier/more straight forward. But let's make sure that all the 
other

components still work.


I’m relatively indifferent to how we accomplish this. For the sake 
of

discussion let our project.artifactId=commons-something where N
represents the major version of the release with N being the empty
string for a major version equal to 1. We still are stuck with half 
of
our projects in one state for building with componentid=something 
and

the other half with componentid=somethingN. Furthermore we need a
properties representing both “something” as well as “somethingN” 
given

that we have our dist urls and site urls not containing the major
release version.

Do you propose something other than:

something
somethingN

and change [parent] back to




https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}




What about starting from maven requirements and try and avoid
redundancies (that ultimately lead to inconsistencies)?

Given are
 
 


I’m actually indifferent to how we approach this.


Discussion should be on what is
1. desirable
2. achievable

And, if you are willing to continue your work on this, it is
IMO desirable to take this opportunity to actually reduce the
level of redundancy found in the projects' POMs, with all their
slight variations that keep things more complicated than they
could be.


I’m more just
motivated to pick a direction and get it behind us.


Do you know whether it is possible to go in the direction
which I propose?

Gilles


@Benedikt - you
have any thoughts on how we keep records of both “lang” as well as
“lang3” in the parent for the sake of our surrounding ecosystem??

-Rob



Can the parent POM generate the properties values required by
the "Commons" infrastructure from those (using maven plugin
code, I guess)?

E.g. generate "commons-lang" (a.o. to generate the path to the
web site's SVN repository) from
 commons-lang3
 3.9-SNAPSHOT

[Side-effect would be to enforce the rule for changing top-level
package name in step with a new major version.]

Best regards,
Gilles



If so, what is it? Let’s pick it and move forward.

Cheers,
-Rob

[Ref]
June conversation on the matter as well.
https://markmail.org/message/7xbk3zm6pornsrto 





[...]






-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions

2018-09-21 Thread Rob Tompkins


> On Sep 20, 2018, at 9:31 AM, Gilles  wrote:
> 
> On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote:
>>> On Sep 20, 2018, at 3:10 AM, Benedikt Ritter  wrote:
>>> 
>>> Hello,
>>> 
>>> Reverting this change was discussed here [1]. It was a result of this
>>> commit [2] breaking multiple component builds. As Stefan points out the
>>> initial change does not make sense, since the componentId is always just
>>> the name without "commons-" (e.g. math4). But the folders for all the
>>> websites have the commons prefix (e.g. commons-math).
>>> 
>>> I just restored the old (working) behavior. I'm fine with making things
>>> easier/more straight forward. But let's make sure that all the other
>>> components still work.
>> 
>> I’m relatively indifferent to how we accomplish this. For the sake of
>> discussion let our project.artifactId=commons-something where N
>> represents the major version of the release with N being the empty
>> string for a major version equal to 1. We still are stuck with half of
>> our projects in one state for building with componentid=something and
>> the other half with componentid=somethingN. Furthermore we need a
>> properties representing both “something” as well as “somethingN” given
>> that we have our dist urls and site urls not containing the major
>> release version.
>> 
>> Do you propose something other than:
>> 
>> something
>> somethingN
>> 
>> and change [parent] back to
>> 
>> 
>> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
>> 
>> 
> 
> What about starting from maven requirements and try and avoid
> redundancies (that ultimately lead to inconsistencies)?
> 
> Given are
>  
>  

I’m actually indifferent to how we approach this. I’m more just motivated to 
pick a direction and get it behind us. @Benedikt - you have any thoughts on how 
we keep records of both “lang” as well as “lang3” in the parent for the sake of 
our surrounding ecosystem??

-Rob

> 
> Can the parent POM generate the properties values required by
> the "Commons" infrastructure from those (using maven plugin
> code, I guess)?
> 
> E.g. generate "commons-lang" (a.o. to generate the path to the
> web site's SVN repository) from
>  commons-lang3
>  3.9-SNAPSHOT
> 
> [Side-effect would be to enforce the rule for changing top-level
> package name in step with a new major version.]
> 
> Best regards,
> Gilles
> 
>> 
>> If so, what is it? Let’s pick it and move forward.
>> 
>> Cheers,
>> -Rob
>> 
>> [Ref]
>> June conversation on the matter as well.
>> https://markmail.org/message/7xbk3zm6pornsrto 
>> 
>> 
>>> 
>>> [...]
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
> 
> For additional commands, e-mail: dev-h...@commons.apache.org 
> 


Re: [All] CP definitions

2018-09-20 Thread Gilles

On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote:
On Sep 20, 2018, at 3:10 AM, Benedikt Ritter  
wrote:


Hello,

Reverting this change was discussed here [1]. It was a result of 
this
commit [2] breaking multiple component builds. As Stefan points out 
the
initial change does not make sense, since the componentId is always 
just
the name without "commons-" (e.g. math4). But the folders for all 
the

websites have the commons prefix (e.g. commons-math).

I just restored the old (working) behavior. I'm fine with making 
things

easier/more straight forward. But let's make sure that all the other
components still work.


I’m relatively indifferent to how we accomplish this. For the sake of
discussion let our project.artifactId=commons-something where N
represents the major version of the release with N being the empty
string for a major version equal to 1. We still are stuck with half 
of

our projects in one state for building with componentid=something and
the other half with componentid=somethingN. Furthermore we need a
properties representing both “something” as well as “somethingN” 
given

that we have our dist urls and site urls not containing the major
release version.

Do you propose something other than:

something
somethingN

and change [parent] back to




https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}




What about starting from maven requirements and try and avoid
redundancies (that ultimately lead to inconsistencies)?

Given are
  
  

Can the parent POM generate the properties values required by
the "Commons" infrastructure from those (using maven plugin
code, I guess)?

E.g. generate "commons-lang" (a.o. to generate the path to the
web site's SVN repository) from
  commons-lang3
  3.9-SNAPSHOT

[Side-effect would be to enforce the rule for changing top-level
package name in step with a new major version.]

Best regards,
Gilles



If so, what is it? Let’s pick it and move forward.

Cheers,
-Rob

[Ref]
June conversation on the matter as well.
https://markmail.org/message/7xbk3zm6pornsrto



[...]



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-20 Thread Rob Tompkins



> On Sep 20, 2018, at 3:10 AM, Benedikt Ritter  wrote:
> 
> Hello,
> 
> Reverting this change was discussed here [1]. It was a result of this
> commit [2] breaking multiple component builds. As Stefan points out the
> initial change does not make sense, since the componentId is always just
> the name without "commons-" (e.g. math4). But the folders for all the
> websites have the commons prefix (e.g. commons-math).
> 
> I just restored the old (working) behavior. I'm fine with making things
> easier/more straight forward. But let's make sure that all the other
> components still work.

I’m relatively indifferent to how we accomplish this. For the sake of 
discussion let our project.artifactId=commons-something where N represents the 
major version of the release with N being the empty string for a major version 
equal to 1. We still are stuck with half of our projects in one state for 
building with componentid=something and the other half with 
componentid=somethingN. Furthermore we need a properties representing both 
“something” as well as “somethingN” given that we have our dist urls and site 
urls not containing the major release version. 

Do you propose something other than:

something
somethingN

and change [parent] back to



https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}



If so, what is it? Let’s pick it and move forward.

Cheers,
-Rob

[Ref]
June conversation on the matter as well.
https://markmail.org/message/7xbk3zm6pornsrto

> 
> Regards,
> Benedikt
> 
> [1]
> https://lists.apache.org/thread.html/304129bf7d25a2118ee3f324214c04e1e8f0846e7ee43a57b100a26e@%3Cdev.commons.apache.org%3E
> [2]
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1831599=1832339
> 
> Am Mi., 19. Sep. 2018 um 17:25 Uhr schrieb Gary Gregory <
> garydgreg...@gmail.com>:
> 
>> On Wed, Sep 19, 2018 at 8:30 AM Rob Tompkins  wrote:
>> 
>>> I think the plan moving forward here is that we should do the following:
>>> 
>>> math
>>> math4
>>> 
>>> And change [parent] back to
>>> 
>>> 
>>> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
>>> 
>>> 
>>> Yeah?
>>> 
>> 
>> LGTM.
>> 
>> Gary
>> 
>> 
>>> 
>>> -Rob
>>> 
 On Sep 19, 2018, at 9:36 AM, Rob Tompkins  wrote:
 
 
 
> On Sep 19, 2018, at 9:28 AM, Gilles 
>>> wrote:
> 
>> On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
>> The difference is to account for artifact ids that contain a version
>>> like
>> commons-lang3. The component id is then just commons-lang. You must
>> not
>> have versions in names for certain names like in the download page.
>>> This
>> change will probably break builds like pool, dbcp, lang, and so on.
> 
> Hmm, this completes the confusion!
> 
> If "artifactId" is e.g. commons-lang3 then I don't understand how
> the reverted line works because (AFAICT) the SVN URL is
> 
>>> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/
> 
> The [Math] POM contains these lines:
> ---CUT---
>  
>  math4
> ---CUT---
> Correct or not?
 
 Half of the components are correct, half aren’t.
 
 What’s the consensus here? My thought was that componentId=math is
>>> actually correct based on the documentation, and we need and
>>> “artifactIdSuffix” or something analogous.
 
 -Rob
 
> 
> It also uses a fix string:
> ---CUT---
> 
>>> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
>>> 
> ---CUT---
> whereas a variable (as in the commit below) would seem more portable.
> 
> Why isn't "" defined in CP only (using the
>>> appropriate
> variable overridden in each component)?
> 
> Why having
> ---CUT---
> math
> ---CUT---
> that doesn't look at all like a "path"?
> We could define a quite more explicit ""
> that could serve for composing a path, as well as for any
> other purpose where the component is meant, independently
> of artefact identifier syntax or major version.
> 
> 
> Regards,
> Gilles
> 
>> Gary
>> 
>>> On Wed, Sep 19, 2018, 04:07 Gilles 
>>> wrote:
>>> 
>>> Hi.
>>> 
>>> Are we sure that the fix/revert below to work as intended for
>>> *all* components?
>>> 
>>> Common usage should be enforced (e.g. to allow anyone to help
>>> releasing any component), and ancient inconsistencies fixed.
>>> 
>>> With a concrete example of a component that has had major
>>> version changes (and top-level package change accordingly),
>>> what is
>>> commons.componentid
>>> and what is
>>> project.artefactId
>>> ?
>>> 
>>> Thanks,
>>> Gilles
>>> 
>>> On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
 Author: britter

Re: [All] CP definitions

2018-09-20 Thread Gilles

On Thu, 20 Sep 2018 09:10:50 +0200, Benedikt Ritter wrote:

Hello,

Reverting this change was discussed here [1]. It was a result of this
commit [2] breaking multiple component builds. As Stefan points out 
the
initial change does not make sense, since the componentId is always 
just

the name without "commons-" (e.g. math4). But the folders for all the
websites have the commons prefix (e.g. commons-math).

I just restored the old (working) behavior. I'm fine with making 
things

easier/more straight forward.


I'm for it too. But not everyone is (or thinks that things
get easier)...


But let's make sure that all the other
components still work.


I certainly agree, and am also frustrated that what used to work
suddenly doesn't anymore without anything related having changed
within the component's source repository.
Case in point is [RNG]: "mvn site:stage" doesn't work in "master"
for any version of CP. :-(

Gilles


Regards,
Benedikt

[1]

https://lists.apache.org/thread.html/304129bf7d25a2118ee3f324214c04e1e8f0846e7ee43a57b100a26e@%3Cdev.commons.apache.org%3E
[2]

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1831599=1832339




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Gary Gregory
On Wed, Sep 19, 2018 at 8:30 AM Rob Tompkins  wrote:

> I think the plan moving forward here is that we should do the following:
>
> math
> math4
>
> And change [parent] back to
>
> 
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
> 
>
> Yeah?
>

LGTM.

Gary


>
> -Rob
>
> > On Sep 19, 2018, at 9:36 AM, Rob Tompkins  wrote:
> >
> >
> >
> >> On Sep 19, 2018, at 9:28 AM, Gilles 
> wrote:
> >>
> >>> On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
> >>> The difference is to account for artifact ids that contain a version
> like
> >>> commons-lang3. The component id is then just commons-lang. You must not
> >>> have versions in names for certain names like in the download page.
> This
> >>> change will probably break builds like pool, dbcp, lang, and so on.
> >>
> >> Hmm, this completes the confusion!
> >>
> >> If "artifactId" is e.g. commons-lang3 then I don't understand how
> >> the reverted line works because (AFAICT) the SVN URL is
> >>
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/
> >>
> >> The [Math] POM contains these lines:
> >> ---CUT---
> >>   
> >>   math4
> >> ---CUT---
> >> Correct or not?
> >
> > Half of the components are correct, half aren’t.
> >
> > What’s the consensus here? My thought was that componentId=math is
> actually correct based on the documentation, and we need and
> “artifactIdSuffix” or something analogous.
> >
> > -Rob
> >
> >>
> >> It also uses a fix string:
> >> ---CUT---
> >> 
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
> 
> >> ---CUT---
> >> whereas a variable (as in the commit below) would seem more portable.
> >>
> >> Why isn't "" defined in CP only (using the
> appropriate
> >> variable overridden in each component)?
> >>
> >> Why having
> >> ---CUT---
> >> math
> >> ---CUT---
> >> that doesn't look at all like a "path"?
> >> We could define a quite more explicit ""
> >> that could serve for composing a path, as well as for any
> >> other purpose where the component is meant, independently
> >> of artefact identifier syntax or major version.
> >>
> >>
> >> Regards,
> >> Gilles
> >>
> >>> Gary
> >>>
>  On Wed, Sep 19, 2018, 04:07 Gilles 
> wrote:
> 
>  Hi.
> 
>  Are we sure that the fix/revert below to work as intended for
>  *all* components?
> 
>  Common usage should be enforced (e.g. to allow anyone to help
>  releasing any component), and ancient inconsistencies fixed.
> 
>  With a concrete example of a component that has had major
>  version changes (and top-level package change accordingly),
>  what is
>  commons.componentid
>  and what is
>  project.artefactId
>  ?
> 
>  Thanks,
>  Gilles
> 
>  On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
> > Author: britter
> > Date: Wed Sep 19 08:06:17 2018
> > New Revision: 1841296
> >
> > URL: http://svn.apache.org/viewvc?rev=1841296=rev
> > Log:
> > COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
> >
> > Modified:
> >commons/proper/commons-parent/trunk/pom.xml
> >commons/proper/commons-parent/trunk/src/changes/changes.xml
> >
> > Modified: commons/proper/commons-parent/trunk/pom.xml
> > URL:
> >
> >
> 
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
> >
> >
> 
> ==
> > --- commons/proper/commons-parent/trunk/pom.xml (original)
> > +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
> > 2018
> > @@ -1940,7 +1940,7 @@
> > 
> > ${commons.componentid}
> >
> > -
> >
> > 
> 
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
>  
> > +
> >
> > 
> 
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
>  
> >
> >
> >
> 
> ${commons.site.cache}/${commons.site.path}
> > commons.site
> >
> >
> > Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
> > URL:
> >
> >
> 
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
> >
> >
> 
> ==
> > --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> > (original)
> > +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
> > Sep 19 08:06:17 2018
> > @@ -61,6 +61,7 @@ The  type attribute can be add,u
> > 
> >
> > 
> > + > dev="britter">Revert change in commons.scmPubUrl in Parent
> > 47
> >  

Re: [All] CP definitions

2018-09-19 Thread Gilles

On Wed, 19 Sep 2018 10:28:50 -0400, Rob Tompkins wrote:
I think the plan moving forward here is that we should do the 
following:


math
math4


See my other post for an alternative.



And change [parent] back to


https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}


If possible, we should either create the Jenkins jobs I
referred to in a previous message, or reimplement some
functionality in CP so as to not break existing POMs
(managed by people who do not yet want to change how
they perform a release).

For example, the component's POM should not need to define
the above path; everything should be transparently performed
as part of a new "rob-release" profile. :-)

Gilles



Yeah?

-Rob


[...]


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Rob Tompkins
I think the plan moving forward here is that we should do the following:

math
math4

And change [parent] back to

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}

Yeah?

-Rob

> On Sep 19, 2018, at 9:36 AM, Rob Tompkins  wrote:
> 
> 
> 
>> On Sep 19, 2018, at 9:28 AM, Gilles  wrote:
>> 
>>> On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
>>> The difference is to account for artifact ids that contain a version like
>>> commons-lang3. The component id is then just commons-lang. You must not
>>> have versions in names for certain names like in the download page. This
>>> change will probably break builds like pool, dbcp, lang, and so on.
>> 
>> Hmm, this completes the confusion!
>> 
>> If "artifactId" is e.g. commons-lang3 then I don't understand how
>> the reverted line works because (AFAICT) the SVN URL is
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/
>> 
>> The [Math] POM contains these lines:
>> ---CUT---
>>   
>>   math4
>> ---CUT---
>> Correct or not?
> 
> Half of the components are correct, half aren’t. 
> 
> What’s the consensus here? My thought was that componentId=math is actually 
> correct based on the documentation, and we need and “artifactIdSuffix” or 
> something analogous. 
> 
> -Rob
> 
>> 
>> It also uses a fix string:
>> ---CUT---
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
>> ---CUT---
>> whereas a variable (as in the commit below) would seem more portable.
>> 
>> Why isn't "" defined in CP only (using the appropriate
>> variable overridden in each component)?
>> 
>> Why having
>> ---CUT---
>> math
>> ---CUT---
>> that doesn't look at all like a "path"?
>> We could define a quite more explicit ""
>> that could serve for composing a path, as well as for any
>> other purpose where the component is meant, independently
>> of artefact identifier syntax or major version.
>> 
>> 
>> Regards,
>> Gilles
>> 
>>> Gary
>>> 
 On Wed, Sep 19, 2018, 04:07 Gilles  wrote:
 
 Hi.
 
 Are we sure that the fix/revert below to work as intended for
 *all* components?
 
 Common usage should be enforced (e.g. to allow anyone to help
 releasing any component), and ancient inconsistencies fixed.
 
 With a concrete example of a component that has had major
 version changes (and top-level package change accordingly),
 what is
 commons.componentid
 and what is
 project.artefactId
 ?
 
 Thanks,
 Gilles
 
 On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
> Author: britter
> Date: Wed Sep 19 08:06:17 2018
> New Revision: 1841296
> 
> URL: http://svn.apache.org/viewvc?rev=1841296=rev
> Log:
> COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
> 
> Modified:
>commons/proper/commons-parent/trunk/pom.xml
>commons/proper/commons-parent/trunk/src/changes/changes.xml
> 
> Modified: commons/proper/commons-parent/trunk/pom.xml
> URL:
> 
> 
 http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
> 
> 
 ==
> --- commons/proper/commons-parent/trunk/pom.xml (original)
> +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
> 2018
> @@ -1940,7 +1940,7 @@
> 
> ${commons.componentid}
> 
> -
> 
> 
 https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
 
> +
> 
> 
 https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
 
> 
> 
> 
 ${commons.site.cache}/${commons.site.path}
> commons.site
> 
> 
> Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
> URL:
> 
> 
 http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
> 
> 
 ==
> --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> (original)
> +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
> Sep 19 08:06:17 2018
> @@ -61,6 +61,7 @@ The  type attribute can be add,u
> 
> 
> 
> + dev="britter">Revert change in commons.scmPubUrl in Parent
> 47
> Update parent from
> org.apache:apache 19 to 20.
> maven-compiler-plugin 3.7.0 ->
> 3.8.0
> re-enabled japicmp and introduced
> japicmp.skip property that
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For 

Re: [All] CP definitions

2018-09-19 Thread Gilles

On Wed, 19 Sep 2018 09:36:25 -0400, Rob Tompkins wrote:
On Sep 19, 2018, at 9:28 AM, Gilles  
wrote:



On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
The difference is to account for artifact ids that contain a 
version like
commons-lang3. The component id is then just commons-lang. You must 
not
have versions in names for certain names like in the download page. 
This

change will probably break builds like pool, dbcp, lang, and so on.


Hmm, this completes the confusion!

If "artifactId" is e.g. commons-lang3 then I don't understand how
the reverted line works because (AFAICT) the SVN URL is
 
https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/


The [Math] POM contains these lines:
---CUT---
   
   math4
---CUT---
Correct or not?


Half of the components are correct, half aren’t.

What’s the consensus here? My thought was that componentId=math is
actually correct based on the documentation, and we need and
“artifactIdSuffix” or something analogous.


We need to reduce the number of variations on a name.

I propose something like:

lang
3

Then, all the various names can be constructed, and
hopefully most of the currently duplicated functionality
can be removed, and the "right things" be done in CP.

Gilles



-Rob



It also uses a fix string:
---CUT---

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
---CUT---
whereas a variable (as in the commit below) would seem more 
portable.


Why isn't "" defined in CP only (using the 
appropriate

variable overridden in each component)?

Why having
---CUT---
math
---CUT---
that doesn't look at all like a "path"?
We could define a quite more explicit ""
that could serve for composing a path, as well as for any
other purpose where the component is meant, independently
of artefact identifier syntax or major version.


Regards,
Gilles


Gary

On Wed, Sep 19, 2018, 04:07 Gilles  
wrote:


Hi.

Are we sure that the fix/revert below to work as intended for
*all* components?

Common usage should be enforced (e.g. to allow anyone to help
releasing any component), and ancient inconsistencies fixed.

With a concrete example of a component that has had major
version changes (and top-level package change accordingly),
what is
 commons.componentid
and what is
 project.artefactId
?

Thanks,
Gilles

On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
> Author: britter
> Date: Wed Sep 19 08:06:17 2018
> New Revision: 1841296
>
> URL: http://svn.apache.org/viewvc?rev=1841296=rev
> Log:
> COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
>
> Modified:
> commons/proper/commons-parent/trunk/pom.xml
> commons/proper/commons-parent/trunk/src/changes/changes.xml
>
> Modified: commons/proper/commons-parent/trunk/pom.xml
> URL:
>
>

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
>
>

==
> --- commons/proper/commons-parent/trunk/pom.xml (original)
> +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 
08:06:17

> 2018
> @@ -1940,7 +1940,7 @@
>  
>  
${commons.componentid}

>
> -
>
> 

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}

> +
>
> 

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}

>
>
>

${commons.site.cache}/${commons.site.path}
>  commons.site
>
>
> Modified: 
commons/proper/commons-parent/trunk/src/changes/changes.xml

> URL:
>
>

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
>
>

==
> --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> (original)
> +++ commons/proper/commons-parent/trunk/src/changes/changes.xml 
Wed

> Sep 19 08:06:17 2018
> @@ -61,6 +61,7 @@ The  type attribute can be add,u
>  
>
>  description="TBD">

> + dev="britter">Revert change in commons.scmPubUrl in Parent
> 47
>  Update parent from
> org.apache:apache 19 to 20.
>  maven-compiler-plugin 3.7.0 
->

> 3.8.0
>  re-enabled japicmp and 
introduced

> japicmp.skip property that





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions

2018-09-19 Thread Gilles

Hi Rob.

On Wed, 19 Sep 2018 09:08:51 -0400, Rob Tompkins wrote:

My impression was that we had this conversation, and we decided that
we wanted this the other way around and to fix the components
respectively due to the semantics of the issue at hand based on what
Gary said below.


It is not clear (see my reply to Gary's message).

+1 to fix of course.
As proposed previously, [RNG] could serve as the testing ground
and future "reference" POM of a new modular component that works
with the more recent CP (with your release-plugin).[1]

Regards,
Gilles

[1] It is *not* the case currently on master ("mvn site" fails)!


-Rob

On Sep 19, 2018, at 8:45 AM, Gary Gregory  
wrote:


The difference is to account for artifact ids that contain a version 
like
commons-lang3. The component id is then just commons-lang. You must 
not
have versions in names for certain names like in the download page. 
This

change will probably break builds like pool, dbcp, lang, and so on.

Gary

On Wed, Sep 19, 2018, 04:07 Gilles  
wrote:


Hi.

Are we sure that the fix/revert below to work as intended for
*all* components?

Common usage should be enforced (e.g. to allow anyone to help
releasing any component), and ancient inconsistencies fixed.

With a concrete example of a component that has had major
version changes (and top-level package change accordingly),
what is
 commons.componentid
and what is
 project.artefactId
?

Thanks,
Gilles


On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
Author: britter
Date: Wed Sep 19 08:06:17 2018
New Revision: 1841296

URL: http://svn.apache.org/viewvc?rev=1841296=rev
Log:
COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47

Modified:
   commons/proper/commons-parent/trunk/pom.xml
   commons/proper/commons-parent/trunk/src/changes/changes.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL:




http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff





==

--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 
08:06:17

2018
@@ -1940,7 +1940,7 @@

${commons.componentid}

-




https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}


+




https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}







${commons.site.cache}/${commons.site.path}

commons.site


Modified: 
commons/proper/commons-parent/trunk/src/changes/changes.xml

URL:




http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff





==

--- commons/proper/commons-parent/trunk/src/changes/changes.xml
(original)
+++ commons/proper/commons-parent/trunk/src/changes/changes.xml 
Wed

Sep 19 08:06:17 2018
@@ -61,6 +61,7 @@ The  type attribute can be add,u



+Revert change in commons.scmPubUrl in Parent
47
Update parent from
org.apache:apache 19 to 20.
maven-compiler-plugin 3.7.0 ->
3.8.0
re-enabled japicmp and introduced
japicmp.skip property that




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Rob Tompkins



> On Sep 19, 2018, at 9:28 AM, Gilles  wrote:
> 
>> On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
>> The difference is to account for artifact ids that contain a version like
>> commons-lang3. The component id is then just commons-lang. You must not
>> have versions in names for certain names like in the download page. This
>> change will probably break builds like pool, dbcp, lang, and so on.
> 
> Hmm, this completes the confusion!
> 
> If "artifactId" is e.g. commons-lang3 then I don't understand how
> the reverted line works because (AFAICT) the SVN URL is
>  
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/
> 
> The [Math] POM contains these lines:
> ---CUT---
>
>math4
> ---CUT---
> Correct or not?

Half of the components are correct, half aren’t. 

What’s the consensus here? My thought was that componentId=math is actually 
correct based on the documentation, and we need and “artifactIdSuffix” or 
something analogous. 

-Rob

> 
> It also uses a fix string:
> ---CUT---
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
> ---CUT---
> whereas a variable (as in the commit below) would seem more portable.
> 
> Why isn't "" defined in CP only (using the appropriate
> variable overridden in each component)?
> 
> Why having
> ---CUT---
> math
> ---CUT---
> that doesn't look at all like a "path"?
> We could define a quite more explicit ""
> that could serve for composing a path, as well as for any
> other purpose where the component is meant, independently
> of artefact identifier syntax or major version.
> 
> 
> Regards,
> Gilles
> 
>> Gary
>> 
>>> On Wed, Sep 19, 2018, 04:07 Gilles  wrote:
>>> 
>>> Hi.
>>> 
>>> Are we sure that the fix/revert below to work as intended for
>>> *all* components?
>>> 
>>> Common usage should be enforced (e.g. to allow anyone to help
>>> releasing any component), and ancient inconsistencies fixed.
>>> 
>>> With a concrete example of a component that has had major
>>> version changes (and top-level package change accordingly),
>>> what is
>>>  commons.componentid
>>> and what is
>>>  project.artefactId
>>> ?
>>> 
>>> Thanks,
>>> Gilles
>>> 
>>> On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
>>> > Author: britter
>>> > Date: Wed Sep 19 08:06:17 2018
>>> > New Revision: 1841296
>>> >
>>> > URL: http://svn.apache.org/viewvc?rev=1841296=rev
>>> > Log:
>>> > COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
>>> >
>>> > Modified:
>>> > commons/proper/commons-parent/trunk/pom.xml
>>> > commons/proper/commons-parent/trunk/src/changes/changes.xml
>>> >
>>> > Modified: commons/proper/commons-parent/trunk/pom.xml
>>> > URL:
>>> >
>>> >
>>> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
>>> >
>>> >
>>> ==
>>> > --- commons/proper/commons-parent/trunk/pom.xml (original)
>>> > +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
>>> > 2018
>>> > @@ -1940,7 +1940,7 @@
>>> >  
>>> >  ${commons.componentid}
>>> >
>>> > -
>>> >
>>> > 
>>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
>>> 
>>> > +
>>> >
>>> > 
>>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
>>> 
>>> >
>>> >
>>> >
>>> ${commons.site.cache}/${commons.site.path}
>>> >  commons.site
>>> >
>>> >
>>> > Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
>>> > URL:
>>> >
>>> >
>>> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
>>> >
>>> >
>>> ==
>>> > --- commons/proper/commons-parent/trunk/src/changes/changes.xml
>>> > (original)
>>> > +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
>>> > Sep 19 08:06:17 2018
>>> > @@ -61,6 +61,7 @@ The  type attribute can be add,u
>>> >  
>>> >
>>> >  
>>> > +>> > dev="britter">Revert change in commons.scmPubUrl in Parent
>>> > 47
>>> >  Update parent from
>>> > org.apache:apache 19 to 20.
>>> >  maven-compiler-plugin 3.7.0 ->
>>> > 3.8.0
>>> >  re-enabled japicmp and introduced
>>> > japicmp.skip property that
>>> 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>> 
>>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: 

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Gilles

On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
The difference is to account for artifact ids that contain a version 
like
commons-lang3. The component id is then just commons-lang. You must 
not
have versions in names for certain names like in the download page. 
This

change will probably break builds like pool, dbcp, lang, and so on.


Hmm, this completes the confusion!

If "artifactId" is e.g. commons-lang3 then I don't understand how
the reverted line works because (AFAICT) the SVN URL is
  
https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/


The [Math] POM contains these lines:
---CUT---

math4
---CUT---
Correct or not?

It also uses a fix string:
---CUT---
https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
---CUT---
whereas a variable (as in the commit below) would seem more portable.

Why isn't "" defined in CP only (using the 
appropriate

variable overridden in each component)?

Why having
---CUT---
math
---CUT---
that doesn't look at all like a "path"?
We could define a quite more explicit ""
that could serve for composing a path, as well as for any
other purpose where the component is meant, independently
of artefact identifier syntax or major version.


Regards,
Gilles


Gary

On Wed, Sep 19, 2018, 04:07 Gilles  
wrote:



Hi.

Are we sure that the fix/revert below to work as intended for
*all* components?

Common usage should be enforced (e.g. to allow anyone to help
releasing any component), and ancient inconsistencies fixed.

With a concrete example of a component that has had major
version changes (and top-level package change accordingly),
what is
  commons.componentid
and what is
  project.artefactId
?

Thanks,
Gilles

On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
> Author: britter
> Date: Wed Sep 19 08:06:17 2018
> New Revision: 1841296
>
> URL: http://svn.apache.org/viewvc?rev=1841296=rev
> Log:
> COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
>
> Modified:
> commons/proper/commons-parent/trunk/pom.xml
> commons/proper/commons-parent/trunk/src/changes/changes.xml
>
> Modified: commons/proper/commons-parent/trunk/pom.xml
> URL:
>
>

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
>
>

==
> --- commons/proper/commons-parent/trunk/pom.xml (original)
> +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 
08:06:17

> 2018
> @@ -1940,7 +1940,7 @@
>  
>  ${commons.componentid}
>
> -
>
> 

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}

> +
>
> 

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}

>
>
>

${commons.site.cache}/${commons.site.path}
>  commons.site
>
>
> Modified: 
commons/proper/commons-parent/trunk/src/changes/changes.xml

> URL:
>
>

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
>
>

==
> --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> (original)
> +++ commons/proper/commons-parent/trunk/src/changes/changes.xml 
Wed

> Sep 19 08:06:17 2018
> @@ -61,6 +61,7 @@ The  type attribute can be add,u
>  
>
>  description="TBD">

> + dev="britter">Revert change in commons.scmPubUrl in Parent
> 47
>  Update parent from
> org.apache:apache 19 to 20.
>  maven-compiler-plugin 3.7.0 ->
> 3.8.0
>  re-enabled japicmp and introduced
> japicmp.skip property that



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Rob Tompkins
My impression was that we had this conversation, and we decided that we wanted 
this the other way around and to fix the components respectively due to the 
semantics of the issue at hand based on what Gary said below. 

-Rob

> On Sep 19, 2018, at 8:45 AM, Gary Gregory  wrote:
> 
> The difference is to account for artifact ids that contain a version like
> commons-lang3. The component id is then just commons-lang. You must not
> have versions in names for certain names like in the download page. This
> change will probably break builds like pool, dbcp, lang, and so on.
> 
> Gary
> 
>> On Wed, Sep 19, 2018, 04:07 Gilles  wrote:
>> 
>> Hi.
>> 
>> Are we sure that the fix/revert below to work as intended for
>> *all* components?
>> 
>> Common usage should be enforced (e.g. to allow anyone to help
>> releasing any component), and ancient inconsistencies fixed.
>> 
>> With a concrete example of a component that has had major
>> version changes (and top-level package change accordingly),
>> what is
>>  commons.componentid
>> and what is
>>  project.artefactId
>> ?
>> 
>> Thanks,
>> Gilles
>> 
>>> On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
>>> Author: britter
>>> Date: Wed Sep 19 08:06:17 2018
>>> New Revision: 1841296
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1841296=rev
>>> Log:
>>> COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
>>> 
>>> Modified:
>>>commons/proper/commons-parent/trunk/pom.xml
>>>commons/proper/commons-parent/trunk/src/changes/changes.xml
>>> 
>>> Modified: commons/proper/commons-parent/trunk/pom.xml
>>> URL:
>>> 
>>> 
>> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
>>> 
>>> 
>> ==
>>> --- commons/proper/commons-parent/trunk/pom.xml (original)
>>> +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
>>> 2018
>>> @@ -1940,7 +1940,7 @@
>>> 
>>> ${commons.componentid}
>>> 
>>> -
>>> 
>>> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
>> 
>>> +
>>> 
>>> 
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
>> 
>>> 
>>> 
>>> 
>> ${commons.site.cache}/${commons.site.path}
>>> commons.site
>>> 
>>> 
>>> Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
>>> URL:
>>> 
>>> 
>> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
>>> 
>>> 
>> ==
>>> --- commons/proper/commons-parent/trunk/src/changes/changes.xml
>>> (original)
>>> +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
>>> Sep 19 08:06:17 2018
>>> @@ -61,6 +61,7 @@ The  type attribute can be add,u
>>> 
>>> 
>>> 
>>> +>> dev="britter">Revert change in commons.scmPubUrl in Parent
>>> 47
>>> Update parent from
>>> org.apache:apache 19 to 20.
>>> maven-compiler-plugin 3.7.0 ->
>>> 3.8.0
>>> re-enabled japicmp and introduced
>>> japicmp.skip property that
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Gary Gregory
The difference is to account for artifact ids that contain a version like
commons-lang3. The component id is then just commons-lang. You must not
have versions in names for certain names like in the download page. This
change will probably break builds like pool, dbcp, lang, and so on.

Gary

On Wed, Sep 19, 2018, 04:07 Gilles  wrote:

> Hi.
>
> Are we sure that the fix/revert below to work as intended for
> *all* components?
>
> Common usage should be enforced (e.g. to allow anyone to help
> releasing any component), and ancient inconsistencies fixed.
>
> With a concrete example of a component that has had major
> version changes (and top-level package change accordingly),
> what is
>   commons.componentid
> and what is
>   project.artefactId
> ?
>
> Thanks,
> Gilles
>
> On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:
> > Author: britter
> > Date: Wed Sep 19 08:06:17 2018
> > New Revision: 1841296
> >
> > URL: http://svn.apache.org/viewvc?rev=1841296=rev
> > Log:
> > COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
> >
> > Modified:
> > commons/proper/commons-parent/trunk/pom.xml
> > commons/proper/commons-parent/trunk/src/changes/changes.xml
> >
> > Modified: commons/proper/commons-parent/trunk/pom.xml
> > URL:
> >
> >
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff
> >
> >
> ==
> > --- commons/proper/commons-parent/trunk/pom.xml (original)
> > +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
> > 2018
> > @@ -1940,7 +1940,7 @@
> >  
> >  ${commons.componentid}
> >
> > -
> >
> > 
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
> 
> > +
> >
> > 
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
> 
> >
> >
> >
> ${commons.site.cache}/${commons.site.path}
> >  commons.site
> >
> >
> > Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
> > URL:
> >
> >
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff
> >
> >
> ==
> > --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> > (original)
> > +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
> > Sep 19 08:06:17 2018
> > @@ -61,6 +61,7 @@ The  type attribute can be add,u
> >  
> >
> >  
> > + > dev="britter">Revert change in commons.scmPubUrl in Parent
> > 47
> >  Update parent from
> > org.apache:apache 19 to 20.
> >  maven-compiler-plugin 3.7.0 ->
> > 3.8.0
> >  re-enabled japicmp and introduced
> > japicmp.skip property that
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


[All] CP definitions (Was: svn commit: r1841296 [...])

2018-09-19 Thread Gilles

Hi.

Are we sure that the fix/revert below to work as intended for
*all* components?

Common usage should be enforced (e.g. to allow anyone to help
releasing any component), and ancient inconsistencies fixed.

With a concrete example of a component that has had major
version changes (and top-level package change accordingly),
what is
 commons.componentid
and what is
 project.artefactId
?

Thanks,
Gilles

On Wed, 19 Sep 2018 08:06:17 -, brit...@apache.org wrote:

Author: britter
Date: Wed Sep 19 08:06:17 2018
New Revision: 1841296

URL: http://svn.apache.org/viewvc?rev=1841296=rev
Log:
COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47

Modified:
commons/proper/commons-parent/trunk/pom.xml
commons/proper/commons-parent/trunk/src/changes/changes.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL:

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296=1841295=1841296=diff

==
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17 
2018

@@ -1940,7 +1940,7 @@
 
 ${commons.componentid}

-

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
+

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}


${commons.site.cache}/${commons.site.path}
 commons.site


Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
URL:

http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296=1841295=1841296=diff

==
--- commons/proper/commons-parent/trunk/src/changes/changes.xml 
(original)

+++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
Sep 19 08:06:17 2018
@@ -61,6 +61,7 @@ The  type attribute can be add,u
 

 
+dev="britter">Revert change in commons.scmPubUrl in Parent 
47

 Update parent from
org.apache:apache 19 to 20.
 maven-compiler-plugin 3.7.0 ->
3.8.0
 re-enabled japicmp and introduced
japicmp.skip property that



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org