Re: [COLLECTIONS] Time for 4.2
On 20 September 2017 at 17:21, Matt Benson wrote: > On Sep 20, 2017 11:08 AM, "Stephen Colebourne" wrote: > > I think its worth the extra step of checking the conditions are right > for adding the Automatic-Module-Name manifest entry. > > > Wouldn't that just offload the decision to "when to update the parent > version in the component?" No, I expect that not all commons components will be suitable to be modules. Stephen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
On Sep 20, 2017 11:08 AM, "Stephen Colebourne" wrote: I think its worth the extra step of checking the conditions are right for adding the Automatic-Module-Name manifest entry. Wouldn't that just offload the decision to "when to update the parent version in the component?" Matt I've not got maven to work with actual module-info.java files yet on the Joda projects, but they are a more complex setup. Maybe [collections] could be the first to get a real module-info? There are no dependencies, right? Stephen On 20 September 2017 at 17:03, Benedikt Ritter wrote: > Hi, > >> Am 20.09.2017 um 15:33 schrieb Gary Gregory : >> >> How about dealing with the Automatic-Module-Name MANIFEST header in the >> parent POM and releasing that POM first? > > Stephen Colebourne said that we have to check on a per component basis whether the component is ready to be released as Java 9 module. For this reason we wanted to add this to every component individually. At least that is what I recall. > > Benedikt > >> >> Gary >> >> On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter wrote: >> >>> Hi, >>> >>> I’d like to release Commons Collections 4.2 soon, because I want to get >>> COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the >>> door. Please let me know if you want to add something. >>> >>> Regards, >>> Benedikt >>> >>> [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
On Wed, Sep 20, 2017 at 10:08 AM, Stephen Colebourne wrote: > I think its worth the extra step of checking the conditions are right > for adding the Automatic-Module-Name manifest entry. > > I've not got maven to work with actual module-info.java files yet on > the Joda projects, but they are a more complex setup. Maybe > [collections] could be the first to get a real module-info? There are > no dependencies, right? > Hi, Correct, [collections4] has no runtime dependencies, only test dependencies: JUnit and EasyMock. Gary > > Stephen > > > > On 20 September 2017 at 17:03, Benedikt Ritter wrote: > > Hi, > > > >> Am 20.09.2017 um 15:33 schrieb Gary Gregory : > >> > >> How about dealing with the Automatic-Module-Name MANIFEST header in the > >> parent POM and releasing that POM first? > > > > Stephen Colebourne said that we have to check on a per component basis > whether the component is ready to be released as Java 9 module. For this > reason we wanted to add this to every component individually. At least that > is what I recall. > > > > Benedikt > > > >> > >> Gary > >> > >> On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter > wrote: > >> > >>> Hi, > >>> > >>> I’d like to release Commons Collections 4.2 soon, because I want to get > >>> COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the > >>> door. Please let me know if you want to add something. > >>> > >>> Regards, > >>> Benedikt > >>> > >>> [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 > >>> - > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [COLLECTIONS] Time for 4.2
I think its worth the extra step of checking the conditions are right for adding the Automatic-Module-Name manifest entry. I've not got maven to work with actual module-info.java files yet on the Joda projects, but they are a more complex setup. Maybe [collections] could be the first to get a real module-info? There are no dependencies, right? Stephen On 20 September 2017 at 17:03, Benedikt Ritter wrote: > Hi, > >> Am 20.09.2017 um 15:33 schrieb Gary Gregory : >> >> How about dealing with the Automatic-Module-Name MANIFEST header in the >> parent POM and releasing that POM first? > > Stephen Colebourne said that we have to check on a per component basis > whether the component is ready to be released as Java 9 module. For this > reason we wanted to add this to every component individually. At least that > is what I recall. > > Benedikt > >> >> Gary >> >> On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter wrote: >> >>> Hi, >>> >>> I’d like to release Commons Collections 4.2 soon, because I want to get >>> COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the >>> door. Please let me know if you want to add something. >>> >>> Regards, >>> Benedikt >>> >>> [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
Hi, > Am 20.09.2017 um 15:33 schrieb Gary Gregory : > > How about dealing with the Automatic-Module-Name MANIFEST header in the > parent POM and releasing that POM first? Stephen Colebourne said that we have to check on a per component basis whether the component is ready to be released as Java 9 module. For this reason we wanted to add this to every component individually. At least that is what I recall. Benedikt > > Gary > > On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter wrote: > >> Hi, >> >> I’d like to release Commons Collections 4.2 soon, because I want to get >> COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the >> door. Please let me know if you want to add something. >> >> Regards, >> Benedikt >> >> [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
On Wed, 20 Sep 2017 17:49:38 +0200, Stefan Bodewig wrote: On 2017-09-20, Gilles wrote: On Wed, 20 Sep 2017 07:33:55 -0600, Gary Gregory wrote: How about dealing with the Automatic-Module-Name MANIFEST header in the parent POM and releasing that POM first? Is there a solution to this issue: https://issues.apache.org/jira/browse/RNG-31 I'm afraid Gary and you are talking about completely different things (and either of you as well as myself should have changed the subject line ;-) I did some 20 minutes ago. :-) Unfortunately I cannot answer the question about signatures for modular builds, I'm not really a maven person. What I can say is that I never invoke any "assembly" goal when I create a release, the signatures are created as a byproduct of running "deploy". "deploy" will upload to the nexus server, and there is no problem (signatures are generated automagically). The problem is for the official distribution (on "dist"): a complete archive is generated but not signed. :-/ [At least that was what "parent" was (not) doing when RNG v1.0.] Gilles Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
On 2017-09-20, Gilles wrote: > On Wed, 20 Sep 2017 07:33:55 -0600, Gary Gregory wrote: >> How about dealing with the Automatic-Module-Name MANIFEST header in >> the parent POM and releasing that POM first? > Is there a solution to this issue: > https://issues.apache.org/jira/browse/RNG-31 I'm afraid Gary and you are talking about completely different things (and either of you as well as myself should have changed the subject line ;-) Unfortunately I cannot answer the question about signatures for modular builds, I'm not really a maven person. What I can say is that I never invoke any "assembly" goal when I create a release, the signatures are created as a byproduct of running "deploy". Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
On Wed, Sep 20, 2017 at 7:57 AM, Gilles wrote: > On Wed, 20 Sep 2017 07:33:55 -0600, Gary Gregory wrote: > >> How about dealing with the Automatic-Module-Name MANIFEST header in the >> parent POM >> > > +1 > > and releasing that POM first? >> > > Is there a solution to this issue: > https://issues.apache.org/jira/browse/RNG-31 > > IOW how do other modular components handle the creation of signatures > and checksums for all their modules? > Some Maven magic does that. Gary > > Thanks, > Gilles > > >> Gary >> >> On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter >> wrote: >> >> Hi, >>> >>> I’d like to release Commons Collections 4.2 soon, because I want to get >>> COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the >>> door. Please let me know if you want to add something. >>> >>> Regards, >>> Benedikt >>> >>> [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 >>> >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [COLLECTIONS] Time for 4.2
> On Sep 20, 2017, at 9:57 AM, Gilles wrote: > >> On Wed, 20 Sep 2017 07:33:55 -0600, Gary Gregory wrote: >> How about dealing with the Automatic-Module-Name MANIFEST header in the >> parent POM I went through all of the pom's and added a property that could be used in the parent for the sake of generating this. Do we want to try to do a release of parent to get this in to all of the artifacts? -Rob > > +1 > >> and releasing that POM first? > > Is there a solution to this issue: > https://issues.apache.org/jira/browse/RNG-31 > > IOW how do other modular components handle the creation of signatures > and checksums for all their modules? > > Thanks, > Gilles > >> >> Gary >> >>> On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter wrote: >>> >>> Hi, >>> >>> I’d like to release Commons Collections 4.2 soon, because I want to get >>> COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the >>> door. Please let me know if you want to add something. >>> >>> Regards, >>> Benedikt >>> >>> [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
On Wed, 20 Sep 2017 07:33:55 -0600, Gary Gregory wrote: How about dealing with the Automatic-Module-Name MANIFEST header in the parent POM +1 and releasing that POM first? Is there a solution to this issue: https://issues.apache.org/jira/browse/RNG-31 IOW how do other modular components handle the creation of signatures and checksums for all their modules? Thanks, Gilles Gary On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter wrote: Hi, I’d like to release Commons Collections 4.2 soon, because I want to get COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the door. Please let me know if you want to add something. Regards, Benedikt [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COLLECTIONS] Time for 4.2
How about dealing with the Automatic-Module-Name MANIFEST header in the parent POM and releasing that POM first? Gary On Wed, Sep 20, 2017 at 1:20 AM, Benedikt Ritter wrote: > Hi, > > I’d like to release Commons Collections 4.2 soon, because I want to get > COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the > door. Please let me know if you want to add something. > > Regards, > Benedikt > > [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [COLLECTIONS] Time for 4.2
There is another thread about failing tests on Windows that would need attention before the release. I am still debugging it, but am off to Australia in a few days, and back only in 3 weeks, so not sure if will be able to explain why it's happening. CheersBruno From: Benedikt Ritter To: Commons Developers List Sent: Wednesday, 20 September 2017 7:20 PM Subject: [COLLECTIONS] Time for 4.2 Hi, I’d like to release Commons Collections 4.2 soon, because I want to get COLLECTIONS-658 [1] (Automatic-Module-Name MANIFEST header) out of the door. Please let me know if you want to add something. Regards, Benedikt [1] https://issues.apache.org/jira/browse/COLLECTIONS-658 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
