Re: [LANG] Releasing 3.6.1
What I really wanted to say was: I'm for keeping RandomStringUtils undeprecated in lang. Sorry, Pascal Am 06.09.2017 um 21:20 schrieb Gary Gregory: On Sep 6, 2017 12:31, "Pascal Schumacher"wrote: I'm for keeping RandomStringUtils in lang (at least in 3.x). It has to stay in 3.x no matter what to maintain BC. Gary Am 06.09.2017 um 12:55 schrieb Rob Tompkins: On Sep 6, 2017, at 3:34 AM, Amey Jadiye wrote: Hi Rob, Looking at frequency I think more number of requests coming for RandomStringUtils for its simplicity. RandomStringGenerator is strong , flexible but one can't use it quickly. Also I think this tool should belong in Commons text's arsenal. I'm not only moving RandomStringUtils to text but changing its core logic with using RandomStringGenerator which seems fair to me. So finally we should release text-1.2 rather doing rollback of deprecation and release lang 3.6.1, WDYT ? I definitely lean this direction, but if I recall correctly we drew “line between [lang] and [text]” to be: a piece of functionality should go in [lang] if the arbitrary java developer would probably want it, whereas text is geared towards folks actually doing text manipulation [1]. Personally I’m a +0 to +1 on doing this, but I wanted to gauge other folks’ thoughts here because I feel like we’re in that grey area here. That said, I’m perfectly willing to roll a 1.2 [text] release. Cheers, -Rob [1] http://markmail.org/message/a2urysnxvxihfoto Regards, Amey On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins wrote: On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: Hello Benedikt, How about we keep that deprecated in lang and release Text-1.2 ? [snip] I’m on board with this if folks are complaining and the original intent was to deprecate things in [lang]. Why not roll forward as opposed to backwards? But, that opens the question: Is RandomStringUtils something that most folks would want (i.e. should it be in [lang] or [text])? I think that question is more the heart of the problem here. Either direction seems reasonable to me. Thoughts? -Rob I will submit changes [1] related to this in fact i'm fixing couple of failing test cases ATM. If you are planning to release 3.6.1 just to remove deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine with that as well. [1]. https://issues.apache.org/jira/browse/TEXT-101 On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter wrote: Hi, since we’re getting more and more requests about the deprecation of RandomStringUtils, I’m thinking about releasing the current state of the master branch as 3.6.1. I may have time to push an RC sometime this week. So if you have some fixes you want to include, please do so now. Regards, Benedikt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
On Sep 6, 2017 12:31, "Pascal Schumacher"wrote: I'm for keeping RandomStringUtils in lang (at least in 3.x). It has to stay in 3.x no matter what to maintain BC. Gary Am 06.09.2017 um 12:55 schrieb Rob Tompkins: > On Sep 6, 2017, at 3:34 AM, Amey Jadiye wrote: >> >> Hi Rob, >> >> Looking at frequency I think more number of requests coming >> for RandomStringUtils for its simplicity. >> >> RandomStringGenerator is strong , flexible but one can't use it quickly. >> Also I think this tool should belong in Commons text's arsenal. I'm not >> only moving RandomStringUtils to text but changing its core logic with >> using >> RandomStringGenerator which seems fair to me. So finally we should release >> text-1.2 rather doing rollback of deprecation and release lang 3.6.1, >> WDYT >> ? >> >> I definitely lean this direction, but if I recall correctly we drew “line > between [lang] and [text]” to be: a piece of functionality should go in > [lang] if the arbitrary java developer would probably want it, whereas text > is geared towards folks actually doing text manipulation [1]. > > Personally I’m a +0 to +1 on doing this, but I wanted to gauge other > folks’ thoughts here because I feel like we’re in that grey area here. That > said, I’m perfectly willing to roll a 1.2 [text] release. > > Cheers, > -Rob > > [1] http://markmail.org/message/a2urysnxvxihfoto > > Regards, >> Amey >> >> On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins wrote: >> >> On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: Hello Benedikt, How about we keep that deprecated in lang and release Text-1.2 ? >>> [snip] >>> >>> I’m on board with this if folks are complaining and the original intent >>> was to deprecate things in [lang]. Why not roll forward as opposed to >>> backwards? >>> >>> But, that opens the question: Is RandomStringUtils something that most >>> folks would want (i.e. should it be in [lang] or [text])? I think that >>> question is more the heart of the problem here. Either direction seems >>> reasonable to me. >>> >>> Thoughts? >>> >>> -Rob >>> >>> I will submit changes [1] related to this in fact i'm fixing couple of failing test cases ATM. If you are planning to release 3.6.1 just to remove deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine with that as well. [1]. https://issues.apache.org/jira/browse/TEXT-101 On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter >>> wrote: >>> Hi, > > since we’re getting more and more requests about the deprecation of > RandomStringUtils, I’m thinking about releasing the current state of > the > master branch as 3.6.1. I may have time to push an RC sometime this > week. >>> So if you have some fixes you want to include, please do so now. > > Regards, > Benedikt > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > > -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >>> > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
I'm for keeping RandomStringUtils in lang (at least in 3.x). Am 06.09.2017 um 12:55 schrieb Rob Tompkins: On Sep 6, 2017, at 3:34 AM, Amey Jadiyewrote: Hi Rob, Looking at frequency I think more number of requests coming for RandomStringUtils for its simplicity. RandomStringGenerator is strong , flexible but one can't use it quickly. Also I think this tool should belong in Commons text's arsenal. I'm not only moving RandomStringUtils to text but changing its core logic with using RandomStringGenerator which seems fair to me. So finally we should release text-1.2 rather doing rollback of deprecation and release lang 3.6.1, WDYT ? I definitely lean this direction, but if I recall correctly we drew “line between [lang] and [text]” to be: a piece of functionality should go in [lang] if the arbitrary java developer would probably want it, whereas text is geared towards folks actually doing text manipulation [1]. Personally I’m a +0 to +1 on doing this, but I wanted to gauge other folks’ thoughts here because I feel like we’re in that grey area here. That said, I’m perfectly willing to roll a 1.2 [text] release. Cheers, -Rob [1] http://markmail.org/message/a2urysnxvxihfoto Regards, Amey On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins wrote: On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: Hello Benedikt, How about we keep that deprecated in lang and release Text-1.2 ? [snip] I’m on board with this if folks are complaining and the original intent was to deprecate things in [lang]. Why not roll forward as opposed to backwards? But, that opens the question: Is RandomStringUtils something that most folks would want (i.e. should it be in [lang] or [text])? I think that question is more the heart of the problem here. Either direction seems reasonable to me. Thoughts? -Rob I will submit changes [1] related to this in fact i'm fixing couple of failing test cases ATM. If you are planning to release 3.6.1 just to remove deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine with that as well. [1]. https://issues.apache.org/jira/browse/TEXT-101 On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter wrote: Hi, since we’re getting more and more requests about the deprecation of RandomStringUtils, I’m thinking about releasing the current state of the master branch as 3.6.1. I may have time to push an RC sometime this week. So if you have some fixes you want to include, please do so now. Regards, Benedikt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
> On Sep 6, 2017, at 7:05 AM, Gilleswrote: > > On Wed, 6 Sep 2017 06:55:49 -0400, Rob Tompkins wrote: >>> On Sep 6, 2017, at 3:34 AM, Amey Jadiye wrote: >>> >>> Hi Rob, >>> >>> Looking at frequency I think more number of requests coming >>> for RandomStringUtils for its simplicity. >>> >>> RandomStringGenerator is strong , flexible but one can't use it quickly. >>> Also I think this tool should belong in Commons text's arsenal. I'm not >>> only moving RandomStringUtils to text but changing its core logic with >>> using >>> RandomStringGenerator which seems fair to me. So finally we should release >>> text-1.2 rather doing rollback of deprecation and release lang 3.6.1, WDYT >>> ? >>> >> >> I definitely lean this direction, but if I recall correctly we drew >> “line between [lang] and [text]” to be: a piece of functionality >> should go in [lang] if the arbitrary java developer would probably >> want it, whereas text is geared towards folks actually doing text >> manipulation [1]. >> >> Personally I’m a +0 to +1 on doing this, but I wanted to gauge other >> folks’ thoughts here because I feel like we’re in that grey area here. >> That said, I’m perfectly willing to roll a 1.2 [text] release. > > "Grey area" should favour small components. Fair point. I take that to mean that you think that it should either go into text to make lang smaller or its own component. I suppose because the generator lives in [text] that makes a good argument for [text]. More thoughts out there? -Rob > > Gilles > >> >> Cheers, >> -Rob >> >> [1] http://markmail.org/message/a2urysnxvxihfoto >> >>> Regards, >>> Amey >>> >>> On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins wrote: >>> > On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: > > Hello Benedikt, > > How about we keep that deprecated in lang and release Text-1.2 ? [snip] I’m on board with this if folks are complaining and the original intent was to deprecate things in [lang]. Why not roll forward as opposed to backwards? But, that opens the question: Is RandomStringUtils something that most folks would want (i.e. should it be in [lang] or [text])? I think that question is more the heart of the problem here. Either direction seems reasonable to me. Thoughts? -Rob > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
On Wed, 6 Sep 2017 06:55:49 -0400, Rob Tompkins wrote: On Sep 6, 2017, at 3:34 AM, Amey Jadiyewrote: Hi Rob, Looking at frequency I think more number of requests coming for RandomStringUtils for its simplicity. RandomStringGenerator is strong , flexible but one can't use it quickly. Also I think this tool should belong in Commons text's arsenal. I'm not only moving RandomStringUtils to text but changing its core logic with using RandomStringGenerator which seems fair to me. So finally we should release text-1.2 rather doing rollback of deprecation and release lang 3.6.1, WDYT ? I definitely lean this direction, but if I recall correctly we drew “line between [lang] and [text]” to be: a piece of functionality should go in [lang] if the arbitrary java developer would probably want it, whereas text is geared towards folks actually doing text manipulation [1]. Personally I’m a +0 to +1 on doing this, but I wanted to gauge other folks’ thoughts here because I feel like we’re in that grey area here. That said, I’m perfectly willing to roll a 1.2 [text] release. "Grey area" should favour small components. Gilles Cheers, -Rob [1] http://markmail.org/message/a2urysnxvxihfoto Regards, Amey On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins wrote: On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: Hello Benedikt, How about we keep that deprecated in lang and release Text-1.2 ? [snip] I’m on board with this if folks are complaining and the original intent was to deprecate things in [lang]. Why not roll forward as opposed to backwards? But, that opens the question: Is RandomStringUtils something that most folks would want (i.e. should it be in [lang] or [text])? I think that question is more the heart of the problem here. Either direction seems reasonable to me. Thoughts? -Rob - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
> On Sep 6, 2017, at 3:34 AM, Amey Jadiyewrote: > > Hi Rob, > > Looking at frequency I think more number of requests coming > for RandomStringUtils for its simplicity. > > RandomStringGenerator is strong , flexible but one can't use it quickly. > Also I think this tool should belong in Commons text's arsenal. I'm not > only moving RandomStringUtils to text but changing its core logic with > using > RandomStringGenerator which seems fair to me. So finally we should release > text-1.2 rather doing rollback of deprecation and release lang 3.6.1, WDYT > ? > I definitely lean this direction, but if I recall correctly we drew “line between [lang] and [text]” to be: a piece of functionality should go in [lang] if the arbitrary java developer would probably want it, whereas text is geared towards folks actually doing text manipulation [1]. Personally I’m a +0 to +1 on doing this, but I wanted to gauge other folks’ thoughts here because I feel like we’re in that grey area here. That said, I’m perfectly willing to roll a 1.2 [text] release. Cheers, -Rob [1] http://markmail.org/message/a2urysnxvxihfoto > Regards, > Amey > > On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins wrote: > >> >>> On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: >>> >>> Hello Benedikt, >>> >>> How about we keep that deprecated in lang and release Text-1.2 ? >> [snip] >> >> I’m on board with this if folks are complaining and the original intent >> was to deprecate things in [lang]. Why not roll forward as opposed to >> backwards? >> >> But, that opens the question: Is RandomStringUtils something that most >> folks would want (i.e. should it be in [lang] or [text])? I think that >> question is more the heart of the problem here. Either direction seems >> reasonable to me. >> >> Thoughts? >> >> -Rob >> >>> I will >>> submit changes [1] related to this in fact i'm fixing couple of failing >>> test cases ATM. If you are planning to release 3.6.1 just to remove >>> deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine >>> with that as well. >>> >>> [1]. https://issues.apache.org/jira/browse/TEXT-101 >>> >>> On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter >> wrote: >>> Hi, since we’re getting more and more requests about the deprecation of RandomStringUtils, I’m thinking about releasing the current state of the master branch as 3.6.1. I may have time to push an RC sometime this >> week. So if you have some fixes you want to include, please do so now. Regards, Benedikt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >>> -- >>> >>> - >>> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> >>> For additional commands, e-mail: dev-h...@commons.apache.org >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
Hi Rob, Looking at frequency I think more number of requests coming for RandomStringUtils for its simplicity. RandomStringGenerator is strong , flexible but one can't use it quickly. Also I think this tool should belong in Commons text's arsenal. I'm not only moving RandomStringUtils to text but changing its core logic with using RandomStringGenerator which seems fair to me. So finally we should release text-1.2 rather doing rollback of deprecation and release lang 3.6.1, WDYT ? Regards, Amey On Wed, Sep 6, 2017, 12:00 AM Rob Tompkinswrote: > > > On Sep 5, 2017, at 11:00 AM, Amey Jadiye wrote: > > > > Hello Benedikt, > > > > How about we keep that deprecated in lang and release Text-1.2 ? > [snip] > > I’m on board with this if folks are complaining and the original intent > was to deprecate things in [lang]. Why not roll forward as opposed to > backwards? > > But, that opens the question: Is RandomStringUtils something that most > folks would want (i.e. should it be in [lang] or [text])? I think that > question is more the heart of the problem here. Either direction seems > reasonable to me. > > Thoughts? > > -Rob > > > I will > > submit changes [1] related to this in fact i'm fixing couple of failing > > test cases ATM. If you are planning to release 3.6.1 just to remove > > deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine > > with that as well. > > > > [1]. https://issues.apache.org/jira/browse/TEXT-101 > > > > On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter > wrote: > > > >> Hi, > >> > >> since we’re getting more and more requests about the deprecation of > >> RandomStringUtils, I’m thinking about releasing the current state of the > >> master branch as 3.6.1. I may have time to push an RC sometime this > week. > >> So if you have some fixes you want to include, please do so now. > >> > >> Regards, > >> Benedikt > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > -- > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [LANG] Releasing 3.6.1
+1 Am 5. September 2017 07:17:57 MESZ schrieb Benedikt Ritter: >Hi, > >since we’re getting more and more requests about the deprecation of >RandomStringUtils, I’m thinking about releasing the current state of >the master branch as 3.6.1. I may have time to push an RC sometime this >week. So if you have some fixes you want to include, please do so now. > >Regards, >Benedikt >- >To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
> On Sep 5, 2017, at 11:00 AM, Amey Jadiyewrote: > > Hello Benedikt, > > How about we keep that deprecated in lang and release Text-1.2 ? [snip] I’m on board with this if folks are complaining and the original intent was to deprecate things in [lang]. Why not roll forward as opposed to backwards? But, that opens the question: Is RandomStringUtils something that most folks would want (i.e. should it be in [lang] or [text])? I think that question is more the heart of the problem here. Either direction seems reasonable to me. Thoughts? -Rob > I will > submit changes [1] related to this in fact i'm fixing couple of failing > test cases ATM. If you are planning to release 3.6.1 just to remove > deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine > with that as well. > > [1]. https://issues.apache.org/jira/browse/TEXT-101 > > On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter wrote: > >> Hi, >> >> since we’re getting more and more requests about the deprecation of >> RandomStringUtils, I’m thinking about releasing the current state of the >> master branch as 3.6.1. I may have time to push an RC sometime this week. >> So if you have some fixes you want to include, please do so now. >> >> Regards, >> Benedikt >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Releasing 3.6.1
Hello Benedikt, How about we keep that deprecated in lang and release Text-1.2 ? I will submit changes [1] related to this in fact i'm fixing couple of failing test cases ATM. If you are planning to release 3.6.1 just to remove deprecation and deprecate RandomStringUtils back in Lang - 3.7 I'm fine with that as well. [1]. https://issues.apache.org/jira/browse/TEXT-101 On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritterwrote: > Hi, > > since we’re getting more and more requests about the deprecation of > RandomStringUtils, I’m thinking about releasing the current state of the > master branch as 3.6.1. I may have time to push an RC sometime this week. > So if you have some fixes you want to include, please do so now. > > Regards, > Benedikt > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org