Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread sebb 
On 30 July 2017 at 16:30, Matt Sicker  wrote:
> If the build is anything like Log4j's, it probably has a separate rat
> config for the release profile than it does by default.

If rat and Clirr are run as part of the the site build they use the
report settings whereas 'mvn clirr:check' will use the build settings.

The build and report section configs need to agree.

> On 30 July 2017 at 10:27, Gary Gregory  wrote:
>
>> I always run:
>>
>> mvn apache-rat:check
>>
>> And
>>
>> mvn clirr:check
>>
>> Gary
>>
>> On Jul 30, 2017 07:12, "Stefan Bodewig"  wrote:
>>
>> > On 2017-07-30, Gary Gregory wrote:
>> >
>> > > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
>> > > Email Package" instead of "Commons Email Package".
>> >
>> > I was under the impression it had been generated by the commons-build
>> > plugin. Anyway, will fix it when I publish the release (no reason to
>> > vote on that).
>> >
>> > > RAT check fails with:
>> >
>> > > Unapproved licenses:
>> >
>> > >   src/test/resources/eml/attachment-only.eml
>> > >   src/test/resources/eml/html-attachment-content-disposition.eml
>> > >   src/test/resources/eml/html-attachment-encoded-filename.eml
>> > >   src/test/resources/eml/html-attachment.eml
>> > >   src/test/resources/eml/multipart-report.eml
>> > >   src/test/resources/eml/multipart-text-attachment-only.eml
>> > >   src/test/resources/eml/multipart-text-attachment.eml
>> > >   src/test/resources/eml/outofmemory-no-header-seperation.eml
>> > >   src/test/resources/eml/simple-reply.eml
>> > >   src/test/resources/eml/simple.eml
>> >
>> > The pom contains
>> >
>> > 
>> > org.apache.rat
>> > apache-rat-plugin
>> > 
>> > 
>> > src/test/resources/eml/*.eml
>> > 
>> > 
>> > 
>> >
>> > and RAT is prefectly happy inside the site build. How do you execute the
>> > rat check? Comparing the POM with the one of Compress I see the plugin
>> > is configured inside the  section for Email only, while it is
>> > inside  for Compress. This may explain the difference when
>> > running rat checks directly.
>> >
>> > Stefan
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> > For additional commands, e-mail: dev-h...@commons.apache.org
>> >
>> >
>>
>
>
>
> --
> Matt Sicker 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Matt Sicker 
If the build is anything like Log4j's, it probably has a separate rat
config for the release profile than it does by default.

On 30 July 2017 at 10:27, Gary Gregory  wrote:

> I always run:
>
> mvn apache-rat:check
>
> And
>
> mvn clirr:check
>
> Gary
>
> On Jul 30, 2017 07:12, "Stefan Bodewig"  wrote:
>
> > On 2017-07-30, Gary Gregory wrote:
> >
> > > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
> > > Email Package" instead of "Commons Email Package".
> >
> > I was under the impression it had been generated by the commons-build
> > plugin. Anyway, will fix it when I publish the release (no reason to
> > vote on that).
> >
> > > RAT check fails with:
> >
> > > Unapproved licenses:
> >
> > >   src/test/resources/eml/attachment-only.eml
> > >   src/test/resources/eml/html-attachment-content-disposition.eml
> > >   src/test/resources/eml/html-attachment-encoded-filename.eml
> > >   src/test/resources/eml/html-attachment.eml
> > >   src/test/resources/eml/multipart-report.eml
> > >   src/test/resources/eml/multipart-text-attachment-only.eml
> > >   src/test/resources/eml/multipart-text-attachment.eml
> > >   src/test/resources/eml/outofmemory-no-header-seperation.eml
> > >   src/test/resources/eml/simple-reply.eml
> > >   src/test/resources/eml/simple.eml
> >
> > The pom contains
> >
> > 
> > org.apache.rat
> > apache-rat-plugin
> > 
> > 
> > src/test/resources/eml/*.eml
> > 
> > 
> > 
> >
> > and RAT is prefectly happy inside the site build. How do you execute the
> > rat check? Comparing the POM with the one of Compress I see the plugin
> > is configured inside the  section for Email only, while it is
> > inside  for Compress. This may explain the difference when
> > running rat checks directly.
> >
> > Stefan
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>



-- 
Matt Sicker

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Gary Gregory 
I always run:

mvn apache-rat:check

And

mvn clirr:check

Gary

On Jul 30, 2017 07:12, "Stefan Bodewig"  wrote:

> On 2017-07-30, Gary Gregory wrote:
>
> > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
> > Email Package" instead of "Commons Email Package".
>
> I was under the impression it had been generated by the commons-build
> plugin. Anyway, will fix it when I publish the release (no reason to
> vote on that).
>
> > RAT check fails with:
>
> > Unapproved licenses:
>
> >   src/test/resources/eml/attachment-only.eml
> >   src/test/resources/eml/html-attachment-content-disposition.eml
> >   src/test/resources/eml/html-attachment-encoded-filename.eml
> >   src/test/resources/eml/html-attachment.eml
> >   src/test/resources/eml/multipart-report.eml
> >   src/test/resources/eml/multipart-text-attachment-only.eml
> >   src/test/resources/eml/multipart-text-attachment.eml
> >   src/test/resources/eml/outofmemory-no-header-seperation.eml
> >   src/test/resources/eml/simple-reply.eml
> >   src/test/resources/eml/simple.eml
>
> The pom contains
>
> 
> org.apache.rat
> apache-rat-plugin
> 
> 
> src/test/resources/eml/*.eml
> 
> 
> 
>
> and RAT is prefectly happy inside the site build. How do you execute the
> rat check? Comparing the POM with the one of Compress I see the plugin
> is configured inside the  section for Email only, while it is
> inside  for Compress. This may explain the difference when
> running rat checks directly.
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Stefan Bodewig 
On 2017-07-30, Amey Jadiye wrote:

> I have fixed this, and yes reason was though those .eml files was added in
> exclusion but in reports and not in build.
> I have raised PR and tested it on my local.

> https://github.com/apache/commons-email/pull/2

LGTM, but please allow us to get the release out of the door before
changung trunk :-)

Thanks

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Amey Jadiye 
Hi,

I have fixed this, and yes reason was though those .eml files was added in
exclusion but in reports and not in build.
I have raised PR and tested it on my local.

https://github.com/apache/commons-email/pull/2

Regards,
Amey

On Sun, Jul 30, 2017 at 7:42 PM, Stefan Bodewig  wrote:

> On 2017-07-30, Gary Gregory wrote:
>
> > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
> > Email Package" instead of "Commons Email Package".
>
> I was under the impression it had been generated by the commons-build
> plugin. Anyway, will fix it when I publish the release (no reason to
> vote on that).
>
> > RAT check fails with:
>
> > Unapproved licenses:
>
> >   src/test/resources/eml/attachment-only.eml
> >   src/test/resources/eml/html-attachment-content-disposition.eml
> >   src/test/resources/eml/html-attachment-encoded-filename.eml
> >   src/test/resources/eml/html-attachment.eml
> >   src/test/resources/eml/multipart-report.eml
> >   src/test/resources/eml/multipart-text-attachment-only.eml
> >   src/test/resources/eml/multipart-text-attachment.eml
> >   src/test/resources/eml/outofmemory-no-header-seperation.eml
> >   src/test/resources/eml/simple-reply.eml
> >   src/test/resources/eml/simple.eml
>
> The pom contains
>
> 
> org.apache.rat
> apache-rat-plugin
> 
> 
> src/test/resources/eml/*.eml
> 
> 
> 
>
> and RAT is prefectly happy inside the site build. How do you execute the
> rat check? Comparing the POM with the one of Compress I see the plugin
> is configured inside the  section for Email only, while it is
> inside  for Compress. This may explain the difference when
> running rat checks directly.
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Stefan Bodewig 
On 2017-07-30, Gary Gregory wrote:

> Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
> Email Package" instead of "Commons Email Package".

I was under the impression it had been generated by the commons-build
plugin. Anyway, will fix it when I publish the release (no reason to
vote on that).

> RAT check fails with:

> Unapproved licenses:

>   src/test/resources/eml/attachment-only.eml
>   src/test/resources/eml/html-attachment-content-disposition.eml
>   src/test/resources/eml/html-attachment-encoded-filename.eml
>   src/test/resources/eml/html-attachment.eml
>   src/test/resources/eml/multipart-report.eml
>   src/test/resources/eml/multipart-text-attachment-only.eml
>   src/test/resources/eml/multipart-text-attachment.eml
>   src/test/resources/eml/outofmemory-no-header-seperation.eml
>   src/test/resources/eml/simple-reply.eml
>   src/test/resources/eml/simple.eml

The pom contains


org.apache.rat
apache-rat-plugin


src/test/resources/eml/*.eml




and RAT is prefectly happy inside the site build. How do you execute the
rat check? Comparing the POM with the one of Compress I see the plugin
is configured inside the  section for Email only, while it is
inside  for Compress. This may explain the difference when
running rat checks directly.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-30 Thread Amey Jadiye 
Checked RC1, and here is my +1 (non-binding).

1. Build and Tests looks good.
2. Clirr looks good.
3. Rat is not good as mentioned by gary, as they are test resources can be
put to ignore list.
4. Findbug looks good.
5. There are 302 Checkstyle issues but they are non-blocker to release.
6. Hashes looks good.
7. Site looks good.

Checked on :-
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T22:11:47+05:30)
Maven home: /opt/apache/maven
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_IN, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-31-generic", arch: "amd64", family: "unix"


On Sat, Jul 29, 2017 at 7:54 PM, Stefan Bodewig  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Email 1.4 was released, so I would like to release Email 1.5.
>
> Email 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/email/
> (svn revision 20667)
>
> The tag is here:
> http://svn.apache.org/repos/asf/commons/proper/email/tags/
> EMAIL_1_5_RC1/
> (svn revision 1803366)
> N.B. the SVN revision is required because SVN tags are not immutable.
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/
> orgapachecommons-1255/org/apache/commons/commons-email/1.5/
>
> These are the Maven artifacts and their SHA1 hashes
>
> e8e677c6362eba14ff3c476ba63ccb83132dbd52  commons-email-1.5.jar
> 6ccc8b44cb666b849b71ecc6fa32549a6461c099  commons-email-1.5-javadoc.jar
> 09d31911480b5148275d8a26c60e355bbcbe9ae3  commons-email-1.5.pom
> dbe951d1b89eb9472b4b2c8f618b8bc9783b6623  commons-email-1.5-sources.jar
> 15afde52264e316438802b5bd05d34bc424bf659  commons-email-1.5-tests.jar
> e157492dfd776839387a6ce4af0d191e0a92a534  commons-email-1.5-test-
> sources.jar
>
> I have tested this with JDK 8 using Maven 3.0.5.
>
> As usual when I cut a release the site is not the one I'll publish
> once the vote has succeeded. I'll recreate the site once the release
> date is known.
>
> I've already copied the javadocs for 1.4 so
> http://commons.apache.org/proper/commons-email/javadocs/api-1.4/index.html
> already is available. The javadoc links and download page certainly
> don't work in the staging site.
>
> Details of changes since 1.4 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/email/RELEASE-NOTES.txt
> https://stefan.samaflost.de/staging/commons-email-1.5/
> changes-report.html
>
> Site:
> https://stefan.samaflost.de/staging/commons-email-1.5/
>
> Clirr Report (compared to 1.4):
> https://stefan.samaflost.de/staging/commons-email-1.5/
> clirr-report.html
>
> RAT Report:
> https://stefan.samaflost.de/staging/commons-email-1.5/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 14:30 UTC 1-Aug 2017
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-29 Thread Gary Gregory 
+1

BUT:

Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
Email Package" instead of "Commons Email Package". I would do away with the
"Package" suffix, we just don't use that, if anything we say "Component"
since the Apache Commons Projects is made up of Components.

Building from the src zip: ASC, MD5, and SHA-1 OK.

CLIRR check OK

RAT check fails with:

Unapproved licenses:

  src/test/resources/eml/attachment-only.eml
  src/test/resources/eml/html-attachment-content-disposition.eml
  src/test/resources/eml/html-attachment-encoded-filename.eml
  src/test/resources/eml/html-attachment.eml
  src/test/resources/eml/multipart-report.eml
  src/test/resources/eml/multipart-text-attachment-only.eml
  src/test/resources/eml/multipart-text-attachment.eml
  src/test/resources/eml/outofmemory-no-header-seperation.eml
  src/test/resources/eml/simple-reply.eml
  src/test/resources/eml/simple.eml

Either these should be licensed with a header in each file or the files
should be excluded from the RAT check.

Built with:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_144\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary



On Sat, Jul 29, 2017 at 7:24 AM, Stefan Bodewig  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Email 1.4 was released, so I would like to release Email 1.5.
>
> Email 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/email/
> (svn revision 20667)
>
> The tag is here:
> http://svn.apache.org/repos/asf/commons/proper/email/tags/
> EMAIL_1_5_RC1/
> (svn revision 1803366)
> N.B. the SVN revision is required because SVN tags are not immutable.
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/
> orgapachecommons-1255/org/apache/commons/commons-email/1.5/
>
> These are the Maven artifacts and their SHA1 hashes
>
> e8e677c6362eba14ff3c476ba63ccb83132dbd52  commons-email-1.5.jar
> 6ccc8b44cb666b849b71ecc6fa32549a6461c099  commons-email-1.5-javadoc.jar
> 09d31911480b5148275d8a26c60e355bbcbe9ae3  commons-email-1.5.pom
> dbe951d1b89eb9472b4b2c8f618b8bc9783b6623  commons-email-1.5-sources.jar
> 15afde52264e316438802b5bd05d34bc424bf659  commons-email-1.5-tests.jar
> e157492dfd776839387a6ce4af0d191e0a92a534  commons-email-1.5-test-
> sources.jar
>
> I have tested this with JDK 8 using Maven 3.0.5.
>
> As usual when I cut a release the site is not the one I'll publish
> once the vote has succeeded. I'll recreate the site once the release
> date is known.
>
> I've already copied the javadocs for 1.4 so
> http://commons.apache.org/proper/commons-email/javadocs/api-1.4/index.html
> already is available. The javadoc links and download page certainly
> don't work in the staging site.
>
> Details of changes since 1.4 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/email/RELEASE-NOTES.txt
> https://stefan.samaflost.de/staging/commons-email-1.5/
> changes-report.html
>
> Site:
> https://stefan.samaflost.de/staging/commons-email-1.5/
>
> Clirr Report (compared to 1.4):
> https://stefan.samaflost.de/staging/commons-email-1.5/
> clirr-report.html
>
> RAT Report:
> https://stefan.samaflost.de/staging/commons-email-1.5/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 14:30 UTC 1-Aug 2017
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Commons Email 1.5 Based on RC1

2017-07-29 Thread Oliver Heger 
Build works fine with Java 1.6 and 1.8. Artifacts and site look good.

+1

Oliver

Am 29.07.2017 um 16:24 schrieb Stefan Bodewig:
> We have fixed quite a few bugs and added some significant enhancements
> since Email 1.4 was released, so I would like to release Email 1.5.
> 
> Email 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/email/
> (svn revision 20667)
> 
> The tag is here:
> http://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_5_RC1/
> (svn revision 1803366)
> N.B. the SVN revision is required because SVN tags are not immutable.
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1255/org/apache/commons/commons-email/1.5/
> 
> These are the Maven artifacts and their SHA1 hashes
> 
> e8e677c6362eba14ff3c476ba63ccb83132dbd52  commons-email-1.5.jar
> 6ccc8b44cb666b849b71ecc6fa32549a6461c099  commons-email-1.5-javadoc.jar
> 09d31911480b5148275d8a26c60e355bbcbe9ae3  commons-email-1.5.pom
> dbe951d1b89eb9472b4b2c8f618b8bc9783b6623  commons-email-1.5-sources.jar
> 15afde52264e316438802b5bd05d34bc424bf659  commons-email-1.5-tests.jar
> e157492dfd776839387a6ce4af0d191e0a92a534  commons-email-1.5-test-sources.jar
> 
> I have tested this with JDK 8 using Maven 3.0.5.
> 
> As usual when I cut a release the site is not the one I'll publish
> once the vote has succeeded. I'll recreate the site once the release
> date is known.
> 
> I've already copied the javadocs for 1.4 so
> http://commons.apache.org/proper/commons-email/javadocs/api-1.4/index.html
> already is available. The javadoc links and download page certainly
> don't work in the staging site.
> 
> Details of changes since 1.4 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/email/RELEASE-NOTES.txt
> https://stefan.samaflost.de/staging/commons-email-1.5/changes-report.html
> 
> Site:
> https://stefan.samaflost.de/staging/commons-email-1.5/
> 
> Clirr Report (compared to 1.4):
> https://stefan.samaflost.de/staging/commons-email-1.5/clirr-report.html
> 
> RAT Report:
> https://stefan.samaflost.de/staging/commons-email-1.5/rat-report.html
> 
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 14:30 UTC 1-Aug 2017
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
> Thanks!
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org