Re: Some pain points from our users :'(
Sorry for being late to the party. When I was a consumer of Phonegap back in the days, my most precious doc was the upgrade guides [1]. We didn't have the bandwidth or test process to update our app with every release of phonegap. But when it was time to upgrade (i.e. 1.4 to 1.9) The upgrade guide was my only resource to go over every change release by release, and I was happy after a week getting my app updated. I think having the same for the Plugins will be of benefit to the consumers. In order of priorities: *1. Having a upgrade guide per plugin including api changes* 2. If we can, try to adopt semver and change the version according to the level of change As we document the breaking changes, we will feel the pain of consumers, and as we write a lot of doc for upgrading we will want not to doc and leave the api stable. [1]: http://cordova.apache.org/docs/en/3.4.0/guide_platforms_android_upgrading.md.html#Upgrading%20Android http://cordova.apache.org/docs/en/3.4.0/guide_platforms_ios_upgrading.md.html#Upgrading%20iOS On Wed, Apr 30, 2014 at 9:36 AM, Michal Mocny wrote: > Thanks for choosing a saner option than the wiki ;) > > > On Wed, Apr 30, 2014 at 12:34 PM, Ray Camden wrote: > > > Ok folks, here is the document. I even took a quick stab at an outline. > > I've set this as Anyone Can Edit, but if that causes problems I'll set it > > back to invited folks only. > > > > > > > https://docs.google.com/document/d/1uJ5qXqQxK2oh1eZPgMdYuhK2rQTB7QMHXUHbkcomWgk/edit?usp=sharing > > > > > > > > From: Ray Camden > > Sent: Wednesday, April 30, 2014 11:28 AM > > To: dev@cordova.apache.org > > Subject: RE: Some pain points from our users :'( > > > > On it. > > > > From: Steven Gill > > Sent: Wednesday, April 30, 2014 11:12 AM > > To: dev@cordova.apache.org > > Subject: RE: Some pain points from our users :'( > > > > I would suggest creating a Google doc and sharing it here. > > On Apr 30, 2014 8:59 AM, "Ray Camden" wrote: > > > > > Crap, I spoke too soon. it is a "Immutable Page" and I can't edit it. > > > > > > > > > From: Marcel Kinard > > > Sent: Wednesday, April 30, 2014 10:41 AM > > > To: dev@cordova.apache.org > > > Subject: Re: Some pain points from our users :'( > > > > > > How about here? https://wiki.apache.org/cordova/signposts-draft . I'd > > > hope this works, as long as the contributions are considered "trivial" > by > > > Apache standards. Otherwise pull requests to cordova-doc.git would be > the > > > [slower and more proper] way to go. > > > > > > On Apr 30, 2014, at 11:29 AM, Ray Camden wrote: > > > > > > > Any particular place? Sorry if obvious - but it would need to be a > > > github repo multiple folks can edit. (Seems like that would be quicker > > than > > > PRs imo.) > > > > > > -- Carlos Santana
Re: Success with Crosswalk Engine (and webview plugins for 3.5.0)
haha "is so 2007" love it On Thu, May 1, 2014 at 7:58 AM, Joe Bowser wrote: > How? With something like this? > > "Even their dev process is slow. With Famo.us, we make you sign an NDA so > that you can't complain about how we change our API." > > In all seriousness, we're cool with anyone writing a third-party WebView > and I think that devs don't want to be locked in. Proprietary Javascript > is so 2007. > On May 1, 2014 6:14 AM, "Mike Billau" wrote: > > > So awesome and exciting! Thanks Joe (and Ian, and everyone else!) > > > > Hope the famo.us guys (or at least, their marketing team) doesn't come > > after ya'll. > > > > > > On Tue, Apr 29, 2014 at 9:46 PM, Hu, Ningxin > wrote: > > > > > So excited! > > > > > > Thanks, > > > -ningxin > > > > > > > -Original Message- > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > Sent: Wednesday, April 30, 2014 6:50 AM > > > > To: dev@cordova.apache.org > > > > Subject: Re: Success with Crosswalk Engine (and webview plugins for > > > 3.5.0) > > > > > > > > Sweet! > > > > > > > > > > > > On Tue, Apr 29, 2014 at 1:43 PM, Brian LeRoux wrote: > > > > > > > > > This is awesome. Thx for tackling Ian/Joe. This is easily one of > the > > > > > most exciting new features this year. (Esp once Gecko gets stable > > > > > enough to bolt > > > > > in.) > > > > > > > > > > > > > > > On Tue, Apr 29, 2014 at 1:32 PM, Ian Clelland < > > iclell...@chromium.org > > > > > >wrote: > > > > > > > > > > > I've managed now to get cordova-android up and running with Joe's > > > > > > pluggable_webview branch, and the cordova-crosswalk-engine > plugin, > > > > > passing > > > > > > all of the mobile spec tests. > > > > > > > > > > > > (I had a few tests in Contacts and Geolocation failing, but those > > > > > > were entirely due to timeouts; Contacts is *very* slow) > > > > > > > > > > > > My build is ARM-only, and there are some packaging issues to work > > > > > > through still, but I'm really happy with this so far. Its pretty > > > > > > amazing to just have to install a plugin, and have it swap in a > > > > > > modern webview, with, > > > > > say, > > > > > > WebGL support out of the box. > > > > > > > > > > > > It's all dependent right now on the mods to cordova-android, > which > > > > > > I'd really like to get out as part of 3.5.0. I'm going to try to > > > > > > merge that > > > > > in > > > > > > soon, to give everyone a chance to test it out and make sure > there > > > > > > aren't any regressions. > > > > > > > > > > > > Ian > > > > > > > > > > > > > > > > > -- Carlos Santana
Re: Docs for plugins
Hi Freak Are you referring about having a link on the website http://cordova.apache.org ? There is a link at the top "Plugins" it will take you to the plugins registry http://plugins.cordova.io On Thu, May 1, 2014 at 10:37 AM, Freak Show wrote: > > On May 1, 2014, at 10:21 AM, Andrew Grieve wrote: > > > Hi Freak, > > > > We're just talking about cordova core plugins (not all plugins). You can > > find the plugin registry here: http://plugins.cordova.io > > > > I had no idea that was there. Seems to me a top level "Available Plugins" > link would be a useful add to the website. > > Also, I would suggest you have a look at https://www.cocoacontrols.com. > It is a lot easier to use than plugins.cordova.io > > > -- Carlos Santana
Re: What should it mean to +1 a release
Andrew, Should we add a link to this document from the other *-release-process.md[1], maybe near the section "Start VOTE Thread"? [1]: https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#start-vote-thread https://github.com/apache/cordova-coho/blob/master/docs/cadence-release-process.md#start-vote-thread https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#start-vote-thread On Fri, May 2, 2014 at 7:53 AM, Andrew Grieve wrote: > Only if you run the command. > > > On Thu, May 1, 2014 at 1:26 PM, Joe Bowser wrote: > > > Doesn't coho audit every time we cut a release? > > > > On Thu, May 1, 2014 at 10:17 AM, Andrew Grieve > > wrote: > > > Drafted this up here: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Feel free to make changes directly, or to propose changes via pull > > requests. > > > > > > > > > On Fri, Apr 25, 2014 at 5:15 PM, James Jong > > wrote: > > > > > >> I went to Marvin’s talk on the release process at ApacheCon and > several > > of > > >> the Cordova committers spoke with him afterwards. He was very > > >> knowledgeable and willing to help. Any help in smoothing out the > > release > > >> process while limiting the overhead would be greatly appreciated > Marvin. > > >> -James Jong > > >> > > >> On Apr 25, 2014, at 3:25 PM, Marvin Humphrey > > >> wrote: > > >> > > >> > On Fri, Apr 25, 2014 at 10:55 AM, Andrew Grieve < > agri...@chromium.org > > > > > >> wrote: > > >> >> Had some discussions about this at ApacheCon, and I think it would > be > > >> >> good to formalize this in a release-process doc within coho/docs. > > >> > > > >> > I'd like to help with this. ASF release policy is an area of > > expertise > > >> for > > >> > me, and I look forward in particular to suggesting mechanisms which > > >> reduce > > >> > overhead while keeping Cordova and the ASF in sync. > > >> > > > >> > Marvin Humphrey > > >> > > >> > > > -- Carlos Santana
Re: First stab at Next Steps article
Mike, spajs.io didn't get the track we wanted, so we ended putting the content here: *"Best practices for mobile app development"* https://www.ibm.com/developerworks/mobile/worklight/best-practices.html We created this because we often got questioned "What are the best practices when doing hybrid mobile Apps?" And I think folks got tired of us answering "Well it depends on many factors" :-). So this is a first version on attempting to answer Ray The resources are 99.9% none-ibm product related (I say 99.9%, there one doc about our product :-) ). The goal of the resources was to make it mobile focus including mobile web and mobile hybrid. Please review and see if it worthy to included the link as a reference under "Other resources", if not I will not be offended. On Fri, May 2, 2014 at 6:39 PM, Carlos Santana wrote: > Sorry I'm late to the party, being trapped on a work conference all week. > > - Ray, thanks for starting this I'm interested on helping also, I know is > difficult on not being opinionated when giving advice base on our own > experiences, and that sometimes folks looking for solutions to problems > there is a fine line to walk between a web dev concern and a cordova dev > concern. > I think is good such type of documentation coming from our group, its not > about the tool, company, framework, sdk vendor is about the end to end > developer experience when a developer decides to use hybrid (coding, > testing, debugging, integrating, releasing) which the expectation that > their web dev skills should be enough, but the reality is that there is a > little more effort when dealing with hybrid which Cordova is here to help > with code, education, collaboration. > > > - Brian I think you walked into the trap :-), But good to remind folks how > we got here, and where we are heading (i.e. close the gap between web dev > and mobile dev) If someone is an awesome web dev should be able to create > awesome mobile apps with those skills > > > > > On Fri, May 2, 2014 at 12:07 PM, Brian LeRoux wrote: > >> Oh no you don't. This is YOUR baby to maintain. =) >> >> >> On Fri, May 2, 2014 at 6:59 AM, Ray Camden wrote: >> >> > I've gotten a lot of good feedback. My plan is to review, update, etc, >> and >> > see if it feels like a good 1.0 release for Monday at which point yall >> can >> > take it over. >> > >> > >> > From: kerrisho...@gmail.com on behalf of Kerri >> > Shotts >> > Sent: Friday, May 02, 2014 12:05 AM >> > To: dev@cordova.apache.org >> > Subject: Re: First stab at Next Steps article >> > >> > Awesome work thus far, and a good idea to have, imo. Getting to "hello, >> > world" is great, but having a jumping-off point for how to proceed after >> > that fact would be very beneficial. >> > >> > I added a few comments to the document, and also contributed some >> sections >> > on upgrading projects/plugins and testing. If anything there is too much >> > detail, wrong, or not desired in this document, feel free to remove as >> > needed. :-) >> > >> > If an ICLA is needed for what I added, one is on its way. I've been >> meaning >> > to send one anyway, but time keeps getting away from me! >> > >> > >> > >> > > > > -- > Carlos Santana > > -- Carlos Santana
Re: [DISCUSS] Release 3.5.0
I can help with testing Firefox OS. I assume I can't do much on the firefox os subtask[1] as a non-committer. There are a couple of pull requests for Firefox OS that I'd love to see in the release ([2] & [3]). PR [4] would be amazing too, but might need some rework. I'm waiting on cordova-lib to show up in github to migrate a local change from CLI that is related to these others too. None of this is release blocking though. Rodrigo. [1] https://issues.apache.org/jira/browse/CB-6593 [2] https://github.com/apache/cordova-plugin-contacts/pull/29 [3] https://github.com/apache/cordova-plugin-geolocation/pull/17 [4] https://github.com/apache/cordova-firefoxos/pull/7 - Original Message - From: "Steven Gill" To: dev@cordova.apache.org Sent: Friday, May 2, 2014 3:01:49 PM Subject: Re: [DISCUSS] Release 3.5.0 Releasing options for 3.5.0. Option 1: Release like we always have. * One zip containing zips of the platforms, js, docs, cli Option 2: Break up platforms/tools/plugins This is the option we are going towards with independent releases. * Platforms go in the platforms directory * Tools in the tools directory * Plugins in the plugins directory * where does cordova-js go? Tools directory? Since this will also be released on npm, we need to release it on dist somewhere as well. * do we need/want to release docs still? If yes, we should create a top level docs directory * cordova.io downloads section will need to reflect the change You can see both option 1 & 2 at [1] I personally like option 2 since this is the direction we are going towards with independent releases. All the platforms will be released on npm once the 3.5.0 vote concludes. I don't see much value in having one zip that has zips of all of our platforms, cli, js + docs anymore. [1] http://www.apache.org/dist/cordova/ On Thu, May 1, 2014 at 7:01 PM, Ian Clelland wrote: > At this point, I have to agree. I found a couple more issues while sorting > things out today that make me think it's not as obviously clean as it would > have to be to be in 3.5.0. > > (The hope was originally that the public interface would be *exactly* the > same, so it would be obvious that there were no compatibility issues, but > it's a bit more complicated than that now :( ) > > For now, it can stay on a branch, and we can experiment with it until it's > ready for merging. No need to hold up the rest of the cadence train for one > feature. > > Ian > > > On Thu, May 1, 2014 at 12:06 PM, Steven Gill > wrote: > > > I agree with Marcel. We should give it more time and bump it to a future > > release. > > On May 1, 2014 8:42 AM, "Marcel Kinard" wrote: > > > > > Given the recent thread on "customer pain points", I'd suggest that > this > > > capability be released when there is confidence that it works well, and > > any > > > breakages are understood and minimized. Reading the other threads, > sounds > > > like it's not quite there yet. > > > > > > On May 1, 2014, at 10:02 AM, Michal Mocny wrote: > > > > > > > Should we just be cautious and bump to 3.6, or do we give you till > > > Monday? > > > > > > > > > > > > On Thu, May 1, 2014 at 9:54 AM, Ian Clelland > > > > wrote: > > > > > > > >> Currently, I think that pluggable webview is a non-starter for > 3.5.0; > > > >> there's an unfortunate backwards-incompatibility introduced by > > > abstracting > > > >> CordovaWebView from a class into an interface. > > > >> > > > >> /me swears at Java for not having either multiple inheritance or > > > non-static > > > >> fields on interfaces... > > > >> > > > >> I'm playing with one possible solution to this today; if it works, > > then > > > we > > > >> might be able to get this in to 3.5, but I'm not 100% confident yet. > > > I'll > > > >> have to let you know later today. > > > > > > > > >
Re: First stab at Next Steps article
Sorry I'm late to the party, being trapped on a work conference all week. - Ray, thanks for starting this I'm interested on helping also, I know is difficult on not being opinionated when giving advice base on our own experiences, and that sometimes folks looking for solutions to problems there is a fine line to walk between a web dev concern and a cordova dev concern. I think is good such type of documentation coming from our group, its not about the tool, company, framework, sdk vendor is about the end to end developer experience when a developer decides to use hybrid (coding, testing, debugging, integrating, releasing) which the expectation that their web dev skills should be enough, but the reality is that there is a little more effort when dealing with hybrid which Cordova is here to help with code, education, collaboration. - Brian I think you walked into the trap :-), But good to remind folks how we got here, and where we are heading (i.e. close the gap between web dev and mobile dev) If someone is an awesome web dev should be able to create awesome mobile apps with those skills On Fri, May 2, 2014 at 12:07 PM, Brian LeRoux wrote: > Oh no you don't. This is YOUR baby to maintain. =) > > > On Fri, May 2, 2014 at 6:59 AM, Ray Camden wrote: > > > I've gotten a lot of good feedback. My plan is to review, update, etc, > and > > see if it feels like a good 1.0 release for Monday at which point yall > can > > take it over. > > > > > > From: kerrisho...@gmail.com on behalf of Kerri > > Shotts > > Sent: Friday, May 02, 2014 12:05 AM > > To: dev@cordova.apache.org > > Subject: Re: First stab at Next Steps article > > > > Awesome work thus far, and a good idea to have, imo. Getting to "hello, > > world" is great, but having a jumping-off point for how to proceed after > > that fact would be very beneficial. > > > > I added a few comments to the document, and also contributed some > sections > > on upgrading projects/plugins and testing. If anything there is too much > > detail, wrong, or not desired in this document, feel free to remove as > > needed. :-) > > > > If an ICLA is needed for what I added, one is on its way. I've been > meaning > > to send one anyway, but time keeps getting away from me! > > > > > > > -- Carlos Santana
[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091967
Found the culprit:
https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L312
If either of the first two conditions are used, it results in what I
experienced. Your code as you probably tested it used the third condition.
This test case results in a success:
```
navigator.camera.getPicture(onSuccess, onFail, { quality: 50,
destinationType:
Camera.DestinationType.NATIVE_URI,
sourceType :
Camera.PictureSourceType.CAMERA,
saveToPhotoAlbum: true,
encodingType: Camera.EncodingType.JPEG,
targetHeight: 200,
targetWidth: 200,
correctOrientation: true
});
function onSuccess(imageURI) {
alert(imageURI);
}
function onFail(message) {
alert('Failed because: ' + message);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091677 After debugging, there are two spots that are not handled: 1. https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L335 2. https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L358 For (1), there is no completionBlock For (2) there is no case for handling DestinationTypeNativeUri This is why my device was hanging, it was trying to return it as a Data URL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091340
How are you testing this? My device is non-responsive when I integrated
your code and do:
```
navigator.camera.getPicture(onSuccess, onFail, { quality: 50,
destinationType:
Camera.DestinationType.NATIVE_URI,
sourceType :
Camera.PictureSourceType.CAMERA,
saveToPhotoAlbum: true
});
function onSuccess(imageURI) {
alert(imageURI);
}
function onFail(message) {
alert('Failed because: ' + message);
}
```
I pulled your changes into my branch:
https://github.com/shazron/cordova-plugin-camera/tree/CB-6627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42090217 Filed https://issues.apache.org/jira/browse/CB-6627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-42090058 Filed: https://issues.apache.org/jira/browse/CB-6626 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: Update plugin.xml
Github user pororious commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/40#issuecomment-42089984 NAVER - http://www.naver.com/ hyunsu1...@naver.com ëê» ë³´ë´ì ë©ì¼ ì´ ë¤ìê³¼ ê°ì ì´ì ë¡ ì ì¡ ì¤í¨íìµëë¤. ë°ë ì¬ëì´ íìëì ë©ì¼ì ìì ì°¨ë¨ íììµëë¤. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: Update plugin.xml
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/40#issuecomment-42089981 From my code review comments (3 of them) in this PR, my recommendation is this pull request is unnecessary and is therefore rejected. Please close this pull request. Thank you for your pull request, and please continue to contribute to the project! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-coho pull request: Updated the cadence release process doc
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-coho pull request: Updated the cadence release process doc
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/20 Updated the cadence release process doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 59998603d422247eebabbf944826b2a72a93580d Author: Steve Gill Date: 2014-05-02T23:39:54Z Updated the cadence release process doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-contacts pull request: Add error codes to index.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugins pull request: Update README.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugins/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-vibration pull request: Implemented vibrateWithPatt...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/11#issuecomment-42088838 iCLA received. Filed: https://issues.apache.org/jira/browse/CB-6625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-42088711 Filed issue: https://issues.apache.org/jira/browse/CB-6624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: cordova-lib split out
What does cordova lib do? Grab bag of properties like this?
module.exports = {
}
On Fri, May 2, 2014 at 2:44 PM, Mark Koudritsky wrote:
> We will see how it goes, but I think cordova-lib should be a real module,
> rather than just a prefix. Even if eventually it will be a thin layer that
> just proxies to all other submodules. Anyway, right it would be very
> difficult to split it into several cordova-lib-something modules without
> cordova-lib being a module, there are no good logical separation lines in
> current code.
>
>
> On Fri, May 2, 2014 at 5:11 PM, Brian LeRoux wrote:
>
> > 1. node_modules is a bad idea and yep it was a joke
> > 2. are we looking to break out into something wherein the cordova-lib is
> a
> > dumb directory w/ modules inside it still? (unclear in current structure)
> >
> >
> > On Fri, May 2, 2014 at 12:13 PM, Michal Mocny
> wrote:
> >
> > > On Fri, May 2, 2014 at 2:43 PM, Mark Koudritsky
> > wrote:
> > >
> > > > Instructions for checking history in cordova-lib:
> > > >
> > > > git log will show no history from before this commit for files
> > > that
> > > > moved. To see full history use either
> > > > git log --follow
> > > > or
> > > > git log cli_pre_lib
> > > > git log plugman_pre_lib
> > > >
> > > > 'cli_pre_lib' and 'plugman_pre_lib' are tags for the last commit in
> > > > cordova-cli and plugman repos made before cordova-lib was split out.
> > > >
> > > > If you just do "git log " on a file, the earliest visible
> commit
> > > will
> > > > contain the same suggestions as above, but it will also tell you
> which
> > > repo
> > > > this file lived in.
> > > >
> > >
> > > Sweet, that was a good idea.
> > >
> > >
> > > >
> > > >
> > > >
> > > > On Fri, May 2, 2014 at 2:34 PM, Mark Koudritsky
> > > wrote:
> > > >
> > > > > Hi All,
> > > > >
> > > > > Cordova-lib is here. And since there is no way to do it gradually
> > > without
> > > > > eternally chasing changes between repos, I'm landing it on master
> in
> > a
> > > > big
> > > > > heavy chunk (as well as on branch named cordova-lib).
> > > > >
> > > > > Cordova lib is here:
> > > > > https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> > > > >
> > > > > when cloning cordova lib please make sure to run
> > > > >npm link in cordova-lib
> > > > >and
> > > > >npm link cordova-lib in cordova-cli and cordova-plugman repos
> > > > >
> > > > > The new code structure is based on what was discussed during the
> > > hangout
> > > > > with minor changes and is as follows:
> > > > >
> > > > > cordova-cli.git/
> > > > >
> > > > >-
> > > > >
> > > > >package.json
> > > > >-
> > > > >
> > > > >bin/cordova[.cmd]
> > > > >-
> > > > >
> > > > >src/cli.js
> > > > >-
> > > > >
> > > > >doc/help.txt
> > > > >-
> > > > >
> > > > >spec/cli.spec.js
> > > > >-
> > > > >
> > > > >cordova.js - a proxy for cordova-lib/src/cordova/cordova.js
> below,
> > > for
> > > > >compatibility, will go away later, when downstream tools start
> > using
> > > > >crdova-lib.
> > > > >
> > > > >
> > > > >
> > > > > cordova-plugman repo has a structure very similar to cordova-cli.
> > > > >
> > > > > cordova-lib.git/
> > > > >
> > > > >-
> > > > >
> > > > >cordova-lib/
> > > > >-
> > > > >
> > > > > cordova-lib.js - The future Cordova API surface. For now only
> > > > > contains proxy shims to cordova.js and plugman.js
> > > > > -
> > > > >
> > > > > src/cordova/
> > > > > -
> > > > >
> > > > > src/plugman/
> > > > > -
> > > > >
> > > > > src/ (for now only CordovaError)
> > > > > -
> > > > >
> > > > > templates/*
> > > > > -
> > > > >
> > > > > spec-plugman/
> > > > > -
> > > > >
> > > > > spec-cordva/
> > > > > -
> > > > >
> > > > > Specs are not in the same dir because they interact with
> > each
> > > > > other. This will be solved later, then they can be
> combined
> > > > into a single
> > > > > spec dir.
> > > > > -
> > > > >
> > > > >cordova-future-moduleX/ - will live as sibling of cordova-lib/.
> We
> > > can
> > > > >later move them to live under cordova-lib/node_modules/ if npm
> > > > linkwork becomes a burden for dev workflow.
> > > > >
> > > > >
> > > > >
> > > > > Some points:
> > > > >
> > > > > - code that does require('cordova/something') will break.
> > > > >
> > > > > - README files will need some attention.
> > > > >
> > > > > - npm-shrinkwrap.json files were deleted and will need to be
> > > re-created
> > > > > again.
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Release 3.5.0
Releasing options for 3.5.0. Option 1: Release like we always have. * One zip containing zips of the platforms, js, docs, cli Option 2: Break up platforms/tools/plugins This is the option we are going towards with independent releases. * Platforms go in the platforms directory * Tools in the tools directory * Plugins in the plugins directory * where does cordova-js go? Tools directory? Since this will also be released on npm, we need to release it on dist somewhere as well. * do we need/want to release docs still? If yes, we should create a top level docs directory * cordova.io downloads section will need to reflect the change You can see both option 1 & 2 at [1] I personally like option 2 since this is the direction we are going towards with independent releases. All the platforms will be released on npm once the 3.5.0 vote concludes. I don't see much value in having one zip that has zips of all of our platforms, cli, js + docs anymore. [1] http://www.apache.org/dist/cordova/ On Thu, May 1, 2014 at 7:01 PM, Ian Clelland wrote: > At this point, I have to agree. I found a couple more issues while sorting > things out today that make me think it's not as obviously clean as it would > have to be to be in 3.5.0. > > (The hope was originally that the public interface would be *exactly* the > same, so it would be obvious that there were no compatibility issues, but > it's a bit more complicated than that now :( ) > > For now, it can stay on a branch, and we can experiment with it until it's > ready for merging. No need to hold up the rest of the cadence train for one > feature. > > Ian > > > On Thu, May 1, 2014 at 12:06 PM, Steven Gill > wrote: > > > I agree with Marcel. We should give it more time and bump it to a future > > release. > > On May 1, 2014 8:42 AM, "Marcel Kinard" wrote: > > > > > Given the recent thread on "customer pain points", I'd suggest that > this > > > capability be released when there is confidence that it works well, and > > any > > > breakages are understood and minimized. Reading the other threads, > sounds > > > like it's not quite there yet. > > > > > > On May 1, 2014, at 10:02 AM, Michal Mocny wrote: > > > > > > > Should we just be cautious and bump to 3.6, or do we give you till > > > Monday? > > > > > > > > > > > > On Thu, May 1, 2014 at 9:54 AM, Ian Clelland > > > > wrote: > > > > > > > >> Currently, I think that pluggable webview is a non-starter for > 3.5.0; > > > >> there's an unfortunate backwards-incompatibility introduced by > > > abstracting > > > >> CordovaWebView from a class into an interface. > > > >> > > > >> /me swears at Java for not having either multiple inheritance or > > > non-static > > > >> fields on interfaces... > > > >> > > > >> I'm playing with one possible solution to this today; if it works, > > then > > > we > > > >> might be able to get this in to 3.5, but I'm not 100% confident yet. > > > I'll > > > >> have to let you know later today. > > > > > > > > >
[GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-42082556 @Inwinder Can you file a new issue? https://issues.apache.org/jira/browse/CB I'll work on it. what this needs is a possible re-factor so it is unit testable, right now it is only manually tested and error prone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: cordova-lib split out
We will see how it goes, but I think cordova-lib should be a real module,
rather than just a prefix. Even if eventually it will be a thin layer that
just proxies to all other submodules. Anyway, right it would be very
difficult to split it into several cordova-lib-something modules without
cordova-lib being a module, there are no good logical separation lines in
current code.
On Fri, May 2, 2014 at 5:11 PM, Brian LeRoux wrote:
> 1. node_modules is a bad idea and yep it was a joke
> 2. are we looking to break out into something wherein the cordova-lib is a
> dumb directory w/ modules inside it still? (unclear in current structure)
>
>
> On Fri, May 2, 2014 at 12:13 PM, Michal Mocny wrote:
>
> > On Fri, May 2, 2014 at 2:43 PM, Mark Koudritsky
> wrote:
> >
> > > Instructions for checking history in cordova-lib:
> > >
> > > git log will show no history from before this commit for files
> > that
> > > moved. To see full history use either
> > > git log --follow
> > > or
> > > git log cli_pre_lib
> > > git log plugman_pre_lib
> > >
> > > 'cli_pre_lib' and 'plugman_pre_lib' are tags for the last commit in
> > > cordova-cli and plugman repos made before cordova-lib was split out.
> > >
> > > If you just do "git log " on a file, the earliest visible commit
> > will
> > > contain the same suggestions as above, but it will also tell you which
> > repo
> > > this file lived in.
> > >
> >
> > Sweet, that was a good idea.
> >
> >
> > >
> > >
> > >
> > > On Fri, May 2, 2014 at 2:34 PM, Mark Koudritsky
> > wrote:
> > >
> > > > Hi All,
> > > >
> > > > Cordova-lib is here. And since there is no way to do it gradually
> > without
> > > > eternally chasing changes between repos, I'm landing it on master in
> a
> > > big
> > > > heavy chunk (as well as on branch named cordova-lib).
> > > >
> > > > Cordova lib is here:
> > > > https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> > > >
> > > > when cloning cordova lib please make sure to run
> > > >npm link in cordova-lib
> > > >and
> > > >npm link cordova-lib in cordova-cli and cordova-plugman repos
> > > >
> > > > The new code structure is based on what was discussed during the
> > hangout
> > > > with minor changes and is as follows:
> > > >
> > > > cordova-cli.git/
> > > >
> > > >-
> > > >
> > > >package.json
> > > >-
> > > >
> > > >bin/cordova[.cmd]
> > > >-
> > > >
> > > >src/cli.js
> > > >-
> > > >
> > > >doc/help.txt
> > > >-
> > > >
> > > >spec/cli.spec.js
> > > >-
> > > >
> > > >cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below,
> > for
> > > >compatibility, will go away later, when downstream tools start
> using
> > > >crdova-lib.
> > > >
> > > >
> > > >
> > > > cordova-plugman repo has a structure very similar to cordova-cli.
> > > >
> > > > cordova-lib.git/
> > > >
> > > >-
> > > >
> > > >cordova-lib/
> > > >-
> > > >
> > > > cordova-lib.js - The future Cordova API surface. For now only
> > > > contains proxy shims to cordova.js and plugman.js
> > > > -
> > > >
> > > > src/cordova/
> > > > -
> > > >
> > > > src/plugman/
> > > > -
> > > >
> > > > src/ (for now only CordovaError)
> > > > -
> > > >
> > > > templates/*
> > > > -
> > > >
> > > > spec-plugman/
> > > > -
> > > >
> > > > spec-cordva/
> > > > -
> > > >
> > > > Specs are not in the same dir because they interact with
> each
> > > > other. This will be solved later, then they can be combined
> > > into a single
> > > > spec dir.
> > > > -
> > > >
> > > >cordova-future-moduleX/ - will live as sibling of cordova-lib/. We
> > can
> > > >later move them to live under cordova-lib/node_modules/ if npm
> > > linkwork becomes a burden for dev workflow.
> > > >
> > > >
> > > >
> > > > Some points:
> > > >
> > > > - code that does require('cordova/something') will break.
> > > >
> > > > - README files will need some attention.
> > > >
> > > > - npm-shrinkwrap.json files were deleted and will need to be
> > re-created
> > > > again.
> > > >
> > >
> >
>
[GitHub] cordova-plugin-network-information pull request: Fixed syntax erro...
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/6#issuecomment-42080099 Fixed in commit 44005034004559bb798f402b4ef177f5f70167d8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: CB-3207 Newer imp...
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/9#issuecomment-42079997 This can be closed, merged already: see 44005034004559bb798f402b4ef177f5f70167d8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: cordova-lib split out
1. node_modules is a bad idea and yep it was a joke
2. are we looking to break out into something wherein the cordova-lib is a
dumb directory w/ modules inside it still? (unclear in current structure)
On Fri, May 2, 2014 at 12:13 PM, Michal Mocny wrote:
> On Fri, May 2, 2014 at 2:43 PM, Mark Koudritsky wrote:
>
> > Instructions for checking history in cordova-lib:
> >
> > git log will show no history from before this commit for files
> that
> > moved. To see full history use either
> > git log --follow
> > or
> > git log cli_pre_lib
> > git log plugman_pre_lib
> >
> > 'cli_pre_lib' and 'plugman_pre_lib' are tags for the last commit in
> > cordova-cli and plugman repos made before cordova-lib was split out.
> >
> > If you just do "git log " on a file, the earliest visible commit
> will
> > contain the same suggestions as above, but it will also tell you which
> repo
> > this file lived in.
> >
>
> Sweet, that was a good idea.
>
>
> >
> >
> >
> > On Fri, May 2, 2014 at 2:34 PM, Mark Koudritsky
> wrote:
> >
> > > Hi All,
> > >
> > > Cordova-lib is here. And since there is no way to do it gradually
> without
> > > eternally chasing changes between repos, I'm landing it on master in a
> > big
> > > heavy chunk (as well as on branch named cordova-lib).
> > >
> > > Cordova lib is here:
> > > https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> > >
> > > when cloning cordova lib please make sure to run
> > >npm link in cordova-lib
> > >and
> > >npm link cordova-lib in cordova-cli and cordova-plugman repos
> > >
> > > The new code structure is based on what was discussed during the
> hangout
> > > with minor changes and is as follows:
> > >
> > > cordova-cli.git/
> > >
> > >-
> > >
> > >package.json
> > >-
> > >
> > >bin/cordova[.cmd]
> > >-
> > >
> > >src/cli.js
> > >-
> > >
> > >doc/help.txt
> > >-
> > >
> > >spec/cli.spec.js
> > >-
> > >
> > >cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below,
> for
> > >compatibility, will go away later, when downstream tools start using
> > >crdova-lib.
> > >
> > >
> > >
> > > cordova-plugman repo has a structure very similar to cordova-cli.
> > >
> > > cordova-lib.git/
> > >
> > >-
> > >
> > >cordova-lib/
> > >-
> > >
> > > cordova-lib.js - The future Cordova API surface. For now only
> > > contains proxy shims to cordova.js and plugman.js
> > > -
> > >
> > > src/cordova/
> > > -
> > >
> > > src/plugman/
> > > -
> > >
> > > src/ (for now only CordovaError)
> > > -
> > >
> > > templates/*
> > > -
> > >
> > > spec-plugman/
> > > -
> > >
> > > spec-cordva/
> > > -
> > >
> > > Specs are not in the same dir because they interact with each
> > > other. This will be solved later, then they can be combined
> > into a single
> > > spec dir.
> > > -
> > >
> > >cordova-future-moduleX/ - will live as sibling of cordova-lib/. We
> can
> > >later move them to live under cordova-lib/node_modules/ if npm
> > linkwork becomes a burden for dev workflow.
> > >
> > >
> > >
> > > Some points:
> > >
> > > - code that does require('cordova/something') will break.
> > >
> > > - README files will need some attention.
> > >
> > > - npm-shrinkwrap.json files were deleted and will need to be
> re-created
> > > again.
> > >
> >
>
Re: cordova-lib split out
On Fri, May 2, 2014 at 3:52 PM, Michal Mocny wrote: > Added cordova-lib to coho repo list --- but I haven't figured out which > lists it needs to go in yet, so that will need to be updated for releases > etc. > > Mark, I noticed that cordova-lib is in CLI package.json deps, but not for > plugman. I imagine thats an oversight? > Yep. Added it. Also fixed the cordova-lib dep version in CLI. Cordova-lib version is now set to be the same as latest plugman version. > Also, if you npm install before npm link cordova-lib, it will fail since > there is no published version yet. Its not a problem.
[GitHub] cordova-plugin-geolocation pull request: CB-5416 - Adding support ...
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/17 CB-5416 - Adding support for auto-managing permissions With [CB-5416](https://github.com/apache/cordova-cli/pull/168) merged into cordova-cli, we can have plugins automatically set the permissions in the manifest. Reviewed by @zalun. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mozilla-cordova/cordova-plugin-geolocation auto-permission Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit d4558831838ae3070de46ef8bcaa5e7174a1db7d Author: Rodrigo Silveira Date: 2014-04-22T19:07:19Z CB-5416 - Adding support for auto-managing permissions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: cordova-lib split out
Added cordova-lib to coho repo list --- but I haven't figured out which
lists it needs to go in yet, so that will need to be updated for releases
etc.
Mark, I noticed that cordova-lib is in CLI package.json deps, but not for
plugman. I imagine thats an oversight?
Also, if you npm install before npm link cordova-lib, it will fail since
there is no published version yet. Its not a problem.
On Fri, May 2, 2014 at 3:36 PM, Naik, Archana wrote:
> Cool. I just checked amazon-fireos and looks like there are no scripts
> referring to cordova/something. So all is well. :)
>
> Thanks
> Archana
>
> On 5/2/14 12:33 PM, "Mark Koudritsky" wrote:
>
> >On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
> >
> >> Thanks Mark for sending this out. I just noticed these changes as I need
> >> to fix something in amazon_fireos_parser.js. :)
> >>
> >> Question: re: code that does require('cordova/something') will break.
> >> Platform scripts use 'cordova/something' and I guess we will have to
> >>take
> >> care of those. Is this change going in 3.5.0?
> >>
> >
> >Hi Archana,
> >Which platform scripts are you referring to?
> >At least the scripts in cordova-ios and cordova-android don't seem to
> >require() anything from within cordova. "cordova build" works ok for iOS
> >and Android.
> >All the code that lived in cordova-cli and cordova-plugman repos was
> >updated.
> >
> >The only place where I saw this problem was in
> >cca where
> >it does
> >var platforms = require('cordova/platforms')
> >
> >This would need to be changed to
> >var cordova_lib = require('cordova-lib');
> >var platforms = cordova_lib.cordova_platforms;
> >
> >Note that
> >cordova_lib.cordova_platforms
> >is a temporary shim, until we move to platforms list/object which will be
> >common to plugman and ex cordova-cli code.
>
>
Re: cordova-lib split out
Cool. I just checked amazon-fireos and looks like there are no scripts
referring to cordova/something. So all is well. :)
Thanks
Archana
On 5/2/14 12:33 PM, "Mark Koudritsky" wrote:
>On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
>
>> Thanks Mark for sending this out. I just noticed these changes as I need
>> to fix something in amazon_fireos_parser.js. :)
>>
>> Question: re: code that does require('cordova/something') will break.
>> Platform scripts use 'cordova/something' and I guess we will have to
>>take
>> care of those. Is this change going in 3.5.0?
>>
>
>Hi Archana,
>Which platform scripts are you referring to?
>At least the scripts in cordova-ios and cordova-android don't seem to
>require() anything from within cordova. "cordova build" works ok for iOS
>and Android.
>All the code that lived in cordova-cli and cordova-plugman repos was
>updated.
>
>The only place where I saw this problem was in
>cca where
>it does
>var platforms = require('cordova/platforms')
>
>This would need to be changed to
>var cordova_lib = require('cordova-lib');
>var platforms = cordova_lib.cordova_platforms;
>
>Note that
>cordova_lib.cordova_platforms
>is a temporary shim, until we move to platforms list/object which will be
>common to plugman and ex cordova-cli code.
Re: cordova-lib split out
On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
> Thanks Mark for sending this out. I just noticed these changes as I need
> to fix something in amazon_fireos_parser.js. :)
>
> Question: re: code that does require('cordova/something') will break.
> Platform scripts use 'cordova/something' and I guess we will have to take
> care of those. Is this change going in 3.5.0?
>
Hi Archana,
Which platform scripts are you referring to?
At least the scripts in cordova-ios and cordova-android don't seem to
require() anything from within cordova. "cordova build" works ok for iOS
and Android.
All the code that lived in cordova-cli and cordova-plugman repos was
updated.
The only place where I saw this problem was in
cca where
it does
var platforms = require('cordova/platforms')
This would need to be changed to
var cordova_lib = require('cordova-lib');
var platforms = cordova_lib.cordova_platforms;
Note that
cordova_lib.cordova_platforms
is a temporary shim, until we move to platforms list/object which will be
common to plugman and ex cordova-cli code.
Re: cordova-lib split out
Added JIRA component: CordovaLib
On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
> Thanks Mark for sending this out. I just noticed these changes as I need
> to fix something in amazon_fireos_parser.js. :)
>
> Question: re: code that does require('cordova/something') will break.
> Platform scripts use 'cordova/something' and I guess we will have to take
> care of those. Is this change going in 3.5.0?
>
> Archana
>
> On 5/2/14 11:34 AM, "Mark Koudritsky" wrote:
>
> >Hi All,
> >
> >Cordova-lib is here. And since there is no way to do it gradually without
> >eternally chasing changes between repos, I'm landing it on master in a big
> >heavy chunk (as well as on branch named cordova-lib).
> >
> >Cordova lib is here:
> >https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> >
> >when cloning cordova lib please make sure to run
> > npm link in cordova-lib
> > and
> > npm link cordova-lib in cordova-cli and cordova-plugman repos
> >
> >The new code structure is based on what was discussed during the hangout
> >with minor changes and is as follows:
> >
> >cordova-cli.git/
> >
> > -
> >
> > package.json
> > -
> >
> > bin/cordova[.cmd]
> > -
> >
> > src/cli.js
> > -
> >
> > doc/help.txt
> > -
> >
> > spec/cli.spec.js
> > -
> >
> > cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below, for
> > compatibility, will go away later, when downstream tools start using
> > crdova-lib.
> >
> >
> >
> >cordova-plugman repo has a structure very similar to cordova-cli.
> >
> >cordova-lib.git/
> >
> > -
> >
> > cordova-lib/
> > -
> >
> > cordova-lib.js - The future Cordova API surface. For now only
> > contains proxy shims to cordova.js and plugman.js
> > -
> >
> > src/cordova/
> > -
> >
> > src/plugman/
> > -
> >
> > src/ (for now only CordovaError)
> > -
> >
> > templates/*
> > -
> >
> > spec-plugman/
> > -
> >
> > spec-cordva/
> > -
> >
> > Specs are not in the same dir because they interact with each
> > other. This will be solved later, then they can be combined
> >into a single
> > spec dir.
> > -
> >
> > cordova-future-moduleX/ - will live as sibling of cordova-lib/. We can
> > later move them to live under cordova-lib/node_modules/ if npm link
> >work
> > becomes a burden for dev workflow.
> >
> >
> >
> >Some points:
> >
> > - code that does require('cordova/something') will break.
> >
> > - README files will need some attention.
> >
> > - npm-shrinkwrap.json files were deleted and will need to be re-created
> >again.
>
>
Re: cordova-lib split out
Thanks Mark for sending this out. I just noticed these changes as I need
to fix something in amazon_fireos_parser.js. :)
Question: re: code that does require('cordova/something') will break.
Platform scripts use 'cordova/something' and I guess we will have to take
care of those. Is this change going in 3.5.0?
Archana
On 5/2/14 11:34 AM, "Mark Koudritsky" wrote:
>Hi All,
>
>Cordova-lib is here. And since there is no way to do it gradually without
>eternally chasing changes between repos, I'm landing it on master in a big
>heavy chunk (as well as on branch named cordova-lib).
>
>Cordova lib is here:
>https://git-wip-us.apache.org/repos/asf/cordova-lib.git
>
>when cloning cordova lib please make sure to run
> npm link in cordova-lib
> and
> npm link cordova-lib in cordova-cli and cordova-plugman repos
>
>The new code structure is based on what was discussed during the hangout
>with minor changes and is as follows:
>
>cordova-cli.git/
>
> -
>
> package.json
> -
>
> bin/cordova[.cmd]
> -
>
> src/cli.js
> -
>
> doc/help.txt
> -
>
> spec/cli.spec.js
> -
>
> cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below, for
> compatibility, will go away later, when downstream tools start using
> crdova-lib.
>
>
>
>cordova-plugman repo has a structure very similar to cordova-cli.
>
>cordova-lib.git/
>
> -
>
> cordova-lib/
> -
>
> cordova-lib.js - The future Cordova API surface. For now only
> contains proxy shims to cordova.js and plugman.js
> -
>
> src/cordova/
> -
>
> src/plugman/
> -
>
> src/ (for now only CordovaError)
> -
>
> templates/*
> -
>
> spec-plugman/
> -
>
> spec-cordva/
> -
>
> Specs are not in the same dir because they interact with each
> other. This will be solved later, then they can be combined
>into a single
> spec dir.
> -
>
> cordova-future-moduleX/ - will live as sibling of cordova-lib/. We can
> later move them to live under cordova-lib/node_modules/ if npm link
>work
> becomes a burden for dev workflow.
>
>
>
>Some points:
>
> - code that does require('cordova/something') will break.
>
> - README files will need some attention.
>
> - npm-shrinkwrap.json files were deleted and will need to be re-created
>again.
Re: cordova-lib split out
On Fri, May 2, 2014 at 2:43 PM, Mark Koudritsky wrote:
> Instructions for checking history in cordova-lib:
>
> git log will show no history from before this commit for files that
> moved. To see full history use either
> git log --follow
> or
> git log cli_pre_lib
> git log plugman_pre_lib
>
> 'cli_pre_lib' and 'plugman_pre_lib' are tags for the last commit in
> cordova-cli and plugman repos made before cordova-lib was split out.
>
> If you just do "git log " on a file, the earliest visible commit will
> contain the same suggestions as above, but it will also tell you which repo
> this file lived in.
>
Sweet, that was a good idea.
>
>
>
> On Fri, May 2, 2014 at 2:34 PM, Mark Koudritsky wrote:
>
> > Hi All,
> >
> > Cordova-lib is here. And since there is no way to do it gradually without
> > eternally chasing changes between repos, I'm landing it on master in a
> big
> > heavy chunk (as well as on branch named cordova-lib).
> >
> > Cordova lib is here:
> > https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> >
> > when cloning cordova lib please make sure to run
> >npm link in cordova-lib
> >and
> >npm link cordova-lib in cordova-cli and cordova-plugman repos
> >
> > The new code structure is based on what was discussed during the hangout
> > with minor changes and is as follows:
> >
> > cordova-cli.git/
> >
> >-
> >
> >package.json
> >-
> >
> >bin/cordova[.cmd]
> >-
> >
> >src/cli.js
> >-
> >
> >doc/help.txt
> >-
> >
> >spec/cli.spec.js
> >-
> >
> >cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below, for
> >compatibility, will go away later, when downstream tools start using
> >crdova-lib.
> >
> >
> >
> > cordova-plugman repo has a structure very similar to cordova-cli.
> >
> > cordova-lib.git/
> >
> >-
> >
> >cordova-lib/
> >-
> >
> > cordova-lib.js - The future Cordova API surface. For now only
> > contains proxy shims to cordova.js and plugman.js
> > -
> >
> > src/cordova/
> > -
> >
> > src/plugman/
> > -
> >
> > src/ (for now only CordovaError)
> > -
> >
> > templates/*
> > -
> >
> > spec-plugman/
> > -
> >
> > spec-cordva/
> > -
> >
> > Specs are not in the same dir because they interact with each
> > other. This will be solved later, then they can be combined
> into a single
> > spec dir.
> > -
> >
> >cordova-future-moduleX/ - will live as sibling of cordova-lib/. We can
> >later move them to live under cordova-lib/node_modules/ if npm
> linkwork becomes a burden for dev workflow.
> >
> >
> >
> > Some points:
> >
> > - code that does require('cordova/something') will break.
> >
> > - README files will need some attention.
> >
> > - npm-shrinkwrap.json files were deleted and will need to be re-created
> > again.
> >
>
Re: First stab at Next Steps article
Oh no you don't. This is YOUR baby to maintain. =) On Fri, May 2, 2014 at 6:59 AM, Ray Camden wrote: > I've gotten a lot of good feedback. My plan is to review, update, etc, and > see if it feels like a good 1.0 release for Monday at which point yall can > take it over. > > > From: kerrisho...@gmail.com on behalf of Kerri > Shotts > Sent: Friday, May 02, 2014 12:05 AM > To: dev@cordova.apache.org > Subject: Re: First stab at Next Steps article > > Awesome work thus far, and a good idea to have, imo. Getting to "hello, > world" is great, but having a jumping-off point for how to proceed after > that fact would be very beneficial. > > I added a few comments to the document, and also contributed some sections > on upgrading projects/plugins and testing. If anything there is too much > detail, wrong, or not desired in this document, feel free to remove as > needed. :-) > > If an ICLA is needed for what I added, one is on its way. I've been meaning > to send one anyway, but time keeps getting away from me! > > >
Re: cordova-lib split out
Thanks Mark, I'll take a look now.
One quick note: at the hangout we raised the option of placing everything
in cordova-lib.git repo inside a top-level node_modules dir. There was
some debate if that was a good idea, bad idea, or just a joke.. Right now,
we think it may help with dev workflow, but had some concerns it may
actually mask dependency bugs. So we decided not to do it until we
experiment to understand more of the implications. It would be useless at
this point anyway, and we can add it once there are more top-level node
modules (as Mark says). That would have no impact on releases or end
users, it would just change our dev instructions a bit.
-Michal
On Fri, May 2, 2014 at 2:34 PM, Mark Koudritsky wrote:
> Hi All,
>
> Cordova-lib is here. And since there is no way to do it gradually without
> eternally chasing changes between repos, I'm landing it on master in a big
> heavy chunk (as well as on branch named cordova-lib).
>
> Cordova lib is here:
> https://git-wip-us.apache.org/repos/asf/cordova-lib.git
>
> when cloning cordova lib please make sure to run
>npm link in cordova-lib
>and
>npm link cordova-lib in cordova-cli and cordova-plugman repos
>
> The new code structure is based on what was discussed during the hangout
> with minor changes and is as follows:
>
> cordova-cli.git/
>
>-
>
>package.json
>-
>
>bin/cordova[.cmd]
>-
>
>src/cli.js
>-
>
>doc/help.txt
>-
>
>spec/cli.spec.js
>-
>
>cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below, for
>compatibility, will go away later, when downstream tools start using
>crdova-lib.
>
>
>
> cordova-plugman repo has a structure very similar to cordova-cli.
>
> cordova-lib.git/
>
>-
>
>cordova-lib/
>-
>
> cordova-lib.js - The future Cordova API surface. For now only
> contains proxy shims to cordova.js and plugman.js
> -
>
> src/cordova/
> -
>
> src/plugman/
> -
>
> src/ (for now only CordovaError)
> -
>
> templates/*
> -
>
> spec-plugman/
> -
>
> spec-cordva/
> -
>
> Specs are not in the same dir because they interact with each
> other. This will be solved later, then they can be combined
> into a single
> spec dir.
> -
>
>cordova-future-moduleX/ - will live as sibling of cordova-lib/. We can
>later move them to live under cordova-lib/node_modules/ if npm link work
>becomes a burden for dev workflow.
>
>
>
> Some points:
>
> - code that does require('cordova/something') will break.
>
> - README files will need some attention.
>
> - npm-shrinkwrap.json files were deleted and will need to be re-created
> again.
>
Re: [jira] [Commented] (CB-6594) [Release + 3.5.0] Branch & Test & Tag RC1 for Ubuntu
Hey Maxim, I'm assuming you want me to pull those in :P On Fri, May 2, 2014 at 10:35 AM, Maxim Ermilov (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/CB-6594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987982#comment-13987982] > > Maxim Ermilov commented on CB-6594: > --- > > https://github.com/apache/cordova-ubuntu/pull/6 > https://github.com/apache/cordova-plugin-file/pull/43 > https://github.com/apache/cordova-plugin-file-transfer/pull/29 > https://github.com/apache/cordova-cli/pull/136 > https://github.com/apache/cordova-plugin-device-motion/pull/12 > https://github.com/apache/cordova-plugin-camera/pull/25 > > > > [Release + 3.5.0] Branch & Test & Tag RC1 for Ubuntu > > > > > > Key: CB-6594 > > URL: https://issues.apache.org/jira/browse/CB-6594 > > Project: Apache Cordova > > Issue Type: Sub-task > > Components: Ubuntu > >Reporter: Steve Gill > >Assignee: Maxim Ermilov > > Fix For: 3.5.0 > > > > > > Refer to Workflow here: > > http://wiki.apache.org/cordova/CuttingReleases > > > > -- > This message was sent by Atlassian JIRA > (v6.2#6252) >
Re: cordova-lib split out
Instructions for checking history in cordova-lib:
git log will show no history from before this commit for files that
moved. To see full history use either
git log --follow
or
git log cli_pre_lib
git log plugman_pre_lib
'cli_pre_lib' and 'plugman_pre_lib' are tags for the last commit in
cordova-cli and plugman repos made before cordova-lib was split out.
If you just do "git log " on a file, the earliest visible commit will
contain the same suggestions as above, but it will also tell you which repo
this file lived in.
On Fri, May 2, 2014 at 2:34 PM, Mark Koudritsky wrote:
> Hi All,
>
> Cordova-lib is here. And since there is no way to do it gradually without
> eternally chasing changes between repos, I'm landing it on master in a big
> heavy chunk (as well as on branch named cordova-lib).
>
> Cordova lib is here:
> https://git-wip-us.apache.org/repos/asf/cordova-lib.git
>
> when cloning cordova lib please make sure to run
>npm link in cordova-lib
>and
>npm link cordova-lib in cordova-cli and cordova-plugman repos
>
> The new code structure is based on what was discussed during the hangout
> with minor changes and is as follows:
>
> cordova-cli.git/
>
>-
>
>package.json
>-
>
>bin/cordova[.cmd]
>-
>
>src/cli.js
>-
>
>doc/help.txt
>-
>
>spec/cli.spec.js
>-
>
>cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below, for
>compatibility, will go away later, when downstream tools start using
>crdova-lib.
>
>
>
> cordova-plugman repo has a structure very similar to cordova-cli.
>
> cordova-lib.git/
>
>-
>
>cordova-lib/
>-
>
> cordova-lib.js - The future Cordova API surface. For now only
> contains proxy shims to cordova.js and plugman.js
> -
>
> src/cordova/
> -
>
> src/plugman/
> -
>
> src/ (for now only CordovaError)
> -
>
> templates/*
> -
>
> spec-plugman/
> -
>
> spec-cordva/
> -
>
> Specs are not in the same dir because they interact with each
> other. This will be solved later, then they can be combined into a
> single
> spec dir.
> -
>
>cordova-future-moduleX/ - will live as sibling of cordova-lib/. We can
>later move them to live under cordova-lib/node_modules/ if npm linkwork
> becomes a burden for dev workflow.
>
>
>
> Some points:
>
> - code that does require('cordova/something') will break.
>
> - README files will need some attention.
>
> - npm-shrinkwrap.json files were deleted and will need to be re-created
> again.
>
cordova-lib split out
Hi All,
Cordova-lib is here. And since there is no way to do it gradually without
eternally chasing changes between repos, I'm landing it on master in a big
heavy chunk (as well as on branch named cordova-lib).
Cordova lib is here: https://git-wip-us.apache.org/repos/asf/cordova-lib.git
when cloning cordova lib please make sure to run
npm link in cordova-lib
and
npm link cordova-lib in cordova-cli and cordova-plugman repos
The new code structure is based on what was discussed during the hangout
with minor changes and is as follows:
cordova-cli.git/
-
package.json
-
bin/cordova[.cmd]
-
src/cli.js
-
doc/help.txt
-
spec/cli.spec.js
-
cordova.js - a proxy for cordova-lib/src/cordova/cordova.js below, for
compatibility, will go away later, when downstream tools start using
crdova-lib.
cordova-plugman repo has a structure very similar to cordova-cli.
cordova-lib.git/
-
cordova-lib/
-
cordova-lib.js - The future Cordova API surface. For now only
contains proxy shims to cordova.js and plugman.js
-
src/cordova/
-
src/plugman/
-
src/ (for now only CordovaError)
-
templates/*
-
spec-plugman/
-
spec-cordva/
-
Specs are not in the same dir because they interact with each
other. This will be solved later, then they can be combined
into a single
spec dir.
-
cordova-future-moduleX/ - will live as sibling of cordova-lib/. We can
later move them to live under cordova-lib/node_modules/ if npm link work
becomes a burden for dev workflow.
Some points:
- code that does require('cordova/something') will break.
- README files will need some attention.
- npm-shrinkwrap.json files were deleted and will need to be re-created
again.
[GitHub] cordova-plugin-file pull request: ubuntu: Change FS URL scheme to ...
Github user pororious commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/43#issuecomment-42056757 NAVER - http://www.naver.com/ hyunsu1...@naver.com ëê» ë³´ë´ì ë©ì¼ <[cordova-plugin-file] ubuntu: Change FS URL scheme to 'cdvfile' (#43)> ì´ ë¤ìê³¼ ê°ì ì´ì ë¡ ì ì¡ ì¤í¨íìµëë¤. ë°ë ì¬ëì´ íìëì ë©ì¼ì ìì ì°¨ë¨ íììµëë¤. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: ubuntu: support 'cdvfil...
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/29 ubuntu: support 'cdvfile' URI You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-file-transfer master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit dbe20f1d90c848954ce66eeb1bc92556e544e295 Author: Maxim Ermilov Date: 2014-05-02T17:25:56Z ubuntu: support 'cdvfile' URI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: ubuntu: Change FS URL scheme to ...
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-file/pull/43 ubuntu: Change FS URL scheme to 'cdvfile' You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 2658db7287022e7d34048282e641cc495f24713d Author: Maxim Ermilov Date: 2014-04-23T11:47:08Z ubuntu: Return size with Entry.getMetadata() method commit 764bff63a86532844d63eddbb3225507464d9518 Author: Maxim Ermilov Date: 2014-05-02T17:24:22Z ubuntu: Change FS URL scheme to 'cdvfile' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-device-motion pull request: ubuntu: don't destroy c...
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/12 ubuntu: don't destroy callback after use You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-device-motion master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 2670391c79ac1703b7ffe1892ab81be1806df005 Author: Maxim Ermilov Date: 2014-05-02T16:57:49Z ubuntu: don't destroy callback after use --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: ubuntu: use application direct...
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/25 ubuntu: use application directory for images You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 28e5e4d4623d1fce5f88e584de37f231a1c3c93f Author: Maxim Ermilov Date: 2014-05-02T17:08:27Z ubuntu: use application directory for images --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-ubuntu pull request: 3.5
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-ubuntu/pull/6 3.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-ubuntu master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ubuntu/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit e4d45807644f8f0a453b112ae674727b24b1f4e0 Author: Maxim Ermilov Date: 2014-04-14T11:04:35Z bin/build: switch to async shelljs.exec commit 63bb865cc4069ce265f157d3c4000737b2a5275a Author: Maxim Ermilov Date: 2014-04-14T11:30:42Z bin/build: specify framework instead of series for click chroot commit 46553475de8818e4af526a95c343db2bcc8935bf Author: Maxim Ermilov Date: 2014-04-14T11:46:36Z bin/build: fixes for --nobuild commit 94a65b966e32ddeb46f204fa08a435a4ba38e88f Author: Maxim Ermilov Date: 2014-04-15T10:10:01Z don't hard code cpu count commit af5a228e1c72cb98ec12083c55ed94dc052b87b1 Author: Maxim Ermilov Date: 2014-04-15T10:13:05Z bin/build/[build,run] always report errors commit 77cda302b077d712bb4e938581febd1bce5efca2 Author: Maxim Ermilov Date: 2014-04-16T09:50:22Z check requirements before build commit 0c28378e833e56d2b2d8c4a63cfb34702983cf34 Author: Maxim Ermilov Date: 2014-04-16T10:20:10Z workaround for qt 5.2 commit 02f836318184a123fba9c0b9f1725d6734cd5066 Author: Maxim Ermilov Date: 2014-04-25T10:23:58Z add .editorconfig commit 67869587550e8dcc658360238f9e4c86c83d5b30 Author: Maxim Ermilov Date: 2014-05-01T21:38:39Z allow inter plugin communication commit 3b6762c655c21cf635964cc45e66a5c365c915ff Author: Maxim Ermilov Date: 2014-05-01T21:43:12Z another qt 5.2 workaround --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugman pull request: Fix plugin check error, when plugin ...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugman/pull/76#issuecomment-42056008 Would be great if there was a test for this in: https://github.com/apache/cordova-plugman/blob/master/spec/fetch.spec.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView
Since you talked about plugin so do you plan to introduce/merge xwalk extension mechanism to Cordova plugin mechanism? Thanks, Leo On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser wrote: > Hey > > So, once again, we're dealing with some major API changes once we > introduce pluggable webview. The first change that was done for > sanity was finally deprecating setProperty. This was slated to be > removed by 3.5 or in six months from the deprecation date, but we kept > it in too long. While I would like to assume that everyone has moved > over to setting their preferences in config.xml, which is the much > more sane way of doing things, we can't do that. We need to publicize > this in some blog posts, as well as in our documentation somehow. > There will obviously be some pissed off users, as we've seen in past > posts, but I think having the ability to use a WebView other than > Chrome 30 is worth these changes. > > The other change, which says more about our design is adding a getter > method for pluginManager. We need to access the pluginManager to get > plugins, and it's expected that everyone who implements a > CordovaWebView will have this method produce a pluginManager. In the > past, it was just publicly exposed, which was not the greatest idea > and was kinda sloppy. > > So, how do people want to handle these changes? We constantly get > shit for changing our API when we do development, but I do think these > improvements are extremely important, especially given how much flak > we get for relying on Android's WebView. > > Thoughts? > > Joe >
Re: What should it mean to +1 a release
Only if you run the command. On Thu, May 1, 2014 at 1:26 PM, Joe Bowser wrote: > Doesn't coho audit every time we cut a release? > > On Thu, May 1, 2014 at 10:17 AM, Andrew Grieve > wrote: > > Drafted this up here: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Feel free to make changes directly, or to propose changes via pull > requests. > > > > > > On Fri, Apr 25, 2014 at 5:15 PM, James Jong > wrote: > > > >> I went to Marvin’s talk on the release process at ApacheCon and several > of > >> the Cordova committers spoke with him afterwards. He was very > >> knowledgeable and willing to help. Any help in smoothing out the > release > >> process while limiting the overhead would be greatly appreciated Marvin. > >> -James Jong > >> > >> On Apr 25, 2014, at 3:25 PM, Marvin Humphrey > >> wrote: > >> > >> > On Fri, Apr 25, 2014 at 10:55 AM, Andrew Grieve > > >> wrote: > >> >> Had some discussions about this at ApacheCon, and I think it would be > >> >> good to formalize this in a release-process doc within coho/docs. > >> > > >> > I'd like to help with this. ASF release policy is an area of > expertise > >> for > >> > me, and I look forward in particular to suggesting mechanisms which > >> reduce > >> > overhead while keeping Cordova and the ASF in sync. > >> > > >> > Marvin Humphrey > >> > >> >
RE: First stab at Next Steps article
I've gotten a lot of good feedback. My plan is to review, update, etc, and see if it feels like a good 1.0 release for Monday at which point yall can take it over. From: kerrisho...@gmail.com on behalf of Kerri Shotts Sent: Friday, May 02, 2014 12:05 AM To: dev@cordova.apache.org Subject: Re: First stab at Next Steps article Awesome work thus far, and a good idea to have, imo. Getting to "hello, world" is great, but having a jumping-off point for how to proceed after that fact would be very beneficial. I added a few comments to the document, and also contributed some sections on upgrading projects/plugins and testing. If anything there is too much detail, wrong, or not desired in this document, feel free to remove as needed. :-) If an ICLA is needed for what I added, one is on its way. I've been meaning to send one anyway, but time keeps getting away from me!
Re: createmobilespecandroid-usingplugman.sh
I'll take care of it. https://issues.apache.org/jira/browse/CB-6616 On May 1, 2014, at 4:52 PM, Martin Gonzalez Glez wrote: > Createmobilespec.js can support it, Add an option to createmobilespec.js, > in order to accept the argument and use plugman install, instead of cordova > plugin add. > If the plugman argument is not present, regular workflow it can be followed. > On May 1, 2014 1:37 PM, "Anis KADRI" wrote: > >> I didn't know it even existed but I am using the plugman flow to test >> mobile-spec myself so an option would be helpful. >> >> >> On Thu, May 1, 2014 at 11:00 AM, Marcel Kinard wrote: >> >>> Is this script in cordova-mobile-spec still being used? (Andrew, history >>> says you added it.) If it is, I can fold it into createmobilespec.js via >> a >>> new option. If it isn't, I can delete it. Just looking to do a little >>> housecleaning, but didn't want to break anyone's workflow. Thanks! >>
[GitHub] cordova-plugman pull request: Fix plugin check error, when plugin ...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugman/pull/76 Fix plugin check error, when plugin dependency with specific version is given. Fix for this issue: https://issues.apache.org/jira/browse/CB-6615 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugman CB-6615 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugman/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 46a8c672f027e38e8ecfe081e8215ffbc549 Author: Vladimir Kotikov Date: 2014-05-02T09:50:49Z Fix plugin check error, when plugin dependency with specific version is given. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221118 --- Diff: src/ios/CDVFile.m --- @@ -313,11 +313,9 @@ - (void)pluginInitialize --- End diff -- Since you are doing the copy route and not sharing code with src/ios, these callbackId fixes should be in a separate issue against iOS, and should be in a separate pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221112 --- Diff: plugin.xml --- @@ -212,6 +212,27 @@ xmlns:android="http://schemas.android.com/apk/res/android"; + + + + + + + + + + + + + + + + --- End diff -- Not critical since it's just a label, but this really should be "osxFileSystem" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
