Re: [GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

[purplecabbage]

We don't need an cla for a 1 line documentation fix. 
Ultimately this is a defect in the plugin, and should be fixed. Documenting the 
quirk helps in the meantime, until it is fixed for Android and ios. 

> On Aug 1, 2014, at 2:22 PM, lorinbeer  wrote:
> 
> Github user lorinbeer commented on the pull request:
> 
>
> https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50936354
> 
>Hi @sgrebnov,
> 
>omitting contactFindOptions results in a errorJSON return message on 
> Android, and I believe was replicated on iOS. Documenting the actual behavior 
> of the plugin is essential, and this issue has caused considerable confusion 
> to using the contacts plugin.
> 
>Thanks for the pull request Sebastian, we'll pull it in as soon as your 
> CLA is recognized by the Apache Secretary. @sgrebnov and myself may have 
> suggestions in how to document the issue (which can be accomplished by adding 
> commits to the origin branch of the pull request) depending on whether it is 
> system wide, platform specific, deviation from spec, etc.
> 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

Re: remotely loaded pages

[purplecabbage]

It is great design for development, and netflix. 

Sent from my iPhone

> On Aug 1, 2014, at 4:26 PM, Marc Weiner  wrote:
> 
> It's technically possible, and even (arguably) legal according to Apple's
> documentation, depending on the nature of the code and how it's implemented:
> 
> 3.3.2 An Application may not download or install executable code.
> Interpreted code may only be used in an Application if all scripts, code
> and interpreters are packaged in the Application and not downloaded. The
> only exception to the foregoing is scripts and code downloaded and run by
> Apple's built-in WebKit framework, provided that such scripts and code do
> not change the primary purpose of the Application by providing features or
> functionality that are inconsistent with the intended and advertised
> purpose of the Application as submitted to the App Store.
> 
> However, I would only do so if the code is coming from a server that you
> control, and if you are able to control what code is getting executed.
> Loading in 3rd party, unverified scripts into your Cordova view is a big
> "no-no" for security reasons, and could get your app delisted (or rejected).
> 
> If anyone else has more information on the topic, I'd be interested in
> hearing it.
> 
> Marc
> 
> 
>> On Fri, Aug 1, 2014 at 7:01 PM, Victor Sosa  wrote:
>> 
>> Hi Frederico.
>> 
>> While what you are saying about the policies stores is true, this applies
>> to public stores only (as far as I can tell). For on-premise app stores
>> this might be false because each store owner need to set and apply the
>> governance for the apps. It could end on horrible results due to a bad
>> implementation.
>> 
>> I concur with everyone, it is possible but awful design
>> On Aug 1, 2014 4:35 PM, "Frederico Galvão" <
>> frederico.gal...@pontoget.com.br>
>> wrote:
>> 
>>> I don't have the details in hand at the moment, but I remember seeing in
>>> more than one application store last year policies being changed to
>>> disallow remote code to run in an application on-demand. Such rules
>> *could*
>>> as well be applied to Cordova apps that load remote content considered as
>>> code (HTML isn't, but JS is). It's not only a security concern per se,
>> but
>>> also an imposed limitation on the stores (which were obviously created
>> for
>>> security concerns in the first place).
>>> 
>>> Not even mentioning the issues with providing the right cordova.js
>> version
>>> from the remote server not really knowing where the request came from.
>>> However, it's good to note too that aside Phonegap Developer App, there
>> is
>>> also Adobe Hydration that does the exact same thing as a side service to
>>> Phonegap Build. I don't know if they've come into any of the issues
>>> mentioned, and I haven't even heard of it being used in production.
>>> 
>>> 
>>> 2014-08-01 17:36 GMT-03:00 purplecabbage :
>>> 
 I agree with all your statements Marcel. I use this approach frequently
>>> in
 dev for fast turnaround.
 Ultimately App Store policies decide what can and cannot be done.
 
 Regarding security, there is nothing I can do with a remote page that I
 can't already do inside my app. It's an issue of trust.
 
 
 Sent from my iPhone
 
> On Aug 1, 2014, at 10:35 AM, Shazron  wrote:
> 
> I agree that it is not recommended, but it's possible. I delved into
> this question here:
> https://github.com/shazron/phonegap-questions/issues/37
> 
> The PhoneGap Developer App is an example of how this is working at
> http://app.phonegap.com but they do some proxying to get around the
> CORS limitations I believe.
> 
>> On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard 
 wrote:
>> I've been getting occasional questions about users trying to use
 remotely-loaded (non-local) HTML pages with Cordova (in the webview,
>> not
 InAppBrowser), and still expecting to have access to the plugin APIs
 (camera is a popular one). My response so far is: "This is an
>> unsupported
 configuration, because Cordova was not designed for this and the
>>> community
 does no testing of this configuration. While it can work in some
 circumstances, it is not recommended nor supported."
>> 
>> My definition of "unsupported" is not that it is incapable, but that
>>> we
 don't claim that it is supposed to work, and more importantly, we won't
 actively fix user-submitted defects on this topic.
>> 
>> The main concern I have on this is same origin policy, and matching
>>> the
 remotely-served cordova.js with the locally-installed native Cordova
 platform to avoid version mismatch.
>> 
>> Do you think I'm out in-the-weeds on this, or do you agree?
>> 
>> If you agree, what would you think of a blurb in cordova-docs
>>> somewhere
 that captures this gist?
>> 
>> Thanks for your feedback!
>>> 
>>> 
>>> 
>>> --
>>> 
>>> *Frederico Galvão*
>>> 
>>> Diretor de Tecnologi

[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...

[joshbuchea]

Github user joshbuchea commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-50948393
  
What's the behavior of the issue this is supposed to fix?

I'm having issues with the plugin not honoring AutoHideSplashScreen in iOS 
7.1 & PhoneGap 3.5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Experimenting with JSCS + JSHint in cordova-lib

[Michal Mocny]

lgtm


On Fri, Aug 1, 2014 at 4:42 PM, Steven Gill  wrote:

> All three parts look good to me!
>
>
> On Fri, Aug 1, 2014 at 1:15 PM, Mark Koudritsky  wrote:
>
> > With and empty config file JSCS would emit no errors whatsoever. As more
> > options are added, the more of a style JSCS enforces. Let's try it this
> > way, I'll split the current config file into 3 sections and people
> comment
> > whether they think it should be enforced:
> >
> > ## Part 1, the whitespace basics I've rarely seen disagreement about
> > Option names are self explanatory.
> >
> > "disallowMixedSpacesAndTabs": true,
> > "disallowTrailingWhitespace": true,
> > "validateLineBreaks": "LF",
> > "validateIndentation": 4,
> > "requireLineFeedAtFileEnd": true,
> >
> > ## Part 2, not universal but very common conventions.
> >
> > "disallowSpaceAfterPrefixUnaryOperators": true,
> > "disallowSpaceBeforePostfixUnaryOperators": true,
> > "requireSpaceAfterLineComment": true,
> > "requireCapitalizedConstructors": true,
> > cordova-lib code currently violates the last one with lower case
> > constructors for hooker() (but that's being replaces in PR 55
> > ) and platfroms[].parser.
> >
> >
> > ## Part 3, somewhat arguable things but mostly adhered to by the existing
> > cordova-lib code
> > // function f(x) is ok but function f (x) is not:
> > "disallowSpacesInNamedFunctionExpression": {
> > "beforeOpeningRoundBrace": true
> > },
> > // if (x>0) is ok but if(x>0) is not./
> > "requireSpaceAfterKeywords": [
> >   "if",
> >   "else",
> >   "for",
> >   "while",
> >   "do"
> > ]
> >
> > We could potentially add way way more options and create a fully fledged
> > tight style, but that's definitely not my goal :)
> >
> >
> >
> > On Fri, Aug 1, 2014 at 2:56 PM, Steven Gill 
> > wrote:
> >
> > > I personally am a little hesitant to have to follow a certain coding
> > style
> > > + am worried about outside contributors struggling with it. On the
> other
> > > hand, it would be nice for code readability to have uniform/consistent
> > > style.
> > >
> > > As long as we discuss what styles we want to use beforehand, I am open
> to
> > > it.
> > >
> > >
> > > On Thu, Jul 31, 2014 at 7:34 PM, Mark Koudritsky 
> > > wrote:
> > >
> > > > Just opened a pull request with an experimental JSCS config. Would be
> > > glad
> > > > to get some feedback about this. My goal is to eventually run JSCS
> > > together
> > > > with JSHint as part of `npm test`. This is a relatively liberal
> config
> > > that
> > > > doesn't generate too many warnings with the existing code.
> > > >
> > > > https://github.com/apache/cordova-lib/pull/69
> > > >
> > > >
> > > > ## Some background
> > > >
> > > > JSHint people want to focus on syntax linting and are dropping style
> > > > oriented
> > > > options. They recommend using JSCS (in addition to JSHint) for style:
> > > > https://github.com/jshint/jshint/issues/1339
> > > >
> > > > Options dropped from JSHint were added to JSCS some time ago:
> > > > https://github.com/mdevils/node-jscs/issues/102
> > > >
> > > > I'm using it with SublimeLinter-jscs
> > > > https://sublime.wbond.net/packages/SublimeLinter-jscs
> > > >
> > >
> >
>

Re: Experimenting with JSCS + JSHint in cordova-lib

[Terence M. Bandoian]

Nicely done.  Seems reasonable, well-organized and easy to understand.

-Terence Bandoian


On 8/1/2014 3:15 PM, Mark Koudritsky wrote:

With and empty config file JSCS would emit no errors whatsoever. As more
options are added, the more of a style JSCS enforces. Let's try it this
way, I'll split the current config file into 3 sections and people comment
whether they think it should be enforced:

## Part 1, the whitespace basics I've rarely seen disagreement about
Option names are self explanatory.

 "disallowMixedSpacesAndTabs": true,
 "disallowTrailingWhitespace": true,
 "validateLineBreaks": "LF",
 "validateIndentation": 4,
 "requireLineFeedAtFileEnd": true,

## Part 2, not universal but very common conventions.

 "disallowSpaceAfterPrefixUnaryOperators": true,
 "disallowSpaceBeforePostfixUnaryOperators": true,
 "requireSpaceAfterLineComment": true,
 "requireCapitalizedConstructors": true,
cordova-lib code currently violates the last one with lower case
constructors for hooker() (but that's being replaces in PR 55
) and platfroms[].parser.


## Part 3, somewhat arguable things but mostly adhered to by the existing
cordova-lib code
 // function f(x) is ok but function f (x) is not:
 "disallowSpacesInNamedFunctionExpression": {
 "beforeOpeningRoundBrace": true
 },
 // if (x>0) is ok but if(x>0) is not./
 "requireSpaceAfterKeywords": [
   "if",
   "else",
   "for",
   "while",
   "do"
 ]

We could potentially add way way more options and create a fully fledged
tight style, but that's definitely not my goal :)



On Fri, Aug 1, 2014 at 2:56 PM, Steven Gill  wrote:


I personally am a little hesitant to have to follow a certain coding style
+ am worried about outside contributors struggling with it. On the other
hand, it would be nice for code readability to have uniform/consistent
style.

As long as we discuss what styles we want to use beforehand, I am open to
it.


On Thu, Jul 31, 2014 at 7:34 PM, Mark Koudritsky 
wrote:


Just opened a pull request with an experimental JSCS config. Would be

glad

to get some feedback about this. My goal is to eventually run JSCS

together

with JSHint as part of `npm test`. This is a relatively liberal config

that

doesn't generate too many warnings with the existing code.

https://github.com/apache/cordova-lib/pull/69


## Some background

JSHint people want to focus on syntax linting and are dropping style
oriented
options. They recommend using JSCS (in addition to JSHint) for style:
https://github.com/jshint/jshint/issues/1339

Options dropped from JSHint were added to JSCS some time ago:
https://github.com/mdevils/node-jscs/issues/102

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs

Re: remotely loaded pages

[Marc Weiner]

It's technically possible, and even (arguably) legal according to Apple's
documentation, depending on the nature of the code and how it's implemented:

3.3.2 An Application may not download or install executable code.
Interpreted code may only be used in an Application if all scripts, code
and interpreters are packaged in the Application and not downloaded. The
only exception to the foregoing is scripts and code downloaded and run by
Apple's built-in WebKit framework, provided that such scripts and code do
not change the primary purpose of the Application by providing features or
functionality that are inconsistent with the intended and advertised
purpose of the Application as submitted to the App Store.

However, I would only do so if the code is coming from a server that you
control, and if you are able to control what code is getting executed.
Loading in 3rd party, unverified scripts into your Cordova view is a big
"no-no" for security reasons, and could get your app delisted (or rejected).

If anyone else has more information on the topic, I'd be interested in
hearing it.

Marc


On Fri, Aug 1, 2014 at 7:01 PM, Victor Sosa  wrote:

> Hi Frederico.
>
> While what you are saying about the policies stores is true, this applies
> to public stores only (as far as I can tell). For on-premise app stores
> this might be false because each store owner need to set and apply the
> governance for the apps. It could end on horrible results due to a bad
> implementation.
>
> I concur with everyone, it is possible but awful design
> On Aug 1, 2014 4:35 PM, "Frederico Galvão" <
> frederico.gal...@pontoget.com.br>
> wrote:
>
> > I don't have the details in hand at the moment, but I remember seeing in
> > more than one application store last year policies being changed to
> > disallow remote code to run in an application on-demand. Such rules
> *could*
> > as well be applied to Cordova apps that load remote content considered as
> > code (HTML isn't, but JS is). It's not only a security concern per se,
> but
> > also an imposed limitation on the stores (which were obviously created
> for
> > security concerns in the first place).
> >
> > Not even mentioning the issues with providing the right cordova.js
> version
> > from the remote server not really knowing where the request came from.
> > However, it's good to note too that aside Phonegap Developer App, there
> is
> > also Adobe Hydration that does the exact same thing as a side service to
> > Phonegap Build. I don't know if they've come into any of the issues
> > mentioned, and I haven't even heard of it being used in production.
> >
> >
> > 2014-08-01 17:36 GMT-03:00 purplecabbage :
> >
> > > I agree with all your statements Marcel. I use this approach frequently
> > in
> > > dev for fast turnaround.
> > > Ultimately App Store policies decide what can and cannot be done.
> > >
> > > Regarding security, there is nothing I can do with a remote page that I
> > > can't already do inside my app. It's an issue of trust.
> > >
> > >
> > > Sent from my iPhone
> > >
> > > > On Aug 1, 2014, at 10:35 AM, Shazron  wrote:
> > > >
> > > > I agree that it is not recommended, but it's possible. I delved into
> > > > this question here:
> > > > https://github.com/shazron/phonegap-questions/issues/37
> > > >
> > > > The PhoneGap Developer App is an example of how this is working at
> > > > http://app.phonegap.com but they do some proxying to get around the
> > > > CORS limitations I believe.
> > > >
> > > >> On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard 
> > > wrote:
> > > >> I've been getting occasional questions about users trying to use
> > > remotely-loaded (non-local) HTML pages with Cordova (in the webview,
> not
> > > InAppBrowser), and still expecting to have access to the plugin APIs
> > > (camera is a popular one). My response so far is: "This is an
> unsupported
> > > configuration, because Cordova was not designed for this and the
> > community
> > > does no testing of this configuration. While it can work in some
> > > circumstances, it is not recommended nor supported."
> > > >>
> > > >> My definition of "unsupported" is not that it is incapable, but that
> > we
> > > don't claim that it is supposed to work, and more importantly, we won't
> > > actively fix user-submitted defects on this topic.
> > > >>
> > > >> The main concern I have on this is same origin policy, and matching
> > the
> > > remotely-served cordova.js with the locally-installed native Cordova
> > > platform to avoid version mismatch.
> > > >>
> > > >> Do you think I'm out in-the-weeds on this, or do you agree?
> > > >>
> > > >> If you agree, what would you think of a blurb in cordova-docs
> > somewhere
> > > that captures this gist?
> > > >>
> > > >> Thanks for your feedback!
> > >
> >
> >
> >
> > --
> >
> > *Frederico Galvão*
> >
> > Diretor de Tecnologia
> >
> > PontoGet Inovação Web
> >
> >
> > ( +55(62) 8131-5720
> >
> > * www.pontoget.com.br 
> >
>

Re: remotely loaded pages

[Victor Sosa]

Hi Frederico.

While what you are saying about the policies stores is true, this applies
to public stores only (as far as I can tell). For on-premise app stores
this might be false because each store owner need to set and apply the
governance for the apps. It could end on horrible results due to a bad
implementation.

I concur with everyone, it is possible but awful design
On Aug 1, 2014 4:35 PM, "Frederico Galvão" 
wrote:

> I don't have the details in hand at the moment, but I remember seeing in
> more than one application store last year policies being changed to
> disallow remote code to run in an application on-demand. Such rules *could*
> as well be applied to Cordova apps that load remote content considered as
> code (HTML isn't, but JS is). It's not only a security concern per se, but
> also an imposed limitation on the stores (which were obviously created for
> security concerns in the first place).
>
> Not even mentioning the issues with providing the right cordova.js version
> from the remote server not really knowing where the request came from.
> However, it's good to note too that aside Phonegap Developer App, there is
> also Adobe Hydration that does the exact same thing as a side service to
> Phonegap Build. I don't know if they've come into any of the issues
> mentioned, and I haven't even heard of it being used in production.
>
>
> 2014-08-01 17:36 GMT-03:00 purplecabbage :
>
> > I agree with all your statements Marcel. I use this approach frequently
> in
> > dev for fast turnaround.
> > Ultimately App Store policies decide what can and cannot be done.
> >
> > Regarding security, there is nothing I can do with a remote page that I
> > can't already do inside my app. It's an issue of trust.
> >
> >
> > Sent from my iPhone
> >
> > > On Aug 1, 2014, at 10:35 AM, Shazron  wrote:
> > >
> > > I agree that it is not recommended, but it's possible. I delved into
> > > this question here:
> > > https://github.com/shazron/phonegap-questions/issues/37
> > >
> > > The PhoneGap Developer App is an example of how this is working at
> > > http://app.phonegap.com but they do some proxying to get around the
> > > CORS limitations I believe.
> > >
> > >> On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard 
> > wrote:
> > >> I've been getting occasional questions about users trying to use
> > remotely-loaded (non-local) HTML pages with Cordova (in the webview, not
> > InAppBrowser), and still expecting to have access to the plugin APIs
> > (camera is a popular one). My response so far is: "This is an unsupported
> > configuration, because Cordova was not designed for this and the
> community
> > does no testing of this configuration. While it can work in some
> > circumstances, it is not recommended nor supported."
> > >>
> > >> My definition of "unsupported" is not that it is incapable, but that
> we
> > don't claim that it is supposed to work, and more importantly, we won't
> > actively fix user-submitted defects on this topic.
> > >>
> > >> The main concern I have on this is same origin policy, and matching
> the
> > remotely-served cordova.js with the locally-installed native Cordova
> > platform to avoid version mismatch.
> > >>
> > >> Do you think I'm out in-the-weeds on this, or do you agree?
> > >>
> > >> If you agree, what would you think of a blurb in cordova-docs
> somewhere
> > that captures this gist?
> > >>
> > >> Thanks for your feedback!
> >
>
>
>
> --
>
> *Frederico Galvão*
>
> Diretor de Tecnologia
>
> PontoGet Inovação Web
>
>
> ( +55(62) 8131-5720
>
> * www.pontoget.com.br 
>

Re: remotely loaded pages

[Shazron]

Adobe PhoneGap Build Hydration is different however -- it downloads an
app payload that is run locally (points to the new www folder
contents), and is only meant for dev purposes, not for App Store
release.

On Fri, Aug 1, 2014 at 2:34 PM, Frederico Galvão
 wrote:
> I don't have the details in hand at the moment, but I remember seeing in
> more than one application store last year policies being changed to
> disallow remote code to run in an application on-demand. Such rules *could*
> as well be applied to Cordova apps that load remote content considered as
> code (HTML isn't, but JS is). It's not only a security concern per se, but
> also an imposed limitation on the stores (which were obviously created for
> security concerns in the first place).
>
> Not even mentioning the issues with providing the right cordova.js version
> from the remote server not really knowing where the request came from.
> However, it's good to note too that aside Phonegap Developer App, there is
> also Adobe Hydration that does the exact same thing as a side service to
> Phonegap Build. I don't know if they've come into any of the issues
> mentioned, and I haven't even heard of it being used in production.
>
>
> 2014-08-01 17:36 GMT-03:00 purplecabbage :
>
>> I agree with all your statements Marcel. I use this approach frequently in
>> dev for fast turnaround.
>> Ultimately App Store policies decide what can and cannot be done.
>>
>> Regarding security, there is nothing I can do with a remote page that I
>> can't already do inside my app. It's an issue of trust.
>>
>>
>> Sent from my iPhone
>>
>> > On Aug 1, 2014, at 10:35 AM, Shazron  wrote:
>> >
>> > I agree that it is not recommended, but it's possible. I delved into
>> > this question here:
>> > https://github.com/shazron/phonegap-questions/issues/37
>> >
>> > The PhoneGap Developer App is an example of how this is working at
>> > http://app.phonegap.com but they do some proxying to get around the
>> > CORS limitations I believe.
>> >
>> >> On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard 
>> wrote:
>> >> I've been getting occasional questions about users trying to use
>> remotely-loaded (non-local) HTML pages with Cordova (in the webview, not
>> InAppBrowser), and still expecting to have access to the plugin APIs
>> (camera is a popular one). My response so far is: "This is an unsupported
>> configuration, because Cordova was not designed for this and the community
>> does no testing of this configuration. While it can work in some
>> circumstances, it is not recommended nor supported."
>> >>
>> >> My definition of "unsupported" is not that it is incapable, but that we
>> don't claim that it is supposed to work, and more importantly, we won't
>> actively fix user-submitted defects on this topic.
>> >>
>> >> The main concern I have on this is same origin policy, and matching the
>> remotely-served cordova.js with the locally-installed native Cordova
>> platform to avoid version mismatch.
>> >>
>> >> Do you think I'm out in-the-weeds on this, or do you agree?
>> >>
>> >> If you agree, what would you think of a blurb in cordova-docs somewhere
>> that captures this gist?
>> >>
>> >> Thanks for your feedback!
>>
>
>
>
> --
>
> *Frederico Galvão*
>
> Diretor de Tecnologia
>
> PontoGet Inovação Web
>
>
> ( +55(62) 8131-5720
>
> * www.pontoget.com.br 

Re: remotely loaded pages

[Frederico Galvão]

I don't have the details in hand at the moment, but I remember seeing in
more than one application store last year policies being changed to
disallow remote code to run in an application on-demand. Such rules *could*
as well be applied to Cordova apps that load remote content considered as
code (HTML isn't, but JS is). It's not only a security concern per se, but
also an imposed limitation on the stores (which were obviously created for
security concerns in the first place).

Not even mentioning the issues with providing the right cordova.js version
from the remote server not really knowing where the request came from.
However, it's good to note too that aside Phonegap Developer App, there is
also Adobe Hydration that does the exact same thing as a side service to
Phonegap Build. I don't know if they've come into any of the issues
mentioned, and I haven't even heard of it being used in production.


2014-08-01 17:36 GMT-03:00 purplecabbage :

> I agree with all your statements Marcel. I use this approach frequently in
> dev for fast turnaround.
> Ultimately App Store policies decide what can and cannot be done.
>
> Regarding security, there is nothing I can do with a remote page that I
> can't already do inside my app. It's an issue of trust.
>
>
> Sent from my iPhone
>
> > On Aug 1, 2014, at 10:35 AM, Shazron  wrote:
> >
> > I agree that it is not recommended, but it's possible. I delved into
> > this question here:
> > https://github.com/shazron/phonegap-questions/issues/37
> >
> > The PhoneGap Developer App is an example of how this is working at
> > http://app.phonegap.com but they do some proxying to get around the
> > CORS limitations I believe.
> >
> >> On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard 
> wrote:
> >> I've been getting occasional questions about users trying to use
> remotely-loaded (non-local) HTML pages with Cordova (in the webview, not
> InAppBrowser), and still expecting to have access to the plugin APIs
> (camera is a popular one). My response so far is: "This is an unsupported
> configuration, because Cordova was not designed for this and the community
> does no testing of this configuration. While it can work in some
> circumstances, it is not recommended nor supported."
> >>
> >> My definition of "unsupported" is not that it is incapable, but that we
> don't claim that it is supposed to work, and more importantly, we won't
> actively fix user-submitted defects on this topic.
> >>
> >> The main concern I have on this is same origin policy, and matching the
> remotely-served cordova.js with the locally-installed native Cordova
> platform to avoid version mismatch.
> >>
> >> Do you think I'm out in-the-weeds on this, or do you agree?
> >>
> >> If you agree, what would you think of a blurb in cordova-docs somewhere
> that captures this gist?
> >>
> >> Thanks for your feedback!
>



-- 

*Frederico Galvão*

Diretor de Tecnologia

PontoGet Inovação Web


( +55(62) 8131-5720

* www.pontoget.com.br 

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

[lorinbeer]

Github user lorinbeer commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50936354
  
Hi @sgrebnov,

omitting contactFindOptions results in a errorJSON return message on 
Android, and I believe was replicated on iOS. Documenting the actual behavior 
of the plugin is essential, and this issue has caused considerable confusion to 
using the contacts plugin.

Thanks for the pull request Sebastian, we'll pull it in as soon as your CLA 
is recognized by the Apache Secretary. @sgrebnov and myself may have 
suggestions in how to document the issue (which can be accomplished by adding 
commits to the origin branch of the pull request) depending on whether it is 
system wide, platform specific, deviation from spec, etc.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: git commit: CB-7249cordova-plugin-statusbar documentation translation: cordova-plugin-statusbar

[Marcel Kinard]

Lisa, assuming this is being run by your scripts, in the commit message could 
you add a space after the CB number? Thanks!

On Aug 1, 2014, at 4:24 PM, ldel...@apache.org wrote:

> Repository: cordova-plugin-statusbar
> Updated Branches:
>  refs/heads/master ad834b573 -> df64e5b15
> 
> 
> CB-7249cordova-plugin-statusbar documentation translation: 
> cordova-plugin-statusbar

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[nicola]

Github user nicola commented on the pull request:

https://github.com/apache/cordova-firefoxos/pull/20#issuecomment-50933496
  
Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Experimenting with JSCS + JSHint in cordova-lib

[Steven Gill]

All three parts look good to me!


On Fri, Aug 1, 2014 at 1:15 PM, Mark Koudritsky  wrote:

> With and empty config file JSCS would emit no errors whatsoever. As more
> options are added, the more of a style JSCS enforces. Let's try it this
> way, I'll split the current config file into 3 sections and people comment
> whether they think it should be enforced:
>
> ## Part 1, the whitespace basics I've rarely seen disagreement about
> Option names are self explanatory.
>
> "disallowMixedSpacesAndTabs": true,
> "disallowTrailingWhitespace": true,
> "validateLineBreaks": "LF",
> "validateIndentation": 4,
> "requireLineFeedAtFileEnd": true,
>
> ## Part 2, not universal but very common conventions.
>
> "disallowSpaceAfterPrefixUnaryOperators": true,
> "disallowSpaceBeforePostfixUnaryOperators": true,
> "requireSpaceAfterLineComment": true,
> "requireCapitalizedConstructors": true,
> cordova-lib code currently violates the last one with lower case
> constructors for hooker() (but that's being replaces in PR 55
> ) and platfroms[].parser.
>
>
> ## Part 3, somewhat arguable things but mostly adhered to by the existing
> cordova-lib code
> // function f(x) is ok but function f (x) is not:
> "disallowSpacesInNamedFunctionExpression": {
> "beforeOpeningRoundBrace": true
> },
> // if (x>0) is ok but if(x>0) is not./
> "requireSpaceAfterKeywords": [
>   "if",
>   "else",
>   "for",
>   "while",
>   "do"
> ]
>
> We could potentially add way way more options and create a fully fledged
> tight style, but that's definitely not my goal :)
>
>
>
> On Fri, Aug 1, 2014 at 2:56 PM, Steven Gill 
> wrote:
>
> > I personally am a little hesitant to have to follow a certain coding
> style
> > + am worried about outside contributors struggling with it. On the other
> > hand, it would be nice for code readability to have uniform/consistent
> > style.
> >
> > As long as we discuss what styles we want to use beforehand, I am open to
> > it.
> >
> >
> > On Thu, Jul 31, 2014 at 7:34 PM, Mark Koudritsky 
> > wrote:
> >
> > > Just opened a pull request with an experimental JSCS config. Would be
> > glad
> > > to get some feedback about this. My goal is to eventually run JSCS
> > together
> > > with JSHint as part of `npm test`. This is a relatively liberal config
> > that
> > > doesn't generate too many warnings with the existing code.
> > >
> > > https://github.com/apache/cordova-lib/pull/69
> > >
> > >
> > > ## Some background
> > >
> > > JSHint people want to focus on syntax linting and are dropping style
> > > oriented
> > > options. They recommend using JSCS (in addition to JSHint) for style:
> > > https://github.com/jshint/jshint/issues/1339
> > >
> > > Options dropped from JSHint were added to JSCS some time ago:
> > > https://github.com/mdevils/node-jscs/issues/102
> > >
> > > I'm using it with SublimeLinter-jscs
> > > https://sublime.wbond.net/packages/SublimeLinter-jscs
> > >
> >
>

Re: remotely loaded pages

[purplecabbage]

I agree with all your statements Marcel. I use this approach frequently in dev 
for fast turnaround. 
Ultimately App Store policies decide what can and cannot be done. 

Regarding security, there is nothing I can do with a remote page that I can't 
already do inside my app. It's an issue of trust. 


Sent from my iPhone

> On Aug 1, 2014, at 10:35 AM, Shazron  wrote:
> 
> I agree that it is not recommended, but it's possible. I delved into
> this question here:
> https://github.com/shazron/phonegap-questions/issues/37
> 
> The PhoneGap Developer App is an example of how this is working at
> http://app.phonegap.com but they do some proxying to get around the
> CORS limitations I believe.
> 
>> On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard  wrote:
>> I've been getting occasional questions about users trying to use 
>> remotely-loaded (non-local) HTML pages with Cordova (in the webview, not 
>> InAppBrowser), and still expecting to have access to the plugin APIs (camera 
>> is a popular one). My response so far is: "This is an unsupported 
>> configuration, because Cordova was not designed for this and the community 
>> does no testing of this configuration. While it can work in some 
>> circumstances, it is not recommended nor supported."
>> 
>> My definition of "unsupported" is not that it is incapable, but that we 
>> don't claim that it is supposed to work, and more importantly, we won't 
>> actively fix user-submitted defects on this topic.
>> 
>> The main concern I have on this is same origin policy, and matching the 
>> remotely-served cordova.js with the locally-installed native Cordova 
>> platform to avoid version mismatch.
>> 
>> Do you think I'm out in-the-weeds on this, or do you agree?
>> 
>> If you agree, what would you think of a blurb in cordova-docs somewhere that 
>> captures this gist?
>> 
>> Thanks for your feedback!

Re: plugin-test-framework PRs

[purplecabbage]

Staci, why not just one pull request for all these changes?

Sent from my iPhone

> On Aug 1, 2014, at 10:19 AM, Staci Cooper  wrote:
> 
> I've noticed some problems I'd like to bring up.
> 
> 1)
> https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44
> This line breaks on windows phone when the query property is used.
> 
> 2) My pull requests include the manual tests for contacts, device-motion,
> and geolocation on top of existing automated tests, which I did not change.
> I just tested those automated tests and they are breaking on WP; there are
> 2 tests failing in geolocation which shouldn't and 3 in contacts.
> Device-motion is more severe and is breaking the entire test suite on WP. I
> can start looking into those.
> 
> 3) I'm not sure how to make the PRs to mobile-spec for removing tests
> without requiring them to be merged in a specific order or causing merge
> conflicts around pages like index.html. My suggestion is that we make a PR
> for each plugin which removes the test files but leaves the buttons/script
> elements in to avoid merge conflicts, and just add a warning to mobile-spec
> that some links will be broken while we go through the porting process.
> Then when everything is done we can remove the links in a final PR.
> 
> -Staci
> 
> 
> 
> On Fri, Aug 1, 2014 at 3:55 AM, Martin Gonzalez <
> martin.c.glez.g...@gmail.com> wrote:
> 
>> Hey Michal,
>> I've followed up your instructions to easily integrate the test along with
>> plugin-test-framework, as you can see I have spammed a little bit the dev
>> list with PRs, anyway here's the list of PRs, that includes File, Media,
>> Battery-Status and Vibration:
>> https://github.com/apache/cordova-plugin-file/pull/62
>> https://github.com/apache/cordova-plugin-media/pull/21
>> https://github.com/apache/cordova-plugin-battery-status/pull/15
>> https://github.com/apache/cordova-plugin-vibration/pull/19
>> 
>> And the removed tests at mobile-spec:
>> File: https://github.com/apache/cordova-mobile-spec/pull/86
>> Media: https://github.com/apache/cordova-mobile-spec/pull/85
>> Battery: https://github.com/apache/cordova-mobile-spec/pull/87
>> Vibration: https://github.com/apache/cordova-mobile-spec/pull/88
>> 
>> Also a few days ago, I created a PR against plugin-test-framework, just
>> some little changes to the css, all details on the description:
>> https://github.com/apache/cordova-plugin-test-framework/pull/3
>> 
>> Everything tested with createmobilespec, and android device.
>> 
>> If you can take a look to any of this, it would be awesome.
>> 
>> Thanks,
>> Best Regards,
>> Martin
>> 
>> 2014-07-30 10:44 GMT-05:00 Staci Cooper :
>> 
>>> Sounds good, I'll get started.
>>> 
>>> 
>>> On Wed, Jul 30, 2014 at 11:33 AM, Michal Mocny 
>>> wrote:
>>> 
 Things to help move this along:
 
 - Move test directories to "tests" and add nested plugin.xml, that
>> would
>>> be
 a great.  You can look at an example here:
 https://github.com/apache/cordova-plugin-device/tree/master/tests
 - Test the PR locally by running the mobilespec create script to make
>>> sure
 the plugin tests install fine and run well.  (The part that adds
>>> new-style
 tests is here:
>> https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L248
 )
 - Double check to make sure we have covered all tests currently in
 mobilespec, and submit PR to remove the old tests from mobilespec app.
>> I
 would not like to land the new tests without removing the old tests as
 well.
 
 Thanks a bunch!
 
 
 
 
 
 On Wed, Jul 30, 2014 at 11:25 AM, Staci Cooper 
 wrote:
 
> Just want to bump this thread.
> 
> Michal -- that all sounds great. Let me know if there's anything I
>> can
>>> do
> to help with integration, or if the IBM committers can help with
>>> merging.
> Should we go ahead and add nested plugin.xml files to the PRs?
> 
> Also, for reference: I tested all of my PRs on wp8 with a comparison
>>> with
> mobile-spec's behavior, as did Martin with his. Edna and Martin have
>>> also
> been testing on ios and android respectively.
> 
> 
>> On Tue, Jul 22, 2014 at 9:52 AM, Michal Mocny 
> wrote:
> 
>> Just a quick update since its been a few days.
>> 
>> - Mobile-spec now builds with new-style tests bundled in (there is
>> a
> button
>> to launch this on the first screen), and the createmobilespec.sh
>>> script
>> will automatically install plugin tests.
>> - Last week I moved device tests from mobile-spec over to plugin
>>> tests,
> and
>> modified the file plugin tests to use a nested plugin.xml.
>> - File and FileTransfer tests are tightly coupled in mobile-spec,
>> and
>> should be removed together.  I have this mostly finished locally,
>>> but..
>> - I want to set up ci.cordova.io to include results of new-style
>>> tests
>> before 

Re: Experimenting with JSCS + JSHint in cordova-lib

[Mark Koudritsky]

With and empty config file JSCS would emit no errors whatsoever. As more
options are added, the more of a style JSCS enforces. Let's try it this
way, I'll split the current config file into 3 sections and people comment
whether they think it should be enforced:

## Part 1, the whitespace basics I've rarely seen disagreement about
Option names are self explanatory.

"disallowMixedSpacesAndTabs": true,
"disallowTrailingWhitespace": true,
"validateLineBreaks": "LF",
"validateIndentation": 4,
"requireLineFeedAtFileEnd": true,

## Part 2, not universal but very common conventions.

"disallowSpaceAfterPrefixUnaryOperators": true,
"disallowSpaceBeforePostfixUnaryOperators": true,
"requireSpaceAfterLineComment": true,
"requireCapitalizedConstructors": true,
cordova-lib code currently violates the last one with lower case
constructors for hooker() (but that's being replaces in PR 55
) and platfroms[].parser.


## Part 3, somewhat arguable things but mostly adhered to by the existing
cordova-lib code
// function f(x) is ok but function f (x) is not:
"disallowSpacesInNamedFunctionExpression": {
"beforeOpeningRoundBrace": true
},
// if (x>0) is ok but if(x>0) is not./
"requireSpaceAfterKeywords": [
  "if",
  "else",
  "for",
  "while",
  "do"
]

We could potentially add way way more options and create a fully fledged
tight style, but that's definitely not my goal :)



On Fri, Aug 1, 2014 at 2:56 PM, Steven Gill  wrote:

> I personally am a little hesitant to have to follow a certain coding style
> + am worried about outside contributors struggling with it. On the other
> hand, it would be nice for code readability to have uniform/consistent
> style.
>
> As long as we discuss what styles we want to use beforehand, I am open to
> it.
>
>
> On Thu, Jul 31, 2014 at 7:34 PM, Mark Koudritsky 
> wrote:
>
> > Just opened a pull request with an experimental JSCS config. Would be
> glad
> > to get some feedback about this. My goal is to eventually run JSCS
> together
> > with JSHint as part of `npm test`. This is a relatively liberal config
> that
> > doesn't generate too many warnings with the existing code.
> >
> > https://github.com/apache/cordova-lib/pull/69
> >
> >
> > ## Some background
> >
> > JSHint people want to focus on syntax linting and are dropping style
> > oriented
> > options. They recommend using JSCS (in addition to JSHint) for style:
> > https://github.com/jshint/jshint/issues/1339
> >
> > Options dropped from JSHint were added to JSCS some time ago:
> > https://github.com/mdevils/node-jscs/issues/102
> >
> > I'm using it with SublimeLinter-jscs
> > https://sublime.wbond.net/packages/SublimeLinter-jscs
> >
>

Re: [DISCUSS] Plugins Release

[Shazron]

Oops yeah it's actually called .ratExcludes :P

On Fri, Aug 1, 2014 at 11:16 AM, Bryan Higgins  wrote:
> Thanks Shaz! I couldn't find any other use of .ratignore in Cordova and
> coho isn't configured to look for one.
>
> Adding a ratExcludes section for plugin-globalization to
> cordova-coho/src/repoutil.js did the trick.
>
>
> On Fri, Aug 1, 2014 at 1:31 PM, Shazron  wrote:
>
>> You can add a .ratignore file, and add the note about the libs being
>> approved by Apache legal.
>>
>> On Fri, Aug 1, 2014 at 6:41 AM, Bryan Higgins 
>> wrote:
>> > Thanks Steve.
>> >
>> > I've done this, but RAT doesn't recognize zlib/libpng even though it has
>> > been approved by Apache legal.
>> >
>> > http://www.apache.org/legal/resolved.html
>> >
>> >
>> > On Thu, Jul 31, 2014 at 7:18 PM, Steven Gill 
>> wrote:
>> >
>> >> So Globalization has issues with missing headers and needs a update to
>> the
>> >> notice file for new licenses. Both Blackberry and FFOS need to go do
>> this
>> >> before I release that plugin!
>> >>
>> >> What am I doing with test-harness? That isn't being released right? It
>> also
>> >> needs headers included + notice file updates.
>> >>
>> >>
>> >> On Thu, Jul 31, 2014 at 7:18 AM, Bryan Higgins 
>> >> wrote:
>> >>
>> >> > I'm into it! BlackBerry now supports File plugin roots and
>> Globalization
>> >> :)
>> >> >
>> >> >
>> >> > On Tue, Jul 29, 2014 at 3:29 PM, Steven Gill 
>> >> > wrote:
>> >> >
>> >> > > How do you all feel about a plugins release?
>> >> > >
>> >> > > I can aim to start a vote thread tomorrow or Thursday if people feel
>> >> good
>> >> > > about it.
>> >> > >
>> >> > > -Steve
>> >> > >
>> >> >
>> >>
>>

Re: Experimenting with JSCS + JSHint in cordova-lib

[Steven Gill]

I personally am a little hesitant to have to follow a certain coding style
+ am worried about outside contributors struggling with it. On the other
hand, it would be nice for code readability to have uniform/consistent
style.

As long as we discuss what styles we want to use beforehand, I am open to
it.


On Thu, Jul 31, 2014 at 7:34 PM, Mark Koudritsky  wrote:

> Just opened a pull request with an experimental JSCS config. Would be glad
> to get some feedback about this. My goal is to eventually run JSCS together
> with JSHint as part of `npm test`. This is a relatively liberal config that
> doesn't generate too many warnings with the existing code.
>
> https://github.com/apache/cordova-lib/pull/69
>
>
> ## Some background
>
> JSHint people want to focus on syntax linting and are dropping style
> oriented
> options. They recommend using JSCS (in addition to JSHint) for style:
> https://github.com/jshint/jshint/issues/1339
>
> Options dropped from JSHint were added to JSCS some time ago:
> https://github.com/mdevils/node-jscs/issues/102
>
> I'm using it with SublimeLinter-jscs
> https://sublime.wbond.net/packages/SublimeLinter-jscs
>

Re: [DISCUSS] Plugins Release

[Bryan Higgins]

Thanks Shaz! I couldn't find any other use of .ratignore in Cordova and
coho isn't configured to look for one.

Adding a ratExcludes section for plugin-globalization to
cordova-coho/src/repoutil.js did the trick.


On Fri, Aug 1, 2014 at 1:31 PM, Shazron  wrote:

> You can add a .ratignore file, and add the note about the libs being
> approved by Apache legal.
>
> On Fri, Aug 1, 2014 at 6:41 AM, Bryan Higgins 
> wrote:
> > Thanks Steve.
> >
> > I've done this, but RAT doesn't recognize zlib/libpng even though it has
> > been approved by Apache legal.
> >
> > http://www.apache.org/legal/resolved.html
> >
> >
> > On Thu, Jul 31, 2014 at 7:18 PM, Steven Gill 
> wrote:
> >
> >> So Globalization has issues with missing headers and needs a update to
> the
> >> notice file for new licenses. Both Blackberry and FFOS need to go do
> this
> >> before I release that plugin!
> >>
> >> What am I doing with test-harness? That isn't being released right? It
> also
> >> needs headers included + notice file updates.
> >>
> >>
> >> On Thu, Jul 31, 2014 at 7:18 AM, Bryan Higgins 
> >> wrote:
> >>
> >> > I'm into it! BlackBerry now supports File plugin roots and
> Globalization
> >> :)
> >> >
> >> >
> >> > On Tue, Jul 29, 2014 at 3:29 PM, Steven Gill 
> >> > wrote:
> >> >
> >> > > How do you all feel about a plugins release?
> >> > >
> >> > > I can aim to start a vote thread tomorrow or Thursday if people feel
> >> good
> >> > > about it.
> >> > >
> >> > > -Steve
> >> > >
> >> >
> >>
>

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[nicola]

Github user nicola commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/20#discussion_r15710411
  
--- Diff: bin/lib/b2g.js ---
@@ -0,0 +1,74 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+varexec = require('shelljs').exec,
+args  = process.argv,
+os = process.platform,
+B2G_BIN_OSX = 'b2g/B2G.app/Contents/MacOS/b2g-bin',
+   FX_PROFILES_OSX = 'Library/Application Support/Firefox/Profiles/',
+   B2G_BIN_LINUX = 'b2g/b2g-bin',
+   FX_PROFILES_LINUX = '.mozilla/firefox/',
+   NETSTAT_CMD = 'netstat -lnptu',
+   LSOF_CMD = 'lsof -i -n -P -sTCP:LISTEN';
+
+exports.discoverPorts = function (callback) {
+   
+   var ports = [];
+ 
+   if (os == 'darwin') {
+   var output = exec(LSOF_CMD, {silent: true}).output;
+   var regex = 
/^b2g[-bin]?.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]*)/;
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
+   var matches = regex.exec(lines[line]);
+   
+   if (matches && +matches[1] != 2828)
+   ports.push(+matches[1])
+   }
+ 
+   } else
+   if (os == 'linux') {
+   var output = exec(NETSTAT_CMD, {silent: true}).output;
+   var regex = 
/tcp.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]+).*LISTEN.*\/b2g[-bin]?/
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
--- End diff --

Thanks for your comments, going back to you in a sec


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: CB-7133 port inappbrowse...

[stacic]

GitHub user stacic opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/55

CB-7133 port inappbrowser to plugin-test-framework



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stacic/cordova-plugin-inappbrowser CB-7133

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit cb8534ca565d8a6c6de914d27e663d2e4da8dbe0
Author: Staci Cooper 
Date:   2014-07-14T19:21:41Z

CB-7133 port inappbrowser to plugin-test-framework

commit a719509c00c8122971629a22c4378862f4a7125d
Author: Staci Cooper 
Date:   2014-07-15T17:42:22Z

CB-7133 added resources and fixed file paths

commit b12bb7d1385a35d9d628cb087a91a328ddc15bbf
Author: Staci Cooper 
Date:   2014-07-21T19:56:00Z

CB-7133 Changed to relative basePath

commit d4187d96a36b066c14f370ab0383ce6a70e4efcc
Author: Staci Cooper 
Date:   2014-08-01T18:10:35Z

CB-7133 Changed how resources are being added




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/20#discussion_r15710033
  
--- Diff: bin/lib/b2g.js ---
@@ -0,0 +1,74 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+varexec = require('shelljs').exec,
+args  = process.argv,
+os = process.platform,
+B2G_BIN_OSX = 'b2g/B2G.app/Contents/MacOS/b2g-bin',
+   FX_PROFILES_OSX = 'Library/Application Support/Firefox/Profiles/',
+   B2G_BIN_LINUX = 'b2g/b2g-bin',
+   FX_PROFILES_LINUX = '.mozilla/firefox/',
+   NETSTAT_CMD = 'netstat -lnptu',
+   LSOF_CMD = 'lsof -i -n -P -sTCP:LISTEN';
+
+exports.discoverPorts = function (callback) {
+   
+   var ports = [];
+ 
+   if (os == 'darwin') {
+   var output = exec(LSOF_CMD, {silent: true}).output;
+   var regex = 
/^b2g[-bin]?.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]*)/;
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
+   var matches = regex.exec(lines[line]);
+   
+   if (matches && +matches[1] != 2828)
+   ports.push(+matches[1])
+   }
+ 
+   } else
+   if (os == 'linux') {
+   var output = exec(NETSTAT_CMD, {silent: true}).output;
+   var regex = 
/tcp.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]+).*LISTEN.*\/b2g[-bin]?/
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
--- End diff --

personally, I'd favor lines.forEach(function(line) {...});


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/20#discussion_r1570
  
--- Diff: bin/lib/b2g.js ---
@@ -0,0 +1,74 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+varexec = require('shelljs').exec,
+args  = process.argv,
+os = process.platform,
+B2G_BIN_OSX = 'b2g/B2G.app/Contents/MacOS/b2g-bin',
+   FX_PROFILES_OSX = 'Library/Application Support/Firefox/Profiles/',
+   B2G_BIN_LINUX = 'b2g/b2g-bin',
+   FX_PROFILES_LINUX = '.mozilla/firefox/',
+   NETSTAT_CMD = 'netstat -lnptu',
+   LSOF_CMD = 'lsof -i -n -P -sTCP:LISTEN';
+
+exports.discoverPorts = function (callback) {
+   
+   var ports = [];
+ 
+   if (os == 'darwin') {
+   var output = exec(LSOF_CMD, {silent: true}).output;
+   var regex = 
/^b2g[-bin]?.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]*)/;
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
+   var matches = regex.exec(lines[line]);
+   
+   if (matches && +matches[1] != 2828)
+   ports.push(+matches[1])
+   }
+ 
+   } else
+   if (os == 'linux') {
+   var output = exec(NETSTAT_CMD, {silent: true}).output;
+   var regex = 
/tcp.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]+).*LISTEN.*\/b2g[-bin]?/
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
+   var matches = regex.exec(lines[line]);
+   
+   if (matches && +matches[1] != 2828)
+   ports.push(+matches[1])
+   }
+ 
+   } else {
+   return callback(new Error("OS not supported for running"))
+   }
+ 
+   callback(null, ports)
+ 
+}
+
+if (require.main === module) {
+(function() {
+exports.discoverPorts(function(err, ports){
+   if (err) return console.log(err)
+   console.log("Running FirefoxOS simulators (B2G) on ports", 
ports)
+});
+})();
+}
--- End diff --

do include a newline at EOF


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/20#discussion_r15709986
  
--- Diff: bin/lib/b2g.js ---
@@ -0,0 +1,74 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+varexec = require('shelljs').exec,
+args  = process.argv,
+os = process.platform,
+B2G_BIN_OSX = 'b2g/B2G.app/Contents/MacOS/b2g-bin',
+   FX_PROFILES_OSX = 'Library/Application Support/Firefox/Profiles/',
+   B2G_BIN_LINUX = 'b2g/b2g-bin',
+   FX_PROFILES_LINUX = '.mozilla/firefox/',
+   NETSTAT_CMD = 'netstat -lnptu',
+   LSOF_CMD = 'lsof -i -n -P -sTCP:LISTEN';
+
+exports.discoverPorts = function (callback) {
+   
+   var ports = [];
+ 
+   if (os == 'darwin') {
+   var output = exec(LSOF_CMD, {silent: true}).output;
+   var regex = 
/^b2g[-bin]?.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]*)/;
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
+   var matches = regex.exec(lines[line]);
+   
+   if (matches && +matches[1] != 2828)
+   ports.push(+matches[1])
+   }
+ 
+   } else
+   if (os == 'linux') {
+   var output = exec(NETSTAT_CMD, {silent: true}).output;
+   var regex = 
/tcp.*[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:([0-9]+).*LISTEN.*\/b2g[-bin]?/
+   var lines = output.split('\n');
+   for (var line=0; line < lines.length; line++) {
+   var matches = regex.exec(lines[line]);
+   
+   if (matches && +matches[1] != 2828)
+   ports.push(+matches[1])
+   }
+ 
+   } else {
+   return callback(new Error("OS not supported for running"))
+   }
+ 
+   callback(null, ports)
+ 
+}
+
+if (require.main === module) {
+(function() {
+exports.discoverPorts(function(err, ports){
+   if (err) return console.log(err)
--- End diff --

don't use tabs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[nicola]

Github user nicola commented on the pull request:

https://github.com/apache/cordova-firefoxos/pull/20#issuecomment-50915757
  
Sorry for the redundancy in code. I could compress that all, but I was 
expecting two different behaviors on two different machines. Keep me posted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-firefoxos pull request: Discover b2g ports

[nicola]

GitHub user nicola opened a pull request:

https://github.com/apache/cordova-firefoxos/pull/20

Discover b2g ports

This should be an helper library that should contain functions to find the 
port of an existing b2g simulator (Firefox OS simulator) and eventually 
functions to start a new simulator listening on a specific port, so that 
`cordova run` and `cordova emulate` can finally work.

The idea is about running `cordova emulate`
- you first scan listening ports to find existing b2g, connect in case they 
are found, or a specific port or version is specified (implemented for OS X and 
Linux)
- if no ports is found you then start a new simulator (coming soon)

The way I scan ports is straight forward, lsof or netstat in localhost and 
I find b2g processes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nicola/cordova-firefoxos b2g-ports

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-firefoxos/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 3225d64a25ff301dc5b1eef82228eb1e7a15fe86
Author: nicolagreco 
Date:   2014-08-01T17:55:15Z

discover b2g ports




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: remotely loaded pages

[Shazron]

I agree that it is not recommended, but it's possible. I delved into
this question here:
https://github.com/shazron/phonegap-questions/issues/37

The PhoneGap Developer App is an example of how this is working at
http://app.phonegap.com but they do some proxying to get around the
CORS limitations I believe.

On Fri, Aug 1, 2014 at 10:23 AM, Marcel Kinard  wrote:
> I've been getting occasional questions about users trying to use 
> remotely-loaded (non-local) HTML pages with Cordova (in the webview, not 
> InAppBrowser), and still expecting to have access to the plugin APIs (camera 
> is a popular one). My response so far is: "This is an unsupported 
> configuration, because Cordova was not designed for this and the community 
> does no testing of this configuration. While it can work in some 
> circumstances, it is not recommended nor supported."
>
> My definition of "unsupported" is not that it is incapable, but that we don't 
> claim that it is supposed to work, and more importantly, we won't actively 
> fix user-submitted defects on this topic.
>
> The main concern I have on this is same origin policy, and matching the 
> remotely-served cordova.js with the locally-installed native Cordova platform 
> to avoid version mismatch.
>
> Do you think I'm out in-the-weeds on this, or do you agree?
>
> If you agree, what would you think of a blurb in cordova-docs somewhere that 
> captures this gist?
>
> Thanks for your feedback!

Re: plugin-test-framework PRs

[Michal Mocny]

On Fri, Aug 1, 2014 at 1:19 PM, Staci Cooper  wrote:

> I've noticed some problems I'd like to bring up.
>
> 1)
>
> https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44
> This line breaks on windows phone when the query property is used.
>

1. was a recent change.  I'm happy to revert / would love a fix if you have
easy access to test on windows phone.


>
> 2) My pull requests include the manual tests for contacts, device-motion,
> and geolocation on top of existing automated tests, which I did not change.
> I just tested those automated tests and they are breaking on WP; there are
> 2 tests failing in geolocation which shouldn't and 3 in contacts.
> Device-motion is more severe and is breaking the entire test suite on WP. I
> can start looking into those.
>

Thank you for bringing that up.  Jesse has been awesome at helping test
this stuff on windows so far, perhaps I'll ask him (and bryan/josh for BB)
to confirm before landing these PR's.


>
> 3) I'm not sure how to make the PRs to mobile-spec for removing tests
> without requiring them to be merged in a specific order or causing merge
> conflicts around pages like index.html. My suggestion is that we make a PR
> for each plugin which removes the test files but leaves the buttons/script
> elements in to avoid merge conflicts, and just add a warning to mobile-spec
> that some links will be broken while we go through the porting process.
> Then when everything is done we can remove the links in a final PR.
>

I've run into these issues before.  I usually resolve the merge conflict
locally in the merge commit.  Usually they aren't hard.  If the conflicts
are actually hairy, I'm happy to remove the finally bits in bulk as you
suggest.


>
> -Staci
>

Thanks for all the effort here!


>
>
>
> On Fri, Aug 1, 2014 at 3:55 AM, Martin Gonzalez <
> martin.c.glez.g...@gmail.com> wrote:
>
> > Hey Michal,
> > I've followed up your instructions to easily integrate the test along
> with
> > plugin-test-framework, as you can see I have spammed a little bit the dev
> > list with PRs, anyway here's the list of PRs, that includes File, Media,
> > Battery-Status and Vibration:
> > https://github.com/apache/cordova-plugin-file/pull/62
> > https://github.com/apache/cordova-plugin-media/pull/21
> > https://github.com/apache/cordova-plugin-battery-status/pull/15
> > https://github.com/apache/cordova-plugin-vibration/pull/19
> >
> > And the removed tests at mobile-spec:
> > File: https://github.com/apache/cordova-mobile-spec/pull/86
> > Media: https://github.com/apache/cordova-mobile-spec/pull/85
> > Battery: https://github.com/apache/cordova-mobile-spec/pull/87
> > Vibration: https://github.com/apache/cordova-mobile-spec/pull/88
> >
> > Also a few days ago, I created a PR against plugin-test-framework, just
> > some little changes to the css, all details on the description:
> > https://github.com/apache/cordova-plugin-test-framework/pull/3
> >
> > Everything tested with createmobilespec, and android device.
> >
> > If you can take a look to any of this, it would be awesome.
> >
> > Thanks,
> > Best Regards,
> > Martin
> >
> > 2014-07-30 10:44 GMT-05:00 Staci Cooper :
> >
> > > Sounds good, I'll get started.
> > >
> > >
> > > On Wed, Jul 30, 2014 at 11:33 AM, Michal Mocny 
> > > wrote:
> > >
> > > > Things to help move this along:
> > > >
> > > > - Move test directories to "tests" and add nested plugin.xml, that
> > would
> > > be
> > > > a great.  You can look at an example here:
> > > > https://github.com/apache/cordova-plugin-device/tree/master/tests
> > > > - Test the PR locally by running the mobilespec create script to make
> > > sure
> > > > the plugin tests install fine and run well.  (The part that adds
> > > new-style
> > > > tests is here:
> > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L248
> > > > )
> > > > - Double check to make sure we have covered all tests currently in
> > > > mobilespec, and submit PR to remove the old tests from mobilespec
> app.
> >  I
> > > > would not like to land the new tests without removing the old tests
> as
> > > > well.
> > > >
> > > > Thanks a bunch!
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Wed, Jul 30, 2014 at 11:25 AM, Staci Cooper 
> > > > wrote:
> > > >
> > > > > Just want to bump this thread.
> > > > >
> > > > > Michal -- that all sounds great. Let me know if there's anything I
> > can
> > > do
> > > > > to help with integration, or if the IBM committers can help with
> > > merging.
> > > > > Should we go ahead and add nested plugin.xml files to the PRs?
> > > > >
> > > > > Also, for reference: I tested all of my PRs on wp8 with a
> comparison
> > > with
> > > > > mobile-spec's behavior, as did Martin with his. Edna and Martin
> have
> > > also
> > > > > been testing on ios and android respectively.
> > > > >
> > > > >
> > > > > On Tue, Jul 22, 2014 at 9:52 AM, Michal Mocny  >
> > > > wrote:
> > > > >
> > > > > > Just 

Re: remotely loaded pages

[Victor Sosa]

Hello Marcel.

Interesting scenario here. I'm not an expert on this topic, but loading
remote web artifacts that have native access looks very insecure to me.
Whether it is possible? Yeah, maybe... But is it advisable and, more
important, recommended by the Cordova experts community? I'd like to say no
just for the sake of security.

Of course, I might be just talking crazy here and would like to know what
the community thinks about it.



2014-08-01 12:23 GMT-05:00 Marcel Kinard :

> I've been getting occasional questions about users trying to use
> remotely-loaded (non-local) HTML pages with Cordova (in the webview, not
> InAppBrowser), and still expecting to have access to the plugin APIs
> (camera is a popular one). My response so far is: "This is an unsupported
> configuration, because Cordova was not designed for this and the community
> does no testing of this configuration. While it can work in some
> circumstances, it is not recommended nor supported."
>
> My definition of "unsupported" is not that it is incapable, but that we
> don't claim that it is supposed to work, and more importantly, we won't
> actively fix user-submitted defects on this topic.
>
> The main concern I have on this is same origin policy, and matching the
> remotely-served cordova.js with the locally-installed native Cordova
> platform to avoid version mismatch.
>
> Do you think I'm out in-the-weeds on this, or do you agree?
>
> If you agree, what would you think of a blurb in cordova-docs somewhere
> that captures this gist?
>
> Thanks for your feedback!




-- 
Victor Adrian Sosa Herrera
IBM Software Engineer
Guadalajara, Jalisco

Re: [DISCUSS] Plugins Release

[Shazron]

You can add a .ratignore file, and add the note about the libs being
approved by Apache legal.

On Fri, Aug 1, 2014 at 6:41 AM, Bryan Higgins  wrote:
> Thanks Steve.
>
> I've done this, but RAT doesn't recognize zlib/libpng even though it has
> been approved by Apache legal.
>
> http://www.apache.org/legal/resolved.html
>
>
> On Thu, Jul 31, 2014 at 7:18 PM, Steven Gill  wrote:
>
>> So Globalization has issues with missing headers and needs a update to the
>> notice file for new licenses. Both Blackberry and FFOS need to go do this
>> before I release that plugin!
>>
>> What am I doing with test-harness? That isn't being released right? It also
>> needs headers included + notice file updates.
>>
>>
>> On Thu, Jul 31, 2014 at 7:18 AM, Bryan Higgins 
>> wrote:
>>
>> > I'm into it! BlackBerry now supports File plugin roots and Globalization
>> :)
>> >
>> >
>> > On Tue, Jul 29, 2014 at 3:29 PM, Steven Gill 
>> > wrote:
>> >
>> > > How do you all feel about a plugins release?
>> > >
>> > > I can aim to start a vote thread tomorrow or Thursday if people feel
>> good
>> > > about it.
>> > >
>> > > -Steve
>> > >
>> >
>>

remotely loaded pages

[Marcel Kinard]

I've been getting occasional questions about users trying to use 
remotely-loaded (non-local) HTML pages with Cordova (in the webview, not 
InAppBrowser), and still expecting to have access to the plugin APIs (camera is 
a popular one). My response so far is: "This is an unsupported configuration, 
because Cordova was not designed for this and the community does no testing of 
this configuration. While it can work in some circumstances, it is not 
recommended nor supported."

My definition of "unsupported" is not that it is incapable, but that we don't 
claim that it is supposed to work, and more importantly, we won't actively fix 
user-submitted defects on this topic.

The main concern I have on this is same origin policy, and matching the 
remotely-served cordova.js with the locally-installed native Cordova platform 
to avoid version mismatch.

Do you think I'm out in-the-weeds on this, or do you agree?

If you agree, what would you think of a blurb in cordova-docs somewhere that 
captures this gist?

Thanks for your feedback!

Re: plugin-test-framework PRs

[Staci Cooper]

I've noticed some problems I'd like to bring up.

1)
https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44
This line breaks on windows phone when the query property is used.

2) My pull requests include the manual tests for contacts, device-motion,
and geolocation on top of existing automated tests, which I did not change.
I just tested those automated tests and they are breaking on WP; there are
2 tests failing in geolocation which shouldn't and 3 in contacts.
Device-motion is more severe and is breaking the entire test suite on WP. I
can start looking into those.

3) I'm not sure how to make the PRs to mobile-spec for removing tests
without requiring them to be merged in a specific order or causing merge
conflicts around pages like index.html. My suggestion is that we make a PR
for each plugin which removes the test files but leaves the buttons/script
elements in to avoid merge conflicts, and just add a warning to mobile-spec
that some links will be broken while we go through the porting process.
Then when everything is done we can remove the links in a final PR.

-Staci



On Fri, Aug 1, 2014 at 3:55 AM, Martin Gonzalez <
martin.c.glez.g...@gmail.com> wrote:

> Hey Michal,
> I've followed up your instructions to easily integrate the test along with
> plugin-test-framework, as you can see I have spammed a little bit the dev
> list with PRs, anyway here's the list of PRs, that includes File, Media,
> Battery-Status and Vibration:
> https://github.com/apache/cordova-plugin-file/pull/62
> https://github.com/apache/cordova-plugin-media/pull/21
> https://github.com/apache/cordova-plugin-battery-status/pull/15
> https://github.com/apache/cordova-plugin-vibration/pull/19
>
> And the removed tests at mobile-spec:
> File: https://github.com/apache/cordova-mobile-spec/pull/86
> Media: https://github.com/apache/cordova-mobile-spec/pull/85
> Battery: https://github.com/apache/cordova-mobile-spec/pull/87
> Vibration: https://github.com/apache/cordova-mobile-spec/pull/88
>
> Also a few days ago, I created a PR against plugin-test-framework, just
> some little changes to the css, all details on the description:
> https://github.com/apache/cordova-plugin-test-framework/pull/3
>
> Everything tested with createmobilespec, and android device.
>
> If you can take a look to any of this, it would be awesome.
>
> Thanks,
> Best Regards,
> Martin
>
> 2014-07-30 10:44 GMT-05:00 Staci Cooper :
>
> > Sounds good, I'll get started.
> >
> >
> > On Wed, Jul 30, 2014 at 11:33 AM, Michal Mocny 
> > wrote:
> >
> > > Things to help move this along:
> > >
> > > - Move test directories to "tests" and add nested plugin.xml, that
> would
> > be
> > > a great.  You can look at an example here:
> > > https://github.com/apache/cordova-plugin-device/tree/master/tests
> > > - Test the PR locally by running the mobilespec create script to make
> > sure
> > > the plugin tests install fine and run well.  (The part that adds
> > new-style
> > > tests is here:
> > >
> > >
> >
> https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L248
> > > )
> > > - Double check to make sure we have covered all tests currently in
> > > mobilespec, and submit PR to remove the old tests from mobilespec app.
>  I
> > > would not like to land the new tests without removing the old tests as
> > > well.
> > >
> > > Thanks a bunch!
> > >
> > >
> > >
> > >
> > >
> > > On Wed, Jul 30, 2014 at 11:25 AM, Staci Cooper 
> > > wrote:
> > >
> > > > Just want to bump this thread.
> > > >
> > > > Michal -- that all sounds great. Let me know if there's anything I
> can
> > do
> > > > to help with integration, or if the IBM committers can help with
> > merging.
> > > > Should we go ahead and add nested plugin.xml files to the PRs?
> > > >
> > > > Also, for reference: I tested all of my PRs on wp8 with a comparison
> > with
> > > > mobile-spec's behavior, as did Martin with his. Edna and Martin have
> > also
> > > > been testing on ios and android respectively.
> > > >
> > > >
> > > > On Tue, Jul 22, 2014 at 9:52 AM, Michal Mocny 
> > > wrote:
> > > >
> > > > > Just a quick update since its been a few days.
> > > > >
> > > > > - Mobile-spec now builds with new-style tests bundled in (there is
> a
> > > > button
> > > > > to launch this on the first screen), and the createmobilespec.sh
> > script
> > > > > will automatically install plugin tests.
> > > > > - Last week I moved device tests from mobile-spec over to plugin
> > tests,
> > > > and
> > > > > modified the file plugin tests to use a nested plugin.xml.
> > > > > - File and FileTransfer tests are tightly coupled in mobile-spec,
> and
> > > > > should be removed together.  I have this mostly finished locally,
> > but..
> > > > > - I want to set up ci.cordova.io to include results of new-style
> > tests
> > > > > before ripping out huge portions of mobile spec, which is what I'm
> > > doing
> > > > > now.
> > > > >
> > > > > Few notes:
> > > > > - The PR's have created

PTO notices for August

[Joe Bowser]

Hey

I'll be on PTO starting on Monday, August 4, 2014.  I'll be back on August
12, 2014.  I'm also going to be out of the office from Aug 20nd to Sept 3
as well.  I'll probably have internet, but I probably won't be able to
respond with anything more meaningful than "+1", "-1" and "DON'T DO THAT"
at that time, if I'm even able to respond at all.

Please post any serious changes to code I'm working on to the list so I at
least know what I'm getting myself into when I get back? Thanks!

Joe

Re: Cordova Hangout August 19

[Marcel Kinard]

Added to wiki, with a placeholder agenda. Set your calendars, and we'll see you 
then.

http://wiki.apache.org/cordova/Google%20Hangout%20Discussion%20Notes

On Jul 28, 2014, at 7:26 PM, tommy-carlos williams  wrote:

>> On Mon, Jul 28, 2014 at 12:37 PM, Marcel Kinard  
>> wrote: 
>> 
>>> I just posted the YouTube playback link to the wiki. 
>>> 
>>> For the next Hangout, how about Tuesday August 19th at same time (4pm EST 
>>> / 1pm PDT)? 
>> 
> 

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50886099
  
Hey Sebastian, I think missing contactFindOptions means return all contacts 
and is correctly handled on some platforms. Is there specific platform which 
fails if you don't pass this parameter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Plugins Release

[Bryan Higgins]

Thanks Steve.

I've done this, but RAT doesn't recognize zlib/libpng even though it has
been approved by Apache legal.

http://www.apache.org/legal/resolved.html


On Thu, Jul 31, 2014 at 7:18 PM, Steven Gill  wrote:

> So Globalization has issues with missing headers and needs a update to the
> notice file for new licenses. Both Blackberry and FFOS need to go do this
> before I release that plugin!
>
> What am I doing with test-harness? That isn't being released right? It also
> needs headers included + notice file updates.
>
>
> On Thu, Jul 31, 2014 at 7:18 AM, Bryan Higgins 
> wrote:
>
> > I'm into it! BlackBerry now supports File plugin roots and Globalization
> :)
> >
> >
> > On Tue, Jul 29, 2014 at 3:29 PM, Steven Gill 
> > wrote:
> >
> > > How do you all feel about a plugins release?
> > >
> > > I can aim to start a vote thread tomorrow or Thursday if people feel
> good
> > > about it.
> > >
> > > -Steve
> > >
> >
>

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-lib/pull/55#issuecomment-50883550
  
Addressed @kamrik code review notes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: plugin-test-framework PRs

[Martin Gonzalez]

Hey Michal,
I've followed up your instructions to easily integrate the test along with
plugin-test-framework, as you can see I have spammed a little bit the dev
list with PRs, anyway here's the list of PRs, that includes File, Media,
Battery-Status and Vibration:
https://github.com/apache/cordova-plugin-file/pull/62
https://github.com/apache/cordova-plugin-media/pull/21
https://github.com/apache/cordova-plugin-battery-status/pull/15
https://github.com/apache/cordova-plugin-vibration/pull/19

And the removed tests at mobile-spec:
File: https://github.com/apache/cordova-mobile-spec/pull/86
Media: https://github.com/apache/cordova-mobile-spec/pull/85
Battery: https://github.com/apache/cordova-mobile-spec/pull/87
Vibration: https://github.com/apache/cordova-mobile-spec/pull/88

Also a few days ago, I created a PR against plugin-test-framework, just
some little changes to the css, all details on the description:
https://github.com/apache/cordova-plugin-test-framework/pull/3

Everything tested with createmobilespec, and android device.

If you can take a look to any of this, it would be awesome.

Thanks,
Best Regards,
Martin

2014-07-30 10:44 GMT-05:00 Staci Cooper :

> Sounds good, I'll get started.
>
>
> On Wed, Jul 30, 2014 at 11:33 AM, Michal Mocny 
> wrote:
>
> > Things to help move this along:
> >
> > - Move test directories to "tests" and add nested plugin.xml, that would
> be
> > a great.  You can look at an example here:
> > https://github.com/apache/cordova-plugin-device/tree/master/tests
> > - Test the PR locally by running the mobilespec create script to make
> sure
> > the plugin tests install fine and run well.  (The part that adds
> new-style
> > tests is here:
> >
> >
> https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L248
> > )
> > - Double check to make sure we have covered all tests currently in
> > mobilespec, and submit PR to remove the old tests from mobilespec app.  I
> > would not like to land the new tests without removing the old tests as
> > well.
> >
> > Thanks a bunch!
> >
> >
> >
> >
> >
> > On Wed, Jul 30, 2014 at 11:25 AM, Staci Cooper 
> > wrote:
> >
> > > Just want to bump this thread.
> > >
> > > Michal -- that all sounds great. Let me know if there's anything I can
> do
> > > to help with integration, or if the IBM committers can help with
> merging.
> > > Should we go ahead and add nested plugin.xml files to the PRs?
> > >
> > > Also, for reference: I tested all of my PRs on wp8 with a comparison
> with
> > > mobile-spec's behavior, as did Martin with his. Edna and Martin have
> also
> > > been testing on ios and android respectively.
> > >
> > >
> > > On Tue, Jul 22, 2014 at 9:52 AM, Michal Mocny 
> > wrote:
> > >
> > > > Just a quick update since its been a few days.
> > > >
> > > > - Mobile-spec now builds with new-style tests bundled in (there is a
> > > button
> > > > to launch this on the first screen), and the createmobilespec.sh
> script
> > > > will automatically install plugin tests.
> > > > - Last week I moved device tests from mobile-spec over to plugin
> tests,
> > > and
> > > > modified the file plugin tests to use a nested plugin.xml.
> > > > - File and FileTransfer tests are tightly coupled in mobile-spec, and
> > > > should be removed together.  I have this mostly finished locally,
> but..
> > > > - I want to set up ci.cordova.io to include results of new-style
> tests
> > > > before ripping out huge portions of mobile spec, which is what I'm
> > doing
> > > > now.
> > > >
> > > > Few notes:
> > > > - The PR's have created a "test" folder, but I had written scripts to
> > > > expect "tests" folder.  Its easy to change or just accept both, but I
> > > > wonder if we should settle on a single convention.  Total bikeshed
> > topic,
> > > > so I'll just pick one.
> > > > - PR's for new tests seem to be well isolated from each other (unlike
> > > > mobilespec).  Aka you can run FileTransfer tests without File tests.
> > >  Good
> > > > job!
> > > >
> > > > -Michal
> > > >
> > > >
> > > > On Wed, Jul 16, 2014 at 5:02 PM, Michal Mocny 
> > > wrote:
> > > >
> > > > > Sure, I was actually already planning to take a look this week.  I
> > was
> > > > > working on mobile-spec today and have *also* ported device tests :P
> >  I
> > > > > should have looked at the PR's first!  Will start these tomorrow.
> > > > >
> > > > > The plan for mobile spec was just to have a transition path, by
> > adding
> > > a
> > > > > link to the old mobile-spec app to open the new-style-tests
> harness.
> > > >  Then,
> > > > > as we move tests from mobile-spec to new-style, we should remove
> the
> > > old
> > > > > tests from mobile-spec.  Doing it this way means cordova committers
> > > have
> > > > a
> > > > > single place to run all tests, and when mobile-spec is 100%
> > completely
> > > > > deprecated, then we can just switch the start page with no change
> to
> > > > > committers.
> > > > >
> > > > > Thanks for your work here!
> > > > >
>

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

[martincgg]

Github user martincgg commented on the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/19#issuecomment-50857537
  
https://github.com/apache/cordova-mobile-spec/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6966 Removed old vibration te...

[martincgg]

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/88

CB-6966 Removed old vibration tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit d640abfb35f657ef72793048576e476dcdb8909c
Author: Martin Gonzalez 
Date:   2014-08-01T07:30:32Z

CB-6966 Removed old vibration tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6957 Removed old battery-stat...

[martincgg]

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/87

CB-6957 Removed old battery-status tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit df403a2144acd31f46cdfb6693f20b53707b51b0
Author: Martin Gonzalez 
Date:   2014-08-01T07:14:38Z

CB-6957 Removed battery-status tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

[martincgg]

Github user martincgg commented on the pull request:


https://github.com/apache/cordova-plugin-battery-status/pull/15#issuecomment-50857488
  
Removed old battery-status tests
https://github.com/apache/cordova-mobile-spec/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

[martincgg]

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-50857437
  
Removed old file tests
https://github.com/apache/cordova-mobile-spec/pull/86


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7094 Removed old file tests

[martincgg]

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/86

CB-7094 Removed old file tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7094

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 3920e2044f0fbc4c9da09d2875626bb589c16d07
Author: Martin Gonzalez 
Date:   2014-08-01T07:17:26Z

CB-7094 Removed old file tests

commit 4866870e5f2f0428a0450cf6cff7b2e88800b2b2
Author: Martin Gonzalez 
Date:   2014-08-01T07:25:40Z

Removed remaining button on index.html




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media manual & aut...

[martincgg]

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-media/pull/21#issuecomment-50857321
  
Removed old media tests:
https://github.com/apache/cordova-mobile-spec/pull/85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6963 Removed old media tests

[martincgg]

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/85

CB-6963 Removed old media tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit 76e257085bdee5503817a10b75adbc0b375542f9
Author: Martin Gonzalez 
Date:   2014-08-01T07:24:33Z

CB-6963 Removed old media tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

[martincgg]

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/15

CB-6957 Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Requires the changes on this PR:
apache/cordova-plugin-test-framework#3

To get a better look.

Also, renamed folder to tests + added nested plugin.xml

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-battery-status 
CB-6957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit f6079cdb6a718ba03a6a5246a5fd0cd423dd2378
Author: Martin Gonzalez 
Date:   2014-07-17T21:27:57Z

CB-6957 Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Requires the changes on this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/3

To get a better look.

commit f01bb645668133ee100e3275a8c933fb5fad1723
Author: Martin Gonzalez 
Date:   2014-08-01T06:36:36Z

CB-6957 renamed folder to tests + added nested plugin.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

[martincgg]

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/19

CB-6966 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 6c21d194f7caff17d8043065d685bc12577e4654
Author: Martin Gonzalez 
Date:   2014-07-17T21:47:01Z

CB-6966 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

commit 6bb38e581ed60c72cff7adaa17e9e3945d3e8221
Author: Martin Gonzalez 
Date:   2014-08-01T06:09:54Z

CB-6966 renamed folder to tests + added nested plugin.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---