RE: WKWebView for iOS8
@firt said yesterday on twitter the GM and the final versión has the same build versión, so the problem should be thereFrom: Ally Ogilvie Sent: 9/18/2014 5:32 To: dev@cordova.apache.org Subject: Re: WKWebView for iOS8 Interested in any updates if you have 'em @Shazron ? Following Brian's tweet i'm kinda hoping there has been a breakthrough to load local files! Gonna switch to WKWebViews from iOS 8 in ma WizViewManager plugin. (WizViewManager is a WebView creator and manager for iOS and Android - sorta like IAB) On Thu, Aug 14, 2014 at 6:08 AM, Brian LeRoux wrote: > orly > > > On Wed, Aug 13, 2014 at 1:57 PM, Shazron wrote: > > > External urls of course work. The other alternative is to host www > > contents on a local webserver, and for CORs use the whitelist. > > > > On Wed, Aug 13, 2014 at 1:51 PM, Shazron wrote: > > > Well, bad news, the workaround doesn't work. Nothing from a file:// > > > url will load in a WKWebView in an iOS 8 beta 5 device. > > > Assumption 1 below fails. > > > > > > Assumptions: > > > 1. WKWebView can load resources from tmp / Documents / Library / > > Library/Caches > > > 2. Can copy www folder in app bundle to tmp / Documents / Library / > > > Library/Caches > > > > > > On Wed, Aug 13, 2014 at 11:18 AM, Shazron wrote: > > >> Jesse had a great idea -- surely you are allowed to load from tmp or > > >> Documents. Assuming I can copy off the app bundle, I would copy the > > >> www folder into tmp or Documents, and load the index.html from there. > > >> This is the Windows Phone Cordova approach I believe. > > >> > > >> Assumptions: > > >> 1. WKWebView can load resources from tmp or Documents > > >> 2. Can copy www folder in app bundle to tmp or Documents > > >> > > >> On Wed, Aug 13, 2014 at 11:07 AM, Shazron wrote: > > >>> Bad news - local file loading in a WKWebView is borked ever since iOS > > 8 beta 4. > > >>> > > >>> Not sure if there is some sort of new security model for loading > local > > >>> files in WKWebView >= beta 4.WKWebView cannot load local files in its > > >>> app bundle anymore you get a blank screen, when on the device. > > >>> Simulator seems fine. I found this out when updating my beta 3 iPhone > > >>> to beta 5 yesterday. I downgraded back, but this beta unfortunately > > >>> expires in 7 days on Aug 21, 2014. > > >>> > > >>> 1. https://devforums.apple.com/message/1011583 > > >>> 2. > > > http://stackoverflow.com/questions/24882834/wkwebview-not-working-in-ios-8-beta-4/24922619#24922619 > > >>> 3. https://issues.apache.org/jira/browse/CB-7288 > > >>> 4. rdar://problem/17761459 > > >>> 5. rdar://problem/17835098 > > >>> > > >>> > > >>> On Wed, Jul 16, 2014 at 12:05 PM, Marc Weiner > > > wrote: > > Same! Shazron, you're awesome!! > > > > > > On Wed, Jul 16, 2014 at 2:08 PM, Carlos Santana < > csantan...@gmail.com > > > > > wrote: > > > > > Happy to see good news when returning from vacation. :-) > > > > > > > > > On Mon, Jul 7, 2014 at 10:33 PM, Ally Ogilvie > > > wrote: > > > > > > > I'm usually an observer here but.. the urge to post was too > great! > > > > > > > > > > > > > > http://seattlesportsnet.files.wordpress.com/2013/11/anchorman-celebration-gif.gif > > > > > > > > Thanks for the research Shaz. > > > > > > > > On Tue, Jul 8, 2014 at 4:57 AM, Tommy Williams < > to...@devgeeks.org > > > > > > wrote: > > > > > > > > > Yes!!! > > > > > On 8 Jul 2014 05:52, "Shazron" wrote: > > > > > > > > > > > Good news: > > https://twitter.com/shazron/status/486235098715394048 > > > > > > > > > > > > On Fri, Jun 27, 2014 at 3:46 PM, Shazron > > wrote: > > > > > > > Broke the iOS 8 issue into sub-tasks: > > > > > > > https://issues.apache.org/jira/browse/CB-7043 > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jun 16, 2014 at 8:20 AM, Shazron < > shaz...@gmail.com> > > > wrote: > > > > > > >> Haven't yet - but from what I read - no. Something about > > requests > > > > > being > > > > > > out > > > > > > >> of process > > > > > > >> > > > > > > >> > > > > > > >> On Monday, June 16, 2014, Andrew Grieve < > > agri...@chromium.org> > > > > wrote: > > > > > > >>> > > > > > > >>> Awesome. > > > > > > >>> > > > > > > >>> Shaz (or anyone else), curious if you've tested yet to > see > > if the > > > > > > >>> whitelist > > > > > > >>> still works with WKWebView? (e.g. does it go through > > > > NSURLProtocol?) > > > > > > >>> > > > > > > >>> > > > > > > >>> On Sat, Jun 14, 2014 at 8:16 PM, tommy-carlos williams > > > > > > >>> > > > > > > >>> wrote: > > > > > > >>> > > > > > > >>> > This looks promising. > > > > > > >>> > > > > > > > >>> > Thanks for the update, Shazron. > > > > > > >>> > > > > > > > >>> > - tommy > > > > > > >>> > > > > > > > >>> > > > > > > > >>> > On Sun, Jun 15, 2014 at
iOS8 support
Hello I just wonder if the next version of Cordova iOS (3.6.3?) is going to support iOS8. I read iOS platform guide for Cordova 3.6.3 in github but I couldn't find any specific comment for this. I may be asking the obvious but I would appreciate any advice. Best Regards, Shingo
[DISCUSS] continuous build and release process
Honestly, we're not doing continuous build. Yes, there are 3 repos that build within their own scope, but we aren't building end-to-end. I think we need to be building continuously end-to-end. Here are some thoughts: - goal should be to have an automated system that generates nightly builds. The build includes everything end-to-end (i.e.: cli+lib+js dependency tree, platforms, plugins). All that is left to promote a build artifact to an RC is signing and copying to dist-dev. - as much as possible, no input should be required outside of what is in the git repos - commit to git and go. - publishes nightly builds to a test npm registry, so you can do "npm install cordova@2014.09.15" while pointing to this test registry. - does some end-to-end smoke testing such as creating projects, adding and removing plugins, adding platforms and generating an app - shrinkwrap is generated (for those modules that need shrinkwrap) Bonus points for the following: - runs unit tests of all components - uncurated release notes are automatically collected - generates reports from audit-license-headers and license-check (hey, maybe even fail the build) As far as our release process, one gap I suggest we fill is that branches get created for all repos when the first RC is created from master. Not just platforms. If there is a need to spin another RC with a modification, this makes it much more predictable and easier (no winding back the version bump, and then putting it back in after we apply our mod). Coho is a big help, but there still is way too much manual glue and steps. Maybe I'm incompetent, but the 3.6 platforms/tools release has been very painful. Now this I think would accelerate our release pace. Whaddya think?
[DISCUSS] shrinkwrap
I understand the goal of the shrinkwrap to be that all users have exactly all the same dependency versions for execution, and the developers have the same for dev/test. Today the process [1] is for the shrinkwrap to exist in git only during the release process. While this covers the users for execution, it leaves out the developers for dev/test. Additionally, continuing in this way postpones discovery of shrinkwrap issues to the release period instead of catching it earlier. I suggest that: - The shrinkwrap exist in git at all times, not just during the release process. - At the beginning of a new dev/test cycle in a project that has a shrinkwrap, developers should not only "git pull", but should also "rm -r node_modules ; npm install". - Also at the beginning of a new dev cycle in a project that has a shrinkwrap, developers should run "npm outdated" to look for opportunities to freshen versions of dependencies for purposes of general hygiene. Whether or not to do the freshen in this case is up to the discretion of the developer. But at least look and see if something is crusty. - If there is a functional problem during dev/test that can be resolved by freshening the versions of dependencies, do it. - Only cordova-cli should have a shrinkwrap. The parent's shrinkwrap includes the whole tree of children (dependencies). [1]: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md Whaddya think? (Credit to Carlos for stopping by my office to share ideas)
Re: [VOTE] Plugins Release Sept 17 2014
RC has been refreshed with this commit. New vote thread started. On Sep 17, 2014, at 6:37 PM, Archana Naik wrote: > I am done. Change is pushed to geolocation master. > > Thanks Marcel. > Archana > > On Wed, Sep 17, 2014 at 3:26 PM, Marcel Kinard wrote: > >> OK. Let me know when your update is complete, and then for just the >> geolocation plugin I can re-tag and re-gen the zip for dist-dev and start a >> new vote. >> >> This vote is cancelled. >> >> Last call for any other must-have changes. >> >> (Doing the plugins release was WAY easier than the tools release. Almost >> reasonable.) >> >> On Sep 17, 2014, at 6:20 PM, Archana Naik wrote: >> >>> Marcel, >>> >>> -1 for me because I need to remove amazon-fireos related code from >>> geolocation plugin. I can do it now and push it. Would you please update >>> the dist with new one?
[VOTE] Plugins Release Sept 17 2014 (attempt #2)
Please review and vote on the release of this plugins release. Compared to attempt #1, it includes a change to the geolocation plugin for FireOS. The tag for that repo was updated. Release issue: https://issues.apache.org/jira/browse/CB-7571 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7571/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 0.2.11 (c80ffae72f) cordova-plugin-camera: 0.3.2 (af18483d69) cordova-plugin-console: 0.2.11 (9d1c255ac7) cordova-plugin-contacts: 0.2.13 (e42219a7d5) cordova-plugin-device: 0.2.12 (c6e23d8a61) cordova-plugin-device-motion: 0.2.10 (213aea947f) cordova-plugin-device-orientation: 0.3.9 (a09ef3c4ff) cordova-plugin-dialogs: 0.2.10 (64017132b4) cordova-plugin-file: 1.3.1 (198ca6198e) cordova-plugin-file-transfer: 0.4.6 (16249c2f7a) cordova-plugin-geolocation: 0.3.10 (543afdf88a) cordova-plugin-globalization: 0.3.1 (6c4798d263) cordova-plugin-inappbrowser: 0.5.2 (8ce6b497fa) cordova-plugin-media: 0.2.13 (b2e92f9396) cordova-plugin-media-capture: 0.3.3 (5888a627f7) cordova-plugin-network-information: 0.2.12 (df7aac845d) cordova-plugin-splashscreen: 0.3.3 (e4d8b77027) cordova-plugin-statusbar: 0.1.8 (6cce513237) cordova-plugin-vibration: 0.3.11 (5adf530d36) Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho verify-archive over the relevant repos
Re: WKWebView for iOS8
Interested in any updates if you have 'em @Shazron ? Following Brian's tweet i'm kinda hoping there has been a breakthrough to load local files! Gonna switch to WKWebViews from iOS 8 in ma WizViewManager plugin. (WizViewManager is a WebView creator and manager for iOS and Android - sorta like IAB) On Thu, Aug 14, 2014 at 6:08 AM, Brian LeRoux wrote: > orly > > > On Wed, Aug 13, 2014 at 1:57 PM, Shazron wrote: > > > External urls of course work. The other alternative is to host www > > contents on a local webserver, and for CORs use the whitelist. > > > > On Wed, Aug 13, 2014 at 1:51 PM, Shazron wrote: > > > Well, bad news, the workaround doesn't work. Nothing from a file:// > > > url will load in a WKWebView in an iOS 8 beta 5 device. > > > Assumption 1 below fails. > > > > > > Assumptions: > > > 1. WKWebView can load resources from tmp / Documents / Library / > > Library/Caches > > > 2. Can copy www folder in app bundle to tmp / Documents / Library / > > > Library/Caches > > > > > > On Wed, Aug 13, 2014 at 11:18 AM, Shazron wrote: > > >> Jesse had a great idea -- surely you are allowed to load from tmp or > > >> Documents. Assuming I can copy off the app bundle, I would copy the > > >> www folder into tmp or Documents, and load the index.html from there. > > >> This is the Windows Phone Cordova approach I believe. > > >> > > >> Assumptions: > > >> 1. WKWebView can load resources from tmp or Documents > > >> 2. Can copy www folder in app bundle to tmp or Documents > > >> > > >> On Wed, Aug 13, 2014 at 11:07 AM, Shazron wrote: > > >>> Bad news - local file loading in a WKWebView is borked ever since iOS > > 8 beta 4. > > >>> > > >>> Not sure if there is some sort of new security model for loading > local > > >>> files in WKWebView >= beta 4.WKWebView cannot load local files in its > > >>> app bundle anymore you get a blank screen, when on the device. > > >>> Simulator seems fine. I found this out when updating my beta 3 iPhone > > >>> to beta 5 yesterday. I downgraded back, but this beta unfortunately > > >>> expires in 7 days on Aug 21, 2014. > > >>> > > >>> 1. https://devforums.apple.com/message/1011583 > > >>> 2. > > > http://stackoverflow.com/questions/24882834/wkwebview-not-working-in-ios-8-beta-4/24922619#24922619 > > >>> 3. https://issues.apache.org/jira/browse/CB-7288 > > >>> 4. rdar://problem/17761459 > > >>> 5. rdar://problem/17835098 > > >>> > > >>> > > >>> On Wed, Jul 16, 2014 at 12:05 PM, Marc Weiner > > > wrote: > > Same! Shazron, you're awesome!! > > > > > > On Wed, Jul 16, 2014 at 2:08 PM, Carlos Santana < > csantan...@gmail.com > > > > > wrote: > > > > > Happy to see good news when returning from vacation. :-) > > > > > > > > > On Mon, Jul 7, 2014 at 10:33 PM, Ally Ogilvie > > > wrote: > > > > > > > I'm usually an observer here but.. the urge to post was too > great! > > > > > > > > > > > > > > http://seattlesportsnet.files.wordpress.com/2013/11/anchorman-celebration-gif.gif > > > > > > > > Thanks for the research Shaz. > > > > > > > > On Tue, Jul 8, 2014 at 4:57 AM, Tommy Williams < > to...@devgeeks.org > > > > > > wrote: > > > > > > > > > Yes!!! > > > > > On 8 Jul 2014 05:52, "Shazron" wrote: > > > > > > > > > > > Good news: > > https://twitter.com/shazron/status/486235098715394048 > > > > > > > > > > > > On Fri, Jun 27, 2014 at 3:46 PM, Shazron > > wrote: > > > > > > > Broke the iOS 8 issue into sub-tasks: > > > > > > > https://issues.apache.org/jira/browse/CB-7043 > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jun 16, 2014 at 8:20 AM, Shazron < > shaz...@gmail.com> > > > wrote: > > > > > > >> Haven't yet - but from what I read - no. Something about > > requests > > > > > being > > > > > > out > > > > > > >> of process > > > > > > >> > > > > > > >> > > > > > > >> On Monday, June 16, 2014, Andrew Grieve < > > agri...@chromium.org> > > > > wrote: > > > > > > >>> > > > > > > >>> Awesome. > > > > > > >>> > > > > > > >>> Shaz (or anyone else), curious if you've tested yet to > see > > if the > > > > > > >>> whitelist > > > > > > >>> still works with WKWebView? (e.g. does it go through > > > > NSURLProtocol?) > > > > > > >>> > > > > > > >>> > > > > > > >>> On Sat, Jun 14, 2014 at 8:16 PM, tommy-carlos williams > > > > > > >>> > > > > > > >>> wrote: > > > > > > >>> > > > > > > >>> > This looks promising. > > > > > > >>> > > > > > > > >>> > Thanks for the update, Shazron. > > > > > > >>> > > > > > > > >>> > - tommy > > > > > > >>> > > > > > > > >>> > > > > > > > >>> > On Sun, Jun 15, 2014 at 7:48 AM, Shazron < > > shaz...@gmail.com> > > > > > wrote: > > > > > > >>> > > > > > > > >>> >> Rev log: > > http://trac.webkit.org/log/trunk/Source/WebKit2/ > > > > > > >>> >> UIProcess/API/Cocoa/WKWebVie
Re: [VOTE] Plugins Release Sept 17 2014
I am done. Change is pushed to geolocation master. Thanks Marcel. Archana On Wed, Sep 17, 2014 at 3:26 PM, Marcel Kinard wrote: > OK. Let me know when your update is complete, and then for just the > geolocation plugin I can re-tag and re-gen the zip for dist-dev and start a > new vote. > > This vote is cancelled. > > Last call for any other must-have changes. > > (Doing the plugins release was WAY easier than the tools release. Almost > reasonable.) > > On Sep 17, 2014, at 6:20 PM, Archana Naik wrote: > > > Marcel, > > > > -1 for me because I need to remove amazon-fireos related code from > > geolocation plugin. I can do it now and push it. Would you please update > > the dist with new one? > > > > Thanks > > Archana > > > > On Wed, Sep 17, 2014 at 3:15 PM, Marcel Kinard > wrote: > > > >> Please review and vote on the release of this plugins release. > >> > >> Release issue: https://issues.apache.org/jira/browse/CB-7571 > >> > >> The plugins have been published to dist/dev: > >> https://dist.apache.org/repos/dist/dev/cordova/CB-7571/ > >> > >> The packages were published from their corresponding git tags: > >>cordova-plugin-battery-status: 0.2.11 (c80ffae72f) > >>cordova-plugin-camera: 0.3.2 (af18483d69) > >>cordova-plugin-console: 0.2.11 (9d1c255ac7) > >>cordova-plugin-contacts: 0.2.13 (e42219a7d5) > >>cordova-plugin-device: 0.2.12 (c6e23d8a61) > >>cordova-plugin-device-motion: 0.2.10 (213aea947f) > >>cordova-plugin-device-orientation: 0.3.9 (a09ef3c4ff) > >>cordova-plugin-dialogs: 0.2.10 (64017132b4) > >>cordova-plugin-file: 1.3.1 (198ca6198e) > >>cordova-plugin-file-transfer: 0.4.6 (16249c2f7a) > >>cordova-plugin-geolocation: 0.3.10 (2288153f47) > >>cordova-plugin-globalization: 0.3.1 (6c4798d263) > >>cordova-plugin-inappbrowser: 0.5.2 (8ce6b497fa) > >>cordova-plugin-media: 0.2.13 (b2e92f9396) > >>cordova-plugin-media-capture: 0.3.3 (5888a627f7) > >>cordova-plugin-network-information: 0.2.12 (df7aac845d) > >>cordova-plugin-splashscreen: 0.3.3 (e4d8b77027) > >>cordova-plugin-statusbar: 0.1.8 (6cce513237) > >>cordova-plugin-vibration: 0.3.11 (5adf530d36) > >> > >> Upon a successful vote I will upload the archives to dist/, upload them > to > >> the Plugins Registry, and post the corresponding blog post. > >> > >> Voting guidelines: > >> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > >> > >> Voting will go on for a minimum of 48 hours. > >> > >> I vote +1: > >> * Ran coho audit-license-headers over the relevant repos > >> * Ran coho verify-archive over the relevant repos > >> > >> > >
Re: [VOTE] Plugins Release Sept 17 2014
OK. Let me know when your update is complete, and then for just the geolocation plugin I can re-tag and re-gen the zip for dist-dev and start a new vote. This vote is cancelled. Last call for any other must-have changes. (Doing the plugins release was WAY easier than the tools release. Almost reasonable.) On Sep 17, 2014, at 6:20 PM, Archana Naik wrote: > Marcel, > > -1 for me because I need to remove amazon-fireos related code from > geolocation plugin. I can do it now and push it. Would you please update > the dist with new one? > > Thanks > Archana > > On Wed, Sep 17, 2014 at 3:15 PM, Marcel Kinard wrote: > >> Please review and vote on the release of this plugins release. >> >> Release issue: https://issues.apache.org/jira/browse/CB-7571 >> >> The plugins have been published to dist/dev: >> https://dist.apache.org/repos/dist/dev/cordova/CB-7571/ >> >> The packages were published from their corresponding git tags: >>cordova-plugin-battery-status: 0.2.11 (c80ffae72f) >>cordova-plugin-camera: 0.3.2 (af18483d69) >>cordova-plugin-console: 0.2.11 (9d1c255ac7) >>cordova-plugin-contacts: 0.2.13 (e42219a7d5) >>cordova-plugin-device: 0.2.12 (c6e23d8a61) >>cordova-plugin-device-motion: 0.2.10 (213aea947f) >>cordova-plugin-device-orientation: 0.3.9 (a09ef3c4ff) >>cordova-plugin-dialogs: 0.2.10 (64017132b4) >>cordova-plugin-file: 1.3.1 (198ca6198e) >>cordova-plugin-file-transfer: 0.4.6 (16249c2f7a) >>cordova-plugin-geolocation: 0.3.10 (2288153f47) >>cordova-plugin-globalization: 0.3.1 (6c4798d263) >>cordova-plugin-inappbrowser: 0.5.2 (8ce6b497fa) >>cordova-plugin-media: 0.2.13 (b2e92f9396) >>cordova-plugin-media-capture: 0.3.3 (5888a627f7) >>cordova-plugin-network-information: 0.2.12 (df7aac845d) >>cordova-plugin-splashscreen: 0.3.3 (e4d8b77027) >>cordova-plugin-statusbar: 0.1.8 (6cce513237) >>cordova-plugin-vibration: 0.3.11 (5adf530d36) >> >> Upon a successful vote I will upload the archives to dist/, upload them to >> the Plugins Registry, and post the corresponding blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho verify-archive over the relevant repos >> >>
Re: [VOTE] Plugins Release Sept 17 2014
Marcel, -1 for me because I need to remove amazon-fireos related code from geolocation plugin. I can do it now and push it. Would you please update the dist with new one? Thanks Archana On Wed, Sep 17, 2014 at 3:15 PM, Marcel Kinard wrote: > Please review and vote on the release of this plugins release. > > Release issue: https://issues.apache.org/jira/browse/CB-7571 > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-7571/ > > The packages were published from their corresponding git tags: > cordova-plugin-battery-status: 0.2.11 (c80ffae72f) > cordova-plugin-camera: 0.3.2 (af18483d69) > cordova-plugin-console: 0.2.11 (9d1c255ac7) > cordova-plugin-contacts: 0.2.13 (e42219a7d5) > cordova-plugin-device: 0.2.12 (c6e23d8a61) > cordova-plugin-device-motion: 0.2.10 (213aea947f) > cordova-plugin-device-orientation: 0.3.9 (a09ef3c4ff) > cordova-plugin-dialogs: 0.2.10 (64017132b4) > cordova-plugin-file: 1.3.1 (198ca6198e) > cordova-plugin-file-transfer: 0.4.6 (16249c2f7a) > cordova-plugin-geolocation: 0.3.10 (2288153f47) > cordova-plugin-globalization: 0.3.1 (6c4798d263) > cordova-plugin-inappbrowser: 0.5.2 (8ce6b497fa) > cordova-plugin-media: 0.2.13 (b2e92f9396) > cordova-plugin-media-capture: 0.3.3 (5888a627f7) > cordova-plugin-network-information: 0.2.12 (df7aac845d) > cordova-plugin-splashscreen: 0.3.3 (e4d8b77027) > cordova-plugin-statusbar: 0.1.8 (6cce513237) > cordova-plugin-vibration: 0.3.11 (5adf530d36) > > Upon a successful vote I will upload the archives to dist/, upload them to > the Plugins Registry, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho verify-archive over the relevant repos > >
[VOTE] Plugins Release Sept 17 2014
Please review and vote on the release of this plugins release. Release issue: https://issues.apache.org/jira/browse/CB-7571 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7571/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 0.2.11 (c80ffae72f) cordova-plugin-camera: 0.3.2 (af18483d69) cordova-plugin-console: 0.2.11 (9d1c255ac7) cordova-plugin-contacts: 0.2.13 (e42219a7d5) cordova-plugin-device: 0.2.12 (c6e23d8a61) cordova-plugin-device-motion: 0.2.10 (213aea947f) cordova-plugin-device-orientation: 0.3.9 (a09ef3c4ff) cordova-plugin-dialogs: 0.2.10 (64017132b4) cordova-plugin-file: 1.3.1 (198ca6198e) cordova-plugin-file-transfer: 0.4.6 (16249c2f7a) cordova-plugin-geolocation: 0.3.10 (2288153f47) cordova-plugin-globalization: 0.3.1 (6c4798d263) cordova-plugin-inappbrowser: 0.5.2 (8ce6b497fa) cordova-plugin-media: 0.2.13 (b2e92f9396) cordova-plugin-media-capture: 0.3.3 (5888a627f7) cordova-plugin-network-information: 0.2.12 (df7aac845d) cordova-plugin-splashscreen: 0.3.3 (e4d8b77027) cordova-plugin-statusbar: 0.1.8 (6cce513237) cordova-plugin-vibration: 0.3.11 (5adf530d36) Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho verify-archive over the relevant repos
[GitHub] cordova-android pull request: CB-7493 Adds test-build command to p...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-media pull request: CB-7547 Fixes audio recording o...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-media pull request: CB-7531 Fixes play() failure af...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: CB-7529 CB-7532 File tr...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: [BlackBerry10] Re-imple...
GitHub user lyonplus opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/25 [BlackBerry10] Re-implement getPreferredLanguage() and getLocaleName(). Previous implementation of getPreferredLanguage() is using language info from default locale, which is wrong. The new implementation reflects the actual UI language selected, instead of the language for the default locale. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry-webworks/cordova-plugin-globalization lyon-g11n Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit b6e6dacb964f899dc7d7be8c1810b6ba7b472ebf Author: Lianghui Chen Date: 2014-09-15T20:48:09Z [BlackBerry10] Re-implement getPreferredLanguage() and getLocaleName(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: [BlackBerry10] Allow an...
Github user lyonplus closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: [BlackBerry10] Allow an...
GitHub user lyonplus reopened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/23 [BlackBerry10] Allow any numeric type as date in dateToString method. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry-webworks/cordova-plugin-globalization lyon-g11n Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 7dd45012c38ec3b83c2f7ce5472bd7c658926989 Author: Lianghui Chen Date: 2014-09-15T20:48:09Z [BlackBerry10] Re-implement getPreferredLanguage() and getLocaleName(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: [BlackBerry10] Allow an...
Github user lyonplus closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55958394 Ok, sounds good as a stop-gap - with #17 this could be viable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...
Github user Clafou commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55948054 Given the new and recommended splash screen approach in iOS8, it seems that there is naming convention for the iPhone 6. However it is possible to use image-based splash screens for iPhone 6 and 6 Plus by adding the relevant keys to the project plist (as I have tried and tested). Perhaps the plugin should use the entries in the project plist instead of using naming conventions, but that's a lot more rework and in this case it would seem better to reimplement this for an xcassets approach. This merge request at least makes a quick fix to make the plist approach functional. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Vote] Tools Release 3.6.3-0.2.12
don't worry we can release code at any time and at any rate :-), as long we vote and allow enoupgh time for folks to vote On Wed, Sep 17, 2014 at 2:19 PM, Marcel Kinard wrote: > For the most part, I like this idea. It definitely is an improvement. > > Since there isn't significant usage of cordova-lib and cordova-plugman > outside of cordova-cli, then there isn't benefit to shrinkwrapping > cordova-lib and cordova-plugman themselves. The cordova-cli is what people > do an "npm install" on, and the cli shrinkwrap will include the whole tree > of dependencies, including lib and plugman. > > The part that isn't ideal is still needing to npm publish cordova-js and > cordova-lib before creating the rc of cordova-cli for dist-dev. > > On Sep 17, 2014, at 1:02 PM, Carlos Santana wrote: > > > My recommendation would be only do shrinkwrap for cordova-cli, and > publish > > cordova-lib and cordova-js first, then create npm shrinkwrap for > > cordova-cli and publish > > > > 1. npm publish cordova-js version rc:3.6.4 (no shrinkwrap) > > 2. update cordova-lib to depend on cordova-js@3.6.4 && npm publish > > cordova-lib with rc:3.6.4 (no shrinkwrap) > > 3. cd cordova-cli/ && update dependency for cordova-lib@3.6.4 && rm -rf > > node_modules && npm install && npm shrinkwrap && npm publish cordova as > > rc:3.6.4-0.2.13 > > 4. vote on rc > > 5. if voting pass move all to latest:3.6.4 > > > > If this is incorrect then I missed something on the problem you are > facing. > > -- Carlos Santana
[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...
Github user dpeacock commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/81#issuecomment-55938319 Added the fix to check for file exists instead of null check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Vote] Tools Release 3.6.3-0.2.12
For the most part, I like this idea. It definitely is an improvement. Since there isn't significant usage of cordova-lib and cordova-plugman outside of cordova-cli, then there isn't benefit to shrinkwrapping cordova-lib and cordova-plugman themselves. The cordova-cli is what people do an "npm install" on, and the cli shrinkwrap will include the whole tree of dependencies, including lib and plugman. The part that isn't ideal is still needing to npm publish cordova-js and cordova-lib before creating the rc of cordova-cli for dist-dev. On Sep 17, 2014, at 1:02 PM, Carlos Santana wrote: > My recommendation would be only do shrinkwrap for cordova-cli, and publish > cordova-lib and cordova-js first, then create npm shrinkwrap for > cordova-cli and publish > > 1. npm publish cordova-js version rc:3.6.4 (no shrinkwrap) > 2. update cordova-lib to depend on cordova-js@3.6.4 && npm publish > cordova-lib with rc:3.6.4 (no shrinkwrap) > 3. cd cordova-cli/ && update dependency for cordova-lib@3.6.4 && rm -rf > node_modules && npm install && npm shrinkwrap && npm publish cordova as > rc:3.6.4-0.2.13 > 4. vote on rc > 5. if voting pass move all to latest:3.6.4 > > If this is incorrect then I missed something on the problem you are facing.
[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...
Github user dpeacock commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17682048 --- Diff: src/android/LocalFilesystem.java --- @@ -589,6 +593,32 @@ public long writeToFileAtURL(LocalFilesystemURL inputURL, String data, return rawData.length; } + +/** + * Send broadcast of new file so files appear over MTP + * + * @param inputURL + */ + private void broadcastNewFile(LocalFilesystemURL inputURL) { + //Get the activity + Activity activity = this.cordova.getActivity(); + + //Get the context + Context context = activity.getApplicationContext(); + + //Get file + File file = new File(this.filesystemPathForURL(inputURL)); + if (file != null) { --- End diff -- Agreed, I will update this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...
Github user dpeacock commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17681983 --- Diff: src/android/LocalFilesystem.java --- @@ -579,6 +582,7 @@ public long writeToFileAtURL(LocalFilesystemURL inputURL, String data, // Always close the output out.close(); } + broadcastNewFile(inputURL); --- End diff -- I agree with what you are saying here. By the time we are in writeToFileAtURL it seems the file already exists, so I tried moving this logic to getFileForLocalURL. In here I was checking if the file existed prior to creation, then broadcasting if it was created. The results however were strange. Though the files would appear, they would sometimes be 0 bytes in size. Trying to debug the javascript portion always resulted in 0 byte files. I then tried re-testing the broadcast after the write (where it is in this commit) and it seems to work as expected. I can't really explain why this occurring, perhaps you have some insight on this? If not, I think it's probably best to leave the broadcast after every write to be safe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55930672 Definitely, I've commented on other splash screen PRs that we need to go with that modern (and more sane) approach, but that's more of a migration path that needs docs, etc and may affect CLI, so there is more involved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Cordova Meetup @ Google Berlin
So, this is getting finalized -- I think that Brian has sent out a message to everyone who had tickets to PGDEU; I'm not sure what other avenues are good for getting the word out. There's going to be an all-day event at the Google Berlin office next Friday; I'd *love* it if anyone from the dev@ list could make it! If you can, there's a signup form at https://docs.google.com/forms/d/1oXkGhlaoTKBU1fbcxdLX0HFXThbcU7wonPoLry8SX1A -- put your name down, and I'll make sure that there's a spot for you On Fri, Sep 12, 2014 at 6:01 PM, Ian Clelland wrote: > > > On Friday, September 12, 2014, Archana Naik > wrote: > >> Wow!! This is a news to me...When did it get rescheduled? Is it happening >> at all? > > > And, re-reading your message, I realize you probably didn't see what > prompted this: I only saw yesterday, on pgday.phonegap.com, that the > European conference had been postponed until spring 2015. > > It seems that Adobe has been refunding the event tickets. Several of us > have non-refundable travel plans, though, so we're making the best of it :) > > >> >> On Fri, Sep 12, 2014 at 1:52 PM, Michal Mocny >> wrote: >> >> > 3 Googlers have non refundable tickets, and probably there are a few >> others >> > who are already too excited about oktoberfest to back out ;) >> > >> > Anyway, Ian found a meetup was already being organized spontaneously ( >> > www.meetup.com/Hybrid-Mobile-App-Meetup-Berlin/events/206658982/), so >> > Andrew secured a room in the Google Berlin office since it happened to >> be >> > free. >> > >> > I won't be going either, sadly. >> > >> > -Michal >> > >> > On Fri, Sep 12, 2014 at 4:46 PM, Joe Bowser wrote: >> > >> > > Sadly, I already pulled the plug on my Berlin trip yesterday. Perhaps >> > this >> > > would make more sense in San Francisco next month. >> > > >> > > On Fri, Sep 12, 2014 at 1:43 PM, Ian Clelland > > >> > > wrote: >> > > >> > > > Since it appears that PhoneGapDayEU has been postponed, and there >> are >> > > > several of us already committed to going to Berlin, we (Google) >> figured >> > > > that we might take the opportunity to host a Cordova / PhoneGap >> meetup >> > in >> > > > our Berlin office, on the original conference dates. >> > > > >> > > > I've put up a quick site here, to which I'll add more details as >> soon >> > as >> > > I >> > > > have them: http://goo.gl/BVRmIe >> > > > >> > > > I know that some people have cancelled travel plans already, but I >> hope >> > > we >> > > > can still see some folks there! >> > > > >> > > > Ian >> > > > >> > > >> > >> >
[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55928732 And [this document](https://developer.apple.com/library/prerelease/ios/documentation/UserExperience/Conceptual/MobileHIG/LaunchImages.html) linked from [here](https://developer.apple.com/library/prerelease/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html) suggests that you shouldn't use static images at all for launch images on an iPhone 6 or 6 Plus (although maybe we *can* still get away with it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Vote] Tools Release 3.6.3-0.2.12
My recommendation would be only do shrinkwrap for cordova-cli, and publish cordova-lib and cordova-js first, then create npm shrinkwrap for cordova-cli and publish 1. npm publish cordova-js version rc:3.6.4 (no shrinkwrap) 2. update cordova-lib to depend on cordova-js@3.6.4 && npm publish cordova-lib with rc:3.6.4 (no shrinkwrap) 3. cd cordova-cli/ && update dependency for cordova-lib@3.6.4 && rm -rf node_modules && npm install && npm shrinkwrap && npm publish cordova as rc:3.6.4-0.2.13 4. vote on rc 5. if voting pass move all to latest:3.6.4 If this is incorrect then I missed something on the problem you are facing. On Wed, Sep 17, 2014 at 11:47 AM, Marcel Kinard wrote: > > On Sep 17, 2014, at 9:54 AM, Andrew Grieve wrote: > > >> 2) directory install: > >> npm install ../cordova-js > > > We've been bit before by this scenario as well. I believe the shrinkwrap > > will record that cordova-js is located at "../cordova-js" instead of from > > the registry in this case. > > Now that I take a closer look in this scenario at the "from" field in the > shrinkwrap I see that you are correct. This would imply that I would first > need to "npm publish cordova-js" before I could do a clean install of the > cordova-lib dependencies and create the shrinkwrap for cordova-lib. And > then the same to "npm publish cordova-lib" before I could do a clean > install of the cordova-cli dependencies and create the shrinkwrap for > cordova-cli. And that would mean an npm publish is a pre-req to building an > rc before posting it to dist-dev. Am I reading this right? (I'm hoping > someone will tell me I am wrong, because I don't like that path.) > > Hmm, I'm wondering if this tool might be helpful: > https://www.npmjs.org/package/npm-shrinkwrap . Playing with it for just a > moment, it does remove the "from" field and leaves the "resolved" field in > the shrinkwrap. But the resolved field requires that the versioned > dependency (i.e., cordova-js) be published in the npm repo, and will error > if it isn't there. So it's not a full answer. > > A couple related bugs: > https://github.com/npm/npm/issues/3145 > https://github.com/npm/npm/issues/3581 > > Aaargh! > > I'm left with the impression that we way we do dependencies in our tools > and then do a simultaneous release just doesn't fit well with npm's notion > of write-once publishing and creating shrinkwrap, especially creating > shrinkwrap. I am very curious to see what Steve thinks about all this when > he gets back. > > >> 3) registry install: > >> npm install cordova-js (fetches from registry) > >> > > ^^ Shouldn't need this step right? since "npm install" will grab it from > > the registry anyways. > > Correct. I was just doing this locally to see what a user's experience > would be. -- Carlos Santana
[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55919550 Not sure if that is Apple convention for the new iPhones. At least nothing here: https://developer.apple.com/library/prerelease/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/iPhoneOSKeys.html#//apple_ref/doc/uid/TP40009252-SW24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Vote] Tools Release 3.6.3-0.2.12
On Sep 17, 2014, at 9:54 AM, Andrew Grieve wrote: >> 2) directory install: >> npm install ../cordova-js > We've been bit before by this scenario as well. I believe the shrinkwrap > will record that cordova-js is located at "../cordova-js" instead of from > the registry in this case. Now that I take a closer look in this scenario at the "from" field in the shrinkwrap I see that you are correct. This would imply that I would first need to "npm publish cordova-js" before I could do a clean install of the cordova-lib dependencies and create the shrinkwrap for cordova-lib. And then the same to "npm publish cordova-lib" before I could do a clean install of the cordova-cli dependencies and create the shrinkwrap for cordova-cli. And that would mean an npm publish is a pre-req to building an rc before posting it to dist-dev. Am I reading this right? (I'm hoping someone will tell me I am wrong, because I don't like that path.) Hmm, I'm wondering if this tool might be helpful: https://www.npmjs.org/package/npm-shrinkwrap . Playing with it for just a moment, it does remove the "from" field and leaves the "resolved" field in the shrinkwrap. But the resolved field requires that the versioned dependency (i.e., cordova-js) be published in the npm repo, and will error if it isn't there. So it's not a full answer. A couple related bugs: https://github.com/npm/npm/issues/3145 https://github.com/npm/npm/issues/3581 Aaargh! I'm left with the impression that we way we do dependencies in our tools and then do a simultaneous release just doesn't fit well with npm's notion of write-once publishing and creating shrinkwrap, especially creating shrinkwrap. I am very curious to see what Steve thinks about all this when he gets back. >> 3) registry install: >> npm install cordova-js (fetches from registry) >> > ^^ Shouldn't need this step right? since "npm install" will grab it from > the registry anyways. Correct. I was just doing this locally to see what a user's experience would be.
Re: Android L Testing
I've been testing against it as well, and (so far) haven't found any problems. On Wed, Sep 17, 2014 at 10:52 AM, Edna Y Morales wrote: > > Hi all, > > I've done testing on mobilespec over Android L. Comparing against test > results for Android 4.4.4, I'm not seeing any breakages on Android L. > I'm not sure if anyone else has done testing that can confirm my findings, > but just wanted to share what I found. > > Thanks, > Edna Morales
Android L Testing
Hi all, I've done testing on mobilespec over Android L. Comparing against test results for Android 4.4.4, I'm not seeing any breakages on Android L. I'm not sure if anyone else has done testing that can confirm my findings, but just wanted to share what I found. Thanks, Edna Morales
[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17667256 --- Diff: src/android/LocalFilesystem.java --- @@ -579,6 +582,7 @@ public long writeToFileAtURL(LocalFilesystemURL inputURL, String data, // Always close the output out.close(); } + broadcastNewFile(inputURL); --- End diff -- Does this happen on every file write? If so, should we try to ensure that it happens only when new files are created, or does it need to be called every time a file changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17667021 --- Diff: src/android/LocalFilesystem.java --- @@ -589,6 +593,32 @@ public long writeToFileAtURL(LocalFilesystemURL inputURL, String data, return rawData.length; } + +/** + * Send broadcast of new file so files appear over MTP + * + * @param inputURL + */ + private void broadcastNewFile(LocalFilesystemURL inputURL) { + //Get the activity + Activity activity = this.cordova.getActivity(); + + //Get the context + Context context = activity.getApplicationContext(); + + //Get file + File file = new File(this.filesystemPathForURL(inputURL)); + if (file != null) { --- End diff -- What is this comparison for? I'm pretty sure that `new` can't ever return `null`. It also doesn't check for file existence; you'd want `file.exists()` for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Downloading the cordova 3.5.1 files when adding android platform using 3.5.0
You need to install the Android SDK for API level 19. Use the Android SDK Manager to install it. You can open it by Start->Run "android" On Wed, Sep 17, 2014 at 9:04 AM, Surinaidu Majji wrote: > I am developing an app using cordova 3.5.0 by using android-4.4.2 with an > api level 19. > It was working fine till morning but suddenly i am getting the following > error, > I know that the cordova 3.5.1 got released. I did not update my cordova > version also and i have checked the version which is still 3.5.0. > > Can any body have any idea regarding this error? > > D:\ClonedMobWorkspace\mobiledev>cordova platform add android > Creating android project... > > > > C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:126 > throw e; > ^ > Error: Please install Android target 19 (the Android newest SDK). Make > sure you have the latest Android tools installed as well. Run "android" > from your command-line to install/update any missing SDKs or tools. > at > > C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\lib\check_reqs.js:80:29 > at _fulfilled > > (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:798:54) > at self.promiseDispatch.done > > (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:827:30) > at Promise.promise.promiseDispatch > > (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:760:13) > at > > C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:574:44 > at flush > > (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:108:17) > at process._tickCallback (node.js:419:13) > Error: > C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\create.bat: Command > failed with exit code 8 > at ChildProcess.whenDone > > (C:\Users\Admin\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\superspawn.js:135:23) > at ChildProcess.emit (events.js:98:17) > at maybeClose (child_process.js:755:16) > at Process.ChildProcess._handle.onexit (child_process.js:822:5) > > If you see error above some how it is downloading 3.5.1 when adding the > platform even i installed 3.5.0 >
Re: [Vote] Tools Release 3.6.3-0.2.12
On Tue, Sep 16, 2014 at 10:14 PM, Marcel Kinard wrote: > I've been doing some playing around to understand this better. Here are > the 3 scenarios I tried: > > 1) link: > cd cordova-lib > rm -r node_modules > rm npm-shrinkwrap.json > npm link cordova-js > npm install > npm shrinkwrap > > Result is that ALL the devDependencies from cordova-js are present in the > cordova-lib shrinkwrap.json file. Bad. > > 2) directory install: > cd cordova-lib > rm -r node_modules > rm npm-shrinkwrap.json > npm install ../cordova-js > npm install > npm shrinkwrap > > We've been bit before by this scenario as well. I believe the shrinkwrap will record that cordova-js is located at "../cordova-js" instead of from the registry in this case. > Result is that none of the devDependencies from cordova-js are present in > the cordova-lib shrinkwrap.json file. Good. > > 3) registry install: > cd cordova-lib > rm -r node_modules > rm npm-shrinkwrap.json > npm install cordova-js (fetches from registry) > ^^ Shouldn't need this step right? since "npm install" will grab it from the registry anyways. > npm install > npm shrinkwrap > > Result is that none of the devDependencies from cordova-js are present in > the cordova-lib shrinkwrap.json file. Good. > > So what I get from this is that having a linked dependency matters: the > shrinkwrap command will grab everything in the submodule's directory tree > even if it isn't listed as a dependency in the submodule's package.json. > That feels like a flaw in the shrinkwrap command, especially when the > shrinkwrap command is careful to check that the main module's node_modules > matches its package.json dependencies. It seems to be treating the main > module and the submodules differently. > > On Sep 16, 2014, at 9:56 PM, Andrew Grieve wrote: > > >> It shouldn't matter if I had done an "npm link cordova-js" inside of > >> cordova-lib, correct? > > > > This is the key! It *does* matter. shrinkwrap just records what it finds > in > > your node_modules directory, symlinks and all! You always want to do a > > fresh rm -r & npm install before shrinkwrap to ensure you don't have > > extraneous modules in there. > > > > That said, if you did that and it's still showing up, I don't know why > that > > is :S > > I did NOT clean out the node_modules before doing the shrinkwrap. My "npm > link" is present. I wasn't aware this was necessary, and there isn't > anything in the instructions about it. > > Now that I know what to do, I'll update the instructions and respin the > lib, plugman, and cli RCs. I've done it this many times, what's once more? > :-/ > Def. thanks for updating the instructions and for your patience. We all appreciate it! > > On Sep 16, 2014, at 9:25 PM, Carlos Santana wrote: > > > By default, npm install will install all modules listed as dependencies. > > With the --production flag, npm will not install modules listed in > > devDependencies. > > I did try "npm -g install --production cordova@rc" and it is still > pulling in the devDependencies from cordova-js. > > > I will just ignore the Warning on connect and not respin. > > I'm a perfectionist, and don't want to see user confusion about the > warning. > > On a broader note, we definitely need to change how we handle the > shrinkwrap BEFORE the release process. I'll send out a note tomorrow with > some ideas. > >
Downloading the cordova 3.5.1 files when adding android platform using 3.5.0
I am developing an app using cordova 3.5.0 by using android-4.4.2 with an api level 19. It was working fine till morning but suddenly i am getting the following error, I know that the cordova 3.5.1 got released. I did not update my cordova version also and i have checked the version which is still 3.5.0. Can any body have any idea regarding this error? D:\ClonedMobWorkspace\mobiledev>cordova platform add android Creating android project... C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:126 throw e; ^ Error: Please install Android target 19 (the Android newest SDK). Make sure you have the latest Android tools installed as well. Run "android" from your command-line to install/update any missing SDKs or tools. at C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\lib\check_reqs.js:80:29 at _fulfilled (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:798:54) at self.promiseDispatch.done (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:827:30) at Promise.promise.promiseDispatch (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:760:13) at C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:574:44 at flush (C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\node_modules\q\q.js:108:17) at process._tickCallback (node.js:419:13) Error: C:\Users\Admin\.cordova\lib\android\cordova\3.5.1\bin\create.bat: Command failed with exit code 8 at ChildProcess.whenDone (C:\Users\Admin\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\superspawn.js:135:23) at ChildProcess.emit (events.js:98:17) at maybeClose (child_process.js:755:16) at Process.ChildProcess._handle.onexit (child_process.js:822:5) If you see error above some how it is downloading 3.5.1 when adding the platform even i installed 3.5.0
[GitHub] cordova-plugin-camera pull request: CB-7423 do cleanup after copyI...
Github user eymorale closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: CB-7565 add debugging guide for iOS wit...
Github user eymorale closed the pull request at: https://github.com/apache/cordova-docs/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: CB-5921
On 16 Sep,2014, at 20:07 , Shazron wrote: > Thanks Erik, > I'll take a look soon. As long as it addresses the points I've been making > in the issue (wrt plugins) it would be fine -- the target is by 4.0 release It doesn’t do that yet, but I’m working on it. Expect a PR for that soon > I would think for using workspaces. Yes, Swift is only supported with iOS 7 > and up, so a Swift developed plugin needs to have as an engine tag value > the Cordova release that supports iOS 7 and up. > When users want to use swift for developing plugins we could have a xcconfig that changes the target, maybe? > We haven't broached the subject of dropping iOS 6 support, but generally we > do only want to support the current and previous iOS release -- but we'll > let the list know if there are any concerns. > That will be iOS 8 and 7 soon :)
[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...
GitHub user Clafou opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26 Added support for iPhone 6 and iPhone 6 Plus resolutions The iPhone 6 and iPhone 6 Plus brings new resolutions for the splash screen. Taking the same approach as with the iPhone 5 (image name postfixed -568h), i.e. using the postfixes -667h and -736h for iPhone 6 and iPhone 6 Plus respectively. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Clafou/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 13e1c22d10a29169d5c5cfedd0eff7f611b2803c Author: Clafou Date: 2014-09-17T09:47:56Z Added support for iPhone 6 and iPhone 6 Plus resolutions (images postfixed -667h and -736h respectively) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---