[GitHub] cordova-plugin-inappbrowser pull request: Windows platform fixes
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-7639 Notification.confirm(...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: Medic improvenents
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar commit comment: d9a8528c8baaa1b94efa0b0ef...
Github user purplecabbage commented on commit d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1: https://github.com/apache/cordova-plugin-statusbar/commit/d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1#commitcomment-8548965 In www/statusbar.js: In www/statusbar.js on line 76: This turns "#33" into "##33" and do nothing to fix a value of "33" The original goal of this code was to add the '#' if it was not there. I think you meant !== --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: introduction
Welcome Jonathan ! On Wed, Nov 12, 2014 at 10:31 AM Michal Mocny wrote: > Hi Jonathan! > > Seems you've been a lurker on these lists for a while and have helped > submit issues in the past. Thanks for signing up to contribute directly. > > -Michal > > On Wed, Nov 12, 2014 at 9:51 AM, Li, Jonathan wrote: > > > Hi all, > > > > I'm getting myself set up as a contributor to Cordova. So far I've just > > been working on projects that use Cordova, but I hope to contribute back > to > > Cordova in the future. > > > > The first change I plan to make is fixing bug CB-3071, so iOS cordova app > > does not need to use SDURLCache as a workaround for this issue. Few > crashes > > have been reported in SDURLCache code, and it is better to fix the issue > in > > cordova and get rid of SDURLCache from the project. > > > > Regards, > > Jonathan > > > > >
[GitHub] cordova-plugin-statusbar pull request: CB-7986 Add cordova-plugin-...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar commit comment: d9a8528c8baaa1b94efa0b0ef...
Github user purplecabbage commented on commit d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1: https://github.com/apache/cordova-plugin-statusbar/commit/d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1#commitcomment-8548974 In www/statusbar.js: In www/statusbar.js on line 76: Nevermind, just saw the later commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-lib/pull/119#issuecomment-62823008 ping @clelland @agrieve Could you please help to take a look, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Questions re: plugin variables
I know it seems confusing, but the tag inside the tag is just some xml insertion into the config.xml file that is specified, but is not related to the tag specified for plugin.xml. It is the tag for config.xml. It should behave as specified in the Plugin Spec [1], when inside tags, except for what I explained above. Answering your points: 1) Yes, it ignores the value attribute, only 'name' is applicable per the spec. 2) They shouldn't be ignored if inside the node, seems to be a bug (unless the tool is smart enough to know if the variable is actually being used and not prompt -- but that seems to be bad design) [1] http://cordova.apache.org/docs/en/4.0.0/plugin_ref_spec.md.html#Plugin%20Specification On Fri, Nov 7, 2014 at 7:18 AM, Horn, Julian C wrote: > Leo's question really hasn't been answered yet. Let me try to make this > more concrete and see if anyone can explain whether the current behavior of > the CLI is correct or not. > > The plugin.xml in the StatusBar plugin contains the following content: > > ... > > . > ... > > > There are several mysteries here. > > 1) What does it mean if the name attribute of a preference tag does not > obey the "only capital letters, digits, or underscores" rule? Apparently > it can never cause variable replacement. > 2) What does the value attribute mean? Does this supply a default value > for a variable if the variable is not mentioned in the --variable flag > (thus making the variable "optional")? > 3) Where can tags legally appear? Must they be outside of > tags, or can they be inside tags or even inside > tags? > > Our experiments with CLI 4.0.1-dev show the following: > > 1) The value attribute is ignored by the CLI, or at least it doesn't > create a default value. > > For example, suppose you put the following preference tag outside of any > tag. > > We found that the user is still required to supply --variable API_KEY, > which means that "my-api-key" never becomes the value of API_KEY. > > 2) tags appear to be ignored by the CLI if they appear below > a node. > > If you move the node shown above from outside a > node to inside a node, then the CLI stops prompting for a > --variable flag and $API_KEY is not replaced by anything. > > It looks to us like the tag is overloaded. When it appears > outside the tag it defines a variable. When it appears inside a > tag it does not. The meaning of the tag within a > tag is apparently determined by the platform. > > If people agree that this is correct then the documentation can be updated > accordingly. However, we did see some code in the implementation that > seemed to be looking for tags inside of tags. It > seems like this isn't working as intended, but then again we can't figure > out what the intention is. > > Julian > > -Original Message- > From: Marcel Kinard [mailto:cmarc...@gmail.com] > Sent: Friday, November 07, 2014 9:42 AM > To: dev@cordova.apache.org > Subject: Re: Questions re: plugin variables > > If there is a reasonable question from a user, it should probably be added > to the docs (assuming it's not already there). > > Leo, would you like to do a pull request? > > On Nov 5, 2014, at 8:24 PM, Mark Koudritsky wrote: > > > Variables should to be provided when adding the plugin > > E.g: > > > >cordova plugin add org.some.plugin --variable API_KEY=some_value > > > > Example of a plugin that uses variables: > > http://plugins.cordova.io/#/package/com.phonegap.plugins.facebookconne > > ct > > > > Relevant places in the code in cordova-lib: > > Where variables are checked during plugin add: > > > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cord > > ova/plugin.js#L126 > > > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plug > > man/install.js#L296 > > > > Here each variable is replaced with its value when generating the > > "config munge" which is an object that describes changes that need to > > be applied to the platform dir. > > > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plug > > man/util/config-changes.js#L368 > > > > > > On Wed, Nov 5, 2014 at 5:28 PM, Treggiari, Leo > > > > wrote: > > > >> I'm having a hard time understanding exactly how plugin variables work. > >> It's probably a level of detail that only plugin developers and tool > >> developers need to be concerned about. I'd appreciate it if someone > >> can give me the answers. > >> > >> 1. "variables can be indicated by a dollar-sign followed by a series > >> of capital letters, digits, or underscores." > >> "To make the variable mandatory, the tag needs to > >> contain a tag." > >> Does this mean that there are optional and required variables - i.e? > >> - A variable reference is defined by a lexical element which > >> begins with a $ and is followed only by capital letters, digits, or > underscores? > >> - A variable is made mandatory by the presence of a > >> tag
[GitHub] cordova-plugins pull request: Updated Plugin to iOS 8
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugins/pull/16#issuecomment-62795139 Thanks Felipe, Before this can be pulled in - we need you to sign the Apache iCLA: http://www.apache.org/licenses/icla.txt Once I receive confirmation, I'll pull this in right away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-7971 Add cordova-plugin-battery-stat...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/246 CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7971) [Related PR with the implementation](https://github.com/apache/cordova-plugin-battery-status/pull/19) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-7971 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #246 commit 1306bef0fabb56a60068588a0f5076256305b341 Author: daserge Date: 2014-11-12T19:08:34Z CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Updated the platforms support table --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-7970 Add cordova-plugin-vibration su...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/245 CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7970) [Related PR with the implementation](https://github.com/apache/cordova-plugin-vibration/pull/25) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-7970 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/245.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #245 commit 7a3f6b9b9b4ff3330f65668f51c5ec4934dfe697 Author: daserge Date: 2014-11-12T18:47:56Z CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 Updated the platforms support table --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-7977 Mention deviceready...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7977 Mention deviceready in p...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-globalization pull request: CB-7977 Mention devicer...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-7977 Mention devicere...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-orientation pull request: CB-7977 Mention de...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-7977 Mention deviceready...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-console pull request: CB-7977 Mention deviceready i...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-7977 Mention deviceready in ...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-7977 Mention deviceready i...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-7977 Mention devicerea...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: CB-7977 Mention devicer...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-7977 Mention deviceready in...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-7977 Mention devicer...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-7977 Mention deviceready ...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-7977 Mention devicer...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-62753473 Thanks, I'll consider it when reviewing tests for windows phone 8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Tools Release, take 3
Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-7988 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ And to npm under @rc tag To test them out you can use: npm -g uninstall cordova npm -g install cordova@rc The packages were published from their corresponding git tags: cordova-js: 3.7.2 (7afadfc044) cordova-lib: 4.1.2 (83a2f3779f) cordova-plugman: 0.22.16 (d674ecf98e) cordova-cli: 4.1.2 (58b59ea786) Upon a successful vote I will upload the archives to dist/, publish them to NPM (under @latest tag), and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md I vote +1: * Ran coho audit-license-headers over the relevant repos * tested with npm test and mobilespec on Android
Re: [VOTE] Tools Release, take 3
Please also review the updated blog post: https://github.com/cordova/apache-blog-posts/blob/master/2014-11-10-tools-release.md
Re: Fix for `cordova emulate ios` to support iPhone 6
Hi Seth, The run script does not exist in the cordova-cli, it exists in the cordova-ios repo, and I believe this issue has already been fixed in 3.7.0. On Tue, Nov 11, 2014 at 5:24 PM, Seth Voltz wrote: > Hello, > > I just started with Cordova and wanted to keep everything on the CLI so I > can run the build and emulate cycle without having to open Xcode. In order > to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to > use ios-sim 3.x’s —devicetypeid syntax. > > I have attached it here but I would like to contribute this back to the > community as well. Is the only channel for submitting fixes through Jira or > can I fork on GitHub and submit a pull request? > > Thanks! > > – Seth > > > >
Re: introduction
Hi Jonathan! Seems you've been a lurker on these lists for a while and have helped submit issues in the past. Thanks for signing up to contribute directly. -Michal On Wed, Nov 12, 2014 at 9:51 AM, Li, Jonathan wrote: > Hi all, > > I'm getting myself set up as a contributor to Cordova. So far I've just > been working on projects that use Cordova, but I hope to contribute back to > Cordova in the future. > > The first change I plan to make is fixing bug CB-3071, so iOS cordova app > does not need to use SDURLCache as a workaround for this issue. Few crashes > have been reported in SDURLCache code, and it is better to fix the issue in > cordova and get rid of SDURLCache from the project. > > Regards, > Jonathan > >
Re: introduction
Welcome Jonathan! Looking forward to your first pull request. Your iCLA was just received today as well -- good timing. On Wed, Nov 12, 2014 at 6:51 AM, Li, Jonathan wrote: > Hi all, > > I'm getting myself set up as a contributor to Cordova. So far I've just > been working on projects that use Cordova, but I hope to contribute back to > Cordova in the future. > > The first change I plan to make is fixing bug CB-3071, so iOS cordova app > does not need to use SDURLCache as a workaround for this issue. Few crashes > have been reported in SDURLCache code, and it is better to fix the issue in > cordova and get rid of SDURLCache from the project. > > Regards, > Jonathan > >
Re: Fix for `cordova emulate ios` to support iPhone 6
Here is the file history: https://github.com/apache/cordova-ios/commits/master/bin/templates/scripts/cordova/run Thank you however for contributing! I would encourage you to file pull requests in the future. The repo itself has a CONTRIBUTING.md with guidelines. Each pull request should be accompanied by a JIRA issue as well. On Wed, Nov 12, 2014 at 7:23 AM, Shazron wrote: > Hi Seth, > The run script does not exist in the cordova-cli, it exists in the > cordova-ios repo, and I believe this issue has already been fixed in 3.7.0. > > On Tue, Nov 11, 2014 at 5:24 PM, Seth Voltz wrote: > >> Hello, >> >> I just started with Cordova and wanted to keep everything on the CLI so I >> can run the build and emulate cycle without having to open Xcode. In order >> to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to >> use ios-sim 3.x’s —devicetypeid syntax. >> >> I have attached it here but I would like to contribute this back to the >> community as well. Is the only channel for submitting fixes through Jira or >> can I fork on GitHub and submit a pull request? >> >> Thanks! >> >> – Seth >> >> >> >> >
Fix for `cordova emulate ios` to support iPhone 6
Hello,I just started with Cordova and wanted to keep everything on the CLI so I can run the build and emulate cycle without having to open Xcode. In order to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to use ios-sim 3.x’s —devicetypeid syntax.I have attached it here but I would like to contribute this back to the community as well. Is the only channel for submitting fixes through Jira or can I fork on GitHub and submit a pull request?Thanks! – Seth run Description: Binary data
introduction
Hi all, I'm getting myself set up as a contributor to Cordova. So far I've just been working on projects that use Cordova, but I hope to contribute back to Cordova in the future. The first change I plan to make is fixing bug CB-3071, so iOS cordova app does not need to use SDURLCache as a workaround for this issue. Few crashes have been reported in SDURLCache code, and it is better to fix the issue in cordova and get rid of SDURLCache from the project. Regards, Jonathan
Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP
vulcanize does not work when inline script depends on the order of the scripts. vulcanize just extracts all inline script and includes vulcanize.js at the end of the html body var B = A; would not work because that becomes // ReferenceError B is not defined // var B = A; 2014-11-12 14:35 GMT+01:00 Michal Mocny : > We could add to > the default template, or create a plugin that injects it automatically and > try to get developers to install that plugin. > > This has some benefits for security of cordova apps and has been brought up > on these lists in that context (very recently by Ian's whitelist -> plugin > thread). > > Finally, perhaps you can use the `vulcanize --csp` tool to externalize > scripts automatically? (This issue applies to chrome apps, and vulcanize is > used to solve the problem with web component inline scripts). > > -Michal > > On Wed, Nov 12, 2014 at 7:09 AM, Frederik Braun > wrote: > > > Hi, > > > > I am not very involved with Cordova, but as far as I understand, Cordova > > Apps are allowed to use eval, inline scripts etc. > > > > We do not allow this in Firefox OS [1] and I am concerned that it may > > cause some friction when porting existing Cordova apps to Firefox OS and > > then realizing that a lot of scripts needs rewriting to comply with our > > Content Security Policy (CSP). > > > > > > Is there anything we can do to remove this friction? My first intuition > > would be some sort of warning that is emitted when building an app that > > uses one of those patterns. > > > > What do you think? > > > > > > > > Thanks! > > Frederik > > > > [1] > > > > > https://developer.mozilla.org/en-US/Apps/Build/installable_apps_for_Firefox_OS/CSP > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP
I'm not familiar enough with the FirefoxOS architecture, but on Android, we had also considered the possibility of injecting a Content-Security-Policy in the response header for the application's start page -- this would be more secure, arguably, than a tag. The biggest problem is that that trick only works on the initial page load; if you have a multi-page app, then you don't get the chance to do that for subsequent pages, but that's an android-specific limitation. (It's something that we will be able to do soon for iOS, since it looks like we're going to control the entire HTTP process.) On Wed Nov 12 2014 at 8:54:23 AM Frederik Braun wrote: > Response inline > > On 12.11.2014 14:35, Michal Mocny wrote: > > We could add to > > the default template, or create a plugin that injects it automatically > and > > try to get developers to install that plugin. > > > > This has some benefits for security of cordova apps and has been brought > up > > on these lists in that context (very recently by Ian's whitelist -> > plugin > > thread). > > > > Meta CSP is quite a nice idea, yet we're unfortunately lacking support > in Firefox (and Firefox OS) so far > (https://bugzilla.mozilla.org/show_bug.cgi?id=663570). > > I was thinking that some sort of early feedback (i.e. build step > warning) could help avoiding these patterns when app developement has > *just* started. > > > Finally, perhaps you can use the `vulcanize --csp` tool to externalize > > scripts automatically? (This issue applies to chrome apps, and vulcanize > is > > used to solve the problem with web component inline scripts). > > > > That's an interesting suggestion, thanks! > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Whitelist breakout update
Sorry for dropping this thread for a week; let me see if I can address that -- By default, for brand new apps created with Cordova 4.x with no plugins, those will be blocked (this includes protocols like tel: and mailto:) . This was considered to be a security issue earlier this year, and we put measures unto Cordova 3.5.1 to ensure that Cordova apps couldn't launch other intents without the app author's cooperation. (This makes Cordova apps a bit more like native apps, and a bit less like websites, when displaying external content, which is probably a good thing re: security) If you add the cordova-legacy-whitelist plugin, then you get back exactly the same level of control that you had with Cordova, say, 3.7.0, and the goal is that you don't have to do anything else to get backwards compatibility. If you find any regressions, bring them up on the list or in JIRA, and we should be able to resolve them. (Hopefully before 4.0.0 is released). Any other behaviour that you need should be possible through a plugin; whether that means a custom one for your app, or something from the community that hundreds of other devs use, I don't know :) On Tue Nov 04 2014 at 11:11:57 AM Frederico Galvão < frederico.gal...@pontoget.com.br> wrote: > I understand and am already familiar with the configuration for external > URLs that do not interfere/launch third party apps or intents. > I just want to understand better what's gonna happen with the custom > protocols I call, like tel: or mailto:, or even URLs that have custom > handlers on each platform. > > 2014-11-04 14:03 GMT-02:00 Ian Clelland : > > > On Tue Nov 04 2014 at 10:46:52 AM Frederico Galvão < > > frederico.gal...@pontoget.com.br> wrote: > > > > > So we actually have 4 new plugins: > > > org.apache.cordova.whitelist > > > org.apache.cordova.legacy-whitelist > > > org.apache.cordova.navigation-whitelist > > > org.apache.cordova.intent-whitelist > > > > > > > I think that org.apache.cordova.legacy-whitelist is a better name for > what > > I have published at https://github.com/clelland/cordova-plugin-whitelist > > as > > org.apache.cordova.whitelist. > > > > So where I had a single plugin implementing the old behaviour, Andrew has > > suggested releasing three plugins: legacy-whitelist, which is what I > > implemented; and two new ones: navigation-whitelist, which implements > > navigation control, and intent-whitelist, which would control launching > > external apps. > > > > (And there's also the very sound advice of "just skip the whitelist > plugins > > and use CORS if you can get away with it") > > > > > > > > Right? > > > > > > If that's the case, then this is not entirely true: > > > > > > If what > > > > you want is no change at all in behaviour, then your upgrade should > be > > > > just: > > > > > > > > cordova plugin add org.apache.cordova.whitelist > > > > > > > > There would be no configuration changes to make: the plugin reads the > > old > > > > access tags, just as before, and applies the same policies based on > > them > > > > that it did in 3.6. > > > > > > > > > > > > > The messaging is still simple, if all you want is backwards > compatibility, > > but if you want something better, then the instructions are more > > complicated, and depend on your actual needs. > > > > > > > > > > 2014-11-04 2:13 GMT-02:00 Andrew Grieve : > > > > > > > Since the whitelist plugin blocks only a subset of sub-resource loads > > > (just > > > > like the existing whitelists), I think we really want to call out > that > > > > people should not just include the backwards-compatible plugin. > Here's > > a > > > > stab at messaging: > > > > > > > > > > > > If you want nothing to change, use org.apache.cordova.legacy- > whitelist. > > > If > > > > you care about security, then please understand that there are three > > > types > > > > of whitelists to consider: > > > > > > > > 1. Network traffic - The whitelist has never been able to fully block > > all > > > > network requests in this manner (on iOS and Android). Instead, we > > > recommend > > > > using in your , which is supported on Android 4.4 and iOS 7. > > > > > > > > 2. Navigation - By default the webview is allowed to navigate to any > > page > > > > within the same directory tree as the start page. If you'd like to > > > navigate > > > > to a different directory, or to a http(s) address, then you should > use > > > > org.apache.cordova.navigation-whitelist. > > > > > > > > 3. Intents - By default all URLs that cause an external action (e.g. > > > tel:, > > > > sms:, etc) are disabled. If you need to use any of these, then you > > should > > > > use org.apache.cordova.intent-whitelist. > > > > > > > > > > > > On Mon, Nov 3, 2014 at 10:08 PM, Ian Clelland < > iclell...@chromium.org> > > > > wrote: > > > > > > > > > On Mon Nov 03 2014 at 4:05:51 PM Marcel Kinard > > > > > wrote: > > > > > > > > > > > This sounds very interesting and relatively graceful. > > > > > > > > > > > > For a user upgrading to this new
Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP
Response inline On 12.11.2014 14:35, Michal Mocny wrote: > We could add to > the default template, or create a plugin that injects it automatically and > try to get developers to install that plugin. > > This has some benefits for security of cordova apps and has been brought up > on these lists in that context (very recently by Ian's whitelist -> plugin > thread). > Meta CSP is quite a nice idea, yet we're unfortunately lacking support in Firefox (and Firefox OS) so far (https://bugzilla.mozilla.org/show_bug.cgi?id=663570). I was thinking that some sort of early feedback (i.e. build step warning) could help avoiding these patterns when app developement has *just* started. > Finally, perhaps you can use the `vulcanize --csp` tool to externalize > scripts automatically? (This issue applies to chrome apps, and vulcanize is > used to solve the problem with web component inline scripts). > That's an interesting suggestion, thanks! - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP
We could add to the default template, or create a plugin that injects it automatically and try to get developers to install that plugin. This has some benefits for security of cordova apps and has been brought up on these lists in that context (very recently by Ian's whitelist -> plugin thread). Finally, perhaps you can use the `vulcanize --csp` tool to externalize scripts automatically? (This issue applies to chrome apps, and vulcanize is used to solve the problem with web component inline scripts). -Michal On Wed, Nov 12, 2014 at 7:09 AM, Frederik Braun wrote: > Hi, > > I am not very involved with Cordova, but as far as I understand, Cordova > Apps are allowed to use eval, inline scripts etc. > > We do not allow this in Firefox OS [1] and I am concerned that it may > cause some friction when porting existing Cordova apps to Firefox OS and > then realizing that a lot of scripts needs rewriting to comply with our > Content Security Policy (CSP). > > > Is there anything we can do to remove this friction? My first intuition > would be some sort of warning that is emitted when building an app that > uses one of those patterns. > > What do you think? > > > > Thanks! > Frederik > > [1] > > https://developer.mozilla.org/en-US/Apps/Build/installable_apps_for_Firefox_OS/CSP > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[GitHub] cordova-plugin-camera pull request: cameraDirection option fix in ...
GitHub user lgrignon opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/54 cameraDirection option fix in Android Uses Android Camera API, which in API level 9, received some feature detection abilities. A custom activity has been created to control the camera and offer something similar to the the standard Android camera app. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lgrignon/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit e9eaef41b2595574c8335917ec28d168f51ed95f Author: unknown Date: 2014-11-12T11:37:40Z Use Android Camera API to change / select / preview camera, fixes the unability to select back or front camera on android 2.3+ commit fb2d99fab72ff0a8e59abaeb8644f6872f859bfd Author: unknown Date: 2014-11-12T11:59:21Z removed useless comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Typo in android gitignore (ant-built...
Github user stefan-dimitrov-clouway commented on the pull request: https://github.com/apache/cordova-android/pull/129#issuecomment-62710907 Why is this still not merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP
Hi, I am not very involved with Cordova, but as far as I understand, Cordova Apps are allowed to use eval, inline scripts etc. We do not allow this in Firefox OS [1] and I am concerned that it may cause some friction when porting existing Cordova apps to Firefox OS and then realizing that a lot of scripts needs rewriting to comply with our Content Security Policy (CSP). Is there anything we can do to remove this friction? My first intuition would be some sort of warning that is emitted when building an app that uses one of those patterns. What do you think? Thanks! Frederik [1] https://developer.mozilla.org/en-US/Apps/Build/installable_apps_for_Firefox_OS/CSP - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
