[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/29#discussion_r24392364
--- Diff: src/build/makers/ios.js ---
@@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir,
sha, devices, entry_poin
function log(msg) {
console.log('[IOS] ' + msg + ' (sha: ' + sha + ')');
}
-if (keychain_location.length === 0 || keychain_password.length === 0) {
-log('No keychain information. Fill that out in config.json if you
want to build for iOS.');
+log('starting iOS prepare');
+try {
+var projectWww = path.join(output, 'www');
+// add the medic configuration (sha,host) to destination folder
+var
medic_config='{"sha":"'+sha+'","couchdb":"'+couchdb_cfg.host+'","couchdbext":"'+couchdb_cfg.exthost+'"}';
+fs.writeFileSync(path.join(output, 'www','autotest','pages',
'medic.json'),medic_config,'utf-8');
+
+// modify config.xml
+var configFile = path.join(output, 'mobilespec', 'config.xml');
+fs.writeFileSync(configFile, fs.readFileSync(configFile,
'utf-8').replace(//gi,'http://audio.ibeat.org"; />',
'utf-8'));
+
+} catch(e) {
+error_writer('ios', sha, 'Exception thrown modifying mobile spec
application for iOS.', e.message);
callback(true);
return;
-} else {
-// unlock the chain
- log('setting up keychain');
-var security = shell.exec('security default-keychain -s \'' +
keychain_location + '\' && security unlock-keychain -p \'' + keychain_password
+ '\' \'' + keychain_location+'\'', {silent:true});
-if (security.code > 0) {
-log('keychain setup failed');
-error_writer('ios', sha, 'Could not unlock keychain.',
security.output);
-callback(true);
-} else {
- log('starting iOS prepare');
- try {
-var projectWww = path.join(output, 'www');
-// add the medic configuration (sha,host) to destination folder
-var
medic_config='{"sha":"'+sha+'","couchdb":"'+couchdb_cfg.host+'","couchdbext":"'+couchdb_cfg.exthost+'"}';
-fs.writeFileSync(path.join(output, 'www','autotest','pages',
'medic.json'),medic_config,'utf-8');
+}
+// compile
+log('Compiling.');
+log(output);
-// modify config.xml
-var configFile = path.join(output, 'mobilespec', 'config.xml');
-fs.writeFileSync(configFile, fs.readFileSync(configFile,
'utf-8').replace(//gi,'http://audio.ibeat.org"; />',
'utf-8'));
+var mobileSpecDir = path.join(output, '../', '../');
--- End diff --
Just nitpick: there is no need to add slashes to paths being joined.
`path.join` will handle separators by itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/29#discussion_r24392359
--- Diff: src/build/makers/ios.js ---
@@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir,
sha, devices, entry_poin
function log(msg) {
console.log('[IOS] ' + msg + ' (sha: ' + sha + ')');
}
-if (keychain_location.length === 0 || keychain_password.length === 0) {
-log('No keychain information. Fill that out in config.json if you
want to build for iOS.');
+log('starting iOS prepare');
+try {
+var projectWww = path.join(output, 'www');
+// add the medic configuration (sha,host) to destination folder
+var
medic_config='{"sha":"'+sha+'","couchdb":"'+couchdb_cfg.host+'","couchdbext":"'+couchdb_cfg.exthost+'"}';
+fs.writeFileSync(path.join(output, 'www','autotest','pages',
'medic.json'),medic_config,'utf-8');
--- End diff --
I thought that `plugin-test-framework` searches for medic.json at `www`
folder
(https://github.com/apache/cordova-medic/blob/master/src/build/makers/windows.js#L84-L86)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73652050 I'm not aware of overall design of save/restore features, but code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73651273 @gorkem Also, this feature does not prevent the other one you mentionned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73641701 Well, if you review the document we all agreed on, it mentions this. Plus, this feature is already in for platforms as well. I'm trying to mirror it : https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41V3-jFc/edit#heading=h.tsqn5em3043l --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73641308 Already done most of it un https://github.com/gorkem/cordova-lib/tree/save_restore_final and https://github.com/gorkem/cordova-cli/tree/save_restore_final.. Still missing --save flag implementation for plugins and tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: [ADD] GET attribute 'version' config.xml...
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/161#issuecomment-73638976 There is a new implementation of restore cooking, which auto restores engines and also does handle the version. As part of that work restore command will vanish completely. You can see the work in progress at https://github.com/gorkem/cordova-lib/tree/save_restore_final --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73638713 -1 since we agreed to have auto restore for plugins I do not think this feature will be used at all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Binary readers wp8
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Binary readers wp8
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-file/pull/100 Binary readers wp8 Implemented some missing functions in WP8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-file BinaryReadersWP8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit 6f630b4b19271a98ea6e896358c0386283104c43 Author: Jesse MacFadyen Date: 2015-02-10T01:27:29Z Added nativeURL property to FileEntry, implemented readAsArrayBuffer and readAsBinaryString commit 5cfe7a05b50c4139c42c0f7d8f4ce0abaa5c3eb1 Author: Jesse MacFadyen Date: 2015-02-10T01:34:39Z Code cleanup, whitespace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73621340 Hey @gorkem, I'm finalising a PR to remove the save command and add/update the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73615544 @vladimir-kotikov, @agrieve and @gorkem , please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
CB-8448 Add support for "activities" field in FirefoxOS manifest.webapp
Hi, I created https://issues.apache.org/jira/browse/CB-8448 A pull request is here: https://github.com/apache/cordova-lib/pull/163 cheers Axel Don't know why Github fails to merge this.
[GitHub] cordova-lib pull request: CB-8448 Add support for "activities" fie...
GitHub user AxelNennker opened a pull request: https://github.com/apache/cordova-lib/pull/163 CB-8448 Add support for "activities" field in FirefoxOS manifest.webapp See https://issues.apache.org/jira/browse/CB-8448 You can merge this pull request into a Git repository by running: $ git pull https://github.com/AxelNennker/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #163 commit c8b1ff3d89c6a6453366139f4c3446c97aa4c43c Author: Axel Nennker Date: 2015-02-09T22:51:11Z CB-8448 Add support for "activities" field in FirefoxOS manifest.webapp commit 3ff6e57d1abf7e41c17d6fe9a93c9b5e56f4ac97 Author: Axel Nennker Date: 2015-02-09T22:55:26Z CB-8448 remove bogus debug output --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/29 [INFRA-8588] Medic stability improvements Using local npm cache for builds. Working around cordova entrypoint on iOS. Making medic just run 'cordova build' and 'cordova run' for iOS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic ios-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit fa95208819206d06b3fb3a25363bb3d36721a4d5 Author: Dmitry Blotsky Date: 2015-02-09T22:51:36Z [INFRA-8588] Using local npm cache for builds. Working around cordova entrypoint on iOS. Making medic just run 'cordova build' and 'cordova run'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Review] plugman createpackagejson
(I commented on the other thread) Left comments inline, but haven't tested. Overall, looks good and I like the approach! On Mon, Feb 9, 2015 at 10:35 AM, Andrew Grieve wrote: > Plan sounds good to me! > > On Fri, Feb 6, 2015 at 7:11 PM, Steven Gill > wrote: > > > Hey All! Figured this should get its own thread > > > > So createpackagejson script is done. I have it all on branch CB-8416. > > > > USAGE: plugman createpackagejson PLUGIN_PATH > > > > Commit: > > > > > https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6 > > > > I am using init-package-json module. So our createpackagejson script > feels > > very much like npm init. It generates defaults based on info from > > plugin.xml. Try it out! > > > > When publishing to CPR, plugman publish will temporarily move an existing > > package.json so it doesn't conflict with the package.json it needs to > > create to publish. > > > > > https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0 > > > > I'd like to push this to master and do a tools release next week. After > the > > plugins release is completed, I will go through our plugins and add > > package.json files to them all. Next plugins release should be published > on > > npm as well as CPR. > > > > Thoughts? > > >
Re: [iOS 8] WKWebView moving forward
Also Xcode 6.3 now *requires* Yosemite. Fair warning to upgrade I suppose for your dev machines and build servers... On Mon, Feb 9, 2015 at 2:13 PM, tommy-carlos williams wrote: > Oh, FFS. > > I give up on Apple solving this, personally. Most apps don’t *actually* need > it (they think they do, but they don’t). I am going to find another way to > solve it for our apps… maybe I will actually have to write a native plugin > for the crypto :( > > -- > tommy-carlos williams > > On 10 February 2015 at 08:18:31, Shazron (shaz...@gmail.com) wrote: > > In other news -- the new Xcode 6.3 beta (iOS 8.3) does *not* contain > the loadFileURL:readAccessURL: selector that we are all waiting for > :'( > https://twitter.com/wkwebview/status/564865657225756672 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Move platform parsers from CLI to platforms
You know, writing out my thoughts has crystallized that I think we should just be shipping the scripts as independent packages instead of bundling directly inside platforms. With that conclusion, I have to re-think what that implies ;) On Mon, Feb 9, 2015 at 5:07 PM, Michal Mocny wrote: > Thoughts: > > 1. I'm happy to require cordova-android@FOO is required to be installed > if you want to prepare a project that was created with it. I think we > should leave a "created-with" file inside the platform artifacts to confirm > this. Possibly it makes in-place upgrades harder, but I think the future > of upgrade is uninstall-update-install or rm -rf && add > > 2. To support older platforms, I suggest we create a new package > (cordova-platform-scripts-legacy?), which simulate as-if old platforms had > scripts embedded. This way, we can write the CLI/LIB tooling parts without > many special cases, and gives us easier ability to polyfill the legacy > scripts to future CLI/LIB api changes. > > 3. Regarding making refactoring harder.. maybe. Or maybe we have > cordova-android depend on cordova-android-scripts and use semver. If the > cordova-android-scripts change, but are backwards compatible, we can push > an update that will automatically be picked up by all older platforms. If > it isn't compatible, then you have a tooling-platform mismatch and have to > upgrade no matter what. > > 4. Agree with assuming everything async -- and personally prefer promises > (they are in io.js by default, node just updated to 0.12, may be there soon > too) -- but I know there were some reservations on this lists about using > them. (We can wrap one way with the other, so lets not bikeshed for now) > > On Mon, Feb 9, 2015 at 9:45 AM, Andrew Grieve > wrote: > >> Been thinking about this as well, and one part I'm not 100% sure about is >> having this logic at create-time vs prepare-time vs plugin-add time. >> >> create-time - easy to see we just put it in cordova-FOO and allow deps >> within package.json >> >> prepare/plugin-add time though, should we relay on having the correct >> version of cordova-FOO around to use, or should we copy this logic into >> platforms/FOO/cordova? >> >> Moving these files into each repo will certainly make refactoring harder. >> E.g., making a change to the API now requires a version check + still >> supporting the old API + also supporting the new API. Still think this is >> worth doing, but I think we should also consider sanity-checking our API >> surface to ensure that it makes the most sense (e.g. all APIs that may >> have >> to do IO should return promises, even if they are sync right now). >> >> >> On Mon, Feb 9, 2015 at 12:42 AM, Mark Koudritsky >> wrote: >> >> > There are 2 main places in the lib with platform specific logic >> > src/cordova/metadata/_parser.js >> > src/plugman/platforms/.js >> > Probably all of this logic should be moved to platforms. >> > >> > On Sun, Feb 8, 2015 at 4:36 AM, Josh Soref >> wrote: >> > >> > > +1 >> > > >> > > Sent from my BlackBerry 10 smartphone. >> > > >> > > >> > >> > >
Re: [iOS 8] WKWebView moving forward
Oh, FFS. I give up on Apple solving this, personally. Most apps don’t *actually* need it (they think they do, but they don’t). I am going to find another way to solve it for our apps… maybe I will actually have to write a native plugin for the crypto :( -- tommy-carlos williams On 10 February 2015 at 08:18:31, Shazron (shaz...@gmail.com) wrote: In other news -- the new Xcode 6.3 beta (iOS 8.3) does *not* contain the loadFileURL:readAccessURL: selector that we are all waiting for :'( https://twitter.com/wkwebview/status/564865657225756672
Re: Move platform parsers from CLI to platforms
Thoughts: 1. I'm happy to require cordova-android@FOO is required to be installed if you want to prepare a project that was created with it. I think we should leave a "created-with" file inside the platform artifacts to confirm this. Possibly it makes in-place upgrades harder, but I think the future of upgrade is uninstall-update-install or rm -rf && add 2. To support older platforms, I suggest we create a new package (cordova-platform-scripts-legacy?), which simulate as-if old platforms had scripts embedded. This way, we can write the CLI/LIB tooling parts without many special cases, and gives us easier ability to polyfill the legacy scripts to future CLI/LIB api changes. 3. Regarding making refactoring harder.. maybe. Or maybe we have cordova-android depend on cordova-android-scripts and use semver. If the cordova-android-scripts change, but are backwards compatible, we can push an update that will automatically be picked up by all older platforms. If it isn't compatible, then you have a tooling-platform mismatch and have to upgrade no matter what. 4. Agree with assuming everything async -- and personally prefer promises (they are in io.js by default, node just updated to 0.12, may be there soon too) -- but I know there were some reservations on this lists about using them. (We can wrap one way with the other, so lets not bikeshed for now) On Mon, Feb 9, 2015 at 9:45 AM, Andrew Grieve wrote: > Been thinking about this as well, and one part I'm not 100% sure about is > having this logic at create-time vs prepare-time vs plugin-add time. > > create-time - easy to see we just put it in cordova-FOO and allow deps > within package.json > > prepare/plugin-add time though, should we relay on having the correct > version of cordova-FOO around to use, or should we copy this logic into > platforms/FOO/cordova? > > Moving these files into each repo will certainly make refactoring harder. > E.g., making a change to the API now requires a version check + still > supporting the old API + also supporting the new API. Still think this is > worth doing, but I think we should also consider sanity-checking our API > surface to ensure that it makes the most sense (e.g. all APIs that may have > to do IO should return promises, even if they are sync right now). > > > On Mon, Feb 9, 2015 at 12:42 AM, Mark Koudritsky > wrote: > > > There are 2 main places in the lib with platform specific logic > > src/cordova/metadata/_parser.js > > src/plugman/platforms/.js > > Probably all of this logic should be moved to platforms. > > > > On Sun, Feb 8, 2015 at 4:36 AM, Josh Soref > wrote: > > > > > +1 > > > > > > Sent from my BlackBerry 10 smartphone. > > > > > > > > >
Re: [Review] Plugins Package.json
Left comments inline, but haven't tested. Overall, looks good and I like
the approach!
On Fri, Feb 6, 2015 at 3:41 PM, Steven Gill wrote:
> Hey All!
>
> So createpackagejson script is done. I have it all on branch CB-8416.
>
> USAGE: plugman createpackagejson PLUGIN_PATH
>
> Commit:
>
> https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6
>
> I am using init-package-json module. So our createpackagejson script feels
> very much like npm init. It generates defaults based on info from
> plugin.xml. Try it out!
>
> When publishing to CPR, plugman publish will temporarily move an existing
> package.json so it doesn't conflict with the package.json it needs to
> create to publish.
>
> https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0
>
> I'd like to push this to master and do a tools release today. After the
> plugins release is completed, I will go through our plugins and add
> package.json files to them all. Next plugins release should be published on
> npm as well as CPR.
>
> Thoughts?
>
> On Wed, Feb 4, 2015 at 1:31 PM, Brian LeRoux wrote:
>
> > love this, having a cordova key is a v good idea while this bakes too
> >
> > On Wed, Feb 4, 2015 at 12:10 PM, Parashuram N (MS OPEN TECH) <
> > panar...@microsoft.com> wrote:
> >
> > > +1 to changing cordova-windows8 to cordova-windows.
> > >
> > > On 2/4/15, 12:05 PM, "Jesse" wrote:
> > >
> > > >Yes, you can skip all the 'windows8' stuff and just use 'windows'.
> > > >windows8 is legacy and slowly all plugins are being migrated to just
> use
> > > >the 'windows' section in plugin.xml
> > > >
> > > >@purplecabbage
> > > >risingj.com
> > > >
> > > >On Wed, Feb 4, 2015 at 11:36 AM, Steven Gill
> > > >wrote:
> > > >
> > > >> I have made the changes you suggested. I like the idea of cordova
> > parent
> > > >> key.
> > > >>
> > > >> I added cordova-windows8 as a keyword but I would like someone from
> > > >> microsoft to chime in about it. My understanding is that windows8 is
> > > >>around
> > > >> for legacy and windows is preferred. Please correct me if I'm wrong.
> > I'd
> > > >> prefer to just list windows and cordova-windows.
> > > >>
> > > >> If anyone else has feedback on the package.json file, please share!
> > You
> > > >>can
> > > >> view it at
> > > >>
> > > >>
> > > >>
> > >
> >
> https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.j
> > > >>son
> > > >>
> > > >> I am working on createpackagejson command now
> > > >> https://issues.apache.org/jira/browse/CB-8416
> > > >>
> > > >> On Tue, Feb 3, 2015 at 5:29 PM, Andrew Grieve >
> > > >> wrote:
> > > >>
> > > >> > From looking at it, only thought is whether we should put all of
> the
> > > >> > non-standard fields into a "cordova" parent key. E.g.:
> > > >> >
> > > >> > {
> > > >> > "name": "cordova-plugin-device",
> > > >> > "cordova": {
> > > >> > "id": "org.apache.cordova.device",
> > > >> > "platforms": [...]
> > > >> > }
> > > >> > }
> > > >> >
> > > >> > Sounds like we need to re-write the file when publishing to CPR
> > > >>anyways,
> > > >> so
> > > >> > transforming from this to what is currently expected can be done
> in
> > > >>that
> > > >> > step.
> > > >> >
> > > >> > Other tidbits:
> > > >> > - windows8 is missing from keywords. Intentional? (not sure if
> > > >>windows is
> > > >> > now an alias?)
> > > >> > - author: might just set this to "Apache"
> > > >> >
> > > >> >
> > > >> > On Tue, Feb 3, 2015 at 7:50 PM, Steven Gill <
> stevengil...@gmail.com
> > >
> > > >> > wrote:
> > > >> >
> > > >> > > Please review at
> > > >> > >
> > > >> > >
> > > >> >
> > > >>
> > > >>
> > >
> >
> https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.j
> > > >>son
> > > >> > >
> > > >> > > You will notice that I added cordova-PLATFORM as a keyword.
> > > >> > >
> > > >> > > I have also kept the platforms tag for now. I can remove it but
> > > >>maybe
> > > >> we
> > > >> > > can find some future use for it. We currently need it when
> > > >>publising to
> > > >> > CPR
> > > >> > > but can add/rm it during plugman publish.
> > > >> > >
> > > >> > > I am going to create a createpackagejson command in plugman that
> > > >>will
> > > >> > build
> > > >> > > something like this from plugin.xml. Other plugin devs will be
> > able
> > > >>to
> > > >> > use
> > > >> > > this command to quickly add package.json files to their plugins.
> > > >> > >
> > > >> > > I will then modify plugman publish to use the createpackagejson
> > > >>command
> > > >> > if
> > > >> > > needed. Plugman publish will still have to add the contents of
> the
> > > >> readme
> > > >> > > (or doc/index.md) to the package.json as well as the platforms
> > tag
> > > >>if
> > > >> we
> > > >> > > decide to remove it. It will also have to change the
> package-name
> > > >>field
> > > >> > to
> > > >> > > package-id when publishing to CPR. Once published, we can remove
> > > >>these
> > > >> > > changes package.json.
> >
[GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6: https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9664080 In cordova-lib/src/plugman/createpackagejson.js: In cordova-lib/src/plugman/createpackagejson.js on line 46: Aside: There are a lot of "if (err) throw err;" statements in node callback code. I've been using Q for a long time and have grown quite fond of Q.nfcall(...).done() where it does this behaviour automatically for me. Just pondering out loud as Promises become available to js by default (as is the case in io.js already).. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6: https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9664041 In cordova-lib/src/plugman/plugman.js: In cordova-lib/src/plugman/plugman.js on line 226: Nit: Pass in `cli_opts.argv.remain[0]` here, and change `createpackagejson` to accept an actual path. If you actually do want multiple args, and want `createpackagejson` to do the arg parsing (I don't think so), then change this variable name here at least to `args`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6: https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9663971 In cordova-lib/src/plugman/init-defaults.js: In cordova-lib/src/plugman/init-defaults.js on line 1: This file is supposed to be a [PromZard](https://github.com/isaacs/promzard) right? Perhaps a comment to this extent, it took a bit of reading to figure this out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6: https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9663882 In cordova-lib/src/plugman/init-defaults.js: In cordova-lib/src/plugman/init-defaults.js on line 13: Nit: newline after brace and before return? Otherwise its unclear that this is a factory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6: https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9663850 In cordova-lib/src/plugman/createpackagejson.js: In cordova-lib/src/plugman/createpackagejson.js on line 48: Cool! Didn't know about require.resolve() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6: https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9663808 In cordova-lib/src/PluginInfo.js: In cordova-lib/src/PluginInfo.js on line 317: Nit: For next time, someArray.map() would have been more succinct and appropriate than in-place modification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Plugin Install Hooks
We did discuss this, and we rejected: 1. Having a prompt 2. Sandboxing Check out the discussion, for reasons: http://markmail.org/message/alknczhqdghaurrw On Mon, Feb 9, 2015 at 8:28 AM, Horn, Julian C wrote: > We have identified a security issue with the recently added feature of > install-time plugin hooks. > > As far as I can tell, there is nothing that prevents creation of a plugin > with a malicious install-time hook script. Adding that plugin to a project > could corrupt the user's host machine. If that project using that plugin is > submitted to a build server, then the build server could be corrupted. > > Yes, you can use lower level plugman scripts to fetch plugins and then > pre-scan them for install time hooks and track down all the dependencies and > scan them too. So this is fixable (on a build server), but it's a lot of > extra work; "cordova plugin add" should not be an unsafe operation. > > I propose that the CLI should check to see if a plugin requires an > install-time hook and require the user to explicitly grant permission before > executing the install hook. A build server would always deny permission. > > Is there something I'm missing here? > > Julian - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [iOS 8] WKWebView moving forward
Some have been asking -- why not use that Telerik plugin? 1. Swizzling will potentially come with some headaches in the future. As it is currently, the Telerik plugin swaps implementations for an AppDelegate function. So whatever changes we have in the AppDelegate function in the future, it will be lost. The plugin could call the old implementation as well (it does not do so currently), but of course this could create problems as is. This would be hard to maintain with potential future changes. 2. The Telerik plugin will not work if you have any file:// url references when using the core Camera and File plugins. The pluggable webview (wkwebview-engine) and local httpserver proposed will have a solution for this (still a work in progress, needs testing). The Telerik plugin can of course copy from our proposed code to solve this problem. Blog post upcoming, I think, where I can just gather all info regarding the planned work -- for the general public and not just us devs. On Mon, Feb 9, 2015 at 11:23 AM, Shazron wrote: > Darryl: That plugin, based on inspection, is based off my work in > progress code (also used to be based off tmp loading, but now uses the > same httpserver method). The major thing I can see they added was > swizzling an AppDelegate method so it can work on any 3.x cordova-ios. > > In other news -- the new Xcode 6.3 beta (iOS 8.3) does *not* contain > the loadFileURL:readAccessURL: selector that we are all waiting for > :'( > https://twitter.com/wkwebview/status/564865657225756672 > > On Wed, Dec 10, 2014 at 10:28 PM, Darryl Pogue wrote: >> On 10 December 2014 at 22:20, Ally Ogilvie wrote: >>> >>> @Brian it's a dark road down that way.. >>> >>> However, the guys at Ludei patched WKWebView and released "WebView+ for >>> iOS" but have not released the source code :( >>> https://github.com/ludei/webview-plus-ios/tree/master/ios/Release-iphoneos >>> >> >> There's also a Telerik plugin for WkWebView support: >> https://github.com/Telerik-Verified-Plugins/WKWebView >> >> It seems to do roughly the same thing that Shazron's been working on >> (serving from a local HTTP server rather than from file). >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Introduction to community
Welcome Prabodh! Check out the wiki: http://wiki.apache.org/cordova/ContributorWorkflow On Mon, Feb 9, 2015 at 12:20 PM, Prabodh Agarwal wrote: > Hi all, > > I am Prabodh Agarwal. I am an undergraduate student of Birla Institute of > Technology and Science, Pilani from India. > This is my first project I would start contributing to. I have introductory > experience with nodeJS and hence motivated me start contributing over here. > I hope to become a meaningful part of this community and get an upward > learning curve with help of all the developers in here. > > Thank you. > Prabodh Agarwal - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/162 CB-8420 'cordova plugin add' should retrieve version, url or local folder from config.xml if none is specified CB-8420 'cordova plugin add' should retrieve version, url or local folder from config.xml if none is specified You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8420 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 6be67b4c6205f4819887bb34553f75e8d142cdd7 Author: Omar Mefire Date: 2015-02-07T02:03:46Z CB-8420 'cordova plugin add' should retrieve version, url or local folder from config.xml if none is specified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Introduction to community
Hi all, I am Prabodh Agarwal. I am an undergraduate student of Birla Institute of Technology and Science, Pilani from India. This is my first project I would start contributing to. I have introductory experience with nodeJS and hence motivated me start contributing over here. I hope to become a meaningful part of this community and get an upward learning curve with help of all the developers in here. Thank you. Prabodh Agarwal
Re: [iOS 8] WKWebView moving forward
Darryl: That plugin, based on inspection, is based off my work in progress code (also used to be based off tmp loading, but now uses the same httpserver method). The major thing I can see they added was swizzling an AppDelegate method so it can work on any 3.x cordova-ios. In other news -- the new Xcode 6.3 beta (iOS 8.3) does *not* contain the loadFileURL:readAccessURL: selector that we are all waiting for :'( https://twitter.com/wkwebview/status/564865657225756672 On Wed, Dec 10, 2014 at 10:28 PM, Darryl Pogue wrote: > On 10 December 2014 at 22:20, Ally Ogilvie wrote: >> >> @Brian it's a dark road down that way.. >> >> However, the guys at Ludei patched WKWebView and released "WebView+ for >> iOS" but have not released the source code :( >> https://github.com/ludei/webview-plus-ios/tree/master/ios/Release-iphoneos >> > > There's also a Telerik plugin for WkWebView support: > https://github.com/Telerik-Verified-Plugins/WKWebView > > It seems to do roughly the same thing that Shazron's been working on > (serving from a local HTTP server rather than from file). > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Plugins Release
I can't even "svn up" on it right now. Think it's just having an outage. On Mon, Feb 9, 2015 at 11:19 AM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > Hi guys, > > It looks like there is something wrong with access rules or something. > I cannot access https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ > It says: 403 Forbidden > Can someone open access to it? > > Thanks, > Alexander Sorokin > > -Original Message- > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew > Grieve > Sent: Monday, February 9, 2015 18:05 > To: dev > Subject: [VOTE] Plugins Release > > Please review and vote on the release of this plugins release. > > Release issue: https://issues.apache.org/jira/browse/CB-8429 (contains > release notes for all plugins) > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ > > They are the same as last week except for file-transfer. > > The packages were published from their corresponding git tags: > > cordova-plugin-battery-status: 0.2.12 (ec59ef11a5) > cordova-plugin-camera: 0.3.5 (799ed580d3) > cordova-plugin-console: 0.2.13 (7507b29527) > cordova-plugin-contacts: 0.2.16 (95d4d176f3) > cordova-plugin-device-motion: 0.2.11 (110b27671f) > cordova-plugin-device-orientation: 0.3.11 (d8fd79b2ae) > cordova-plugin-device: 0.3.0 (4330db87b9) > cordova-plugin-dialogs: 0.3.0 (d12008f9cd) > cordova-plugin-file-transfer: 0.5.0 (1882bfbd2d) > cordova-plugin-file: 1.3.3 (b05bcff378) > cordova-plugin-geolocation: 0.3.12 (ccab812a49) > cordova-plugin-globalization: 0.3.4 (6b1e88d534) > cordova-plugin-inappbrowser: 0.6.0 (90d41e87ce) > cordova-plugin-media: 0.2.16 (10df21dea8) > cordova-plugin-media-capture: 0.3.6 (cc779375e3) > cordova-plugin-network-information: 0.2.15 (81037e29cf) > cordova-plugin-splashscreen: 1.0.0 (a9f0faa499) > cordova-plugin-vibration: 0.3.13 (25217db403) > cordova-plugin-statusbar: 0.1.10 (5feffc9314) > cordova-plugins: file-system-roots-0.1.0 (be0a4c6cfb) > cordova-plugin-test-framework: 0.0.1 (6aad294699) > > > Upon a successful vote I will upload the archives to dist/, upload them to > the Plugins Registry, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 24 hours. > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ran mobile-spec on android, and made sure it compiled for iOS. There > were only 2 failures in media, and I verified that the same 2 errors happen > with the previous plugin version >
Plugin Install Hooks
We have identified a security issue with the recently added feature of install-time plugin hooks. As far as I can tell, there is nothing that prevents creation of a plugin with a malicious install-time hook script. Adding that plugin to a project could corrupt the user's host machine. If that project using that plugin is submitted to a build server, then the build server could be corrupted. Yes, you can use lower level plugman scripts to fetch plugins and then pre-scan them for install time hooks and track down all the dependencies and scan them too. So this is fixable (on a build server), but it's a lot of extra work; "cordova plugin add" should not be an unsafe operation. I propose that the CLI should check to see if a plugin requires an install-time hook and require the user to explicitly grant permission before executing the install hook. A build server would always deny permission. Is there something I'm missing here? Julian
RE: [VOTE] Plugins Release
Hi guys, It looks like there is something wrong with access rules or something. I cannot access https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ It says: 403 Forbidden Can someone open access to it? Thanks, Alexander Sorokin -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, February 9, 2015 18:05 To: dev Subject: [VOTE] Plugins Release Please review and vote on the release of this plugins release. Release issue: https://issues.apache.org/jira/browse/CB-8429 (contains release notes for all plugins) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ They are the same as last week except for file-transfer. The packages were published from their corresponding git tags: cordova-plugin-battery-status: 0.2.12 (ec59ef11a5) cordova-plugin-camera: 0.3.5 (799ed580d3) cordova-plugin-console: 0.2.13 (7507b29527) cordova-plugin-contacts: 0.2.16 (95d4d176f3) cordova-plugin-device-motion: 0.2.11 (110b27671f) cordova-plugin-device-orientation: 0.3.11 (d8fd79b2ae) cordova-plugin-device: 0.3.0 (4330db87b9) cordova-plugin-dialogs: 0.3.0 (d12008f9cd) cordova-plugin-file-transfer: 0.5.0 (1882bfbd2d) cordova-plugin-file: 1.3.3 (b05bcff378) cordova-plugin-geolocation: 0.3.12 (ccab812a49) cordova-plugin-globalization: 0.3.4 (6b1e88d534) cordova-plugin-inappbrowser: 0.6.0 (90d41e87ce) cordova-plugin-media: 0.2.16 (10df21dea8) cordova-plugin-media-capture: 0.3.6 (cc779375e3) cordova-plugin-network-information: 0.2.15 (81037e29cf) cordova-plugin-splashscreen: 1.0.0 (a9f0faa499) cordova-plugin-vibration: 0.3.13 (25217db403) cordova-plugin-statusbar: 0.1.10 (5feffc9314) cordova-plugins: file-system-roots-0.1.0 (be0a4c6cfb) cordova-plugin-test-framework: 0.0.1 (6aad294699) Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 24 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran mobile-spec on android, and made sure it compiled for iOS. There were only 2 failures in media, and I verified that the same 2 errors happen with the previous plugin version
Re: [Review] plugman createpackagejson
Plan sounds good to me! On Fri, Feb 6, 2015 at 7:11 PM, Steven Gill wrote: > Hey All! Figured this should get its own thread > > So createpackagejson script is done. I have it all on branch CB-8416. > > USAGE: plugman createpackagejson PLUGIN_PATH > > Commit: > > https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6 > > I am using init-package-json module. So our createpackagejson script feels > very much like npm init. It generates defaults based on info from > plugin.xml. Try it out! > > When publishing to CPR, plugman publish will temporarily move an existing > package.json so it doesn't conflict with the package.json it needs to > create to publish. > > https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0 > > I'd like to push this to master and do a tools release next week. After the > plugins release is completed, I will go through our plugins and add > package.json files to them all. Next plugins release should be published on > npm as well as CPR. > > Thoughts? >
[GitHub] cordova-lib commit comment: adab8c9accfd769019837bb1cc36a2975f9742...
Github user agrieve commented on commit adab8c9accfd769019837bb1cc36a2975f9742b0: https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9653338 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 90: @stevengill - realized commenting on apache probably doesn't email you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: adab8c9accfd769019837bb1cc36a2975f9742...
Github user agrieve commented on commit adab8c9accfd769019837bb1cc36a2975f9742b0: https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9653314 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 90: You should also check that package.json1 doesn't already exist here, for when the command is run twice and it failed the first time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib commit comment: adab8c9accfd769019837bb1cc36a2975f9742...
Github user agrieve commented on commit adab8c9accfd769019837bb1cc36a2975f9742b0: https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9653322 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 93: This file will be included in the npm pack, but I think that's fine eh? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73527863 IMHO it is(or was) premature to drop this single PR by itself to master. This new flag --save flag should replace the save command, save command is not removed by this PR. Consequently the existing tests for save command should also be modified/replaced to work with this new function. Also without the corresponding restore functionality --save is useless to CLI users. I think we should refrain from releasing it until restore is taken to master too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Plugins Blog Post
Please create PRs to change (can be done right in the github interface) https://github.com/cordova/apache-blog-posts/blob/master/2015-02-10-plugins-release.md
[VOTE] Plugins Release
Please review and vote on the release of this plugins release. Release issue: https://issues.apache.org/jira/browse/CB-8429 (contains release notes for all plugins) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ They are the same as last week except for file-transfer. The packages were published from their corresponding git tags: cordova-plugin-battery-status: 0.2.12 (ec59ef11a5) cordova-plugin-camera: 0.3.5 (799ed580d3) cordova-plugin-console: 0.2.13 (7507b29527) cordova-plugin-contacts: 0.2.16 (95d4d176f3) cordova-plugin-device-motion: 0.2.11 (110b27671f) cordova-plugin-device-orientation: 0.3.11 (d8fd79b2ae) cordova-plugin-device: 0.3.0 (4330db87b9) cordova-plugin-dialogs: 0.3.0 (d12008f9cd) cordova-plugin-file-transfer: 0.5.0 (1882bfbd2d) cordova-plugin-file: 1.3.3 (b05bcff378) cordova-plugin-geolocation: 0.3.12 (ccab812a49) cordova-plugin-globalization: 0.3.4 (6b1e88d534) cordova-plugin-inappbrowser: 0.6.0 (90d41e87ce) cordova-plugin-media: 0.2.16 (10df21dea8) cordova-plugin-media-capture: 0.3.6 (cc779375e3) cordova-plugin-network-information: 0.2.15 (81037e29cf) cordova-plugin-splashscreen: 1.0.0 (a9f0faa499) cordova-plugin-vibration: 0.3.13 (25217db403) cordova-plugin-statusbar: 0.1.10 (5feffc9314) cordova-plugins: file-system-roots-0.1.0 (be0a4c6cfb) cordova-plugin-test-framework: 0.0.1 (6aad294699) Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 24 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran mobile-spec on android, and made sure it compiled for iOS. There were only 2 failures in media, and I verified that the same 2 errors happen with the previous plugin version
RE: [VOTE] Plugins Release
Thank you, Andrew - File Transfer should be good on Windows now (@vladimir-kotikov has made it working, fixes are in master branch). -Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Saturday, February 7, 2015 12:24 AM To: Andrew Grieve Cc: dev Subject: Re: [VOTE] Plugins Release I'll spin this up again on Monday with the fixed commits to file-transfer. Plan to leave the rest of the plugins the same, so speak up if there's anything wrong with something other than file-transfer. On Fri, Feb 6, 2015 at 4:23 PM, Andrew Grieve wrote: > The vote has now closed. The results are: > > Positive Binding Votes: 1 > > Andrew Grieve > > Negative Binding Votes: 1 > > Jesse MacFadyen > > The vote has failed. > > > > > On Fri, Feb 6, 2015 at 4:48 AM, Jesse wrote: > >> -1 on (b05bcff378)cordova-plugin-file-transfer: 0.5.0 (15591b) >> Let's get the fix in first. >> >> @purplecabbage >> risingj.com >> >> On Fri, Feb 6, 2015 at 12:31 AM, Alexander Sorokin (Akvelon) < >> v-als...@microsoft.com> wrote: >> >> > Hi guys, >> > >> > I just wanted to let you know that there is a bug on windows in >> > file transfer plugin in this release. >> > >> > It is related to recent changes in file plugin and it breaks >> > download functionality on windows completely: >> > https://issues.apache.org/jira/browse/CB-8407 >> > The fix has been merged to master yesterday yet didn’t make it to >> > this >> > release: >> > https://github.com/apache/cordova-plugin-file-transfer/pull/63 >> > >> > Thank you, >> > Alexander Sorokin >> > >> > -Original Message- >> > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of >> Andrew >> > Grieve >> > Sent: Thursday, February 5, 2015 5:51 >> > To: dev >> > Subject: [VOTE] Plugins Release >> > >> > Please review and vote on the release of this plugins release. >> > Release issue: https://issues.apache.org/jira/browse/CB-8429 >> > (contains release notes for all plugins) The plugins have been >> > published to >> dist/dev: >> > https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ >> > The packages were published from their corresponding git tags: >> > cordova-plugin-camera: 0.3.5 (799ed580d3)cordova-plugin-console: >> 0.2.13 >> > (7507b29527)cordova-plugin-contacts: 0.2.16 (95d4d176f3) >> > cordova-plugin-device: 0.3.0 (4330db87b9) >> > cordova-plugin-device-orientation: 0.3.11 (d8fd79b2ae) >> > cordova-plugin-dialogs: 0.3.0 (d12008f9cd)cordova-plugin-file: 1.3.3 >> > (b05bcff378)cordova-plugin-file-transfer: 0.5.0 (15591b) >> > cordova-plugin-geolocation: 0.3.12 (ccab812a49) >> > cordova-plugin-globalization: 0.3.4 (6b1e88d534) >> > cordova-plugin-inappbrowser: 0.6.0 (90d41e87ce)cordova-plugin-media: >> > 0.2.16 (10df21dea8)cordova-plugin-media-capture: 0.3.6 (cc779375e3) >> > cordova-plugin-network-information: 0.2.15 (81037e29cf) >> > cordova-plugin-splashscreen: 1.0.0 (a9f0faa499) >> > cordova-plugin-statusbar: 0.1.10 (5feffc9314) >> > cordova-plugin-test-framework: 0.0.1 (6aad294699) >> > cordova-plugin-vibration: 0.3.13 (25217db403) Upon a successful >> > vote I will upload the archives to dist/, upload them to the >> > Plugins Registry, >> and >> > post the corresponding blog post. >> > Voting guidelines: >> > >> https://github.com/apache/cordova-coho/blob/master/docs/release-votin >> g.md >> > Voting will go on for a minimum of 48 hours. >> > I vote +1:* Ran coho audit-license-headers over the relevant repos* >> > Ran coho check-license to ensure all dependencies and >> > subdependencies have Apache-compatible licenses* Ran mobile-spec on >> > android, and made sure it compiled for iOS. There were only 2 >> > failures in media, and I verified >> that >> > the same 2 errors happen with the previous plugin version >> > >> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Move platform parsers from CLI to platforms
Been thinking about this as well, and one part I'm not 100% sure about is having this logic at create-time vs prepare-time vs plugin-add time. create-time - easy to see we just put it in cordova-FOO and allow deps within package.json prepare/plugin-add time though, should we relay on having the correct version of cordova-FOO around to use, or should we copy this logic into platforms/FOO/cordova? Moving these files into each repo will certainly make refactoring harder. E.g., making a change to the API now requires a version check + still supporting the old API + also supporting the new API. Still think this is worth doing, but I think we should also consider sanity-checking our API surface to ensure that it makes the most sense (e.g. all APIs that may have to do IO should return promises, even if they are sync right now). On Mon, Feb 9, 2015 at 12:42 AM, Mark Koudritsky wrote: > There are 2 main places in the lib with platform specific logic > src/cordova/metadata/_parser.js > src/plugman/platforms/.js > Probably all of this logic should be moved to platforms. > > On Sun, Feb 8, 2015 at 4:36 AM, Josh Soref wrote: > > > +1 > > > > Sent from my BlackBerry 10 smartphone. > > > > >
[GitHub] cordova-wp8 pull request: JsonHelper testing, and use of Newtonsof...
Github user pietertingly commented on the pull request: https://github.com/apache/cordova-wp8/pull/62#issuecomment-73509892 +1 here also. I have issues parsing JSON in Cordova also, only on Windows Phone platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7956 Add cordova-plugin-file ...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file/pull/99 CB-7956 Add cordova-plugin-file support for browser platform * Added Firefox and IE support via IndexedDB * Updated the docs * Updated the tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-7956 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/99.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #99 commit a993eabd91116ebd82799b7992c13428e41d4e76 Author: daserge Date: 2015-01-15T20:08:02Z CB-7956 Add cordova-plugin-file support for browser platform * Added Firefox and IE support via IndexedDB * Updated the docs * Updated the tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73487890 Confirm, adding platform by git url works fine. Code LGTM, and also if no one has anything against the design of this, i would like to merge these chages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/57#issuecomment-73478942 @muratsu Merged in 8e7ad53191ebf34c7faec9ed1a3e4c0634372e2d and 232968c062cf73ae7482f13cc3b6584d72933498 . Could you please close this PR manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
