[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...
GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/73 CB-6313 [wp8]: Extra boundary in upload When performing an upload on Windows Phone, an extra boundary is included after any parameters, and before the file contents. This causes some servers (such as express/multiparty on node.js) to fail to handle the request properly. This commit removes the extraneous boundary. Fixes https://issues.apache.org/jira/browse/CB-6313 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpolivy/cordova-plugin-file-transfer CB6313 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 237dd43b4d28c1a0e074bafedd404e6a7566cc7e Author: Dan Polivy d...@cellartracker.com Date: 2015-03-27T06:13:12Z CB-6313 [wp8]: Extra boundary in upload When performing an upload on Windows Phone, an extra boundary is included after any parameters, and before the file contents. This causes some servers (such as express/multiparty on node.js) to fail to handle the request properly. This commit removes the extraneous boundary. Fixes https://issues.apache.org/jira/browse/CB-6313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Plugin Development
Hello All, I am new to cordova development, and would like to know how to develop cordova plugins for various platforms. I found the development guide for the same here http://cordova.apache.org/docs/en/edge/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide. But it explains the basic procedure to do the same. I would like to know how to develop cordova plugins using the SDK provided by device vendor for specific platform. I want to develop cordova plugin for LineDevice http://ipcprint.com/. I have the ios SDK provided by vendor, but I don't know how to use it with cordova. The SDK provided contains LineaSDK.h and libLineaSDK.a files. Please help. Rahul Bhooteshwar
[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...
GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74 CB-8761 [wp8]: Copy cookies from WebBrowser On other platforms, the cookies from the browser that apply to the request are automatically included. On WP8, that's not the case. This commit will copy the cookies from the WebBrowser control, if the scheme and host of the WebBrowser match that of the HttpWebRequest. For users who host their web components remotely, and perform uploads/downloads from the same server using cookie based authentication, this fix enables that scenario on WP8, and brings it up to parity with iOS, Android, and others. Fixes https://issues.apache.org/jira/browse/CB-8761 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpolivy/cordova-plugin-file-transfer CB8761 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit fcd8880d049825b317aadf24bfbe12562a7b0924 Author: Dan Polivy d...@cellartracker.com Date: 2015-03-27T07:19:56Z CB-8761 [wp8]: Copy cookies from WebBrowser On other platforms, the cookies from the browser that apply to the request are automatically included. On WP8, that's not the case. This commit will copy the cookies from the WebBrowser control, if the scheme and host of the WebBrowser match that of the HttpWebRequest. For users who host their web components remotely, and perform uploads/downloads from the same server using cookie based authentication, this fix enables that scenario on WP8, and brings it up to parity with iOS, Android, and others. Fixes https://issues.apache.org/jira/browse/CB-8761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-8760 Issues with 'platform list'.
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-coho/pull/67 CB-8760 Issues with 'platform list'. Added support for updating `windows` and `browser` platform versions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho CB-8760 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 0f1336e517b1d8e482a0c955195953df59a2d4aa Author: Tim Barham tim.bar...@microsoft.com Date: 2015-03-27T04:51:10Z CB-8760 Issues with 'platform list'. Added support for updating 'windows' and 'browser' platform versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8760 'platform list' shows wrong ...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/11 CB-8760 'platform list' shows wrong version for browser platform. Updated version file for `browser` platform (note that this relies on a change in `coho` to keep it in sync). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-browser CB-8760 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-browser/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit b6a3826ca7e624c2683729f04672e82dc26a84f5 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-03-27T04:51:37Z CB-8760 platform list shows wrong version for browser platform. Updated version file for browser platform (note that this relies on a change in coho to keep it in sync). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8760 'platform list' doesn't show...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-windows/pull/64 CB-8760 'platform list' doesn't show version for windows platform. Added version file for `windows` platform (note that this relies on a change in `coho` to keep it in sync). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-8760 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 14a470b78c8ddedb8ab60c056dc33d1a89a10cfb Author: Tim Barham tim.bar...@microsoft.com Date: 2015-03-27T04:52:59Z CB-8760 platform list doesn't show version for windows platform. Added version file for windows platform (note that this relies on a change in coho to keep it in sync). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: add state to outState before calling...
GitHub user thehuijb opened a pull request: https://github.com/apache/cordova-android/pull/169 add state to outState before calling super InstanceState was never really saved because super.onSaveInstanceState was called before any state was added. this pull request fixes that You can merge this pull request into a Git repository by running: $ git pull https://github.com/thehuijb/cordova-android develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 6714166d2e91366e70614b0efc091b33c1b66b04 Author: Serge Huijben s.huij...@gmail.com Date: 2015-03-27T09:12:29Z save instanceState before calling super --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: hook logging issue
https://issues.apache.org/jira/browse/CB-8763 On Thu, Mar 26, 2015 at 9:30 PM, Shazron shaz...@gmail.com wrote: File it pls thx! No idea of the workaround On Thursday, March 26, 2015, Raymond Camden raymondcam...@gmail.com wrote: So file a bug? Know a way around it? On Thu, Mar 26, 2015 at 5:46 PM, Shazron shaz...@gmail.com javascript:; wrote: actually it has stdio:inherit, and does capture the output and pushes it back up the chain, so somewhere up the chain no one does anything with it -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Plugin Development
Hello. Read the link you provided, read the SDK documentation and mix the knowledge. Most of the cordova plugins are open source and you can find them on github, so you can search a few to see more complex code. If you have any doubts after trying, ask on stackoverflow. This mail list if for the development of cordova itself, not for 3rd party plugins or problems while developing with cordova. 2015-03-27 7:37 GMT+01:00 Rahul Bhooteshwar rahul.bhootesh...@hotwaxsystems.com: Hello All, I am new to cordova development, and would like to know how to develop cordova plugins for various platforms. I found the development guide for the same here http://cordova.apache.org/docs/en/edge/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide . But it explains the basic procedure to do the same. I would like to know how to develop cordova plugins using the SDK provided by device vendor for specific platform. I want to develop cordova plugin for LineDevice http://ipcprint.com/. I have the ios SDK provided by vendor, but I don't know how to use it with cordova. The SDK provided contains LineaSDK.h and libLineaSDK.a files. Please help. Rahul Bhooteshwar
[GitHub] cordova-lib pull request:
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/dd6663ecda700a32bcdf3a8419cc918536a0764f#commitcomment-10427187 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8750 [wp8]: Allow res...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-86878586 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
introduction
Hi Everybody, I am a developer in the Netherlands working on a Mobile app development team. Our primary focus is on delivering a uniform user experience across at least the two major platforms (Android and iOS). We therefore chose to use Cordova as our base and we’re pretty happy with it. so happy in fact that I would really like to help make it even better. so expect to see a few PR’s from me (or my alias thehuijb) soon. regards, Serge Huijben (aka thehuijb) signature.asc Description: Message signed with OpenPGP using GPGMail
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/194 CB-8754 Auto-restoring a plugin fails when adding a platform. Start with a blank Cordova app, then enter the following: cordova plugin add org.apache.cordova.camera --save cordova plugin remove org.apache.cordova.camera cordova platform add browser The final step should restore the camera plugin, but it fails with the following exception: TypeError: Cannot read property 'latest' of undefined at next (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\lib\cache.js:694:35) at D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\lib\cache.js:682:5 at RegClient.get_ (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\npm-registry-client\lib\get.js:105:14) at RegClient.anonymous (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\npm-registry-client\lib\get.js:41:12) at fs.js:336:14 at D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\graceful-fs\graceful-fs.js:103:5 at FSReqWrap.oncomplete (fs.js:99:15) The core problem here is an issue with how we work with npm. Every time we are going to use npm (when dealing with plugins), we call `npm.load()` passing it our settings. But `npm.load()` can only be called once per session - subsequent calls are ignored. The correct approach is to call `npm.load()` without any settings (to make sure npm is loaded), then call `npm.config.set()` for each setting. This change had been made for platforms, but not plugins. I also wanted to make sure each time we worked with npm we had a clean config (for example, if we get an npm package from the Cordova Plugin Respository, then later from the npm repository, it would try to get the second package from the CPR because that setting would still be around and not get overridden). So now any code that wants to load and init npm I pass through a central load and restore method. You pass this method your npm settings and the chain of promises you want to execute with those settings applied. It loads and initializes npm, executes the promises, then restores npm's configuration to what it was before we started. Finally, once that problem was fixed there was an additional problem - we were adding plugins too early and the platform wasn't fully initialized, so we'd get an error about not being able to find the platform's `config.xml` file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8754 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #194 commit 0df6b800c6013bcf53045040ade81345fd9b47ec Author: Tim Barham tim.bar...@microsoft.com Date: 2015-03-26T11:54:37Z CB-8754 Auto-restoring a plugin fails when adding a platform. Start with a blank Cordova app, then enter the following: cordova plugin add org.apache.cordova.camera --save cordova plugin remove org.apache.cordova.camera cordova platform add browser The final step should restore the camera plugin, but it fails with the following exception: TypeError: Cannot read property 'latest' of undefined at next (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\lib\cache.js:694:35) at D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\lib\cache.js:682:5 at RegClient.get_ (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\npm-registry-client\lib\get.js:105:14) at RegClient.anonymous (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\npm-registry-client\lib\get.js:41:12) at fs.js:336:14 at D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\graceful-fs\graceful-fs.js:103:5 at FSReqWrap.oncomplete (fs.js:99:15) The core problem here is an issue with how we work with npm. Every time we are going to use npm (when dealing with plugins), we call npm.load() passing it our settings. But npm.load() can only be called once per session - subsequent calls are ignored. The correct approach is to call npm.load() without any settings (to make sure npm is loaded), then call npm.config.set() for each setting. This change had been made for platforms, but not plugins. I also wanted to make sure each time we worked with npm we had a clean config (for example, if we get an npm package from the Cordova plugin respository, then later from the npm repository, it would try to get the second package from the CPR because that setting would still be around and not get
Re: introduction
Welcome aboard, Serge! On Mar 27, 2015 3:36 AM, Serge Huijben s.huij...@gmail.com wrote: Hi Everybody, I am a developer in the Netherlands working on a Mobile app development team. Our primary focus is on delivering a uniform user experience across at least the two major platforms (Android and iOS). We therefore chose to use Cordova as our base and we’re pretty happy with it. so happy in fact that I would really like to help make it even better. so expect to see a few PR’s from me (or my alias thehuijb) soon. regards, Serge Huijben (aka thehuijb)
[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/195 CB-8756 Make 'plugin --save' work more like 'npm install' 1. `plugin add --save` now always saves version (in the form `^x.y.z`) 2. `plugin add --save` now always overwrites an existing entry. 3. `plugin add` now honors an existing version specified in `config.xml` when a plugin is added without a specific version, even if the `--save` flag is specified. I also fixed a bug in `isUrl()` (in `util.js`) - `url.protocol` includes the colon, so the protocol for a windows path is something like `c:` - 2 characters, not one. Note that I'm current finishing off a similar change for `platform add --save`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8756 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #195 commit b79ca83e64dd8f485209370d9ff1b113ba32d9f2 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-03-27T13:22:20Z CB-8756 Make plugin --save work more like npm install. 1. 'plugin add --save' now always saves version (in the form '^x.y.z') 2. 'plugin add --save' now always overwrites an existing entry. 3. 'plugin add' now honors an existing version specified in config.xml when a plugin is added without a specific version, even if the '--save' flag is specified. I also fixed a bug in isUrl() in util.js - url.protocol includes the colon, so the protocol for a windows path is something like c: - 2 characters, not one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/195#issuecomment-86949466 Sorry, this PR points to the wrong JIRA issue (a bug I closed as a dup of the one this PR should point to). Will close and open a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-8760 Issues with 'platform list'.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/194#issuecomment-86956650 Nice clean-up! Let me know when comments are addressed and I'll merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27298469 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -223,11 +211,13 @@ module.exports = { * @param {Boolean} determines if we are using the npm registry * @return {Promise.Object} Promised settings. */ -function initSettings() { +function initSettings(returnEmptySettings) { var settings = module.exports.settings; // check if settings already set -if(settings !== null) return Q(settings); +if(settings !== null) { --- End diff -- No it should not. Good catch, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8651 Restoring platforms causes plugi...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27299568 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -0,0 +1,76 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + License); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + */ + +// Helper methods to help keep npm operations separated. + +var npm = require('npm'), +Q = require('q'), +cachedSettings = null, +cachedSettingsValues = null; + +/** + * @description Calls npm.load, then initializes npm.config with the specified settings. Then executes a chain of + * promises that rely on those npm settings, then restores npm settings back to their previous value. Use this rather + * than passing settings to npm.load, since that only works the first time you try to load npm. + * @param {Object} settings + * @param {Function} promiseChain + */ +function loadWithSettingsThenRestore(settings, promiseChain) { +return loadWithSettings(settings).then(promiseChain).then(restoreSettings); --- End diff -- Yes, indeed it should ... good point :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8741 Make plugin --save work more lik...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/198 CB-8741 Make plugin --save work more like npm install. 1. `plugin add --save` now always saves version (in the form `^x.y.z`) 2. `plugin add --save` now always overwrites an existing entry. 3. `plugin add` now honors an existing version specified in `config.xml` when a plugin is added without a specific version, even if the `--save` flag is specified. I also fixed a bug in `isUrl()` (in `util.js`) - `url.protocol` includes the colon, so the protocol for a windows path is something like `c:` - 2 characters, not one. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8741 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #198 commit 8c9f3eec78ee5574d5392371b6b3cf4e5d1f19b2 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-03-27T13:22:20Z CB-8741 Make plugin --save work more like npm install. 1. 'plugin add --save' now always saves version (in the form '^x.y.z') 2. 'plugin add --save' now always overwrites an existing entry. 3. 'plugin add' now honors an existing version specified in config.xml when a plugin is added without a specific version, even if the '--save' flag is specified. I also fixed a bug in isUrl() in util.js - url.protocol includes the colon, so the protocol for a windows path is something like c: - 2 characters, not one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: add state to outState before calling...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: introduction
Welcome Serge! Just merged your PR ( https://github.com/apache/cordova-android/pull/169) Great stuff! On Fri, Mar 27, 2015 at 9:08 AM, Victor Sosa sosah.vic...@gmail.com wrote: Welcome aboard, Serge! On Mar 27, 2015 3:36 AM, Serge Huijben s.huij...@gmail.com wrote: Hi Everybody, I am a developer in the Netherlands working on a Mobile app development team. Our primary focus is on delivering a uniform user experience across at least the two major platforms (Android and iOS). We therefore chose to use Cordova as our base and we’re pretty happy with it. so happy in fact that I would really like to help make it even better. so expect to see a few PR’s from me (or my alias thehuijb) soon. regards, Serge Huijben (aka thehuijb)
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27298069 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -0,0 +1,76 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + License); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + */ + +// Helper methods to help keep npm operations separated. + +var npm = require('npm'), +Q = require('q'), +cachedSettings = null, +cachedSettingsValues = null; + +/** + * @description Calls npm.load, then initializes npm.config with the specified settings. Then executes a chain of + * promises that rely on those npm settings, then restores npm settings back to their previous value. Use this rather + * than passing settings to npm.load, since that only works the first time you try to load npm. + * @param {Object} settings + * @param {Function} promiseChain + */ +function loadWithSettingsThenRestore(settings, promiseChain) { +return loadWithSettings(settings).then(promiseChain).then(restoreSettings); --- End diff -- nit: should restoreSettings be within a .finally() rather than a .then()? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27298165 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -223,11 +211,13 @@ module.exports = { * @param {Boolean} determines if we are using the npm registry * @return {Promise.Object} Promised settings. */ -function initSettings() { +function initSettings(returnEmptySettings) { var settings = module.exports.settings; // check if settings already set -if(settings !== null) return Q(settings); +if(settings !== null) { --- End diff -- This returns settings even when returnEmptySettings is true. should it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/194#issuecomment-86962408 Thanks Andrew. Changes made! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86966069 Maybe I'm missing something. The problem which we faced with the current inAppBrowser plugin implementation is that it doesn't allow to perform the redirection back to the application using custom scheme. Although the android:scheme is registered the the webView in inAppBrowser returns err_unknown_url_scheme when trying navigate back. It works without any problems on iOS, and also using system browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86966392 We don't want to system browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
GitHub Problems
Just an FYI - I've been struggling with GitHub most of my day. Turns out there's been an ongoing DDoS attack. https://status.github.com/messages Tim
[GitHub] cordova-android pull request: CB-8753 Maintain splash screen aspec...
Github user AlexTalis commented on the pull request: https://github.com/apache/cordova-android/pull/168#issuecomment-87017968 I'm working on a pull request for cordova-plugin-splashscreen master. The only way I found to set up for the plugin development was to copy SplashScreen.java from the repo into another project, make the changes, then copy it back to cordova-plugin-splashscreen repo, then push. That's because SplashScreen.java in cordova-plugin-splashscreen is not in the right package folder structure, so it can't be linked into a workspace directly. This is a little painful. Do you have better way of doing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-87025912 It should not redirect, it should send a message to it's parent ( the application webview ) The parent should then dismiss it's child (InAppBrowser). The parent gets notifications every time the location of the InAppBrowser changes, and can respond based on what the location.href is. Think oauth, and send the InAppBrower to #token=ACCESS_TOKEN or some other signal that you define. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8750 [wp8]: Allow res...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87015745 I should also point out that the ResolutionHelper.cs file is taken from MSDN sample code: https://msdn.microsoft.com/library/windows/apps/jj206974(v=vs.105).aspx As it is example code and intended for us in WP apps, I believe it is OK to use here, but I am not a lawyer, so you may want to have someone double check that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8750 [wp8]: Allow res...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87028196 I'll rewrite it, since I haven't looked at it. Just so we're clear. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8596 Expose APIs to retrieve platform...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/177#issuecomment-86994521 Yes, #191 subsumes this PR. I believe @omefire is on vacation and he will be able to close this when he's back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/187#issuecomment-86999644 @purplecabbage. Yes, this one's ready to go! Please help commit this one and close this PR! :bow: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8717 Write cordova-android@4.0.0 ...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-android/pull/167#issuecomment-87033190 It might be good to get an answer for the Whitelist Guide -- that seems useful to have. Also, I'd personally encourage you to fold your changes together, there's no real need for people to see the intermediate changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...
Github user Xavierh95 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-86980841 Works perfectly with : ionic : 1.0.0-rc.1 crosswalk : 13.41.318.0 Android : 4.X.X Thanks a lot @dpogue ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8717 Write cordova-android@4.0.0 ...
Github user jpchase commented on the pull request: https://github.com/apache/cordova-android/pull/167#issuecomment-86982723 @jsoref I included some of the corrections from your changes. I believe the release notes read better with less formatting, so I excluded many of your changes. Finally, I didn't link to the Whitelist Guide as I wasn't sure which would be the correct link, and I didn't want to link to the edge docs (as that wouldn't make sense over time). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8596 Expose APIs to retrieve platform...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/194#issuecomment-86971194 Thanks, merging. Tests pass ok. Appveyor or GitHub were flaky for the last couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8755 Plugin --save: Multiple config.x...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/197#issuecomment-86978847 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8755 Plugin --save: Multiple config.x...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8741 Make plugin --save work more lik...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8741 Make plugin --save work more lik...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/198#issuecomment-86982386 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8596 Expose APIs to retrieve platform...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/177#issuecomment-86993019 Was this all taken care of with #191 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8596 Expose APIs to retrieve platform...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/191#issuecomment-86991348 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/187#issuecomment-87065126 This is merged into master, not sure why the pull-request didn't close. Please review master and close. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8717 Write cordova-android@4.0.0 ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Discuss] Deprecate platform Windows 8.0
+1 on deprecation to the platform. I think we should also ensure that all plugins now refer to Windows instead of windows8 platform. -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Friday, March 20, 2015 1:39 PM To: dev@cordova.apache.org Subject: Re: [Discuss] Deprecate platform Windows 8.0 cordova-windows contains code for windows universal apps ( windows 8.1 and wp8.1 ) It also contains legacy support for windows8.0 To target wp8.1 you : cordova platform add windows # deploy app to Windows Phone 8.1 emulator cordova run windows -- --phone # deploy app to connected device cordova run windows --device -- --phone @purplecabbage risingj.com On Fri, Mar 20, 2015 at 11:35 AM, Carlos Santana csantan...@gmail.com wrote: Jesse which is the platform repo for the windows universal? I always get those mixed. Can I assume there is only one platform for windows universal to support windows 8.1 and windows phone 8.1? And lastly if I wan to try windows universal which one is the key name for cordova cli? cordova platform add window ? sorry for all the stupid questions, it's being a while since I worked on windows. On Thu, Mar 19, 2015 at 4:26 PM, Jesse purplecabb...@gmail.com wrote: The time is long past, and we should clean this out of our codebase soon. Windows 8.1 is better and offers better support. It's a free upgrade to anyone who has Windows 8.0, it will install on any device that supports 8.0, and it has been out for almost 18 months. Any objections? @purplecabbage risingj.com -- Carlos Santana csantan...@gmail.com
[GitHub] cordova-firefoxos pull request: CB-4548 Implement the `run` comman...
GitHub user lmorchard opened a pull request: https://github.com/apache/cordova-firefoxos/pull/23 CB-4548 Implement the `run` command using node-firefox-* modules This is most of a fix for [CB-4548](https://issues.apache.org/jira/browse/CB-4548), using [node-firefox](https://github.com/mozilla/node-firefox) modules to implement turn `run` command and associated helper scripts. Still looking into supporting `log`, but wanted to get some more eyes on what I've got so far. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lmorchard/cordova-firefoxos 4548-node-firefox Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-firefoxos/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 3685b13ce8ff15ab25676144a0d57637a29d7ea8 Author: Les Orchard m...@lmorchard.com Date: 2015-03-11T17:29:57Z Ignore VIM swapfiles for git commit d26d10915eaeac21a8776a09648d7ecb2dd147bc Author: Les Orchard m...@lmorchard.com Date: 2015-03-11T17:29:23Z CB-4548 Add node-firefox-* module dependencies to package.json commit b2b43200d94a5ec90e57fec333bf4e25cf34c755 Author: Les Orchard m...@lmorchard.com Date: 2015-03-11T17:31:04Z CB-4548 Install new node-firefox-* dependencies in node_modules commit d46b4430bc92d72f9e4866af4022bea98c090e11 Author: Les Orchard m...@lmorchard.com Date: 2015-03-11T20:08:46Z CB-4548 Implement the `run` command using node-firefox-* modules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8753 Maintain splash screen aspec...
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/168#issuecomment-87076470 Install the plugin with the --link flag, and then you should be able to edit it in the projects and the changes will be reflected in the repo (it creates symlinks) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Storage.md link to file plugin readme
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release (attempt 2)
+1 * Tested that both plugins compile on Android * Tested that the non-legacy plugin does what its supposed to on Android On Thu, Mar 26, 2015 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the releases of cordova-plugin-whitelist and cordova-plugin-legacy-whitelist plugins. Release issue: https://issues.apache.org/jira/browse/CB-8739 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8739/ The packages were published from their corresponding git tags: cordova-plugin-whitelist: 1.0.0 (38f5a9fa2c)cordova-plugin-legacy-whitelist: 1.0.0 (1ce26eba64) Upon a successful vote I will upload the archives to dist/ and upload them to npm. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
[GitHub] cordova-plugin-splashscreen pull request: CB-8753 Maintain splash ...
GitHub user AlexTalis opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/43 CB-8753 Maintain splash screen aspect ratio - Added SplashMaintainAspectRatioâ preference to maintain SplashScreen aspect ratio instead of scaling it to dialog. - Added âSplashReloadOnOrientationChangeâ preference to reload drawable when orientation changes. It's a preference for performance reasons - do not reload the drawable if it does not change based on orientation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/AlexTalis/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 9155b9066202716b13c72e4c5b20204eb8f20426 Author: Alex Talis alex.ta...@yahoo.com Date: 2015-03-27T18:33:01Z CB-8753 Maintain splash screen aspect ratio - Added SplashMaintainAspectRatioâ preference to maintain SplashScreen aspect ratio instead of scaling it to dialog. - Added âSplashReloadOnOrientationChangeâ preference to reload drawable when orientation changes. It's a preference for performance reasons - do not reload the drawable if it does not change based on orientation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/187#issuecomment-87097870 Thanks, @purplecabbage ! There is a corresponding update to docs here that needs someone to commit it: https://github.com/apache/cordova-docs/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8753 Maintain splash screen aspec...
Github user AlexTalis commented on the pull request: https://github.com/apache/cordova-android/pull/168#issuecomment-87089041 Closing this pull request in favor of this one: https://github.com/apache/cordova-plugin-splashscreen/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8753 Maintain splash screen aspec...
Github user AlexTalis closed the pull request at: https://github.com/apache/cordova-android/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Plugins to NPM (Phase 1)
Hi Steve, My final questions (until my next final question... ;-) ) Until the CPR becomes read-only, will the Cordova project plugin releases update both CPR and npm or only npm? I guess they would be the same except for the id? Or has CPR already seen its final update for Cordova project plugins? In your reply you mentioned: Right now, our mapping just spits out a message to use the new name for users. It doesn't actually convert the id to the new name, though we will probably start doing the conversion automatically at some point. I had been assuming for the initial support that if the mapper found a match, it would go to npm - either first and dropback to CPR or CPR then npm. Here's why I ask. In the Intel XDK we want to support both CLI 4.x and CLI 5.x (in the same IDE) until CPR is retired. That presents a few challenges of course, but wrt to the name change, I would like to be able to use the old names both with CLI 4.x and CLI 5.x until we have a release that no longer supports CLI 4.x. For example, the current version of the camera plugin is 0.3.5. With the initial npm release there will be a cordova-plugin-camera version 1.0? If I ask the CLI 5.x for org.apache.cordova.camera@1.0, will that work? Thanks, Leo -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, March 26, 2015 5:40 PM To: dev@cordova.apache.org Subject: Re: Plugins to NPM (Phase 1) On Wed, Mar 25, 2015 at 2:36 PM, Horn, Julian C julian.c.h...@intel.com wrote: I'd like to add some more questions to what Leo asked. Can anyone explain how the hundreds of plugins that are published in git repos are supposed to transition to CLI 5 (and beyond)? It seems like the answer is that they don't change anything. What if they want to (or already do) publish via the registry? It seems like you can win if you keep the id unchanged and add yourself to the mapping table. But if that's true, then why are we renaming the core plugins? If you don't change the id, you don't need to be added to the mapping table. It will just work once we start checking npm first if it is published as the same id on npm. We decided to rename our core plugins due to improved readability and fitting in better with the npm ecosystem. I don't think repo-resident plugins need to update any dependency tags that refer to core plugins. That is, you can continue to ask for org.apache.cordova.file. If you use CLI 5, then the rename logic will get you the corresponding plugin from npm. Or is there some reason why you will eventually have to change your dependency tags to use the new names. Of course you better not change a dependency tag in your repo-resident plugin before October 1, because that will break projects that use your plugin but aren't yet using CLI 5. Right now, our mapping just spits out a message to use the new name for users. It doesn't actually convert the id to the new name, though we will probably start doing the conversion automatically at some point. The dependency tag is an interesting usecase. Not sure what the best solution is. For core plugins, we are doing a major version jump and we are probably going to have a requirement that they require a newer version of the CLI to work. (using the engine tag). Third party developers could do something similar. All of this would be a part of the effort to get developers to update their tools. I haven't been able to come up with any strategy for changing the id of a repo-resident plugin without great pain. It's basically equivalent to discontinuing your plugin and creating a new one in its place. So it seems to me that if I have any users I would probably want to stick with my existing id and repo URL, even if it meant that I couldn't publish my plugin in npm format. Is that a viable strategy, or is there a long term plan that EVERY plugin must eventually publish via npm? We will still support installing via git or locally. So npm won't be a requirement. To clarify, org.your.project.id is valid for npm. You are welcomed to use the existing id as package-name when publishing to npm. One final question. Suppose I have a CLI 4.x project and I want to transition to CLI 5. Do I have to start over at cordova create project? Depends on what changes land in 5. But currently, it is the same as updating has been since CLI 3.x. * Update cordova-cli via npm install -g cordova-cli@5.0.0. * Update your project platforms if you desire. cordova platform rm android; cordova platform add android@newVERSION. As far as I know, we don't have any changes coming into the CLI that prevent older platform versions from working. Hopefully we can keep this going. Great questions. Appreciate it. Julian -Original Message- From: Treggiari, Leo [mailto:leo.treggi...@intel.com] Sent: Wednesday, March 25, 2015 3:53 PM To: dev@cordova.apache.org Subject: RE: Plugins to NPM (Phase 1) Thanks for the
[GitHub] cordova-docs pull request: CB-8703: Add support for semver and dev...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8753 Maintain splash screen aspec...
Github user AlexTalis commented on the pull request: https://github.com/apache/cordova-android/pull/168#issuecomment-87086720 It doesn't work for me on Windows, probably because my repo structure is totally different from what you use. I'm not going to bug you with more questions - it's not that big of a deal. I can manually create the link. From: agrieve notificati...@github.com To: apache/cordova-android cordova-andr...@noreply.github.com Cc: Alex alex.ta...@yahoo.com Sent: Friday, March 27, 2015 1:18 PM Subject: Re: [cordova-android] CB-8753 Maintain splash screen aspect ratio (#168) Install the plugin with the --link flag, and then you should be able to edit it in the projects and the changes will be reflected in the repo (it creates symlinks)â Reply to this email directly or view it on GitHub. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/78#issuecomment-87098082 @vladimir-kotikov @sgrebnov Can you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Simulating Cordova plugins and device capabilities
IBM is behind this use case, there are customers that are novice or some reason are just getting started doing mobile. There is also those design developers that want to build a good prototype, before going to the next level of debugging (i.e. emulator, and real device) We currently have product named MBS [1] that offers help in this area. TIm, Julian We(IBM MobileFirst) would like to see an open solution, that then downstream distributions can built on top. Let us know know how can we help. [1]: https://www.ibm.com/developerworks/community/blogs/worklight/entry/hybrid_application_preview_in_the_mobile_browser_simulator On Thu, Mar 26, 2015 at 4:47 PM, Michal Mocny mmo...@chromium.org wrote: Julian, I think with the current plan you can proceed to emulate with Ripple exactly as you explain, right? Is there a change you would like to see be made that would make this easier? For me, device emulation inside the browser is preferable, and actually no-emulation-just-polyfills is usually even sufficient (I just use desktop Safari/Chrome as a proxy for mobile equivalents). If I want to truly emulate a device I grab it off the shelf. I understand the above workflow is not universal to everyone, its just my preference.. and I like that the current proposal gives us both the option we prefer, yet we can share as much common infrastructure as makes sense at the plugin-browser-implementation level. -Michal On Thu, Mar 26, 2015 at 4:04 PM, Horn, Julian C julian.c.h...@intel.com wrote: I'll try to follow up on Tim's remark as eloquently as I can ;) There are clearly advantages to building device simulation into the browser, but this strategy does impose limitations. A company like Microsoft or Google has complete control over the browser and the debug tools, but this freedom does not exist for other vendors making their own emulator. This creates the feeling of a closed system. Intel has a rich history of creating software development tools for new hardware as it being designed. We prize the ability to quickly support new devices of our choosing, so an open architecture is better for our needs. Beyond that I see some shortcomings in the way the emulation features in Chrome and Internet Explorer work today. The attributes of a device, once selected, cannot be modified by the program under test (or even by the non-browser parts of the emulator). This makes it impossible to simulate any actions that change the size of the viewport. For example, the show/hide status bar APIs cannot be simulated under these conditions, nor can other popular plugins such as AdMob that reduce the size of the viewport to allow room for advertisements. The device sizes provided in Chrome and Internet Explorer all assume a “full screen” configuration, that is, no status bar. This is a reasonable choice if you are simulating a mobile browser. However, most packaged apps run with a status bar. This means the device sizes provided by browsers are in fact uniformly incorrect for most packaged apps. In our experience, the photorealistic device skins are surprisingly effective in getting across the feeling of what an app would look like running on a real device. We heard from one customer who develops apps for a living. For less technical customers a prototype of an app he would build running in the XDK Device Emulator to show what the app would feel like. We lose this capability if we entrust the device emulation problem to the browser. Julian -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Wednesday, March 25, 2015 1:50 AM To: dev@cordova.apache.org Subject: RE: Simulating Cordova plugins and device capabilities Thanks Michal and Jesse! Jesse, in response to your additional questions... What value does Ripple if the basic functionality becomes part of a generic simulation interface? Ripple currently will simulate screen sizes based on device choice. Chrome dev tools support picking different device viewports also. Where should something like this live? Julian Horn (Intel) would be a good person to answer that question... He can speak more eloquently than me to why Ripple is (and will continue to be, after this proposal is implemented) the ideal platform for them. And I think there is definitely room for both approaches: * Some basic simulation host provided by Cordova, which wouldn't provide any of the device choosing capabilities and other functionality we get with Ripple, but would work well with browser dev tools (and rely on them to provide that functionality). * A richer environment like Ripple, which is also works well embedded in tools like the XDK. Another interesting point is that Chrome device mode means you have the Chrome debugger open, which means you can't use an external debugger. If your workflow is
Re: Who Runs cordova.io?
Hi Dmitry, I own and pay for the cordova.io domain. When it comes to domains, the general rules within Apache are: 1. cordova.io URLs that point to official Apache resources (e.g. cordova.apache.org) must redirect to the official URL and not mask it. This ensures that the project is recognized as an official Apache project. We do this for cordova.io, docs.cordova.io, and issues.cordova.io 2. Apache prefers to not have the word apache in the third-party domain because ownership can be deceiving. cordova.io is okay. apachecordova.io is misleading. For those interested, I'll describe some of the history of cordova.io. During the donation of PhoneGap to Apache, I registered the cordova.io domain. In my naivety, I thought we could use it as the official Apache Cordova domain (CNAME style like Github Page). However, after talking with our Apache mentor, I learned what I stated above (redirect and make it clear that the domain is not apache property). Regardless, I decided to keep the domain around because it's shorter, verbally easier to spread by word-of-mouth (e.g. docs.cordova.io), and cleaner for presentation slide decks. The entire Adobe team has access to the DNS management of the domain. If anyone else on the Apache Cordova project would like to add a subdomain, I'm all for it! Likewise, if you want a subdomain removed, let's talk about i! Cheers, Michael On Thu, Mar 26, 2015 at 11:44 AM, Josh Soref jso...@blackberry.com wrote: this has nothing to do w/ cordova.io domaining, it's a bug in our registry-web repository. you're encouraged to work on it (it is filed). once a fix is provided for it (it's a escape/unescape loop), someone will know how to fix it. On the other side, all of the browser vendors should handle this well, I know Chrome crashes, which is a bug in chrome. I'm sorry for everyone. but i've lost a few days debugging it and got lost. I'm also ill, and don't have any more resources to invest on this until after spring. From: Dmitry Blotsky [dblot...@microsoft.com] Sent: Thursday, March 26, 2015 2:39 PM To: dev@cordova.apache.org Subject: Who Runs cordova.io? Hi list, This issue just came up on JIRA for Apache Infra - https://issues.apache.org/jira/browse/INFRA-9349 - but they apparently don't have the ruling power over cordova.io. Who governs cordova.io? Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Who Runs cordova.io?
Thanks, Michael for the detailed information. On a related note, who owns http://ci.cordova.io/ ? It seems to be running an old/stale version of medic + BuildBot. There is a newer version now hosted on Apache Infra but it's got a long url : http://ci.apache.org/waterfall?builder=cordova-iosbuilder=cordova-android-osxbuilder=cordova-windowsbuilder=cordova-wp8builder=cordova-android-winbuilder=cordova-blackberry-osxbuilder=cordova-blackberry-win Wonder if there is a way for ci.cordova.io to point to the above version instead? Thanks, Nikhil -Original Message- From: mikeywbro...@gmail.com [mailto:mikeywbro...@gmail.com] On Behalf Of Michael Brooks Sent: Friday, March 27, 2015 4:18 PM To: dev@cordova.apache.org Subject: Re: Who Runs cordova.io? Hi Dmitry, I own and pay for the cordova.io domain. When it comes to domains, the general rules within Apache are: 1. cordova.io URLs that point to official Apache resources (e.g. cordova.apache.org) must redirect to the official URL and not mask it. This ensures that the project is recognized as an official Apache project. We do this for cordova.io, docs.cordova.io, and issues.cordova.io 2. Apache prefers to not have the word apache in the third-party domain because ownership can be deceiving. cordova.io is okay. apachecordova.io is misleading. For those interested, I'll describe some of the history of cordova.io. During the donation of PhoneGap to Apache, I registered the cordova.io domain. In my naivety, I thought we could use it as the official Apache Cordova domain (CNAME style like Github Page). However, after talking with our Apache mentor, I learned what I stated above (redirect and make it clear that the domain is not apache property). Regardless, I decided to keep the domain around because it's shorter, verbally easier to spread by word-of-mouth (e.g. docs.cordova.io), and cleaner for presentation slide decks. The entire Adobe team has access to the DNS management of the domain. If anyone else on the Apache Cordova project would like to add a subdomain, I'm all for it! Likewise, if you want a subdomain removed, let's talk about i! Cheers, Michael On Thu, Mar 26, 2015 at 11:44 AM, Josh Soref jso...@blackberry.com wrote: this has nothing to do w/ cordova.io domaining, it's a bug in our registry-web repository. you're encouraged to work on it (it is filed). once a fix is provided for it (it's a escape/unescape loop), someone will know how to fix it. On the other side, all of the browser vendors should handle this well, I know Chrome crashes, which is a bug in chrome. I'm sorry for everyone. but i've lost a few days debugging it and got lost. I'm also ill, and don't have any more resources to invest on this until after spring. From: Dmitry Blotsky [dblot...@microsoft.com] Sent: Thursday, March 26, 2015 2:39 PM To: dev@cordova.apache.org Subject: Who Runs cordova.io? Hi list, This issue just came up on JIRA for Apache Infra - https://issues.apache.org/jira/browse/INFRA-9349 - but they apparently don't have the ruling power over cordova.io. Who governs cordova.io? Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Github user bau720123 commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-87159454 hi @shazron according to this https://github.com/doggy8088/Learn-Git-in-30-days seem everything fix done so...please help...how long will merge into the official repository ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org