[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99354856 > So the apache/cordova-plugin-file-transfer#72 probably should be closed then... My point that apache/cordova-plugin-file-transfer#54 was an improvement that was closed and rejected since we did not expect to add the Newtonsoft JSON library. Now that we *do* include the Newtonsoft library, it is **now** possible to include apache/cordova-plugin-file-transfer#54 (in favor over apache/cordova-plugin-file-transfer#72 and apache/cordova-plugin-file-transfer#82). I hope [cordova-plugin-file-transfer]( https://github.com/apache/cordova-plugin-file-transfer) will consider apache/cordova-plugin-file-transfer#54 again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-99359895 Can we consider #54 again, now that apache/cordova-wp8#79 has been integrated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99360986 This one is now possible since apache/cordova-wp8#62 has been integrated (I already tested building with apache/cordova-wp8#62 OK). Can we consider including this one again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99365163 Yeah @brodybits, will have another look at apache/cordova-plugin-file-transfer/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8965 copy platform specific js into p...
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/213 CB-8965 copy platform specific js into platform_www when adding new plat... ...forms for browserify workflow. https://issues.apache.org/jira/browse/CB-8965 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib CB-8965 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit 38b2caee660953cd3f505d8ef6dcf3321e4f4b09 Author: Steve Gill Date: 2015-05-06T08:02:25Z CB-8965 copy platform specific js into platform_www when adding new platforms for browserify workflow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99371506 > Yeah @brodybits, will have another look at apache/cordova-plugin-file-transfer#54 :+1: thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8898 Introduces `requirements` cordov...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8898 Introduces `cordova requirements...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8961 Killing more Android tasks on ...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-medic/pull/52#issuecomment-99380547 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
GitHub user mowcixo reopened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54 Better header parse with custom WSSE sintax Changed the FileTransfer.cs#parseHeaders function to work with the changes of the https://github.com/apache/cordova-wp8/pull/62 pull request. The problem is that, with WSSE headers with a VALUE like this: ``` UsernameToken Username="f...@bar.net", PasswordDigest="ZTQ0NTJlMGE2M2I0NGJiYWM4NA==", Nonce="A==", Created="2014-10-11T18:48:07.232Z" ``` The current version of the function, will return null because of a bad parse by DataContractJsonSerializer. The pull request I mentioned suggests change DataContractJsonSerializer by Newtonsoft.Json for a better serialize and performance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mowcixo/cordova-plugin-file-transfer develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 1d85f44b4ccc9ce404da97d00ea1decc19e59cf8 Author: Moisés Gramary Barbosa Date: 2014-12-01T11:38:47Z Changed the FileTransfer.cs#parseHeaders function to work with the changes of the https://github.com/apache/cordova-wp8/pull/62 pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Github user mowcixo commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99387644 Great! Reopened! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99394981 Isn't this one enough? https://issues.apache.org/jira/browse/CB-8721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99399217 > Isn't this one enough? > https://issues.apache.org/jira/browse/CB-8721 Yes it looks like you fix the problem (and am very happy to see it merged). #54 has some performance improvement as well and makes the code a little easier to read as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99403955 @brodybits sorry for misunderstanding here, what I'm trying to say to @dblotsky is that we already have JIRA issue created which will be resolved by your PR https://github.com/apache/cordova-plugin-file-transfer/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Medic Builds on Panic Status Board
Hi list, I went on a small coding binge, and made a thing. If any of you have an iPad and on it you already have, or ever planned to have, the Panic Status Board (https://panic.com/statusboard), I made a component to show our Buildbot builds on it (screenshot attached). To add it, create a DIY component, and use this URI: http://dmitryblotsky.com/statusboard/index.html. You can then cast this on a huge screen and marvel at our medic results all day long (it refreshes). Feel free to copy it, use it, send feedback, etc. I plan to make it more data-rich in the future. Kindly, Dmitry [cid:8FADF490-2C15-41E6-894C-65E2A7AFC12A]
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99422459 > Great! Reopened! > > ... > apache/cordova-wp8#79 > ... Yes I meant apache/cordova-wp8#79 - my bad! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99430542 > Great! Reopened! Also I suggest we should mark this as a solution to CB-8721, both in the title of this PR and in JIRA CB-8721 (see discussion in #82). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99432098 > we already have JIRA issue created which will be resolved by your PR #54 Yes, understood (PR #54 was raised by @mowcixo). I just added a note to PR #54 with suggestion to reference CB-8721. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99489261 (and thanks!) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99489147 Merged. would be great if you could do another PR to update the docs: https://github.com/apache/cordova-docs/blob/master/docs/en/edge/guide/platforms/android/config.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8936 Gathering logs for Android
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/53 CB-8936 Gathering logs for Android https://issues.apache.org/jira/browse/CB-8936 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB-8936 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit 2d7c6091b0da1a75582a8b53c2e6b6ca2f4b6336 Author: alsorokin Date: 2015-05-06T13:18:23Z CB-8936 Gathering logs for Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Cordova Plugins with Symlinks
Hey folks, So I’ve started to see some issues come up with certain Cordova plugins when devs are mixing a Windows and OSX environment together when developing an app. Digging into it a bit, it looks like root cause is that there are some situations where iOS plugin implementations with custom frameworks that require symlinks - as described in the thread below. In addition to the situation mentioned in the thread, there's a second one worth calling out: installing a plugin with symlinks on Windows on the NTFS file system results in the symlinks becoming files. The workaround described in this thread (zipping as a tarball) helps when plugin installs happen on OSX, but it doesn't resolve the problem with NTFS. If a development team is split between OSX and Windows machines, the plugin will appear broken on iOS if it was committed/checked in/copied from Windows. If, on the other hand, the plugin is added from OSX, it will work - the end result is the behavior seems "glitchy" and it is not at all obvious what happened when things go wrong. I came up with a hook that fixes these symlinks since the files that are generated do contain the relative path to the underlying folder – but it is admittedly a bit of a hack since it attempts to handle any arbitrary plugin: https://github.com/Chuxel/taco-tricks/tree/master/ios-plugin-symlink-fix I think at a minimum, we should call this out in the plugin docs as a potential issue with a workaround. However, It got me thinking, would the right thing here be to just provide guidance to plugin authors to work around this problem Cordova plugin hook to create the symlinks or should we develop a way for this to happen automatically? Ex: A npm pre-publish hook persists symlinks in a file that are then used before_compile on an OS that supports them. Or frameworks can be referenced as tar balls in plugin.xml that are then untar'd as a before_compile step. Thoughts? -Chuck -Original Message- From: Ally Ogilvie [mailto:aogil...@wizcorp.jp] Sent: Friday, September 5, 2014 3:31 AM To: dev@cordova.apache.org Subject: Re: Cordova Plugin Registry iOS frameworks Thanks Carlos. I'll take a look Monday. Have a good weekend. On Fri, Sep 5, 2014 at 4:06 AM, Carlos Santana wrote: > Source code is here: > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plug > man/registry/registry.js#L97 > > I think the fix will be to create a tarball in some tmp after > generating pacakgeJson, then calling npm .commands, 'publish', args > with the tarball instead of a folder containing the package.json > > Have fun !, remember to add unit tests :-) > > > > On Wed, Sep 3, 2014 at 10:37 PM, Ally Ogilvie wrote: > > > I tried to find plugman source code responsible for npm publish but > failed. > > > > I'm gonna bump this for someone to assign too.. any takers? <3 > > > > > > > > On Wed, Aug 20, 2014 at 12:12 PM, Ally Ogilvie > > wrote: > > > > > >Ally, do you know if the symlinks are required for the > > > >FacebookConnect > > > framework? > > > > > > @Ian Absolutely required. Not just for Facebook, but all > > > .framework > > files. > > > > > > MyFramework.framework // (directory) > > > info.plist > > > MyFramework // (symbolic link to > > > Versions/Current/MyFramework) > > > Resources // (symbolic link to > > Versions/Current/Resources) > > > Headers // (symbolic link to > Versions/Current/Headers) > > > Versions// (directory) > > > Current // (symbolic link to directory "A" below) > > > A // (directory) > > > Headers // (directory containing framework headers) > > > Resources // (directory holding framework resources) > > > MyFramework // (actual compiled library, really a .a > file) > > > > > > As you can see there are 4 symbolic links in .frameworks. > > > > > > > > > > > > > > > On Tue, Aug 19, 2014 at 5:59 AM, Shazron wrote: > > > > > >> I think the right approach is what Andrew suggested. So the > > >> current workaround is to tarball it first then publish? > > >> > > >> On Mon, Aug 18, 2014 at 12:04 PM, Andrew Grieve > > >> > > > >> wrote: > > >> > Tarballs support symlinks. > > >> > npm uses tarballs. > > >> > "npm publish" lets you give a path to a tarball rather than > > >> > having > it > > >> pack > > >> > it for you. > > >> > > > >> > So, I think we probably could fix this in plugman by having it > create > > >> the > > >> > tgz more intelligently. > > >> > > > >> > > > >> > On Mon, Aug 18, 2014 at 2:24 PM, Ian Clelland < > iclell...@chromium.org > > > > > >> > wrote: > > >> > > > >> >> On Mon, Aug 18, 2014 at 12:40 PM, Brian LeRoux wrote: > > >> >> > > >> >> > I like the idea of not supporting them until I hear a really > great > > >> reason > > >> >> > to support them. =) > > >> >> > > > >> >> > > >> >> Certainly; YAGNI and all that. > > >> >> > > >> >> Ally
[GitHub] cordova-medic pull request: added Firefox OS
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-medic/pull/49#issuecomment-99508694 any update about it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-medic/pull/49#issuecomment-99524085 this PR is generating conflict with some files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Github user marti1125 closed the pull request at: https://github.com/apache/cordova-medic/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova Plugins with Symlinks
I think in this case we should be not be using symlinks. All of our output project types support adding a reference to a file or folder, we should leverage this directly. Of course, this could possibly lead to forward vs back slash issues, but should be easier than running hook hacks. At least I think we should explore this way. > On May 6, 2015, at 7:53 AM, Chuck Lantz wrote: > > Hey folks, > > So I’ve started to see some issues come up with certain Cordova plugins > when devs are mixing a Windows and OSX environment together when developing > an app. Digging into it a bit, it looks like root cause is that there are > some situations where iOS plugin implementations with custom frameworks that > require symlinks - as described in the thread below. > > In addition to the situation mentioned in the thread, there's a second one > worth calling out: installing a plugin with symlinks on Windows on the NTFS > file system results in the symlinks becoming files. > > The workaround described in this thread (zipping as a tarball) helps when > plugin installs happen on OSX, but it doesn't resolve the problem with NTFS. > If a development team is split between OSX and Windows machines, the plugin > will appear broken on iOS if it was committed/checked in/copied from Windows. > If, on the other hand, the plugin is added from OSX, it will work - the end > result is the behavior seems "glitchy" and it is not at all obvious what > happened when things go wrong. > > I came up with a hook that fixes these symlinks since the files that are > generated do contain the relative path to the underlying folder – but it is > admittedly a bit of a hack since it attempts to handle any arbitrary plugin: > https://github.com/Chuxel/taco-tricks/tree/master/ios-plugin-symlink-fix > > I think at a minimum, we should call this out in the plugin docs as a > potential issue with a workaround. > > However, It got me thinking, would the right thing here be to just provide > guidance to plugin authors to work around this problem Cordova plugin hook > to create the symlinks or should we develop a way for this to happen > automatically? Ex: A npm pre-publish hook persists symlinks in a file that > are then used before_compile on an OS that supports them. Or frameworks can > be referenced as tar balls in plugin.xml that are then untar'd as a > before_compile step. > > Thoughts? > > -Chuck > > -Original Message- > From: Ally Ogilvie [mailto:aogil...@wizcorp.jp] > Sent: Friday, September 5, 2014 3:31 AM > To: dev@cordova.apache.org > Subject: Re: Cordova Plugin Registry iOS frameworks > > Thanks Carlos. I'll take a look Monday. Have a good weekend. > > >> On Fri, Sep 5, 2014 at 4:06 AM, Carlos Santana wrote: >> >> Source code is here: >> >> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plug >> man/registry/registry.js#L97 >> >> I think the fix will be to create a tarball in some tmp after >> generating pacakgeJson, then calling npm .commands, 'publish', args >> with the tarball instead of a folder containing the package.json >> >> Have fun !, remember to add unit tests :-) >> >> >> >>> On Wed, Sep 3, 2014 at 10:37 PM, Ally Ogilvie wrote: >>> >>> I tried to find plugman source code responsible for npm publish but >> failed. >>> >>> I'm gonna bump this for someone to assign too.. any takers? <3 >>> >>> >>> >>> On Wed, Aug 20, 2014 at 12:12 PM, Ally Ogilvie >>> wrote: >>> > Ally, do you know if the symlinks are required for the > FacebookConnect framework? @Ian Absolutely required. Not just for Facebook, but all .framework >>> files. MyFramework.framework // (directory) info.plist MyFramework // (symbolic link to Versions/Current/MyFramework) Resources // (symbolic link to >>> Versions/Current/Resources) Headers // (symbolic link to >> Versions/Current/Headers) Versions// (directory) Current // (symbolic link to directory "A" below) A // (directory) Headers // (directory containing framework headers) Resources // (directory holding framework resources) MyFramework // (actual compiled library, really a .a >> file) As you can see there are 4 symbolic links in .frameworks. > On Tue, Aug 19, 2014 at 5:59 AM, Shazron wrote: > > I think the right approach is what Andrew suggested. So the > current workaround is to tarball it first then publish? > > On Mon, Aug 18, 2014 at 12:04 PM, Andrew Grieve > >> > wrote: >> Tarballs support symlinks. >> npm uses tarballs. >> "npm publish" lets you give a path to a tarball rather than >> having >> it > pack >> it for you. >> >> So, I think we probably could fix this in plugma
Re: Shorter URI for ci.ordova.io
Done and done. http://ci.cordova.io/ now redirects to the shorter URI. Thanks for putting in the work to clean it up, Dmitry. Michael On Tue, May 5, 2015 at 11:03 AM, Dmitry Blotsky wrote: > Hi Michael, > > > > We’ve added some goodies in Buildbot so our ci.cordova.io URI can be > shorter. We can now have it point to > http://ci.apache.org/waterfall?category=cordova. Whenever it is > convenient for you, please feel free to make the change. > > > > Many thanks! > > > > Kindly, > > Dmitry >
RE: Cordova Plugins with Symlinks
Yeah, I agree symlinks should be avoided, but what Ally highlighted below is
that it is required in this case. ("@Ian Absolutely required. Not just for
Facebook, but all .framework files.") Given that statement, it seems that in
this case we need to have some sort of solution to remediate the problem does
it not?
-Chuck
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Wednesday, May 6, 2015 9:16 AM
To: dev@cordova.apache.org
Subject: Re: Cordova Plugins with Symlinks
I think in this case we should be not be using symlinks. All of our output
project types support adding a reference to a file or folder, we should
leverage this directly.
Of course, this could possibly lead to forward vs back slash issues, but should
be easier than running hook hacks.
At least I think we should explore this way.
> On May 6, 2015, at 7:53 AM, Chuck Lantz wrote:
>
> Hey folks,
>
> So I’ve started to see some issues come up with certain Cordova plugins
> when devs are mixing a Windows and OSX environment together when developing
> an app. Digging into it a bit, it looks like root cause is that there are
> some situations where iOS plugin implementations with custom frameworks that
> require symlinks - as described in the thread below.
>
> In addition to the situation mentioned in the thread, there's a second one
> worth calling out: installing a plugin with symlinks on Windows on the NTFS
> file system results in the symlinks becoming files.
>
> The workaround described in this thread (zipping as a tarball) helps when
> plugin installs happen on OSX, but it doesn't resolve the problem with NTFS.
> If a development team is split between OSX and Windows machines, the plugin
> will appear broken on iOS if it was committed/checked in/copied from Windows.
> If, on the other hand, the plugin is added from OSX, it will work - the end
> result is the behavior seems "glitchy" and it is not at all obvious what
> happened when things go wrong.
>
> I came up with a hook that fixes these symlinks since the files that
> are generated do contain the relative path to the underlying folder
> – but it is admittedly a bit of a hack since it attempts to handle
> any arbitrary plugin:
> https://github.com/Chuxel/taco-tricks/tree/master/ios-plugin-symlink-f
> ix
>
> I think at a minimum, we should call this out in the plugin docs as a
> potential issue with a workaround.
>
> However, It got me thinking, would the right thing here be to just provide
> guidance to plugin authors to work around this problem Cordova plugin hook
> to create the symlinks or should we develop a way for this to happen
> automatically? Ex: A npm pre-publish hook persists symlinks in a file that
> are then used before_compile on an OS that supports them. Or frameworks can
> be referenced as tar balls in plugin.xml that are then untar'd as a
> before_compile step.
>
> Thoughts?
>
> -Chuck
>
> -Original Message-
> From: Ally Ogilvie [mailto:aogil...@wizcorp.jp]
> Sent: Friday, September 5, 2014 3:31 AM
> To: dev@cordova.apache.org
> Subject: Re: Cordova Plugin Registry iOS frameworks
>
> Thanks Carlos. I'll take a look Monday. Have a good weekend.
>
>
>> On Fri, Sep 5, 2014 at 4:06 AM, Carlos Santana wrote:
>>
>> Source code is here:
>>
>> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plu
>> g
>> man/registry/registry.js#L97
>>
>> I think the fix will be to create a tarball in some tmp after
>> generating pacakgeJson, then calling npm .commands, 'publish', args
>> with the tarball instead of a folder containing the package.json
>>
>> Have fun !, remember to add unit tests :-)
>>
>>
>>
>>> On Wed, Sep 3, 2014 at 10:37 PM, Ally Ogilvie wrote:
>>>
>>> I tried to find plugman source code responsible for npm publish but
>> failed.
>>>
>>> I'm gonna bump this for someone to assign too.. any takers? <3
>>>
>>>
>>>
>>> On Wed, Aug 20, 2014 at 12:12 PM, Ally Ogilvie
>>> wrote:
>>>
> Ally, do you know if the symlinks are required for the
> FacebookConnect
framework?
@Ian Absolutely required. Not just for Facebook, but all .framework
>>> files.
MyFramework.framework // (directory)
info.plist
MyFramework // (symbolic link to
Versions/Current/MyFramework)
Resources // (symbolic link to
>>> Versions/Current/Resources)
Headers // (symbolic link to
>> Versions/Current/Headers)
Versions// (directory)
Current // (symbolic link to directory "A" below)
A // (directory)
Headers // (directory containing framework headers)
Resources // (directory holding framework resources)
MyFramework // (actual compiled library, really a .a
>> file)
As you can see there are 4 symbolic links in .frameworks.
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99541999 It looks like these changes brought new test failures on wp8: https://issues.apache.org/jira/browse/CB-8968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8253 Fix potential unreleas...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99542404 @purplecabbage @goya could you please look at these failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova Plugins with Symlinks
Ordinarily I agree with Jesse's sentiment about not using symlinks but
that is just the reality for .frameworks.
That being said, I don't think we should do anything extra for authors
_but_ instead provide a middle ground that you mentioned "provide
guidance to plugin authors to work around this problem" and even as a
pre-publish (or analysis) step that checks whether this might be a
problem, and warns them.
On Wed, May 6, 2015 at 9:54 AM, Chuck Lantz wrote:
> Yeah, I agree symlinks should be avoided, but what Ally highlighted below is
> that it is required in this case. ("@Ian Absolutely required. Not just for
> Facebook, but all .framework files.") Given that statement, it seems that in
> this case we need to have some sort of solution to remediate the problem does
> it not?
>
> -Chuck
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Wednesday, May 6, 2015 9:16 AM
> To: dev@cordova.apache.org
> Subject: Re: Cordova Plugins with Symlinks
>
> I think in this case we should be not be using symlinks. All of our output
> project types support adding a reference to a file or folder, we should
> leverage this directly.
> Of course, this could possibly lead to forward vs back slash issues, but
> should be easier than running hook hacks.
> At least I think we should explore this way.
>
>
>> On May 6, 2015, at 7:53 AM, Chuck Lantz wrote:
>>
>> Hey folks,
>>
>> So I’ve started to see some issues come up with certain Cordova plugins
>> when devs are mixing a Windows and OSX environment together when developing
>> an app. Digging into it a bit, it looks like root cause is that there are
>> some situations where iOS plugin implementations with custom frameworks that
>> require symlinks - as described in the thread below.
>>
>> In addition to the situation mentioned in the thread, there's a second one
>> worth calling out: installing a plugin with symlinks on Windows on the NTFS
>> file system results in the symlinks becoming files.
>>
>> The workaround described in this thread (zipping as a tarball) helps when
>> plugin installs happen on OSX, but it doesn't resolve the problem with NTFS.
>> If a development team is split between OSX and Windows machines, the plugin
>> will appear broken on iOS if it was committed/checked in/copied from
>> Windows. If, on the other hand, the plugin is added from OSX, it will work -
>> the end result is the behavior seems "glitchy" and it is not at all obvious
>> what happened when things go wrong.
>>
>> I came up with a hook that fixes these symlinks since the files that
>> are generated do contain the relative path to the underlying folder
>> – but it is admittedly a bit of a hack since it attempts to handle
>> any arbitrary plugin:
>> https://github.com/Chuxel/taco-tricks/tree/master/ios-plugin-symlink-f
>> ix
>>
>> I think at a minimum, we should call this out in the plugin docs as a
>> potential issue with a workaround.
>>
>> However, It got me thinking, would the right thing here be to just provide
>> guidance to plugin authors to work around this problem Cordova plugin hook
>> to create the symlinks or should we develop a way for this to happen
>> automatically? Ex: A npm pre-publish hook persists symlinks in a file that
>> are then used before_compile on an OS that supports them. Or frameworks can
>> be referenced as tar balls in plugin.xml that are then untar'd as a
>> before_compile step.
>>
>> Thoughts?
>>
>> -Chuck
>>
>> -Original Message-
>> From: Ally Ogilvie [mailto:aogil...@wizcorp.jp]
>> Sent: Friday, September 5, 2014 3:31 AM
>> To: dev@cordova.apache.org
>> Subject: Re: Cordova Plugin Registry iOS frameworks
>>
>> Thanks Carlos. I'll take a look Monday. Have a good weekend.
>>
>>
>>> On Fri, Sep 5, 2014 at 4:06 AM, Carlos Santana wrote:
>>>
>>> Source code is here:
>>>
>>> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plu
>>> g
>>> man/registry/registry.js#L97
>>>
>>> I think the fix will be to create a tarball in some tmp after
>>> generating pacakgeJson, then calling npm .commands, 'publish', args
>>> with the tarball instead of a folder containing the package.json
>>>
>>> Have fun !, remember to add unit tests :-)
>>>
>>>
>>>
On Wed, Sep 3, 2014 at 10:37 PM, Ally Ogilvie wrote:
I tried to find plugman source code responsible for npm publish but
>>> failed.
I'm gonna bump this for someone to assign too.. any takers? <3
On Wed, Aug 20, 2014 at 12:12 PM, Ally Ogilvie
wrote:
>> Ally, do you know if the symlinks are required for the
>> FacebookConnect
> framework?
>
> @Ian Absolutely required. Not just for Facebook, but all .framework
files.
>
> MyFramework.framework // (directory)
> info.plist
> MyFramework // (symbolic link to
> Versions/Current/MyFramework)
> Resources // (symbolic link to
Versions/Current/Resources)
>
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99544620 > It looks like these changes brought new test failures on wp8: > https://issues.apache.org/jira/browse/CB-8968 @alsorokin I will take a look as well. Cannot promise I will find anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99545354 Should the plugin.xml for this plugin be updated to specify that this version of the plugin now only will work with cordova-wp8 4.0 and greater? I believe you can use the `engine` tag to do so - http://cordova.apache.org/docs/en/5.0.0/plugin_ref_spec.md.html#Plugin%20Specification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Cordova Plugins with Symlinks
It should be possible for our build system to convert some metadata into
symlinks which are fed to whatever build thing actually requires them, but
allows us to not have genuine symlinks in the working directory.
The BlackBerry 10 project copies all the files it wants to package over into
another directory, other platforms should be able to do similar.
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Wednesday, May 06, 2015 1:23 PM
> To: dev@cordova.apache.org
> Subject: Re: Cordova Plugins with Symlinks
>
> Ordinarily I agree with Jesse's sentiment about not using symlinks but
> that is just the reality for .frameworks.
>
> That being said, I don't think we should do anything extra for authors
> _but_ instead provide a middle ground that you mentioned "provide
> guidance to plugin authors to work around this problem" and even as a
> pre-publish (or analysis) step that checks whether this might be a
> problem, and warns them.
>
> On Wed, May 6, 2015 at 9:54 AM, Chuck Lantz
> wrote:
> > Yeah, I agree symlinks should be avoided, but what Ally highlighted below
> is that it is required in this case. ("@Ian Absolutely required. Not just for
> Facebook, but all .framework files.") Given that statement, it seems that in
> this case we need to have some sort of solution to remediate the problem
> does it not?
> >
> > -Chuck
> >
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Wednesday, May 6, 2015 9:16 AM
> > To: dev@cordova.apache.org
> > Subject: Re: Cordova Plugins with Symlinks
> >
> > I think in this case we should be not be using symlinks. All of our output
> project types support adding a reference to a file or folder, we should
> leverage this directly.
> > Of course, this could possibly lead to forward vs back slash issues, but
> should be easier than running hook hacks.
> > At least I think we should explore this way.
> >
> >
> >> On May 6, 2015, at 7:53 AM, Chuck Lantz wrote:
> >>
> >> Hey folks,
> >>
> >> So I’ve started to see some issues come up with certain Cordova
> plugins when devs are mixing a Windows and OSX environment together
> when developing an app. Digging into it a bit, it looks like root cause is
> that
> there are some situations where iOS plugin implementations with custom
> frameworks that require symlinks - as described in the thread below.
> >>
> >> In addition to the situation mentioned in the thread, there's a second one
> worth calling out: installing a plugin with symlinks on Windows on the NTFS
> file system results in the symlinks becoming files.
> >>
> >> The workaround described in this thread (zipping as a tarball) helps when
> plugin installs happen on OSX, but it doesn't resolve the problem with NTFS.
> If a development team is split between OSX and Windows machines, the
> plugin will appear broken on iOS if it was committed/checked in/copied from
> Windows. If, on the other hand, the plugin is added from OSX, it will work -
> the end result is the behavior seems "glitchy" and it is not at all obvious
> what
> happened when things go wrong.
> >>
> >> I came up with a hook that fixes these symlinks since the files that
> >> are generated do contain the relative path to the underlying folder
> >> – but it is admittedly a bit of a hack since it attempts to handle
> >> any arbitrary plugin:
> >> https://github.com/Chuxel/taco-tricks/tree/master/ios-plugin-symlink-f
> >> ix
> >>
> >> I think at a minimum, we should call this out in the plugin docs as a
> potential issue with a workaround.
> >>
> >> However, It got me thinking, would the right thing here be to just provide
> guidance to plugin authors to work around this problem Cordova plugin hook
> to create the symlinks or should we develop a way for this to happen
> automatically? Ex: A npm pre-publish hook persists symlinks in a file that
> are
> then used before_compile on an OS that supports them. Or frameworks can
> be referenced as tar balls in plugin.xml that are then untar'd as a
> before_compile step.
> >>
> >> Thoughts?
> >>
> >> -Chuck
> >>
> >> -Original Message-
> >> From: Ally Ogilvie [mailto:aogil...@wizcorp.jp]
> >> Sent: Friday, September 5, 2014 3:31 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: Cordova Plugin Registry iOS frameworks
> >>
> >> Thanks Carlos. I'll take a look Monday. Have a good weekend.
> >>
> >>
> >>> On Fri, Sep 5, 2014 at 4:06 AM, Carlos Santana
> wrote:
> >>>
> >>> Source code is here:
> >>>
> >>> https://github.com/apache/cordova-lib/blob/master/cordova-
> lib/src/plu
> >>> g
> >>> man/registry/registry.js#L97
> >>>
> >>> I think the fix will be to create a tarball in some tmp after
> >>> generating pacakgeJson, then calling npm .commands, 'publish', args
> >>> with the tarball instead of a folder containing the package.json
> >>>
> >>> Have fun !, remember to add unit tests :-)
> >>>
> >>>
> >>>
> On Wed, Sep 3, 2014 at 10:37 PM, Ally Ogilvie
> wrote:
>
> I tri
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/74#issuecomment-99556720 If you decide to use the `preference` approach - make sure you document it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: Update setting-up-gpg.md
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-coho/pull/77 Update setting-up-gpg.md Add --keyserver for gnupg You can merge this pull request into a Git repository by running: $ git pull https://github.com/muratsu/cordova-coho patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit ee287f2d8f2510e1c2b14aab53129a74634415d9 Author: Murat Sutunc Date: 2015-05-06T18:17:51Z Update setting-up-gpg.md Add --keyserver for gnupg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Cordova Plugins with Symlinks
Yeah that was one of the alternatives I was thinking about as a part of that
pre-publish step I mentioned. Really, you'd need to either:
1. Provide a general mechanism for all symlinks using a metadata file
a. Prep-publish: Run through and find paths to symlinks (which is easy
to do with node), store in a json file with the plugin
b. After Platform Add / Plugin Add, or just Before Compile: Use the
metadata file to generate the symlinks if OS = OSX or Linux
2. Provide a specific mechanism to deal with frameworks
a. Pre-publish: Find custom frameworks. (Which you can actually do
using plugin.xml), tgz them
b. After Platform Add / Plugin Add, or just Before Compile: Expand
framework tgz if found
(a) could be done via npm but (b) really has to be done via a Cordova hook or
be inherent to the iOS platform.
Maybe the thing to do is to develop these hooks and add them to the default
template for plugins and in addition to the docs. #1 is likely a bit more
robust.
-Chuck
-Original Message-
From: Josh Soref [mailto:jso...@blackberry.com]
Sent: Wednesday, May 6, 2015 11:05 AM
To: dev@cordova.apache.org
Subject: RE: Cordova Plugins with Symlinks
It should be possible for our build system to convert some metadata into
symlinks which are fed to whatever build thing actually requires them, but
allows us to not have genuine symlinks in the working directory.
The BlackBerry 10 project copies all the files it wants to package over into
another directory, other platforms should be able to do similar.
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Wednesday, May 06, 2015 1:23 PM
> To: dev@cordova.apache.org
> Subject: Re: Cordova Plugins with Symlinks
>
> Ordinarily I agree with Jesse's sentiment about not using symlinks but
> that is just the reality for .frameworks.
>
> That being said, I don't think we should do anything extra for authors
> _but_ instead provide a middle ground that you mentioned "provide
> guidance to plugin authors to work around this problem" and even as a
> pre-publish (or analysis) step that checks whether this might be a
> problem, and warns them.
>
> On Wed, May 6, 2015 at 9:54 AM, Chuck Lantz
> wrote:
> > Yeah, I agree symlinks should be avoided, but what Ally highlighted below
> is that it is required in this case. ("@Ian Absolutely required. Not just for
> Facebook, but all .framework files.") Given that statement, it seems that in
> this case we need to have some sort of solution to remediate the problem
> does it not?
> >
> > -Chuck
> >
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Wednesday, May 6, 2015 9:16 AM
> > To: dev@cordova.apache.org
> > Subject: Re: Cordova Plugins with Symlinks
> >
> > I think in this case we should be not be using symlinks. All of our output
> project types support adding a reference to a file or folder, we should
> leverage this directly.
> > Of course, this could possibly lead to forward vs back slash issues, but
> should be easier than running hook hacks.
> > At least I think we should explore this way.
> >
> >
> >> On May 6, 2015, at 7:53 AM, Chuck Lantz wrote:
> >>
> >> Hey folks,
> >>
> >> So I’ve started to see some issues come up with certain Cordova
> plugins when devs are mixing a Windows and OSX environment together
> when developing an app. Digging into it a bit, it looks like root cause is
> that
> there are some situations where iOS plugin implementations with custom
> frameworks that require symlinks - as described in the thread below.
> >>
> >> In addition to the situation mentioned in the thread, there's a second one
> worth calling out: installing a plugin with symlinks on Windows on the NTFS
> file system results in the symlinks becoming files.
> >>
> >> The workaround described in this thread (zipping as a tarball) helps when
> plugin installs happen on OSX, but it doesn't resolve the problem with NTFS.
> If a development team is split between OSX and Windows machines, the
> plugin will appear broken on iOS if it was committed/checked in/copied from
> Windows. If, on the other hand, the plugin is added from OSX, it will work -
> the end result is the behavior seems "glitchy" and it is not at all obvious
> what
> happened when things go wrong.
> >>
> >> I came up with a hook that fixes these symlinks since the files that
> >> are generated do contain the relative path to the underlying folder
> >> – but it is admittedly a bit of a hack since it attempts to handle
> >> any arbitrary plugin:
> >> https://github.com/Chuxel/taco-tricks/tree/master/ios-plugin-symlink-f
> >> ix
> >>
> >> I think at a minimum, we should call this out in the plugin docs as a
> potential issue with a workaround.
> >>
> >> However, It got me thinking, would the right thing here be to just provide
> guidance to plugin authors to work around this problem Cordova plugin hook
> to create the symlinks or should we develop a way f
Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple
Okay cool. Version should be cordova-js@3.9.1. Then I'll release Android@4.0.1, wp8@3.8.1, windows@3.8.2. These releases will only have updated cordova.js files and nothing else new (patch release). I'll start up some discuss threads On Tue, May 5, 2015 at 9:13 PM, Jesse wrote: > This fix has been merged ( your way Tim ) > Steve, can we do a minor bump of all platforms that included cordova-js > >3.8.2 ? > This will be a 3.9.2 cordova-js release I think, and appropriately enough > has a ripple effect into platforms and tools. > > @purplecabbage > risingj.com > > On Mon, May 4, 2015 at 7:30 PM, Tim Barham > wrote: > > > Yep, I verified your change fixes the failure with Ripple (in fact, just > > the 'window.cordova' check is enough to fix Ripple, since that returns > > undefined). > > > > > > From: Jesse > > Sent: Tuesday, May 5, 2015 10:53 AM > > To: dev@cordova.apache.org > > Subject: Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple > > > > Discussions aside, are you in a position to test ripple? > > > > I believe this change will fix it, can you try this change, and I will > look > > into the ripple side shortly? > > https://github.com/apache/cordova-js/pull/109 > > > > We can start the re-release fanfare in the morning, as a minor release > > directly from the last release and a minor bump with no other changes > > coming in. > > > > Let me know if there are still issues in cordova-js, and I'll look later > > tonite. > > > > Cheers, > >Jesse > > > > > > > > > > @purplecabbage > > risingj.com > > > > On Mon, May 4, 2015 at 5:23 PM, Tim Barham > > wrote: > > > > > Thanks Jesse... > > > > > > > but still it will be at least a week before we can get a new > everything > > > out > > > > > > And the alternatives will take less than a week? :) > > > > > > While I agree there may be better ways for Ripple to "do it's thing", > my > > > immediate concern is to get Ripple working as quickly as possible. If > we > > > can indeed kill those two birds with one stone, that's great, but I'm > > > worried that anything beyond a simple fix will drag out for quite a > > while. > > > > > > Also, I was picturing these sorts of changes as being part of proper > > > plugin simulation support built into Cordova (that is, the ongoing > > project > > > I've mentioned previously) - I wonder if for now we should just fix > this > > > the quickest way we can, and make sure the appropriate, public, > > documented > > > hooks are in place as part of that project. > > > > > > > override the entire cordova object > > > > > > BTW, I guess you already know this, but to make sure it is clear - > Ripple > > > doesn't override the cordova object - it only overrides cordova/exec. > It > > > intercepts the creation of the cordova property so it can immediately > > patch > > > cordova/exec before it can get called by anyone. It seems to me that > > > patching cordova/exec is pretty fundamental to how Ripple works, but if > > > there was another way it could ensure the correct timing (that is, > patch > > > cordova/exec after the cordova object is created, but before it can > ever > > > get called), that would probably suffice. > > > > > > I don't think cordova/exec/proxy is going to be a viable solution (at > > > least as it currently works) - isn't there the risk that that will get > > > overridden by plugins themselves? Also, Ripple wants to intercept *any* > > > cordova.exec call, even ones it doesn't know about (so it can display > UI > > to > > > handle those cases) - how to we handle that using cordova/exec/proxy? > > > > > > Thanks for looking into this, BTW. > > > > > > Tim > > > > > > > > > From: Jesse > > > Sent: Tuesday, May 5, 2015 9:57 AM > > > To: dev@cordova.apache.org > > > Subject: Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple > > > > > > Yeah, my reasoning is that it is difficult to update all the affected > > bits > > > in cordova. We can change the cordova logic, but still it will be at > > least > > > a week before we can get a new everything out. > > > > > > Part of my reasoning is that ripple claims to be a '... platform > agnostic > > > mobile application development and testing tool.' We should make that > > part > > > true as well. > > > > > > Personally, I consider ripple's use of 'cordova' to be risky given that > > we > > > have certain expectations of how our own library works, which may or > may > > > not be private to cordova. I would much rather see ripple implement a > > > ripple-cordova connector class which uses cordova/exec/proxy or some > > > cordova apis that we purposely publish, which is what I plan to look > into > > > this week. Or we can consider moving to a model where we do define a > way > > to > > > override the entire cordova object, and document it. > > > > > > > > > @purplecabbage > > > risingj.com > > > > > > On Mon, May 4, 2015 at 3:56 PM, Tim Barham > > > wrote: > > > > >
Re: [GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Yes, absolutely. But, this is a major version jump, so breakage IS expected. All plugins could have issues, the first step is to properly define the 'engines' in the plugin.xml to declare what versions you work with. @purplecabbage risingj.com On Wed, May 6, 2015 at 10:28 AM, brodybits wrote: > Github user brodybits commented on the pull request: > > https://github.com/apache/cordova-wp8/pull/79#issuecomment-99544620 > > > It looks like these changes brought new test failures on wp8: > > https://issues.apache.org/jira/browse/CB-8968 > > @alsorokin I will take a look as well. Cannot promise I will find > anything. > > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Plugins release prep: Cherry-picking plugin updates
I haven't heard back. Should I move forward with those 5 plugins? file-transfer, device-motion, dialogs, vibration, and camera. I will update the process to support specific plugins release (instead of all plugins) as I work through it. On Tue, May 5, 2015 at 12:29 PM, Jesse wrote: > + file-transfer so we can resolve CB-8951 > > > @purplecabbage > risingj.com > > On Tue, May 5, 2015 at 12:19 PM, Steven Gill > wrote: > > > Hey guys, > > > > I can help you out. The process is designed for all plugins but it is > > pretty easy to do it for just a few. I've done it many times. > > > > If changes are on master, they shouldn't be incomplete. Any known problem > > with release the master branch of those plugins? > > > > We could cherry-pick, but it is just more work than probably required. > > Since we don't have release branches for plugins, just tags. > > > > If you guys merge changes into master, I can take over the release or at > > least tell you the parts to modify in the release process to make it > work. > > > > -Steve > > > > On Tue, May 5, 2015 at 11:44 AM, Rob Paveza > > wrote: > > > > > Hi all - > > > > > > I started a [discuss] thread about plugin updates last week, > effectively > > > saying that we wanted to take four JIRA items which are causing > problems > > > for Windows 10: CB-8926, CB-8928, CB-8930, and CB-8943. Since Murat > is a > > > committer, he's actually trying to do the release. We're looking at > > > device-motion, dialogs, vibration, and camera. > > > > > > However, as we go through the [release process]( > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > > ), > > > there are a lot of things that give us pause, specifically that we're > > going > > > to end up tagging each plugin rather than just the four. We're also > > > concerned that we'll bring in unstable or not-yet-completed changes > from > > > 'master' in some of the plugins. Instead, we're trying to cherry-pick. > > > > > > So, we know that where the final state is supposed to be: > > > - Each plugin that we're updating gets a new tag with a build-version > > bump > > > - The branch that we submitted as the PR should become the new tag > (since > > > it was based on the previous release tag) > > > - Then we'll go on with the rest of the publish-to-NPM work, etc. > > > > > > Since all of the steps are automated, is there a straightforward way to > > > cherry-pick the individual pieces that is known and has been used > before? > > > Or are we in new territory? > > > > > > Thanks! > > > -Rob and Murat > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > >
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99575104 yes, these changes need to happen together, and the engine tag is how that is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release
Need to do patch releases for these three platforms with updated cordova.js files due to bug with ripple https://issues.apache.org/jira/browse/RIPPLE-82 . I will do it on the respective release branches and not master so new changes won't make it into these releases. Thoughts?
[GitHub] cordova-plugin-camera pull request: CB-8943 fix PickAndContinue is...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/92 CB-8943 fix PickAndContinue issue on Win10Phone -fix PickAndContinue issue on WindowsPhone 10 -fix emulator not correctly taking pictures WindowsPhone 8.1 -change default save location from Documents to Pictures You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera win10merge Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit 69c687e0cfd78ba39dd36157d3e84addbb2a8e32 Author: Murat Sutunc Date: 2015-05-06T17:49:05Z CB-8943 fix PickAndContinue issue on Win10Phone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8943 fix PickAndContinue is...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Plugins release prep: Cherry-picking plugin updates
Murat is still working on the merge to master for the Camera plugin. I'll let you know when we're all squared away. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 6, 2015 11:57 AM To: dev@cordova.apache.org Subject: Re: Plugins release prep: Cherry-picking plugin updates I haven't heard back. Should I move forward with those 5 plugins? file-transfer, device-motion, dialogs, vibration, and camera. I will update the process to support specific plugins release (instead of all plugins) as I work through it. On Tue, May 5, 2015 at 12:29 PM, Jesse wrote: > + file-transfer so we can resolve CB-8951 > > > @purplecabbage > risingj.com > > On Tue, May 5, 2015 at 12:19 PM, Steven Gill > wrote: > > > Hey guys, > > > > I can help you out. The process is designed for all plugins but it > > is pretty easy to do it for just a few. I've done it many times. > > > > If changes are on master, they shouldn't be incomplete. Any known > > problem with release the master branch of those plugins? > > > > We could cherry-pick, but it is just more work than probably required. > > Since we don't have release branches for plugins, just tags. > > > > If you guys merge changes into master, I can take over the release > > or at least tell you the parts to modify in the release process to > > make it > work. > > > > -Steve > > > > On Tue, May 5, 2015 at 11:44 AM, Rob Paveza > > > > wrote: > > > > > Hi all - > > > > > > I started a [discuss] thread about plugin updates last week, > effectively > > > saying that we wanted to take four JIRA items which are causing > problems > > > for Windows 10: CB-8926, CB-8928, CB-8930, and CB-8943. Since > > > Murat > is a > > > committer, he's actually trying to do the release. We're looking > > > at device-motion, dialogs, vibration, and camera. > > > > > > However, as we go through the [release process]( > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-releas > e-process.md > > ), > > > there are a lot of things that give us pause, specifically that > > > we're > > going > > > to end up tagging each plugin rather than just the four. We're > > > also concerned that we'll bring in unstable or not-yet-completed > > > changes > from > > > 'master' in some of the plugins. Instead, we're trying to cherry-pick. > > > > > > So, we know that where the final state is supposed to be: > > > - Each plugin that we're updating gets a new tag with a > > > build-version > > bump > > > - The branch that we submitted as the PR should become the new tag > (since > > > it was based on the previous release tag) > > > - Then we'll go on with the rest of the publish-to-NPM work, etc. > > > > > > Since all of the steps are automated, is there a straightforward > > > way to cherry-pick the individual pieces that is known and has > > > been used > before? > > > Or are we in new territory? > > > > > > Thanks! > > > -Rob and Murat > > > > > > -- > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Plugins release prep: Cherry-picking plugin updates
Sounds good. Thanks Rob On Wed, May 6, 2015 at 12:04 PM, Rob Paveza wrote: > Murat is still working on the merge to master for the Camera plugin. I'll > let you know when we're all squared away. > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Wednesday, May 6, 2015 11:57 AM > To: dev@cordova.apache.org > Subject: Re: Plugins release prep: Cherry-picking plugin updates > > I haven't heard back. Should I move forward with those 5 plugins? > > file-transfer, device-motion, dialogs, vibration, and camera. > > I will update the process to support specific plugins release (instead of > all plugins) as I work through it. > > > On Tue, May 5, 2015 at 12:29 PM, Jesse wrote: > > > + file-transfer so we can resolve CB-8951 > > > > > > @purplecabbage > > risingj.com > > > > On Tue, May 5, 2015 at 12:19 PM, Steven Gill > > wrote: > > > > > Hey guys, > > > > > > I can help you out. The process is designed for all plugins but it > > > is pretty easy to do it for just a few. I've done it many times. > > > > > > If changes are on master, they shouldn't be incomplete. Any known > > > problem with release the master branch of those plugins? > > > > > > We could cherry-pick, but it is just more work than probably required. > > > Since we don't have release branches for plugins, just tags. > > > > > > If you guys merge changes into master, I can take over the release > > > or at least tell you the parts to modify in the release process to > > > make it > > work. > > > > > > -Steve > > > > > > On Tue, May 5, 2015 at 11:44 AM, Rob Paveza > > > > > > wrote: > > > > > > > Hi all - > > > > > > > > I started a [discuss] thread about plugin updates last week, > > effectively > > > > saying that we wanted to take four JIRA items which are causing > > problems > > > > for Windows 10: CB-8926, CB-8928, CB-8930, and CB-8943. Since > > > > Murat > > is a > > > > committer, he's actually trying to do the release. We're looking > > > > at device-motion, dialogs, vibration, and camera. > > > > > > > > However, as we go through the [release process]( > > > > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-releas > > e-process.md > > > ), > > > > there are a lot of things that give us pause, specifically that > > > > we're > > > going > > > > to end up tagging each plugin rather than just the four. We're > > > > also concerned that we'll bring in unstable or not-yet-completed > > > > changes > > from > > > > 'master' in some of the plugins. Instead, we're trying to > cherry-pick. > > > > > > > > So, we know that where the final state is supposed to be: > > > > - Each plugin that we're updating gets a new tag with a > > > > build-version > > > bump > > > > - The branch that we submitted as the PR should become the new tag > > (since > > > > it was based on the previous release tag) > > > > - Then we'll go on with the rest of the publish-to-NPM work, etc. > > > > > > > > Since all of the steps are automated, is there a straightforward > > > > way to cherry-pick the individual pieces that is known and has > > > > been used > > before? > > > > Or are we in new territory? > > > > > > > > Thanks! > > > > -Rob and Murat > > > > > > > > -- > > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[GitHub] cordova-plugin-device-motion pull request: CB-8926: The tests modu...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-8928: prompt fails if toSt...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8674: Creates a 'cordova.env' object.....
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Change folder save Windows. An...
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/73#issuecomment-99581264 Most of this functionality is in Camera now. I think you can close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8931 Replace all sla...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/76#issuecomment-99604158 LGTM @vladimir-kotikov Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Plugins release prep: Cherry-picking plugin updates
Hey, took me a while but we're good to go with: Camera, device-motion, dialogs and vibration. Thanks! -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 6, 2015 12:16 PM To: dev@cordova.apache.org Subject: Re: Plugins release prep: Cherry-picking plugin updates Sounds good. Thanks Rob On Wed, May 6, 2015 at 12:04 PM, Rob Paveza wrote: > Murat is still working on the merge to master for the Camera plugin. > I'll let you know when we're all squared away. > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Wednesday, May 6, 2015 11:57 AM > To: dev@cordova.apache.org > Subject: Re: Plugins release prep: Cherry-picking plugin updates > > I haven't heard back. Should I move forward with those 5 plugins? > > file-transfer, device-motion, dialogs, vibration, and camera. > > I will update the process to support specific plugins release (instead > of all plugins) as I work through it. > > > On Tue, May 5, 2015 at 12:29 PM, Jesse wrote: > > > + file-transfer so we can resolve CB-8951 > > > > > > @purplecabbage > > risingj.com > > > > On Tue, May 5, 2015 at 12:19 PM, Steven Gill > > > > wrote: > > > > > Hey guys, > > > > > > I can help you out. The process is designed for all plugins but it > > > is pretty easy to do it for just a few. I've done it many times. > > > > > > If changes are on master, they shouldn't be incomplete. Any known > > > problem with release the master branch of those plugins? > > > > > > We could cherry-pick, but it is just more work than probably required. > > > Since we don't have release branches for plugins, just tags. > > > > > > If you guys merge changes into master, I can take over the release > > > or at least tell you the parts to modify in the release process to > > > make it > > work. > > > > > > -Steve > > > > > > On Tue, May 5, 2015 at 11:44 AM, Rob Paveza > > > > > > wrote: > > > > > > > Hi all - > > > > > > > > I started a [discuss] thread about plugin updates last week, > > effectively > > > > saying that we wanted to take four JIRA items which are causing > > problems > > > > for Windows 10: CB-8926, CB-8928, CB-8930, and CB-8943. Since > > > > Murat > > is a > > > > committer, he's actually trying to do the release. We're > > > > looking at device-motion, dialogs, vibration, and camera. > > > > > > > > However, as we go through the [release process]( > > > > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-rele > > as > > e-process.md > > > ), > > > > there are a lot of things that give us pause, specifically that > > > > we're > > > going > > > > to end up tagging each plugin rather than just the four. We're > > > > also concerned that we'll bring in unstable or not-yet-completed > > > > changes > > from > > > > 'master' in some of the plugins. Instead, we're trying to > cherry-pick. > > > > > > > > So, we know that where the final state is supposed to be: > > > > - Each plugin that we're updating gets a new tag with a > > > > build-version > > > bump > > > > - The branch that we submitted as the PR should become the new > > > > tag > > (since > > > > it was based on the previous release tag) > > > > - Then we'll go on with the rest of the publish-to-NPM work, etc. > > > > > > > > Since all of the steps are automated, is there a straightforward > > > > way to cherry-pick the individual pieces that is known and has > > > > been used > > before? > > > > Or are we in new territory? > > > > > > > > Thanks! > > > > -Rob and Murat > > > > > > > > > > > > -- > > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99611924 > It looks like these changes brought new test failures on wp8: > https://issues.apache.org/jira/browse/CB-8968 Can someone describe how I would run these cordova-plugin-file tests for wp8? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent
Github user sinofool commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99629530 I will update the docs later. For both iOS and Android. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple
Thanks Steve! From: Steven Gill Sent: Thursday, May 7, 2015 4:53 AM To: dev@cordova.apache.org Subject: Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple Okay cool. Version should be cordova-js@3.9.1. Then I'll release Android@4.0.1, wp8@3.8.1, windows@3.8.2. These releases will only have updated cordova.js files and nothing else new (patch release). I'll start up some discuss threads On Tue, May 5, 2015 at 9:13 PM, Jesse wrote: > This fix has been merged ( your way Tim ) > Steve, can we do a minor bump of all platforms that included cordova-js > >3.8.2 ? > This will be a 3.9.2 cordova-js release I think, and appropriately enough > has a ripple effect into platforms and tools. > > @purplecabbage > risingj.com > > On Mon, May 4, 2015 at 7:30 PM, Tim Barham > wrote: > > > Yep, I verified your change fixes the failure with Ripple (in fact, just > > the 'window.cordova' check is enough to fix Ripple, since that returns > > undefined). > > > > > > From: Jesse > > Sent: Tuesday, May 5, 2015 10:53 AM > > To: dev@cordova.apache.org > > Subject: Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple > > > > Discussions aside, are you in a position to test ripple? > > > > I believe this change will fix it, can you try this change, and I will > look > > into the ripple side shortly? > > https://github.com/apache/cordova-js/pull/109 > > > > We can start the re-release fanfare in the morning, as a minor release > > directly from the last release and a minor bump with no other changes > > coming in. > > > > Let me know if there are still issues in cordova-js, and I'll look later > > tonite. > > > > Cheers, > >Jesse > > > > > > > > > > @purplecabbage > > risingj.com > > > > On Mon, May 4, 2015 at 5:23 PM, Tim Barham > > wrote: > > > > > Thanks Jesse... > > > > > > > but still it will be at least a week before we can get a new > everything > > > out > > > > > > And the alternatives will take less than a week? :) > > > > > > While I agree there may be better ways for Ripple to "do it's thing", > my > > > immediate concern is to get Ripple working as quickly as possible. If > we > > > can indeed kill those two birds with one stone, that's great, but I'm > > > worried that anything beyond a simple fix will drag out for quite a > > while. > > > > > > Also, I was picturing these sorts of changes as being part of proper > > > plugin simulation support built into Cordova (that is, the ongoing > > project > > > I've mentioned previously) - I wonder if for now we should just fix > this > > > the quickest way we can, and make sure the appropriate, public, > > documented > > > hooks are in place as part of that project. > > > > > > > override the entire cordova object > > > > > > BTW, I guess you already know this, but to make sure it is clear - > Ripple > > > doesn't override the cordova object - it only overrides cordova/exec. > It > > > intercepts the creation of the cordova property so it can immediately > > patch > > > cordova/exec before it can get called by anyone. It seems to me that > > > patching cordova/exec is pretty fundamental to how Ripple works, but if > > > there was another way it could ensure the correct timing (that is, > patch > > > cordova/exec after the cordova object is created, but before it can > ever > > > get called), that would probably suffice. > > > > > > I don't think cordova/exec/proxy is going to be a viable solution (at > > > least as it currently works) - isn't there the risk that that will get > > > overridden by plugins themselves? Also, Ripple wants to intercept *any* > > > cordova.exec call, even ones it doesn't know about (so it can display > UI > > to > > > handle those cases) - how to we handle that using cordova/exec/proxy? > > > > > > Thanks for looking into this, BTW. > > > > > > Tim > > > > > > > > > From: Jesse > > > Sent: Tuesday, May 5, 2015 9:57 AM > > > To: dev@cordova.apache.org > > > Subject: Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple > > > > > > Yeah, my reasoning is that it is difficult to update all the affected > > bits > > > in cordova. We can change the cordova logic, but still it will be at > > least > > > a week before we can get a new everything out. > > > > > > Part of my reasoning is that ripple claims to be a '... platform > agnostic > > > mobile application development and testing tool.' We should make that > > part > > > true as well. > > > > > > Personally, I consider ripple's use of 'cordova' to be risky given that > > we > > > have certain expectations of how our own library works, which may or > may > > > not be private to cordova. I would much rather see ripple implement a > > > ripple-cordova connector class which uses cordova/exec/proxy or some > > > cordova apis that we purposely publish, which is what I plan to look > into > > > this week. Or we can consider moving to a model where we do defi
[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent
Github user shazron commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99633548 @sinofool There is already an issue for the iOS Doc CB-8960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release
Sounds good to me. Once this is done, will we need to do a tools release to update pinned platforms (which makes me wonder - should we set the version of pinned platforms to something like "4.0.x" so we don't need to update tools when we do a platform patch release)? From: Steven Gill Sent: Thursday, May 7, 2015 5:00 AM To: dev@cordova.apache.org Subject: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release Need to do patch releases for these three platforms with updated cordova.js files due to bug with ripple https://issues.apache.org/jira/browse/RIPPLE-82 . I will do it on the respective release branches and not master so new changes won't make it into these releases. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/12 CB-8973: Changed the functionality of making the log appear and disappear When the log appears, it appears over the "content" area, which means (for example) on the Manual Tests page, some tests are impossible to see. This change alters the log show/hide implementation, such that instead of modifying the #log class list, it modifies the body class list, and the #middle and #log elements adjust their appearances based on having body.expanded-log selector. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8973 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit e547f2f18c908c1471fa807c1e9439c401fee0cf Author: Rob Paveza Date: 2015-05-06T23:36:23Z CB-8973: Changed the functionality of making the log appear and disappear from modifying the #log class list, to modifying the body class list, and having the #middle and #log elements adjust their appearances based on having body.expanded-log selector. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Plugins Release (camera, file-transfer, dialogs, vibration, device-motion)
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-8959 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8959/ The packages were published from their corresponding git tags: cordova-plugin-camera: 1.1.0 (19feee9cb0) cordova-plugin-file-transfer: 1.1.0 (e251db5cac) cordova-plugin-device-motion: 1.1.0 (7d52b8457d) cordova-plugin-dialogs: 1.1.0 (439372988b) cordova-plugin-vibration: 1.1.0 (4d316e2555) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
Re: Also moving to a new team
Little bit late, but anyway. Good luck on your team. You help me a lot merging stuff to Docs. :) 2015-05-06 2:22 GMT+06:00 Tommy-Carlos Williams : > Wow. Real "end of an era" stuff here. > > Your tireless work for Cordova will be big shoes indeed. > > Good luck on the Chrome team. It's been a pleasure. > > > > > On 6 May 2015, at 05:36, Steven Gill wrote: > > > > Andrew, it has been a pleasure to work with you these last few years! > Good > > luck on your new team!! > > > >> On Tue, May 5, 2015 at 11:11 AM, Ryan J. Salva > wrote: > >> > >> Thanks for all you've done for the project, Andrew and Michal. I'm sure > >> we'll cross paths again sometime soon. In the meantime, I can't wait to > see > >> what you create with the Physical Web. It looks like a super-cool > project. > >> I only expect great things :-) > >> > >> rjs > >> > >> Ryan J. Salva | Principal Program Manager Lead > >> Visual Studio Tools for Apache Cordova > >> rsa...@microsoft.com > >> 425 706 5270 office > >> 206 612 5079 mobile > >> > >> > >> > >> My team is hiring. > >> > >> -Original Message- > >> From: agri...@google.com [mailto:agri...@google.com] On Behalf Of > Andrew > >> Grieve > >> Sent: Tuesday, May 5, 2015 9:16 AM > >> To: dev > >> Subject: Also moving to a new team > >> > >> As with Michal, you'll be seeing less of me around. My new full-time > >> project will be on the Android port of Chrome. > >> > >> Just want to make it clear that us moving to new teams has nothing to do > >> with a lack of faith in the project, but rather is due to needing a > change > >> of scenery and exciting new projects becoming available here. > >> > >> I'm super excited to see a new wave of committers joining the project! > The > >> momentum has certainly picked up: > >> - Cordova-android 4.0.0 was huge > >> - Plugins to npm was huge > >> - Win10 and wkwebview will be massive launches as well! > >> > >> Great time for Cordova! (or a bad one... you know... if you're measuring > >> against the goal of becoming obsolete :P) > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
RE: No Readme for plugin packages on npm
Thanks, Steven! Do you have a pointer to the issue? In case they can't get do this soon - perhaps we should explore a workaround. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, April 23, 2015 6:34 PM To: dev@cordova.apache.org Subject: Re: No Readme for plugin packages on npm I filed the issue a few days ago with npm. They are working on fixing it. The parser is struggling with html comments On Apr 23, 2015 6:14 PM, "Nikhil Khandelwal" wrote: > It looks like npm cannot find the readme for plugin packages: > https://www.npmjs.com/package/cordova-plugin-battery-status > > Github can find it just fine though: > https://github.com/apache/cordova-plugin-battery-status > > Thanks, > Nikhil > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-3360 Set custom User-Agent
GitHub user sinofool opened a pull request: https://github.com/apache/cordova-docs/pull/284 CB-3360 Set custom User-Agent Add document about OverrideUserAgent and AppendUserAgent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sinofool/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/284.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #284 commit de0378d1466589e2b68062d0dad5ee16717cd058 Author: Bochun Bai Date: 2015-05-07T06:04:49Z CB-3360 Set custom User-Agent Add document about OverrideUserAgent and AppendUserAgent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99734573 @brodybits follow these steps: * clone https://github.com/apache/cordova-plugin-file-transfer.git somewhere on your disk * Create a new application * Add three plugins: ``` cordova plugin add path-to-cloned-file-transfer-plugin cordova plugin add path-to-cloned-file-transfer-plugin/tests cordova plugin add https://github.com/apache/cordova-plugin-test-framework.git ``` * Update config.xml at the root of your app - change `` to `` * Run application --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8931 Replace all sla...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8931 Replace all sla...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/76#issuecomment-99736100 LGTM and merged. Thanks @starquake --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
