[GitHub] cordova-plugin-camera pull request: [Android] fix: support lollipo...

[devpaul]

Github user devpaul commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-112295207
  
Hi, I was wondering if this was going to be reviewed soon. I'm receiving 
content uris for some media types on a Nexus 5 - 5.1 and I am hoping this could 
help resolve the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-coho/pull/85#issuecomment-112294287
  
Wow! @TimBarham this looks great! I will keep testing and playing around 
with it. But I'd say merge it in. We can make fixes where needed as they come 
up. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...

[aroberson]

Github user aroberson commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/106#issuecomment-112257930
  
I would like this pull to be approved as I am having the same issues that 
are fixed here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Fixed Browser to set wi...

[aroberson]

GitHub user aroberson opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/89

Fixed Browser to set withCredentials flag on XMLHttpRequest object to allow 
cookies to be used



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ABB-Austin/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 051ada102e617478a1a47c1eee8d224665f45b88
Author: aroberson 
Date:   2015-06-15T20:54:27Z

Added option to allow for passing cookies automatically in the browser

commit f52d324b4fe516256c16c23eaf18ea3a3bf1ca19
Author: aroberson 
Date:   2015-06-15T21:03:56Z

Updated documentation for browser

commit f17b7fcdd109eaf5e51db68cc7b316380e93ceef
Author: aroberson 
Date:   2015-06-16T01:38:21Z

Updated code per code review.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

[aroberson]

Github user aroberson closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

[aroberson]

Github user aroberson commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/88#issuecomment-112255281
  
Duke,
I did not do that on purpose as I wanted to keep it as close to possible to 
the original functionality.  I can make the change.

I would have to check the other platforms.  Most of them already handle the 
use of cookies properly which is why I did not apply the change elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/214#discussion_r32484109
  
--- Diff: doc/platform.txt ---
@@ -5,7 +5,10 @@ Synopsis
 Manage project platforms
 
 add  [...].. add specified platforms
---usegit .. retrieve from git instead of npm 
registry
+--usegit .. [WARNING: This flag has been 
deprecated !]
+[Instead, please use: `cordova 
platform add git-url#custom-branch`.] 
+[e.g: cordova platform add 
https://github.com/apache/cordova-android.git#2.4.0]
+retrieve from git instead of npm 
registry
--- End diff --

Just a minor nit, as for the other change - don't put a space before the 
`!` (or just replace it with a period). Also, I wonder - should the description 
come first, then the warning?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/234#discussion_r32484031
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
 }
 }
 
+if (opts.usegit) {
+msg = '\r\nWARNING: The --usegit flag has been deprecated ! \r\n' +
+  'instead, please use: `cordova platform add 
git-url#custom-branch`. \r\n' +
+  'e.g: cordova platform add 
https://github.com/apache/cordova-android.git#2.4.0 \r\n';
+events.emit('log', msg);
--- End diff --

Ok, seems backtick is used all over the place, so don't worry about that 
one :smile:.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/234#discussion_r32483383
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
 }
 }
 
+if (opts.usegit) {
+msg = '\r\nWARNING: The --usegit flag has been deprecated ! \r\n' +
+  'instead, please use: `cordova platform add 
git-url#custom-branch`. \r\n' +
+  'e.g: cordova platform add 
https://github.com/apache/cordova-android.git#2.4.0 \r\n';
+events.emit('log', msg);
--- End diff --

Some nits:
* Use `\n`, not `\r\n`.
* Use `\'` rather than backtick (`` ` ``).
* Use `events.emit('warning'...)`
* No space before `!` (or even just a period - no need to get too excited 
:smile:).
* Capital `I` for `Instead`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-wp8 pull request: Remove `ecosystem:cordova` keyword from ...

[Jesse]

merge it!

@purplecabbage
risingj.com

On Mon, Jun 15, 2015 at 5:46 PM, nikhilkh  wrote:

> GitHub user nikhilkh opened a pull request:
>
> https://github.com/apache/cordova-wp8/pull/83
>
> Remove `ecosystem:cordova` keyword from package.json
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/MSOpenTech/cordova-wp8
> package_ecosystem_cordova
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cordova-wp8/pull/83.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #83
>
> 
> commit 3799b274df6d0a9a56b4889fe2bc7f32d46e7ca3
> Author: Nikhil Khandelwal 
> Date:   2015-06-16T00:41:18Z
>
> Remove `ecosystem:cordova` keyword from package.json
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[VOTE] Cordova Serve 0.1.2 release

[Tim Barham]

Please review and vote on this Cordova Serve Release by replying to this email.

Release issue: https://issues.apache.org/jira/browse/CB-9181

Package has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-9181/

I have uploaded the package to npm under the RC tag for testing purposes, and 
created cordova-lib update that uses it for the 'cordova serve' command [1].

The package was published from its corresponding git tag:

cordova-lib: serve-0.1.2 (c87b48140a)

(Note that this is the cordova-serve module in the cordova-lib repository)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

I vote +1:
* Ran 'coho audit-license-headers' on the cordova-serve module
* Ran 'coho check-license' on the cordova-serve module to ensure all 
dependencies and sub-dependencies have Apache-compatible licenses
* Uploaded to NPM with RC tag, installed and verified it works as expected with 
version of cordova-lib modified to use it.

To use coho tools to verify the this release, you will need to sync with a coho 
update that knows how to work with multiple modules within a repo (this update 
is not yet checked in) [2]. With this update, you will be able to use 'serve' 
as a repo name.

[1] https://github.com/MSOpenTech/cordova-lib/tree/tb-use-cordova-serve
[2] https://github.com/MSOpenTech/cordova-coho/tree/tb-coho-modules

Thanks!

Tim

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-wp8 pull request: Remove `ecosystem:cordova` keyword from ...

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-wp8/pull/83

Remove `ecosystem:cordova` keyword from package.json



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-wp8 
package_ecosystem_cordova

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-wp8/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit 3799b274df6d0a9a56b4889fe2bc7f32d46e7ca3
Author: Nikhil Khandelwal 
Date:   2015-06-16T00:41:18Z

Remove `ecosystem:cordova` keyword from package.json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] 5.1.1 Docs Release?

[Steven Gill]

docs have been released!

On Fri, Jun 12, 2015 at 8:06 AM, Victor Sosa  wrote:

> Hi Steven.
>
> Translations are committed now and I did a quick check on the docs.
> Translations are there. Could you publish these docs, please?
> Thanks a lot.
>
> On Fri, Jun 12, 2015 at 8:21 AM Victor Sosa 
> wrote:
>
> > Hi Andrey
> >
> > Actually working on the Russian documentation but not done. So, I'll stop
> > here and will commit changes for the other languages.
> > Please, let me know when you are done to update Russian docs in the repo.
> >
> > Yes, I'll be including the latest changes, including clean hook
> >
> > On Thu, Jun 11, 2015 at 11:54 PM Andrey Kurdumov <
> kant2...@googlemail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> I would like that docs for `clean` hooks would be also included, so both
> >> English and Russian version would be exactly the same.
> >> This is require that docs would be updated, very easy fix - See (
> >> https://github.com/apache/cordova-docs/pull/293/files)
> >>
> >> Also before releasing Russian docs, I have to verify that all markup is
> >> generated correctly, we don't have any missing links and so on. I need
> day
> >> or two for that to verify.
> >>
> >> @Victor, could you please not automatically update Russian docs with
> text
> >> from Bing, I lose all my progress constantly and have to reread all docs
> >> to
> >> find which places is not correctly translated. Please give me some
> notice
> >> in advance, so I at least could record what's left. Anyway I have to
> >> modify
> >> CrowdIn output in some places so all links would be in place and HTML
> >> would
> >> be generated correctly.
> >>
> >> @Stiven, could you please merge
> >> https://github.com/apache/cordova-docs/pull/289, this will greatly help
> >> me
> >> in translation process.
> >>
> >>
> >> 2015-06-12 3:16 GMT+06:00 Victor Sosa :
> >>
> >> > Hello Steven.
> >> >
> >> > I'm working on the translation right now, I expect to finish
> everything
> >> byt
> >> > tomorrow evening. Will reply this thread when I'm done.
> >> >
> >> > On Thu, Jun 11, 2015 at 3:16 PM Steven Gill 
> >> > wrote:
> >> >
> >> > > Let me know when translations have been checked in and what
> languages
> >> > need
> >> > > to get the new version. For example, only Russian and english docs
> >> have
> >> > > 5.0.0 currently. Edge for all of the other docs is recent though.
> >> > >
> >> >
> >>
> >
>

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/88#issuecomment-112243188
  
Is 'withCredentials' available everywhere? I think this has potentially 
wider impact than just the cordova-browser platform.
Shouldn't we check if xhr.withCredentials exists?
Then this could become : 
``` 
if('withCredentials' in xhr) {
  xhr.withCredentials = options.withCredentials || false;
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9171 Support Variables with =

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-cli/pull/217#issuecomment-112241310
  
Nice. and a test too!  Keep it up!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-ios/pull/138#issuecomment-112240780
  
This change creates an ipa in addition to .app file by invoking xcrun: 
https://github.com/MSOpenTech/cordova-ios/commit/ebcc29ef9a2ca4ebe49fd319868a514c0a558499#diff-6a830db18b2f183f537e0d0f98275067R114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-112240606
  
Not a bot! Or am I?
LGTM +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Query regarding CSS

[Jesse]

Yes, you can use css.
No other requirements exist.  I suspect you are modifying things in the
wrong place, or not including your css from your index.html

Please note, this is a mail list for people who develop/contribute to
cordova, not for
people who develop apps using cordova.
Try asking on this group instead
https://groups.google.com/forum/m/#!forum/phonegap
OR join the new community on slack at http://cordova.slack.com

Cheers,
  Jesse

@purplecabbage
risingj.com

On Mon, Jun 15, 2015 at 7:18 AM, Mehta, Ruchit 
wrote:

> Hello,
>
>
>
> I am using Cordova to build a hybrid mobile application. I am using my
> custom css files in it for styling.But it is not working,I am not getting
> any styling when I build and install my app.Will it work only for jquery
> mobile CSS? Please give me some direction.
>
>
>
> Thanks & Regards,
>
> Ruchit Mehta | Associate Software Engineer
>
> Allscripts
>
> 011.91.265.398.1500| P
> 011.91.992.529.4418| C
>
> In case of Emergency/On call  : 1-888-325-4779 Opt. 4
>
> ruchit.me...@allscripts.com |
> www.allscripts.com
>
> Welcome to the new Allscripts, formed by the merger of Allscripts and
> Eclipsys
>
>
>
> Allscripts is committed to accountability and delivering an outstanding
> experience for our clients. If you have compliments or if I have not met
> your expectations, please contact my manager Sachin Katiyar sachin.kati...@allscripts.com>
>
> or Allscripts at clientsatisfact...@allscripts.com clientsatisfact...@allscripts.com>
>
>
>
>

[GitHub] cordova-plugin-camera pull request: Update README.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: fix broken plugman command to install a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/283


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: fix crash when trying to pick ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

[brodybits]

Github user brodybits commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112238832
  
> I believe this is still required, will test.

Sorry I missed the question before. I don't think this should be needed as
already commented by Nikhil:

> As far as I understand, this is not needed any more as Newtonsoft JSON
change was made non-breaking.

Quick test is not a bad idea.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/247#discussion_r32479018
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -168,10 +168,19 @@ module.exports = function plugin(command, targets, 
opts) {
 })
 .then(function(dir) {
 // Validate top-level required variables
-var pluginVariables = 
pluginInfoProvider.get(dir).getPreferences(),
-missingVariables = 
pluginVariables.filter(function (v) {
+var pluginVariables = 
pluginInfoProvider.get(dir).getPreferences();
+var requiredVariables = [];
+for(var i in pluginVariables)
+{
+var v = pluginVariables[i];
+// discard variables with default value
+if (!v.default)
--- End diff --

Have a look in `spec-cordova/plugin.spec.js`. You should be able to add 
something there. Create a `plugin.xml` with the required bits and add it under 
`spec-cordova/fixtures/plugins`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Should files in cordova-lib/templates have license headers?

[Tim Barham]

So... I added the license headers to the checked-in code, but got around the 
issue you describe by adding logic to strip out the license headers when 
creating a plugin. See https://github.com/apache/cordova-lib/commit/921dad392a.

Tim

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Monday, June 15, 2015 2:21 PM
To: dev@cordova.apache.org
Subject: Re: Should files in cordova-lib/templates have license headers?

What specific files?
The problem that I have is with adding license headers to template files is 
that it *may* imply that the developer's app must be APL 2.0, these typically 
are 'sample' files and the user is expected to change them ...
but expecting them to remove a license header as their first change is kinda 
weird.






@purplecabbage
risingj.com

On Mon, Jun 8, 2015 at 12:30 PM, Shazron  wrote:

> We should add license headers.
>
> On Mon, Jun 8, 2015 at 11:21 AM, Tim Barham 
> wrote:
>
> > Currently these files are flagged by RAT. We should either add 
> > license headers or exclude them (from RAT) to clean up the noise. 
> > They're small pieces of template code used by plugman. The Apache 
> > rules for whether a file needs to have a license header [1] specifies:
> >
> > > What files in an Apache release do not require a license header?
> > > A file without any degree of creativity in either its literal 
> > > elements
> or
> > > its structure is not protected by copyright law; therefore, such a 
> > > file does not require a license header. If in doubt about the 
> > > extent of the file's creativity, add the license header to the file.
> >
> > I don't think it could be argued that these files have *no* 
> > creativity what-so-ever, so perhaps we should add license headers?
> >
> > [1] http://www.apache.org/legal/src-headers.html
> >
> > Tim
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112236890
  
I believe this is still required, will test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Keeping Cordova app open in background all th time

[Jesse]

This is a limitation of windows store apps ( which cordova-windows apps are
)
You can pin them to the sides to keep them both open, but there are no apis
to do this programmatically.

Please note, this is a mail list for people who develop/contribute to
cordova, not for
people who develop apps using cordova.
Try asking on this group instead
https://groups.google.com/forum/m/#!forum/phonegap
OR join the new community on slack at http://cordova.slack.com

Cheers,
  Jesse


@purplecabbage
risingj.com

On Thu, Jun 11, 2015 at 1:01 AM, Jay Patel  wrote:

> Dear team,
>
> Am not sure if I can do this but any assistance would be appreciated.
>
> I have a windows cordova app, within this app am opening another external
> app, as soon as I open the external app cordova app is minimised in the
> background. What I want to do is keep my Cordova app maximised so I can
> overlay the external app on top of it when launched.
>
> Want to overlay external app on top of cordova app.
>
> Regards
> Jay
>

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

[killswitch]

Github user killswitch commented on the pull request:

https://github.com/apache/cordova-ios/pull/132#issuecomment-112232774
  
This package hasn't been published since before this pull request was 
merged. Can we get this code published to npm? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232437
  
Numerous issues here .. removing whitespace from the diff reveals only 
minor changes.
The changes however do not address the issue as reported in JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232035
  
Why does this pull request touch iOS?  Can you make it so that it's only 
Android?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/138#issuecomment-112220047
  
Yes xcrun


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

[dukex]

Github user dukex commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/88#discussion_r32469454
  
--- Diff: www/browser/FileTransfer.js ---
@@ -231,7 +236,9 @@ FileTransfer.prototype.download = function(source, 
target, successCallback, erro
 
 var that = this;
 var xhr = transfers[this._id] = new XMLHttpRequest();
-
+if (withCredentials) {
+xhr.withCredentials = true;
--- End diff --

Same here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

[mattdsteele]

Github user mattdsteele commented on the pull request:

https://github.com/apache/cordova-ios/pull/138#issuecomment-112217556
  
Hi folks, I'm trying this out - looks really slick!

I had one question: this produces a signed `.app` file. What's the best way 
to convert it to an `.ipa` we can install on a device? I found [this 
StackOverflow](http://stackoverflow.com/a/25006630) post, is running `xcrun` 
the recommended approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

[dukex]

Github user dukex commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/88#discussion_r32469314
  
--- Diff: www/browser/FileTransfer.js ---
@@ -121,6 +122,9 @@ FileTransfer.prototype.upload = function(filePath, 
server, successCallback, erro
 
 var that = this;
 var xhr = transfers[this._id] = new XMLHttpRequest();
+if (withCredentials) {
+xhr.withCredentials = true;
--- End diff --

You can remove the `if`statement and write only:
``` js 
 xhr.withCredentials = withCredentials
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/242#issuecomment-112216370
  
lgtm :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Should files in cordova-lib/templates have license headers?

[Shazron]

I believe we had this exact discussion regarding our app-hello-world.
Ultimately we added it in:
https://github.com/apache/cordova-app-hello-world/blob/master/www/index.html

On Mon, Jun 15, 2015 at 2:21 PM, Jesse  wrote:

> What specific files?
> The problem that I have is with adding license headers to template files is
> that it *may* imply that the developer's app must be APL 2.0, these
> typically are 'sample' files and the user is expected to change them ...
> but expecting them to remove a license header as their first change is
> kinda weird.
>
>
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Jun 8, 2015 at 12:30 PM, Shazron  wrote:
>
> > We should add license headers.
> >
> > On Mon, Jun 8, 2015 at 11:21 AM, Tim Barham 
> > wrote:
> >
> > > Currently these files are flagged by RAT. We should either add license
> > > headers or exclude them (from RAT) to clean up the noise. They're small
> > > pieces of template code used by plugman. The Apache rules for whether a
> > > file needs to have a license header [1] specifies:
> > >
> > > > What files in an Apache release do not require a license header?
> > > > A file without any degree of creativity in either its literal
> elements
> > or
> > > > its structure is not protected by copyright law; therefore, such a
> file
> > > > does not require a license header. If in doubt about the extent of
> the
> > > > file's creativity, add the license header to the file.
> > >
> > > I don't think it could be argued that these files have *no* creativity
> > > what-so-ever, so perhaps we should add license headers?
> > >
> > > [1] http://www.apache.org/legal/src-headers.html
> > >
> > > Tim
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

Re: Should files in cordova-lib/templates have license headers?

[Jesse]

What specific files?
The problem that I have is with adding license headers to template files is
that it *may* imply that the developer's app must be APL 2.0, these
typically are 'sample' files and the user is expected to change them ...
but expecting them to remove a license header as their first change is
kinda weird.






@purplecabbage
risingj.com

On Mon, Jun 8, 2015 at 12:30 PM, Shazron  wrote:

> We should add license headers.
>
> On Mon, Jun 8, 2015 at 11:21 AM, Tim Barham 
> wrote:
>
> > Currently these files are flagged by RAT. We should either add license
> > headers or exclude them (from RAT) to clean up the noise. They're small
> > pieces of template code used by plugman. The Apache rules for whether a
> > file needs to have a license header [1] specifies:
> >
> > > What files in an Apache release do not require a license header?
> > > A file without any degree of creativity in either its literal elements
> or
> > > its structure is not protected by copyright law; therefore, such a file
> > > does not require a license header. If in doubt about the extent of the
> > > file's creativity, add the license header to the file.
> >
> > I don't think it could be argued that these files have *no* creativity
> > what-so-ever, so perhaps we should add license headers?
> >
> > [1] http://www.apache.org/legal/src-headers.html
> >
> > Tim
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[ogoguel]

Github user ogoguel commented on the pull request:

https://github.com/apache/cordova-lib/pull/247#issuecomment-112212662
  
Fixed requiredVariables
Fixed whitespace in plugin.xml



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[ogoguel]

Github user ogoguel commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/247#discussion_r32466926
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -168,10 +168,19 @@ module.exports = function plugin(command, targets, 
opts) {
 })
 .then(function(dir) {
 // Validate top-level required variables
-var pluginVariables = 
pluginInfoProvider.get(dir).getPreferences(),
-missingVariables = 
pluginVariables.filter(function (v) {
+var pluginVariables = 
pluginInfoProvider.get(dir).getPreferences();
+var requiredVariables = [];
+for(var i in pluginVariables)
+{
+var v = pluginVariables[i];
+// discard variables with default value
+if (!v.default)
--- End diff --

Beside adding a plugin, how this line of code can be unit-tested ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

[aroberson]

GitHub user aroberson opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/88

Add Browser support for using Cookies

Added a property for browser to set the withCredentials flag on the 
XMLHttpRequest for upload and download


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ABB-Austin/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit 051ada102e617478a1a47c1eee8d224665f45b88
Author: aroberson 
Date:   2015-06-15T20:54:27Z

Added option to allow for passing cookies automatically in the browser

commit f52d324b4fe516256c16c23eaf18ea3a3bf1ca19
Author: aroberson 
Date:   2015-06-15T21:03:56Z

Updated documentation for browser




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Dmitry WFH

[Steven Gill]

Hope you feel better buddy!

On Mon, Jun 15, 2015 at 2:00 PM, Jesse  wrote:

> Get well soon!
>
> @purplecabbage
> risingj.com
>
> On Mon, Jun 15, 2015 at 1:01 PM, Dmitry Blotsky 
> wrote:
>
> > Whoop, I sent it to the wrong list. I should lie down. Sorry, y’all. :/
> >
> > > On Jun 15, 2015, at 12:38 PM, Dmitry Blotsky 
> > wrote:
> > >
> > > Hi all,
> > >
> > > I’m not feeling any better, so I’ll remain at home today and work from
> > here. Will call in for sprint planning.
> > >
> > > Kindly,
> > > Dmitry
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: Dmitry WFH

[Jesse]

Get well soon!

@purplecabbage
risingj.com

On Mon, Jun 15, 2015 at 1:01 PM, Dmitry Blotsky 
wrote:

> Whoop, I sent it to the wrong list. I should lie down. Sorry, y’all. :/
>
> > On Jun 15, 2015, at 12:38 PM, Dmitry Blotsky 
> wrote:
> >
> > Hi all,
> >
> > I’m not feeling any better, so I’ll remain at home today and work from
> here. Will call in for sprint planning.
> >
> > Kindly,
> > Dmitry
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: Dmitry WFH

[Dmitry Blotsky]

Whoop, I sent it to the wrong list. I should lie down. Sorry, y’all. :/

> On Jun 15, 2015, at 12:38 PM, Dmitry Blotsky  wrote:
> 
> Hi all,
> 
> I’m not feeling any better, so I’ll remain at home today and work from here. 
> Will call in for sprint planning.
> 
> Kindly,
> Dmitry
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/247#issuecomment-112186148
  
Thanks @ogoguel! A couple of things need fixing - I'll merge this once 
they're sorted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/247#discussion_r32458351
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -168,10 +168,19 @@ module.exports = function plugin(command, targets, 
opts) {
 })
 .then(function(dir) {
 // Validate top-level required variables
-var pluginVariables = 
pluginInfoProvider.get(dir).getPreferences(),
-missingVariables = 
pluginVariables.filter(function (v) {
+var pluginVariables = 
pluginInfoProvider.get(dir).getPreferences();
+var requiredVariables = [];
+for(var i in pluginVariables)
+{
+var v = pluginVariables[i];
+// discard variables with default value
+if (!v.default)
--- End diff --

When I test this adding a plugin that requires variables (for example, 
`com.phonegap.plugins.facebookconnect`) and I don't specify any, this line 
throws (`v` is `null`). The logic here doesn't seem to coincide with the actual 
value returned by `getPreferences()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/247#discussion_r32458159
  
--- Diff: 
cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml ---
@@ -0,0 +1,18 @@
+
+
+
+http://cordova.apache.org/ns/plugins/1.0";
+xmlns:android="http://schemas.android.com/apk/res/android";
+id="org.test.defaultvariables"
+version="3.0.0">
+
+Use Default Variables
+
+
+
+  
+
+
+
+   
+
--- End diff --

Clean up whitespace (mixture of tabs and spaces).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/247#discussion_r32458071
  
--- Diff: cordova-lib/spec-plugman/install-browserify.spec.js ---
@@ -46,6 +46,7 @@ var install = require('../src/plugman/install'),
 'com.cordova.engine-android' : path.join(plugins_dir, 
'com.cordova.engine-android'),
 'org.test.plugins.childbrowser' : path.join(plugins_dir, 
'org.test.plugins.childbrowser'),
 'com.adobe.vars' : path.join(plugins_dir, 'com.adobe.vars'),
+'org.test.defaultvariables' : path.join(plugins_dir, 
'org.test.defaultvariables'),
--- End diff --

@ogoguel - could you make the equivalent change to `install.spec.js`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Dmitry WFH

[Dmitry Blotsky]

Hi all,

I’m not feeling any better, so I’ll remain at home today and work from here. 
Will call in for sprint planning.

Kindly,
Dmitry
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9171 Support Variables with =

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/214#issuecomment-112176978
  
Related PR : https://github.com/apache/cordova-lib/pull/234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/234#issuecomment-112177005
  
https://github.com/apache/cordova-cli/pull/214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Deprecate --usegit flag

[Mefire O .]

Ping 

Since we've come to a consensus regarding this, could someone please pull these 
PRs in ?
I don't have committer privileges to do it.


Thanks,
Mefire

-Original Message-
From: Mefire O. 
Sent: Wednesday, June 3, 2015 2:33 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Deprecate --usegit flag

Thanks guys,
Looks like we can go ahead with this.

I've sent 2 PRs that add deprecation warnings to both CLI and cordova-lib :

-  https://github.com/apache/cordova-cli/pull/214
-  https://github.com/apache/cordova-lib/pull/234


Thanks,
Mefire

-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Wednesday, June 3, 2015 12:44 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Deprecate --usegit flag

+1

On Wed, Jun 3, 2015 at 12:35 PM, Brian LeRoux  wrote:

> +1
>
> On Wed, Jun 3, 2015 at 12:17 PM, Jesse  wrote:
>
> > +1
> > and using real git urls (should?) lets you install from
> branches/tags+other
> > git repos and not just the mystical magical one that lives behind 
> > the
> flag.
> >
> > @purplecabbage
> > risingj.com
> >
> > On Wed, Jun 3, 2015 at 12:05 PM, Steven Gill 
> > 
> > wrote:
> >
> > > Sounds like a good candidate for deprecation to me. I used 
> > > --usegit in
> > the
> > > old nightly builds I had running. But the custom git urls would 
> > > work
> just
> > > as well.
> > >
> > > -Steve
> > >
> > > On Wed, Jun 3, 2015 at 11:44 AM, Mefire O. 
> > > 
> > wrote:
> > >
> > > > Hi list,
> > > > I think it's high time we deprecate the -usegit flag, whose 
> > > > intent
> was
> > to
> > > > provide apache git repos as an alternative source to install
> platforms
> > > (the
> > > > default being npm).
> > > >
> > > > A little bit of background :
> > > > In the past, there were two main sources from which to install a
> > > platform.
> > > > You could fetch the platform to be installed from npm (the default).
> > > > Or you could specify that the platform to be installed be 
> > > > fetched
> from
> > > the
> > > > Apache git repo using -usegit : `cordova platform add android
> -usegit`.
> > > >
> > > > There are certain shortcomings to the -useflag :
> > > >
> > > > -It only works with Apache git repos. It doesn't support
> custom
> > > > git repos.
> > > >
> > > >  e.g: It passes if the following is found in
> platformsConfig.json :
> > > > `cordova platform add
> > > > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git`
> > > >
> > > >  e.g: the following would fail : `cordova platform add 
> > > > https://github.com/apache/cordova-android.git`<
> > > > https://github.com/apache/cordova-android.git%60>
> > > >
> > > > -The code that implements it is complex and prone to bugs.
> e.g:
> > > > https://github.com/apache/cordova-lib/pull/232
> > > >
> > > > -The git repo we want to fetch the platform from has to be
> > > > manually added to the file platformsConfig.json.
> > > >
> > > >
> > > > Suggested replacement:
> > > > We've been supporting custom git-urls for a while now :
> > > >
> > > > -
> > > >
> > >
> >
> https://github.com/apache/cordova-lib/commit/811f6f72d74dfd2ca054553ae
> 248f0831235f912
> > > >
> > > > -
> > > >
> > >
> >
> https://github.com/apache/cordova-lib/commit/4d2059452fa36dd510d9a949e
> 150de840d336e04
> > > >
> > > > Using this feature, we can add platforms from any git repo using 
> > > > the following : `cordova platform add 
> > > > https://github.com/apache/cordova-android.git`<
> > > > https://github.com/apache/cordova-android.git%60>
> > > > It also supports specifying a custom branch : `cordova platform 
> > > > add https://github.com/apache/cordova-android.git#my_branch`
> > > >
> > > > So, I think this second feature can handle all the scenarios 
> > > > handled
> by
> > > > -usegit and much more ...
> > > >
> > > > What I propose is phasing out the -usegit flag, over the next 6
> months.
> > > >
> > > > Please, let me know your thoughts.
> > > >
> > > > Thanks,
> > > > Mefire
> > > >
> > > >
> > >
> >
>

[GitHub] cordova-docs pull request: CB-9034 Improve reporting errors in tra...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/289


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

[uareurapid]

Github user uareurapid commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-112163607
  
Is the repo alive or is just a bot?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Proposal: Cordova Plugin Search

[Murat Sutunc]

Before I went ahead with the new page I've spent some time thinking about ways 
to improve our current search page 
(http://plugins.cordova.io/#/search?search=camera). The new site 
(http://people.apache.org/~muratsu/) isn't that big of a departure from the old 
one but has couple new UEX ideas. 

I must tell - I'm a huge fan of cards paradigm. Compared to tables it takes a 
bit more screen real estate but is much more elegant, expressive and easy to 
customize. Also below are some additional reasons why I preferred a new design:

1) In the old design we didn't have to display author as plugin names included 
the orgs. E.g. com.phonegap.plugins.barcodescanner. With npm, we need to grab 
the author name and display it next to plugin name.
2) I like the old filter by platform and got plans to add filtering in the 
future. But I also think we should be displaying platforms as small badges next 
to plugins. This helps with discoverability and encourages plugins with no tags 
to add them.
3) Bunch of extra information, such as last updated and license is also useful 
to see before going to details of a plugin. I personally find them useful but 
that's just me. 

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Friday, June 12, 2015 9:39 PM
To: dev@cordova.apache.org
Subject: Re: Proposal: Cordova Plugin Search

Why we can't re-use some of the web app code that currently uses the cpr I like 
the UI, just change how to query the data logic to npm

On Thu, Jun 11, 2015 at 1:12 PM Steven Gill  wrote:

> Nice list of tasks. I'll try to find some time to look at the PR in 
> the next few days.
>
> It might be nice to turn this search functionality (with the 
> blacklist) into a module others can incorporate into their tools. We 
> could potentially use it in the cordova cli (cordova plugin search) 
> and maybe some of the IDE developers here could use it as well.
>
>
>
> On Wed, Jun 10, 2015 at 2:19 PM, Victor Sosa 
> wrote:
>
> > Thanks for your prompt answer. Great to see the community will get a 
> > good search mechanism :-D
> >
> > On Wed, Jun 10, 2015 at 3:14 PM Murat Sutunc 
> > wrote:
> >
> > > I've updated the cordova-discussion with tasks and bugs, so it's 
> > > more clear what's planned for search page:
> > >
> >
> https://github.com/cordova/cordova-discuss/issues/7#issuecomment-11089
> 3889
> > >
> > > 1 - Yes, the goal for this page is to eventually replace current 
> > > plugin search page. CPR will be read-only on july 15th and 
> > > everyone here
> agreed
> > > that using npmjs.com isn't the best experience when it comes to 
> > > plugin searching. The idea is to offer a better user experience 
> > > from our
> cordova
> > > domain.
> > > 2- The website is a static page. At this point, I don't think we 
> > > want
> to
> > > host a backend service. For now, you can use the same api that I'm
> using
> > (
> > > npmsearch.com :) )
> > >
> > > -Original Message-
> > > From: Victor Sosa [mailto:sosah.vic...@gmail.com]
> > > Sent: Wednesday, June 10, 2015 10:54 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Proposal: Cordova Plugin Search
> > >
> > > Hi Murat.
> > > Two questions
> > >
> > > 1. This is for the community, is this going to be the official 
> > > search
> > page
> > > for cordova plugins in NPM?
> > > 2. Do you plan to open a REST API so others can query this search page?
> > > This would be awesome if others like me just want to receive a 
> > > JSON
> with
> > > the info.
> > >
> > > Thanks Murat, looks great!
> > >
> > > On Tue, Jun 9, 2015 at 7:44 PM Murat Sutunc 
> > > 
> > wrote:
> > >
> > > > I’ve created a PR for the first iteration of plugin search page.
> > > > You can find the PR at
> > > > https://github.com/apache/cordova-registry-web/pull/11
> > > >
> > > > Current known issues:
> > > > - Search should lowercase queries
> > > > - Platform tags don't look good on ipad/iphone
> > > >
> > > > -Original Message-
> > > > From: Joerg Holz [mailto:h...@hamburg.de]
> > > > Sent: Saturday, June 6, 2015 1:26 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: Proposal: Cordova Plugin Search
> > > >
> > > > Thx, great job!
> > > >
> > > > If you need some help with CSS, … drop me a note.
> > > >
> > > >
> > > > Joerg
> > > >
> > > >
> > > > > Am 06.06.2015 um 02:09 schrieb Murat Sutunc 
> > > > >  >:
> > > > >
> > > > > Got some updates on this proposal!
> > > > > I've prepared a live demo on: 
> > > > > http://people.apache.org/~muratsu/
> > > > > Please visit the webpage and let me know what you think!
> > > > >
> > > > > Thanks,
> > > > > Murat
> > > > >
> > > > > -Original Message-
> > > > > From: Murat Sutunc [mailto:mura...@microsoft.com]
> > > > > Sent: Wednesday, June 3, 2015 11:41 AM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Proposal: Cordova Plugin Search
> > > > >
> > > > > Hey everyone,
> > > > > I've seen couple folks mention the idea of turning 
> > > > > plugins.cordova.io
> > > > into

Query regarding CSS

[Mehta, Ruchit]

Hello,



I am using Cordova to build a hybrid mobile application. I am using my custom 
css files in it for styling.But it is not working,I am not getting any styling 
when I build and install my app.Will it work only for jquery mobile CSS? Please 
give me some direction.



Thanks & Regards,

Ruchit Mehta | Associate Software Engineer

Allscripts

011.91.265.398.1500| P
011.91.992.529.4418| C

In case of Emergency/On call  : 1-888-325-4779 Opt. 4

ruchit.me...@allscripts.com | 
www.allscripts.com

Welcome to the new Allscripts, formed by the merger of Allscripts and Eclipsys



Allscripts is committed to accountability and delivering an outstanding 
experience for our clients. If you have compliments or if I have not met your 
expectations, please contact my manager Sachin 
Katiyar

or Allscripts at 
clientsatisfact...@allscripts.com

[GitHub] cordova-plugin-statusbar pull request: Stop "object has no method"...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

[sgrebnov]

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-windows/pull/91

CB-9159 Fix Windows Phone 8.1 deploy when 'window-target-version' is 10

Jira issue: https://issues.apache.org/jira/browse/CB-9159

* Don't duplicate target processing logic in Run and Build scripts.
* Run should use first available build target returned by Build script
* Added additional tests for `--appx` parameter

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-9159

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit 526c9f6b07e58a5795bb6e2fec98f6bbd186b586
Author: sgrebnov 
Date:   2015-06-15T10:11:26Z

CB-9159 Fix Windows Phone 8.1 deploy when 'window-target-version' is 10.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-8214 COHO. Rename windowsphone to wp...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-coho/pull/60#issuecomment-111987098
  
Looks good :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-8214 COHO. Rename windowsphone to wp...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-coho/pull/60#issuecomment-111986557
  
Re-based and re-tested. I  see that there was similar fix added here: 
https://github.com/apache/cordova-coho/commit/5a07ec0c711e16695e2ce5a824ae5fee9cf5897f
 
But it is still actual since it removes unnecessary logic as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-7953 Add cordova-pl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-7953 Add cordova-pl...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-battery-status/pull/20#issuecomment-111981249
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org