[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113403640 thanks @dpolivy, that's exactly the kind of review I was looking to get. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9128 Russian translation for the 5.1
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/294 CB-9128 Russian translation for the 5.1 I verified all links in the translation. Docs ready to be released. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-docs CB-9128 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/294.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #294 commit 8463d20c115f94f463c45cfba56557cd21d1ea38 Author: Andrey Kurdyumov Date: 2015-06-13T08:44:58Z Russian translation commit 978ef60aded1a9ef7e0d29899ca5b23595af32a8 Author: Andrey Kurdyumov Date: 2015-06-13T13:16:33Z Fix links commit dfbdab3810138af966316e37ac87df002dcdfbc5 Author: Andrey Kurdyumov Date: 2015-06-18T12:27:40Z Fix errors in docs on the Ru and En commit f230f75d0f3b52b7c2e238d62233f0e39129bb92 Author: Andrey Kurdyumov Date: 2015-06-18T13:15:49Z Fix UI issues in docs commit 817e225a7d49d4b7406a05ed338eb8501d7c84fe Author: Andrey Kurdyumov Date: 2015-06-18T14:02:02Z Update UI quirks in the Russian translation commit 8e6e6f59a8d4538acc67eac65bd098908bc260c9 Author: Andrey Kurdyumov Date: 2015-06-18T14:35:23Z Fix UI issues in Blackberry docs in Russian commit 309305a4c5d2bf06fef2b9c3cdee53641e12b70a Author: Andrey Kurdyumov Date: 2015-06-19T05:56:44Z Update UI fixes in Android section in Russian docs commit eac93516449c63033bc0803bcca4f056457bca98 Author: Andrey Kurdyumov Date: 2015-06-19T06:13:09Z Fix UI issues in the Amazon Fire OS Russian docs commit 41d490566734cb45d5ce846bca7d19e3757eca22 Author: Andrey Kurdyumov Date: 2015-06-19T08:00:30Z Fix UI issues in Russian docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
GitHub user SunboX opened a pull request: https://github.com/apache/cordova-wp8/pull/84 Added the XHR upload attribute Added the XHR upload attribute as defined by https://xhr.spec.whatwg.org/#the-upload-attribute and documented at MDN here https://developer.mozilla.org/de/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#Monitoring_progress This is required by https://github.com/doedje/jquery.soap/blob/master/jquery.soap.js#L281 and will throw a exception if not present. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SunboX/cordova-wp8 xhr-upload-attribute Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/84.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #84 commit 9a1b36cb13908436a946a4621325018d16a26f56 Author: André Fiedler Date: 2015-06-19T08:18:49Z Added the XHR upload attribute Added the XHR upload attribute as defined by https://xhr.spec.whatwg.org/#the-upload-attribute and documented at MDN here https://developer.mozilla.org/de/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#Monitoring_progress This is required by https://github.com/doedje/jquery.soap/blob/master/jquery.soap.js#L281 and will throw a exception if not present. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-113429801 Yeah, on iOS the user agent change applies to all the webviews, maybe it should be restored after closing the inappbrowser --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-7964 Add cordova-plug...
Github user SunboX commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-113439475 I'm getting `10:53:31.345 uncaught exception: module cordova/confighelper not found1 ` using Cordova 5.1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9128 Russian translation for the 5.1
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9219 Added filters to search...
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/19 CB-9219 Added filters to search, support for multiple words, localize⦠⦠download count and other css changes You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web raghav/search Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 14fe2277e94ab4c82c8720ce98ac0474aa498fd4 Author: Raghav Katyal Date: 2015-06-19T17:47:27Z CB-9219 Added filters to search, support for multiple words, localize download count and other css changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/84#issuecomment-113594895 Thanks. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Fixed printing flavored versions
GitHub user oNaiPs opened a pull request: https://github.com/apache/cordova-android/pull/184 Fixed printing flavored versions Current code never prints anything because .has() is not used correctly You can merge this pull request into a Git repository by running: $ git pull https://github.com/oNaiPs/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit 2d94c02fb501655a60b6f74b88464169a7bc2516 Author: Jose Pereira Date: 2015-06-19T18:33:45Z Fixed printing flavored versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[CI] Weekly Update
Hi all, CI has been doing pretty well this week. Some notable things are: - We’re hitting scaling issues (a buffer of 70+ pending builds happened a few times this week) - We’re still waiting on INFRA-9811 and INFRA-9678 for PR-triggered builds Next uses for the CI that are impeded by the scaling issues: - Static analysis (FB Infer) - Automated releases - Documentation generation - Testing on more emulators, platforms, and devices - FirefoxOS, BlackBerry, and WebOS (seeing a lot of love recently) - Moving our platform and tools CI from Travis and AppVeyor to Buildbot, so all our builds are on Apache infrastructure Thoughts on improving scalability: - Builds can be greatly sped up if we can alleviate the path-length limit issue that prevents us from packaging up a Cordova build - Does anyone know of a tool that can zip up too-long paths? - Does anyone know if we can reduce our path lengths? - Does anyone know where we can store a buffer of builds? Cordova-vm is an option (~30GB of space). - We can run more builds in parallel if folks connect more slaves to the CI (instructions here: https://github.com/apache/cordova-medic/blob/master/SLAVES.md) - We can split the build process into levels (e.g. smoke, regression, end-to-end) and run them on different occasions Bug status: ~1 on Android OSX ~2 on Android Windows ~20 on iOS 0 on Windows Phone 8.1 0 on Windows 8.1 0 on Windows 8.0 0 on Windows Phone 8.0 Kindly, Dmitry
Re: [CI] Weekly Update
Quick question, why don't keep travis + appveyor as well as build bot? I don't see the reason to remove that functionality. On Fri, Jun 19, 2015 at 2:27 PM, Dmitry Blotsky wrote: > Hi all, > > CI has been doing pretty well this week. Some notable things are: > - We’re hitting scaling issues (a buffer of 70+ pending builds happened a > few times this week) > - We’re still waiting on INFRA-9811 and INFRA-9678 for PR-triggered builds > > Next uses for the CI that are impeded by the scaling issues: > - Static analysis (FB Infer) > - Automated releases > - Documentation generation > - Testing on more emulators, platforms, and devices > - FirefoxOS, BlackBerry, and WebOS (seeing a lot of love recently) > - Moving our platform and tools CI from Travis and AppVeyor to Buildbot, > so all our builds are on Apache infrastructure > > Thoughts on improving scalability: > - Builds can be greatly sped up if we can alleviate the path-length limit > issue that prevents us from packaging up a Cordova build > - Does anyone know of a tool that can zip up too-long paths? > - Does anyone know if we can reduce our path lengths? > - Does anyone know where we can store a buffer of builds? Cordova-vm is an > option (~30GB of space). > - We can run more builds in parallel if folks connect more slaves to the > CI (instructions here: > https://github.com/apache/cordova-medic/blob/master/SLAVES.md) > - We can split the build process into levels (e.g. smoke, regression, > end-to-end) and run them on different occasions > > Bug status: > ~1 on Android OSX > ~2 on Android Windows > ~20 on iOS > 0 on Windows Phone 8.1 > 0 on Windows 8.1 > 0 on Windows 8.0 > 0 on Windows Phone 8.0 > > Kindly, > Dmitry >
[GitHub] cordova-lib pull request: Updates 'cordova serve' command to use c...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/250 Updates 'cordova serve' command to use cordova-serve module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb-use-cordova-serve-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #250 commit 0fc7a33c071fbae1aa9a2740ca0ff902fd824d0b Author: Tim Barham Date: 2015-05-12T00:00:25Z Updates 'cordova serve' command to use cordova-serve module. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: Update 'cordova run browser' command...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/12 Update 'cordova run browser' command to use cordova-serve module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-browser tb-cordova-serve-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-browser/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 0044fe33ca181db99cebf04558035cffc86f9418 Author: Tim Barham Date: 2015-05-11T23:57:08Z Update 'cordova run browser' command to use cordova-serve module. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] Weekly Update
Steve, travis+appveyor are about running platform tests while buildbot is running all the plugin tests as well. Dmitry, can you elaborate on the specifics of the path-length issue? Is it one platform in particular? My team is hiring! @purplecabbage risingj.com On Fri, Jun 19, 2015 at 2:36 PM, Steven Gill wrote: > Quick question, why don't keep travis + appveyor as well as build bot? I > don't see the reason to remove that functionality. > > On Fri, Jun 19, 2015 at 2:27 PM, Dmitry Blotsky > wrote: > > > Hi all, > > > > CI has been doing pretty well this week. Some notable things are: > > - We’re hitting scaling issues (a buffer of 70+ pending builds happened a > > few times this week) > > - We’re still waiting on INFRA-9811 and INFRA-9678 for PR-triggered > builds > > > > Next uses for the CI that are impeded by the scaling issues: > > - Static analysis (FB Infer) > > - Automated releases > > - Documentation generation > > - Testing on more emulators, platforms, and devices > > - FirefoxOS, BlackBerry, and WebOS (seeing a lot of love recently) > > - Moving our platform and tools CI from Travis and AppVeyor to Buildbot, > > so all our builds are on Apache infrastructure > > > > Thoughts on improving scalability: > > - Builds can be greatly sped up if we can alleviate the path-length limit > > issue that prevents us from packaging up a Cordova build > > - Does anyone know of a tool that can zip up too-long paths? > > - Does anyone know if we can reduce our path lengths? > > - Does anyone know where we can store a buffer of builds? Cordova-vm is > an > > option (~30GB of space). > > - We can run more builds in parallel if folks connect more slaves to the > > CI (instructions here: > > https://github.com/apache/cordova-medic/blob/master/SLAVES.md) > > - We can split the build process into levels (e.g. smoke, regression, > > end-to-end) and run them on different occasions > > > > Bug status: > > ~1 on Android OSX > > ~2 on Android Windows > > ~20 on iOS > > 0 on Windows Phone 8.1 > > 0 on Windows 8.1 > > 0 on Windows 8.0 > > 0 on Windows Phone 8.0 > > > > Kindly, > > Dmitry > > >
[GitHub] cordova-browser pull request: CB-9221 Update 'cordova run browser'...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-browser/pull/12#issuecomment-113660968 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] Weekly Update
@Steve: It’s really just a nice-to-have in the long-term: all CI in one place. They’re fine where they are right now though. Buildbot just runs on our own hardware, and we can control our slave environments more than those of Travis and AppVeyor. Also we don’t need to administer two extra accounts/ @Jesse: The path-length issue is as follows: right now all artifacts of a mobilespec from-source build (i.e. cloning, installing, and linking lib, cli, plugman, js, mobilespec, etc.) cannot be zipped on Windows because there are paths that are too long. If they were to be zipped, there would be only 2 “build mobilespec” builds (one for each OS) at ~6 minutes each, and 7 “test” builds at ~3 minutes each. So, a full E2E build would take up about a third of the time it takes now. Adding more machines would also relieve some of the build pressure though. Kindly, Dmitry > On Jun 19, 2015, at 3:12 PM, Jesse wrote: > > Steve, travis+appveyor are about running platform tests while buildbot is > running all the plugin tests as well. > > Dmitry, can you elaborate on the specifics of the path-length issue? > Is it one platform in particular? > > > My team is hiring! > @purplecabbage > risingj.com > > On Fri, Jun 19, 2015 at 2:36 PM, Steven Gill wrote: > >> Quick question, why don't keep travis + appveyor as well as build bot? I >> don't see the reason to remove that functionality. >> >> On Fri, Jun 19, 2015 at 2:27 PM, Dmitry Blotsky >> wrote: >> >>> Hi all, >>> >>> CI has been doing pretty well this week. Some notable things are: >>> - We’re hitting scaling issues (a buffer of 70+ pending builds happened a >>> few times this week) >>> - We’re still waiting on INFRA-9811 and INFRA-9678 for PR-triggered >> builds >>> >>> Next uses for the CI that are impeded by the scaling issues: >>> - Static analysis (FB Infer) >>> - Automated releases >>> - Documentation generation >>> - Testing on more emulators, platforms, and devices >>> - FirefoxOS, BlackBerry, and WebOS (seeing a lot of love recently) >>> - Moving our platform and tools CI from Travis and AppVeyor to Buildbot, >>> so all our builds are on Apache infrastructure >>> >>> Thoughts on improving scalability: >>> - Builds can be greatly sped up if we can alleviate the path-length limit >>> issue that prevents us from packaging up a Cordova build >>> - Does anyone know of a tool that can zip up too-long paths? >>> - Does anyone know if we can reduce our path lengths? >>> - Does anyone know where we can store a buffer of builds? Cordova-vm is >> an >>> option (~30GB of space). >>> - We can run more builds in parallel if folks connect more slaves to the >>> CI (instructions here: >>> https://github.com/apache/cordova-medic/blob/master/SLAVES.md) >>> - We can split the build process into levels (e.g. smoke, regression, >>> end-to-end) and run them on different occasions >>> >>> Bug status: >>> ~1 on Android OSX >>> ~2 on Android Windows >>> ~20 on iOS >>> 0 on Windows Phone 8.1 >>> 0 on Windows 8.1 >>> 0 on Windows 8.0 >>> 0 on Windows Phone 8.0 >>> >>> Kindly, >>> Dmitry >>> >>
Re: [VOTE] Plugins Release June 17th, 2015
Bump! On Wed, Jun 17, 2015 at 6:06 PM, Steven Gill wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-9192 > > The plugins have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ > > The packages were published from their corresponding git tags: > cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) > cordova-plugin-camera: 1.2.0 (437cf3d93a) > cordova-plugin-console: 1.0.1 (f055daec45) > cordova-plugin-contacts: 1.1.0 (e47559b0d4) > cordova-plugin-device: 1.0.1 (b3da8484ec) > cordova-plugin-device-motion: 1.1.1 (28394c4607) > cordova-plugin-device-orientation: 1.0.1 (427d49f612) > cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) > cordova-plugin-file: 2.1.0 (6276d06d7a) > cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) > cordova-plugin-geolocation: 1.0.1 (e529db6abd) > cordova-plugin-globalization: 1.0.1 (cd9d52355a) > cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) > cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) > cordova-plugin-media: 1.0.1 (b3056343fc) > cordova-plugin-media-capture: 1.0.1 (9af90d8540) > cordova-plugin-network-information: 1.0.1 (d8bdb0e953) > cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) > cordova-plugin-statusbar: 1.0.1 (5e96b2a345) > cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) > cordova-plugin-vibration: 1.2.0 (274003cb33) > cordova-plugin-whitelist: 1.1.0 (521e62b0fd) > > Upon a successful vote I will upload the archives to dist/, upload them to > npm, and post the corresponding blog post. > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies have > Apache-compatible licenses > * Built and ran mobilespec on android and ios > >
[GitHub] cordova-registry-web pull request: CB-9219 Added filters to search...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/19#issuecomment-113672308 LGTM. Feel free to improve this stylistic changes I mentioned later - Merging this one in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9219 Added filters to search...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: Updated the look and feel of th...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/18#issuecomment-113672827 @cpsloal Please close this PR as it's been subsumed by #19. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Remove `ecosystem:cordova` keyword from ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: Add a verbose switch to see all the com...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879001
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message) {
alert('Failed because: ' + message);
}
+
+## navigator.camera.checkForSavedResult
+
+call this method in onDeviceReady to see if there is a result present from
a previous call to getPicture.
--- End diff --
Capitalize first word
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879022
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message) {
alert('Failed because: ' + message);
}
+
+## navigator.camera.checkForSavedResult
+
+call this method in onDeviceReady to see if there is a result present from
a previous call to getPicture.
+add the same options you used when calling getPicture, or leave it out to
pass default options
--- End diff --
Capitalize first word. Also, options are required, but you can pass an
empty object to get the defaults.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879074
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message) {
alert('Failed because: ' + message);
}
+
+## navigator.camera.checkForSavedResult
+
+call this method in onDeviceReady to see if there is a result present from
a previous call to getPicture.
+add the same options you used when calling getPicture, or leave it out to
pass default options
+
+navigator.camera.checkForSavedResult( successCallback, errorCallback,
options );
--- End diff --
Minor: the `getPicture` examples in the README use `onSuccess` and `onFail`
as names for the parameters. And no spacing after parens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879107
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message) {
alert('Failed because: ' + message);
}
+
+## navigator.camera.checkForSavedResult
+
+call this method in onDeviceReady to see if there is a result present from
a previous call to getPicture.
+add the same options you used when calling getPicture, or leave it out to
pass default options
+
+navigator.camera.checkForSavedResult( successCallback, errorCallback,
options );
+
+### Description
+
+Tries to get the intermediate image file that is kept in temporary storage
after calling `camera.getPicture`.
+Applies when the operating system decides to kill our MainActivity while
getting an Image.
+Once our MainActivity restarts you should call this method to see if a
result is available.
+
+If you want to use the same options you used when calling getPicture you
have to make sure you store the options first,
+this way you can use your saved options to call checkForSavedResult, so
the picture get's handled the same as it would have when Android hadn't killed
our MainActivity
--- End diff --
No apostrophe in "gets"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879192
--- Diff: src/android/CameraLauncher.java ---
@@ -124,16 +127,9 @@ public boolean execute(String action, JSONArray args,
CallbackContext callbackCo
this.mediaType = PICTURE;
this.mQuality = 80;
--- End diff --
I would get rid of all of these defaults here. I like your use of `optInt`,
and passing in defaults; would suggest just eliminating the forced defaults
above and go with the single line initialization in the method.
FWIW, here's how I ported this to my local copy:
if (action.equals("takePicture")) {
int srcType = args.optInt(2, CAMERA);
int destType = args.optInt(1, FILE_URI);
// Process the rest of the configuration arguments
processConfiguration(args);
...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879234
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +159,19 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM)) {
PluginResult r = new
PluginResult(PluginResult.Status.NO_RESULT);
r.setKeepCallback(true);
callbackContext.sendPluginResult(r);
-
+
+return true;
+} else if (action.equals("checkForSavedResult")) {
+if (savedRequestCode > 0 || savedResultCode > 0) {
+processConfiguration(args);
+imageUri = Uri.fromFile(createCaptureFile(encodingType));
+onActivityResult(savedRequestCode, savedResultCode,
savedIntent);
+savedRequestCode = 0;
+savedResultCode = 0;
+savedIntent = null;
+} else {
+callbackContext.success("");
--- End diff --
I'm not sure it's expected to get an empty string returned on success -- I
believe the code will always return the requested result (URI to file, or
base64 data). Better to just return an error here?
callbackContext.error("No saved results available.");
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879268
--- Diff: src/android/CameraLauncher.java ---
@@ -173,6 +181,20 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM)) {
// LOCAL METHODS
//--
+private void processConfiguration(JSONArray args) throws JSONException
{
+if (args == null)
+throw new JSONException("no configuration object passed");
+this.mQuality = args.optInt(0, 80);
+// args 1 and 2 (destType, srcType) are skipped because they have
no field representation in this class
+this.targetWidth = args.optInt(3);
+this.targetHeight = args.optInt(4);
+this.encodingType = args.optInt(5, JPEG);
+this.mediaType = args.optInt(6, PICTURE);
+this.allowEdit = args.optBoolean(7);
+this.correctOrientation = args.optBoolean(8);
+this.saveToPhotoAlbum = args.optBoolean(9);
+}
--- End diff --
Nice! FWIW, I added in defaults for all values. Here's my edit:
this.mQuality = args.optInt(0, 80);
// args 1 and 2 (destType, srcType) are skipped because they have
no field representation in this class
this.targetWidth = args.optInt(3, 0);
this.targetHeight = args.optInt(4, 0);
this.encodingType = args.optInt(5, JPEG);
this.mediaType = args.optInt(6, PICTURE);
this.allowEdit = args.optBoolean(7, false);
this.correctOrientation = args.optBoolean(8, false);
this.saveToPhotoAlbum = args.optBoolean(9, false);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879337
--- Diff: www/Camera.js ---
@@ -72,4 +72,28 @@ cameraExport.cleanup = function(successCallback,
errorCallback) {
exec(successCallback, errorCallback, "Camera", "cleanup", []);
};
+cameraExport.checkForSavedResult = function(successCallback,
errorCallback, options) {
+argscheck.checkArgs('fFO', 'Camera.checkForSavedResult', arguments);
+options = options || {};
+var getValue = argscheck.getValue;
+
+var quality = getValue(options.quality, 80);
+var destinationType = getValue(options.destinationType,
Camera.DestinationType.FILE_URI);
+var sourceType = getValue(options.sourceType,
Camera.PictureSourceType.CAMERA);
+var targetWidth = getValue(options.targetWidth, -1);
+var targetHeight = getValue(options.targetHeight, -1);
+var encodingType = getValue(options.encodingType,
Camera.EncodingType.JPEG);
+var mediaType = getValue(options.mediaType, Camera.MediaType.PICTURE);
+var allowEdit = !!options.allowEdit;
+var correctOrientation = !!options.correctOrientation;
+var saveToPhotoAlbum = !!options.saveToPhotoAlbum;
+var popoverOptions = getValue(options.popoverOptions, null);
+var cameraDirection = getValue(options.cameraDirection,
Camera.Direction.BACK);
+
+var args = [quality, destinationType, sourceType, targetWidth,
targetHeight, encodingType,
+mediaType, allowEdit, correctOrientation,
saveToPhotoAlbum, popoverOptions, cameraDirection];
--- End diff --
It would be much better to refactor this as it's shared code with the
getPicture API. Here's a refactor:
// Put this before the getPicture method definition
var prepareArgs = function(options) {
options = options || {};
var getValue = argscheck.getValue;
var quality = getValue(options.quality, 50);
var destinationType = getValue(options.destinationType,
Camera.DestinationType.FILE_URI);
var sourceType = getValue(options.sourceType,
Camera.PictureSourceType.CAMERA);
var targetWidth = getValue(options.targetWidth, -1);
var targetHeight = getValue(options.targetHeight, -1);
var encodingType = getValue(options.encodingType,
Camera.EncodingType.JPEG);
var mediaType = getValue(options.mediaType, Camera.MediaType.PICTURE);
var allowEdit = !!options.allowEdit;
var correctOrientation = !!options.correctOrientation;
var saveToPhotoAlbum = !!options.saveToPhotoAlbum;
var popoverOptions = getValue(options.popoverOptions, null);
var cameraDirection = getValue(options.cameraDirection,
Camera.Direction.BACK);
return [quality, destinationType, sourceType, targetWidth,
targetHeight, encodingType,
mediaType, allowEdit, correctOrientation, saveToPhotoAlbum,
popoverOptions,
cameraDirection];
};
...
cameraExport.getPicture = function(successCallback, errorCallback, options)
{
argscheck.checkArgs('fFO', 'Camera.getPicture', arguments);
var args = prepareArgs(options);
exec(successCallback, errorCallback, "Camera", "takePicture", args);
// XXX: commented out
//return new CameraPopoverHandle();
};
...
cameraExport.checkForSavedResult = function(successCallback, errorCallback,
options) {
argscheck.checkArgs('fFO', 'Camera.checkForSavedResult', arguments);
var args = prepareArgs(options);
exec(successCallback, errorCallback, "Camera", "checkForSavedResult",
args);
};
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113683706 @thehuijb Thanks for quickly reworking based on my feedback! I "ported" these into my fork and it seems to be working fine for me at the moment. I did add a bunch of additional comments directly on the diffs (sorry for the spam). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB 9156 - Move to sibling based platform ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: Refactor code
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/20 Refactor code You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web raghav/refactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 786d638cce37188865aa0f226ff9d0020d13a17a Author: Raghav Katyal Date: 2015-06-20T01:51:01Z Refactor code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Adds plugman support for the Windows pla...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/251 Adds plugman support for the Windows platform. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb-plugman-windows Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #251 commit 9e0e9f594fd19f5b4cee8e69294a309523f4e0bd Author: Tim Barham Date: 2015-06-20T00:10:51Z Adds plugman support for the Windows platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
