[GitHub] cordova-osx pull request: Fix OS X, see CB-7143
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/12#issuecomment-126061637 I think that @onflapp's branch is a bit outdated. I can revisit his changes and see what needs to be updated. it is probably easier to migrate the iOS platform from scratch. @shazron WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Update ubuntu.js
Github user swhgoon closed the pull request at: https://github.com/apache/cordova-lib/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-126129030 I agree. My goal here however was just to fix the exception, not change the behavior of a plugin I'm not familiar with :smile:... So what's the consensus - should I merge this change now, or just leave it pendinging @purplecabbage's rewrite (same question applies to the `device-orientation` change as well). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 3.9.0 iOS Release
+1 Ran coho verify Created cordova project, added device plugin. Had to update ios-sim to 4.0 so I could run cordova run ios. Got a nice message telling me to do that. Cordova requirements is a nice command. On Tue, Jul 28, 2015 at 4:06 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Please review and vote on this 3.9.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9406 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9406 The package was published from its corresponding git tag: cordova-ios: 3.9.0 (209c1e9e02) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-ios#3.9.0 Blog post to review will be sent by separate email to Discuss thread. Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Performed manual smoke testing: platform could be added and built -Sergey Grebnov - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-126136377 Yeah. Merge as is to side step the error. I'll create jira tickets and revisit later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user matt-way commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-126137282 NO_RESULT doing absolutely nothing in javascript is bad design. For example, now there is no way of telling when/if the cordova-plugin-contacts plugin was cancelled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Update: Plugins Registry warnings
So I looked into adding warnings into the registry that users who are trying to publish/adduser would get, but it won't work. If plugman publish is successful, plugman does nothing. If plugman publish fails, plugman will output the error that the registry sends. Once we switch the registry to read-only, I'll add an error message that tells users to publish to npm and points them to the appropriate guide. At the last hangout we discussed delaying switching the registry over to read only until Aug 15thish. We should discuss what else needs to happen for us to hit this. The next tools release, plugman looses all commands related to the registry (publish, unpublish, adduser, owner). I'll be starting that release right after iOS 3.9.0 is done releasing. I am going to spend time tomorrow trying to gather the emails of people who are still publishing and send them an email asking them to move over to npm. -Steve
RE: [DISCUSS] cordova-browser 3.7.0 release
Yeah, fair point. I'll make it a 4.0.0 release. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, July 30, 2015 9:59 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-browser 3.7.0 release Lets do it! Either 3.7.0 or 4.0.0. Base it on the changes that have gone in since 3.6.0 compared to semvers requirements. Launching from a server seems like a pretty big change. Might be 4.0 worthy. On Tue, Jul 28, 2015 at 5:39 PM, Tim Barham tim.bar...@microsoft.com wrote: It seems to me like it would be good to get a cordova-browser release out. There have been a few changes since the last release - most significantly launching from a server rather than the local file system, which I think is an important change to release. Any objections? Would 3.7.0 be the appropriate version? Thanks! Tim
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user matt-way commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-126184116 Can you give one good example of when NO_RESULT would ever be useful? What is the difference now between NO_RESULT and actually not doing anything? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9421 Added a test for plugin fetch wi...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-lib/pull/273 CB-9421 Added a test for plugin fetch with searchpath parameter https://issues.apache.org/jira/browse/CB-9421 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9421 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #273 commit 6f494a271761eef9abbb287967b882924382883b Author: alsorokin alexander.soro...@akvelon.com Date: 2015-07-29T09:41:13Z CB-9421 Added a test for plugin fetch with searchpath parameter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-8222 Background threading fo...
Github user ghenry22 closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming Background threadin...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/62 Streaming Background threading on play This fixes 2 issues in the Cordova Jira, both with iOS. It enables streaming support for media playback from URLs while retaining the existing playback for local media. The second part is the simply background thread the play function so it doesn't block the ui or lock up the app on load. Gets rid of some of those pesky warnings in xcode too. Tested with simulator and on iphone 5 and iphone 6 and ipad 2, with iOS 8.1, 8.3 8.4 Please merge these and bump the version of the media plugin so I can stop installing them from my own fork :) Fix for CB-57 Updated to use avplayer when url starts with http:// or https:// for full streaming support. All other urls will use the standard AVAudioplayer Fix for CB-8222 Background thread on play to prevent locking during initial load of media. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media avplayer_streaming Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 00ddb9372bf4c9b96ccea0dbd285499df1809277 Author: ghenry22 ghenr...@gmail.com Date: 2015-07-29T07:14:59Z Streaming Background threading on play Fix for CB-57 Updated to use avplayer when url starts with http:// or https:// for full streaming support. All other urls will use the standard AVAudioplayer Fix for CB-8222 Background thread on play to prevent locking during initial load of media. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: More background threading for a...
Github user ghenry22 closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9421 Fixed searchpath parameter being...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9421 Added a test for plugin fetch wi...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125955137 The PR LGTM. However, IMO the code that emits `devicemotion` events might be removed due to: a) this is not a scope of plugin to provide stubs for browser functionality b) the `devicemotion` event is already supported by most of the browsers (http://caniuse.com/#search=devicemotion). @purplecabbage, what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9429 Enables jsdom/browser tests for b...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-js/pull/123 CB-9429 Enables jsdom/browser tests for browserify This PR implements [CB-9429](https://issues.apache.org/jira/browse/CB-9429). It also: - Fixes browser-based tests problems (browser not launched, tests files served improperly), so `grunt btest` command now works. - Adds `test` platform to `compile-browserify` target - Add `test-browserify` and `btest-browserify` Grunt targets to run cordova-js tests against browserified bundle You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-js CB-9429 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 commit ba4dcd8e0a0458c1969d4ec7e3965d37d74f1958 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-07-29T07:49:56Z Enables/fixes browser-based tests Also enables both browser and JSDom tests for browserify flow. commit adbe1885b118161f0bd19d82a748653ae0f8ba25 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-07-29T10:42:11Z CB-9429 Enables jsdom/browser tests for browserify commit 42e6a6d26f7eb224e7317d6831f4028f9f7abc69 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-07-29T10:42:11Z Moves test platform sources to platforms directory Updates tests with new test platform paths Updates bundlers to use new test platform path commit 4107d66a0f5996f868a46aebb40d8f6688f2 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-07-29T10:42:11Z Fixes malformed bundle by adding symbol list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] cordova-browser 3.7.0 release
Lets do it! Either 3.7.0 or 4.0.0. Base it on the changes that have gone in since 3.6.0 compared to semvers requirements. Launching from a server seems like a pretty big change. Might be 4.0 worthy. On Tue, Jul 28, 2015 at 5:39 PM, Tim Barham tim.bar...@microsoft.com wrote: It seems to me like it would be good to get a cordova-browser release out. There have been a few changes since the last release - most significantly launching from a server rather than the local file system, which I think is an important change to release. Any objections? Would 3.7.0 be the appropriate version? Thanks! Tim
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-126146012 In the case of the contacts plugin, yes, android should return an error on Activity.RESULT_CANCELED This is an inappropriate use of NO_RESULT. Please file an issue in JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125975741 Yeah. I was still going to look at a rewrite in the near future. No need to fake data... On Jul 29, 2015, at 6:38 AM, Vladimir Kotikov notificati...@github.com wrote: The PR LGTM. However, IMO the code that emits devicemotion events might be removed due to: a) this is not a scope of plugin to provide stubs for browser functionality b) the devicemotion event is already supported by most of the browsers (http://caniuse.com/#search=devicemotion). @purplecabbage, what do you think? â Reply to this email directly or view it on GitHub. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
