Re: Marshmallow Update and Cordova-Android 5.0

[Karen Tran]

Hi Joe,

I tested your patch and it works for the most part using mobilespec's
manual test for contacts. I do see the prompt for permissions contacts, but
not explicitly to read or write contacts like you mentioned.

One thing that doesn't work is if you click "Deny" permission, the app
crashes. I don't think we'd want that to happen, so we'll have to handle
that case.

And as for the contact autotests, they're a bit finicky now with a couple
of failures.

On Tue, Sep 1, 2015 at 9:39 AM, Carlos Santana  wrote:

> Joe I understand the feeling. One part of me saying that we should name the
> version 4.2 since there are no API changes.
> But my other part says that if developer's ignore because is 4.x stuff will
> break in new major release of Android M (23)
>
> I would say that also agree that best option is to name is
> cordova-android@5
> , then is clear to developers that they can use targetsdk=23 and also new
> major versions for the affected plugins that need updates to support
> targetsdk=23
>
> But as you can see this is less important that getting the plugins to work
> correctly with permissions :-)
>
>
>
> On Tue, Sep 1, 2015 at 12:03 AM Joe Bowser  wrote:
>
> > BTW: I got Contacts somewhat working with Marshmellow.  It's still got
> the
> > same crappy concurrency bugs that it always has, and I am not sure how to
> > resolve those without re-writing the damn thing, but the purpose of this
> is
> > to figure out how to get permissions to work, and I have something that
> > works.
> >
> > https://github.com/infil00p/cordova-plugin-contacts/tree/smores
> >
> > This works with the latest smores tree of Cordova Android, and I tested
> it
> > on Lollipop and Marshmellow.  I'm going to move on to some of the other
> > plugins to get them ready for Marshmellow, but it'd be good to have
> people
> > look these over.
> >
> > I did find a nasty security bug with this, though.  If you request one
> > permission out of the permission group, you get all the permissions.  So,
> > anything that can read contacts can magically write contacts even if you
> > don't request that permission explicitly.  I think this is a serious bug,
> > and I'm going to dig tomorrow to see if someone already reported it.
> >
> > On Mon, Aug 31, 2015 at 11:35 AM Joe Bowser  wrote:
> >
> > > Hey
> > >
> > > So, I created a new topic branch of my github with the new changes as
> > > suggested earlier.
> > >
> > > https://github.com/infil00p/cordova-android/tree/smores
> > >
> > > The thing we have to make sure works is if the user turns off the
> > > permissions on Marshmellow.  Right now if the permissions are off,
> > > everything crashes and dies, so we're going to issue a 5.0 because
> > plugins
> > > will have to have this code to work on the latest version of Android.
> > It's
> > > not a API change, since we're adding it, but I feel that it's important
> > > enough that we should bump the major version anyway.
> > >
> > > Can we PLEASE not have any other features creep into 5.0?  If we need
> > > additional features, we can do a 6.0.  I'm not against bumping major
> > > versions as long as we get into a trend of not breaking shit like we
> did
> > in
> > > the bump from 3.7 to 4.0.
> > >
> > > Also, we're going to deprecate 3.7, is there any major third-party
> > plugins
> > > that still don't work with 4.0.x that we should be aware of?  Do we
> have
> > > people to cover the docs on that.
> > >
> > > Thoughts?
> > >
> > > Joe
> > >
> > >
> > >
> >
>

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38659073
  
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
 fail(e);
 }
 }, 
-vibrateWithPattern: function(success, fail, args) {
-// TODO: Implement with setTimeout.
-fail('"vibrateWithPattern" is unsupported by this platform.');
+vibrateWithPattern: function (success, fail, args) {
+// Cancel current vibrations first
+module.exports.cancelVibration(function () {
+// Removes the first zero
+if (args[0] && args[0][0] === 0) {
--- End diff --

Can we factor out args[0] to a more meaningful variable name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38659458
  
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
 fail(e);
 }
 }, 
-vibrateWithPattern: function(success, fail, args) {
-// TODO: Implement with setTimeout.
-fail('"vibrateWithPattern" is unsupported by this platform.');
+vibrateWithPattern: function (success, fail, args) {
+// Cancel current vibrations first
+module.exports.cancelVibration(function () {
+// Removes the first zero
+if (args[0] && args[0][0] === 0) {
+args[0].shift(0);
+}
+
+patternChainPromise = args[0].reduce(function 
(previousValue, currentValue, index) {
--- End diff --

Do we need to test for presence of args[0]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/219#issuecomment-137487656
  
Thanks! LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38659317
  
--- Diff: README.md ---
@@ -113,7 +113,9 @@ Vibrates the device with a given pattern
 
 Windows Quirks
 
-- vibrate(pattern) falls back on vibrate with default duration
+- `repeat` parameter is not supported
--- End diff --

Why is repeat not supported?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#issuecomment-137486956
  
Should any mobilespec tests be updated now that this is supported for 
Windows? Or is mobilespec not testing this because its not supported on 
emulators?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38669813
  
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
 fail(e);
 }
 }, 
-vibrateWithPattern: function(success, fail, args) {
-// TODO: Implement with setTimeout.
-fail('"vibrateWithPattern" is unsupported by this platform.');
+vibrateWithPattern: function (success, fail, args) {
+// Cancel current vibrations first
+module.exports.cancelVibration(function () {
+// Removes the first zero
+if (args[0] && args[0][0] === 0) {
+args[0].shift(0);
+}
+
+patternChainPromise = args[0].reduce(function 
(previousValue, currentValue, index) {
+if (index % 2 === 0) {
+return previousValue.then(function () {
+return new WinJS.Promise(function (complete, 
error) {
+module.exports.vibrate(function () {}, 
function(err) {
+console.error(err);
+error(err);
+}, [currentValue]);
+
+setTimeout(function () {
+complete();
+}, parseInt(currentValue, 10));
+});
+});
+} else {
+return previousValue.then(function () {
+return new WinJS.Promise(function (complete) {
--- End diff --

Prefer `WinJS.Promise.timeout(parseInt(currentValue, 10))` to `new 
WinJS.Promise( ... setTimeout(...))`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] 3.8.0 BlackBerry Release (take 2)

[Steven Gill]

+1

On Wed, Sep 2, 2015 at 2:39 PM, Tim Windsor  wrote:

> +1 (non-PMC member)
>
> Tested:
> - new project creation, platform add and build to device.
> - webworks-cli (3.6.0) new project creation, update to 3.8.0 and deploy to
> device
> - new cordova project, add blackberry10 3.7.0 platfrom, update to 3.8.0
> and deploy to device
> - build and run mobile-spec app
>
> Tim Windsor
> Open Source Technical Lead – Devices
>
>
>
>
> -Original Message-
> From: Bryan Higgins [mailto:br...@bryanhiggins.net]
> Sent: Wednesday, September 02, 2015 5:29 PM
> To: dev@cordova.apache.org
> Subject: [VOTE] 3.8.0 BlackBerry Release (take 2)
>
> Please review and vote on this 3.8.0 BlackBerry Release by replying to
> this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-9576
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-9576
>
> The package was published from its corresponding git tag:
> 6790a1ed4b
>
> Note that you can test it out via:
>
> cordova platform add
> https://github.com/apache/cordova-blackberry#3.8.0
>
> Blog post to review is here:
>
> https://github.com/cordova/apache-blog-posts/pull/45
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> NPM, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Tested project creation and device deployment
>

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/64#issuecomment-137533398
  
LGTM!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/329#issuecomment-137551154
  
It lives!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/329#issuecomment-137541650
  
GitHub has fallen out of sync with ASF Git. ):


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9606 Fixes arguments parsing...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/65#issuecomment-137535688
  
lgtm!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/329


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/329#issuecomment-137535292
  
Wow, thanks!
Merge away.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Marshmallow Update and Cordova-Android 5.0

[Joe Bowser]

On Thu, Sep 3, 2015 at 8:07 AM Karen Tran  wrote:

> Hi Joe,
>
> I tested your patch and it works for the most part using mobilespec's
> manual test for contacts. I do see the prompt for permissions contacts, but
> not explicitly to read or write contacts like you mentioned.
>
> I don't either, even though I'm explicitly promoting for the permission.
Also, I found that if you prompt for READ permissions, you get both READ
and WRITE.


> One thing that doesn't work is if you click "Deny" permission, the app
> crashes. I don't think we'd want that to happen, so we'll have to handle
> that case.
>

It should work now.  I forgot to return out of the method once the
permission is denied.


>
> And as for the contact autotests, they're a bit finicky now with a couple
> of failures.
>

Contacts has always been finicky, and needs a full re-write.  I wasn't
intending to fully fix this plugin (because of time), just get the
permissions working because it's the low hanging fruit.  Any change to the
flow of the tests will break the tests because of concurrency issues with
the Android Contacts API.

I also have the Camera using the plugin, since we rely on external storage
for determining whether we're going to produce duplicates.

https://github.com/infil00p/cordova-plugin-camera/tree/smores



> On Tue, Sep 1, 2015 at 9:39 AM, Carlos Santana 
> wrote:
>
> > Joe I understand the feeling. One part of me saying that we should name
> the
> > version 4.2 since there are no API changes.
> > But my other part says that if developer's ignore because is 4.x stuff
> will
> > break in new major release of Android M (23)
> >
> > I would say that also agree that best option is to name is
> > cordova-android@5
> > , then is clear to developers that they can use targetsdk=23 and also new
> > major versions for the affected plugins that need updates to support
> > targetsdk=23
> >
> > But as you can see this is less important that getting the plugins to
> work
> > correctly with permissions :-)
> >
> >
> >
> > On Tue, Sep 1, 2015 at 12:03 AM Joe Bowser  wrote:
> >
> > > BTW: I got Contacts somewhat working with Marshmellow.  It's still got
> > the
> > > same crappy concurrency bugs that it always has, and I am not sure how
> to
> > > resolve those without re-writing the damn thing, but the purpose of
> this
> > is
> > > to figure out how to get permissions to work, and I have something that
> > > works.
> > >
> > > https://github.com/infil00p/cordova-plugin-contacts/tree/smores
> > >
> > > This works with the latest smores tree of Cordova Android, and I tested
> > it
> > > on Lollipop and Marshmellow.  I'm going to move on to some of the other
> > > plugins to get them ready for Marshmellow, but it'd be good to have
> > people
> > > look these over.
> > >
> > > I did find a nasty security bug with this, though.  If you request one
> > > permission out of the permission group, you get all the permissions.
> So,
> > > anything that can read contacts can magically write contacts even if
> you
> > > don't request that permission explicitly.  I think this is a serious
> bug,
> > > and I'm going to dig tomorrow to see if someone already reported it.
> > >
> > > On Mon, Aug 31, 2015 at 11:35 AM Joe Bowser  wrote:
> > >
> > > > Hey
> > > >
> > > > So, I created a new topic branch of my github with the new changes as
> > > > suggested earlier.
> > > >
> > > > https://github.com/infil00p/cordova-android/tree/smores
> > > >
> > > > The thing we have to make sure works is if the user turns off the
> > > > permissions on Marshmellow.  Right now if the permissions are off,
> > > > everything crashes and dies, so we're going to issue a 5.0 because
> > > plugins
> > > > will have to have this code to work on the latest version of Android.
> > > It's
> > > > not a API change, since we're adding it, but I feel that it's
> important
> > > > enough that we should bump the major version anyway.
> > > >
> > > > Can we PLEASE not have any other features creep into 5.0?  If we need
> > > > additional features, we can do a 6.0.  I'm not against bumping major
> > > > versions as long as we get into a trend of not breaking shit like we
> > did
> > > in
> > > > the bump from 3.7 to 4.0.
> > > >
> > > > Also, we're going to deprecate 3.7, is there any major third-party
> > > plugins
> > > > that still don't work with 4.0.x that we should be aware of?  Do we
> > have
> > > > people to cover the docs on that.
> > > >
> > > > Thoughts?
> > > >
> > > > Joe
> > > >
> > > >
> > > >
> > >
> >
>

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38669919
  
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
 fail(e);
 }
 }, 
-vibrateWithPattern: function(success, fail, args) {
-// TODO: Implement with setTimeout.
-fail('"vibrateWithPattern" is unsupported by this platform.');
+vibrateWithPattern: function (success, fail, args) {
+// Cancel current vibrations first
+module.exports.cancelVibration(function () {
+// Removes the first zero
+if (args[0] && args[0][0] === 0) {
+args[0].shift(0);
+}
+
+patternChainPromise = args[0].reduce(function 
(previousValue, currentValue, index) {
+if (index % 2 === 0) {
+return previousValue.then(function () {
+return new WinJS.Promise(function (complete, 
error) {
+module.exports.vibrate(function () {}, 
function(err) {
+console.error(err);
+error(err);
+}, [currentValue]);
+
+setTimeout(function () {
+complete();
+}, parseInt(currentValue, 10));
+});
+});
+} else {
+return previousValue.then(function () {
+return new WinJS.Promise(function (complete) {
+setTimeout(function () {
+complete();
+}, parseInt(currentValue, 10));
+});
+});
+}
+}, WinJS.Promise.as());
+}, fail);
 },
 cancelVibration: function(success, fail, args) {
 try {
+patternChainPromise && patternChainPromise.cancel();
--- End diff --

If you're currently vibrating, will the vibration itself also be cancelled? 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38670056
  
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
 fail(e);
 }
 }, 
-vibrateWithPattern: function(success, fail, args) {
-// TODO: Implement with setTimeout.
-fail('"vibrateWithPattern" is unsupported by this platform.');
+vibrateWithPattern: function (success, fail, args) {
+// Cancel current vibrations first
+module.exports.cancelVibration(function () {
+// Removes the first zero
+if (args[0] && args[0][0] === 0) {
+args[0].shift(0);
+}
+
+patternChainPromise = args[0].reduce(function 
(previousValue, currentValue, index) {
+if (index % 2 === 0) {
+return previousValue.then(function () {
+return new WinJS.Promise(function (complete, 
error) {
+module.exports.vibrate(function () {}, 
function(err) {
+console.error(err);
+error(err);
+}, [currentValue]);
--- End diff --

We make a lot of references to `currentValue`.  Can we just parse it once 
and save the integer form?  Maybe we can opportunistically parse all of them on 
input and if any parse return NaN then we fail fast.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] Tools Release Aug 28th

[Steven Gill]

The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Tim Barham
Sergey Grebnov

The vote has passed. I will publish to dist. I'll wait until after the
blackberry release to set to latest on npm.


On Tue, Sep 1, 2015 at 2:29 AM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> I vote +1:
>
> * Installed cordova@rc on OSX
> * Created, built and run blank app on ios
>
> -Sergey Grebnov
>
> -Original Message-
> From: Tim Barham [mailto:tim.bar...@microsoft.com]
> Sent: Tuesday, September 1, 2015 4:35 AM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release Aug 28th
>
> +1
>
> * Verified tags with coho verify-tags
> * Verified signature and hashes with coho verify-archive
> * Verified package contents match git repo at tag
> * Installed Cordova
> * Built and ran blank app for Windows, Android, Browser
> * Verified blank app launches without error in Ripple
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Saturday, August 29, 2015 10:12 AM
> To: dev@cordova.apache.org
> Subject: Re: [Vote] Tools Release Aug 28th
>
> You can test via npm install -g cordova@rc
>
> On Fri, Aug 28, 2015 at 5:10 PM, Steven Gill 
> wrote:
>
> > Please review and vote on this Tools Release by replying to this email
> > (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fCB-9574=01%7c01%7cTBARHAM%40064d.m
> > gd.microsoft.com%7ca8bb5a9a2bfe4287d40908d2b00676a6%7c72f988bf86f141af
> > 91ab2d7cd011db47%7c1=G6OWjCtY79PXjOYZ%2bgrDYft3srcryHEaWeoRQXGs8
> > yA%3d
> >
> > Both tools have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9574/
> >
> > The packages were published from their corresponding git tags:
> >
> > cordova-js: 4.1.1 (66c2bb8e56)
> > cordova-lib: 5.3.1 (7ce4eb4b8f)
> > cordova-plugman: 1.0.2 (ee8aefc5cc)
> > cordova-cli: 5.3.1 (427c1f2294)
> >
> > Upon a successful vote I will upload the archives to dist/, publish them
> to NPM, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> > b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.
> > md=01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7ca8bb5a9a2bfe4287d
> > 40908d2b00676a6%7c72f988bf86f141af91ab2d7cd011db47%7c1=FicqExIIO
> > g%2b4GPNn9s3Q6MH5N7PFoaOH4SezvFXIYM0%3d
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Built hello world app and mobile-spec
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-137558561
  
Hi Paulo,
Please sign an ICLA as explained here:
http://cordova.apache.org/#contribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Update index.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: iOS 9 data-rel back not working - known issue?

[Jesse]

Can you verify that jQuery+jQM function correctly?
Since iOS9 is not out yet, we don't have a lot of details for you. There
are currently no known issues related to this.

Also, this list is for cordova development itself, not for development
questions
using cordova.  You should try stack-overflow, http://slack.cordova.io/ or
the google-groups mailing list [1]

Cheers,
  Jesse

[1] https://groups.google.com/forum/#!forum/phonegap


My team is hiring!
@purplecabbage
risingj.com

On Thu, Sep 3, 2015 at 2:22 PM, Cem Yesil  wrote:

> Hi,
> I have an app that is going to be shipped to my client next week. He
> reported to me that the back button in the navigation bar (anchor with
> data-rel="back") is not working. I downloaded the XCode Beta with iOS 9 and
> it's true. It's working fine on other versions.Is that a known issue, or at
> least can you confirm that this is a cordova issue?
> Thanks and kind regards,Cem Yesil

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/34#issuecomment-137579131
  
rebase or close please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Added parameter for additional ...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/24#issuecomment-137575541
  
Hi Simon,
Please file a ICLA and a JIRA Ticket. 
You will need to rebase as well.
We will have to close this soon otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9079 Increased timeout for p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

[appjitsu]

Github user appjitsu commented on the pull request:

https://github.com/apache/cordova-ios/pull/132#issuecomment-137566856
  
remove/add works for me on mac


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

iOS 9 data-rel back not working - known issue?

[Cem Yesil]

Hi,
I have an app that is going to be shipped to my client next week. He reported 
to me that the back button in the navigation bar (anchor with data-rel="back") 
is not working. I downloaded the XCode Beta with iOS 9 and it's true. It's 
working fine on other versions.Is that a known issue, or at least can you 
confirm that this is a cordova issue?
Thanks and kind regards,Cem Yesil 

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546
  
Looks good. However there is another chance to access `this._config` before 
it will be initialized: 
https://github.com/MSOpenTech/cordova-lib/blob/CB-9604/cordova-lib/src/platforms/PlatformApiPoly.js#L162.

Probably it makes sense to eliminate "private" `this._config` and always 
use `platformInfo.projectConfig` instead, which need to be a dynamic property 
with getter? Your thoughts? I can refactor this by myself after.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9587 Check if browser platform added ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/293#issuecomment-13732
  
Yes, i didn't found any 'browser'-specific things to check too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/64

CB-9605 Fixes issue with playback resume after pause on WP8

This fixes [CB-9605](https://issues.apache.org/jira/browse/CB-9605)

In case of playing remote file, specified by URL (instead of local path) 
`player.Source.AbsolutePath` is a last part of original URL and thus 
`AbsolutePath.LastIndexOf(filePath)` always -1:

AbsoluteUri = "http://cordova.apache.org/downloads/BlueZedEx.mp3;
AbsolutePath = "/downloads/BlueZedEx.mp3"

So, using an `AbsoluteUri` looks more reasonable and works for both local 
files and remote URLs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-9605

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit 71af3b1c302d4adfffb2616a60e95c4ca94d3046
Author: Vladimir Kotikov 
Date:   2015-09-03T08:07:17Z

CB-9605 Fixes issue with playback resume after pause on WP8




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9587 Check if browser platform added ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/293


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9606 Fixes arguments parsing...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/65

CB-9606 Fixes arguments parsing in `seekAudio`

This fixes [CB-9606](https://issues.apache.org/jira/browse/CB-9606)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-9606

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit d0d0c874cc52f439ec7f40d126b8e00dc821ed00
Author: Vladimir Kotikov 
Date:   2015-09-03T08:52:20Z

CB-9606 Fixes arguments parsing in `seekAudio`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...

[mbektchiev]

Github user mbektchiev commented on the pull request:

https://github.com/apache/cordova-lib/pull/289#issuecomment-137356795
  
@stevengill Can you please review this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/329

Fixing license headers in all Markdown files.

Some files had partially translated or overflowing and malformed license 
headers. This commit fixes all of them to use the text of the Apache license, 
and formats them all in the same way.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs license-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/329.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #329


commit 2bc44f59cde27e66299098dab71902a4373bb4d6
Author: Dmitry Blotsky 
Date:   2015-09-03T08:18:18Z

Fixing license headers in all Markdown files.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Merging files.

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/330

Merging files.

Obeying all `config.json` files, merged all files into their specified 
destinations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs merging-files

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #330


commit 2bc44f59cde27e66299098dab71902a4373bb4d6
Author: Dmitry Blotsky 
Date:   2015-09-03T08:18:18Z

Fixing license headers in all Markdown files.

commit 4e4b191d7770145a5dfc1a5a5191918788d48a47
Author: Dmitry Blotsky 
Date:   2015-09-03T10:07:29Z

Merging all specified merges.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

[daserge]

Github user daserge closed the pull request at:

https://github.com/apache/cordova-cli/pull/219


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-cli/pull/219#issuecomment-137405643
  
@stevengill, @nikhilkh, 
Verified (works OK) and documented the ways to disable updates check, 
please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

[daserge]

GitHub user daserge reopened a pull request:

https://github.com/apache/cordova-cli/pull/219

CB-9523 Show out of date message for older cordova CLI

Used [update-notifier](https://github.com/yeoman/update-notifier) module

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli CB-9523

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #219


commit d7179b716df7be1f511685ac9ea430c15a659235
Author: daserge 
Date:   2015-08-20T17:24:20Z

CB-9523 Show out of date message for older cordova CLI
Used update-notifier module
Added instructions on disabling the updates check




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Merging files.

[dblotsky]

Github user dblotsky closed the pull request at:

https://github.com/apache/cordova-docs/pull/330


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

[vldmrrr]

Github user vldmrrr commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/34#issuecomment-137588661
  
Closing due to age


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

[vldmrrr]

Github user vldmrrr closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

[uareurapid]

Github user uareurapid commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-137591772
  
Great news. I will send you the pdf in the next days. 
cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[REVIEW] CPR readonly blog post.

[Steven Gill]

Please review.
https://github.com/cordova/apache-blog-posts/blob/master/2015-09-03-CPR-readonly.md

Anything else I should add?

-Steve

Re: [REVIEW] CPR readonly blog post.

[Shazron]

Looks good. Spelling "swithed"

On Thu, Sep 3, 2015 at 5:14 PM, Steven Gill  wrote:

> Please review.
>
> https://github.com/cordova/apache-blog-posts/blob/master/2015-09-03-CPR-readonly.md
>
> Anything else I should add?
>
> -Steve
>

[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/290#issuecomment-137600450
  
I'll review them next week (off tomorrow). Thanks for the ping. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Merging all specified merges.

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/331

Merging all specified merges.

Obeying all config.json files, merged all files into their specified 
destinations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs merging-files

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit 4e4b191d7770145a5dfc1a5a5191918788d48a47
Author: Dmitry Blotsky 
Date:   2015-09-03T10:07:29Z

Merging all specified merges.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [REVIEW] CPR readonly blog post.

[Carlos Santana]

Replace "read-only" , it's soo 2014
Use "immutable" sounds more hipster :-)

Other than that looks good to me, I notice you don't mentioned plugman cli. I 
think is OK to make general use to be cordova cli. 


- Carlos
Sent from my iPhone

> On Sep 3, 2015, at 8:27 PM, Shazron  wrote:
>  
> Looks good. Spelling "swithed"
> 
>> On Thu, Sep 3, 2015 at 5:14 PM, Steven Gill  wrote:
>> 
>> Please review.
>> 
>> https://github.com/cordova/apache-blog-posts/blob/master/2015-09-03-CPR-readonly.md
>> 
>> Anything else I should add?
>> 
>> -Steve
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function

[cojomojo]

Github user cojomojo commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-137577342
  
Is this PR still being considered?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: iOS 9 data-rel back not working - known issue?

[julio cesar sanchez]

data-rel="back" is a jquery mobile thing, right? Then it might be a jquery
mobile issue.
El 3/9/2015 23:27, "Cem Yesil"  escribió:

> Hi,
> I have an app that is going to be shipped to my client next week. He
> reported to me that the back button in the navigation bar (anchor with
> data-rel="back") is not working. I downloaded the XCode Beta with iOS 9 and
> it's true. It's working fine on other versions.Is that a known issue, or at
> least can you confirm that this is a cordova issue?
> Thanks and kind regards,Cem Yesil

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/119#discussion_r38723211
  
--- Diff: template/cordova/lib/log.js ---
@@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'),
 configPath   = path.join(projectRoot, 'config.xml');
 
 // variables
-var appTracingInitialState = null,
+var appTracingLog  = 
'Microsoft-Windows-AppHost/ApplicationTracing',
+appTracingInitialState = null,
 appTracingCurrentState = null,
-adminInitialState = null,
-adminCurrentState = null,
+adminLog   = 'Microsoft-Windows-AppHost/Admin',
+adminInitialState  = null,
+adminCurrentState  = null,
+timers = [],
 appName;
 
 /*
  * Gets windows AppHost/ApplicationTracing and AppHost/Admin logs
  * and prints them to console
  */
-module.exports.run = function() {
-getLogState('Microsoft-Windows-AppHost/Admin').then(function (state) {
+module.exports.run = function(args) {
+var dump = false, 
+startTime = new Date(new Date().getTime() - 10 * 60 * 
1000).toISOString(); // show last 10 minutes by default
+
+if (args.length > 0) {
+for (var i = 0; i < args.length; i++) {
+switch (args[i]) {
+case '--startTime':
--- End diff --

Instead of start time which is often hard to specify you should have last 
'n' minutes or seconds: `--mins`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/119#discussion_r38723140
  
--- Diff: template/cordova/lib/log.js ---
@@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'),
 configPath   = path.join(projectRoot, 'config.xml');
 
 // variables
-var appTracingInitialState = null,
+var appTracingLog  = 
'Microsoft-Windows-AppHost/ApplicationTracing',
+appTracingInitialState = null,
 appTracingCurrentState = null,
-adminInitialState = null,
-adminCurrentState = null,
+adminLog   = 'Microsoft-Windows-AppHost/Admin',
+adminInitialState  = null,
+adminCurrentState  = null,
+timers = [],
 appName;
 
 /*
  * Gets windows AppHost/ApplicationTracing and AppHost/Admin logs
  * and prints them to console
  */
-module.exports.run = function() {
-getLogState('Microsoft-Windows-AppHost/Admin').then(function (state) {
+module.exports.run = function(args) {
+var dump = false, 
+startTime = new Date(new Date().getTime() - 10 * 60 * 
1000).toISOString(); // show last 10 minutes by default
+
+if (args.length > 0) {
+for (var i = 0; i < args.length; i++) {
+switch (args[i]) {
--- End diff --

Ideally, we should use a library for this - the one that is used by 
cordova-windows should be re-used here instead of doing this on your own.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Merging all specified merges.

[dblotsky]

Github user dblotsky closed the pull request at:

https://github.com/apache/cordova-docs/pull/331


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org