Re: [DISCUSS] Curating Apps

2015-10-18 Thread Jesse
This was part of my hesitation in doing this.
PhoneGap.com gets >20 submissions a week, and someone has to look at them,
validate them. Here [1] is a link to page 30 of the android apps, and there
are 24 apps per page.

We also have to consider appropriateness of the app, is it adult? mature?
We cannot display every app submitted.
I agree with automating the display of apps, we don't want to have to do
this.

[1] http://phonegap.com/app/android/page30/



My team is hiring!
@purplecabbage
risingj.com

On Fri, Oct 16, 2015 at 5:35 PM, Dmitry Blotsky 
wrote:

> So, there are two items to address here:
> - display policy
> - content policy
>
> I propose the following policy for app content:
> - if the app is on an app store, it is OK to show on our page
>
> I propose the following strategy for app display:
> - show 6 apps and 6 tools
> - pick them at random at each page load from their respective lists
> - when we agree on quality metrics:
> - use them to sort instead of picking randomly OR
> - pick arbitrarily at our discretion
>
> Kindly,
> Dmitry
>
> > On Oct 16, 2015, at 2:19 PM, julio cesar sanchez 
> wrote:
> >
> > I think every cordova app should be accepted and displayed, but we should
> > create a "Featured apps" section like
> https://na01.safelinks.protection.outlook.com/?url=phonegap.com&data=01%7c01%7cdblotsky%40microsoft.com%7cb6348c11e8b944fe70cf08d2d66f7669%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=eDhU2NWipwMST6Kvu%2bxGRZVseukwYgOoS2QBhmPTK78%3d,
> where we show "the best
> > of the best", or show the best on first page
> >
> > 2015-10-16 23:07 GMT+02:00 Tommy Williams :
> >
> >> +1 for curation.
> >>
> >> Apps in the showcase should really be the best of the best, yeah? Apps
> >> that show that the myths about Cordova aren’t true, etc.
> >>
> >>
> >> On 17 October 2015 at 07:44:49, Joe Bowser (bows...@gmail.com) wrote:
> >>
> >> Yes, I definitely think we should be curating the apps to make sure
> they're
> >> legit.
> >>
> >> On Fri, Oct 16, 2015 at 10:49 AM, Dmitry Blotsky <
> dblot...@microsoft.com>
> >> wrote:
> >>
> >>> Hey folks,
> >>>
> >>> Just a quick thought: should we be curating the apps in the showcase to
> >>> make sure they’re legit? I verify that they’re on an app store, but the
> >>> Android app store has no curation.
> >>>
> >>> Kindly,
> >>> Dmitry
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


RE: Is CPR going offline

2015-10-18 Thread Parashuram N
To follow up on this, we discussed it at the face to face. Steve has an action 
item to look at the download count for CPR - at the moment, the number of 
requests seem to make it hard to shut down. Carlos also said if we could get 
cloudant to host this registry. 

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Saturday, October 10, 2015 1:12 PM
To: dev@cordova.apache.org
Subject: Re: Is CPR going offline

Lets talk more about it at the f2f. I haven't heard any updated from our hosts 
about shutdown, so we can keep it online for a little while longer.
We should definitely start discussing a backup plan though (some sort of auto 
redirect to npm on the server)



On Fri, Oct 9, 2015 at 3:42 PM, Carlos Santana  wrote:

> The question is are we going to need to hosted some where else, I 
> remember something about not getting free hosting anymore.
>
> But I guess Steve will enlighten us when he reads these emails :-) On 
> Fri, Oct 9, 2015 at 6:36 PM Gorkem Ercan 
> wrote:
>
> >
> > +1
> > I also observe that people has taken their time to update.
> > I think it is helpful to keep CPR around until new year.
> > We can then send CPR away with a countdown on new year's day, 
> > instead of the viking funeral.
> > --
> > Gorkem
> >
> > On 9 Oct 2015, at 18:04, Nikhil Khandelwal wrote:
> >
> > > I am in favor of keeping it running without making any updates. 
> > > There is fairly high % of users using cordova cli version < 
> > > cordova 5 (~25% based on survey responses). Since our survey is 
> > > not yet broadly publicized, but only using twitter, this number is likely 
> > > higher.
> > >
> > > We should look at download numbers from CPR and when they become 
> > > sufficiently low, then we should decide to take it offline.
> > >
> > > Our switch to 
> > > https://na01.safelinks.protection.outlook.com/?url=plugins.cordova
> > > .io&data=01%7c01%7cpanarasi%40microsoft.com%7cf031643a071c4c4f3a65
> > > 08d2d1af2c5f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=NcqZcARglozR%2bOF56z5BdLM8CALPl8cQG27%2fVi%2bn2BU%3d
> > >  use the new plugin search will likely push people to upgrade to the new 
> > > CLI versions and phase out CPR - but it's going to take more time than 
> > > another week (our initial phase out date).
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > Sent: Friday, October 9, 2015 2:49 PM
> > > To: Cordova Dev 
> > > Subject: Re: Is CPR going offline
> > >
> > > If there is no reason to keep it alive, I was already handing out 
> > > obituaries for CPR, it served a good purpose for his lifetime
> > >
> > > On Fri, Oct 9, 2015 at 9:43 AM Gorkem Ercan 
> > > 
> > > wrote:
> > >
> > >>
> > >> Hi,
> > >> Our announced date Oct 15 is next week.
> > >> Will CPR be go offline as planned or do we see that we should 
> > >> give it more time.
> > >> --
> > >> Gorkem
> > >>
> > >> -
> > >>  To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > >>
> > >>
> > >
> > > --
> > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


RE: Using Cordova Plugins with ReactNative

2015-10-18 Thread Parashuram N
Thanks :) 

-Original Message-
From: mikeywbro...@gmail.com [mailto:mikeywbro...@gmail.com] On Behalf Of 
Michael Brooks
Sent: Friday, October 16, 2015 10:29 AM
To: dev@cordova.apache.org
Subject: Re: Using Cordova Plugins with ReactNative

So rad! Amazing work Parashuram!

On Fri, Oct 16, 2015 at 10:25 AM, Parashuram N 
wrote:

> During the Face to Face yesterday, I showed a quick hack that I put 
> together to use Cordova plugins in React Native. I was encouraged to 
> share it on the dev mailing list. Would love to hear what you guys 
> think about the idea.
>
> The basic idea here is that we have more than 1000 Cordova plugins 
> that help us access device capabilities. Why not simply re-use them 
> with react native !!
>
> Here is a demo - 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwww.y
> outube.com%2fwatch%3fv%3dh_fKByit6IY&data=01%7c01%7cpanarasi%40microso
> ft.com%7cbdf9c2cbdda2413cd7cf08d2d64f52e3%7c72f988bf86f141af91ab2d7cd0
> 11db47%7c1&sdata=1CZZlKzjjnzRmGNX0dqMgpcJvw3%2bQ91fLh9qwBGjLxs%3d
> Explanation of how I leverage Cordova plugman to achieve this - 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fblog.n
> parashuram.com%2f2015%2f10%2fusing-cordova-plugins-in-react-native.htm
> l&data=01%7c01%7cpanarasi%40microsoft.com%7cbdf9c2cbdda2413cd7cf08d2d6
> 4f52e3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=o8FvbtyzEPPwMjQNfY
> bn%2b9tsgr5ykw2Tim18ecjxArs%3d Repo - 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgithub
> .com%2faxemclion%2freact-native-cordova-plugin&data=01%7c01%7cpanarasi
> %40microsoft.com%7cbdf9c2cbdda2413cd7cf08d2d64f52e3%7c72f988bf86f141af
> 91ab2d7cd011db47%7c1&sdata=f43AvMa5bWgYJAS%2fIZy5hWxcSeqBIr4XIZHU77DPx
> jc%3d NPM - 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwww.n
> pmjs.com%2fpackage%2freact-native-cordova-plugin&data=01%7c01%7cpanara
> si%40microsoft.com%7cbdf9c2cbdda2413cd7cf08d2d64f52e3%7c72f988bf86f141
> af91ab2d7cd011db47%7c1&sdata=F7EcGKZ%2bERdS4wZDEAP83Rbiar9uB%2bMPSFQTO
> 1JEkAM%3d
>
>


Re: [DISCUSS] CI and testing

2015-10-18 Thread Steven Gill
Forgot to mention that Masa would look into the jenkins build system his
company is using and give advice on our move to jenkins.


On Sun, Oct 18, 2015 at 8:11 PM, Steven Gill  wrote:

> At the Cordova F2F[1], we discussed updates to our CI system.
>
> Dimitry will be leading an effort to move our CI from buildbot to jenkins.
> Buildbot has been unstable and struggles to handle the testing load we need
> it to. You can view Dimitry's slides at [2].
>
> Dimitry and I will also be reviewing cordova-plugin-test-framework and
> seeing if we can simplify testing for plugin authors.
>
> Finally, we also discussed using Appium [3] to do some UI testing. Dimitry
> and I will look into this and make recommendations if needed.
>
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2]
> https://slack-files.com/files-pri-safe/T068CHLV6-F0CJ2MGMP/slides-whole.pdf?c=1445032318-eec787706e9e1f5f692e1a7b3e82fc0f984cb4af
> [3] http://appium.io/
>


[DISCUSS] CI and testing

2015-10-18 Thread Steven Gill
At the Cordova F2F[1], we discussed updates to our CI system.

Dimitry will be leading an effort to move our CI from buildbot to jenkins.
Buildbot has been unstable and struggles to handle the testing load we need
it to. You can view Dimitry's slides at [2].

Dimitry and I will also be reviewing cordova-plugin-test-framework and
seeing if we can simplify testing for plugin authors.

Finally, we also discussed using Appium [3] to do some UI testing. Dimitry
and I will look into this and make recommendations if needed.

[1]
https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
[2]
https://slack-files.com/files-pri-safe/T068CHLV6-F0CJ2MGMP/slides-whole.pdf?c=1445032318-eec787706e9e1f5f692e1a7b3e82fc0f984cb4af
[3] http://appium.io/


[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-10-18 Thread nikhilkh
Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-test-framework/pull/14#issuecomment-149079635
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[DISCUSS] CPR end of life

2015-10-18 Thread Steven Gill
At the Cordova F2F[1], we discussed keeping CPR online for a little while
longer as it is still fairly active. The next version of cordova-cli will
auto convert oldIDs to newIDs and that should lower the activity on the
server.

Carlos and I are looking into finding different hosting for the CPR. We
will let you know how it goes.

We also have a backup plan to put up a server which handles converting +
redirecting to npm. This is going to be quite a bit of work to implement so
we are hoping to find alternative hosting.

[1]
https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing


RE: Merging smores branch into Cordova-Android TODAY

2015-10-18 Thread Nikhil Khandelwal
Thanks Joe! 

Most of the changes look good. I did leave a comment on the design of the 
CordovaPlugin base class - I don’t want to block progress on that. Feel free to 
merge it - but let's see if we can rationalize why we are adding the base class 
methods - it seems only for the Geoloc plugin - but I don’t know enough about 
this area to understand this fully.

I would love to see the guidance for what changes a plugin developer should 
make to work in Marshmallow - Perhaps even giving them a link to our commit to 
fix one of the plugins.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Friday, October 16, 2015 2:33 PM
To: dev 
Subject: Re: Merging smores branch into Cordova-Android TODAY

I guess that I'm going to have to write the blog post for this release, 
including how permissions work on Android.

On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N 
wrote:

> As discussed in the Cordova Face to Face yesterday, we said that we 
> want our users to be aware of changes like these that will hit them. 
> Is someone looking at writing a blog post for this ?
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Friday, October 16, 2015 10:35 AM
> To: dev 
> Subject: Merging smores branch into Cordova-Android TODAY
>
> Hey
>
> I'm going to be merging the smores branch into master by 3:00 PM today.
> I've left this pull request open for the past week, so we should be 
> ready to go.  Please let me know if there's any reason I shouldn't 
> merge this in.  Once this is merged, there will be a discuss thread 
> for Cordova-Android 5.0.0.
>
> If you have a Nexus device, please update it to Marshmallow and start 
> testing Cordova applications and filing those issues in our JIRA.  If 
> there's third party plugins, please let me know, and I will look at 
> them and see if there's any major issues with that plugin being 
> upgraded and will try to contact the author.
>
> If we can be a bit more pro-active with this one to try and avoid 
> breakage (there shouldn't be much breakage, since most plugins don't 
> ask for more permissions), that would be awesome.
>
> Thanks
>
> Joe
>


[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...

2015-10-18 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/223#discussion_r42330756
  
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean 
onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
  */
 public void onConfigurationChanged(Configuration newConfig) {
 }
+
+/**
+ * Called by the Plugin Manager when we need to actually request 
permissions
+ *
+ * @param requestCode   Passed to the activity to track the request
+ *
+ * @return  Returns the permission that was stored in the 
plugin
+ */
+
+public void requestPermissions(int requestCode) {
--- End diff --

The design feels a bit hacky - designed around how geolocation plugin has 
to do this. In fact, your changes for camera plugin for Masrhmallow don't 
override this method and the `hasPermission` method. What's the guidance to a 
cordova plugin should they care to override this or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: Merging smores branch into Cordova-Android TODAY

2015-10-18 Thread Nikhil Khandelwal
I think there are two aspects of the CI. I think Dmitry is handling the 
BuildBOT CI update to support android-23.

Travis CI need android 23 which is causing Joe's change to fail in PR state: 
https://travis-ci.org/apache/cordova-android/builds/83964922

Joe you need to update Travis, as part of your change. In the file, 
https://github.com/apache/cordova-android/blob/master/.travis.yml replace 
android-22 with android-23.

Thanks,
Nikhil



-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Friday, October 16, 2015 2:41 PM
To: dev 
Subject: Re: Merging smores branch into Cordova-Android TODAY

OK, I'll push this monday.

On Fri, Oct 16, 2015 at 2:37 PM, Dmitry Blotsky 
wrote:

> I’m installing 23 on the CI right now. Should be done, conservatively, 
> in
> 2 hours.
>
> > On Oct 16, 2015, at 1:38 PM, Joe Bowser  wrote:
> >
> > OK, I locally did the rebase.  How soon can we get the CI to have
> > android-23 installed so that Travis no longer fails?
> >
> > On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N 
> > 
> > wrote:
> >
> >> As discussed in the Cordova Face to Face yesterday, we said that we 
> >> want our users to be aware of changes like these that will hit 
> >> them. Is
> someone
> >> looking at writing a blog post for this ?
> >>
> >> -Original Message-
> >> From: Joe Bowser [mailto:bows...@gmail.com]
> >> Sent: Friday, October 16, 2015 10:35 AM
> >> To: dev 
> >> Subject: Merging smores branch into Cordova-Android TODAY
> >>
> >> Hey
> >>
> >> I'm going to be merging the smores branch into master by 3:00 PM today.
> >> I've left this pull request open for the past week, so we should be
> ready
> >> to go.  Please let me know if there's any reason I shouldn't merge 
> >> this in.  Once this is merged, there will be a discuss thread for 
> >> Cordova-Android 5.0.0.
> >>
> >> If you have a Nexus device, please update it to Marshmallow and 
> >> start testing Cordova applications and filing those issues in our 
> >> JIRA.  If there's third party plugins, please let me know, and I 
> >> will look at them and see if there's any major issues with that 
> >> plugin being upgraded and will try to contact the author.
> >>
> >> If we can be a bit more pro-active with this one to try and avoid
> breakage
> >> (there shouldn't be much breakage, since most plugins don't ask for 
> >> more permissions), that would be awesome.
> >>
> >> Thanks
> >>
> >> Joe
> >>
>
>


[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-10-18 Thread dpolivy
Github user dpolivy commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149044779
  
@jcesarmobile Is this a quirk just because it's only implemented on iOS, 
Android, and WP?

@infil00p Actually, it is consistent on Android, and has nothing to do with 
whether the device has a library icon on their Camera activity (I'm not sure 
that any do?). We're simply showing an Intent Chooser that lets the user choose 
which Activity they want to launch, and the list includes all of the camera and 
file activities found on their device. That is consistent across all Android 
devices. And it's using the exact same intents that would be used if you chose 
to show the camera or library. Give it a try and see the behavior for yourself.

I still think this feature is valuable and provides a better user 
experience in certain circumstances. We've had success using this in our app, 
and being a good citizen I've tried to make it available for others to take 
advantage of. There are some native limitations here, but if you truly wanted a 
consistent camera experience and UI across all platforms, you'd basically have 
to write to the raw camera APIs on each platform which is a significant 
departure from the current approach of this plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-10-18 Thread infil00p
Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149027648
  
-1 to this as well.  This wouldn't be consistent on Android, since we're 
using Intents to launch a camera, and it's possible some devices wouldn't have 
the library icon on their Camera activity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-10-18 Thread jcesarmobile
Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149005887
  
-1 to adding new quirks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org