[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42779175
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ - 
(void)connectionDidFinishLoading:(NSURLConnection*)connection
 
 if (self.direction == CDV_TRANSFER_UPLOAD) {
 uploadResponse = [[NSString alloc] initWithData:self.responseData 
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData: 
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --

Yes, `NSISOLatin1StringEncoding` seems to be supported on JS side after 
this conversion - the string comes with correct characters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Android 5.0.x

[Simon MacDonald]

Yes please, let's get to voting. Let's get Marshmallow support out to
all our users.
Simon Mac Donald
http://hi.im/simonmacdonald


On Thu, Oct 22, 2015 at 1:38 PM, Joe Bowser  wrote:
> BUMP! I'd like to start the vote thread on Monday!
>
> On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser  wrote:
>
>> Hey
>>
>> I would like to release Cordova-Android 5.0.x soon so that I can then move
>> on to releasing each of the plugins that depend on it so we can get ready
>> to release a CLI version by the end of the year.  Is there anything that's
>> currently blocking us from doing this other than minor class name changes?
>>
>> Is there any reason we shouldn't start the release process once we change
>> the name of CordovaWebView to CordovaWebInterface?  Respond in this thread.
>>
>> Thanks
>>
>> Joe
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150307876
  
Created an issue for this here: CB-9847
Moving forward with `isVirtual`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Discuss] Cordova-common release

[Vladimir Kotikov (Akvelon)]

So if there is no -1, I'm going to start VOTE thread tomorrow.

-
Best regards, Vladimir 

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Thursday, October 22, 2015 2:09 PM
To: dev@cordova.apache.org
Subject: RE: [Discuss] Cordova-common release

> From what I understand, it's release ready with no known issues. Vladimir: Is 
> that correct?
Confirm. The only one problem is missing license header for Adb.js. Added it in 
78b7ae7. Right now everything is ready for release.

-
Best regards, Vladimir

-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
Sent: Wednesday, October 21, 2015 7:31 PM
To: dev@cordova.apache.org
Subject: RE: [Discuss] Cordova-common release

It should not - it's a good change for Android 5.0. However, it does represent 
a big change and we need more testing. From what I understand, it's release 
ready with no known issues. Vladimir: Is that correct?

As for the cordova-common dependency, cordova-android will bundle it. And we 
don't have to wait for a cordova-common release to release cordova-android.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Wednesday, October 21, 2015 9:19 AM
To: dev 
Subject: Re: [Discuss] Cordova-common release

OK, how will this impact the 5.0 release of Android?

On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal 
wrote:

> It got checked in earlier this morning.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, October 20, 2015 2:34 PM
> To: dev 
> Subject: Re: [Discuss] Cordova-common release
>
> So, when did the PlatformAPI change land in Android?
>
> On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N 
> wrote:
>
> > +1 - YES please. Requiring cordoba-common for my
> > react-native-cordova-plugin adapter was a nightmare !!
> >
> >
> >
> >
> > On 10/20/15, 2:23 PM, "Nikhil Khandelwal" 
> wrote:
> >
> > >+1 to publishing cordova-common to npm.
> > >
> > >-Nikhil
> > >
> > >-Original Message-
> > >From: Steven Gill [mailto:stevengil...@gmail.com]
> > >Sent: Tuesday, October 20, 2015 2:20 PM
> > >To: dev@cordova.apache.org
> > >Subject: Re: [Discuss] Cordova-common release
> > >
> > >I want to revisit this.
> > >
> > >So cordova-android has a dependency now on cordova-common. It is a
> > bundledDependency so when we generate a tar to release 
> > cordova-android, it will be included. It will also be in the 
> > cordova-android package that gets downloaded with cordova platform add.
> > >
> > >This is fine for released work, but more annoying for development. 
> > >I need
> > to npm link cordova-common into cordova-android (and soon every 
> > platform which implements common platformAPI). We could check in 
> > cordova-common into cordova-android but that isn't a great solution
> either.
> > >
> > >I agree that we should be going towards smaller modules and not 
> > >having a
> > case of cordovaLib1, cordovaLib2, etc. I think this is still going 
> > to be a work in progress and will take some time.
> > >
> > >For the interim, I recommend we publish cordova-common. Of course,
> > continue to add it as a bundledDependency so users don't need to npm 
> > install it with released packages.
> > >
> > >On Wed, Sep 30, 2015 at 7:24 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> > >
> > >> > I still do not understand what are you trying to solve by 
> > >> > having all
> > >> that content published as big blob.
> > >> Code deduplication is the main reason. All the things from 
> > >> 'cordova-common' will be used by platforms intensively, so we 
> > >> need to share this code and keep it separately from LIB to share easily.
> > >> Publishing is basically doesn't required for this, and bundling 
> > >> 'cordova-common' into LIB is enough for this purpose.
> > >>
> > >> Another reason was that third-party tool might want to use some 
> > >> of this functionality (like your example with ConfigParser), so 
> > >> we need to have this package on NPM to allow them to get it. For 
> > >> this case I now do agree with you that separate packages for 
> > >> ConfigParser, PluginInfo and other stuff looks better than 
> > >> putting it into one big
> > package.
> > >>
> > >> -
> > >> Best regards, Vladimir
> > >>
> > >>
> > >> -Original Message-
> > >> From: Carlos Santana [mailto:csantan...@gmail.com]
> > >> Sent: Wednesday, September 30, 2015 2:07 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: [Discuss] Cordova-common release
> > >>
> > >> Yes temporary, maybe we can discuss some more in F2F
> > >>
> > >> I still do not understand what are you trying to solve by having 
> > >> all that content published as big blob.
> > >>
> > >> If the packages are only for Cordova components to depend on then 
> > >> we control the release and we can 

Re: [Discuss] Cordova-common release

[Steven Gill]

DO IT!

On Thu, Oct 22, 2015 at 11:44 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> So if there is no -1, I'm going to start VOTE thread tomorrow.
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> Sent: Thursday, October 22, 2015 2:09 PM
> To: dev@cordova.apache.org
> Subject: RE: [Discuss] Cordova-common release
>
> > From what I understand, it's release ready with no known issues.
> Vladimir: Is that correct?
> Confirm. The only one problem is missing license header for Adb.js. Added
> it in 78b7ae7. Right now everything is ready for release.
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> Sent: Wednesday, October 21, 2015 7:31 PM
> To: dev@cordova.apache.org
> Subject: RE: [Discuss] Cordova-common release
>
> It should not - it's a good change for Android 5.0. However, it does
> represent a big change and we need more testing. From what I understand,
> it's release ready with no known issues. Vladimir: Is that correct?
>
> As for the cordova-common dependency, cordova-android will bundle it. And
> we don't have to wait for a cordova-common release to release
> cordova-android.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Wednesday, October 21, 2015 9:19 AM
> To: dev 
> Subject: Re: [Discuss] Cordova-common release
>
> OK, how will this impact the 5.0 release of Android?
>
> On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal  >
> wrote:
>
> > It got checked in earlier this morning.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Tuesday, October 20, 2015 2:34 PM
> > To: dev 
> > Subject: Re: [Discuss] Cordova-common release
> >
> > So, when did the PlatformAPI change land in Android?
> >
> > On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N 
> > wrote:
> >
> > > +1 - YES please. Requiring cordoba-common for my
> > > react-native-cordova-plugin adapter was a nightmare !!
> > >
> > >
> > >
> > >
> > > On 10/20/15, 2:23 PM, "Nikhil Khandelwal" 
> > wrote:
> > >
> > > >+1 to publishing cordova-common to npm.
> > > >
> > > >-Nikhil
> > > >
> > > >-Original Message-
> > > >From: Steven Gill [mailto:stevengil...@gmail.com]
> > > >Sent: Tuesday, October 20, 2015 2:20 PM
> > > >To: dev@cordova.apache.org
> > > >Subject: Re: [Discuss] Cordova-common release
> > > >
> > > >I want to revisit this.
> > > >
> > > >So cordova-android has a dependency now on cordova-common. It is a
> > > bundledDependency so when we generate a tar to release
> > > cordova-android, it will be included. It will also be in the
> > > cordova-android package that gets downloaded with cordova platform add.
> > > >
> > > >This is fine for released work, but more annoying for development.
> > > >I need
> > > to npm link cordova-common into cordova-android (and soon every
> > > platform which implements common platformAPI). We could check in
> > > cordova-common into cordova-android but that isn't a great solution
> > either.
> > > >
> > > >I agree that we should be going towards smaller modules and not
> > > >having a
> > > case of cordovaLib1, cordovaLib2, etc. I think this is still going
> > > to be a work in progress and will take some time.
> > > >
> > > >For the interim, I recommend we publish cordova-common. Of course,
> > > continue to add it as a bundledDependency so users don't need to npm
> > > install it with released packages.
> > > >
> > > >On Wed, Sep 30, 2015 at 7:24 AM, Vladimir Kotikov (Akvelon) <
> > > v-vlk...@microsoft.com> wrote:
> > > >
> > > >> > I still do not understand what are you trying to solve by
> > > >> > having all
> > > >> that content published as big blob.
> > > >> Code deduplication is the main reason. All the things from
> > > >> 'cordova-common' will be used by platforms intensively, so we
> > > >> need to share this code and keep it separately from LIB to share
> easily.
> > > >> Publishing is basically doesn't required for this, and bundling
> > > >> 'cordova-common' into LIB is enough for this purpose.
> > > >>
> > > >> Another reason was that third-party tool might want to use some
> > > >> of this functionality (like your example with ConfigParser), so
> > > >> we need to have this package on NPM to allow them to get it. For
> > > >> this case I now do agree with you that separate packages for
> > > >> ConfigParser, PluginInfo and other stuff looks better than
> > > >> putting it into one big
> > > package.
> > > >>
> > > >> -
> > > >> Best regards, Vladimir
> > > >>
> > > >>
> > > >> -Original Message-
> > > >> From: Carlos Santana [mailto:csantan...@gmail.com]
> > > >> Sent: Wednesday, September 30, 2015 2:07 PM
> > > >> To: dev@cordova.apache.org
> > > >> Subject: Re: [Discuss] 

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42778180
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ - 
(void)connectionDidFinishLoading:(NSURLConnection*)connection
 
 if (self.direction == CDV_TRANSFER_UPLOAD) {
 uploadResponse = [[NSString alloc] initWithData:self.responseData 
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData: 
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --

Is the code below able to marshal the string with Latin1 encoding to JS or 
do we really need to convert to UTF8 here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Android 5.0.x

[Joe Bowser]

BUMP! I'd like to start the vote thread on Monday!

On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser  wrote:

> Hey
>
> I would like to release Cordova-Android 5.0.x soon so that I can then move
> on to releasing each of the plugins that depend on it so we can get ready
> to release a CLI version by the end of the year.  Is there anything that's
> currently blocking us from doing this other than minor class name changes?
>
> Is there any reason we shouldn't start the release process once we change
> the name of CordovaWebView to CordovaWebInterface?  Respond in this thread.
>
> Thanks
>
> Joe
>

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

[Simon MacDonald]

Let's just be clear that in Cordova Android 5.0 nothing will break.
The interface CordovaWebView has been renamed to CordovaWebInterface
but that won't break anything as we introduce a new class called, wait
for it, CordovaWebView that extends the new CordovaWebInterface. This
way all current code that uses CordovaWebView will continue to work
without modification.

If we start updating our documentation, i.e. how to write a
CordovaPlugin for Android, and give people plenty of notice that this
is going to happen then I don't see why we wouldn't want to move
forward.

That's just my 2 cents.

Simon Mac Donald
http://hi.im/simonmacdonald


On Wed, Oct 21, 2015 at 6:13 PM, Nikhil Khandelwal
 wrote:
> Thanks, Joe for the summary of the impact later.
>
> -1. IMO - a naming change is no worth the effort and future breakage.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Wednesday, October 21, 2015 11:06 AM
> To: dev 
> Subject: Re: [Android][Discuss] Change name of CordovaWebView to 
> CordovaWebInterface
>
> Yes, I do.  I had to search through mobilespec, but here it is:
>
> private static final boolean HAS_BUILT_IN_SPLASH_SCREEN =
> Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4;
>
> Also, every plugin that calls initialize requires a CordovaWebView passed 
> into it.  That's a pretty big change.  I also haven't touched on Third Party 
> WebViews like Crosswalk, which would have to do the change.
>
>
> On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill  wrote:
>
>> Joe, do you have a small example of what could break with this change.
>> What is a usecase for someone to reference CordovaWebView
>>
>> On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser  wrote:
>>
>> > I'll pull this in at the end of the day.  This small change may
>> > break
>> stuff
>> > further down the road, so people should comment on it now.
>> >
>> > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser  wrote:
>> >
>> > > OK, Going to pull this in.
>> > >
>> > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
>> > > simon.macdon...@gmail.com> wrote:
>> > >
>> > >> +1 from me as I'm the one that initiated the PR.
>> > >>
>> > >> Simon Mac Donald
>> > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fh
>> > >> i.im%2fsimonmacdonald=01%7c01%7cnikhilkh%40microsoft.com%7c8
>> > >> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db4
>> > >> 7%7c1=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d
>> > >>
>> > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue 
>> > wrote:
>> > >>
>> > >> > +1 for doing this with the major version bump
>> > >> >
>> > >> > On 20 October 2015 at 09:15, Joe Bowser  wrote:
>> > >> >
>> > >> > > Hey
>> > >> > >
>> > >> > > We're close to getting 5.0.x ready for release, but I want to
>> > >> > > add
>> > one
>> > >> > more
>> > >> > > pull request:
>> > >> > >
>> > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2
>> > >> > > f%2fgithub.com%2fapache%2fcordova-android%2fpull%2f227=0
>> > >> > > 1%7c01%7cnikhilkh%40microsoft.com%7c8619031b1eef484bd48508d2d
>> > >> > > a425e41%7c72f988bf86f141af91ab2d7cd011db47%7c1=w5TYcbCH
>> > >> > > %2fhLIhbrZImOsVFgGMfp%2bIk0Dl6Qk6ADzMVc%3d
>> > >> > >
>> > >> > > This is a trivial pull request, but I want to get buy-in from
>> > >> > > the
>> > list
>> > >> > for
>> > >> > > doing the rename for CordovaWebView class to be changed
>> > >> > > before we
>> > >> start
>> > >> > > deprecating it.  This means we're probably going to remove
>> > >> > > the
>> shim
>> > in
>> > >> > the
>> > >> > > next major version.
>> > >> > >
>> > >> > > Thoughts?
>> > >> > >
>> > >> > > Joe
>> > >> > >
>> > >> >
>> > >>
>> > >
>> > >
>> >
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova-Android 5.0.x

[Vladimir Kotikov (Akvelon)]

+1 

FYI, there is a finishing stroke - [ab72e48] CB-9782 Check in cordova-common 
dependency [1] which is needed for scenario when user installs platform from 
git. 
I also went through release steps and didn't found any issues.

---
[1] 
https://git1-us-west.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ab72e484311470baab43838e6b55bbba953279d6

-
Best regards, Vladimir

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Thursday, October 22, 2015 10:10 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android 5.0.x

+1

On Thu, Oct 22, 2015 at 12:09 PM, Simon MacDonald  wrote:

> Yes please, let's get to voting. Let's get Marshmallow support out to 
> all our users.
> Simon Mac Donald
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> 2fsimonmacdonald=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7ce8
> 2b09c23b72420766a308d2db14795d%7c72f988bf86f141af91ab2d7cd011db47%7c1&
> sdata=E3SrGSCv3OBPBXrPpPsP4PvmNY3BVCgzlCRZzFuv3Bo%3d
>
>
> On Thu, Oct 22, 2015 at 1:38 PM, Joe Bowser  wrote:
> > BUMP! I'd like to start the vote thread on Monday!
> >
> > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser  wrote:
> >
> >> Hey
> >>
> >> I would like to release Cordova-Android 5.0.x soon so that I can 
> >> then
> move
> >> on to releasing each of the plugins that depend on it so we can get
> ready
> >> to release a CLI version by the end of the year.  Is there anything
> that's
> >> currently blocking us from doing this other than minor class name
> changes?
> >>
> >> Is there any reason we shouldn't start the release process once we
> change
> >> the name of CordovaWebView to CordovaWebInterface?  Respond in this
> thread.
> >>
> >> Thanks
> >>
> >> Joe
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42778351
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ - 
(void)connectionDidFinishLoading:(NSURLConnection*)connection
 
 if (self.direction == CDV_TRANSFER_UPLOAD) {
 uploadResponse = [[NSString alloc] initWithData:self.responseData 
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData: 
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --

We ideally want to be cross-platform here and add this support on all main 
platforms - at least downloadresponse should also support this feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Android 5.0.x

[Steven Gill]

+1

On Thu, Oct 22, 2015 at 12:09 PM, Simon MacDonald  wrote:

> Yes please, let's get to voting. Let's get Marshmallow support out to
> all our users.
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Thu, Oct 22, 2015 at 1:38 PM, Joe Bowser  wrote:
> > BUMP! I'd like to start the vote thread on Monday!
> >
> > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser  wrote:
> >
> >> Hey
> >>
> >> I would like to release Cordova-Android 5.0.x soon so that I can then
> move
> >> on to releasing each of the plugins that depend on it so we can get
> ready
> >> to release a CLI version by the end of the year.  Is there anything
> that's
> >> currently blocking us from doing this other than minor class name
> changes?
> >>
> >> Is there any reason we shouldn't start the release process once we
> change
> >> the name of CordovaWebView to CordovaWebInterface?  Respond in this
> thread.
> >>
> >> Thanks
> >>
> >> Joe
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-file-transfer pull request: CB-9843 Added wp8 quirk...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/105

CB-9843 Added wp8 quirk to test spec 12

https://issues.apache.org/jira/browse/CB-9843

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-9843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105


commit d6b480c95e2665e1aaa5fa5b01c4cb31958b3f68
Author: Alexander Sorokin 
Date:   2015-10-22T10:14:03Z

CB-9843 Added wp8 quirk to test spec 12




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-9843 Added wp8 quirk...

[alsorokin]

Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/105


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-9843 Added wp8 quirk...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/106#discussion_r42734873
  
--- Diff: src/wp/FileTransfer.cs ---
@@ -775,11 +775,8 @@ private void downloadCallback(IAsyncResult 
asynchronousResult)
 }
 catch (WebException webex)
 {
-// TODO: probably need better work here to properly 
respond with all http status codes back to JS
-// Right now am jumping through hoops just to detect 404.
 HttpWebResponse response = (HttpWebResponse)webex.Response;
-if ((webex.Status == WebExceptionStatus.ProtocolError && 
response.StatusCode == HttpStatusCode.NotFound)
-|| webex.Status == WebExceptionStatus.UnknownError)
+if ((webex.Status == WebExceptionStatus.ProtocolError) || 
(webex.Status == WebExceptionStatus.UnknownError))
--- End diff --

Please remove excess brackets.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

[EddyVerbruggen]

Github user EddyVerbruggen commented on the pull request:

https://github.com/apache/cordova-ios/pull/164#issuecomment-150191011
  
BTW I am seeing it on 9.1. iPhone 6S, longpress and 3D Touch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-9843 Added wp8 quirk...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/106

CB-9843 Added wp8 quirk to test spec 15

https://issues.apache.org/jira/browse/CB-9843

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-9843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit b1f034f01b6ab02b6514084ae4c90c7f66b7fd00
Author: Alexander Sorokin 
Date:   2015-10-22T10:49:55Z

CB-9843 Added wp8 quirk to test spec 15




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Discuss] Cordova-common release

[Vladimir Kotikov (Akvelon)]

> From what I understand, it's release ready with no known issues. Vladimir: Is 
> that correct?
Confirm. The only one problem is missing license header for Adb.js. Added it in 
78b7ae7. Right now everything is ready for release.

-
Best regards, Vladimir

-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] 
Sent: Wednesday, October 21, 2015 7:31 PM
To: dev@cordova.apache.org
Subject: RE: [Discuss] Cordova-common release

It should not - it's a good change for Android 5.0. However, it does represent 
a big change and we need more testing. From what I understand, it's release 
ready with no known issues. Vladimir: Is that correct?

As for the cordova-common dependency, cordova-android will bundle it. And we 
don't have to wait for a cordova-common release to release cordova-android.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Wednesday, October 21, 2015 9:19 AM
To: dev 
Subject: Re: [Discuss] Cordova-common release

OK, how will this impact the 5.0 release of Android?

On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal 
wrote:

> It got checked in earlier this morning.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, October 20, 2015 2:34 PM
> To: dev 
> Subject: Re: [Discuss] Cordova-common release
>
> So, when did the PlatformAPI change land in Android?
>
> On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N 
> wrote:
>
> > +1 - YES please. Requiring cordoba-common for my
> > react-native-cordova-plugin adapter was a nightmare !!
> >
> >
> >
> >
> > On 10/20/15, 2:23 PM, "Nikhil Khandelwal" 
> wrote:
> >
> > >+1 to publishing cordova-common to npm.
> > >
> > >-Nikhil
> > >
> > >-Original Message-
> > >From: Steven Gill [mailto:stevengil...@gmail.com]
> > >Sent: Tuesday, October 20, 2015 2:20 PM
> > >To: dev@cordova.apache.org
> > >Subject: Re: [Discuss] Cordova-common release
> > >
> > >I want to revisit this.
> > >
> > >So cordova-android has a dependency now on cordova-common. It is a
> > bundledDependency so when we generate a tar to release 
> > cordova-android, it will be included. It will also be in the 
> > cordova-android package that gets downloaded with cordova platform add.
> > >
> > >This is fine for released work, but more annoying for development. 
> > >I need
> > to npm link cordova-common into cordova-android (and soon every 
> > platform which implements common platformAPI). We could check in 
> > cordova-common into cordova-android but that isn't a great solution
> either.
> > >
> > >I agree that we should be going towards smaller modules and not 
> > >having a
> > case of cordovaLib1, cordovaLib2, etc. I think this is still going 
> > to be a work in progress and will take some time.
> > >
> > >For the interim, I recommend we publish cordova-common. Of course,
> > continue to add it as a bundledDependency so users don't need to npm 
> > install it with released packages.
> > >
> > >On Wed, Sep 30, 2015 at 7:24 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> > >
> > >> > I still do not understand what are you trying to solve by 
> > >> > having all
> > >> that content published as big blob.
> > >> Code deduplication is the main reason. All the things from 
> > >> 'cordova-common' will be used by platforms intensively, so we 
> > >> need to share this code and keep it separately from LIB to share easily.
> > >> Publishing is basically doesn't required for this, and bundling 
> > >> 'cordova-common' into LIB is enough for this purpose.
> > >>
> > >> Another reason was that third-party tool might want to use some 
> > >> of this functionality (like your example with ConfigParser), so 
> > >> we need to have this package on NPM to allow them to get it. For 
> > >> this case I now do agree with you that separate packages for 
> > >> ConfigParser, PluginInfo and other stuff looks better than 
> > >> putting it into one big
> > package.
> > >>
> > >> -
> > >> Best regards, Vladimir
> > >>
> > >>
> > >> -Original Message-
> > >> From: Carlos Santana [mailto:csantan...@gmail.com]
> > >> Sent: Wednesday, September 30, 2015 2:07 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: [Discuss] Cordova-common release
> > >>
> > >> Yes temporary, maybe we can discuss some more in F2F
> > >>
> > >> I still do not understand what are you trying to solve by having 
> > >> all that content published as big blob.
> > >>
> > >> If the packages are only for Cordova components to depend on then 
> > >> we control the release and we can include them easily.
> > >>
> > >> If the code is to be share by third party or anyone out there 
> > >> then it make sense to put in npm.
> > >>
> > >> One concrete example is cordova-configparser, Our IBM tool is 
> > >> using it in our own models code so today we taking a copy, if 
> > >> it's 

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

[zhangjianying]

Github user zhangjianying commented on the pull request:

https://github.com/apache/cordova-ios/pull/164#issuecomment-150184839
  
good idea. thinks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

[julio cesar sanchez]

Ok, forget about the -webkit-user-select: none; part, you might put that on
the body but use -webkit-user-select: text; on input type text and textarea.

2015-10-22 13:03 GMT+02:00 julio cesar sanchez :

> +1 for preference
>
> but I think the problem the plugin solves only appears when you add the
> css to avoid text selection (-webkit-user-select: none;), so if the user
> wants text selection he won't add that css and he doesn't need the plugin.
>
> BTW, I'm not able to reproduce the magnifier glass issue on iOS 9.1, maybe
> apple fixed it?
>
>
> 2015-10-22 12:18 GMT+02:00 EddyVerbruggen :
>
>> Github user EddyVerbruggen commented on the pull request:
>>
>> https://github.com/apache/cordova-ios/pull/164#issuecomment-150170110
>>
>> I think I'll be adding a configuration for this to config.xml as not
>> all folks may like this feature (new PR).
>>
>> The plugin that inspired this PR has been around for a few weeks now:
>> https://github.com/EddyVerbruggen/cordova-plugin-ios-longpress-fix and
>> while most like it, it may break text selection. If your app needs that
>> this feature will cause trouble.
>>
>> I propose enabling this private plugin only when a certain config.xml
>> property has been enabled.
>>
>> And I'd also like to add a feature to suppress the magnifying glass
>> for devices with 3D Touch support. In the plugin mentioned above I've
>> already done so, by specifying a preference: `> name="Suppress3DTouch" value="true" />`.
>>
>> Any thoughts others want to share perhaps?
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:

https://github.com/apache/cordova-ios/pull/164#issuecomment-150188723
  
+1 for preference

BTW, I'm not able to reproduce the magnifier glass issue on iOS 9.1, maybe 
apple fixed it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

[julio cesar sanchez]

+1 for preference

but I think the problem the plugin solves only appears when you add the css
to avoid text selection (-webkit-user-select: none;), so if the user wants
text selection he won't add that css and he doesn't need the plugin.

BTW, I'm not able to reproduce the magnifier glass issue on iOS 9.1, maybe
apple fixed it?

2015-10-22 12:18 GMT+02:00 EddyVerbruggen :

> Github user EddyVerbruggen commented on the pull request:
>
> https://github.com/apache/cordova-ios/pull/164#issuecomment-150170110
>
> I think I'll be adding a configuration for this to config.xml as not
> all folks may like this feature (new PR).
>
> The plugin that inspired this PR has been around for a few weeks now:
> https://github.com/EddyVerbruggen/cordova-plugin-ios-longpress-fix and
> while most like it, it may break text selection. If your app needs that
> this feature will cause trouble.
>
> I propose enabling this private plugin only when a certain config.xml
> property has been enabled.
>
> And I'd also like to add a feature to suppress the magnifying glass
> for devices with 3D Touch support. In the plugin mentioned above I've
> already done so, by specifying a preference: ` name="Suppress3DTouch" value="true" />`.
>
> Any thoughts others want to share perhaps?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[DISCUSS] Removing Tizen From Support Matrix

[Dmitry Blotsky]

Hey folks,

A few weeks back I heard someone mention that we should strike Tizen from this 
matrix: http://cordova.apache.org/docs/en/5.1.1/guide/support/index.html. 
Should I proceed with that? Should we be removing Tizen entirely from our docs?

Kindly,
Dmitry

Re: [DISCUSS] Removing Tizen From Support Matrix

[Dmitry Blotsky]

Shall I remove all parts of the docs that pertain to Tizen, or just the Tizen 
column from the support matrix for now?

> On Oct 22, 2015, at 2:00 PM, Steven Gill  wrote:
> 
> I'm pretty sure it was me who said that. It isn't released on npm and
> doesn't work with our current tooling. Remove it
> 
> On Thu, Oct 22, 2015 at 1:39 PM, Dmitry Blotsky 
> wrote:
> 
>> Hey folks,
>> 
>> A few weeks back I heard someone mention that we should strike Tizen from
>> this matrix:
>> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcordova.apache.org%2fdocs%2fen%2f5.1.1%2fguide%2fsupport%2findex.html.=01%7c01%7cdblotsky%40microsoft.com%7c7b97b82a79c34e2fc00a08d2db23f0f5%7c72f988bf86f141af91ab2d7cd011db47%7c1=AXqF96UrQzFIVOcB3gKCmqz1bY0r52HCamOeinoVNNY%3d
>>  Should
>> I proceed with that? Should we be removing Tizen entirely from our docs?
>> 
>> Kindly,
>> Dmitry
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Removing Tizen From Support Matrix

[Steven Gill]

from master and future versions, sure. From old versions, no. That way
users can go back and find them if necessary.

On Thu, Oct 22, 2015 at 2:11 PM, Dmitry Blotsky 
wrote:

> Shall I remove all parts of the docs that pertain to Tizen, or just the
> Tizen column from the support matrix for now?
>
> > On Oct 22, 2015, at 2:00 PM, Steven Gill  wrote:
> >
> > I'm pretty sure it was me who said that. It isn't released on npm and
> > doesn't work with our current tooling. Remove it
> >
> > On Thu, Oct 22, 2015 at 1:39 PM, Dmitry Blotsky 
> > wrote:
> >
> >> Hey folks,
> >>
> >> A few weeks back I heard someone mention that we should strike Tizen
> from
> >> this matrix:
> >>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcordova.apache.org%2fdocs%2fen%2f5.1.1%2fguide%2fsupport%2findex.html.=01%7c01%7cdblotsky%40microsoft.com%7c7b97b82a79c34e2fc00a08d2db23f0f5%7c72f988bf86f141af91ab2d7cd011db47%7c1=AXqF96UrQzFIVOcB3gKCmqz1bY0r52HCamOeinoVNNY%3d
> Should
> >> I proceed with that? Should we be removing Tizen entirely from our docs?
> >>
> >> Kindly,
> >> Dmitry
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-device pull request: add JIRA issue tracker link

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

npm install on cordova platform/plugin add

[Steven Gill]

We discussed running `npm install` on `cordova plugin add` at the Cordova
F2F.

I want to see how people feel about this.

For installing a platform via git url, the dependency won't exist unless we
check it in to the repo. This can cause problems. bundleDependencies are
only useful for installing via npm

For platforms:

i believe this is how it would work:

Adding via `npm`

1) `cordova platform add ios`

2) cordova fetches `cordova-ios` from npm, adds it to global cordova
directory

3) I'd like tools to run `npm install` , but these deps are most likely
already included in fetched version due to `bundleDependecies`. So it
wouldn't do anything

Adding locally

1) `cordova platform add /YourLocalCordovaIOS`

2) cordova uses your `cordova-ios`

3) tools to run `npm install` which should have no impact (Assuming you've
done it manually)

Adding via Git url

1) `cordova platform add https://github.com/apache/cordova-ios`

2) cordova clones it (i believe into global cordova directory)

3) tools to run `npm install` which is important because packages aren't
bundled unless we manually check them in

For Plugins
It would allow plugins to have 3rd party npm dependencies and not have to
check them in. This will be even more important once we switch to
browserify method.

Thoughts?

[GitHub] cordova-plugin-device pull request: CB 9847 Cannot tell when runni...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: CB 9847 Cannot tell when runni...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/40

CB 9847 Cannot tell when running on Simulator

added isVirtual boolean property

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-plugin-device CB-9847

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 50abd1a7c39ca628d7c63689aa9f93f04ca7ddaf
Author: Andy Chen 
Date:   2015-04-10T06:55:25Z

add isSimulator for iOS & Android device

commit 2bd41cfaa80941fc4baaf7e4162538722f389feb
Author: Jesse MacFadyen 
Date:   2015-10-22T18:03:11Z

Merge branch 'feature/add_isSimulator_to_iOS_and_android' of 
https://github.com/AndyChenW/cordova-plugin-device into CB-9847

commit 2aebeae3d1a15dd110fc6f92a4bd2526c7ed9a4c
Author: Jesse MacFadyen 
Date:   2015-10-22T18:17:20Z

create test to verify existence and type of new property 'isVirtual'

commit 60787409adbcf3b94794060a265fc5e0e7f0bf47
Author: Jesse MacFadyen 
Date:   2015-10-22T18:29:13Z

update code to use 'isVirtual'

commit 853d23799259fdfefe520dad1f44d0812e9ecc20
Author: Jesse MacFadyen 
Date:   2015-10-22T18:30:27Z

update to use TARGET_OS_SIMULATOR as TARGET_IPHONE_SIMULATOR is deprecated.

commit 2fc875cb0577f90f03554b56fc6609c669efb63e
Author: Jesse MacFadyen 
Date:   2015-10-22T18:56:30Z

WP8 implementation

commit 7f9827d2f0fccbf5cb5228cc12e5abe9afdb52a2
Author: Jesse MacFadyen 
Date:   2015-10-22T22:12:28Z

Cleanup wp8 code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Removing Tizen From Support Matrix

[Steven Gill]

I'm pretty sure it was me who said that. It isn't released on npm and
doesn't work with our current tooling. Remove it

On Thu, Oct 22, 2015 at 1:39 PM, Dmitry Blotsky 
wrote:

> Hey folks,
>
> A few weeks back I heard someone mention that we should strike Tizen from
> this matrix:
> http://cordova.apache.org/docs/en/5.1.1/guide/support/index.html. Should
> I proceed with that? Should we be removing Tizen entirely from our docs?
>
> Kindly,
> Dmitry
>

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/328#issuecomment-150371632
  
This functionality is moving to the platforms themselves. For this fix to 
work in android@5.0+, you should look to add it to 
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/prepare.js#L156


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: npm install on cordova platform/plugin add

[Darryl Pogue]

One example would be the ios-sim and ios-deploy node modules that the iOS
platform needs for launching the simulator and deploying to a device.
Currently these are bundled dependencies and checked in to git.

Another example is the Platform API that's been added to cordova-android,
which depends on cordova-common.

On 22 October 2015 at 16:17, Mefire O.  wrote:

> I can definitely see the case for adding deps specified in plugins'
> package.json, which is to make 'tools plugins' development easier.
>
> But I don't understand the use case for platforms. What scenario are we
> trying to fulfill there ?
>
> Thanks,
> Omar Mefire
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, October 22, 2015 2:54 PM
> To: dev@cordova.apache.org
> Subject: npm install on cordova platform/plugin add
>
> We discussed running `npm install` on `cordova plugin add` at the Cordova
> F2F.
>
> I want to see how people feel about this.
>
> For installing a platform via git url, the dependency won't exist unless
> we check it in to the repo. This can cause problems. bundleDependencies are
> only useful for installing via npm
>
> For platforms:
>
> i believe this is how it would work:
>
> Adding via `npm`
>
> 1) `cordova platform add ios`
>
> 2) cordova fetches `cordova-ios` from npm, adds it to global cordova
> directory
>
> 3) I'd like tools to run `npm install` , but these deps are most likely
> already included in fetched version due to `bundleDependecies`. So it
> wouldn't do anything
>
> Adding locally
>
> 1) `cordova platform add /YourLocalCordovaIOS`
>
> 2) cordova uses your `cordova-ios`
>
> 3) tools to run `npm install` which should have no impact (Assuming you've
> done it manually)
>
> Adding via Git url
>
> 1) `cordova platform add
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-ios%60=01%7c01%7commenjik%40microsoft.com%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db47%7c1=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d
>
> 2) cordova clones it (i believe into global cordova directory)
>
> 3) tools to run `npm install` which is important because packages aren't
> bundled unless we manually check them in
>
> For Plugins
> It would allow plugins to have 3rd party npm dependencies and not have to
> check them in. This will be even more important once we switch to
> browserify method.
>
> Thoughts?
>

Re: [Android] Merging Camera Pull Request for Marshmallow Compatibility

[Joe Bowser]

Hey

I merged the changes into the camera.  That said, I didn't bump the version
up on this yet.

On Wed, Oct 21, 2015 at 3:07 PM, Joe Bowser  wrote:

> Hey
>
> Now that we merged in the compatibility for Android 5.0 I want to do the
> same for the Camera plugin.  This will also allow us to do a bunch of other
> work that we're currently waiting on this pull request for.  Is there any
> reason I shouldn't pull the current changes into master?   If not, I'm
> going to merge the pull request in at around noon.
>
> Thanks
>
> Joe
>

Re: npm install on cordova platform/plugin add

[Steven Gill]

Yeah. Cordova-common is the main reason for platforms. IMO It doesn't make
sense to check it into platforms. It makes sense to have it as a
bundleDependency but if you cordova platform add it via git url, the
dependency won't be around. Hence the npm install
On Oct 22, 2015 4:24 PM, "Darryl Pogue"  wrote:

> One example would be the ios-sim and ios-deploy node modules that the iOS
> platform needs for launching the simulator and deploying to a device.
> Currently these are bundled dependencies and checked in to git.
>
> Another example is the Platform API that's been added to cordova-android,
> which depends on cordova-common.
>
> On 22 October 2015 at 16:17, Mefire O.  wrote:
>
> > I can definitely see the case for adding deps specified in plugins'
> > package.json, which is to make 'tools plugins' development easier.
> >
> > But I don't understand the use case for platforms. What scenario are we
> > trying to fulfill there ?
> >
> > Thanks,
> > Omar Mefire
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Thursday, October 22, 2015 2:54 PM
> > To: dev@cordova.apache.org
> > Subject: npm install on cordova platform/plugin add
> >
> > We discussed running `npm install` on `cordova plugin add` at the Cordova
> > F2F.
> >
> > I want to see how people feel about this.
> >
> > For installing a platform via git url, the dependency won't exist unless
> > we check it in to the repo. This can cause problems. bundleDependencies
> are
> > only useful for installing via npm
> >
> > For platforms:
> >
> > i believe this is how it would work:
> >
> > Adding via `npm`
> >
> > 1) `cordova platform add ios`
> >
> > 2) cordova fetches `cordova-ios` from npm, adds it to global cordova
> > directory
> >
> > 3) I'd like tools to run `npm install` , but these deps are most likely
> > already included in fetched version due to `bundleDependecies`. So it
> > wouldn't do anything
> >
> > Adding locally
> >
> > 1) `cordova platform add /YourLocalCordovaIOS`
> >
> > 2) cordova uses your `cordova-ios`
> >
> > 3) tools to run `npm install` which should have no impact (Assuming
> you've
> > done it manually)
> >
> > Adding via Git url
> >
> > 1) `cordova platform add
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-ios%60=01%7c01%7commenjik%40microsoft.com%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db47%7c1=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d
> >
> > 2) cordova clones it (i believe into global cordova directory)
> >
> > 3) tools to run `npm install` which is important because packages aren't
> > bundled unless we manually check them in
> >
> > For Plugins
> > It would allow plugins to have 3rd party npm dependencies and not have to
> > check them in. This will be even more important once we switch to
> > browserify method.
> >
> > Thoughts?
> >
>

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/384


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing the survey banner

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/398


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: [CB-9773] Switching versions goes to th...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/399


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: npm install on cordova platform/plugin add

[Mefire O .]

I can definitely see the case for adding deps specified in plugins' 
package.json, which is to make 'tools plugins' development easier.

But I don't understand the use case for platforms. What scenario are we trying 
to fulfill there ?

Thanks,
Omar Mefire

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Thursday, October 22, 2015 2:54 PM
To: dev@cordova.apache.org
Subject: npm install on cordova platform/plugin add

We discussed running `npm install` on `cordova plugin add` at the Cordova F2F.

I want to see how people feel about this.

For installing a platform via git url, the dependency won't exist unless we 
check it in to the repo. This can cause problems. bundleDependencies are only 
useful for installing via npm

For platforms:

i believe this is how it would work:

Adding via `npm`

1) `cordova platform add ios`

2) cordova fetches `cordova-ios` from npm, adds it to global cordova directory

3) I'd like tools to run `npm install` , but these deps are most likely already 
included in fetched version due to `bundleDependecies`. So it wouldn't do 
anything

Adding locally

1) `cordova platform add /YourLocalCordovaIOS`

2) cordova uses your `cordova-ios`

3) tools to run `npm install` which should have no impact (Assuming you've done 
it manually)

Adding via Git url

1) `cordova platform add 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-ios%60=01%7c01%7commenjik%40microsoft.com%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db47%7c1=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d

2) cordova clones it (i believe into global cordova directory)

3) tools to run `npm install` which is important because packages aren't 
bundled unless we manually check them in

For Plugins
It would allow plugins to have 3rd party npm dependencies and not have to check 
them in. This will be even more important once we switch to browserify method.

Thoughts?

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

[gorkem]

Github user gorkem commented on the pull request:

https://github.com/apache/cordova-lib/pull/328#issuecomment-150394486
  
@stevengill Yes, created CB-9844 to follow up. This one is still valid for 
fixing older android engines though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: [CB-9773] Switching versions goes to th...

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/399

[CB-9773] Switching versions goes to the same page, not to root



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-9773

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #399


commit c49c6fea714717f6aa2853948860763f593e8579
Author: Dmitry Blotsky 
Date:   2015-10-23T00:38:34Z

Making version-switching go to the same page.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-test-framework/pull/15

CB-8973: Changed the functionality of making the log appear and disap…

…pear

Applies the UI fix for wp8 platform

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework 
CB-8973-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-test-framework/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit c95392c8bca7af2abe032762a4a7fa0c88654dbe
Author: daserge 
Date:   2015-10-22T08:58:50Z

CB-8973: Changed the functionality of making the log appear and disappear

Applies the UI fix for wp8 platform




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

[EddyVerbruggen]

Github user EddyVerbruggen commented on the pull request:

https://github.com/apache/cordova-ios/pull/164#issuecomment-150170110
  
I think I'll be adding a configuration for this to config.xml as not all 
folks may like this feature (new PR).

The plugin that inspired this PR has been around for a few weeks now: 
https://github.com/EddyVerbruggen/cordova-plugin-ios-longpress-fix and while 
most like it, it may break text selection. If your app needs that this feature 
will cause trouble.

I propose enabling this private plugin only when a certain config.xml 
property has been enabled.

And I'd also like to add a feature to suppress the magnifying glass for 
devices with 3D Touch support. In the plugin mentioned above I've already done 
so, by specifying a preference: ``.

Any thoughts others want to share perhaps?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/328


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-9519 Fix the engine destruction b...

[DILEEP-YADAV]

Github user DILEEP-YADAV commented on the pull request:

https://github.com/apache/cordova-android/pull/208#issuecomment-150468569
  
ok



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed example referencing non-e...

[iepathos]

GitHub user iepathos opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/73

Fixed example referencing non-existent variable

Fixed example referencing non-existent variable media, fixed to use 
my_media variable.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/iepathos/cordova-plugin-media patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit 7140d88dc047b407d631b879fbf4a9233d94253f
Author: Glen Baker 
Date:   2015-10-23T04:14:40Z

Fixed example referencing non-existent variable

Fixed example referencing non-existent variable media, fixed to use 
my_media variable.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information pull request: add JIRA issue tr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-network-information/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information pull request: Fix checks that a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-network-information/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/328#issuecomment-150461925
  
Definitely. Thanks!

On Thu, Oct 22, 2015 at 5:27 PM, Gorkem Ercan 
wrote:

> @stevengill  Yes, created CB-9844 to
> follow up. This one is still valid for fixing older android engines 
though.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/71#issuecomment-150281147
  
Started a discussion on the dev list:
http://callback.markmail.org/thread/aeteluc3l7rtdb2x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

[Joe Bowser]

This would be done over at least one major version, and we've done way
worse name changes back when we were in Incubator. (i.e. PhoneGap to
Cordova).  I'm just wondering what the threshold for doing a breaking
change is.

On Wed, Oct 21, 2015 at 3:13 PM, Nikhil Khandelwal 
wrote:

> Thanks, Joe for the summary of the impact later.
>
> -1. IMO - a naming change is no worth the effort and future breakage.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Wednesday, October 21, 2015 11:06 AM
> To: dev 
> Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> CordovaWebInterface
>
> Yes, I do.  I had to search through mobilespec, but here it is:
>
> private static final boolean HAS_BUILT_IN_SPLASH_SCREEN =
> Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4;
>
> Also, every plugin that calls initialize requires a CordovaWebView passed
> into it.  That's a pretty big change.  I also haven't touched on Third
> Party WebViews like Crosswalk, which would have to do the change.
>
>
> On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill 
> wrote:
>
> > Joe, do you have a small example of what could break with this change.
> > What is a usecase for someone to reference CordovaWebView
> >
> > On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser  wrote:
> >
> > > I'll pull this in at the end of the day.  This small change may
> > > break
> > stuff
> > > further down the road, so people should comment on it now.
> > >
> > > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser  wrote:
> > >
> > > > OK, Going to pull this in.
> > > >
> > > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
> > > > simon.macdon...@gmail.com> wrote:
> > > >
> > > >> +1 from me as I'm the one that initiated the PR.
> > > >>
> > > >> Simon Mac Donald
> > > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fh
> > > >> i.im%2fsimonmacdonald=01%7c01%7cnikhilkh%40microsoft.com%7c8
> > > >> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db4
> > > >> 7%7c1=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d
> > > >>
> > > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue 
> > > wrote:
> > > >>
> > > >> > +1 for doing this with the major version bump
> > > >> >
> > > >> > On 20 October 2015 at 09:15, Joe Bowser 
> wrote:
> > > >> >
> > > >> > > Hey
> > > >> > >
> > > >> > > We're close to getting 5.0.x ready for release, but I want to
> > > >> > > add
> > > one
> > > >> > more
> > > >> > > pull request:
> > > >> > >
> > > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2
> > > >> > > f%2fgithub.com%2fapache%2fcordova-android%2fpull%2f227=0
> > > >> > > 1%7c01%7cnikhilkh%40microsoft.com%7c8619031b1eef484bd48508d2d
> > > >> > > a425e41%7c72f988bf86f141af91ab2d7cd011db47%7c1=w5TYcbCH
> > > >> > > %2fhLIhbrZImOsVFgGMfp%2bIk0Dl6Qk6ADzMVc%3d
> > > >> > >
> > > >> > > This is a trivial pull request, but I want to get buy-in from
> > > >> > > the
> > > list
> > > >> > for
> > > >> > > doing the rename for CordovaWebView class to be changed
> > > >> > > before we
> > > >> start
> > > >> > > deprecating it.  This means we're probably going to remove
> > > >> > > the
> > shim
> > > in
> > > >> > the
> > > >> > > next major version.
> > > >> > >
> > > >> > > Thoughts?
> > > >> > >
> > > >> > > Joe
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>