[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

2016-01-18 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-172761068
  
@tfitschen, thanks for your contribution!
This has been included into #74, could you please close the PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

2016-01-18 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/66#issuecomment-172760818
  
@neo-clon, thanks for your contribution!
This has been included into #74, could you please close the PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

2016-01-18 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-172760723
  
@njleonzhang, thanks for your contribution!
This has been included into #74, could you please close the PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Plugins Release

2016-01-18 Thread Steven Gill
Please review the plugins release blog post.
https://github.com/apache/cordova-docs/pull/458

Also, need one more vote for the release.

On Thu, Jan 14, 2016 at 10:24 AM, Steven Gill 
wrote:

> Going to start a plugins release soon. Any blockers? Any high priority
> outstanding PRs you want us to look at before this release?
>
>
>


[GitHub] cordova-docs pull request: added plugins release blog post

2016-01-18 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-docs/pull/458

added plugins release blog post

Please review!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/458.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #458


commit 28f20c63220d9952e453f612e6f57fdf7d947c9a
Author: Steve Gill 
Date:   2016-01-19T06:53:29Z

added plugins release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Unified Cordova Fetch Proposal

2016-01-18 Thread Steven Gill
I wrote up a proposal for unifying our fetching mechanisms and splitting it
into a cordova-fetch module.

Let me know what you think.

https://github.com/cordova/cordova-discuss/pull/33


[GitHub] cordova-plugin-splashscreen pull request: Add support for UILaunch...

2016-01-18 Thread IndieSW
Github user IndieSW commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/17#issuecomment-172707811
  
It's been almost two years since I submitted this so I doubt it's still 
useful.

-Terence


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: Try to use realpath filename i...

2016-01-18 Thread FuzzyTree
Github user FuzzyTree commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-172693987
  
Has anyone tested this patch? Applying the changes to CameraLauncher.java 
results in failed `getPicture` calls. Unfortunately the only error is "Error 
retrieving image", so I'm not sure where it breaks.

I also tried building from the nightlies and get the same error. When I 
revert `ouputModifiedBitmap` in the nightlies the error goes away.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-18 Thread Joe Bowser
I don't think the gradle build issue should block the release, as annoying
as it is, the workaround is literally adding a gradle.properties file with
a single line.

As far as who owns it, I think Cordova should probably own that, but are
there any other plugins that need NDK support?

(I just ran into this less than an hour ago. It's annoying that Google
deprecates something without something else to replace it.)

On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue  wrote:

> With cordova-android master, the Crosswalk Webview plugin fails to build
> because gradle was updated and now NDK support has been removed.
>
> It can be re-enabled by providing a gradle.properties file, but I'm not
> sure whether that should be the responsibility of Cordova-Android or the
> Crosswalk Webview plugin.
>
> On 18 January 2016 at 15:12, Steven Gill  wrote:
>
> > Going to start this today. Let me know if you have any concerns.
> >
> > -Steve
> >
>


Re: [DISCUSS] Android@5.1.0

2016-01-18 Thread Darryl Pogue
With cordova-android master, the Crosswalk Webview plugin fails to build
because gradle was updated and now NDK support has been removed.

It can be re-enabled by providing a gradle.properties file, but I'm not
sure whether that should be the responsibility of Cordova-Android or the
Crosswalk Webview plugin.

On 18 January 2016 at 15:12, Steven Gill  wrote:

> Going to start this today. Let me know if you have any concerns.
>
> -Steve
>


[DISCUSS] Android@5.1.0

2016-01-18 Thread Steven Gill
Going to start this today. Let me know if you have any concerns.

-Steve


[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-18 Thread purplecabbage
Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/140#issuecomment-172676250
  
Thanks! And your change of  to  has made this issue make 
infinitely more sense!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-18 Thread bso-intel
Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-windows/pull/140#issuecomment-172675243
  
Hi @purplecabbage,

Here is how you can reproduce the issue:
1. cordova platform add windows
2. cordova plugin add cordova-sqlite-storage
3. cordova plugin rm cordova-sqlite-storage

{code}
[CB-10381] cordova plugin add cordova-sqlite-storage
Fetching plugin "cordova-sqlite-storage" via npm
Installing "cordova-sqlite-storage" for windows
[CB-10381] cordova plugin rm cordova-sqlite-storage
Uninstalling cordova-sqlite-storage from windows
Error: Uh oh!
EISDIR, illegal operation on a directory
{code}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-18 Thread purplecabbage
Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/140#issuecomment-172667998
  
Thanks for the fix!
Can you please provide a failing test that now passes, or at least a 
specific list of repro steps?
I am unclear on what exactly it means to include a tag in a plugin ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-18 Thread bso-intel
Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-windows/pull/140#issuecomment-172667498
  
Hi @vladimir-kotikov 
Could you review this pull request?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-18 Thread bso-intel
GitHub user bso-intel opened a pull request:

https://github.com/apache/cordova-windows/pull/140

CB-10381 fix the bug when removing a plugin with a  tag

I fixed a simple bug that caused an exception EISDIR when removing a plugin 
that includes a  tag.
PluginHandler.js should have passed the project file instead of the plugin 
directory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bso-intel/cordova-windows CB-10381

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit d5079b99bdb0ab5fe7d75ed13853de762e0cf254
Author: Byoungro So 
Date:   2016-01-18T22:02:40Z

CB-10381 fix the bug when removing a plugin with a  tag




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[ANNOUNCE] Windows 4.3.0 release

2016-01-18 Thread Steven Gill
Blog:
http://cordova.apache.org/announcements/2016/01/18/cordova-windows-4.3.0.html
Tweet: https://twitter.com/apachecordova/status/689195357712953345


RE: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-18 Thread Sergey Grebnov (Akvelon)
Thank you Steve!

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Monday, January 18, 2016 10:07 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release

I'll take care of publishing the blog and announcing. Thanks Sergey and 
Vladimir!

On Mon, Jan 18, 2016 at 7:37 AM, Sergey Grebnov (Akvelon) < 
v-seg...@microsoft.com> wrote:

> I've published cordova-windows@4.3.0 on npm and has merged release 
> blogpost [1]. Could someone help me w/ Announce[2] and blogpost 
> release steps please.
>
> [1] https://github.com/apache/cordova-docs/pull/453
> [2]
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-rele
> ase-process.md#announce-it
>
> -Sergey
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Friday, January 15, 2016 12:49 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release
>
> Vladimir get well soon.
> Sergey thanks for taking over +1
>
>
> On Thu, Jan 14, 2016 at 10:15 AM Sergey Grebnov (Akvelon) < 
> v-seg...@microsoft.com> wrote:
>
> > Cherry-picked the following two fixes and started new vote (attempt 
> > 3), release notes and blogpost are not affected as those issues have 
> > been recently introduced/fixed and don't affect previous versions.
> >
> >   * CB-10344 Fixed icons and splashscreens parsing
> >   * CB-10356 "npm install" fails for cordova-windows
> >
> > -Sergey
> > -Original Message-
> > From: Sergey Grebnov (Akvelon)
> > Sent: Thursday, January 14, 2016 9:20 AM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Cordova-windows 4.3.0 release
> >
> > Vladimir is on sick leave, I will take a look on this as high 
> > priority thing today and restart the vote
> >
> > -Sergey
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Thursday, January 14, 2016 1:46 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release
> >
> > Hi Vlad,
> >
> > There is something weird going on with the semver bundled, appveyor 
> > [1] is claiming that the build is failing since the addition of 
> > semver, and the same thing happened for me when I ran : `npm i` If 
> > however, I ran : `npm i semver` first, it works again.
> > I think it is probably a permission/executable issue on the bundled 
> > files you checked in ... not sure.
> >
> > [1]
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.
> > ap
> > pveyor.com%2fproject%2fHumbedooh%2fcordova-windows%2fhistory&data=01
> > %7
> > c01%7cv-segreb%40microsoft.com%7c57a2661f05734f44c14508d31c6b6857%7c
> > 72 
> > f988bf86f141af91ab2d7cd011db47%7c1&sdata=wdwTZ39DoyUMGJrMdbvU4A3Aaul
> > Gk
> > 0XAZS7LUOunZ2c%3d
> >
> >
> >
> > @purplecabbage
> >
> > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=
> > 01 
> > %7c01%7cv-segreb%40microsoft.com%7c57a2661f05734f44c14508d31c6b6857%
> > 7c 
> > 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2bJ%2fyXn0qDVI2YERJRkoC8
> > kV
> > gEzr28Z4VJ9QmO9cbjp4%3d
> >
> > On Tue, Jan 12, 2016 at 12:49 PM, Vladimir Kotikov (Akvelon) < 
> > v-vlk...@microsoft.com> wrote:
> >
> > > As the first attempt has failed, I fixed the fail reason (one of 
> > > dependencies was not added to bundledDependencies and hence was 
> > > missing in resultant package), retagged the release branch and 
> > > uploaded a new release candidates to dist/dev. Going to restart a vote.
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > > Sent: Tuesday, January 5, 2016 4:18 PM
> > > To: dev@cordova.apache.org
> > > Subject: [DISCUSS] Cordova-windows 4.3.0 release
> > >
> > > Hi all,
> > >
> > > I plan to do a minor cordova-windows release (bump to 4.3.0) to 
> > > release PlatformApi and unified logging feature in the next couple 
> > > of
> > days.
> > > Please leave your comments and notes.
> > >
> > > Release issue:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
> > > ss
> > > ue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10299&data=01%7c01%7cv-vlkoti%40
> > > 06
> > > 4d
> > > .mgd.microsoft.com%7c82326e83f9f94fb6cc1e08d315d2a2da%7c72f988bf86
> > > f1
> > > 41
> > > af91ab2d7cd011db47%7c1&sdata=wtlvNPG9BcKPjg3P8uh84uG1d%2bAa33TPuxy
> > > 2Q
> > > Kp
> > > 8XLg%3d
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > --
> > > --
> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


Re: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-18 Thread Steven Gill
I'll take care of publishing the blog and announcing. Thanks Sergey and
Vladimir!

On Mon, Jan 18, 2016 at 7:37 AM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> I've published cordova-windows@4.3.0 on npm and has merged release
> blogpost [1]. Could someone help me w/ Announce[2] and blogpost release
> steps please.
>
> [1] https://github.com/apache/cordova-docs/pull/453
> [2]
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#announce-it
>
> -Sergey
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Friday, January 15, 2016 12:49 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release
>
> Vladimir get well soon.
> Sergey thanks for taking over +1
>
>
> On Thu, Jan 14, 2016 at 10:15 AM Sergey Grebnov (Akvelon) <
> v-seg...@microsoft.com> wrote:
>
> > Cherry-picked the following two fixes and started new vote (attempt
> > 3), release notes and blogpost are not affected as those issues have
> > been recently introduced/fixed and don't affect previous versions.
> >
> >   * CB-10344 Fixed icons and splashscreens parsing
> >   * CB-10356 "npm install" fails for cordova-windows
> >
> > -Sergey
> > -Original Message-
> > From: Sergey Grebnov (Akvelon)
> > Sent: Thursday, January 14, 2016 9:20 AM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Cordova-windows 4.3.0 release
> >
> > Vladimir is on sick leave, I will take a look on this as high priority
> > thing today and restart the vote
> >
> > -Sergey
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Thursday, January 14, 2016 1:46 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release
> >
> > Hi Vlad,
> >
> > There is something weird going on with the semver bundled, appveyor
> > [1] is claiming that the build is failing since the addition of
> > semver, and the same thing happened for me when I ran : `npm i` If
> > however, I ran : `npm i semver` first, it works again.
> > I think it is probably a permission/executable issue on the bundled
> > files you checked in ... not sure.
> >
> > [1]
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.ap
> > pveyor.com%2fproject%2fHumbedooh%2fcordova-windows%2fhistory&data=01%7
> > c01%7cv-segreb%40microsoft.com%7c57a2661f05734f44c14508d31c6b6857%7c72
> > f988bf86f141af91ab2d7cd011db47%7c1&sdata=wdwTZ39DoyUMGJrMdbvU4A3AaulGk
> > 0XAZS7LUOunZ2c%3d
> >
> >
> >
> > @purplecabbage
> >
> > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01
> > %7c01%7cv-segreb%40microsoft.com%7c57a2661f05734f44c14508d31c6b6857%7c
> > 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2bJ%2fyXn0qDVI2YERJRkoC8kV
> > gEzr28Z4VJ9QmO9cbjp4%3d
> >
> > On Tue, Jan 12, 2016 at 12:49 PM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > As the first attempt has failed, I fixed the fail reason (one of
> > > dependencies was not added to bundledDependencies and hence was
> > > missing in resultant package), retagged the release branch and
> > > uploaded a new release candidates to dist/dev. Going to restart a vote.
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > > Sent: Tuesday, January 5, 2016 4:18 PM
> > > To: dev@cordova.apache.org
> > > Subject: [DISCUSS] Cordova-windows 4.3.0 release
> > >
> > > Hi all,
> > >
> > > I plan to do a minor cordova-windows release (bump to 4.3.0) to
> > > release PlatformApi and unified logging feature in the next couple
> > > of
> > days.
> > > Please leave your comments and notes.
> > >
> > > Release issue:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > > ue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10299&data=01%7c01%7cv-vlkoti%4006
> > > 4d
> > > .mgd.microsoft.com%7c82326e83f9f94fb6cc1e08d315d2a2da%7c72f988bf86f1
> > > 41
> > > af91ab2d7cd011db47%7c1&sdata=wtlvNPG9BcKPjg3P8uh84uG1d%2bAa33TPuxy2Q
> > > Kp
> > > 8XLg%3d
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > 
> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>


[GitHub] cordova-plugin-statusbar pull request: Fix for CB-10102

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/45


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



CB-9516 Android SplashScreen - Spinner Does Not Display

2016-01-18 Thread Sergey Shakhnazarov (Akvelon)
Hi guys,

What is the history of SplashScreen plugin spinnerDialog implementation on 
Android [1]?
Is there a specific reason it is cancellable (so that it can be dismissed on 
tap)?

I wanted to discuss the PR CB-9516 Android SplashScreen - Spinner Does Not 
Display #75 [2] - it fixes the bug and adds an option to display the spinner 
via the custom dialog without screen dim and on transparent background, which 
is consistent with ios implementation.

Do we need the old implementation at all, which shows the default 
ProgressDialog with title and message and dims the splashimage?
Are LoadingDialog [3] and LoadingPageDialog still used in the apps - would not 
they clash with the splashscreen plugin?

Screenshots: old way ProgressDialog with title and message [4], spinner-only 
variant [5].

[1]: 
https://github.com/apache/cordova-plugin-splashscreen/blob/7a12204ba9c49d8b23cf67634e2d69890944274a/src/android/SplashScreen.java#L338
[2]: https://github.com/apache/cordova-plugin-splashscreen/pull/75/files
[3]: 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/config.html
[4]: 
https://cloud.githubusercontent.com/assets/4272078/12397546/f4bf2a1c-be1e-11e5-8e45-91a794072d62.png
[5]: 
https://cloud.githubusercontent.com/assets/4272078/12397547/f4c3f844-be1e-11e5-95c4-e9324523b481.png

Please let me know if you have any questions or considerations.

Best regards,
Sergey Shakhnazarov.



[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...

2016-01-18 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/75#issuecomment-172594119
  
Title and message mode:

![device-2016-01-18-195856](https://cloud.githubusercontent.com/assets/4272078/12397546/f4bf2a1c-be1e-11e5-8e45-91a794072d62.png)

Spinner-only mode:

![device-2016-01-18-200106](https://cloud.githubusercontent.com/assets/4272078/12397547/f4c3f844-be1e-11e5-95c4-e9324523b481.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [VOTE] Plugins Release! Jan 15, 2016

2016-01-18 Thread Alexander Sorokin (Akvelon)
I vote +1.

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Ran smoke testing of mobilespec app
* Verified release notes

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Saturday, January 16, 2016 4:24 AM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release! Jan 15, 2016

Please review and vote on the release of this plugins release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10368&data=01%7c01%7cv-alsoro%40microsoft.com%7c9853fe889c8f49e85fa808d31e13bc16%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KMtqzQjV%2boqHORO2cKiG0hS0Ioh9Rm%2bNjkiXDILLEOI%3d

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10368/

The packages were published from their corresponding git tags:
cordova-plugin-camera: 2.1.0 (0f32b78c82)
cordova-plugin-contacts: 2.0.1 (e9bbdd299c)
cordova-plugin-device: 1.1.1 (d42fb80ca1)
cordova-plugin-file: 4.1.0 (a4aa9158c3)
cordova-plugin-file-transfer: 1.5.0 (3540af439e)
cordova-plugin-geolocation: 2.1.0 (43ceab3a92)
cordova-plugin-inappbrowser: 1.2.0 (c3ccb694d3)
cordova-plugin-media: 2.1.0 (871bf29a4a)
cordova-plugin-media-capture: 1.2.0 (1ede87258b)
cordova-plugin-network-information: 1.2.0 (b0375e549b)
cordova-plugin-splashscreen: 3.1.0 (0f4a9d3f18)
cordova-plugin-statusbar: 2.1.0 (e6e8c5be10)
cordova-plugin-test-framework: 1.1.1 (c431d1270b)
cordova-plugin-vibration: 2.1.0 (e613e2e318)
cordova-plugin-whitelist: 1.2.1 (c33ea30cf2)

Upon a successful vote I will upload the archives to dist/, upload them to npm, 
post the corresponding blog post, and create apache release tags based on these 
release tags.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Built mobile-spec and ran on android 6.0.1


RE: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-18 Thread Sergey Grebnov (Akvelon)
I've published cordova-windows@4.3.0 on npm and has merged release blogpost 
[1]. Could someone help me w/ Announce[2] and blogpost release steps please.

[1] https://github.com/apache/cordova-docs/pull/453
[2] 
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#announce-it
 

-Sergey
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Friday, January 15, 2016 12:49 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release

Vladimir get well soon.
Sergey thanks for taking over +1


On Thu, Jan 14, 2016 at 10:15 AM Sergey Grebnov (Akvelon) < 
v-seg...@microsoft.com> wrote:

> Cherry-picked the following two fixes and started new vote (attempt 
> 3), release notes and blogpost are not affected as those issues have 
> been recently introduced/fixed and don't affect previous versions.
>
>   * CB-10344 Fixed icons and splashscreens parsing
>   * CB-10356 "npm install" fails for cordova-windows
>
> -Sergey
> -Original Message-
> From: Sergey Grebnov (Akvelon)
> Sent: Thursday, January 14, 2016 9:20 AM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Cordova-windows 4.3.0 release
>
> Vladimir is on sick leave, I will take a look on this as high priority 
> thing today and restart the vote
>
> -Sergey
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Thursday, January 14, 2016 1:46 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-windows 4.3.0 release
>
> Hi Vlad,
>
> There is something weird going on with the semver bundled, appveyor 
> [1] is claiming that the build is failing since the addition of 
> semver, and the same thing happened for me when I ran : `npm i` If 
> however, I ran : `npm i semver` first, it works again.
> I think it is probably a permission/executable issue on the bundled 
> files you checked in ... not sure.
>
> [1]
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.ap
> pveyor.com%2fproject%2fHumbedooh%2fcordova-windows%2fhistory&data=01%7
> c01%7cv-segreb%40microsoft.com%7c57a2661f05734f44c14508d31c6b6857%7c72
> f988bf86f141af91ab2d7cd011db47%7c1&sdata=wdwTZ39DoyUMGJrMdbvU4A3AaulGk
> 0XAZS7LUOunZ2c%3d
>
>
>
> @purplecabbage
>
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01
> %7c01%7cv-segreb%40microsoft.com%7c57a2661f05734f44c14508d31c6b6857%7c
> 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2bJ%2fyXn0qDVI2YERJRkoC8kV
> gEzr28Z4VJ9QmO9cbjp4%3d
>
> On Tue, Jan 12, 2016 at 12:49 PM, Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > As the first attempt has failed, I fixed the fail reason (one of 
> > dependencies was not added to bundledDependencies and hence was 
> > missing in resultant package), retagged the release branch and 
> > uploaded a new release candidates to dist/dev. Going to restart a vote.
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Tuesday, January 5, 2016 4:18 PM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Cordova-windows 4.3.0 release
> >
> > Hi all,
> >
> > I plan to do a minor cordova-windows release (bump to 4.3.0) to 
> > release PlatformApi and unified logging feature in the next couple 
> > of
> days.
> > Please leave your comments and notes.
> >
> > Release issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ue 
> > s.apache.org%2fjira%2fbrowse%2fCB-10299&data=01%7c01%7cv-vlkoti%4006
> > 4d
> > .mgd.microsoft.com%7c82326e83f9f94fb6cc1e08d315d2a2da%7c72f988bf86f1
> > 41 
> > af91ab2d7cd011db47%7c1&sdata=wtlvNPG9BcKPjg3P8uh84uG1d%2bAa33TPuxy2Q
> > Kp
> > 8XLg%3d
> >
> > -
> > Best regards, Vladimir
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


[GitHub] cordova-docs pull request: Add HealthPlanet, Ohalog and Undog Apps...

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/385


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Ski patrol mobile app showcase

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/391


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10299 Adds windows@4.3.0 release blo...

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/453


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Ajout de popvox.png

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/386


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: orubase

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/389


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Add BurracoON app to showcase

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/392


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: New

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [Vote] Windwos 4.3.0 Release attempt 3

2016-01-18 Thread Sergey Grebnov (Akvelon)
The vote has now closed. The results are:

Positive Binding Votes: 3

Jesse MacFadyen
Alexander Sorokin
Sergey Grebnov

Negative Binding Votes: 0

The vote has passed.

-Sergey

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Friday, January 15, 2016 11:20 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Windwos 4.3.0 Release attempt 3

+1

* Verified archives via `coho verify-archive`
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully built and ran
* Verified 'npm i' works


@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-segreb%40microsoft.com%7c840eab13e439499d0df508d31de945b5%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=tmGakjSW%2bYZAP4A%2fhQ0TTFNJ9sf4bjxZbu%2baZAJiK8k%3d

On Fri, Jan 15, 2016 at 4:54 AM, Alexander Sorokin (Akvelon) < 
v-als...@microsoft.com> wrote:

> I vote +1.
>
> * Verified archives via `coho verify-archive`
> * Verified tags manually
> * Verified that blank app creates correctly with platform
> * Verified that blank app can be successfully built and ran
> * Verified that platform can be updated from previous version
> * Verified compatibility with core plugins (ran autotests for released 
> plugin versions)
> * Verified release notes
>
> Additional checks:
> * Verified version
> * Verified line breaks
>
> Thanks,
> Alexander Sorokin
>
> -Original Message-
> From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com]
> Sent: Thursday, January 14, 2016 6:06 PM
> To: dev@cordova.apache.org
> Subject: [Vote] Windwos 4.3.0 Release attempt 3
>
> Please review and vote on this 4.3.0 Windows Release (3nd attempt) by 
> replying to this email (and keep discussion on the DISCUSS thread)
>
>
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10299&data=01%7c01%7cv-alsoro%40micr
> osoft.com%7cb07752ea8a17434c603108d31cf447d7%7c72f988bf86f141af91ab2d7
> cd011db47%7c1&sdata=BT8VhN3oEDVgVvHVo6KCY2m4khhI%2bSY0sazpqDbFtF0%3d
>
>
>
> The archive has been published to dist/dev:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.
> apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10299%2f&data=01%7c01%7
> cv-alsoro%40microsoft.com%7cb07752ea8a17434c603108d31cf447d7%7c72f988b
> f86f141af91ab2d7cd011db47%7c1&sdata=tAn7De5vU%2bwJ0l%2bK7NnKeWKv4MVl0Y
> zNYRDFfZJAGFo%3d
>
>
>
> The package was published from its corresponding git tag:
>
> cordova-windows: 4.3.0 (9f3a3b0388)
>
>
>
> Note that you can test it out via:
>
>
>
> cordova platform add windows@
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-windows.git%234.3.0&data=01%7c01%7cv-segreb%40microsoft.com%7c840eab13e439499d0df508d31de945b5%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6jSQlY3bpZyv4d2kzEoDsOgenf5DYDKUzAn8LNyDO0w%3d windows@https://git-wip-us.apache.org/repos/asf/cordova-windows.git#4.
> 3.0>
>
>
>
> Upon a successful vote I will upload the archive to dist/, publish it 
> to npm, and post the blog post.
>
>
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
>
>
> Voting will go on for a minimum of 48 hours.
>
>
>
> I vote +1:
>
> * Reviewed package diff with 4.3.0 release attempt 2 package
>
> * Created helloworld app, added platform from release package to 
> ensure that package is valid
>
> * Ensured continuous build was green when repo was tagged
>
>
>
> -Sergey
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

2016-01-18 Thread biasmv
GitHub user biasmv opened a pull request:

https://github.com/apache/cordova-windows/pull/139

don't copy resource-files at plugin install

Instead, reference the file in the plugin directory. This allows to have 
multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g. 
architecture.

This implements a fix for CB-10326

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/biasmv/cordova-windows master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit e3425d97fd6bdd23823ba5430dca780405e803f6
Author: Marco Biasini 
Date:   2016-01-18T10:24:29Z

don't copy resource-files at plugin install

Instead, reference the file in the plugin directory. This allows to have 
multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g. 
architecture.

This implements a fix for CB-10326




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...

2016-01-18 Thread fattalgazi
GitHub user fattalgazi opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/154

Chrome , Uncaught TypeError: localStream.stop is not a function



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fattalgazi/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #154


commit e092e4fbb709925c6ac961b57a7e5f6f59550042
Author: fattalgazi 
Date:   2016-01-18T10:52:50Z

Update CameraProxy.js

localMediaStream.stop() fix

commit 5e81cdcec4b78dcc1c78537f9310cd27683847ad
Author: fattalgazi 
Date:   2016-01-18T10:56:19Z

Update CameraProxy.js

commit c17a297ad5d5b5b80b9f727aa0770ac740d4c67c
Author: fattalgazi 
Date:   2016-01-18T11:01:37Z

Update CameraProxy.js

commit 0e03410f6ef8c8eff87ceb652764e6a362fc348b
Author: fattalgazi 
Date:   2016-01-18T11:03:26Z

Update CameraProxy.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request: CB-8396 Add AutoHideSpla...

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org