[GitHub] cordova-docs pull request: Fix invalid dash sign (`Too many parame...

2016-01-19 Thread SunboX
GitHub user SunboX opened a pull request:

https://github.com/apache/cordova-docs/pull/459

Fix invalid dash sign (`Too many parameters` exception)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SunboX/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #459


commit 5a518c8c49ad8a7c63a0bf0a6c541b6aaef6a0a6
Author: André Fiedler 
Date:   2016-01-19T08:44:19Z

Fix invalid dash sign (`Too many parameters` exception)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

2016-01-19 Thread neo-clon
Github user neo-clon commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/66#issuecomment-172779405
  
Thanks,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

2016-01-19 Thread neo-clon
Github user neo-clon closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: Try to use realpath filename i...

2016-01-19 Thread nantunes
Github user nantunes commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-172819385
  
_Per se_ the patch only manipulates strings:
```java
String fileName = realPath != null ?
realPath.substring(realPath.lastIndexOf('/') + 1) :
"modified." + (this.encodingType == JPEG ? "jpg" : "png");

String modifiedPath = getTempDirectoryPath() + "/" + fileName;
```

So I don't how could it cause that error. Maybe some other change 
in-between? Could you diff the two versions of CameraLauncher.java?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Carlos Santana
What you guys think of making MIN SDK VER 15 instead of 14 as the default
for this Android@5.1.0 ?

We have a couple of plugins that required minsdk 15 [1], I also see that
phonegap push plugin have problems with min sdk 14 here [2]

Instead of anoying user with readme instructions to change it to 15, why
not make the default 15, this way more stuff would work out of the box with
less trouble.
I guess if there is someone for a particular reason wants minsdk 14, they
can change the default the same way as today using config.xml


[1]:
https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-plugin-push/blob/master/README.md
[2]:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#minsdkversion--14

On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser  wrote:

> I don't think the gradle build issue should block the release, as annoying
> as it is, the workaround is literally adding a gradle.properties file with
> a single line.
>
> As far as who owns it, I think Cordova should probably own that, but are
> there any other plugins that need NDK support?
>
> (I just ran into this less than an hour ago. It's annoying that Google
> deprecates something without something else to replace it.)
>
> On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue  wrote:
>
> > With cordova-android master, the Crosswalk Webview plugin fails to build
> > because gradle was updated and now NDK support has been removed.
> >
> > It can be re-enabled by providing a gradle.properties file, but I'm not
> > sure whether that should be the responsibility of Cordova-Android or the
> > Crosswalk Webview plugin.
> >
> > On 18 January 2016 at 15:12, Steven Gill  wrote:
> >
> > > Going to start this today. Let me know if you have any concerns.
> > >
> > > -Steve
> > >
> >
>


RE: [DISCUSS] Android@5.1.0

2016-01-19 Thread Nikhil Khandelwal
If this is a regression in behavior and CrossWalk will not work out of the box 
- we should consider fixing it. Sounds like it is a simple fix. Is there a JIRA 
for this?

Overall, we shouldn't require/expect Cordova JS developers to modify gradle 
files.

-Nikhil

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Tuesday, January 19, 2016 9:00 AM
To: dev 
Subject: Re: [DISCUSS] Android@5.1.0

What you guys think of making MIN SDK VER 15 instead of 14 as the default for 
this Android@5.1.0 ?

We have a couple of plugins that required minsdk 15 [1], I also see that 
phonegap push plugin have problems with min sdk 14 here [2]

Instead of anoying user with readme instructions to change it to 15, why not 
make the default 15, this way more stuff would work out of the box with less 
trouble.
I guess if there is someone for a particular reason wants minsdk 14, they can 
change the default the same way as today using config.xml


[1]:
https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-plugin-push/blob/master/README.md
[2]:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#minsdkversion--14

On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser  wrote:

> I don't think the gradle build issue should block the release, as 
> annoying as it is, the workaround is literally adding a 
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties&data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
>  file with a single line.
>
> As far as who owns it, I think Cordova should probably own that, but 
> are there any other plugins that need NDK support?
>
> (I just ran into this less than an hour ago. It's annoying that Google 
> deprecates something without something else to replace it.)
>
> On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue  wrote:
>
> > With cordova-android master, the Crosswalk Webview plugin fails to 
> > build because gradle was updated and now NDK support has been removed.
> >
> > It can be re-enabled by providing a 
> > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > &data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> >  file, but I'm not sure whether that should be the responsibility of 
> > Cordova-Android or the Crosswalk Webview plugin.
> >
> > On 18 January 2016 at 15:12, Steven Gill  wrote:
> >
> > > Going to start this today. Let me know if you have any concerns.
> > >
> > > -Steve
> > >
> >
>


Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Joe Bowser
I really don't want to add this file and use the deprecated NDK, especially
since we don't know if this is a plugin or platform responsibility.  I also
don't want to delay a release for people not using Crosswalk.

Do we know of any other plugins that use the NDK? If there aren't any, I'm
more agreeable to adding the file since it won't break others.


On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal 
wrote:

> If this is a regression in behavior and CrossWalk will not work out of the
> box - we should consider fixing it. Sounds like it is a simple fix. Is
> there  JIRA for this?
>
> Overall, we shouldn't require/expect Cordova JS developers to modify
> gradle files.
>
> -Nikhil
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Tuesday, January 19, 2016 9:00 AM
> To: dev 
> Subject: Re: [DISCUSS] Android@5.1.0
>
> What you guys think of making MIN SDK VER 15 instead of 14 as the default
> for this Android@5.1.0 ?
>
> We have a couple of plugins that required minsdk 15 [1], I also see that
> phonegap push plugin have problems with min sdk 14 here [2]
>
> Instead of anoying user with readme instructions to change it to 15, why
> not make the default 15, this way more stuff would work out of the box with
> less trouble.
> I guess if there is someone for a particular reason wants minsdk 14, they
> can change the default the same way as today using config.xml
>
>
> [1]:
>
> https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-plugin-push/blob/master/README.md
> [2]:
>
> https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#minsdkversion--14
>
> On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser  wrote:
>
> > I don't think the gradle build issue should block the release, as
> > annoying as it is, the workaround is literally adding a
> >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties&data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> file with a single line.
> >
> > As far as who owns it, I think Cordova should probably own that, but
> > are there any other plugins that need NDK support?
> >
> > (I just ran into this less than an hour ago. It's annoying that Google
> > deprecates something without something else to replace it.)
> >
> > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue  wrote:
> >
> > > With cordova-android master, the Crosswalk Webview plugin fails to
> > > build because gradle was updated and now NDK support has been removed.
> > >
> > > It can be re-enabled by providing a
> > > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > &data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> file, but I'm not sure whether that should be the responsibility of
> Cordova-Android or the Crosswalk Webview plugin.
> > >
> > > On 18 January 2016 at 15:12, Steven Gill 
> wrote:
> > >
> > > > Going to start this today. Let me know if you have any concerns.
> > > >
> > > > -Steve
> > > >
> > >
> >
>


[GitHub] cordova-plugin-inappbrowser pull request: add fix for iOS upload

2016-01-19 Thread birge
GitHub user birge opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/138

add fix for iOS upload



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/birge/cordova-plugin-inappbrowser 
add-ios-workaround

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #138


commit 651d3cdff3446c7fe16ab3ed866fd194c6f7fd97
Author: Birge Clark 
Date:   2016-01-19T18:31:28Z

add fix for iOS upload




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Simon MacDonald
Can't the crosswalk plugin deliver the
Gradle files via the framework tag of its plugin. Xml to fix this?

Simon
On Jan 19, 2016 13:26, "Joe Bowser"  wrote:

> I really don't want to add this file and use the deprecated NDK, especially
> since we don't know if this is a plugin or platform responsibility.  I also
> don't want to delay a release for people not using Crosswalk.
>
> Do we know of any other plugins that use the NDK? If there aren't any, I'm
> more agreeable to adding the file since it won't break others.
>
>
> On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal 
> wrote:
>
> > If this is a regression in behavior and CrossWalk will not work out of
> the
> > box - we should consider fixing it. Sounds like it is a simple fix. Is
> > there  JIRA for this?
> >
> > Overall, we shouldn't require/expect Cordova JS developers to modify
> > gradle files.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Carlos Santana [mailto:csantan...@gmail.com]
> > Sent: Tuesday, January 19, 2016 9:00 AM
> > To: dev 
> > Subject: Re: [DISCUSS] Android@5.1.0
> >
> > What you guys think of making MIN SDK VER 15 instead of 14 as the default
> > for this Android@5.1.0 ?
> >
> > We have a couple of plugins that required minsdk 15 [1], I also see that
> > phonegap push plugin have problems with min sdk 14 here [2]
> >
> > Instead of anoying user with readme instructions to change it to 15, why
> > not make the default 15, this way more stuff would work out of the box
> with
> > less trouble.
> > I guess if there is someone for a particular reason wants minsdk 14, they
> > can change the default the same way as today using config.xml
> >
> >
> > [1]:
> >
> >
> https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-plugin-push/blob/master/README.md
> > [2]:
> >
> >
> https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#minsdkversion--14
> >
> > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser  wrote:
> >
> > > I don't think the gradle build issue should block the release, as
> > > annoying as it is, the workaround is literally adding a
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties&data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > file with a single line.
> > >
> > > As far as who owns it, I think Cordova should probably own that, but
> > > are there any other plugins that need NDK support?
> > >
> > > (I just ran into this less than an hour ago. It's annoying that Google
> > > deprecates something without something else to replace it.)
> > >
> > > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue 
> wrote:
> > >
> > > > With cordova-android master, the Crosswalk Webview plugin fails to
> > > > build because gradle was updated and now NDK support has been
> removed.
> > > >
> > > > It can be re-enabled by providing a
> > > > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > > &data=01%7c01%7cnikhilkh%40microsoft.com
> %7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > file, but I'm not sure whether that should be the responsibility of
> > Cordova-Android or the Crosswalk Webview plugin.
> > > >
> > > > On 18 January 2016 at 15:12, Steven Gill 
> > wrote:
> > > >
> > > > > Going to start this today. Let me know if you have any concerns.
> > > > >
> > > > > -Steve
> > > > >
> > > >
> > >
> >
>


[GitHub] cordova-plugin-inappbrowser pull request: add fix for iOS upload

2016-01-19 Thread birge
Github user birge closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Joe Bowser
Yes, it probably can. I'm thinking that Google once again put us in
dependency hell with the new NDK functionality, which is why I'm not super
stoked about this file existing at all.

On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald 
wrote:

> Can't the crosswalk plugin deliver the
> Gradle files via the framework tag of its plugin. Xml to fix this?
>
> Simon
> On Jan 19, 2016 13:26, "Joe Bowser"  wrote:
>
> > I really don't want to add this file and use the deprecated NDK,
> especially
> > since we don't know if this is a plugin or platform responsibility.  I
> also
> > don't want to delay a release for people not using Crosswalk.
> >
> > Do we know of any other plugins that use the NDK? If there aren't any,
> I'm
> > more agreeable to adding the file since it won't break others.
> >
> >
> > On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal  >
> > wrote:
> >
> > > If this is a regression in behavior and CrossWalk will not work out of
> > the
> > > box - we should consider fixing it. Sounds like it is a simple fix. Is
> > > there  JIRA for this?
> > >
> > > Overall, we shouldn't require/expect Cordova JS developers to modify
> > > gradle files.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > Sent: Tuesday, January 19, 2016 9:00 AM
> > > To: dev 
> > > Subject: Re: [DISCUSS] Android@5.1.0
> > >
> > > What you guys think of making MIN SDK VER 15 instead of 14 as the
> default
> > > for this Android@5.1.0 ?
> > >
> > > We have a couple of plugins that required minsdk 15 [1], I also see
> that
> > > phonegap push plugin have problems with min sdk 14 here [2]
> > >
> > > Instead of anoying user with readme instructions to change it to 15,
> why
> > > not make the default 15, this way more stuff would work out of the box
> > with
> > > less trouble.
> > > I guess if there is someone for a particular reason wants minsdk 14,
> they
> > > can change the default the same way as today using config.xml
> > >
> > >
> > > [1]:
> > >
> > >
> >
> https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-plugin-push/blob/master/README.md
> > > [2]:
> > >
> > >
> >
> https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#minsdkversion--14
> > >
> > > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser  wrote:
> > >
> > > > I don't think the gradle build issue should block the release, as
> > > > annoying as it is, the workaround is literally adding a
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties&data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > > file with a single line.
> > > >
> > > > As far as who owns it, I think Cordova should probably own that, but
> > > > are there any other plugins that need NDK support?
> > > >
> > > > (I just ran into this less than an hour ago. It's annoying that
> Google
> > > > deprecates something without something else to replace it.)
> > > >
> > > > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue 
> > wrote:
> > > >
> > > > > With cordova-android master, the Crosswalk Webview plugin fails to
> > > > > build because gradle was updated and now NDK support has been
> > removed.
> > > > >
> > > > > It can be re-enabled by providing a
> > > > >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > > > &data=01%7c01%7cnikhilkh%40microsoft.com
> >
> %7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > > file, but I'm not sure whether that should be the responsibility of
> > > Cordova-Android or the Crosswalk Webview plugin.
> > > > >
> > > > > On 18 January 2016 at 15:12, Steven Gill 
> > > wrote:
> > > > >
> > > > > > Going to start this today. Let me know if you have any concerns.
> > > > > >
> > > > > > -Steve
> > > > > >
> > > > >
> > > >
> > >
> >
>


[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...

2016-01-19 Thread birge
GitHub user birge opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/139

Add fix for iOS file upload.

I'd like to start by saying I don't understand fully what the issue is or 
how this fixes the issue. I have been having an issue where my cordova app 
would fall back to the splash screen when I tried to upload a file on iOS. I 
found the solution here https://issues.apache.org/jira/browse/CB-7679 

This is before the fix

![file_upload_bug](https://cloud.githubusercontent.com/assets/1206124/12428174/04e7daa0-be98-11e5-85bb-2f58bebcad7e.gif)

and this is after

![file_upload_bug_fixed](https://cloud.githubusercontent.com/assets/1206124/12428184/0f049848-be98-11e5-81d6-ac2286210036.gif)

I am not sure why this fix wasn't already included so I am hoping it just 
because no one has taken the time to make a PR. Any issues with this?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/birge/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit 651d3cdff3446c7fe16ab3ed866fd194c6f7fd97
Author: Birge Clark 
Date:   2016-01-19T18:31:28Z

add fix for iOS upload




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Simon MacDonald
I'd say, don't delay the release for this. Send a PR to the crosswalk team
to let them know as it is ultimately their problem.

Simon
On Jan 19, 2016 13:36, "Joe Bowser"  wrote:

> Yes, it probably can. I'm thinking that Google once again put us in
> dependency hell with the new NDK functionality, which is why I'm not super
> stoked about this file existing at all.
>
> On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald 
> wrote:
>
> > Can't the crosswalk plugin deliver the
> > Gradle files via the framework tag of its plugin. Xml to fix this?
> >
> > Simon
> > On Jan 19, 2016 13:26, "Joe Bowser"  wrote:
> >
> > > I really don't want to add this file and use the deprecated NDK,
> > especially
> > > since we don't know if this is a plugin or platform responsibility.  I
> > also
> > > don't want to delay a release for people not using Crosswalk.
> > >
> > > Do we know of any other plugins that use the NDK? If there aren't any,
> > I'm
> > > more agreeable to adding the file since it won't break others.
> > >
> > >
> > > On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal <
> nikhi...@microsoft.com
> > >
> > > wrote:
> > >
> > > > If this is a regression in behavior and CrossWalk will not work out
> of
> > > the
> > > > box - we should consider fixing it. Sounds like it is a simple fix.
> Is
> > > > there  JIRA for this?
> > > >
> > > > Overall, we shouldn't require/expect Cordova JS developers to modify
> > > > gradle files.
> > > >
> > > > -Nikhil
> > > >
> > > > -Original Message-
> > > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > > Sent: Tuesday, January 19, 2016 9:00 AM
> > > > To: dev 
> > > > Subject: Re: [DISCUSS] Android@5.1.0
> > > >
> > > > What you guys think of making MIN SDK VER 15 instead of 14 as the
> > default
> > > > for this Android@5.1.0 ?
> > > >
> > > > We have a couple of plugins that required minsdk 15 [1], I also see
> > that
> > > > phonegap push plugin have problems with min sdk 14 here [2]
> > > >
> > > > Instead of anoying user with readme instructions to change it to 15,
> > why
> > > > not make the default 15, this way more stuff would work out of the
> box
> > > with
> > > > less trouble.
> > > > I guess if there is someone for a particular reason wants minsdk 14,
> > they
> > > > can change the default the same way as today using config.xml
> > > >
> > > >
> > > > [1]:
> > > >
> > > >
> > >
> >
> https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-plugin-push/blob/master/README.md
> > > > [2]:
> > > >
> > > >
> > >
> >
> https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#minsdkversion--14
> > > >
> > > > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser 
> wrote:
> > > >
> > > > > I don't think the gradle build issue should block the release, as
> > > > > annoying as it is, the workaround is literally adding a
> > > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties&data=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > > > file with a single line.
> > > > >
> > > > > As far as who owns it, I think Cordova should probably own that,
> but
> > > > > are there any other plugins that need NDK support?
> > > > >
> > > > > (I just ran into this less than an hour ago. It's annoying that
> > Google
> > > > > deprecates something without something else to replace it.)
> > > > >
> > > > > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue 
> > > wrote:
> > > > >
> > > > > > With cordova-android master, the Crosswalk Webview plugin fails
> to
> > > > > > build because gradle was updated and now NDK support has been
> > > removed.
> > > > > >
> > > > > > It can be re-enabled by providing a
> > > > > >
> > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > > > > &data=01%7c01%7cnikhilkh%40microsoft.com
> > >
> >
> %7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > > > file, but I'm not sure whether that should be the responsibility of
> > > > Cordova-Android or the Crosswalk Webview plugin.
> > > > > >
> > > > > > On 18 January 2016 at 15:12, Steven Gill  >
> > > > wrote:
> > > > > >
> > > > > > > Going to start this today. Let me know if you have any
> concerns.
> > > > > > >
> > > > > > > -Steve
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>


Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Steven Gill
Anyone planning on submitting a talk for apachecon?

The folks over at Apache Flex are wondering if we want to partner to create
a client-side track.

http://events.linuxfoundation.org/events/apachecon-north-america


[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread nikhilkh
GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-android/pull/249

CB-10386 Add android.useDeprecatedNdk=true to support NDK in gradle



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android ndkFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit 058a20af3ffc03bc2ef7bf89a8b74d3d4f61ac86
Author: Nikhil Khandelwal 
Date:   2016-01-19T19:16:04Z

CB-10386 Add android.useDeprecatedNdk=true to support NDK in gradle




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Ryan J. Salva
If we can get critical mass among other committers, I'd love to head up to 
Vancouver for a few days. Without other Cordova committers attending, I'm not 
sure I could justify attending solo.


-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Tuesday, January 19, 2016 11:05 AM
To: dev@cordova.apache.org
Subject: Apache Con NA May 11-13 in Vancouver, BC

Anyone planning on submitting a talk for apachecon?

The folks over at Apache Flex are wondering if we want to partner to create a 
client-side track.

https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents.linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBntbQGSkQY%3d


RE: [DISCUSS] Android@5.1.0

2016-01-19 Thread Nikhil Khandelwal
We have customers who have an existing C++ code base and looking to use NDK in 
their plugins. 

From what I can see the property android.useDeprecatedNdk=true needs to be part 
of gradle.properties and not .gradle file itself. I am aware that a plugin can 
add .gradle files - but I'm not sure they can add a gradle.properties file. Of 
course, hooks can be used to just about anything but it sounds hacky.

Another option would be to have cordova build.js invoke the gradle compiler 
with -Pandroid.useDeprecatedNdk=true.

I have a PR for this: https://github.com/apache/cordova-android/pull/249

Let's release once we are OK with merging this.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Tuesday, January 19, 2016 10:36 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Android@5.1.0

Yes, it probably can. I'm thinking that Google once again put us in dependency 
hell with the new NDK functionality, which is why I'm not super stoked about 
this file existing at all.

On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald 
wrote:

> Can't the crosswalk plugin deliver the Gradle files via the framework 
> tag of its plugin. Xml to fix this?
>
> Simon
> On Jan 19, 2016 13:26, "Joe Bowser"  wrote:
>
> > I really don't want to add this file and use the deprecated NDK,
> especially
> > since we don't know if this is a plugin or platform responsibility.  
> > I
> also
> > don't want to delay a release for people not using Crosswalk.
> >
> > Do we know of any other plugins that use the NDK? If there aren't 
> > any,
> I'm
> > more agreeable to adding the file since it won't break others.
> >
> >
> > On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal 
> >  >
> > wrote:
> >
> > > If this is a regression in behavior and CrossWalk will not work 
> > > out of
> > the
> > > box - we should consider fixing it. Sounds like it is a simple 
> > > fix. Is there  JIRA for this?
> > >
> > > Overall, we shouldn't require/expect Cordova JS developers to 
> > > modify gradle files.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > Sent: Tuesday, January 19, 2016 9:00 AM
> > > To: dev 
> > > Subject: Re: [DISCUSS] Android@5.1.0
> > >
> > > What you guys think of making MIN SDK VER 15 instead of 14 as the
> default
> > > for this Android@5.1.0 ?
> > >
> > > We have a couple of plugins that required minsdk 15 [1], I also 
> > > see
> that
> > > phonegap push plugin have problems with min sdk 14 here [2]
> > >
> > > Instead of anoying user with readme instructions to change it to 
> > > 15,
> why
> > > not make the default 15, this way more stuff would work out of the 
> > > box
> > with
> > > less trouble.
> > > I guess if there is someone for a particular reason wants minsdk 
> > > 14,
> they
> > > can change the default the same way as today using config.xml
> > >
> > >
> > > [1]:
> > >
> > >
> >
> https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-p
> lugin-push/blob/master/README.md
> > > [2]:
> > >
> > >
> >
> https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INST
> ALLATION.md#minsdkversion--14
> > >
> > > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser  wrote:
> > >
> > > > I don't think the gradle build issue should block the release, 
> > > > as annoying as it is, the workaround is literally adding a
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties&d
> ata=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f20
> 60f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa
> 7guies16P67hnK7hD%2b4hSs%3d
> > > file with a single line.
> > > >
> > > > As far as who owns it, I think Cordova should probably own that, 
> > > > but are there any other plugins that need NDK support?
> > > >
> > > > (I just ran into this less than an hour ago. It's annoying that
> Google
> > > > deprecates something without something else to replace it.)
> > > >
> > > > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue 
> > wrote:
> > > >
> > > > > With cordova-android master, the Crosswalk Webview plugin 
> > > > > fails to build because gradle was updated and now NDK support 
> > > > > has been
> > removed.
> > > > >
> > > > > It can be re-enabled by providing a
> > > > >
> https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > > > &data=01%7c01%7cnikhilkh%40microsoft.com
> >
> %7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011db47
> %7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > > file, but I'm not sure whether that should be the responsibility 
> > > of Cordova-Android or the Crosswalk Webview plugin.
> > > > >
> > > > > On 18 January 2016 at 15:12, Steven Gill 
> > > > > 
> > > wrote:
> > > > >
> > > > > > Going to start this today. Let me know if you have any concerns.
> > > > > >
> > > > > > -Steve
> > > > > >
> > > > >
> > > >
> > >
> >
>


Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Joe Bowser
As usual, I'm not going to be attending this conference.  I'm pretty sure
I'm banned from attending this.

On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva 
wrote:

> If we can get critical mass among other committers, I'd love to head up to
> Vancouver for a few days. Without other Cordova committers attending, I'm
> not sure I could justify attending solo.
>
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Tuesday, January 19, 2016 11:05 AM
> To: dev@cordova.apache.org
> Subject: Apache Con NA May 11-13 in Vancouver, BC
>
> Anyone planning on submitting a talk for apachecon?
>
> The folks over at Apache Flex are wondering if we want to partner to
> create a client-side track.
>
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents.linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBntbQGSkQY%3d
>


[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread nikhilkh
Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-172961014
  
This seems important enough. @riknoll can you review this? It relates to: 
CB-10177



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Steven Gill
I'm planning on going but it seems i'm the only one so far.

On Tue, Jan 19, 2016 at 11:23 AM, Joe Bowser  wrote:

> As usual, I'm not going to be attending this conference.  I'm pretty sure
> I'm banned from attending this.
>
> On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva 
> wrote:
>
> > If we can get critical mass among other committers, I'd love to head up
> to
> > Vancouver for a few days. Without other Cordova committers attending, I'm
> > not sure I could justify attending solo.
> >
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Tuesday, January 19, 2016 11:05 AM
> > To: dev@cordova.apache.org
> > Subject: Apache Con NA May 11-13 in Vancouver, BC
> >
> > Anyone planning on submitting a talk for apachecon?
> >
> > The folks over at Apache Flex are wondering if we want to partner to
> > create a client-side track.
> >
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents.linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBntbQGSkQY%3d
> >
>


[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/249#issuecomment-172965450
  
@infil00p Please take a look and lets start the release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread infil00p
Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/249#issuecomment-172966143
  
LGTM! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/457#discussion_r50165370
  
--- Diff: www/static/js/docs.js ---
@@ -48,7 +57,10 @@ $(document).ready(function () {
 // add a special class to the anchor for this toc entry
 var anchorName = getAnchorName(i, heading, prefix);
 $('#' + anchorName).addClass('fragment-anchor');
-
+if (i > 0) { 
+// the first link is the header of the page - exclude it
--- End diff --

Nitpick: please put the comment above the `if`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread riknoll
Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165621
  
--- Diff: src/android/FileHelper.java ---
@@ -79,50 +79,72 @@ public static String getRealPath(String uriString, 
CordovaInterface cordova) {
 @SuppressLint("NewApi")
 public static String getRealPathFromURI_API19(Context context, Uri 
uri) {
 String filePath = "";
+   Cursor cursor = null;
+
 try {
-String wholeID = DocumentsContract.getDocumentId(uri);
+ String wholeID = DocumentsContract.getDocumentId(uri);
 
 // Split at colon, use second item in the array
 String id = wholeID.indexOf(":") > -1 ? wholeID.split(":")[1] 
: wholeID.indexOf(";") > -1 ? wholeID
 .split(";")[1] : wholeID;
 
-String[] column = { MediaStore.Images.Media.DATA };
+   // @dlogo 20151210 Get type to check wheter is image or video
+   String type = wholeID.indexOf(":") > -1 ? wholeID.split(":")[0] : 
wholeID.indexOf(";") > -1 ? wholeID
+.split(";")[0] : wholeID;
+
+   Uri contentUri = null;
+if ("image".equals(type)) {
+contentUri = MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
+} else if ("video".equals(type)) {
+contentUri = MediaStore.Video.Media.EXTERNAL_CONTENT_URI;
+} else if ("audio".equals(type)) {
+contentUri = MediaStore.Audio.Media.EXTERNAL_CONTENT_URI;
+}
+
+   String[] column = { "_data" };
--- End diff --

Instead of hardcoding "_data", it looks like you can reference it from the 
base class that images/video/audio inherit from 
http://developer.android.com/reference/android/provider/MediaStore.MediaColumns.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread riknoll
Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165780
  
--- Diff: src/android/FileHelper.java ---
@@ -79,50 +79,72 @@ public static String getRealPath(String uriString, 
CordovaInterface cordova) {
 @SuppressLint("NewApi")
 public static String getRealPathFromURI_API19(Context context, Uri 
uri) {
 String filePath = "";
+   Cursor cursor = null;
+
 try {
-String wholeID = DocumentsContract.getDocumentId(uri);
+ String wholeID = DocumentsContract.getDocumentId(uri);
 
 // Split at colon, use second item in the array
 String id = wholeID.indexOf(":") > -1 ? wholeID.split(":")[1] 
: wholeID.indexOf(";") > -1 ? wholeID
 .split(";")[1] : wholeID;
 
-String[] column = { MediaStore.Images.Media.DATA };
+   // @dlogo 20151210 Get type to check wheter is image or video
+   String type = wholeID.indexOf(":") > -1 ? wholeID.split(":")[0] : 
wholeID.indexOf(";") > -1 ? wholeID
+.split(";")[0] : wholeID;
+
+   Uri contentUri = null;
+if ("image".equals(type)) {
+contentUri = MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
+} else if ("video".equals(type)) {
+contentUri = MediaStore.Video.Media.EXTERNAL_CONTENT_URI;
+} else if ("audio".equals(type)) {
+contentUri = MediaStore.Audio.Media.EXTERNAL_CONTENT_URI;
+}
+
+   String[] column = { "_data" };
 
-// where id is equal to
-String sel = MediaStore.Images.Media._ID + "=?";
+   // where id is equal to
+String sel = "_id=?";
--- End diff --

Same with `_id`: 
http://developer.android.com/reference/android/provider/BaseColumns.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Joe Bowser
OK, that's fine for now, but we should look at moving up which Android
Gradle version we're building with.  I'm kind of hesitant to use 2.0.0
because it might break stuff, and more and more getting the feeling that
the tools team is trying to make it harder for us to do things.

On Tue, Jan 19, 2016 at 11:17 AM, Nikhil Khandelwal 
wrote:

> We have customers who have an existing C++ code base and looking to use
> NDK in their plugins.
>
> From what I can see the property android.useDeprecatedNdk=true needs to be
> part of gradle.properties and not .gradle file itself. I am aware that a
> plugin can add .gradle files - but I'm not sure they can add a
> gradle.properties file. Of course, hooks can be used to just about anything
> but it sounds hacky.
>
> Another option would be to have cordova build.js invoke the gradle
> compiler with -Pandroid.useDeprecatedNdk=true.
>
> I have a PR for this: https://github.com/apache/cordova-android/pull/249
>
> Let's release once we are OK with merging this.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, January 19, 2016 10:36 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Android@5.1.0
>
> Yes, it probably can. I'm thinking that Google once again put us in
> dependency hell with the new NDK functionality, which is why I'm not super
> stoked about this file existing at all.
>
> On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald 
> wrote:
>
> > Can't the crosswalk plugin deliver the Gradle files via the framework
> > tag of its plugin. Xml to fix this?
> >
> > Simon
> > On Jan 19, 2016 13:26, "Joe Bowser"  wrote:
> >
> > > I really don't want to add this file and use the deprecated NDK,
> > especially
> > > since we don't know if this is a plugin or platform responsibility.
> > > I
> > also
> > > don't want to delay a release for people not using Crosswalk.
> > >
> > > Do we know of any other plugins that use the NDK? If there aren't
> > > any,
> > I'm
> > > more agreeable to adding the file since it won't break others.
> > >
> > >
> > > On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal
> > >  > >
> > > wrote:
> > >
> > > > If this is a regression in behavior and CrossWalk will not work
> > > > out of
> > > the
> > > > box - we should consider fixing it. Sounds like it is a simple
> > > > fix. Is there  JIRA for this?
> > > >
> > > > Overall, we shouldn't require/expect Cordova JS developers to
> > > > modify gradle files.
> > > >
> > > > -Nikhil
> > > >
> > > > -Original Message-
> > > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > > Sent: Tuesday, January 19, 2016 9:00 AM
> > > > To: dev 
> > > > Subject: Re: [DISCUSS] Android@5.1.0
> > > >
> > > > What you guys think of making MIN SDK VER 15 instead of 14 as the
> > default
> > > > for this Android@5.1.0 ?
> > > >
> > > > We have a couple of plugins that required minsdk 15 [1], I also
> > > > see
> > that
> > > > phonegap push plugin have problems with min sdk 14 here [2]
> > > >
> > > > Instead of anoying user with readme instructions to change it to
> > > > 15,
> > why
> > > > not make the default 15, this way more stuff would work out of the
> > > > box
> > > with
> > > > less trouble.
> > > > I guess if there is someone for a particular reason wants minsdk
> > > > 14,
> > they
> > > > can change the default the same way as today using config.xml
> > > >
> > > >
> > > > [1]:
> > > >
> > > >
> > >
> > https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-p
> > lugin-push/blob/master/README.md
> > > > [2]:
> > > >
> > > >
> > >
> > https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INST
> > ALLATION.md#minsdkversion--14
> > > >
> > > > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser 
> wrote:
> > > >
> > > > > I don't think the gradle build issue should block the release,
> > > > > as annoying as it is, the workaround is literally adding a
> > > > >
> > > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=gradle.properties&d
> > ata=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f20
> > 60f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa
> > 7guies16P67hnK7hD%2b4hSs%3d
> > > > file with a single line.
> > > > >
> > > > > As far as who owns it, I think Cordova should probably own that,
> > > > > but are there any other plugins that need NDK support?
> > > > >
> > > > > (I just ran into this less than an hour ago. It's annoying that
> > Google
> > > > > deprecates something without something else to replace it.)
> > > > >
> > > > > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue 
> > > wrote:
> > > > >
> > > > > > With cordova-android master, the Crosswalk Webview plugin
> > > > > > fails to build because gradle was updated and now NDK support
> > > > > > has been
> > > removed.
> > > > > >
> > > > > > It can be re-enabled by providing a
> > > > > >
> > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > > > > &data=01%7c01%7cnikhilkh%40microsoft.

[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/249


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Steven Gill
Looks like it has been merged. Good to release now?

On Tue, Jan 19, 2016 at 11:57 AM, Joe Bowser  wrote:

> OK, that's fine for now, but we should look at moving up which Android
> Gradle version we're building with.  I'm kind of hesitant to use 2.0.0
> because it might break stuff, and more and more getting the feeling that
> the tools team is trying to make it harder for us to do things.
>
> On Tue, Jan 19, 2016 at 11:17 AM, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> wrote:
>
> > We have customers who have an existing C++ code base and looking to use
> > NDK in their plugins.
> >
> > From what I can see the property android.useDeprecatedNdk=true needs to
> be
> > part of gradle.properties and not .gradle file itself. I am aware that a
> > plugin can add .gradle files - but I'm not sure they can add a
> > gradle.properties file. Of course, hooks can be used to just about
> anything
> > but it sounds hacky.
> >
> > Another option would be to have cordova build.js invoke the gradle
> > compiler with -Pandroid.useDeprecatedNdk=true.
> >
> > I have a PR for this: https://github.com/apache/cordova-android/pull/249
> >
> > Let's release once we are OK with merging this.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Tuesday, January 19, 2016 10:36 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Android@5.1.0
> >
> > Yes, it probably can. I'm thinking that Google once again put us in
> > dependency hell with the new NDK functionality, which is why I'm not
> super
> > stoked about this file existing at all.
> >
> > On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald <
> simon.macdon...@gmail.com>
> > wrote:
> >
> > > Can't the crosswalk plugin deliver the Gradle files via the framework
> > > tag of its plugin. Xml to fix this?
> > >
> > > Simon
> > > On Jan 19, 2016 13:26, "Joe Bowser"  wrote:
> > >
> > > > I really don't want to add this file and use the deprecated NDK,
> > > especially
> > > > since we don't know if this is a plugin or platform responsibility.
> > > > I
> > > also
> > > > don't want to delay a release for people not using Crosswalk.
> > > >
> > > > Do we know of any other plugins that use the NDK? If there aren't
> > > > any,
> > > I'm
> > > > more agreeable to adding the file since it won't break others.
> > > >
> > > >
> > > > On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal
> > > >  > > >
> > > > wrote:
> > > >
> > > > > If this is a regression in behavior and CrossWalk will not work
> > > > > out of
> > > > the
> > > > > box - we should consider fixing it. Sounds like it is a simple
> > > > > fix. Is there  JIRA for this?
> > > > >
> > > > > Overall, we shouldn't require/expect Cordova JS developers to
> > > > > modify gradle files.
> > > > >
> > > > > -Nikhil
> > > > >
> > > > > -Original Message-
> > > > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > > > Sent: Tuesday, January 19, 2016 9:00 AM
> > > > > To: dev 
> > > > > Subject: Re: [DISCUSS] Android@5.1.0
> > > > >
> > > > > What you guys think of making MIN SDK VER 15 instead of 14 as the
> > > default
> > > > > for this Android@5.1.0 ?
> > > > >
> > > > > We have a couple of plugins that required minsdk 15 [1], I also
> > > > > see
> > > that
> > > > > phonegap push plugin have problems with min sdk 14 here [2]
> > > > >
> > > > > Instead of anoying user with readme instructions to change it to
> > > > > 15,
> > > why
> > > > > not make the default 15, this way more stuff would work out of the
> > > > > box
> > > > with
> > > > > less trouble.
> > > > > I guess if there is someone for a particular reason wants minsdk
> > > > > 14,
> > > they
> > > > > can change the default the same way as today using config.xml
> > > > >
> > > > >
> > > > > [1]:
> > > > >
> > > > >
> > > >
> > > https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordova-p
> > > lugin-push/blob/master/README.md
> > > > > [2]:
> > > > >
> > > > >
> > > >
> > > https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INST
> > > ALLATION.md#minsdkversion--14
> > > > >
> > > > > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser 
> > wrote:
> > > > >
> > > > > > I don't think the gradle build issue should block the release,
> > > > > > as annoying as it is, the workaround is literally adding a
> > > > > >
> > > > >
> > > >
> > > https://na01.safelinks.protection.outlook.com/?url=gradle.properties&d
> > > ata=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d320f20
> > > 60f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxUjkWa
> > > 7guies16P67hnK7hD%2b4hSs%3d
> > > > > file with a single line.
> > > > > >
> > > > > > As far as who owns it, I think Cordova should probably own that,
> > > > > > but are there any other plugins that need NDK support?
> > > > > >
> > > > > > (I just ran into this less than an hour ago. It's annoying that
> > > Google
> > > > > > deprecates something without something else to replace it.)
> > > > > >
> > > > > > On

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/457#discussion_r50170623
  
--- Diff: _config.yml ---
@@ -73,7 +73,9 @@ redcarpet:
 - lax_spacing
 
 - tables
-
+
+# enables anhor links
+- with_toc_data
--- End diff --

Nitpick: please add a space under the option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/457#discussion_r50170880
  
--- Diff: www/static/js/docs.js ---
@@ -48,7 +57,10 @@ $(document).ready(function () {
 // add a special class to the anchor for this toc entry
 var anchorName = getAnchorName(i, heading, prefix);
 $('#' + anchorName).addClass('fragment-anchor');
-
+if (i > 0) { 
--- End diff --

Should we also apply this condition to the above adding of 
`'fragment-anchor'`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Anis KADRI
I'd be down to go. I went last year and our project had a few talks but
still was super under represented so everyone that can make it should go I
think.

On Tue, Jan 19, 2016 at 11:49 AM Steven Gill  wrote:

> I'm planning on going but it seems i'm the only one so far.
>
> On Tue, Jan 19, 2016 at 11:23 AM, Joe Bowser  wrote:
>
> > As usual, I'm not going to be attending this conference.  I'm pretty sure
> > I'm banned from attending this.
> >
> > On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva 
> > wrote:
> >
> > > If we can get critical mass among other committers, I'd love to head up
> > to
> > > Vancouver for a few days. Without other Cordova committers attending,
> I'm
> > > not sure I could justify attending solo.
> > >
> > >
> > > -Original Message-
> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > Sent: Tuesday, January 19, 2016 11:05 AM
> > > To: dev@cordova.apache.org
> > > Subject: Apache Con NA May 11-13 in Vancouver, BC
> > >
> > > Anyone planning on submitting a talk for apachecon?
> > >
> > > The folks over at Apache Flex are wondering if we want to partner to
> > > create a client-side track.
> > >
> > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents.linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBntbQGSkQY%3d
> > >
> >
>


[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/457#issuecomment-173002762
  
Just a suggestion: maybe add some CSS to make the link vanish unless the 
title is hovered, and add a bit of spacing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread riknoll
Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-173005542
  
@dlogo Thanks for submitting a PR! There are a number of whitespace issues 
that must be resolved before this is eligible to be merged. Please make sure 
you do not edit the whitespace on lines that you didn't alter the content of 
(e.g. line 85) and make sure you indent code blocks with four spaces. 

Also, you will need to sign and Apache ICLA before I can accept this code. 
Please see step 1 in the "Prerequisites" section of [this 
page](http://cordova.apache.org/contribute/contribute_guidelines.html
) for information on how to do that and let me know once it has been 
accepted.

I'll need to do some testing on this before I can merge this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] Plugins Release! Jan 15, 2016

2016-01-19 Thread Jesse
I vote +1.

* Verified signatures and hashes
* Verified tags


@purplecabbage
risingj.com

On Mon, Jan 18, 2016 at 8:21 AM, Alexander Sorokin (Akvelon) <
v-als...@microsoft.com> wrote:

> I vote +1.
>
> * Verified signatures and hashes
> * Verified tags
> * Verified that plugins can be added correctly to blank app
> * Verified that blank app can be successfully built and ran
> * Ran smoke testing of mobilespec app
> * Verified release notes
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Saturday, January 16, 2016 4:24 AM
> To: dev@cordova.apache.org
> Subject: [VOTE] Plugins Release! Jan 15, 2016
>
> Please review and vote on the release of this plugins release by replying
> to this email (and keep discussion on the DISCUSS thread)
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10368&data=01%7c01%7cv-alsoro%40microsoft.com%7c9853fe889c8f49e85fa808d31e13bc16%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KMtqzQjV%2boqHORO2cKiG0hS0Ioh9Rm%2bNjkiXDILLEOI%3d
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10368/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-camera: 2.1.0 (0f32b78c82)
> cordova-plugin-contacts: 2.0.1 (e9bbdd299c)
> cordova-plugin-device: 1.1.1 (d42fb80ca1)
> cordova-plugin-file: 4.1.0 (a4aa9158c3)
> cordova-plugin-file-transfer: 1.5.0 (3540af439e)
> cordova-plugin-geolocation: 2.1.0 (43ceab3a92)
> cordova-plugin-inappbrowser: 1.2.0 (c3ccb694d3)
> cordova-plugin-media: 2.1.0 (871bf29a4a)
> cordova-plugin-media-capture: 1.2.0 (1ede87258b)
> cordova-plugin-network-information: 1.2.0 (b0375e549b)
> cordova-plugin-splashscreen: 3.1.0 (0f4a9d3f18)
> cordova-plugin-statusbar: 2.1.0 (e6e8c5be10)
> cordova-plugin-test-framework: 1.1.1 (c431d1270b)
> cordova-plugin-vibration: 2.1.0 (e613e2e318)
> cordova-plugin-whitelist: 1.2.1 (c33ea30cf2)
>
> Upon a successful vote I will upload the archives to dist/, upload them to
> npm, post the corresponding blog post, and create apache release tags based
> on these release tags.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Built mobile-spec and ran on android 6.0.1
>


This is me!

2016-01-19 Thread Hernán Orozco
Hello,

My name is Hernan Orozco, I'm 23 years old, I'm a Ruby on Rails - Angularjs
- Phonegap developer. I've been working with Cordova for around two years.
I'm from Colombia and I'm currently working for Koombea .
I would like to contribute to some cordova plugins such as the camera
plugin and the capture plugin, and maybe other plugins.


[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/457


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/457#issuecomment-173042779
  
Thanks, Dmitry! I fixed the points that you brought up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: This is me!

2016-01-19 Thread Carlos Santana
Bienvenido Hernan
  Check out how to get started here:
http://cordova.apache.org/contribute/contribute_guidelines.html

Just curious, what features media-capture do you use, it will be good to
hear use cases for the plugin since camera it's more widely used than
capture.



On Tue, Jan 19, 2016 at 6:31 PM Hernán Orozco  wrote:

> Hello,
>
> My name is Hernan Orozco, I'm 23 years old, I'm a Ruby on Rails - Angularjs
> - Phonegap developer. I've been working with Cordova for around two years.
> I'm from Colombia and I'm currently working for Koombea <
> http://koombea.com>.
> I would like to contribute to some cordova plugins such as the camera
> plugin and the capture plugin, and maybe other plugins.
>


Re: [DISCUSS] Plugins Release

2016-01-19 Thread Carlos Santana
LGTM might want to add that this is a "plugin extravaganza" every plugin
got an update :-)


On Tue, Jan 19, 2016 at 1:57 AM Steven Gill  wrote:

> Please review the plugins release blog post.
> https://github.com/apache/cordova-docs/pull/458
>
> Also, need one more vote for the release.
>
> On Thu, Jan 14, 2016 at 10:24 AM, Steven Gill 
> wrote:
>
> > Going to start a plugins release soon. Any blockers? Any high priority
> > outstanding PRs you want us to look at before this release?
> >
> >
> >
>


Re: [VOTE] Plugins Release! Jan 15, 2016

2016-01-19 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3
Steve Gill
Alexander Sorokin
Jesse MacFadyen

The vote has passed. I will post the blog and publish to dist & npm.


On Tue, Jan 19, 2016 at 2:19 PM, Jesse  wrote:

> I vote +1.
>
> * Verified signatures and hashes
> * Verified tags
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Jan 18, 2016 at 8:21 AM, Alexander Sorokin (Akvelon) <
> v-als...@microsoft.com> wrote:
>
> > I vote +1.
> >
> > * Verified signatures and hashes
> > * Verified tags
> > * Verified that plugins can be added correctly to blank app
> > * Verified that blank app can be successfully built and ran
> > * Ran smoke testing of mobilespec app
> > * Verified release notes
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Saturday, January 16, 2016 4:24 AM
> > To: dev@cordova.apache.org
> > Subject: [VOTE] Plugins Release! Jan 15, 2016
> >
> > Please review and vote on the release of this plugins release by replying
> > to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10368&data=01%7c01%7cv-alsoro%40microsoft.com%7c9853fe889c8f49e85fa808d31e13bc16%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KMtqzQjV%2boqHORO2cKiG0hS0Ioh9Rm%2bNjkiXDILLEOI%3d
> >
> > The plugins have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10368/
> >
> > The packages were published from their corresponding git tags:
> > cordova-plugin-camera: 2.1.0 (0f32b78c82)
> > cordova-plugin-contacts: 2.0.1 (e9bbdd299c)
> > cordova-plugin-device: 1.1.1 (d42fb80ca1)
> > cordova-plugin-file: 4.1.0 (a4aa9158c3)
> > cordova-plugin-file-transfer: 1.5.0 (3540af439e)
> > cordova-plugin-geolocation: 2.1.0 (43ceab3a92)
> > cordova-plugin-inappbrowser: 1.2.0 (c3ccb694d3)
> > cordova-plugin-media: 2.1.0 (871bf29a4a)
> > cordova-plugin-media-capture: 1.2.0 (1ede87258b)
> > cordova-plugin-network-information: 1.2.0 (b0375e549b)
> > cordova-plugin-splashscreen: 3.1.0 (0f4a9d3f18)
> > cordova-plugin-statusbar: 2.1.0 (e6e8c5be10)
> > cordova-plugin-test-framework: 1.1.1 (c431d1270b)
> > cordova-plugin-vibration: 2.1.0 (e613e2e318)
> > cordova-plugin-whitelist: 1.2.1 (c33ea30cf2)
> >
> > Upon a successful vote I will upload the archives to dist/, upload them
> to
> > npm, post the corresponding blog post, and create apache release tags
> based
> > on these release tags.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Built mobile-spec and ran on android 6.0.1
> >
>


Re: [DISCUSS] Plugins Release

2016-01-19 Thread Steven Gill
Actually not every plugin was updated :P

On Tue, Jan 19, 2016 at 5:17 PM, Carlos Santana 
wrote:

> LGTM might want to add that this is a "plugin extravaganza" every plugin
> got an update :-)
>
>
> On Tue, Jan 19, 2016 at 1:57 AM Steven Gill 
> wrote:
>
> > Please review the plugins release blog post.
> > https://github.com/apache/cordova-docs/pull/458
> >
> > Also, need one more vote for the release.
> >
> > On Thu, Jan 14, 2016 at 10:24 AM, Steven Gill 
> > wrote:
> >
> > > Going to start a plugins release soon. Any blockers? Any high priority
> > > outstanding PRs you want us to look at before this release?
> > >
> > >
> > >
> >
>


Re: [DISCUSS] Plugins Release

2016-01-19 Thread Carlos Santana
I know I know, well at least it's a good thing, plugin that didn't get an
update it's stable or recently already released :-)


On Tue, Jan 19, 2016 at 8:22 PM Steven Gill  wrote:

> Actually not every plugin was updated :P
>
> On Tue, Jan 19, 2016 at 5:17 PM, Carlos Santana 
> wrote:
>
> > LGTM might want to add that this is a "plugin extravaganza" every plugin
> > got an update :-)
> >
> >
> > On Tue, Jan 19, 2016 at 1:57 AM Steven Gill 
> > wrote:
> >
> > > Please review the plugins release blog post.
> > > https://github.com/apache/cordova-docs/pull/458
> > >
> > > Also, need one more vote for the release.
> > >
> > > On Thu, Jan 14, 2016 at 10:24 AM, Steven Gill 
> > > wrote:
> > >
> > > > Going to start a plugins release soon. Any blockers? Any high
> priority
> > > > outstanding PRs you want us to look at before this release?
> > > >
> > > >
> > > >
> > >
> >
>


[GitHub] cordova-docs pull request: added plugins release blog post

2016-01-19 Thread stevengill
Github user stevengill closed the pull request at:

https://github.com/apache/cordova-docs/pull/458


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Simon MacDonald
I would be interested in going as well. Might be an easier sell if we could
schedule a Cordova check up around the same time.

Simon Mac Donald
http://hi.im/simonmacdonald

On Tue, Jan 19, 2016 at 4:20 PM, Anis KADRI  wrote:

> I'd be down to go. I went last year and our project had a few talks but
> still was super under represented so everyone that can make it should go I
> think.
>
> On Tue, Jan 19, 2016 at 11:49 AM Steven Gill 
> wrote:
>
> > I'm planning on going but it seems i'm the only one so far.
> >
> > On Tue, Jan 19, 2016 at 11:23 AM, Joe Bowser  wrote:
> >
> > > As usual, I'm not going to be attending this conference.  I'm pretty
> sure
> > > I'm banned from attending this.
> > >
> > > On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva 
> > > wrote:
> > >
> > > > If we can get critical mass among other committers, I'd love to head
> up
> > > to
> > > > Vancouver for a few days. Without other Cordova committers attending,
> > I'm
> > > > not sure I could justify attending solo.
> > > >
> > > >
> > > > -Original Message-
> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > Sent: Tuesday, January 19, 2016 11:05 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: Apache Con NA May 11-13 in Vancouver, BC
> > > >
> > > > Anyone planning on submitting a talk for apachecon?
> > > >
> > > > The folks over at Apache Flex are wondering if we want to partner to
> > > > create a client-side track.
> > > >
> > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents.linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBntbQGSkQY%3d
> > > >
> > >
> >
>


[ANNOUNCE] Cordova Plugins Released!

2016-01-19 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/689631426921107457
Blog: https://cordova.apache.org/news/2016/01/19/plugins-release.html


[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-19 Thread sarangan12
GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-medic/pull/69

CB-10390: ADB doesn't recognize existing devices in Medic

In Apache CI, we get the error: ADB doesn't recognize existing devices
in Medic. The root cause for this error is that there is an additional
space in the pattern. As a result ‘emulator-5554’ will not be matched
with ‘emulator ‘ pattern (due to additional space). On removing the
additional space, the pattern matching working fine.

Also, when you run adb devices command, there will be a header line
“List of devices” will be displayed which must be ignored. Added the
code to ignore that also.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-medic master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #69


commit 2c9e1d33cace0f046ba0989b56fc5ebe845c42c0
Author: Sarangan Rajamanickam 
Date:   2016-01-20T02:12:42Z

CB-10390: ADB doesn't recognize existing devices in Medic

In Apache CI, we get the error: ADB doesn't recognize existing devices
in Medic. The root cause for this error is that there is an additional
space in the pattern. As a result ‘emulator-5554’ will not be matched
with ‘emulator ‘ pattern (due to additional space). On removing the
additional space, the pattern matching working fine.

Also, when you run adb devices command, there will be a header line
“List of devices” will be displayed which must be ignored. Added the
code to ignore that also.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request: Updated step to create permanent releas...

2016-01-19 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/110

Updated step to create permanent release tags



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #110


commit 9bba016b9358dff6b3f21f0a1b28f43c31bf29ab
Author: Steve Gill 
Date:   2016-01-20T02:14:45Z

Updated step to create permanent release tags




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request: Updated step to create permanent releas...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-19 Thread sarangan12
Github user sarangan12 commented on the pull request:

https://github.com/apache/cordova-medic/pull/69#issuecomment-173062219
  
@dblotsky @nikhilkh @riknoll Can you please check and merge this request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

2016-01-19 Thread njleonzhang
Github user njleonzhang commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173069706
  
@daserge, when AutoHideSplashScreen is disabled, I think the splash should 
not hide when app is switch to background.
So I think the flowing change should be considered.

@@ -110,7 +110,9 @@ public void onPause(boolean multitasking) {
  return;
  }
  // hide the splash screen to avoid leaking a window
 -this.removeSplashScreen();
 +if(autoHide){
 +this.removeSplashScreen();
 +}
}



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Parashuram N
Like another Cordova Face to Face ? It would be almost 6 months since we had 
the last one. 

-Original Message-
From: Simon MacDonald [mailto:simon.macdon...@gmail.com] 
Sent: Tuesday, January 19, 2016 6:02 PM
To: dev@cordova.apache.org
Subject: Re: Apache Con NA May 11-13 in Vancouver, BC

I would be interested in going as well. Might be an easier sell if we could 
schedule a Cordova check up around the same time.

Simon Mac Donald
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cpanarasi%40microsoft.com%7c2adb8eb8acd348e2632108d3213dc71f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=OSg6OMGtiPCppvOA4TuM5hv%2fjkfa8mqcyk1WqT8VSn4%3d

On Tue, Jan 19, 2016 at 4:20 PM, Anis KADRI  wrote:

> I'd be down to go. I went last year and our project had a few talks 
> but still was super under represented so everyone that can make it 
> should go I think.
>
> On Tue, Jan 19, 2016 at 11:49 AM Steven Gill 
> wrote:
>
> > I'm planning on going but it seems i'm the only one so far.
> >
> > On Tue, Jan 19, 2016 at 11:23 AM, Joe Bowser  wrote:
> >
> > > As usual, I'm not going to be attending this conference.  I'm 
> > > pretty
> sure
> > > I'm banned from attending this.
> > >
> > > On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva 
> > > 
> > > wrote:
> > >
> > > > If we can get critical mass among other committers, I'd love to 
> > > > head
> up
> > > to
> > > > Vancouver for a few days. Without other Cordova committers 
> > > > attending,
> > I'm
> > > > not sure I could justify attending solo.
> > > >
> > > >
> > > > -Original Message-
> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > Sent: Tuesday, January 19, 2016 11:05 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: Apache Con NA May 11-13 in Vancouver, BC
> > > >
> > > > Anyone planning on submitting a talk for apachecon?
> > > >
> > > > The folks over at Apache Flex are wondering if we want to 
> > > > partner to create a client-side track.
> > > >
> > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents
> .linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7
> crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf8
> 6f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBnt
> bQGSkQY%3d
> > > >
> > >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Simon MacDonald
Yup, that was exactly what I was thinking. Check in see if we've made
progress on what we talked about last time.


Simon Mac Donald
http://hi.im/simonmacdonald

On Tue, Jan 19, 2016 at 10:05 PM, Parashuram N 
wrote:

> Like another Cordova Face to Face ? It would be almost 6 months since we
> had the last one.
>
> -Original Message-
> From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> Sent: Tuesday, January 19, 2016 6:02 PM
> To: dev@cordova.apache.org
> Subject: Re: Apache Con NA May 11-13 in Vancouver, BC
>
> I would be interested in going as well. Might be an easier sell if we
> could schedule a Cordova check up around the same time.
>
> Simon Mac Donald
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cpanarasi%40microsoft.com%7c2adb8eb8acd348e2632108d3213dc71f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=OSg6OMGtiPCppvOA4TuM5hv%2fjkfa8mqcyk1WqT8VSn4%3d
>
> On Tue, Jan 19, 2016 at 4:20 PM, Anis KADRI  wrote:
>
> > I'd be down to go. I went last year and our project had a few talks
> > but still was super under represented so everyone that can make it
> > should go I think.
> >
> > On Tue, Jan 19, 2016 at 11:49 AM Steven Gill 
> > wrote:
> >
> > > I'm planning on going but it seems i'm the only one so far.
> > >
> > > On Tue, Jan 19, 2016 at 11:23 AM, Joe Bowser 
> wrote:
> > >
> > > > As usual, I'm not going to be attending this conference.  I'm
> > > > pretty
> > sure
> > > > I'm banned from attending this.
> > > >
> > > > On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva
> > > > 
> > > > wrote:
> > > >
> > > > > If we can get critical mass among other committers, I'd love to
> > > > > head
> > up
> > > > to
> > > > > Vancouver for a few days. Without other Cordova committers
> > > > > attending,
> > > I'm
> > > > > not sure I could justify attending solo.
> > > > >
> > > > >
> > > > > -Original Message-
> > > > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > > Sent: Tuesday, January 19, 2016 11:05 AM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Apache Con NA May 11-13 in Vancouver, BC
> > > > >
> > > > > Anyone planning on submitting a talk for apachecon?
> > > > >
> > > > > The folks over at Apache Flex are wondering if we want to
> > > > > partner to create a client-side track.
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fevents
> > .linuxfoundation.org%2fevents%2fapachecon-north-america&data=01%7c01%7
> > crsalva%40microsoft.com%7ca77249e9c394412deb6908d32103904c%7c72f988bf8
> > 6f141af91ab2d7cd011db47%7c1&sdata=DtyHuN1e3o5ARFZ5lNSvHlk0JwrY2zp5hBnt
> > bQGSkQY%3d
> > > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread dlogo
Github user dlogo commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-173118941
  
@riknoll thanks for reviewing the code, I'll follow your recommendations 
and update the code asap!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org