[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723 Reviewed changes, :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] InAppBrowser Plugin Release
Hi Sean, such discussion should happen in [Discuss] thread, before vote is started. CB-7786 introduces new functionality so this should be in minor or major release anyway. I've reviewed your PR and it looks good, I'll merge it later today. Thx! -Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, February 3, 2016 5:44 AM To: dev@cordova.apache.org Subject: Re: [VOTE] InAppBrowser Plugin Release Hey Sean, We only -1 if it is a regression or major bug found. I would say CB-7786 doesn't qualify as either of those. According to ASF policies, only PMC members can vote. I know you have been trying to get someone to review your PR. I'll bug some people tomorrow to see if we can get it reviewed and in the next inappbrowser plugin release. We can do another inappbrowser release shortly after. Cheers, -Steve On Tue, Feb 2, 2016 at 6:39 PM, Sean Kelly wrote: > I'd vote no. I'd really like to see CB-7786 get in before the next release. > > SeanK > > On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > Please review and vote on the InAppBrowser plugin release by > > replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss > > ues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-segreb%40 > > microsoft.com%7c594a03e53e384d3cfc7008d32c43fc36%7c72f988bf86f141af9 > > 1ab2d7cd011db47%7c1&sdata=UhXz%2bhfLfjU0cK16GNLrW0Bmmeqi1hzwEET2zeae > > mQU%3d > > > > The plugin has been published to dist/dev: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdis > > t.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c > > 01%7cv-segreb%40microsoft.com%7c594a03e53e384d3cfc7008d32c43fc36%7c7 > > 2f988bf86f141af91ab2d7cd011db47%7c1&sdata=bDfFos9mxYdJZ27CMfUl2sNMH7 > > G2X%2fBaI4GbfmgUVQ8%3d > > > > The package were published from their corresponding git tag: > > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157) > > > > Upon a successful vote I will upload the archives to dist/, upload > > them > to > > the Plugins Registry, and post the corresponding blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Run auto tests for iOS, Android and Windows > > > > -Sergey > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
[GitHub] cordova-plugin-inappbrowser pull request: CB-7786 android: add new...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/132#issuecomment-179030795 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-179025411 I'm assuming your grep'd for any incoming links to the files that you are deleting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )
yes I tried it your index.html, red boxes some time disappear but they also disappear on simulator so didn't know what you were looking for. ping me tomorrow on slack, maybe I can screen share and do a live session. On Tue, Feb 2, 2016 at 9:18 AM julio cesar sanchez wrote: > Thanks for testing. > Did you try with my index.html? do the red boxes always appeared on the app > corners? > CB-10288 is about webview not resizing correctly in multitasking screens > (Split View - Slide Over) > > 2016-02-02 3:15 GMT+01:00 Carlos Santana : > > > Julio I tested on my iPad Air 2 used ios@4.0.1 the buttons show up, > > buttons > > work, I can do splitview no crashes > > > > > > On Mon, Feb 1, 2016 at 10:36 AM julio cesar sanchez < > > jcesarmob...@gmail.com> > > wrote: > > > > > cordova should support launch storyboards > > > https://issues.apache.org/jira/browse/CB-7521 > > > https://issues.apache.org/jira/browse/CB-9161 > > > > > > and "Requires full Screen" should be configurable, right now is set to > > true > > > (this is the JIRA item that set it to true > > > https://issues.apache.org/jira/browse/CB-9690, AFAIK, there nos issue > > for > > > making it configurable ) > > > > > > > > > > > > 2016-02-01 15:07 GMT+01:00 Carlos Santana : > > > > > > > I have an iPad that supports multitasking but it's at home, I can > test > > it > > > > tonight if no one else have gotten to it first > > > > > > > > You said "cordova doesn't officially support multitasking yet" Do > you > > > have > > > > a JIRA item describing what would be necessary to have support? > > > > > > > > > > > > On Sun, Jan 31, 2016 at 5:15 PM julio cesar sanchez < > > > > jcesarmob...@gmail.com> > > > > wrote: > > > > > > > > > I'm trying to fix https://issues.apache.org/jira/browse/CB-10288 > > > > > > > > > > I've tested on simulators and seems to work fine, but I don't have > > any > > > > real > > > > > iPad with multitasking support to test. > > > > > > > > > > As cordova doesn't officially support multitasking yet, you have to > > > > follow > > > > > these steps to add the support. > > > > > > > > > > On an empty project with ios platform (tested on cordova ios 3.9.2, > > > but I > > > > > think it should work on 4) > > > > > > > > > > Add all orientatios > > > > > > > > > > > > > > > add my commit of statusbar plugin > > > > > > > > > > cordova plugin add > > > > > https://github.com/jcesarmobile/cordova-plugin-statusbar#578fa1b > > > > > > > > > > Open the xcode project and create a new "Launch Screen" file > > > > > On the target "General" screen, set the file as "Launch Screen > File" > > > and > > > > > uncheck "Requires full screen" > > > > > > > > > > I use this as the index.html but you can use your own > > > > > https://gist.github.com/jcesarmobile/114fdb8b771837440752 > > > > > > > > > > > > > > >
Re: [VOTE] InAppBrowser Plugin Release
Hey Sean, We only -1 if it is a regression or major bug found. I would say CB-7786 doesn't qualify as either of those. According to ASF policies, only PMC members can vote. I know you have been trying to get someone to review your PR. I'll bug some people tomorrow to see if we can get it reviewed and in the next inappbrowser plugin release. We can do another inappbrowser release shortly after. Cheers, -Steve On Tue, Feb 2, 2016 at 6:39 PM, Sean Kelly wrote: > I'd vote no. I'd really like to see CB-7786 get in before the next release. > > SeanK > > On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > Please review and vote on the InAppBrowser plugin release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-10505 > > > > The plugin has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-10505/ > > > > The package were published from their corresponding git tag: > > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157) > > > > Upon a successful vote I will upload the archives to dist/, upload them > to > > the Plugins Registry, and post the corresponding blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Run auto tests for iOS, Android and Windows > > > > -Sergey > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Re: [VOTE] InAppBrowser Plugin Release
I'd vote no. I'd really like to see CB-7786 get in before the next release. SeanK On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Please review and vote on the InAppBrowser plugin release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-10505 > > The plugin has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-10505/ > > The package were published from their corresponding git tag: > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157) > > Upon a successful vote I will upload the archives to dist/, upload them to > the Plugins Registry, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Run auto tests for iOS, Android and Windows > > -Sergey > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/463#issuecomment-178958029 Additional review comments handled and committed. Thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178945513 @dblotsky is this good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51665030 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example: app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - - -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: - -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. - - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. - -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. - -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. - -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. - -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. - -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. - -### Additional Versioning +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id (string) | *Required: true* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version (string) | *Required: true* Full version number expressed in major/minor/patch notation. + versionCode (string) | *Required: false* **Platforms supported: Android** Alternative version for Android. + CFBundleVersion (string) | *Required: false* **Platforms supported: iOS** Alternative version for iOS. + packageVersion (string) | *Required: false* **Platforms supported: Windows** Alternative version for Windows. + packageName (string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns (string) | *Required: true* namespace for the config.xml document. + xmlns:cdv (string) | *Required: true* namespace prefix. + + Examples: -Android, iOS, and Windows support a second version string (or number) in -addition to the one visible in app stores: + + -- [versionCode](http://developer.android.com/tools/publishing/versioning.html) - for Android -- [CFBundleVersion](http://stackoverflow.com/questions/4933093/cfbundleversion-in-the-info-plist-upload-error) - for iOS -- [packageVersion](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx) - for Windows + + -Below is an example that explicitly sets these properties: + + +
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51664771 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example: app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - - -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: - -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. - - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. - -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. - -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. - -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. - -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. - -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. - -### Additional Versioning +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id (string) | *Required: true* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version (string) | *Required: true* Full version number expressed in major/minor/patch notation. + versionCode (string) | *Required: false* **Platforms supported: Android** Alternative version for Android. + CFBundleVersion (string) | *Required: false* **Platforms supported: iOS** Alternative version for iOS. + packageVersion (string) | *Required: false* **Platforms supported: Windows** Alternative version for Windows. + packageName (string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns (string) | *Required: true* namespace for the config.xml document. + xmlns:cdv (string) | *Required: true* namespace prefix. + + Examples: -Android, iOS, and Windows support a second version string (or number) in -addition to the one visible in app stores: + + -- [versionCode](http://developer.android.com/tools/publishing/versioning.html) - for Android -- [CFBundleVersion](http://stackoverflow.com/questions/4933093/cfbundleversion-in-the-info-plist-upload-error) - for iOS -- [packageVersion](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx) - for Windows + + -Below is an example that explicitly sets these properties: + + +
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51664527 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## description
[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178919636 Alright I'm going to leave it as is and I'll change it if it becomes an issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178885986 Hmm, that's a good point. I guess if we ever do implement levels in the page ToC then we can always just put them back. LGTM then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178885626 Yep, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178884046 No, I don't think it is. What special meaning does H3+ have in the TOC? All of our TOC entries for a page are presented without hierarchy in the sidebar; H3+ lose all meaning in that format and become semantically the same in importance as H2 in the TOC, which does not make sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178882554 I'm still a bit unconvinced that all H3 - H6 headings should be excluded from ToC across the board. This is specific to the reference pages, isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178880580 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/481 CB-10516: Remove h3-h6 from showing up in docs ToC Removing h3-h6 from showing up in docs ToC @dblotsky @riknoll @nikhilkh Can you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-docs CB-10516 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/481.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #481 commit 5ea32616e43b9dcd078b790c27c7637cedea3197 Author: Sarangan Rajamanickam Date: 2016-02-02T23:16:31Z CB-10516: Remove h3-h6 from showing up in docs ToC Removing h3-h6 from showing up in docs ToC --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51652071
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,386 @@ title: Events
# Events
-> Cordova lifecycle events.
+
-## Event Types
+
-- [deviceready](events.deviceready.html)
-- [pause](events.pause.html)
-- [resume](events.resume.html)
-- [backbutton](events.backbutton.html)
-- [menubutton](events.menubutton.html)
-- [searchbutton](events.searchbutton.html)
-- [startcallbutton](events.startcallbutton.html)
-- [endcallbutton](events.endcallbutton.html)
-- [volumedownbutton](events.volumedownbutton.html)
-- [volumeupbutton](events.volumeupbutton.html)
+
+
+Supported Platforms/Events
+amazon-fireos
+android
+blackberry10
+ios
+Windows Phone 8
+Windows
+
+
-## Events added by
[cordova-plugin-battery-status](https://github.com/apache/cordova-plugin-battery-status/blob/master/README.md)
+
+
+deviceready
+
+
+
+
+
+
+
-- batterycritical
-- batterylow
-- batterystatus
+
+pause
+
+
+
+
+
+
+
-## Events added by
[cordova-plugin-network-information](https://github.com/apache/cordova-plugin-network-information/blob/master/README.md)
+
+resume
+
+
+
+
+
+
+
-- online
-- offline
+
+backbutton
+
+
+
+
+
+
+
+
+menubutton
+
+
+
+
+
+
+
+
+
+searchbutton
+
+
+
+
+
+
+
+
+
+startcallbutton
+
+
+
+
+
+
+
+
+
+endcallbutton
+
+
+
+
+
+
+
+
+
+volumedownbutton
+
+
+
+
+
+
+
+
+
+volumeupbutton
+
+
+
+
+
+
+
+
+
+
+
+
+
+**Note**: Applications typically should use `document.addEventListener` to
+attach an event listener once the [deviceready](#link-deviceready)
+event fires.
+
+## deviceready
+
+The deviceready event fires when Cordova is fully loaded. This event is
+essential to any application. It signals that Cordova's device APIs have
+loaded and are ready to access.
+
+Cordova consists of two code bases: native and JavaScript. While the
+native code loads, a custom loading image displays. However,
+JavaScript only loads once the DOM loads. This means the web app may
+potentially call a Cordova JavaScript function before the
+corresponding native code becomes available.
+
+The `deviceready` event fires once Cordova has fully loaded. Once the
+event fires, you can safely make calls to Cordova APIs. Applications
+typically attach an event listener with `document.addEventListener`
+once the HTML document's DOM has loaded.
+
+The `deviceready` event behaves somewhat differently from others. Any
+event handler registered after the `deviceready` event fires has its
+callback function called immediately.
+
+### Quick Example
+
+document.addEventListener("deviceready", onDeviceReady, false);
+
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+### Full Example
+
+ HTML File
+
+
+
+
+Device Ready Example
+
+
+
+
+
+
+
+
+ JS File
+// example.js file
+// Wait for device API libraries to load
+//
+function onLoad() {
+document.addEventListener("deviceready", onDeviceReady, false);
+}
+
+// device APIs are available
+//
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+## pause
+
+The pause event fires when the native platform puts the application into
the background,
+typically when the user switches to a different application.
+
+### Quick Exampl
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51651676
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
-'selectors': 'h1,h2,h3,h4,h5,h6', // elements to use as
headings
+'selectors': 'h1,h2', // elements to use as headings
--- End diff --
@riknoll Ideally, I would have preferred a seperate commit. But this is a
one-off case. With the changes to the events page, ToC will be cuttered. So,
adding it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51651551
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
-'selectors': 'h1,h2,h3,h4,h5,h6', // elements to use as
headings
+'selectors': 'h1,h2', // elements to use as headings
--- End diff --
@dblotsky Its a tradeoff between the semantic meaning and what you want to
show in ToC. And, this seems reasonable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51651548
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
-'selectors': 'h1,h2,h3,h4,h5,h6', // elements to use as
headings
+'selectors': 'h1,h2', // elements to use as headings
--- End diff --
Confusing for who? I don't think users expect the TOC to be that
comprehensive; major headings only should be fine. We do need to be vigilant
when we write pages to make sure the TOC displays correctly. I would argue that
defining/using other tags just complicates the markdown and defeats the purpose
of using it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178875194 @riknoll @rakatyal @dblotsky Removed the full examples for all except required. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51650887
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
-'selectors': 'h1,h2,h3,h4,h5,h6', // elements to use as
headings
+'selectors': 'h1,h2', // elements to use as headings
--- End diff --
I guess that's an ok workaround. But doesn't that mean that we should use
different tags other than headers in the references? This might become
confusing when we do use `h3`s properly in a document and then it won't show up
in the ToC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-osx pull request: CB-10085 Implement and expose PlatformAp...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51650131
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
-'selectors': 'h1,h2,h3,h4,h5,h6', // elements to use as
headings
+'selectors': 'h1,h2', // elements to use as headings
--- End diff --
I didn't notice this. We do need this change, but it should be in a
separate commit/JIRA. The reason for this @dblotsky is that certain longer
pages (like the upcoming single page platforms guide) have a lot of headers
that only serve to clutter the toc. Same with reference pages; every attribute
does not need a toc entry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178872563 +1 to Richard's previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178872718 +1 to Richard's point. They hardly add anything relevant and the format repeats for each event. I think that we can rename it to example, give the full example for the first event and keep the quick example content for others to follow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51649541
--- Diff: www/static/js/docs.js ---
@@ -40,7 +40,7 @@ $(document).ready(function () {
// Table of Contents
$('#page-toc').toc({
-'selectors': 'h1,h2,h3,h4,h5,h6', // elements to use as
headings
+'selectors': 'h1,h2', // elements to use as headings
--- End diff --
Why not have `h3,h4,h5,h6` show up in the page ToC?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/479#issuecomment-178872081 +1 to @dblotsky's comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178871869 I mentioned this offline, but do we want to include the full example for each event? Adds a lot of length to the document and all of the examples are the same with strings swapped. I think the quick examples are sufficient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/479#issuecomment-178871753 We have another variable, `latest_docs_version`, whose name sounds like this one. Please rename this variable to something more explicit (like `default_linked_docs_version`) and please add it above [this line][line] so that it's grouped with the other one. [line]: https://github.com/apache/cordova-docs/blob/master/_config.yml#L22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51649012
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,560 @@ title: Events
# Events
-> Cordova lifecycle events.
+
-## Event Types
+
-- [deviceready](events.deviceready.html)
-- [pause](events.pause.html)
-- [resume](events.resume.html)
-- [backbutton](events.backbutton.html)
-- [menubutton](events.menubutton.html)
-- [searchbutton](events.searchbutton.html)
-- [startcallbutton](events.startcallbutton.html)
-- [endcallbutton](events.endcallbutton.html)
-- [volumedownbutton](events.volumedownbutton.html)
-- [volumeupbutton](events.volumeupbutton.html)
+
+
+Supported Platforms/Events
+amazon-fireos
+android
+blackberry10
+ios
+Windows Phone 8
+Windows
+
+
-## Events added by
[cordova-plugin-battery-status](https://github.com/apache/cordova-plugin-battery-status/blob/master/README.md)
+
+
+deviceready
+
+
+
+
+
+
+
-- batterycritical
-- batterylow
-- batterystatus
+
+pause
+
+
+
+
+
+
+
-## Events added by
[cordova-plugin-network-information](https://github.com/apache/cordova-plugin-network-information/blob/master/README.md)
+
+resume
+
+
+
+
+
+
+
-- online
-- offline
+
+backbutton
+
+
+
+
+
+
+
+
+menubutton
+
+
+
+
+
+
+
+
+
+searchbutton
+
+
+
+
+
+
+
+
+
+startcallbutton
+
+
+
+
+
+
+
+
+
+endcallbutton
+
+
+
+
+
+
+
+
+
+volumedownbutton
+
+
+
+
+
+
+
+
+
+volumeupbutton
+
+
+
+
+
+
+
+
+
+
+
+
+
+**Note**: Applications typically should use `document.addEventListener` to
+attach an event listener once the [deviceready](#link-deviceready)
+event fires.
+
+## deviceready
+
+The deviceready event fires when Cordova is fully loaded. This event is
+essential to any application. It signals that Cordova's device APIs have
+loaded and are ready to access.
+
+Cordova consists of two code bases: native and JavaScript. While the
+native code loads, a custom loading image displays. However,
+JavaScript only loads once the DOM loads. This means the web app may
+potentially call a Cordova JavaScript function before the
+corresponding native code becomes available.
+
+The `deviceready` event fires once Cordova has fully loaded. Once the
+event fires, you can safely make calls to Cordova APIs. Applications
+typically attach an event listener with `document.addEventListener`
+once the HTML document's DOM has loaded.
+
+The `deviceready` event behaves somewhat differently from others. Any
+event handler registered after the `deviceready` event fires has its
+callback function called immediately.
+
+### Quick Example
+
+document.addEventListener("deviceready", onDeviceReady, false);
+
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+### Full Example
+
+**Note**: For the sake of readability, all the other events assume that
you use the
+below html code.
+
+ HTML File
+
+
+
+
+Device Ready Example
+
+
+
+
+
+
+
+
+ JS File
+// example.js file
+// Wait for device API libraries to load
+//
+function onLoad() {
+document.addEventListener("deviceready", onDeviceReady, false);
+}
+
+// device APIs are available
+//
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+## pause
+
+The pause event fires when the native platform puts the applicatio
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178870956 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51648894 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. --- End diff -- +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178870049 @dblotsky I think both of them use slightly different libs (request and http). So, for now, I am leaving it as is. But, I am marking this for further changes as we plan to move the slave machine itself to new one (soon :-)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51648833 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + --- End diff -- That's not an integer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178869407 Oh, I think I'm mistaking this for `testwait`. `testcheck` does *not* poll and yes, this is necessary. My mistake! Do you think this can be factored out to be in `util` then, so that there is no duplication of retry logic with `testwait`? If it's too long a process, I guess we can have some duplication. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51648033
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
+
-## Event Types
+
-- [deviceready](events.deviceready.html)
-- [pause](events.pause.html)
-- [resume](events.resume.html)
-- [backbutton](events.backbutton.html)
-- [menubutton](events.menubutton.html)
-- [searchbutton](events.searchbutton.html)
-- [startcallbutton](events.startcallbutton.html)
-- [endcallbutton](events.endcallbutton.html)
-- [volumedownbutton](events.volumedownbutton.html)
-- [volumeupbutton](events.volumeupbutton.html)
+
+
+Supported Platforms/Events
+amazon-fireos
+android
+blackberry10
+ios
+Windows Phone 8
+Windows
+
+
-## Events added by
[cordova-plugin-battery-status](https://github.com/apache/cordova-plugin-battery-status/blob/master/README.md)
+
+
+deviceready
+
+
+
+
+
+
+
-- batterycritical
-- batterylow
-- batterystatus
+
+pause
+
+
+
+
+
+
+
-## Events added by
[cordova-plugin-network-information](https://github.com/apache/cordova-plugin-network-information/blob/master/README.md)
+
+resume
+
+
+
+
+
+
+
-- online
-- offline
+
+backbutton
+
+
+
+
+
+
+
+
+menubutton
+
+
+
+
+
+
+
+
+
+searchbutton
+
+
+
+
+
+
+
+
+
+startcallbutton
+
+
+
+
+
+
+
+
+
+endcallbutton
+
+
+
+
+
+
+
+
+
+volumedownbutton
+
+
+
+
+
+
+
+
+
+volumeupbutton
+
+
+
+
+
+
+
+
+
+
+
+
+
+**Note**: Applications typically should use `document.addEventListener` to
+attach an event listener once the [deviceready](#link-deviceready)
+event fires.
+
+## deviceready
+
+The deviceready event fires when Cordova is fully loaded. This event is
+essential to any application. It signals that Cordova's device APIs have
+loaded and are ready to access.
+
+Cordova consists of two code bases: native and JavaScript. While the
+native code loads, a custom loading image displays. However,
+JavaScript only loads once the DOM loads. This means the web app may
+potentially call a Cordova JavaScript function before the
+corresponding native code becomes available.
+
+The `deviceready` event fires once Cordova has fully loaded. Once the
+event fires, you can safely make calls to Cordova APIs. Applications
+typically attach an event listener with `document.addEventListener`
+once the HTML document's DOM has loaded.
+
+The `deviceready` event behaves somewhat differently from others. Any
+event handler registered after the `deviceready` event fires has its
+callback function called immediately.
+
+### Quick Example
+
+document.addEventListener("deviceready", onDeviceReady, false);
+
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+### Full Example
+
+**Note**: For the sake of readability, all the other events assume that
you use the
+below html code.
+
+ HTML File
+
+
+
+
+Device Ready Example
+
+
+
+
+
+
+
+
+ JS File
+// example.js file
+// Wait for device API libraries to load
+//
+function onLoad() {
+document.addEventListener("deviceready", onDeviceReady, false);
+}
+
+// device APIs are available
+//
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+## pause
+
+The pause event fires when an application is put into the backg
[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178865169 Yep, that sounds fine. I would even say not to worry about it if you want to leave it as it is: on the CI environment we have only one simulator/device anyway. Also having the `--target` flag fixes this problem outright. I'm cool with either one: leaving it as is, having the `--target` flag, or just picking the last one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51646921
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
+
-## Event Types
+
-- [deviceready](events.deviceready.html)
-- [pause](events.pause.html)
-- [resume](events.resume.html)
-- [backbutton](events.backbutton.html)
-- [menubutton](events.menubutton.html)
-- [searchbutton](events.searchbutton.html)
-- [startcallbutton](events.startcallbutton.html)
-- [endcallbutton](events.endcallbutton.html)
-- [volumedownbutton](events.volumedownbutton.html)
-- [volumeupbutton](events.volumeupbutton.html)
+
+
+Supported Platforms/Events
+amazon-fireos
+android
+blackberry10
+ios
+Windows Phone 8
+Windows
+
+
-## Events added by
[cordova-plugin-battery-status](https://github.com/apache/cordova-plugin-battery-status/blob/master/README.md)
+
+
+deviceready
+
+
+
+
+
+
+
-- batterycritical
-- batterylow
-- batterystatus
+
+pause
+
+
+
+
+
+
+
-## Events added by
[cordova-plugin-network-information](https://github.com/apache/cordova-plugin-network-information/blob/master/README.md)
+
+resume
+
+
+
+
+
+
+
-- online
-- offline
+
+backbutton
+
+
+
+
+
+
+
+
+menubutton
+
+
+
+
+
+
+
+
+
+searchbutton
+
+
+
+
+
+
+
+
+
+startcallbutton
+
+
+
+
+
+
+
+
+
+endcallbutton
+
+
+
+
+
+
+
+
+
+volumedownbutton
+
+
+
+
+
+
+
+
+
+volumeupbutton
+
+
+
+
+
+
+
+
+
+
+
+
+
+**Note**: Applications typically should use `document.addEventListener` to
+attach an event listener once the [deviceready](#link-deviceready)
+event fires.
+
+## deviceready
+
+The deviceready event fires when Cordova is fully loaded. This event is
+essential to any application. It signals that Cordova's device APIs have
+loaded and are ready to access.
+
+Cordova consists of two code bases: native and JavaScript. While the
+native code loads, a custom loading image displays. However,
+JavaScript only loads once the DOM loads. This means the web app may
+potentially call a Cordova JavaScript function before the
+corresponding native code becomes available.
+
+The `deviceready` event fires once Cordova has fully loaded. Once the
+event fires, you can safely make calls to Cordova APIs. Applications
+typically attach an event listener with `document.addEventListener`
+once the HTML document's DOM has loaded.
+
+The `deviceready` event behaves somewhat differently from others. Any
+event handler registered after the `deviceready` event fires has its
+callback function called immediately.
+
+### Quick Example
+
+document.addEventListener("deviceready", onDeviceReady, false);
+
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+### Full Example
+
+**Note**: For the sake of readability, all the other events assume that
you use the
+below html code.
+
+ HTML File
+
+
+
+
+Device Ready Example
+
+
+
+
+
+
+
+
+ JS File
+// example.js file
+// Wait for device API libraries to load
+//
+function onLoad() {
+document.addEventListener("deviceready", onDeviceReady, false);
+}
+
+// device APIs are available
+//
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+## pause
+
+The pause event fires when an application is put into the backgro
[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178861517 Is this a part of our external API? If not, then why should there be a way to get them without the debugger if it's an internal feature? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51646371
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
+
-## Event Types
+
-- [deviceready](events.deviceready.html)
-- [pause](events.pause.html)
-- [resume](events.resume.html)
-- [backbutton](events.backbutton.html)
-- [menubutton](events.menubutton.html)
-- [searchbutton](events.searchbutton.html)
-- [startcallbutton](events.startcallbutton.html)
-- [endcallbutton](events.endcallbutton.html)
-- [volumedownbutton](events.volumedownbutton.html)
-- [volumeupbutton](events.volumeupbutton.html)
+
+
+Supported Platforms/Events
+amazon-fireos
+android
+blackberry10
+ios
+Windows Phone 8
+Windows
+
+
-## Events added by
[cordova-plugin-battery-status](https://github.com/apache/cordova-plugin-battery-status/blob/master/README.md)
+
+
+deviceready
+
+
+
+
+
+
+
-- batterycritical
-- batterylow
-- batterystatus
+
+pause
+
+
+
+
+
+
+
-## Events added by
[cordova-plugin-network-information](https://github.com/apache/cordova-plugin-network-information/blob/master/README.md)
+
+resume
+
+
+
+
+
+
+
-- online
-- offline
+
+backbutton
+
+
+
+
+
+
+
+
+menubutton
+
+
+
+
+
+
+
+
+
+searchbutton
+
+
+
+
+
+
+
+
+
+startcallbutton
+
+
+
+
+
+
+
+
+
+endcallbutton
+
+
+
+
+
+
+
+
+
+volumedownbutton
+
+
+
+
+
+
+
+
+
+volumeupbutton
+
+
+
+
+
+
+
+
+
+
+
+
+
+**Note**: Applications typically should use `document.addEventListener` to
+attach an event listener once the [deviceready](#link-deviceready)
+event fires.
+
+## deviceready
+
+The deviceready event fires when Cordova is fully loaded. This event is
+essential to any application. It signals that Cordova's device APIs have
+loaded and are ready to access.
+
+Cordova consists of two code bases: native and JavaScript. While the
+native code loads, a custom loading image displays. However,
+JavaScript only loads once the DOM loads. This means the web app may
+potentially call a Cordova JavaScript function before the
+corresponding native code becomes available.
+
+The `deviceready` event fires once Cordova has fully loaded. Once the
+event fires, you can safely make calls to Cordova APIs. Applications
+typically attach an event listener with `document.addEventListener`
+once the HTML document's DOM has loaded.
+
+The `deviceready` event behaves somewhat differently from others. Any
+event handler registered after the `deviceready` event fires has its
+callback function called immediately.
+
+### Quick Example
+
+document.addEventListener("deviceready", onDeviceReady, false);
+
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+### Full Example
+
+**Note**: For the sake of readability, all the other events assume that
you use the
+below html code.
+
+ HTML File
+
+
+
+
+Device Ready Example
+
+
+
+
+
+
+
+
+ JS File
+// example.js file
+// Wait for device API libraries to load
+//
+function onLoad() {
+document.addEventListener("deviceready", onDeviceReady, false);
+}
+
+// device APIs are available
+//
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+## pause
+
+The pause event fires when an application is put into the backg
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/480#discussion_r51646137
--- Diff: www/docs/en/dev/cordova/events/events.md ---
@@ -22,29 +22,561 @@ title: Events
# Events
-> Cordova lifecycle events.
+
-## Event Types
+
-- [deviceready](events.deviceready.html)
-- [pause](events.pause.html)
-- [resume](events.resume.html)
-- [backbutton](events.backbutton.html)
-- [menubutton](events.menubutton.html)
-- [searchbutton](events.searchbutton.html)
-- [startcallbutton](events.startcallbutton.html)
-- [endcallbutton](events.endcallbutton.html)
-- [volumedownbutton](events.volumedownbutton.html)
-- [volumeupbutton](events.volumeupbutton.html)
+
+
+Supported Platforms/Events
+amazon-fireos
+android
+blackberry10
+ios
+Windows Phone 8
+Windows
+
+
-## Events added by
[cordova-plugin-battery-status](https://github.com/apache/cordova-plugin-battery-status/blob/master/README.md)
+
+
+deviceready
+
+
+
+
+
+
+
-- batterycritical
-- batterylow
-- batterystatus
+
+pause
+
+
+
+
+
+
+
-## Events added by
[cordova-plugin-network-information](https://github.com/apache/cordova-plugin-network-information/blob/master/README.md)
+
+resume
+
+
+
+
+
+
+
-- online
-- offline
+
+backbutton
+
+
+
+
+
+
+
+
+menubutton
+
+
+
+
+
+
+
+
+
+searchbutton
+
+
+
+
+
+
+
+
+
+startcallbutton
+
+
+
+
+
+
+
+
+
+endcallbutton
+
+
+
+
+
+
+
+
+
+volumedownbutton
+
+
+
+
+
+
+
+
+
+volumeupbutton
+
+
+
+
+
+
+
+
+
+
+
+
+
+**Note**: Applications typically should use `document.addEventListener` to
+attach an event listener once the [deviceready](#link-deviceready)
+event fires.
+
+## deviceready
+
+The deviceready event fires when Cordova is fully loaded. This event is
+essential to any application. It signals that Cordova's device APIs have
+loaded and are ready to access.
+
+Cordova consists of two code bases: native and JavaScript. While the
+native code loads, a custom loading image displays. However,
+JavaScript only loads once the DOM loads. This means the web app may
+potentially call a Cordova JavaScript function before the
+corresponding native code becomes available.
+
+The `deviceready` event fires once Cordova has fully loaded. Once the
+event fires, you can safely make calls to Cordova APIs. Applications
+typically attach an event listener with `document.addEventListener`
+once the HTML document's DOM has loaded.
+
+The `deviceready` event behaves somewhat differently from others. Any
+event handler registered after the `deviceready` event fires has its
+callback function called immediately.
+
+### Quick Example
+
+document.addEventListener("deviceready", onDeviceReady, false);
+
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+### Full Example
+
+**Note**: For the sake of readability, all the other events assume that
you use the
+below html code.
+
+ HTML File
+
+
+
+
+Device Ready Example
+
+
+
+
+
+
+
+
+ JS File
+// example.js file
+// Wait for device API libraries to load
+//
+function onLoad() {
+document.addEventListener("deviceready", onDeviceReady, false);
+}
+
+// device APIs are available
+//
+function onDeviceReady() {
+// Now safe to use device APIs
+}
+
+## pause
+
+The pause event fires when an application is put into the backgro
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178857041 @riknoll Added link to Android Life Cycle Guide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51643532 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178850170 @dblotsky Yes. We have seen the timeouts 4 times last week. I was able to connect to the VM (and get the same results) right at the same time it was failing in the CI. So, this is added as an additional step to ensure that if the system is not able to connect, it tries again after waiting for 15 seconds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51643217 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/74#discussion_r51643160
--- Diff: lib/testcheck.js ---
@@ -21,22 +21,40 @@
"use strict";
-module.exports = function (sha, dbHost) {
+module.exports = function (sha, dbHost, maxnumberoftries, delay) {
var http = require("http"),
url = require("url"),
q = require("q");
+function tryConnect(options, d, pendingnumberoftries, operation,
successCallBack){
+http.get(options, successCallBack)
+.on("error", function(e){
+if(pendingnumberoftries > 1){
+console.log("Connection attempt to " + operation + "
failed. Will try after: " + delay + " milliseconds.");
--- End diff --
@nikhilkh Logged the e.message and moved the log to use util.medicLog
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51643080 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642981 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example: app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - - -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: - -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. - - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. - -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. - -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. - -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. - -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. - -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. - -### Additional Versioning +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id (string) | *Required: true* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version (string) | *Required: true* Full version number expressed in major/minor/patch notation. + versionCode (string) | *Required: false* **Platforms supported: Android** Alternative version for Android. + CFBundleVersion (string) | *Required: false* **Platforms supported: iOS** Alternative version for iOS. + packageVersion (string) | *Required: false* **Platforms supported: Windows** Alternative version for Windows. + packageName (string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns (string) | *Required: true* namespace for the config.xml document. + xmlns:cdv (string) | *Required: true* namespace prefix. + + Examples: -Android, iOS, and Windows support a second version string (or number) in -addition to the one visible in app stores: + + -- [versionCode](http://developer.android.com/tools/publishing/versioning.html) - for Android -- [CFBundleVersion](http://stackoverflow.com/questions/4933093/cfbundleversion-in-the-info-plist-upload-error) - for iOS -- [packageVersion](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx) - for Windows + + -Below is an example that explicitly sets these properties: + + +
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642666 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. --- End diff -- "reverse-domain identifier" should be "npm-style identifier" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642563 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642289 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642241 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178844879 Resume event should add an Android quirk that points to this page: http://cordova.apache.org/docs/en/dev/guide/platforms/android/lifecycle.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/480 CB-10351: Make Events page a reference Made the Events page a reference @nikhilkh @dblotsky @rakatyal @riknoll @omefire Can you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-docs CB-10351 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #480 commit 3cb84cff15ccb52797bdd89af036e8a6963d00d3 Author: Sarangan Rajamanickam Date: 2016-02-02T21:31:23Z CB-10351: Make Events page a reference Made the Events page a reference --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51638568 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51638474 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + + - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. + + + -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. + + + -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. +## name + Specifies the app's formal name, as it appears on the device's home screen and within app-store interfaces. -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. + Examples: -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. + +HelloCordova + + +## descriptio
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51638042 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. --- End diff -- It will be great to Apple docs here: https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51637888 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. + CFBundleVersion(string) | **Platforms supported: iOS** Alternative version for iOS. + packageVersion(string) | **Platforms supported: Windows** Alternative version for Windows. + packageName(string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns(string) | *Required* Namespace for the config.xml document. + xmlns:cdv(string) | *Required* Namespace prefix. + + Examples: -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: +http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> + -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. + + --- End diff -- Needs to be an integer as far as I understand. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51637838 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`, and that having it here is still supported. When using the CLI to build a project, versions of this file are -passively copied into various `platforms/` subdirectories, for example: +passively copied into various `platforms/` subdirectories. +For example: app/platforms/ios/AppName/config.xml app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id(string) | *Required* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version(string) | *Required* Full version number expressed in major/minor/patch notation. + versionCode(string) | **Platforms supported: Android** Alternative version for Android. --- End diff -- `versionCode` it will be great to link to Android docs here: http://developer.android.com/tools/publishing/versioning.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/463#issuecomment-178829332 @omefire I noticed you merged this without squashing - please do that in the future it helps with maintaining a meaningful history on git. https://github.com/apache/cordova-coho/blob/master/docs/committer-workflow.md has more details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: chore: edit package.json licen...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/463 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-178816734 +1 Windows 8.0 has been deprecated since Apr 13, 2015, let's cleanup so we can provide better focus. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51631675 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example: app/platforms/blackberry10/www/config.xml --- End diff -- +1, done ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51631119 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example: app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - - -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: - -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. - - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. - -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. - -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. - -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. - -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. - -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. - -### Additional Versioning +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id (string) | *Required: true* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version (string) | *Required: true* Full version number expressed in major/minor/patch notation. + versionCode (string) | *Required: false* **Platforms supported: Android** Alternative version for Android. + CFBundleVersion (string) | *Required: false* **Platforms supported: iOS** Alternative version for iOS. + packageVersion (string) | *Required: false* **Platforms supported: Windows** Alternative version for Windows. + packageName (string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns (string) | *Required: true* namespace for the config.xml document. + xmlns:cdv (string) | *Required: true* namespace prefix. + + Examples: -Android, iOS, and Windows support a second version string (or number) in -addition to the one visible in app stores: + + -- [versionCode](http://developer.android.com/tools/publishing/versioning.html) - for Android -- [CFBundleVersion](http://stackoverflow.com/questions/4933093/cfbundleversion-in-the-info-plist-upload-error) - for iOS -- [packageVersion](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx) - for Windows + + -Below is an example that explicitly sets these properties: + + +
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51630971 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -22,8 +22,8 @@ title: The config.xml File # The config.xml File --- End diff -- +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51630990 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example: app/platforms/blackberry10/www/config.xml app/platforms/android/res/xml/config.xml -This section details global and cross-platform configuration options. -See the following sections for platform-specific options: - -- [iOS Configuration](../guide/platforms/ios/config.html) -- [Android Configuration](../guide/platforms/android/config.html) -- [BlackBerry 10 Configuration](../guide/platforms/blackberry10/config.html) - In addition to the various configuration options detailed below, you can also configure an application's core set of images for each target platform. See [Icons and Splash Screens](images.html) for more information. -## Core Configuration Elements - -This example shows the default `config.xml` generated by the CLI's -`create` command, described in [The Command-Line Interface](../guide/cli/index.html): - - -HelloWorld - -A sample Apache Cordova application that responds to the deviceready event. - -http://cordova.io";> -Apache Cordova Team - - - - - -The following configuration elements appear in the top-level -`config.xml` file, and are supported across all supported Cordova -platforms: - -- The `` element's `id` attribute provides the app's - reverse-domain identifier, and the `version` its full version number - expressed in major/minor/patch notation. - - The widget tag can also have attributes that specify alternative versions, - namely `versionCode` for Android, `CFBundleVersion` for iOS, and - `packageVersion` for Windows. See the Additional Versioning section below - for details. - -- The `` element specifies the app's formal name, as it appears - on the device's home screen and within app-store interfaces. - -- The `` and `` elements specify metadata and - contact information that may appear within app-store listings. - -- The optional `` element defines the app's starting - page in the top-level web assets directory. The default value is - `index.html`, which customarily appears in a project's top-level - `www` directory. - -- `` elements define the set of external domains the app is - allowed to communicate with. The default value shown above allows - it to access any server. See the Domain [Whitelist Guide](../guide/appdev/whitelist/index.html) for details. - -- The `` tag sets various options as pairs of - `name`/`value` attributes. Each preference's `name` is - case-insensitive. Many preferences are unique to specific - platforms, as listed at the top of this page. The following sections - detail preferences that apply to more than one platform. - -### Additional Versioning +# widget + Root element of the config.xml document. + + Attributes(type) | Description + | + id (string) | *Required: true* Specifies the app's reverse-domain identifier, and the `version` its full version number expressed in major/minor/patch notation. + version (string) | *Required: true* Full version number expressed in major/minor/patch notation. + versionCode (string) | *Required: false* **Platforms supported: Android** Alternative version for Android. + CFBundleVersion (string) | *Required: false* **Platforms supported: iOS** Alternative version for iOS. + packageVersion (string) | *Required: false* **Platforms supported: Windows** Alternative version for Windows. + packageName (string) | *Default: Cordova.Example* **Platforms supported: Windows** Package name for Windows. + xmlns (string) | *Required: true* namespace for the config.xml document. + xmlns:cdv (string) | *Required: true* namespace prefix. + + Examples: -Android, iOS, and Windows support a second version string (or number) in -addition to the one visible in app stores: + --- End diff -- +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For add
[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178801188 @dblotsky I don't think there is an easy way to get the running simulator, so instead I am going to move the simulator choosing logic from `cordova run` to medic and pass the `--target` flag. I'll probably just do the same thing as above, which is choosing the last iPhone that appears in the list of devices. They list in order (with newest devices appearing at the bottom), so this method will end up choosing iPhone-6s-plus for now. I'll copy the same function in medic-run.js and medic-log.js to ensure they choose the same thing. Is that alright with you? It works for CI, but it will fail on a user's machine if they manually started another simulator (which shouldn't be a big deal, won't come up on buildbot). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/463#issuecomment-178799405 I'm fine with using "Required" instead of "Required: true", as long as other docs get updated to use this convention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: generates a workspace instead of subproj...
Github user yjukaku commented on the pull request: https://github.com/apache/cordova-ios/pull/104#issuecomment-178796116 @edewit Can you please clarify what you mean? To be able to use CocoaPods, we still need a workspace to be generated instead of a project with a sub-project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/479#issuecomment-178764725 @riknoll Fixed the spacing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/479#discussion_r51617878 --- Diff: _config.yml --- @@ -9,6 +9,7 @@ title: Apache Cordova title_suffix: "Apache Cordova" url:"https://cordova.apache.org"; # the base hostname & protocol baseurl:"" # the subpath of the site, e.g. /blog; NOTE: no trailing slash +docsversion: "latest" --- End diff -- Whitespace is weird here. Otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/479 CB-10503: Documentation link points to 'latest' version even in latest buils Fixed the link to point to dev version of the docs in development @dblotsky @riknoll @rakatyal @nikhilkh Can you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-docs CB-10503 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit 9c8f9b999ce13c8615e8b80929c331bf9ec41786 Author: Sarangan Rajamanickam Date: 2016-02-02T19:02:31Z CB-10503: Documentation link points to 'latest' version even in latest build Fixed the link to point to dev version of the docs in development --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-lib/pull/368#issuecomment-178759702 @vladimir-kotikov Can you please review and merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-lib/pull/368#issuecomment-178758457 @riknoll Can you merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/478 CB-10481 Update the docs according to windows8 deprecation [Jira issue](https://issues.apache.org/jira/browse/CB-10481) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-10481 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10497 Prefer .bat over .cmd on window...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10497 Prefer .bat over .cmd on window...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/371#issuecomment-178623860 Tested this, and it seems to work fine. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )
Thanks for testing. Did you try with my index.html? do the red boxes always appeared on the app corners? CB-10288 is about webview not resizing correctly in multitasking screens (Split View - Slide Over) 2016-02-02 3:15 GMT+01:00 Carlos Santana : > Julio I tested on my iPad Air 2 used ios@4.0.1 the buttons show up, > buttons > work, I can do splitview no crashes > > > On Mon, Feb 1, 2016 at 10:36 AM julio cesar sanchez < > jcesarmob...@gmail.com> > wrote: > > > cordova should support launch storyboards > > https://issues.apache.org/jira/browse/CB-7521 > > https://issues.apache.org/jira/browse/CB-9161 > > > > and "Requires full Screen" should be configurable, right now is set to > true > > (this is the JIRA item that set it to true > > https://issues.apache.org/jira/browse/CB-9690, AFAIK, there nos issue > for > > making it configurable ) > > > > > > > > 2016-02-01 15:07 GMT+01:00 Carlos Santana : > > > > > I have an iPad that supports multitasking but it's at home, I can test > it > > > tonight if no one else have gotten to it first > > > > > > You said "cordova doesn't officially support multitasking yet" Do you > > have > > > a JIRA item describing what would be necessary to have support? > > > > > > > > > On Sun, Jan 31, 2016 at 5:15 PM julio cesar sanchez < > > > jcesarmob...@gmail.com> > > > wrote: > > > > > > > I'm trying to fix https://issues.apache.org/jira/browse/CB-10288 > > > > > > > > I've tested on simulators and seems to work fine, but I don't have > any > > > real > > > > iPad with multitasking support to test. > > > > > > > > As cordova doesn't officially support multitasking yet, you have to > > > follow > > > > these steps to add the support. > > > > > > > > On an empty project with ios platform (tested on cordova ios 3.9.2, > > but I > > > > think it should work on 4) > > > > > > > > Add all orientatios > > > > > > > > > > > > add my commit of statusbar plugin > > > > > > > > cordova plugin add > > > > https://github.com/jcesarmobile/cordova-plugin-statusbar#578fa1b > > > > > > > > Open the xcode project and create a new "Launch Screen" file > > > > On the target "General" screen, set the file as "Launch Screen File" > > and > > > > uncheck "Requires full screen" > > > > > > > > I use this as the index.html but you can use your own > > > > https://gist.github.com/jcesarmobile/114fdb8b771837440752 > > > > > > > > > >
RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos
+1 - I would start from identifying weak places - important functionality/methods which are not covered or coverage is low. This is not just one magic coverage number - this is about what functionality is covered and what is not. -Sergey -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Tuesday, February 2, 2016 4:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos +1 This is cool tech to add to our project It shows more transparency which for me I'm all in !! It should make it easier when troubleshooting or fixing bugs, it goes one step forward from adding a test when a bug is found Also seeing how a PR affects coverage interesting info to see sometimes. Like Steve said don't go mad and kill your self looking trying reach 100% for the repo, use it in a way that make sense. On Tue, Feb 2, 2016 at 7:34 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > This is not only about visualization. > Codecov also stores previous result and performs an analysis, how > coverage has changed. Take a look at the comment, made by codecov bot at the > PR: > https://github.com/vladimir-kotikov/cordova-lib/pull/2 > > - > Best regards, Vladimir > > -Original Message- > From: Dmitry Blotsky [mailto:dblot...@microsoft.com] > Sent: Tuesday, February 2, 2016 2:59 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Enabling coverage reports collection and > analysis for cordova repos > > Is this basically just adding a UI then? > > Kindly, > Dmitry > > > On Feb 1, 2016, at 11:48 PM, Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > >> What is the impact to our workflow? are we just adding a node > dependency, or are there other config/integration parts that we need to do? > > The only thing, required from our side is to replace `npm test` (or > > the > command, that executes jasmine tests) witn `npm run cover` in Travis > configuration (the coverage reports are already enabled for the most > important repos). However, some help from infra side is required to > setup Github <-> > https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=01% > 7c01%7cdblotsky%40microsoft.com%7c92d8918c69a6441a775608d32ba557d4%7c7 > 2f988bf86f141af91ab2d7cd011db47%7c1&sdata=chjekNYEfx%2bpdSQBbcGVAYm5A3 > 8fPv%2fBfy1iDTyUau4%3d > integration. > > > >> You are using istanbul for code coverage it seems. > > Yup. > > > >> Why did you remove spec-cordova in your pr? Your [2] > > Only for demo purposes. I wanted to see how it will look like :) > > > >> I think it is a great idea to include this in our repos. It would > >> be > nice to track our coverage and work on improving it. > >> Though I do believe it is important not to chase 100% code coverage. > > Agree here, 100 % coverage is not the goal, We can just reach an > agreement on a minimal appropriate value and try to not to drop > coverage below this bar. > > > > - > > Best regards, Vladimir > > > > > > -Original Message- > > From: Jesse [mailto:purplecabb...@gmail.com] > > Sent: Tuesday, February 2, 2016 2:22 AM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] Enabling coverage reports collection and > > analysis for cordova repos > > > > This looks good, as a metric to add. > > What is the impact to our workflow? are we just adding a node > dependency, or are there other config/integration parts that we need to do? > > > > > > > > > > @purplecabbage > > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data= > > 01 > > %7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d3 > > 2b > > 5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=1SLJ4U2YHSQpiukr > > Yi > > pGlq7uBfl4uQNHxSE8q1JspDQ%3d > > > > On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill > wrote: > > > >> Hey Vlad! > >> > >> This looks great! You are using istanbul for code coverage it seems. > >> > >> Why did you remove spec-cordova in your pr? Your [2] > >> > >> I think it is a great idea to include this in our repos. It would > >> be nice to track our coverage and work on improving it. > >> > >> Though I do believe it is important not to chase 100% code coverage. > >> > >> > >> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < > >> v-vlk...@microsoft.com> wrote: > >> > >>> Hey, guys > >>> > >>> I've spent a couple of hours and have a prototype of how we can > >> visualize, > >>> track and analyze code coverage for our repos. > >>> Here is the fork of cordova-lib repo integrated with > >>> https://na01.safelinks.protection.outlook.com/?url=codecov.io&data > >>> =0 > >>> 1%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac80 > >>> 8d > >>> 32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0oRS0Omv1Ba > >>> c3 OVYlTyT08ENLSP15s1%2fw%2fvXxcO39ZA%3d [1] (notice the coverage > >>> badge at the top of README), and a PR with some coverage metrics > >>> [2]. The coverage summary is placed he
Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos
+1 This is cool tech to add to our project It shows more transparency which for me I'm all in !! It should make it easier when troubleshooting or fixing bugs, it goes one step forward from adding a test when a bug is found Also seeing how a PR affects coverage interesting info to see sometimes. Like Steve said don't go mad and kill your self looking trying reach 100% for the repo, use it in a way that make sense. On Tue, Feb 2, 2016 at 7:34 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > This is not only about visualization. > Codecov also stores previous result and performs an analysis, how coverage > has changed. Take a look at the comment, made by codecov bot at the PR: > https://github.com/vladimir-kotikov/cordova-lib/pull/2 > > - > Best regards, Vladimir > > -Original Message- > From: Dmitry Blotsky [mailto:dblot...@microsoft.com] > Sent: Tuesday, February 2, 2016 2:59 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis > for cordova repos > > Is this basically just adding a UI then? > > Kindly, > Dmitry > > > On Feb 1, 2016, at 11:48 PM, Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > >> What is the impact to our workflow? are we just adding a node > dependency, or are there other config/integration parts that we need to do? > > The only thing, required from our side is to replace `npm test` (or the > command, that executes jasmine tests) witn `npm run cover` in Travis > configuration (the coverage reports are already enabled for the most > important repos). However, some help from infra side is required to setup > Github <-> > https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=01%7c01%7cdblotsky%40microsoft.com%7c92d8918c69a6441a775608d32ba557d4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=chjekNYEfx%2bpdSQBbcGVAYm5A38fPv%2fBfy1iDTyUau4%3d > integration. > > > >> You are using istanbul for code coverage it seems. > > Yup. > > > >> Why did you remove spec-cordova in your pr? Your [2] > > Only for demo purposes. I wanted to see how it will look like :) > > > >> I think it is a great idea to include this in our repos. It would be > nice to track our coverage and work on improving it. > >> Though I do believe it is important not to chase 100% code coverage. > > Agree here, 100 % coverage is not the goal, We can just reach an > agreement on a minimal appropriate value and try to not to drop coverage > below this bar. > > > > - > > Best regards, Vladimir > > > > > > -Original Message- > > From: Jesse [mailto:purplecabb...@gmail.com] > > Sent: Tuesday, February 2, 2016 2:22 AM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] Enabling coverage reports collection and > > analysis for cordova repos > > > > This looks good, as a metric to add. > > What is the impact to our workflow? are we just adding a node > dependency, or are there other config/integration parts that we need to do? > > > > > > > > > > @purplecabbage > > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01 > > %7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b > > 5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=1SLJ4U2YHSQpiukrYi > > pGlq7uBfl4uQNHxSE8q1JspDQ%3d > > > > On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill > wrote: > > > >> Hey Vlad! > >> > >> This looks great! You are using istanbul for code coverage it seems. > >> > >> Why did you remove spec-cordova in your pr? Your [2] > >> > >> I think it is a great idea to include this in our repos. It would be > >> nice to track our coverage and work on improving it. > >> > >> Though I do believe it is important not to chase 100% code coverage. > >> > >> > >> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < > >> v-vlk...@microsoft.com> wrote: > >> > >>> Hey, guys > >>> > >>> I've spent a couple of hours and have a prototype of how we can > >> visualize, > >>> track and analyze code coverage for our repos. > >>> Here is the fork of cordova-lib repo integrated with > >>> https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=0 > >>> 1%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d > >>> 32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0oRS0Omv1Bac3 > >>> OVYlTyT08ENLSP15s1%2fw%2fvXxcO39ZA%3d [1] (notice the coverage badge > >>> at the top of README), and a PR with some coverage metrics [2]. The > >>> coverage summary is placed here [3] > >>> > >>> If this proposal get accepted, I'd like to enable this feature for > >>> all > >> our > >>> repos, to encourage contributors to increase current test coverage > >>> up to appropriate values. > >>> > >>> It'd be great if anyone could give any feedback on this > >>> > >>> [1] https://github.com/vladimir-kotikov/cordova-lib > >>> [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2 > >>> [3] > >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcod > >>> ecov.io%2fgithub%2fvladimir-kotikov%2fcordova-lib&data
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Github user davetayls commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178571365 Thanks Tim, looks good. Are you able to close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178564407 @dblotsky, is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178561020 Because we've been logging these events all the time before cordova refactoring. Many of these events doesn't have much value though, and could be safely ignored, but, for example, the command and arguments, used by superspawn are pretty important information IMO, and there should be a way to get it without using debugger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Multi-level ToC Implementation
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178555686 @vladimir-kotikov I guess my point is: why is it necessary for internal `cordova-common` events to reach platform code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Multi-level ToC Implementation
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/464#issuecomment-178554331 @nikhilkh Fixed. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178554295 @dblotsky, @purplecabbage, thanks for feedback. Agree, this probably smells fishy. However, the only one option i see apart from this one is to setup a proxy to transmit events from `cordova-common` to another `EventEmitter` instance (which was passed to `PlatformApi` constructor), when necessary. All other solutions, that came into my mind, break `events` API and hence require some global changes in cordova (as the `events` is used really widely). However, this PR doesn't change a public API for this and seems to fix the issue with missing events from `cordova-common` internals without affecting any other cases, so it might make sense to get this in as an intermediate fix and then start looking into redesigning cordova `events` mechanics. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos
This is not only about visualization. Codecov also stores previous result and performs an analysis, how coverage has changed. Take a look at the comment, made by codecov bot at the PR: https://github.com/vladimir-kotikov/cordova-lib/pull/2 - Best regards, Vladimir -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Tuesday, February 2, 2016 2:59 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos Is this basically just adding a UI then? Kindly, Dmitry > On Feb 1, 2016, at 11:48 PM, Vladimir Kotikov (Akvelon) > wrote: > >> What is the impact to our workflow? are we just adding a node dependency, or >> are there other config/integration parts that we need to do? > The only thing, required from our side is to replace `npm test` (or the > command, that executes jasmine tests) witn `npm run cover` in Travis > configuration (the coverage reports are already enabled for the most > important repos). However, some help from infra side is required to setup > Github <-> > https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=01%7c01%7cdblotsky%40microsoft.com%7c92d8918c69a6441a775608d32ba557d4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=chjekNYEfx%2bpdSQBbcGVAYm5A38fPv%2fBfy1iDTyUau4%3d > integration. > >> You are using istanbul for code coverage it seems. > Yup. > >> Why did you remove spec-cordova in your pr? Your [2] > Only for demo purposes. I wanted to see how it will look like :) > >> I think it is a great idea to include this in our repos. It would be nice to >> track our coverage and work on improving it. >> Though I do believe it is important not to chase 100% code coverage. > Agree here, 100 % coverage is not the goal, We can just reach an agreement > on a minimal appropriate value and try to not to drop coverage below this bar. > > - > Best regards, Vladimir > > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Tuesday, February 2, 2016 2:22 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Enabling coverage reports collection and > analysis for cordova repos > > This looks good, as a metric to add. > What is the impact to our workflow? are we just adding a node dependency, or > are there other config/integration parts that we need to do? > > > > > @purplecabbage > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01 > %7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b > 5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=1SLJ4U2YHSQpiukrYi > pGlq7uBfl4uQNHxSE8q1JspDQ%3d > > On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill wrote: > >> Hey Vlad! >> >> This looks great! You are using istanbul for code coverage it seems. >> >> Why did you remove spec-cordova in your pr? Your [2] >> >> I think it is a great idea to include this in our repos. It would be >> nice to track our coverage and work on improving it. >> >> Though I do believe it is important not to chase 100% code coverage. >> >> >> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < >> v-vlk...@microsoft.com> wrote: >> >>> Hey, guys >>> >>> I've spent a couple of hours and have a prototype of how we can >> visualize, >>> track and analyze code coverage for our repos. >>> Here is the fork of cordova-lib repo integrated with >>> https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=0 >>> 1%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d >>> 32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0oRS0Omv1Bac3 >>> OVYlTyT08ENLSP15s1%2fw%2fvXxcO39ZA%3d [1] (notice the coverage badge >>> at the top of README), and a PR with some coverage metrics [2]. The >>> coverage summary is placed here [3] >>> >>> If this proposal get accepted, I'd like to enable this feature for >>> all >> our >>> repos, to encourage contributors to increase current test coverage >>> up to appropriate values. >>> >>> It'd be great if anyone could give any feedback on this >>> >>> [1] https://github.com/vladimir-kotikov/cordova-lib >>> [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2 >>> [3] >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcod >>> ecov.io%2fgithub%2fvladimir-kotikov%2fcordova-lib&data=01%7c01%7cv-v >>> lkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c >>> 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mtQlIC3U2lyzKA%2byFchr1zl >>> Yp9PuEUsFRH74kUaqLxg%3d >>> >>> - >>> Best regards, Vladimir >>> >>> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >>> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Cordova windows 4.3.1 release
I vote +1. * Verified archives via `coho verify-archive` * Verified tag manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core plugins (ran autotests) * Verified release notes * Verified version * Verified line breaks Thanks, Alexander Sorokin -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, February 2, 2016 4:31 AM To: dev@cordova.apache.org Subject: Re: [VOTE] Cordova windows 4.3.1 release +1 - ran coho audit-license-headers - ran coho check-license - ran coho verify-archive - created project and added/ran platform, smoke test @purplecabbage https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-alsoro%40microsoft.com%7c1444a653c28d4485995808d32b7083bb%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=DwZ3uTDNba3mg6v7jGU31SmA5TLx1xoSh54EdbSPDnQ%3d On Mon, Feb 1, 2016 at 12:46 PM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Please review and vote on this cordova-windows 4.3.1 release by > replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > s.apache.org%2fjira%2fbrowse%2fCB-10495&data=01%7c01%7cv-alsoro%40micr > osoft.com%7c1444a653c28d4485995808d32b7083bb%7c72f988bf86f141af91ab2d7 > cd011db47%7c1&sdata=tI6XiF%2fU7Q9MUSCZXxvkztlsT%2f%2fB4jW8uO0R7ADfFDo% > 3d The archive has been published to dist/dev: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist. > apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10495&data=01%7c01%7cv- > alsoro%40microsoft.com%7c1444a653c28d4485995808d32b7083bb%7c72f988bf86 > f141af91ab2d7cd011db47%7c1&sdata=umJVDNzv%2fPsxnVHom7tzqgQcP8xgZ%2bgv8 > yeHYMSbykM%3d > > The package was published from its corresponding git tag: > cordova-windows: 4.3.1 (7ce3444b2e) > > Note that you can test it out via: > cordova platform add > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-w > ip-us.apache.org%2frepos%2fasf%2fcordova-windows.git%234.3.1&data=01%7 > c01%7cv-alsoro%40microsoft.com%7c1444a653c28d4485995808d32b7083bb%7c72 > f988bf86f141af91ab2d7cd011db47%7c1&sdata=eF5DYkYHm7S4cZD6UNLJ%2fFguCVw > Sm8N2ucV73padpTQ%3d > > Upon a successful vote I will upload the archive to dist/, publish it > to npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Created and built mobilespec app to ensure all tests are passing > * Ensured continuous build was green when repo was tagged > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[VOTE] InAppBrowser Plugin Release
Please review and vote on the InAppBrowser plugin release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10505 The plugin has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10505/ The package were published from their corresponding git tag: cordova-plugin-inappbrowser: 1.2.1 (df94a6c157) Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Run auto tests for iOS, Android and Windows -Sergey - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos
Is this basically just adding a UI then? Kindly, Dmitry > On Feb 1, 2016, at 11:48 PM, Vladimir Kotikov (Akvelon) > wrote: > >> What is the impact to our workflow? are we just adding a node dependency, or >> are there other config/integration parts that we need to do? > The only thing, required from our side is to replace `npm test` (or the > command, that executes jasmine tests) witn `npm run cover` in Travis > configuration (the coverage reports are already enabled for the most > important repos). However, some help from infra side is required to setup > Github <-> > https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=01%7c01%7cdblotsky%40microsoft.com%7c92d8918c69a6441a775608d32ba557d4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=chjekNYEfx%2bpdSQBbcGVAYm5A38fPv%2fBfy1iDTyUau4%3d > integration. > >> You are using istanbul for code coverage it seems. > Yup. > >> Why did you remove spec-cordova in your pr? Your [2] > Only for demo purposes. I wanted to see how it will look like :) > >> I think it is a great idea to include this in our repos. It would be nice to >> track our coverage and work on improving it. >> Though I do believe it is important not to chase 100% code coverage. > Agree here, 100 % coverage is not the goal, We can just reach an agreement > on a minimal appropriate value and try to not to drop coverage below this bar. > > - > Best regards, Vladimir > > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Tuesday, February 2, 2016 2:22 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for > cordova repos > > This looks good, as a metric to add. > What is the impact to our workflow? are we just adding a node dependency, or > are there other config/integration parts that we need to do? > > > > > @purplecabbage > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=1SLJ4U2YHSQpiukrYipGlq7uBfl4uQNHxSE8q1JspDQ%3d > > On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill wrote: > >> Hey Vlad! >> >> This looks great! You are using istanbul for code coverage it seems. >> >> Why did you remove spec-cordova in your pr? Your [2] >> >> I think it is a great idea to include this in our repos. It would be >> nice to track our coverage and work on improving it. >> >> Though I do believe it is important not to chase 100% code coverage. >> >> >> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < >> v-vlk...@microsoft.com> wrote: >> >>> Hey, guys >>> >>> I've spent a couple of hours and have a prototype of how we can >> visualize, >>> track and analyze code coverage for our repos. >>> Here is the fork of cordova-lib repo integrated with >>> https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=0 >>> 1%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d >>> 32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0oRS0Omv1Bac3 >>> OVYlTyT08ENLSP15s1%2fw%2fvXxcO39ZA%3d [1] (notice the coverage badge >>> at the top of README), and a PR with some coverage metrics [2]. The >>> coverage summary is placed here [3] >>> >>> If this proposal get accepted, I'd like to enable this feature for >>> all >> our >>> repos, to encourage contributors to increase current test coverage >>> up to appropriate values. >>> >>> It'd be great if anyone could give any feedback on this >>> >>> [1] https://github.com/vladimir-kotikov/cordova-lib >>> [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2 >>> [3] >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcod >>> ecov.io%2fgithub%2fvladimir-kotikov%2fcordova-lib&data=01%7c01%7cv-v >>> lkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c >>> 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mtQlIC3U2lyzKA%2byFchr1zl >>> Yp9PuEUsFRH74kUaqLxg%3d >>> >>> - >>> Best regards, Vladimir >>> >>> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >>> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178526013 Ah, it seems like I'm the one that's confused. I didn't know that `progress` was a standard promise function. Returning `child` is what I meant, but that would basically require us to stop using promises. I see how this works now: please disregard my comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/477#issuecomment-178520738 @zhangkaizhao before we merge, please also add this to the Makefile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
