[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

2016-03-18 Thread daserge
Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/276#discussion_r56392123
  
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget, 
buildResults) {
 if (err) reject(new CordovaError('Error executing 
"' + command + '": ' + stderr));
 // adb does not return an error code even if 
installation fails. Instead it puts a specific
 // message to stdout, so we have to use RegExp 
matching to detect installation failure.
-else if (/Failure/.test(stdout)) reject(new 
CordovaError('Failed to install apk to emulator: ' + stdout));
-else resolve(stdout);
+else if (/Failure/.test(stdout)) {
+if 
(stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) {
+stdout += 'Sign the build using \'-- 
--keystore\' or \'--buildConfig\'' +
+' or sign and deploy the unsigned apk 
manually using Android tools.';
+}
+
+reject(new CordovaError('Failed to install apk 
to emulator: ' + stdout));
+} else resolve(stdout);
--- End diff --

I agree but this should be probably done along with error codes/messages 
introducing task (can't find Jira for it; dev list thread: 
http://apache.markmail.org/thread/qsyocgri3zq6nkrh).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Does Cordova have a problem making developers happy?

2016-03-18 Thread Joe Bowser
BTW: The last one was a joke.  But in all honesty, we should all spend a
bit more time on Stack seeing what's going on there with our respective
products/distributions.

On Thu, Mar 17, 2016 at 5:43 PM, Joe Bowser  wrote:

>
>
> On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva 
> wrote:
>
>> Keep in mind that the answers are limited to the technologies that Stack
>> Overflow chooses to offer in their list of options. They have an "other"
>> option with a text box, but people's answers are largely driven by the
>> checkbox options.
>>
>>
> So, we somehow pissed off the Stack Overflow guys???
>
>
>
>>
>>
>> Ryan J. Salva  |  Principal PM Manager
>> Visual Studio Tools for Apache Cordova
>> rsa...@microsoft.com
>> 425 706 5270 office
>> 206 612 5079 mobile
>>
>> -Original Message-
>> From: Joe Bowser [mailto:bows...@gmail.com]
>> Sent: Thursday, March 17, 2016 5:21 PM
>> To: dev 
>> Subject: Re: Does Cordova have a problem making developers happy?
>>
>> On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva 
>> wrote:
>>
>> > As I told some of my co-workers today:
>> >
>> > If you read the fine print, the actual statistic is “% of developers
>> > who are developing with the language or tech but have not expressed
>> > interest in continuing to do so.” Clearly, it’s not a good list to be
>> > on, but developer behavior also doesn’t reflect their stated intent.
>> > NPM Stats show the number of Cordova downloads has actually doubled
>> > since the same time last year.
>> >
>> > Again, I don’t think this is a good list to appear on… I’m just not
>> > sure what to make of it given developer behavior.
>> >
>>
>> I'd rather be on that list instead of not be on any list.  I'd be more
>> concerned with the fact that we're on the "Losers" section of the trending
>> tech with a 7% decrease in the number of questions, which indicate that
>> people either have no problems (not very likely) or are just giving up.  I
>> haven't been answering questions on Stack for a while, mostly because
>> they're using some third party framework like ionic or something else.
>>
>> I also find it interesting that people are hating on Cordova, and not
>> PhoneGap, Ionic, Taco or the other distributions.
>>
>>
>> >
>> >
>> > Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache
>> > Cordova rsa...@microsoft.com
>> > 425 706 5270 office
>> > 206 612 5079 mobile
>> >
>> > -Original Message-
>> > From: Joe Bowser [mailto:bows...@gmail.com]
>> > Sent: Thursday, March 17, 2016 5:08 PM
>> > To: dev 
>> > Subject: Re: Does Cordova have a problem making developers happy?
>> >
>> > On Thu, Mar 17, 2016 at 5:03 PM, Jesse  wrote:
>> >
>> > > Never trust people's answers when you ask them what they like! They
>> > > are almost always wrong, and will tell you what they think they
>> > > like, or think they will seem cooler if they liked.
>> > >
>> > >
>> > +1
>> >
>> > It's interesting that CoffeeScript is on this list and that it passed
>> > Cordova in most dreaded.  I also wonder what would happen if we went
>> > on the WordPress mailing list and talked about how people were so
>> > unhappy with WordPress.
>> >
>> >
>> > >
>> > > > On Mar 17, 2016, at 5:04 AM, julio cesar sanchez
>> > > > 
>> > > wrote:
>> > > >
>> > > > 2016 survey is out
>> > > >
>> > > > Most Dreaded technologies:
>> > > >
>> > > > Visual Basic79.5%
>> > > > WordPress  74.3%
>> > > > Matlab 72.8%
>> > > > Sharepoint  72.1%
>> > > > CoffeeScript71.0%
>> > > > LAMP  68.7%
>> > > > Cordova  66.9%
>> > > > Salesforce   65.4%
>> > > > Other   61.5%
>> > > > Perl 61.3%
>> > > > SQL Server & SQL 60.3%
>> > > > Objective-C 60.2%
>> > > >
>> > > >
>> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fsta
>> > > ck
>> > > overflow.com%2fresearch%2fdeveloper-survey-2016%23technology-most-lo
>> > > ve
>> > > d-dreaded-and-wanted&data=01%7c01%7crsalva%40microsoft.com%7c342aabb
>> > > 95
>> > > ca84607ba2608d34ec16bfe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata
>> > > =x SvTHrkLQ7Z4Z7CTctZ4rjFxaznfrPKVjqCkMzcUIpk%3d
>> > >
>> > > 
>> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > > For additional commands, e-mail: dev-h...@cordova.apache.org
>> > >
>> > >
>> >
>>
>
>


RE: Does Cordova have a problem making developers happy?

2016-03-18 Thread Ryan J. Salva
Keep in mind that the answers are limited to the technologies that Stack 
Overflow chooses to offer in their list of options. They have an "other" option 
with a text box, but people's answers are largely driven by the checkbox 
options.




Ryan J. Salva  |  Principal PM Manager
Visual Studio Tools for Apache Cordova
rsa...@microsoft.com
425 706 5270 office
206 612 5079 mobile

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, March 17, 2016 5:21 PM
To: dev 
Subject: Re: Does Cordova have a problem making developers happy?

On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva  wrote:

> As I told some of my co-workers today:
>
> If you read the fine print, the actual statistic is “% of developers 
> who are developing with the language or tech but have not expressed 
> interest in continuing to do so.” Clearly, it’s not a good list to be 
> on, but developer behavior also doesn’t reflect their stated intent. 
> NPM Stats show the number of Cordova downloads has actually doubled 
> since the same time last year.
>
> Again, I don’t think this is a good list to appear on… I’m just not 
> sure what to make of it given developer behavior.
>

I'd rather be on that list instead of not be on any list.  I'd be more 
concerned with the fact that we're on the "Losers" section of the trending tech 
with a 7% decrease in the number of questions, which indicate that people 
either have no problems (not very likely) or are just giving up.  I haven't 
been answering questions on Stack for a while, mostly because they're using 
some third party framework like ionic or something else.

I also find it interesting that people are hating on Cordova, and not PhoneGap, 
Ionic, Taco or the other distributions.


>
>
> Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache 
> Cordova rsa...@microsoft.com
> 425 706 5270 office
> 206 612 5079 mobile
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 17, 2016 5:08 PM
> To: dev 
> Subject: Re: Does Cordova have a problem making developers happy?
>
> On Thu, Mar 17, 2016 at 5:03 PM, Jesse  wrote:
>
> > Never trust people's answers when you ask them what they like! They 
> > are almost always wrong, and will tell you what they think they 
> > like, or think they will seem cooler if they liked.
> >
> >
> +1
>
> It's interesting that CoffeeScript is on this list and that it passed 
> Cordova in most dreaded.  I also wonder what would happen if we went 
> on the WordPress mailing list and talked about how people were so 
> unhappy with WordPress.
>
>
> >
> > > On Mar 17, 2016, at 5:04 AM, julio cesar sanchez 
> > > 
> > wrote:
> > >
> > > 2016 survey is out
> > >
> > > Most Dreaded technologies:
> > >
> > > Visual Basic79.5%
> > > WordPress  74.3%
> > > Matlab 72.8%
> > > Sharepoint  72.1%
> > > CoffeeScript71.0%
> > > LAMP  68.7%
> > > Cordova  66.9%
> > > Salesforce   65.4%
> > > Other   61.5%
> > > Perl 61.3%
> > > SQL Server & SQL 60.3%
> > > Objective-C 60.2%
> > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fsta
> > ck 
> > overflow.com%2fresearch%2fdeveloper-survey-2016%23technology-most-lo
> > ve
> > d-dreaded-and-wanted&data=01%7c01%7crsalva%40microsoft.com%7c342aabb
> > 95 
> > ca84607ba2608d34ec16bfe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata
> > =x SvTHrkLQ7Z4Z7CTctZ4rjFxaznfrPKVjqCkMzcUIpk%3d
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-18 Thread julio cesar sanchez
I like Jesse's proposal

for #3 I think we should use a new command, I like cordova *downgrade*
platform

As I usually read most cordova questions on stackoverflow, most people is
editing and tellign others to edit the .plist manually and doing some other
manual changes. I always point them to use hooks or plugins to do that, but
as it's harder they don't want to do it.

BTW, I think we should add a way to write on the AndroidManifest.xml and
info.plist from the config.xml as phonegap build does, using the
config-file tag. Right now it's possible to use the config-file tag on
plugin.xml but not on config.xml




2016-03-16 14:54 GMT+01:00 Carlos Santana :

> Here is an example [1] of hooks created by ionic team member extending
> config.xml to allow user to configure their native sdk settings allowing
> have platforms as build artifacts.
>
> This could be a start at looking at some basic configuration settings via
> hooks cordova provides or just in cordova tooling (i.e. platformAPI parser)
>
> [1]: https://github.com/mhartington/cordova-config-utils
>
>
> On Tue, Mar 15, 2016 at 10:31 PM Carlos Santana 
> wrote:
>
> > Scratch the "migrate cli command" idea. Now I think about it really messy
> > and it will be another hackHooks.
> >
> > I think we concentrate to provide more capabilities thru config.xml and
> > hooks for making migration more smooth.
> >
> > Like a running hooks on after_platform_update event and providing more
> > information in the hook context argument with from to platform info
> >
> >
> >
> > On Tue, Mar 15, 2016 at 9:52 PM Carlos Santana 
> > wrote:
> >
> >> By "I like the proposal and deleting all previous versions I don't see
> as
> >> an issue." I meant that I don't have an issue if we don't have this
> feature
> >> to clean old. I prefer not to have it
> >>
> >> On Tue, Mar 15, 2016 at 9:51 PM Carlos Santana 
> >> wrote:
> >>
> >>> I like the proposal and deleting all previous versions I don't see as
> an
> >>> issue.
> >>>
> >>> I didn't get the part of using symlinks, I don't symlinks they bring a
> >>> lot of problems to implement correctly I prefer we stick to real
> directory
> >>> and rename directories, user can choose to create symlinks on their
> needs,
> >>> we would just handle them.
> >>>
> >>> If end up doing a flag I prefer just deleting the one being replace, as
> >>> --no-backup
> >>> cordova platform update ios --no-backup (using nopt notation)
> >>> will do the rename ios -> ios@4.0.1
> >>> will do the add ios
> >>> then only then if the add works and all plugins present get install and
> >>> cli exist with none zero go and don't save the backup and delete the
> folder
> >>> that was rename to ios@4.0.1
> >>>
> >>> But I agree for now implement default to always do a backup, no flag
> >>> (maybe experimental)
> >>>
> >>> User needs to be explicit on harmful actions, they can do platform rm
> >>> ios@4.0.1 will simple delete /platforms/ios@4.0.1
> >>> and he can do it for any platform current/active or old backups
> >>>
> >>> I'm OK about this proposal and we can start a new one that covers how
> to
> >>> help with migration. Since update becomes backup,
> >>> We need to think how much we invest in migration, value of cordova is
> on
> >>> the runtime (core platform, and plugins)
> >>>
> >>> We can do start iterating with implementing enablement but specific
> >>> migration tasks/actions are built on real experiences by the community.
> >>> Meaning plugins/extensions that are plugable to handle migration, today
> >>> peope do with hooks, I call those hackHooks :-), hooks that do hacks to
> >>> make platforms build artifacts and be able to restore everything that
> can't
> >>> be restore with platform+plugins+config.xml
> >>>
> >>> So the flow I see if as the following:
> >>>
> >>> cordova platform update ios
> >>> 
> >>> mv platforms/ios platforms/ios@4.0.1
> >>> add platforms/ios
> >>> 
> >>> cordova migrate ios ios@4.0.1
> >>>
> >>> This cli migrate command migrate helps user migrate things from 4.0.1
> >>> (ios@4.0.1) to 4.1 (ios/current)
> >>> migrate will run the actions/tasks/extensions added by the user, this
> >>> actions/tasks/extensions (don't have a good name for migrations
> "things")
> >>> will be available on npm with keyword cordova:migrate
> >>> For example there can be a command "migrate add
> >>> cordova-migrate-entitlements" (this tasks migrate ios entitlements
> from an
> >>> old project to a new project)
> >>> this tasks/extension will be added to list of steps to do to automate
> >>> migration when cli command migrate runs
> >>> Cordova project can provide the tooling and maybe a handful (or zero)
> of
> >>> well known tasks for migration, but not more, the rest will come from
> the
> >>> community/3rd party to maintain and publish, this will be a way for
> people
> >>> like Darryl and Tommy that have knowledge on migration and hooks they
> can
> >>> convert those to migration npm packages to share.
> >>>
> >>>
> >>>
> >>>
> >>>
> >>

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-18 Thread Carlos Santana
yep  I agree Julio about adding more power to config.xml, that's basically
what Mike's hook those allow  tag in config.xml


On Wed, Mar 16, 2016 at 10:23 AM julio cesar sanchez 
wrote:

> I like Jesse's proposal
>
> for #3 I think we should use a new command, I like cordova *downgrade*
> platform
>
> As I usually read most cordova questions on stackoverflow, most people is
> editing and tellign others to edit the .plist manually and doing some other
> manual changes. I always point them to use hooks or plugins to do that, but
> as it's harder they don't want to do it.
>
> BTW, I think we should add a way to write on the AndroidManifest.xml and
> info.plist from the config.xml as phonegap build does, using the
> config-file tag. Right now it's possible to use the config-file tag on
> plugin.xml but not on config.xml
>
>
>
>
> 2016-03-16 14:54 GMT+01:00 Carlos Santana :
>
> > Here is an example [1] of hooks created by ionic team member extending
> > config.xml to allow user to configure their native sdk settings allowing
> > have platforms as build artifacts.
> >
> > This could be a start at looking at some basic configuration settings via
> > hooks cordova provides or just in cordova tooling (i.e. platformAPI
> parser)
> >
> > [1]: https://github.com/mhartington/cordova-config-utils
> >
> >
> > On Tue, Mar 15, 2016 at 10:31 PM Carlos Santana 
> > wrote:
> >
> > > Scratch the "migrate cli command" idea. Now I think about it really
> messy
> > > and it will be another hackHooks.
> > >
> > > I think we concentrate to provide more capabilities thru config.xml and
> > > hooks for making migration more smooth.
> > >
> > > Like a running hooks on after_platform_update event and providing more
> > > information in the hook context argument with from to platform info
> > >
> > >
> > >
> > > On Tue, Mar 15, 2016 at 9:52 PM Carlos Santana 
> > > wrote:
> > >
> > >> By "I like the proposal and deleting all previous versions I don't see
> > as
> > >> an issue." I meant that I don't have an issue if we don't have this
> > feature
> > >> to clean old. I prefer not to have it
> > >>
> > >> On Tue, Mar 15, 2016 at 9:51 PM Carlos Santana 
> > >> wrote:
> > >>
> > >>> I like the proposal and deleting all previous versions I don't see as
> > an
> > >>> issue.
> > >>>
> > >>> I didn't get the part of using symlinks, I don't symlinks they bring
> a
> > >>> lot of problems to implement correctly I prefer we stick to real
> > directory
> > >>> and rename directories, user can choose to create symlinks on their
> > needs,
> > >>> we would just handle them.
> > >>>
> > >>> If end up doing a flag I prefer just deleting the one being replace,
> as
> > >>> --no-backup
> > >>> cordova platform update ios --no-backup (using nopt notation)
> > >>> will do the rename ios -> ios@4.0.1
> > >>> will do the add ios
> > >>> then only then if the add works and all plugins present get install
> and
> > >>> cli exist with none zero go and don't save the backup and delete the
> > folder
> > >>> that was rename to ios@4.0.1
> > >>>
> > >>> But I agree for now implement default to always do a backup, no flag
> > >>> (maybe experimental)
> > >>>
> > >>> User needs to be explicit on harmful actions, they can do platform rm
> > >>> ios@4.0.1 will simple delete /platforms/ios@4.0.1
> > >>> and he can do it for any platform current/active or old backups
> > >>>
> > >>> I'm OK about this proposal and we can start a new one that covers how
> > to
> > >>> help with migration. Since update becomes backup,
> > >>> We need to think how much we invest in migration, value of cordova is
> > on
> > >>> the runtime (core platform, and plugins)
> > >>>
> > >>> We can do start iterating with implementing enablement but specific
> > >>> migration tasks/actions are built on real experiences by the
> community.
> > >>> Meaning plugins/extensions that are plugable to handle migration,
> today
> > >>> peope do with hooks, I call those hackHooks :-), hooks that do hacks
> to
> > >>> make platforms build artifacts and be able to restore everything that
> > can't
> > >>> be restore with platform+plugins+config.xml
> > >>>
> > >>> So the flow I see if as the following:
> > >>>
> > >>> cordova platform update ios
> > >>> 
> > >>> mv platforms/ios platforms/ios@4.0.1
> > >>> add platforms/ios
> > >>> 
> > >>> cordova migrate ios ios@4.0.1
> > >>>
> > >>> This cli migrate command migrate helps user migrate things from 4.0.1
> > >>> (ios@4.0.1) to 4.1 (ios/current)
> > >>> migrate will run the actions/tasks/extensions added by the user, this
> > >>> actions/tasks/extensions (don't have a good name for migrations
> > "things")
> > >>> will be available on npm with keyword cordova:migrate
> > >>> For example there can be a command "migrate add
> > >>> cordova-migrate-entitlements" (this tasks migrate ios entitlements
> > from an
> > >>> old project to a new project)
> > >>> this tasks/extension will be added to list of steps to do to automate
> > >>> migration when cli comm

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread rakatyal
Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56562785
  
--- Diff: src/android/FileUtils.java ---
@@ -347,18 +348,25 @@ else if (action.equals("write")) {
 threadhelper( new FileOp( ){
 public void run(JSONArray args) throws JSONException, 
FileNotFoundException, IOException, NoModificationAllowedException {
 String fname=args.getString(0);
+String nativeURL = 
resolveLocalFileSystemURI(fname).getString("nativeURL");
 String data=args.getString(1);
 int offset=args.getInt(2);
 Boolean isBinary=args.getBoolean(3);
-/*
- * If we don't have the package name in the path, 
we're reading and writing to places we need permission for
- */
-
if(fname.contains(cordova.getActivity().getPackageName()) ||
-hasReadPermission()) {
-long fileSize = write(fname, data, offset, 
isBinary);
-callbackContext.sendPluginResult(new 
PluginResult(PluginResult.Status.OK, fileSize));
+
+JSONObject j = requestAllPaths();
+String[] allowedStorageDirectories = 
{j.getString("applicationStorageDirectory"), 
j.getString("externalApplicationStorageDirectory")};
+boolean needWritePermission = true;
+
+// Ask for the write permission if the native url lies 
outside the allowed storage directories
+for(String directory : allowedStorageDirectories) {
+if(nativeURL.startsWith(directory) || 
hasWritePermission()) {
--- End diff --

These are converted to absolute paths so that won't happen. Also I couldn't 
find any such native api. Apparently, this is the way to do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579558
  
--- Diff: src/android/FileUtils.java ---
@@ -444,17 +458,19 @@ else if (action.equals("getFile")) {
 threadhelper( new FileOp( ){
 public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
 String dirname=args.getString(0);
-/*
- * If we don't have the package name in the path, 
we're reading and writing to places we need permission for
- */
-
if(dirname.contains(cordova.getActivity().getPackageName()) ||
-hasReadPermission()) {
-String path = args.getString(1);
-JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), false);
-callbackContext.success(obj);
+String path=args.getString(1);
--- End diff --

Nitpick: spaces around `=`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10894 Add supports-screens config...

2016-03-18 Thread akofman
GitHub user akofman opened a pull request:

https://github.com/apache/cordova-android/pull/280

CB-10894 Add supports-screens config from the config.xml file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akofman/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #280


commit 531dec0c66012bca6abc8b6ba7376fd36b900478
Author: Alexis Kofman 
Date:   2016-03-17T17:05:39Z

CB-10894 Add supports-screens config from the config.xml file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread riknoll
Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56701738
  
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException, 
IOException {
 else if (action.equals("getDirectory")) {
 threadhelper( new FileOp( ){
 public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
-String dirname=args.getString(0);
-String path=args.getString(1);
-JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), true);
-callbackContext.success(obj);
+String dirname = args.getString(0);
+String path = args.getString(1);
+String nativeURL = 
resolveLocalFileSystemURI(dirname).getString("nativeURL");
+boolean containsCreate = 
args.toString().contains("\"create\":true");
--- End diff --

This seems like a strange way to check this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread dblotsky
Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-198148373
  
You can also refactor `needPermission` into `needWritePermission` and 
`needReadPermission`, and similarly you can add `getPermissionWriteFile`, 
`getPermissionReadFile` and their directory-related friends in order to have a 
cleaner API (i.e. no flag args).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/195#discussion_r56371109
  
--- Diff: tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m ---
@@ -304,24 +303,28 @@ - (void) testImageScaleNoCropForSize {
 
 // test 800x600
 
-targetSize = CGSizeMake(800, 600);
+targetSize = CGSizeMake(600, 800);
 
 targetImage = [sourceImagePortrait 
imageByScalingNotCroppingForSize:targetSize];
 XCTAssertEqual(targetImage.size.width, targetSize.width);
 XCTAssertEqual(targetImage.size.height, targetSize.height);
 
+targetSize = CGSizeMake(800, 600);
+
 targetImage = [sourceImageLandscape 
imageByScalingNotCroppingForSize:targetSize];
 XCTAssertEqual(targetImage.size.width, targetSize.width);
 XCTAssertEqual(targetImage.size.height, targetSize.height);
 
 // test 1024x768
 
-targetSize = CGSizeMake(1024, 768);
+targetSize = CGSizeMake(768, 1024);
 
 targetImage = [sourceImagePortrait 
imageByScalingNotCroppingForSize:targetSize];
 XCTAssertEqual(targetImage.size.width, targetSize.width);
 XCTAssertEqual(targetImage.size.height, targetSize.height);
 
+targetSize = CGSizeMake(1024, 768);
+
--- End diff --

It might make life easier to put these guys in a loop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-18 Thread daserge
Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/557#discussion_r56392768
  
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -299,6 +299,10 @@ To sign an app, you need the following parameters:
 These parameters can be specified using the command line arguments above to
 the [Cordova CLI](../../../cordova-cli/index.html) `build` or `run` 
commands.
 
+__Note__: You should use double `--` to shield these platform-specific 
arguments, for example:
--- End diff --

Thanks, I will update it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-18 Thread infil00p
Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/273#issuecomment-197413662
  
I like #276 better, can you guys pop over, give it a look and comment on 
that? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579672
  
--- Diff: src/android/FileUtils.java ---
@@ -550,6 +577,26 @@ private boolean hasWritePermission() {
 return PermissionHelper.hasPermission(this, 
Manifest.permission.WRITE_EXTERNAL_STORAGE);
 }
 
+private boolean needPermission(String nativeURL, JSONArray args, int 
permissionType) throws JSONException {
+JSONObject j = requestAllPaths();
+String[] allowedStorageDirectories = 
{j.getString("applicationStorageDirectory"), 
j.getString("externalApplicationStorageDirectory")};
+
+if(permissionType == READ && hasReadPermission()) {
+return false;
+}
+else if(permissionType == WRITE && hasWritePermission()) {
--- End diff --

Just curious: do permissions ever expire?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10837 Support platform-specific o...

2016-03-18 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-android/pull/281

CB-10837 Support platform-specific orientation on Android

This removes processing of "orientation" preference lets user to specify 
any platform-specific value for Android.

See [CB-10837](https://issues.apache.org/jira/browse/CB-10837)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10837

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit e275e0fc4dff1747d0946fc88b858d606abe6222
Author: Vladimir Kotikov 
Date:   2016-03-18T12:07:16Z

CB-10837 Support platform-specific orientation on Android

This removes processing of "orientation" preference lets user to specify 
any platform-specific value for Android




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request: updated testing section in tools releas...

2016-03-18 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/114

updated testing section in tools release process



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-51

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit 9ab34507fbd31a05d25a4dffd3004c015aba086f
Author: Steve Gill 
Date:   2016-03-18T19:56:20Z

updated testing section in tools release process




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread rakatyal
Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-198047033
  
@riknoll , @dblotsky , @jasongin : Addressed feedback and added case for 
{create: true} flag.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/412


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links (Altern...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/555


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-common@1.1.1

2016-03-18 Thread Steven Gill
haha it would make my life easier. Too late now. I didn't include it in the
tools release but in hindsight I should have.

Tools release will pick up this release since cordova-common dependency is
1.1.x in cordova-lib.

This cordova-common release has more to do with platforms anyways. The
changes in here need to be added to platforms for the fixes we want. Other
tools don't necessarily need this change to be released. They should come
out around the same time though.

-Steve



On Fri, Mar 18, 2016 at 4:03 PM, Carlos Santana 
wrote:

> Why cordova-common not included with the Tools release?
> Does the cordova-lib that you sent out to vote contains this fixes? I
> assuming it doesn't just want to be sure
>
> I think it can be release separately like any of the others, but releasing
> it with the Tools would make it easier for person doing the Tools release
> in this case you Steve :-)
>
>
> On Fri, Mar 18, 2016 at 6:53 PM Steven Gill 
> wrote:
>
> > I propose a patch release of cordova-common. Thoughts?
> >
> > Changes:
> > * CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
> > duplicate entries)
> > * CB-10694 - Platform-specific configuration preferences don't override
> > global settings
> > * CB-9264 - Duplicate entries in config.xml
> > * CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
> > * CB-10662 Add tests for ConfigParser.getStaticResources
> > * CB-10622 fix target attribute being ignored for images in config.xml.
> > This closes #392
> > * CB-10583 Protect plugin preferences from adding extra Array properties.
> > This closes #400
> > * CB-10626 Incremented cordova-common package version to -dev
> >
> > Issue: https://issues.apache.org/jira/browse/CB-10911
> >
>


Re: Does Cordova have a problem making developers happy?

2016-03-18 Thread Nikhil Khandelwal
I have been guilty of not spending too much time on stackoverflow answering 
questions. It’s on my TODO list. For those who have, what are there general 
themes of improvement here that will make a huge impact? 

I remember Julio summarized this last year [1] and I believe we have made 
progress on a lot of these – docs, PATH setup. Though the impact of our docs 
work is yet to be seen – we just did a big update in terms of organization [2]. 
There’s probably more to be done in terms of docs – tutorials, examples for 
plugin API usage, integration with other tools like gulp, browserify etc. What 
are other good candidates for improvement?

I found it interesting that our own survey [3] in October had somewhat high Net 
promoter score (NPS).

[1] 
http://mail-archives.apache.org/mod_mbox/cordova-dev/201504.mbox/%3CetPan.552c9004.643c9869.b8b8@Kerris-MacBook-Pro.local%3E
[2] https://cordova.apache.org/announcements/2016/03/03/docs-improvement.html
[3] https://apachecordovabot.typeform.com/report/BCc5co/JQLG

On 3/17/16, 5:55 PM, "Carlos Santana"  wrote:

>I agree Joe
>
>It's easy to create a stackoverflow subscription that emails you once a
>day.
>
>I have one that covers "cordova" "worklight" "mobilefirst"
>
>I tried to answer what I can, but reading it daily which is not every day
>that I get something probably most every other day with a few.
>
>At least reading all the new questions gives me a sense on what people are
>having problems on.
>
>
>
>On Thu, Mar 17, 2016 at 8:46 PM Joe Bowser  wrote:
>
>> BTW: The last one was a joke.  But in all honesty, we should all spend a
>> bit more time on Stack seeing what's going on there with our respective
>> products/distributions.
>>
>> On Thu, Mar 17, 2016 at 5:43 PM, Joe Bowser  wrote:
>>
>> >
>> >
>> > On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva 
>> > wrote:
>> >
>> >> Keep in mind that the answers are limited to the technologies that Stack
>> >> Overflow chooses to offer in their list of options. They have an "other"
>> >> option with a text box, but people's answers are largely driven by the
>> >> checkbox options.
>> >>
>> >>
>> > So, we somehow pissed off the Stack Overflow guys???
>> >
>> >
>> >
>> >>
>> >>
>> >> Ryan J. Salva  |  Principal PM Manager
>> >> Visual Studio Tools for Apache Cordova
>> >> rsa...@microsoft.com
>> >> 425 706 5270 office
>> >> 206 612 5079 mobile
>> >>
>> >> -Original Message-
>> >> From: Joe Bowser [mailto:bows...@gmail.com]
>> >> Sent: Thursday, March 17, 2016 5:21 PM
>> >> To: dev 
>> >> Subject: Re: Does Cordova have a problem making developers happy?
>> >>
>> >> On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva 
>> >> wrote:
>> >>
>> >> > As I told some of my co-workers today:
>> >> >
>> >> > If you read the fine print, the actual statistic is “% of developers
>> >> > who are developing with the language or tech but have not expressed
>> >> > interest in continuing to do so.” Clearly, it’s not a good list to be
>> >> > on, but developer behavior also doesn’t reflect their stated intent.
>> >> > NPM Stats show the number of Cordova downloads has actually doubled
>> >> > since the same time last year.
>> >> >
>> >> > Again, I don’t think this is a good list to appear on… I’m just not
>> >> > sure what to make of it given developer behavior.
>> >> >
>> >>
>> >> I'd rather be on that list instead of not be on any list.  I'd be more
>> >> concerned with the fact that we're on the "Losers" section of the
>> trending
>> >> tech with a 7% decrease in the number of questions, which indicate that
>> >> people either have no problems (not very likely) or are just giving
>> up.  I
>> >> haven't been answering questions on Stack for a while, mostly because
>> >> they're using some third party framework like ionic or something else.
>> >>
>> >> I also find it interesting that people are hating on Cordova, and not
>> >> PhoneGap, Ionic, Taco or the other distributions.
>> >>
>> >>
>> >> >
>> >> >
>> >> > Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache
>> >> > Cordova rsa...@microsoft.com
>> >> > 425 706 5270 office
>> >> > 206 612 5079 mobile
>> >> >
>> >> > -Original Message-
>> >> > From: Joe Bowser [mailto:bows...@gmail.com]
>> >> > Sent: Thursday, March 17, 2016 5:08 PM
>> >> > To: dev 
>> >> > Subject: Re: Does Cordova have a problem making developers happy?
>> >> >
>> >> > On Thu, Mar 17, 2016 at 5:03 PM, Jesse 
>> wrote:
>> >> >
>> >> > > Never trust people's answers when you ask them what they like! They
>> >> > > are almost always wrong, and will tell you what they think they
>> >> > > like, or think they will seem cooler if they liked.
>> >> > >
>> >> > >
>> >> > +1
>> >> >
>> >> > It's interesting that CoffeeScript is on this list and that it passed
>> >> > Cordova in most dreaded.  I also wonder what would happen if we went
>> >> > on the WordPress mailing list and talked about how people were so
>> >> > unhappy with WordPress.
>> >> >
>> >> >
>> >> > >
>> >> > > > On Mar 17, 2016, at 5:04

[GitHub] cordova-android pull request: CB-10837 Support platform-specific o...

2016-03-18 Thread omefire
Github user omefire commented on the pull request:

https://github.com/apache/cordova-android/pull/281#issuecomment-198428837
  
Ok, its better we leave the validation to gradle then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10837 Support platform-specific o...

2016-03-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-android/pull/281#issuecomment-198326891
  
Note that to fix orienattion issues ultimately we'll need also 
https://github.com/apache/cordova-lib/pull/411 and 
https://github.com/apache/cordova-lib/pull/412


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [ALL PLATFORMS][cordova-common] Platform specific preferences overridden by global preferences

2016-03-18 Thread Nikhil Khandelwal
Thanks for the heads up. Good find! (1) sounds pretty bad - correct me if I'm 
wrong, to fix this, we need to do the following:
- fix it in cordova-common, release
- bundle those changes to all platforms & release all of them.

We need tests for this scenario also.

Shaz: Are you planning to take all the tasks above? Some of us could likely 
help.

-Nikhil

-Original Message-
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Wednesday, March 16, 2016 10:32 AM
To: dev@cordova.apache.org
Subject: [ALL PLATFORMS][cordova-common] Platform specific preferences 
overridden by global preferences

Some code changes I want to highlight that I want changing, in cordova-common:

1. 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10694&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ynROJ1IjgLWqIcLk9AYH9%2fzlQTn%2fbVooUcyWk5iG12Q%3d

Platform specific preferences are "overriden" by global preferences, because 
when the merged config.xml file (root config.xml merge with platform 
config.xml), the global preferences are written last always, so they clobber 
any previous declaration. The change is to write platform preferences last:

https://github.com/apache/cordova-lib/blob/a3285602b88f4e40f08c178b8b26c918c91d0dce/cordova-common/src/util/xml-helpers.js#L212-L217

2. 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9264&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uKrVMPdcY2zBnYiGrTASEoKAlGoanmcdd6ME0BIlPd4%3d

This is not as critical as #1 above, since it's just a build artifact 
thing.This is just to remove duplicate entries in the merged config.xml.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-18 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/559#discussion_r56598656
  
--- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
@@ -239,3 +239,105 @@ For example, for a plugin that supports android, iOS 
& Windows, the keywords in
 ```
 
 For more detailed example of a package.json, review the [package.json file 
of 
cordova-plugin-device](https://github.com/apache/cordova-plugin-device/blob/master/package.json).
+
+### Specifying Cordova Dependencies
+
+**Cordova 6.1.0** added support for specifying the Cordova-related 
dependencies of a plugin
+as part of the plugin's `package.json` file. Plugins may list the 
dependencies for multiple
+releases so as to provide guidance to the Cordova CLI when it is selecting 
the version of a
+plugin to fetch from npm. The CLI will choose the latest release of a 
plugin that is
+compatible with the local project's installed platforms and plugins as 
well as the
+the local Cordova CLI version. If no releases of the plugin are 
compatible, the CLI will warn
+the user about the failed requirements and fall back to the old behavior 
of fetching the
+latest release.
+
+This feature is intended to eventually replace the [engines 
element](../../../plugin_ref/spec.html#engines-and-engine) in plugin.xml.
+Listing dependencies is a good way to ensure that your plugin will not 
appear broken or cause
+build errors when fetched from npm. If the latest release of the plugin is 
not compatible with
+a project, the CLI will give the app developer a list of unmet project 
requirements so that
+they are aware of incompatibilites and can update their project to support 
your plugin. This
+allows your plugin to respond to breaking changes without fear of 
confusing devlopers who
+are building against old platforms and plugins.
+
+To specify Cordova-related dependencies for a plugin, alter the `engines` 
element in
+`package.json` to include a `cordovaDependencies` object using the 
following
+structure:
+
+```javascript
+engines: {
+cordovaDependencies: {
+PLUGIN_VERSION: {
+DEPENDENCY: SEMVER_RANGE,
+DEPENDENCY: SEMVER_RANGE,
+...
+},
+...
+}
+}
+```
+
+* `PLUGIN_VERSION` specifies a version of your plugin. It should adhere 
the syntax for a single version as defined by [npm's semver 
package][npm-semver] or an upper bound (see [below](#upper-bounds))
--- End diff --

Nit: You could as well hyper-link "upper bound"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.

2016-03-18 Thread riknoll
Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/562#issuecomment-198590861
  
This is just moving the docs over right? In that case LGTM (as far as I can 
review it)! Just make sure that #563 gets in before we publish


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-common@1.1.1

2016-03-18 Thread Carlos Santana
Why cordova-common not included with the Tools release?
Does the cordova-lib that you sent out to vote contains this fixes? I
assuming it doesn't just want to be sure

I think it can be release separately like any of the others, but releasing
it with the Tools would make it easier for person doing the Tools release
in this case you Steve :-)


On Fri, Mar 18, 2016 at 6:53 PM Steven Gill  wrote:

> I propose a patch release of cordova-common. Thoughts?
>
> Changes:
> * CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
> duplicate entries)
> * CB-10694 - Platform-specific configuration preferences don't override
> global settings
> * CB-9264 - Duplicate entries in config.xml
> * CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
> * CB-10662 Add tests for ConfigParser.getStaticResources
> * CB-10622 fix target attribute being ignored for images in config.xml.
> This closes #392
> * CB-10583 Protect plugin preferences from adding extra Array properties.
> This closes #400
> * CB-10626 Incremented cordova-common package version to -dev
>
> Issue: https://issues.apache.org/jira/browse/CB-10911
>


[GitHub] cordova-docs pull request: Removing prettify reference in index.js

2016-03-18 Thread riknoll
GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/563

Removing prettify reference in index.js

Forgot that we referenced a function from the Prettify script in another 
script that was included later in the page. Hurray web development!

@dblotsky check it out

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs pretty-print

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #563


commit 5c9b8d6d27e14edcc5546db073e8083a83993ea5
Author: Richard Knoll 
Date:   2016-03-19T00:06:19Z

Removing prettify reference in index.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-18 Thread Shazron
Another issue: we still document the non-CLI way to update projects.
This was brought to my attention in a comment [1] in CB-10775.

The platform specific way is still mentioned [2], and update
instructions for iOS [3] and android [4] still exist.

I think we should not have any more "update" docs that don't involve
the CLI. What do you think?

[1] 
https://issues.apache.org/jira/browse/CB-10775?focusedCommentId=15200735&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15200735
[2] 
https://cordova.apache.org/docs/en/latest/guide/overview/index.html#development-paths
[3] http://cordova.apache.org/docs/en/latest/guide/platforms/ios/upgrade.html
[4] 
http://cordova.apache.org/docs/en/latest/guide/platforms/android/upgrade.html


On Wed, Mar 16, 2016 at 7:44 AM, Carlos Santana  wrote:
> yep  I agree Julio about adding more power to config.xml, that's basically
> what Mike's hook those allow  tag in config.xml
>
>
> On Wed, Mar 16, 2016 at 10:23 AM julio cesar sanchez 
> wrote:
>
>> I like Jesse's proposal
>>
>> for #3 I think we should use a new command, I like cordova *downgrade*
>> platform
>>
>> As I usually read most cordova questions on stackoverflow, most people is
>> editing and tellign others to edit the .plist manually and doing some other
>> manual changes. I always point them to use hooks or plugins to do that, but
>> as it's harder they don't want to do it.
>>
>> BTW, I think we should add a way to write on the AndroidManifest.xml and
>> info.plist from the config.xml as phonegap build does, using the
>> config-file tag. Right now it's possible to use the config-file tag on
>> plugin.xml but not on config.xml
>>
>>
>>
>>
>> 2016-03-16 14:54 GMT+01:00 Carlos Santana :
>>
>> > Here is an example [1] of hooks created by ionic team member extending
>> > config.xml to allow user to configure their native sdk settings allowing
>> > have platforms as build artifacts.
>> >
>> > This could be a start at looking at some basic configuration settings via
>> > hooks cordova provides or just in cordova tooling (i.e. platformAPI
>> parser)
>> >
>> > [1]: https://github.com/mhartington/cordova-config-utils
>> >
>> >
>> > On Tue, Mar 15, 2016 at 10:31 PM Carlos Santana 
>> > wrote:
>> >
>> > > Scratch the "migrate cli command" idea. Now I think about it really
>> messy
>> > > and it will be another hackHooks.
>> > >
>> > > I think we concentrate to provide more capabilities thru config.xml and
>> > > hooks for making migration more smooth.
>> > >
>> > > Like a running hooks on after_platform_update event and providing more
>> > > information in the hook context argument with from to platform info
>> > >
>> > >
>> > >
>> > > On Tue, Mar 15, 2016 at 9:52 PM Carlos Santana 
>> > > wrote:
>> > >
>> > >> By "I like the proposal and deleting all previous versions I don't see
>> > as
>> > >> an issue." I meant that I don't have an issue if we don't have this
>> > feature
>> > >> to clean old. I prefer not to have it
>> > >>
>> > >> On Tue, Mar 15, 2016 at 9:51 PM Carlos Santana 
>> > >> wrote:
>> > >>
>> > >>> I like the proposal and deleting all previous versions I don't see as
>> > an
>> > >>> issue.
>> > >>>
>> > >>> I didn't get the part of using symlinks, I don't symlinks they bring
>> a
>> > >>> lot of problems to implement correctly I prefer we stick to real
>> > directory
>> > >>> and rename directories, user can choose to create symlinks on their
>> > needs,
>> > >>> we would just handle them.
>> > >>>
>> > >>> If end up doing a flag I prefer just deleting the one being replace,
>> as
>> > >>> --no-backup
>> > >>> cordova platform update ios --no-backup (using nopt notation)
>> > >>> will do the rename ios -> ios@4.0.1
>> > >>> will do the add ios
>> > >>> then only then if the add works and all plugins present get install
>> and
>> > >>> cli exist with none zero go and don't save the backup and delete the
>> > folder
>> > >>> that was rename to ios@4.0.1
>> > >>>
>> > >>> But I agree for now implement default to always do a backup, no flag
>> > >>> (maybe experimental)
>> > >>>
>> > >>> User needs to be explicit on harmful actions, they can do platform rm
>> > >>> ios@4.0.1 will simple delete /platforms/ios@4.0.1
>> > >>> and he can do it for any platform current/active or old backups
>> > >>>
>> > >>> I'm OK about this proposal and we can start a new one that covers how
>> > to
>> > >>> help with migration. Since update becomes backup,
>> > >>> We need to think how much we invest in migration, value of cordova is
>> > on
>> > >>> the runtime (core platform, and plugins)
>> > >>>
>> > >>> We can do start iterating with implementing enablement but specific
>> > >>> migration tasks/actions are built on real experiences by the
>> community.
>> > >>> Meaning plugins/extensions that are plugable to handle migration,
>> today
>> > >>> peope do with hooks, I call those hackHooks :-), hooks that do hacks
>> to
>> > >>> make platforms build artifacts and be able to restore everything that
>>

[DISCUSS] Cordova-common@1.1.1

2016-03-18 Thread Steven Gill
I propose a patch release of cordova-common. Thoughts?

Changes:
* CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
duplicate entries)
* CB-10694 - Platform-specific configuration preferences don't override
global settings
* CB-9264 - Duplicate entries in config.xml
* CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
* CB-10662 Add tests for ConfigParser.getStaticResources
* CB-10622 fix target attribute being ignored for images in config.xml.
This closes #392
* CB-10583 Protect plugin preferences from adding extra Array properties.
This closes #400
* CB-10626 Incremented cordova-common package version to -dev

Issue: https://issues.apache.org/jira/browse/CB-10911


[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.

2016-03-18 Thread dblotsky
Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/562#issuecomment-198592236
  
Yep, it's just that. Will re-do this once #563 gets merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Removing prettify reference in index.js

2016-03-18 Thread dblotsky
Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/563#issuecomment-198592101
  
Whoop, good catch! LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Tools Release

2016-03-18 Thread Mefire O .
PR issued: https://github.com/apache/cordova-lib/pull/413


Thanks,
Omar Mefire

On Mar 16, 2016, at 12:45 PM, Steven Gill 
mailto:stevengil...@gmail.com>> wrote:

hmm, sounds like a reasonable solution. Right now we only reinstall plugins
saved in config.xml (which prepare does). But it makes sense to reinstall
all plugins installed.

Let me know when you have a PR.

On Wed, Mar 16, 2016 at 11:02 AM, Mefire O. 
mailto:ommen...@microsoft.com>> wrote:

I'd like to propose we get in a fix for CB-10775 during this release:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10775&data=01%7c01%7commenjik%40microsoft.com%7c946d776dac834e2e388d08d34dd3962f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0Mx2AXdn9TjMyV8h7CFnVsOkcqVCL2zr8ifWjdn%2fvo4%3d

It is breaking lots of people, and I have a fix that will solve this
problem temporarily until we get the more permanent 'cordova platform rm,
platform add' solution in.

It involves making changes to cordova-lib, to reinstall plugins recorded
in , after their deletion by the platform (cordova-ios).

If we agree this should go in, I can have something working by end of day,
today.

Thanks,
Omar Mefire

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Monday, March 14, 2016 6:00 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release

Sounds good.
I'm working on this [1] it should be done by then to pick it up

[1]:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10808&data=01%7c01%7commenjik%40microsoft.com%7c0eb62e0d48e74f71ab8208d34c089010%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=AwCI%2f5sbxcxI0kpS%2fJI4D%2bvtdMBMfhexWW2EOCGrfhU%3d


On Sun, Mar 13, 2016 at 6:09 PM Steven Gill 
wrote:

I'm planning on starting a tools release on Wed. Let me know if you
need me to look at anything.

-Steve





[GitHub] cordova-plugin-camera pull request: Fix for CB-10050 : Plugin Came...

2016-03-18 Thread omefire
Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/183#issuecomment-197553388
  
I think this change is not necessary because the user could have edited the 
picture they picked from the PHOTOLIBRARY and want it saved (even though it 
ends up being saved twice). This verification, in my opinion, is better left to 
the user of the plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-18 Thread riknoll
Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/51#discussion_r56393172
  
--- Diff: README.md ---
@@ -175,6 +175,14 @@ code.
 ### Android Quirks
 
 - The `duration` parameter is not supported.  Recording lengths can't be 
limited programmatically.
+- Android uses intents to launch the camera activity on the device to 
capture
+images, and on phones with low memory, the Cordova activity may be killed. 
 In this
+scenario, the result from the plugin call will be delivered via the resume 
event.
+See [the Android Lifecycle guide][android_lifecycle]
--- End diff --

This is a reference style markdown link and I think you missed copying over 
the actual link definition at the bottom of the README. Should point to 
http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#lifecycle-guide


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: Merge pull request #1 from apache/ma...

2016-03-18 Thread infil00p
Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/275#issuecomment-197413270
  
I'm not sure what's going on here, can you please close this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/170


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Does Cordova have a problem making developers happy?

2016-03-18 Thread Carlos Santana
I agree Joe

It's easy to create a stackoverflow subscription that emails you once a
day.

I have one that covers "cordova" "worklight" "mobilefirst"

I tried to answer what I can, but reading it daily which is not every day
that I get something probably most every other day with a few.

At least reading all the new questions gives me a sense on what people are
having problems on.



On Thu, Mar 17, 2016 at 8:46 PM Joe Bowser  wrote:

> BTW: The last one was a joke.  But in all honesty, we should all spend a
> bit more time on Stack seeing what's going on there with our respective
> products/distributions.
>
> On Thu, Mar 17, 2016 at 5:43 PM, Joe Bowser  wrote:
>
> >
> >
> > On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva 
> > wrote:
> >
> >> Keep in mind that the answers are limited to the technologies that Stack
> >> Overflow chooses to offer in their list of options. They have an "other"
> >> option with a text box, but people's answers are largely driven by the
> >> checkbox options.
> >>
> >>
> > So, we somehow pissed off the Stack Overflow guys???
> >
> >
> >
> >>
> >>
> >> Ryan J. Salva  |  Principal PM Manager
> >> Visual Studio Tools for Apache Cordova
> >> rsa...@microsoft.com
> >> 425 706 5270 office
> >> 206 612 5079 mobile
> >>
> >> -Original Message-
> >> From: Joe Bowser [mailto:bows...@gmail.com]
> >> Sent: Thursday, March 17, 2016 5:21 PM
> >> To: dev 
> >> Subject: Re: Does Cordova have a problem making developers happy?
> >>
> >> On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva 
> >> wrote:
> >>
> >> > As I told some of my co-workers today:
> >> >
> >> > If you read the fine print, the actual statistic is “% of developers
> >> > who are developing with the language or tech but have not expressed
> >> > interest in continuing to do so.” Clearly, it’s not a good list to be
> >> > on, but developer behavior also doesn’t reflect their stated intent.
> >> > NPM Stats show the number of Cordova downloads has actually doubled
> >> > since the same time last year.
> >> >
> >> > Again, I don’t think this is a good list to appear on… I’m just not
> >> > sure what to make of it given developer behavior.
> >> >
> >>
> >> I'd rather be on that list instead of not be on any list.  I'd be more
> >> concerned with the fact that we're on the "Losers" section of the
> trending
> >> tech with a 7% decrease in the number of questions, which indicate that
> >> people either have no problems (not very likely) or are just giving
> up.  I
> >> haven't been answering questions on Stack for a while, mostly because
> >> they're using some third party framework like ionic or something else.
> >>
> >> I also find it interesting that people are hating on Cordova, and not
> >> PhoneGap, Ionic, Taco or the other distributions.
> >>
> >>
> >> >
> >> >
> >> > Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache
> >> > Cordova rsa...@microsoft.com
> >> > 425 706 5270 office
> >> > 206 612 5079 mobile
> >> >
> >> > -Original Message-
> >> > From: Joe Bowser [mailto:bows...@gmail.com]
> >> > Sent: Thursday, March 17, 2016 5:08 PM
> >> > To: dev 
> >> > Subject: Re: Does Cordova have a problem making developers happy?
> >> >
> >> > On Thu, Mar 17, 2016 at 5:03 PM, Jesse 
> wrote:
> >> >
> >> > > Never trust people's answers when you ask them what they like! They
> >> > > are almost always wrong, and will tell you what they think they
> >> > > like, or think they will seem cooler if they liked.
> >> > >
> >> > >
> >> > +1
> >> >
> >> > It's interesting that CoffeeScript is on this list and that it passed
> >> > Cordova in most dreaded.  I also wonder what would happen if we went
> >> > on the WordPress mailing list and talked about how people were so
> >> > unhappy with WordPress.
> >> >
> >> >
> >> > >
> >> > > > On Mar 17, 2016, at 5:04 AM, julio cesar sanchez
> >> > > > 
> >> > > wrote:
> >> > > >
> >> > > > 2016 survey is out
> >> > > >
> >> > > > Most Dreaded technologies:
> >> > > >
> >> > > > Visual Basic79.5%
> >> > > > WordPress  74.3%
> >> > > > Matlab 72.8%
> >> > > > Sharepoint  72.1%
> >> > > > CoffeeScript71.0%
> >> > > > LAMP  68.7%
> >> > > > Cordova  66.9%
> >> > > > Salesforce   65.4%
> >> > > > Other   61.5%
> >> > > > Perl 61.3%
> >> > > > SQL Server & SQL 60.3%
> >> > > > Objective-C 60.2%
> >> > > >
> >> > > >
> >> > >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fsta
> >> > > ck
> >> > > overflow.com
> %2fresearch%2fdeveloper-survey-2016%23technology-most-lo
> >> > > ve
> >> > > d-dreaded-and-wanted&data=01%7c01%7crsalva%40microsoft.com
> %7c342aabb
> >> > > 95
> >> > > ca84607ba2608d34ec16bfe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata
> >> > > =x SvTHrkLQ7Z4Z7CTctZ4rjFxaznfrPKVjqCkMzcUIpk%3d
> >> > >
> >> > > 
> >>

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread rakatyal
Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56722724
  
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException, 
IOException {
 else if (action.equals("getDirectory")) {
 threadhelper( new FileOp( ){
 public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
-String dirname=args.getString(0);
-String path=args.getString(1);
-JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), true);
-callbackContext.success(obj);
+String dirname = args.getString(0);
+String path = args.getString(1);
+String nativeURL = 
resolveLocalFileSystemURI(dirname).getString("nativeURL");
+boolean containsCreate = 
args.toString().contains("\"create\":true");
--- End diff --

Corrected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Removing prettify reference in index.js

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] cordova-ios release

2016-03-18 Thread Shazron
Another issue, the bundled ios-sim should be updated:
https://issues.apache.org/jira/browse/CB-10912

On Thu, Mar 17, 2016 at 1:58 PM, Edna Y Morales  wrote:

> Ok sounds good
>
> Thanks,
> *Edna Morales*
>
> [image: Inactive hide details for Carlos Santana ---03/17/2016 04:48:19
> PM---I agree Steve - Carlos]Carlos Santana ---03/17/2016 04:48:19 PM---I
> agree Steve - Carlos
>
> From: Carlos Santana 
> To: dev@cordova.apache.org
> Date: 03/17/2016 04:48 PM
> Subject: Re: [DISCUSS] cordova-ios release
> --
>
>
>
> I agree Steve
>
> - Carlos
> @csantanapr
>
> > On Mar 17, 2016, at 4:17 PM, Steven Gill  wrote:
> >
> > Lets do a common release first and then follow that up with patch ios
> > release
> >
> >> On Thu, Mar 17, 2016 at 11:24 AM, Shazron  wrote:
> >>
> >> I would say patch release. I had some items I wanted in the next
> >> release (labeled cordova-ios-4.1.1), but that shouldn't hold up
> >> releasing often, keep the train running...
> >>
> >> Ideally it should be accompanied with the patches I did yesterday for
> >> cordova-common (since cordova-common is bundled in to cordova-ios),
> >> but those bugs only really affect cordova-cli functionality
> >>
> >> On Thu, Mar 17, 2016 at 11:09 AM, Edna Y Morales 
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> We are interested in a cordova-ios release, specifically for this jira
> >>> item: https://issues.apache.org/jira/browse/CB-10773
> >>>
> >>> Is there any opposition to this or any reason to wait? Steve would it
> >> make
> >>> sense to wait for a cordova-common release to happen first, before
> doing
> >>> the cordova-ios release?
> >>>
> >>> Would it be a patch release or a minor release?
> >>>
> >>> Thanks,
> >>> Edna Morales
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
>
>
>


[GitHub] cordova-docs pull request: CB-10902 added tools release blog post

2016-03-18 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/561#discussion_r56729499
  
--- Diff: www/_posts/2016-03-21-tools-release.md ---
@@ -0,0 +1,140 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: https://twitter.com/stevesgill
+title:  "Cordova 6.1.0 Released!"
+categories: news
+tags: release tools
+---
+New versions of cordova tools are now live!
+
+* [cordova-lib@6.1.0](https://www.npmjs.org/package/cordova-lib)
+* [cordova@6.1.0](https://www.npmjs.org/package/cordova)
+* [plugman@1.2.0](https://www.npmjs.org/package/plugman)
+* [cordova-js@4.1.4](https://www.npmjs.org/package/cordova-js)
+
+Release Highlights include:
+* [CB-10880](https://issues.apache.org/jira/browse/CB-10880) Removed 
plugin pinning. Instead we have implemented automatic plugin fetching based on 
engine requirements. You can read more about our new engine fetching prosal at 
[https://github.com/cordova/cordova-discuss/blob/master/proposals/plugin-version-fetching.md](https://github.com/cordova/cordova-discuss/blob/master/proposals/plugin-version-fetching.md).
 This implementation will grab the newest version of a plugin that your project 
supports when running `cordova plugin add`. 
--- End diff --

I'm actually going to update this to point to @riknoll blog post on the 
subject once he publishes it. https://github.com/apache/cordova-docs/pull/559


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-18 Thread stevengill
Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/559#issuecomment-198562921
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-18 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/559#discussion_r56729389
  
--- Diff: www/_posts/2016-03-16-new-plugin-fetching.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Richard Knoll
+url: https://github.com/riknoll
+title:  "Upcoming Changes to Plugin Fetching"
+categories: announcements
+tags: news
+---
+
+The Cordova 6.0.0 release introduced the pinning of core plugin
+versions in cordova-lib.
+
+We are happy to announce that one of the new features in the upcoming
+Cordova 6.1.0 release is a general API that allows any plugin to guide
+the CLI in choosing a compatible plugin release to fetch for a given 
project.
+This moves the plugin dependency information out of cordova-lib so that it
+can update independently of the Cordova tools and support third-party 
plugins
+outside of core. Our hope is that this feature will improve Cordova's 
plugin
+ecosystem and reduce some of the frustration that Cordova developers face 
when
+adding a new plugin to a project.
+
+
+
+The new API allows for plugin developers to give a mapping of plugin
+releases to project requirements in their `package.json`. When an app 
developer
+adds a plugin to their Cordova project, cordova-lib will examine their
+installed plugins, platforms, and cordova-lib version and decide which
+version of the plugin to fetch based on the provided mapping.
+If the project does not fulfill the requirements for the latest release of 
the
+plugin, the CLI will print warnings indicating the problems and fetch the
+latest release of the plugin that is compatible.
+
+This API may eventually replace the [engines 
element](http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine)
 in `plugin.xml`.
--- End diff --

I would say it **will** eventually replace the engine element in 
plugin.xml! But we can wait until we actually make that change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Tools Release

2016-03-18 Thread Steven Gill
Please review tools release blog post:
https://github.com/apache/cordova-docs/pull/561

Any other highlights I should include?

-Steve

On Thu, Mar 17, 2016 at 2:29 PM, Steven Gill  wrote:

> Tools release issue: https://issues.apache.org/jira/browse/CB-10902
>
>
> On Thu, Mar 17, 2016 at 1:18 PM, Mefire O.  wrote:
>
>> PR: https://github.com/apache/cordova-lib/pull/413
>>
>> Occasionally, there is this issue that crops up, looks like there's a
>> race condition between the cordova-lib code and the cordova-ios code.
>> As a result, I will close this PR and we can proceed with the release.
>> Anyone else is welcome to carry out further investigations, if interested.
>>
>> Sorry, everyone.
>>
>> Thanks,
>> Omar Mefire
>>
>> On Mar 17, 2016, at 12:36 PM, Mefire O. > ommen...@microsoft.com>> wrote:
>>
>> PR issued: https://github.com/apache/cordova-lib/pull/413
>>
>>
>> Thanks,
>> Omar Mefire
>>
>> On Mar 16, 2016, at 12:45 PM, Steven Gill > stevengil...@gmail.com>> wrote:
>>
>> hmm, sounds like a reasonable solution. Right now we only reinstall
>> plugins
>> saved in config.xml (which prepare does). But it makes sense to reinstall
>> all plugins installed.
>>
>> Let me know when you have a PR.
>>
>> On Wed, Mar 16, 2016 at 11:02 AM, Mefire O. > > wrote:
>>
>> I'd like to propose we get in a fix for CB-10775 during this release:
>>
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10775&data=01%7c01%7commenjik%40microsoft.com%7c946d776dac834e2e388d08d34dd3962f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0Mx2AXdn9TjMyV8h7CFnVsOkcqVCL2zr8ifWjdn%2fvo4%3d
>>
>> It is breaking lots of people, and I have a fix that will solve this
>> problem temporarily until we get the more permanent 'cordova platform rm,
>> platform add' solution in.
>>
>> It involves making changes to cordova-lib, to reinstall plugins recorded
>> in , after their deletion by the platform (cordova-ios).
>>
>> If we agree this should go in, I can have something working by end of day,
>> today.
>>
>> Thanks,
>> Omar Mefire
>>
>> -Original Message-
>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> Sent: Monday, March 14, 2016 6:00 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Tools Release
>>
>> Sounds good.
>> I'm working on this [1] it should be done by then to pick it up
>>
>> [1]:
>>
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10808&data=01%7c01%7commenjik%40microsoft.com%7c0eb62e0d48e74f71ab8208d34c089010%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=AwCI%2f5sbxcxI0kpS%2fJI4D%2bvtdMBMfhexWW2EOCGrfhU%3d
>>
>>
>> On Sun, Mar 13, 2016 at 6:09 PM Steven Gill 
>> wrote:
>>
>> I'm planning on starting a tools release on Wed. Let me know if you
>> need me to look at anything.
>>
>> -Steve
>>
>>
>>
>>
>>
>


RE: Does Cordova have a problem making developers happy?

2016-03-18 Thread Raghav Katyal
I guess responding to JIRA quickly and acting on contributors' PRs could be 
candidates for improvement.

-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] 
Sent: Friday, March 18, 2016 11:18 AM
To: dev@cordova.apache.org
Subject: Re: Does Cordova have a problem making developers happy?

I have been guilty of not spending too much time on stackoverflow answering 
questions. It’s on my TODO list. For those who have, what are there general 
themes of improvement here that will make a huge impact? 

I remember Julio summarized this last year [1] and I believe we have made 
progress on a lot of these – docs, PATH setup. Though the impact of our docs 
work is yet to be seen – we just did a big update in terms of organization [2]. 
There’s probably more to be done in terms of docs – tutorials, examples for 
plugin API usage, integration with other tools like gulp, browserify etc. What 
are other good candidates for improvement?

I found it interesting that our own survey [3] in October had somewhat high Net 
promoter score (NPS).

[1] 
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail-archives.apache.org%2fmod_mbox%2fcordova-dev%2f201504.mbox%2f%253CetPan.552c9004.643c9869.b8b8%40Kerris-MacBook-Pro.local%253E&data=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=dPkMBS3I8mA7uqmezeLaxknf4ujYsmymcco50y9piYg%3d
[2] 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordova.apache.org%2fannouncements%2f2016%2f03%2f03%2fdocs-improvement.html&data=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fYJCb131SFY%2bAA0RS2cxrDyf3m74EAHSGPuhd6oR7xo%3d
[3] 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fapachecordovabot.typeform.com%2freport%2fBCc5co%2fJQLG&data=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=eH8cPNyXnPD2ltm%2bKbFfLCq4ifGQeBItD5rAXbgSOhg%3d

On 3/17/16, 5:55 PM, "Carlos Santana"  wrote:

>I agree Joe
>
>It's easy to create a stackoverflow subscription that emails you once a 
>day.
>
>I have one that covers "cordova" "worklight" "mobilefirst"
>
>I tried to answer what I can, but reading it daily which is not every 
>day that I get something probably most every other day with a few.
>
>At least reading all the new questions gives me a sense on what people 
>are having problems on.
>
>
>
>On Thu, Mar 17, 2016 at 8:46 PM Joe Bowser  wrote:
>
>> BTW: The last one was a joke.  But in all honesty, we should all 
>> spend a bit more time on Stack seeing what's going on there with our 
>> respective products/distributions.
>>
>> On Thu, Mar 17, 2016 at 5:43 PM, Joe Bowser  wrote:
>>
>> >
>> >
>> > On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva 
>> > 
>> > wrote:
>> >
>> >> Keep in mind that the answers are limited to the technologies that 
>> >> Stack Overflow chooses to offer in their list of options. They have an 
>> >> "other"
>> >> option with a text box, but people's answers are largely driven by 
>> >> the checkbox options.
>> >>
>> >>
>> > So, we somehow pissed off the Stack Overflow guys???
>> >
>> >
>> >
>> >>
>> >>
>> >> Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for 
>> >> Apache Cordova rsa...@microsoft.com
>> >> 425 706 5270 office
>> >> 206 612 5079 mobile
>> >>
>> >> -Original Message-
>> >> From: Joe Bowser [mailto:bows...@gmail.com]
>> >> Sent: Thursday, March 17, 2016 5:21 PM
>> >> To: dev 
>> >> Subject: Re: Does Cordova have a problem making developers happy?
>> >>
>> >> On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva 
>> >> 
>> >> wrote:
>> >>
>> >> > As I told some of my co-workers today:
>> >> >
>> >> > If you read the fine print, the actual statistic is “% of 
>> >> > developers who are developing with the language or tech but have 
>> >> > not expressed interest in continuing to do so.” Clearly, it’s 
>> >> > not a good list to be on, but developer behavior also doesn’t reflect 
>> >> > their stated intent.
>> >> > NPM Stats show the number of Cordova downloads has actually 
>> >> > doubled since the same time last year.
>> >> >
>> >> > Again, I don’t think this is a good list to appear on… I’m just 
>> >> > not sure what to make of it given developer behavior.
>> >> >
>> >>
>> >> I'd rather be on that list instead of not be on any list.  I'd be 
>> >> more concerned with the fact that we're on the "Losers" section of 
>> >> the
>> trending
>> >> tech with a 7% decrease in the number of questions, which indicate 
>> >> that people either have no problems (not very likely) or are just 
>> >> giving
>> up.  I
>> >> haven't been answering questions on Stack for a while, mostly 
>> >> because they're using some third party framework like ionic or something 
>> >> else.
>> >>
>> >> I also find it interesting that people are hating on Cordova, and 
>> >> not PhoneGap, Ionic, Taco or the other distri

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.

2016-03-18 Thread dblotsky
GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/562

Snapshotting dev to 6.x.

@nikhilkh @rakatyal @riknoll please give this a glance when you have a 
moment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs snapshot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #562


commit 958b369c072672a939876e3d4a8dfeb94d47df0c
Author: Dmitry Blotsky 
Date:   2016-03-18T23:33:59Z

Snapshotting dev to 6.x.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.

2016-03-18 Thread riknoll
Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/562#issuecomment-198603743
  
Do you have to redo it? That PR only affects index.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org