[GitHub] cordova-plugin-contacts pull request: CB-8115 incorrect birthday s...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/113#discussion_r58341876
  
--- Diff: www/convertUtils.js ---
@@ -0,0 +1,61 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+var utils = require('cordova/utils');
+
+module.exports = {
+/**
+* Converts primitives into Complex Object
+* Currently only used for Date fields
+*/
+toCordova: function (contact) {
--- End diff --

These methods have been extracted to avoid code duplication, and I've only 
renamed the functions (BTW +1 on your renaming suggestion, I will address it).
I don't think we need to add more conversions besides the date right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10980 Add tools@6.1.1 release blog p...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-docs/pull/570

CB-10980 Add tools@6.1.1 release blog post

JIRA [CB-10980](https://issues.apache.org/jira/browse/CB-10980)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10980

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #570


commit 0bc0155e82672ea7c3d2c7c74069ced0ff3d99ef
Author: Vladimir Kotikov 
Date:   2016-04-04T08:54:00Z

CB-10980 Add tools@6.1.1 release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Tools release

[Vladimir Kotikov (Akvelon)]

Cordova-cli@6.1.1 & Plugman@1.2.1 has been released!
Check out https://www.npmjs.com/package/cordova and 
https://www.npmjs.com/package/plugman

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Tools Release CLI/LIB 6.1.1

[Vladimir Kotikov (Akvelon)]

The permanent release tags have been set and the packages have been published 
to npm.

Could someone please review announcement blog post at 
https://github.com/apache/cordova-docs/pull/570 

-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Friday, April 1, 2016 4:39 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

can we close the vote and release?

On Fri, Apr 1, 2016 at 9:38 AM Carlos Santana  wrote:

> bump
>
> On Thu, Mar 31, 2016 at 1:27 PM Carlos Santana 
> wrote:
>
>> +1
>>
>> - Carlos
>> @csantanapr
>>
>> > On Mar 31, 2016, at 1:17 PM, Vladimir Kotikov (Akvelon) <
>> v-vlk...@microsoft.com> wrote:
>> >
>> > Just cherry-picked releasenotes to master
>> > -
>> > Best regards, Vladimir
>> >
>> > -Original Message-
>> > From: Carlos Santana [mailto:csantan...@gmail.com]
>> > Sent: Thursday, March 31, 2016 6:09 PM
>> > To: dev@cordova.apache.org
>> > Subject: Re: [DISCUSS] Tools Release CLI/LIB 6.1.1
>> >
>> > Burned again by not using --tags to fresh :-(
>> >
>> > But still cordova-cli master/HEAD is behind 3 commits need to be
>> updated, it's missing the
>> https://na01.safelinks.protection.outlook.com/?url=RELEASENOTES.md&da
>> ta=01%7c01%7cv-vlkoti%40microsoft.com%7c4d492fd59cd945deab3b08d359767
>> d19%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mAKpEs1VeHtDgr6DinoF
>> QjrSX3WZblU3IpZAh8LHbEY%3d
>> changes for 6.1.1
>> >
>> >
>> >
>> >> On Thu, Mar 31, 2016 at 3:36 AM Vladimir Kotikov (Akvelon) <
>> v-vlk...@microsoft.com> wrote:
>> >>
>> >> Carlos,
>> >> I was able to verify tags for lib and cli:
>> >>
>> >> coho verify-tags
>> >> Running from d:\cordova
>> >> Paste in print-tags output then hit Enter
>> >>cordova-lib: 6.1.1 (107e273647)
>> >>cordova-plugman: 1.2.1 (f05a7ef8cf)
>> >>cordova-cli: 6.1.1 (8e730ac376)
>> >>
>> >> cordova-lib: Tag hash verified.
>> >> cordova-plugman: Tag hash verified.
>> >> cordova-cli: Tag hash verified.
>> >>
>> >> Looks like you just need to run `git fetch origin --tags` to 
>> >> update the tags in your local repo. They had been moved since last 
>> >> release attempt. I should have notify about this when started the vote.
>> >>
>> >> -
>> >> Best regards, Vladimir
>> >>
>> >> -Original Message-
>> >> From: Carlos Santana [mailto:csantan...@gmail.com]
>> >> Sent: Tuesday, March 29, 2016 2:35 PM
>> >> To: dev@cordova.apache.org
>> >> Subject: Re: [DISCUSS] Tools Release CLI/LIB 6.1.1
>> >>
>> >> I agree, we can discuss later the release for cordova-commons
>> >>
>> >> - Carlos
>> >> @csantanapr
>> >>
>>  On Mar 29, 2016, at 7:27 AM, Vladimir Kotikov (Akvelon) <
>> >>> v-vlk...@microsoft.com> wrote:
>> >>>
>> >>> Carlos, I've reviewed and merged these PRs. However the only two 
>> >>> PRs
>> >> that need to be included into this release are #415 [1] and #416 [2].
>> >> The other two are for cordova-common and I guess we have nothing 
>> >> to do with them for now.
>> >>>
>> >>> Summarizing, the release notes for 6.1.1 will look like this:
>> >>>
>> >>> ### 6.1.1 (Mar 29, 2016)
>> >>> * CB-10961 Error no such file or directory adding ios platform 
>> >>> when
>> >> plugins present or required
>> >>> * CB-10908 Reload the config.xml before writing the saved plugin
>> >>>
>> >>> [1] https://github.com/apache/cordova-lib/pull/415
>> >>> [2] https://github.com/apache/cordova-lib/pull/416
>> >>>
>> >>> -
>> >>> Best regards, Vladimir
>> >>>
>> >>> -Original Message-
>> >>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> >>> Sent: Monday, March 28, 2016 10:50 PM
>> >>> To: dev@cordova.apache.org
>> >>> Subject: [DISCUSS] Tools Release CLI/LIB 6.1.1
>> >>>
>> >>> I would like to see a patch release for the tools
>> >>>
>> >>> Interested if someone can review and merge these PRs and get 
>> >>> include it
>> >> in the release:
>> >>>
>> >>> https://github.com/apache/cordova-lib/pull/418
>> >>> https://github.com/apache/cordova-lib/pull/417
>> >>> https://github.com/apache/cordova-lib/pull/416
>> >>> https://github.com/apache/cordova-lib/pull/415
>> >>>
>> >>> -
>> >>> ---
>> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> >>
>> >> --
>> >> --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> >> For additional commands, e-mail: dev-h...@cordova.apache.org
>> >>
>> >>
>> >> --
>> >> --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> >> For additional commands, e-mail: dev-h...@cordova.apache.org
>> >
>> ТÐÐ¥Fò
>> Vç7V'67&–&R RÖÖ –â FWb×Vç7V'67&–&T 6÷&F÷f æ   6†Ræ÷&pФf÷"  FF—F–öæ Â
>> 6öÖÖ æG2 RÖÖ –â FWbÖ†VÇ  6÷&F÷f æ   6†Ræ÷&pÐ
>>
>

Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

[Carlos Santana]

LGTM

- Carlos
@csantanapr

> On Apr 4, 2016, at 5:09 AM, Vladimir Kotikov (Akvelon) 
>  wrote:
> 
> The permanent release tags have been set and the packages have been published 
> to npm.
> 
> Could someone please review announcement blog post at 
> https://github.com/apache/cordova-docs/pull/570 
> 
> -
> Best regards, Vladimir
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com] 
> Sent: Friday, April 1, 2016 4:39 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release CLI/LIB 6.1.1
> 
> can we close the vote and release?
> 
>> On Fri, Apr 1, 2016 at 9:38 AM Carlos Santana  wrote:
>> 
>> bump
>> 
>> On Thu, Mar 31, 2016 at 1:27 PM Carlos Santana 
>> wrote:
>> 
>>> +1
>>> 
>>> - Carlos
>>> @csantanapr
>>> 
> On Mar 31, 2016, at 1:17 PM, Vladimir Kotikov (Akvelon) <
 v-vlk...@microsoft.com> wrote:
 
 Just cherry-picked releasenotes to master
 -
 Best regards, Vladimir
 
 -Original Message-
 From: Carlos Santana [mailto:csantan...@gmail.com]
 Sent: Thursday, March 31, 2016 6:09 PM
 To: dev@cordova.apache.org
 Subject: Re: [DISCUSS] Tools Release CLI/LIB 6.1.1
 
 Burned again by not using --tags to fresh :-(
 
 But still cordova-cli master/HEAD is behind 3 commits need to be
>>> updated, it's missing the
>>> https://na01.safelinks.protection.outlook.com/?url=RELEASENOTES.md&da
>>> ta=01%7c01%7cv-vlkoti%40microsoft.com%7c4d492fd59cd945deab3b08d359767
>>> d19%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mAKpEs1VeHtDgr6DinoF
>>> QjrSX3WZblU3IpZAh8LHbEY%3d
>>> changes for 6.1.1
 
 
 
> On Thu, Mar 31, 2016 at 3:36 AM Vladimir Kotikov (Akvelon) <
>>> v-vlk...@microsoft.com> wrote:
> 
> Carlos,
> I was able to verify tags for lib and cli:
> 
> coho verify-tags
> Running from d:\cordova
> Paste in print-tags output then hit Enter
>   cordova-lib: 6.1.1 (107e273647)
>   cordova-plugman: 1.2.1 (f05a7ef8cf)
>   cordova-cli: 6.1.1 (8e730ac376)
> 
> cordova-lib: Tag hash verified.
> cordova-plugman: Tag hash verified.
> cordova-cli: Tag hash verified.
> 
> Looks like you just need to run `git fetch origin --tags` to 
> update the tags in your local repo. They had been moved since last 
> release attempt. I should have notify about this when started the vote.
> 
> -
> Best regards, Vladimir
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Tuesday, March 29, 2016 2:35 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release CLI/LIB 6.1.1
> 
> I agree, we can discuss later the release for cordova-commons
> 
> - Carlos
> @csantanapr
> 
>>> On Mar 29, 2016, at 7:27 AM, Vladimir Kotikov (Akvelon) <
>> v-vlk...@microsoft.com> wrote:
>> 
>> Carlos, I've reviewed and merged these PRs. However the only two 
>> PRs
> that need to be included into this release are #415 [1] and #416 [2].
> The other two are for cordova-common and I guess we have nothing 
> to do with them for now.
>> 
>> Summarizing, the release notes for 6.1.1 will look like this:
>> 
>> ### 6.1.1 (Mar 29, 2016)
>> * CB-10961 Error no such file or directory adding ios platform 
>> when
> plugins present or required
>> * CB-10908 Reload the config.xml before writing the saved plugin
>> 
>> [1] https://github.com/apache/cordova-lib/pull/415
>> [2] https://github.com/apache/cordova-lib/pull/416
>> 
>> -
>> Best regards, Vladimir
>> 
>> -Original Message-
>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> Sent: Monday, March 28, 2016 10:50 PM
>> To: dev@cordova.apache.org
>> Subject: [DISCUSS] Tools Release CLI/LIB 6.1.1
>> 
>> I would like to see a patch release for the tools
>> 
>> Interested if someone can review and merge these PRs and get 
>> include it
> in the release:
>> 
>> https://github.com/apache/cordova-lib/pull/418
>> https://github.com/apache/cordova-lib/pull/417
>> https://github.com/apache/cordova-lib/pull/416
>> https://github.com/apache/cordova-lib/pull/415
>> 
>> -
>> ---
>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
> 
> --
> --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 
> 
> --
> --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>>> ТÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒ

[GitHub] cordova-docs pull request: CB-10980 Add tools@6.1.1 release blog p...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-docs/pull/570#issuecomment-205281945
  
Reviewed by @csantanapr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10980 Add tools@6.1.1 release blog p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/570


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-205285417
  
@unbeatableDeepak I have a solution coded, but I haven't had a chance to 
test it yet. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: Appium runner improvements

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[unbeatableDeepak]

Github user unbeatableDeepak commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-205367729
  
@swbradshaw That's great! If you don't have time then I can do the testing 
of your code and will let you know the result, can you please provide me your 
code so that I can test it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10062 Error: EACCES: permission denie...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/242#discussion_r58406360
  
--- Diff: src/cli.js ---
@@ -60,13 +60,23 @@ function init() {
 }
 
 function checkForUpdates() {
-// Checks for available update and returns an instance
-var notifier = updateNotifier({
-pkg: pkg
-});
+try {
+// Checks for available update and returns an instance
+var notifier = updateNotifier({
+pkg: pkg
+});
 
-// Notify using the built-in convenience method
-notifier.notify();
+// Notify using the built-in convenience method
+notifier.notify();
+} catch (e) {
+// https://issues.apache.org/jira/browse/CB-10062
+if (e && e.message && /EACCES/.test(e.message)) {
+console.log('Update notifier was not able to access the config 
file.\n' +
--- End diff --

Ah, okay!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10942 - Cannot

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-ios/pull/211#issuecomment-205393355
  
lgtm!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Core Plugins and Android API 23

[Richard Knoll]

Sorry for being late to comment on this. If we were the only ones using the 
class, I would say we should just keep copying around. However, since other 
plugins are using it I think it's a good idea to put it in a common place and a 
plugin is the best way to do it. LGTM! Should someone write up a blog post 
about this so that third-party plugins know to update?

Thanks,
Richard

-Original Message-
From: Simon MacDonald [mailto:simon.macdon...@gmail.com] 
Sent: Sunday, April 3, 2016 12:26 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Core Plugins and Android API 23

Seems like we have momentum on this. So barring any negative comments from 
Microsoft about this approach whom do I contact to setup a new repo on Apache 
GIT?


Simon Mac Donald
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d

On Sun, Apr 3, 2016 at 2:26 PM, julio cesar sanchez 
wrote:

> I like it too
> A lot of 3rd party plugins are adding that classes too
>
> BTW, there is a JIRA issue to add 
> https://na01.safelinks.protection.outlook.com/?url=PermissionHelper.ja
> va&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35b
> f5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KXea2ILjY6Ja2Qr4XF
> %2b8FoLrOpCRvinHQIaqi%2faMSXw%3d to cordova-android 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10656&data=01%7c01%7criknoll%40micro
> soft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7c
> d011db47%7c1&sdata=Y6ygyF0AqvvK2VqTcTRSNflpowAn89Xaa%2fTaMFC%2fqlI%3d
>
>
>
> 2016-04-03 18:43 GMT+02:00 Carlos Santana :
>
> > Simon I like approach
> > Can we move to this approach now? Yes Then once the downstream 
> > distro's support API 23 and the new API methods in CordovaInterface 
> > we can move this into Cordova Android proper? Yes
> >
> > +1
> >
> > On Thu, Mar 31, 2016 at 6:38 PM Joe Bowser  wrote:
> >
> > > LGTM!
> > >
> > > On Thu, Mar 31, 2016 at 3:02 PM, Simon MacDonald < 
> > > simon.macdon...@gmail.com>
> > > wrote:
> > >
> > > > I really hate the fact we need to add that 
> > > > https://na01.safelinks.protection.outlook.com/?url=PermissionHel
> > > > per.java&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454d
> > > > a19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> > > > KXea2ILjY6Ja2Qr4XF%2b8FoLrOpCRvinHQIaqi%2faMSXw%3d file
> > to
> > > > each and every plugin that requires API 23 permission support.
> > Especially
> > > > since the package the class is in is different for each plugin 
> > > > so we
> > can
> > > > two, three or more copies of the same code in an app. That's 
> > > > just
> > > wasteful.
> > > >
> > > > Joe responded to my bitching by saying "Maybe we should create a 
> > > > permissions plugin for this and make everything go through that"
> which
> > > set
> > > > my mind a racing (perhaps I was just over caffeinated) and I 
> > > > decided
> to
> > > > prototype it this afternoon.
> > > >
> > > > I've created a new plugin called cordova-plugin-compat over at 
> > > > https://github.com/macdonst/cordova-plugin-compat  and all it 
> > > > does
> is
> > > > deliver the org.apache.cordova.PermissionHelper class. I then 
> > > > turned
> > > around
> > > > and removed the class from the camera plugin and make
> > > cordova-plugin-camera
> > > > depend on cordova-plugin-compat.
> > > >
> > > > You can see that change over on my camera fork:
> > > >
> > > > https://github.com/macdonst
> > > >
> /cordova-plugin-camera/commit/58b72cb5c3109481df9f337ad97607858681b37e
> > > >
> > > > Can we move to this approach now? Then once the downstream 
> > > > distro's
> > > support
> > > > API 23 and the new API methods in CordovaInterface we can move 
> > > > this
> > into
> > > > Cordova Android proper?
> > > >
> > > > Thoughts? Are there use cases this approach doesn't work for?
> > > >
> > > >
> > > > Simon Mac Donald
> > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> > > > hi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c
> > > > 6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011d
> > > > b47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
> > > >
> > > > On Fri, Feb 5, 2016 at 2:32 PM, Richard Knoll 
> > > >  >
> > > > wrote:
> > > >
> > > > > Yep, I left it out of the first round by mistake; I was 
> > > > > looking at
> an
> > > out
> > > > > of date version of cordova-plugin-media at the time. I've got 
> > > > > a PR
> > open
> > > > > that adds the helper here:
> > > > >
> > > > > https://github.com/apache/cordova-plugin-media/pull/79
> > > > >
> > > > > Thanks,
> > > > > Richard
> > > > >
> > > > > -Original Message-
> > > > > From: julio cesar sanchez [mailto:jcesarmob...@gmail.com]
> > > > > Sent: Friday, February 5, 2016 7

Re: [DISCUSS] Core Plugins and Android API 23

[Joe Bowser]

Does this require a major version change?

On Mon, Apr 4, 2016, 10:30 AM Richard Knoll  wrote:

> Sorry for being late to comment on this. If we were the only ones using
> the class, I would say we should just keep copying around. However, since
> other plugins are using it I think it's a good idea to put it in a common
> place and a plugin is the best way to do it. LGTM! Should someone write up
> a blog post about this so that third-party plugins know to update?
>
> Thanks,
> Richard
>
> -Original Message-
> From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> Sent: Sunday, April 3, 2016 12:26 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Core Plugins and Android API 23
>
> Seems like we have momentum on this. So barring any negative comments from
> Microsoft about this approach whom do I contact to setup a new repo on
> Apache GIT?
>
>
> Simon Mac Donald
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
>
> On Sun, Apr 3, 2016 at 2:26 PM, julio cesar sanchez <
> jcesarmob...@gmail.com>
> wrote:
>
> > I like it too
> > A lot of 3rd party plugins are adding that classes too
> >
> > BTW, there is a JIRA issue to add
> > https://na01.safelinks.protection.outlook.com/?url=PermissionHelper.ja
> > va&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35b
> > f5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KXea2ILjY6Ja2Qr4XF
> > %2b8FoLrOpCRvinHQIaqi%2faMSXw%3d to cordova-android
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fCB-10656&data=01%7c01%7criknoll%40micro
> > soft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7c
> > d011db47%7c1&sdata=Y6ygyF0AqvvK2VqTcTRSNflpowAn89Xaa%2fTaMFC%2fqlI%3d
> >
> >
> >
> > 2016-04-03 18:43 GMT+02:00 Carlos Santana :
> >
> > > Simon I like approach
> > > Can we move to this approach now? Yes Then once the downstream
> > > distro's support API 23 and the new API methods in CordovaInterface
> > > we can move this into Cordova Android proper? Yes
> > >
> > > +1
> > >
> > > On Thu, Mar 31, 2016 at 6:38 PM Joe Bowser  wrote:
> > >
> > > > LGTM!
> > > >
> > > > On Thu, Mar 31, 2016 at 3:02 PM, Simon MacDonald <
> > > > simon.macdon...@gmail.com>
> > > > wrote:
> > > >
> > > > > I really hate the fact we need to add that
> > > > > https://na01.safelinks.protection.outlook.com/?url=PermissionHel
> > > > > per.java&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454d
> > > > > a19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> > > > > KXea2ILjY6Ja2Qr4XF%2b8FoLrOpCRvinHQIaqi%2faMSXw%3d file
> > > to
> > > > > each and every plugin that requires API 23 permission support.
> > > Especially
> > > > > since the package the class is in is different for each plugin
> > > > > so we
> > > can
> > > > > two, three or more copies of the same code in an app. That's
> > > > > just
> > > > wasteful.
> > > > >
> > > > > Joe responded to my bitching by saying "Maybe we should create a
> > > > > permissions plugin for this and make everything go through that"
> > which
> > > > set
> > > > > my mind a racing (perhaps I was just over caffeinated) and I
> > > > > decided
> > to
> > > > > prototype it this afternoon.
> > > > >
> > > > > I've created a new plugin called cordova-plugin-compat over at
> > > > > https://github.com/macdonst/cordova-plugin-compat  and all it
> > > > > does
> > is
> > > > > deliver the org.apache.cordova.PermissionHelper class. I then
> > > > > turned
> > > > around
> > > > > and removed the class from the camera plugin and make
> > > > cordova-plugin-camera
> > > > > depend on cordova-plugin-compat.
> > > > >
> > > > > You can see that change over on my camera fork:
> > > > >
> > > > > https://github.com/macdonst
> > > > >
> > /cordova-plugin-camera/commit/58b72cb5c3109481df9f337ad97607858681b37e
> > > > >
> > > > > Can we move to this approach now? Then once the downstream
> > > > > distro's
> > > > support
> > > > > API 23 and the new API methods in CordovaInterface we can move
> > > > > this
> > > into
> > > > > Cordova Android proper?
> > > > >
> > > > > Thoughts? Are there use cases this approach doesn't work for?
> > > > >
> > > > >
> > > > > Simon Mac Donald
> > > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> > > > > hi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c
> > > > > 6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011d
> > > > > b47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
> > > > >
> > > > > On Fri, Feb 5, 2016 at 2:32 PM, Richard Knoll
> > > > >  > >
> > > > > wrote:
> > > > >
> > > > > > Yep, I left it out of the first round by mistake; I was
> > > > > > looking at
> > an
> > > > out
> > > > > > of date version of cordova-plugin-media at the time. I'v

Re: [DISCUSS] Core Plugins and Android API 23

[Simon MacDonald]

In cordova-android? No, I don't think so. For the plugins I'd bump their
minor version. Make sense?


Simon Mac Donald
http://hi.im/simonmacdonald

On Mon, Apr 4, 2016 at 1:32 PM, Joe Bowser  wrote:

> Does this require a major version change?
>
> On Mon, Apr 4, 2016, 10:30 AM Richard Knoll  wrote:
>
> > Sorry for being late to comment on this. If we were the only ones using
> > the class, I would say we should just keep copying around. However, since
> > other plugins are using it I think it's a good idea to put it in a common
> > place and a plugin is the best way to do it. LGTM! Should someone write
> up
> > a blog post about this so that third-party plugins know to update?
> >
> > Thanks,
> > Richard
> >
> > -Original Message-
> > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > Sent: Sunday, April 3, 2016 12:26 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Core Plugins and Android API 23
> >
> > Seems like we have momentum on this. So barring any negative comments
> from
> > Microsoft about this approach whom do I contact to setup a new repo on
> > Apache GIT?
> >
> >
> > Simon Mac Donald
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
> >
> > On Sun, Apr 3, 2016 at 2:26 PM, julio cesar sanchez <
> > jcesarmob...@gmail.com>
> > wrote:
> >
> > > I like it too
> > > A lot of 3rd party plugins are adding that classes too
> > >
> > > BTW, there is a JIRA issue to add
> > > https://na01.safelinks.protection.outlook.com/?url=PermissionHelper.ja
> > > va&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35b
> > > f5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KXea2ILjY6Ja2Qr4XF
> > > %2b8FoLrOpCRvinHQIaqi%2faMSXw%3d to cordova-android
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10656&data=01%7c01%7criknoll%40micro
> > > soft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7c
> > > d011db47%7c1&sdata=Y6ygyF0AqvvK2VqTcTRSNflpowAn89Xaa%2fTaMFC%2fqlI%3d
> > >
> > >
> > >
> > > 2016-04-03 18:43 GMT+02:00 Carlos Santana :
> > >
> > > > Simon I like approach
> > > > Can we move to this approach now? Yes Then once the downstream
> > > > distro's support API 23 and the new API methods in CordovaInterface
> > > > we can move this into Cordova Android proper? Yes
> > > >
> > > > +1
> > > >
> > > > On Thu, Mar 31, 2016 at 6:38 PM Joe Bowser 
> wrote:
> > > >
> > > > > LGTM!
> > > > >
> > > > > On Thu, Mar 31, 2016 at 3:02 PM, Simon MacDonald <
> > > > > simon.macdon...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > I really hate the fact we need to add that
> > > > > > https://na01.safelinks.protection.outlook.com/?url=PermissionHel
> > > > > > per.java&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454d
> > > > > > a19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> > > > > > KXea2ILjY6Ja2Qr4XF%2b8FoLrOpCRvinHQIaqi%2faMSXw%3d file
> > > > to
> > > > > > each and every plugin that requires API 23 permission support.
> > > > Especially
> > > > > > since the package the class is in is different for each plugin
> > > > > > so we
> > > > can
> > > > > > two, three or more copies of the same code in an app. That's
> > > > > > just
> > > > > wasteful.
> > > > > >
> > > > > > Joe responded to my bitching by saying "Maybe we should create a
> > > > > > permissions plugin for this and make everything go through that"
> > > which
> > > > > set
> > > > > > my mind a racing (perhaps I was just over caffeinated) and I
> > > > > > decided
> > > to
> > > > > > prototype it this afternoon.
> > > > > >
> > > > > > I've created a new plugin called cordova-plugin-compat over at
> > > > > > https://github.com/macdonst/cordova-plugin-compat  and all it
> > > > > > does
> > > is
> > > > > > deliver the org.apache.cordova.PermissionHelper class. I then
> > > > > > turned
> > > > > around
> > > > > > and removed the class from the camera plugin and make
> > > > > cordova-plugin-camera
> > > > > > depend on cordova-plugin-compat.
> > > > > >
> > > > > > You can see that change over on my camera fork:
> > > > > >
> > > > > > https://github.com/macdonst
> > > > > >
> > > /cordova-plugin-camera/commit/58b72cb5c3109481df9f337ad97607858681b37e
> > > > > >
> > > > > > Can we move to this approach now? Then once the downstream
> > > > > > distro's
> > > > > support
> > > > > > API 23 and the new API methods in CordovaInterface we can move
> > > > > > this
> > > > into
> > > > > > Cordova Android proper?
> > > > > >
> > > > > > Thoughts? Are there use cases this approach doesn't work for?
> > > > > >
> > > > > >
> > > > > > Simon Mac Donald
> > > > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> > > > > > hi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40micro

Re: [DISCUSS] Core Plugins and Android API 23

[Simon MacDonald]

I will take it upon myself to get it done.

Task list:
1) create cordova-plugin-compat repo, populate with code.
2) migrate core plugins to use cordova-plugin-compat
3) kick off plugins release
4) write blog post

am I missing anything?


Simon Mac Donald
http://hi.im/simonmacdonald

On Mon, Apr 4, 2016 at 1:30 PM, Richard Knoll  wrote:

> Sorry for being late to comment on this. If we were the only ones using
> the class, I would say we should just keep copying around. However, since
> other plugins are using it I think it's a good idea to put it in a common
> place and a plugin is the best way to do it. LGTM! Should someone write up
> a blog post about this so that third-party plugins know to update?
>
> Thanks,
> Richard
>
> -Original Message-
> From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> Sent: Sunday, April 3, 2016 12:26 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Core Plugins and Android API 23
>
> Seems like we have momentum on this. So barring any negative comments from
> Microsoft about this approach whom do I contact to setup a new repo on
> Apache GIT?
>
>
> Simon Mac Donald
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
>
> On Sun, Apr 3, 2016 at 2:26 PM, julio cesar sanchez <
> jcesarmob...@gmail.com>
> wrote:
>
> > I like it too
> > A lot of 3rd party plugins are adding that classes too
> >
> > BTW, there is a JIRA issue to add
> > https://na01.safelinks.protection.outlook.com/?url=PermissionHelper.ja
> > va&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08d35b
> > f5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KXea2ILjY6Ja2Qr4XF
> > %2b8FoLrOpCRvinHQIaqi%2faMSXw%3d to cordova-android
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fCB-10656&data=01%7c01%7criknoll%40micro
> > soft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7c
> > d011db47%7c1&sdata=Y6ygyF0AqvvK2VqTcTRSNflpowAn89Xaa%2fTaMFC%2fqlI%3d
> >
> >
> >
> > 2016-04-03 18:43 GMT+02:00 Carlos Santana :
> >
> > > Simon I like approach
> > > Can we move to this approach now? Yes Then once the downstream
> > > distro's support API 23 and the new API methods in CordovaInterface
> > > we can move this into Cordova Android proper? Yes
> > >
> > > +1
> > >
> > > On Thu, Mar 31, 2016 at 6:38 PM Joe Bowser  wrote:
> > >
> > > > LGTM!
> > > >
> > > > On Thu, Mar 31, 2016 at 3:02 PM, Simon MacDonald <
> > > > simon.macdon...@gmail.com>
> > > > wrote:
> > > >
> > > > > I really hate the fact we need to add that
> > > > > https://na01.safelinks.protection.outlook.com/?url=PermissionHel
> > > > > per.java&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454d
> > > > > a19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> > > > > KXea2ILjY6Ja2Qr4XF%2b8FoLrOpCRvinHQIaqi%2faMSXw%3d file
> > > to
> > > > > each and every plugin that requires API 23 permission support.
> > > Especially
> > > > > since the package the class is in is different for each plugin
> > > > > so we
> > > can
> > > > > two, three or more copies of the same code in an app. That's
> > > > > just
> > > > wasteful.
> > > > >
> > > > > Joe responded to my bitching by saying "Maybe we should create a
> > > > > permissions plugin for this and make everything go through that"
> > which
> > > > set
> > > > > my mind a racing (perhaps I was just over caffeinated) and I
> > > > > decided
> > to
> > > > > prototype it this afternoon.
> > > > >
> > > > > I've created a new plugin called cordova-plugin-compat over at
> > > > > https://github.com/macdonst/cordova-plugin-compat  and all it
> > > > > does
> > is
> > > > > deliver the org.apache.cordova.PermissionHelper class. I then
> > > > > turned
> > > > around
> > > > > and removed the class from the camera plugin and make
> > > > cordova-plugin-camera
> > > > > depend on cordova-plugin-compat.
> > > > >
> > > > > You can see that change over on my camera fork:
> > > > >
> > > > > https://github.com/macdonst
> > > > >
> > /cordova-plugin-camera/commit/58b72cb5c3109481df9f337ad97607858681b37e
> > > > >
> > > > > Can we move to this approach now? Then once the downstream
> > > > > distro's
> > > > support
> > > > > API 23 and the new API methods in CordovaInterface we can move
> > > > > this
> > > into
> > > > > Cordova Android proper?
> > > > >
> > > > > Thoughts? Are there use cases this approach doesn't work for?
> > > > >
> > > > >
> > > > > Simon Mac Donald
> > > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> > > > > hi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c
> > > > > 6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011d
> > > > > b47%7c1&sdata=yGziFs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
> > > > >
> > > > > On Fri, Feb 5, 2016 at

[GitHub] cordova-docs pull request: CB-11006 add ios@4.1.1 release blog pos...

[eymorale]

GitHub user eymorale opened a pull request:

https://github.com/apache/cordova-docs/pull/571

CB-11006 add ios@4.1.1 release blog post



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eymorale/cordova-docs CB-11006

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #571


commit 2f4d611c88b9ad89be885430422bd511b52a3656
Author: Edna Morales 
Date:   2016-04-04T17:36:39Z

CB-11006 add ios@4.1.1 release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Core Plugins and Android API 23

[Richard Knoll]

That sounds right to me. No major version bumps needed.

Richard

-Original Message-
From: Simon MacDonald [mailto:simon.macdon...@gmail.com] 
Sent: Monday, April 4, 2016 10:35 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Core Plugins and Android API 23

In cordova-android? No, I don't think so. For the plugins I'd bump their minor 
version. Make sense?


Simon Mac Donald
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c8bdd5fa551a84275174b08d35caf7ef9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Tx2MCYz9NAhmUMBCaa6fPoOLPb8R%2be5%2f6hCvsHapVaI%3d

On Mon, Apr 4, 2016 at 1:32 PM, Joe Bowser  wrote:

> Does this require a major version change?
>
> On Mon, Apr 4, 2016, 10:30 AM Richard Knoll  wrote:
>
> > Sorry for being late to comment on this. If we were the only ones 
> > using the class, I would say we should just keep copying around. 
> > However, since other plugins are using it I think it's a good idea 
> > to put it in a common place and a plugin is the best way to do it. 
> > LGTM! Should someone write
> up
> > a blog post about this so that third-party plugins know to update?
> >
> > Thanks,
> > Richard
> >
> > -Original Message-
> > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > Sent: Sunday, April 3, 2016 12:26 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Core Plugins and Android API 23
> >
> > Seems like we have momentum on this. So barring any negative 
> > comments
> from
> > Microsoft about this approach whom do I contact to setup a new repo 
> > on Apache GIT?
> >
> >
> > Simon Mac Donald
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> 2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f45
> 4da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yGzi
> Fs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
> >
> > On Sun, Apr 3, 2016 at 2:26 PM, julio cesar sanchez < 
> > jcesarmob...@gmail.com>
> > wrote:
> >
> > > I like it too
> > > A lot of 3rd party plugins are adding that classes too
> > >
> > > BTW, there is a JIRA issue to add
> > > https://na01.safelinks.protection.outlook.com/?url=PermissionHelpe
> > > r.ja 
> > > va&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08
> > > d35b 
> > > f5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KXea2ILjY6Ja2Q
> > > r4XF %2b8FoLrOpCRvinHQIaqi%2faMSXw%3d to cordova-android 
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
> > > ssue 
> > > s.apache.org%2fjira%2fbrowse%2fCB-10656&data=01%7c01%7criknoll%40m
> > > icro 
> > > soft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab
> > > 2d7c 
> > > d011db47%7c1&sdata=Y6ygyF0AqvvK2VqTcTRSNflpowAn89Xaa%2fTaMFC%2fqlI
> > > %3d
> > >
> > >
> > >
> > > 2016-04-03 18:43 GMT+02:00 Carlos Santana :
> > >
> > > > Simon I like approach
> > > > Can we move to this approach now? Yes Then once the downstream 
> > > > distro's support API 23 and the new API methods in 
> > > > CordovaInterface we can move this into Cordova Android proper? 
> > > > Yes
> > > >
> > > > +1
> > > >
> > > > On Thu, Mar 31, 2016 at 6:38 PM Joe Bowser 
> wrote:
> > > >
> > > > > LGTM!
> > > > >
> > > > > On Thu, Mar 31, 2016 at 3:02 PM, Simon MacDonald < 
> > > > > simon.macdon...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > I really hate the fact we need to add that 
> > > > > > https://na01.safelinks.protection.outlook.com/?url=Permissio
> > > > > > nHel 
> > > > > > per.java&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f
> > > > > > 454d 
> > > > > > a19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sd
> > > > > > ata= KXea2ILjY6Ja2Qr4XF%2b8FoLrOpCRvinHQIaqi%2faMSXw%3d file
> > > > to
> > > > > > each and every plugin that requires API 23 permission support.
> > > > Especially
> > > > > > since the package the class is in is different for each 
> > > > > > plugin so we
> > > > can
> > > > > > two, three or more copies of the same code in an app. That's 
> > > > > > just
> > > > > wasteful.
> > > > > >
> > > > > > Joe responded to my bitching by saying "Maybe we should 
> > > > > > create a permissions plugin for this and make everything go through 
> > > > > > that"
> > > which
> > > > > set
> > > > > > my mind a racing (perhaps I was just over caffeinated) and I 
> > > > > > decided
> > > to
> > > > > > prototype it this afternoon.
> > > > > >
> > > > > > I've created a new plugin called cordova-plugin-compat over 
> > > > > > at https://github.com/macdonst/cordova-plugin-compat  and 
> > > > > > all it does
> > > is
> > > > > > deliver the org.apache.cordova.PermissionHelper class. I 
> > > > > > then turned
> > > > > around
> > > > > > and removed the class from the camera plugin and make
> > > > > cordova-plugin-camera
> > > > > > depend on cordova-plugin-compat.
> > > > > >
> > > > > > You can see that change over on my camera fork:
> > > > > >
> > > > > > https://github.com/macdon

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/59#issuecomment-205411389
  
I'm going to merge this now and get rid of the excess conditionals later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.1.1 iOS Release

[Edna Y Morales]

Please review and vote on this 4.1.1 iOS Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11006

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-11006/

The package was published from its corresponding git tag:
cordova-ios: 4.1.1 (c5c33bad30)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ios#4.1.1

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* Ran mobile-spec (iOS)
* Created and ran hello world iOS app with CLI
* Created and ran hello world iOS app non-CLI
* Tested ./bin/create script
* Tested project upgrade from 4.1.0 to 4.1.1 with CLI
* Tested project upgrade from 4.1.0 to 4.1.1 non-CLI
* Ran cordova-lib tests
* Ran iOS native tests
* Ran coho verify-archive

Thanks,
Edna Morales

Re: [DISCUSS] cordova-ios release

[Edna Y Morales]

Can someone review the blog post?
https://github.com/apache/cordova-docs/pull/571

Thanks,
Edna Morales



From:   Shazron 
To: "dev@cordova.apache.org" 
Date:   03/30/2016 08:28 PM
Subject:Re: [DISCUSS] cordova-ios release



Thanks Edna - appreciated :)

On Wed, Mar 30, 2016 at 8:15 AM, Edna Y Morales 
wrote:

> Hi,
>
> I'd like to drive the release for cordova-ios 4.1.1. Does anyone have any
> oppositions or any reason to wait?
>
> Thanks,
> *Edna Morales*
>
> [image: Inactive hide details for Edna Y Morales---03/24/2016 09:41:54
> AM---bump to this discussion since cordova-common has been relea]Edna Y
> Morales---03/24/2016 09:41:54 AM---bump to this discussion since
> cordova-common has been released Thanks,
>
> From: Edna Y Morales/Durham/IBM@IBMUS
> To: dev@cordova.apache.org
> Date: 03/24/2016 09:41 AM
> Subject: Re: [DISCUSS] cordova-ios release
> --
>
>
>
> bump to this discussion since cordova-common has been released
>
> Thanks,
> *Edna Morales*
>
> Shazron ---03/18/2016 10:34:07 PM---Another issue, the bundled ios-sim
> should be updated: *https://issues.apache.org/jira/browse/CB-10912*
> 
>
> From: Shazron 
> To: "dev@cordova.apache.org" 
> Date: 03/18/2016 10:34 PM
> Subject: Re: [DISCUSS] cordova-ios release
> --
>
>
>
> Another issue, the bundled ios-sim should be updated:
> *https://issues.apache.org/jira/browse/CB-10912*
> 
>
> On Thu, Mar 17, 2016 at 1:58 PM, Edna Y Morales 
> wrote:
>
> > Ok sounds good
> >
> > Thanks,
> > *Edna Morales*
> >
> > [image: Inactive hide details for Carlos Santana ---03/17/2016 04:48:19
> > PM---I agree Steve - Carlos]Carlos Santana ---03/17/2016 04:48:19
PM---I
> > agree Steve - Carlos
> >
> > From: Carlos Santana 
> > To: dev@cordova.apache.org
> > Date: 03/17/2016 04:48 PM
> > Subject: Re: [DISCUSS] cordova-ios release
> > --
> >
> >
> >
> > I agree Steve
> >
> > - Carlos
> > @csantanapr
> >
> > > On Mar 17, 2016, at 4:17 PM, Steven Gill 
> wrote:
> > >
> > > Lets do a common release first and then follow that up with patch ios
> > > release
> > >
> > >> On Thu, Mar 17, 2016 at 11:24 AM, Shazron  wrote:
> > >>
> > >> I would say patch release. I had some items I wanted in the next
> > >> release (labeled cordova-ios-4.1.1), but that shouldn't hold up
> > >> releasing often, keep the train running...
> > >>
> > >> Ideally it should be accompanied with the patches I did yesterday
for
> > >> cordova-common (since cordova-common is bundled in to cordova-ios),
> > >> but those bugs only really affect cordova-cli functionality
> > >>
> > >> On Thu, Mar 17, 2016 at 11:09 AM, Edna Y Morales
 >
> > >> wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> We are interested in a cordova-ios release, specifically for this
> jira
> > >>> item: *https://issues.apache.org/jira/browse/CB-10773*
> 
> > >>>
> > >>> Is there any opposition to this or any reason to wait? Steve would
it
> > >> make
> > >>> sense to wait for a cordova-common release to happen first, before
> > doing
> > >>> the cordova-ios release?
> > >>>
> > >>> Would it be a patch release or a minor release?
> > >>>
> > >>> Thanks,
> > >>> Edna Morales
> > >>
> > >>
-
> > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > >>
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
> >
> >
> >
>
>
>
>
>
>

[GitHub] cordova-docs pull request: CB-11006 add ios@4.1.1 release blog pos...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/571#issuecomment-205420917
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] cordova-ios release

[Mefire O .]

LGTM!

Thanks,
Mefire

From: Edna Y Morales [mailto:eymor...@us.ibm.com]
Sent: Monday, April 4, 2016 10:47 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] cordova-ios release


Can someone review the blog post?
https://github.com/apache/cordova-docs/pull/571

Thanks,
Edna Morales

[Inactive hide details for Shazron ---03/30/2016 08:28:03 PM---Thanks Edna - 
appreciated :) On Wed, Mar 30, 2016 at 8:15 AM, Edn]Shazron ---03/30/2016 
08:28:03 PM---Thanks Edna - appreciated :) On Wed, Mar 30, 2016 at 8:15 AM, 
Edna Y Morales mailto:eymor...@us.ibm.com>> w

From: Shazron mailto:shaz...@gmail.com>>
To: "dev@cordova.apache.org" 
mailto:dev@cordova.apache.org>>
Date: 03/30/2016 08:28 PM
Subject: Re: [DISCUSS] cordova-ios release





Thanks Edna - appreciated :)

On Wed, Mar 30, 2016 at 8:15 AM, Edna Y Morales 
mailto:eymor...@us.ibm.com>> wrote:

> Hi,
>
> I'd like to drive the release for cordova-ios 4.1.1. Does anyone have any
> oppositions or any reason to wait?
>
> Thanks,
> *Edna Morales*
>
> [image: Inactive hide details for Edna Y Morales---03/24/2016 09:41:54
> AM---bump to this discussion since cordova-common has been relea]Edna Y
> Morales---03/24/2016 09:41:54 AM---bump to this discussion since
> cordova-common has been released Thanks,
>
> From: Edna Y Morales/Durham/IBM@IBMUS
> To: dev@cordova.apache.org
> Date: 03/24/2016 09:41 AM
> Subject: Re: [DISCUSS] cordova-ios release
> --
>
>
>
> bump to this discussion since cordova-common has been released
>
> Thanks,
> *Edna Morales*
>
> Shazron ---03/18/2016 10:34:07 PM---Another issue, the bundled ios-sim
> should be updated: *https://issues.apache.org/jira/browse/CB-10912*
> >
>
> From: Shazron mailto:shaz...@gmail.com>>
> To: "dev@cordova.apache.org" 
> mailto:dev@cordova.apache.org>>
> Date: 03/18/2016 10:34 PM
> Subject: Re: [DISCUSS] cordova-ios release
> --
>
>
>
> Another issue, the bundled ios-sim should be updated:
> *https://issues.apache.org/jira/browse/CB-10912*
> >
>
> On Thu, Mar 17, 2016 at 1:58 PM, Edna Y Morales 
> mailto:eymor...@us.ibm.com>>
> wrote:
>
> > Ok sounds good
> >
> > Thanks,
> > *Edna Morales*
> >
> > [image: Inactive hide details for Carlos Santana ---03/17/2016 04:48:19
> > PM---I agree Steve - Carlos]Carlos Santana ---03/17/2016 04:48:19 PM---I
> > agree Steve - Carlos
> >
> > From: Carlos Santana mailto:csantan...@gmail.com>>
> > To: dev@cordova.apache.org
> > Date: 03/17/2016 04:48 PM
> > Subject: Re: [DISCUSS] cordova-ios release
> > --
> >
> >
> >
> > I agree Steve
> >
> > - Carlos
> > @csantanapr
> >
> > > On Mar 17, 2016, at 4:17 PM, Steven Gill 
> > > mailto:stevengil...@gmail.com>>
> wrote:
> > >
> > > Lets do a common release first and then follow that up with patch ios
> > > release
> > >
> > >> On Thu, Mar 17, 2016 at 11:24 AM, Shazron 
> > >> mailto:shaz...@gmail.com>> wrote:
> > >>
> > >> I would say patch release. I had some items I wanted in the next
> > >> release (labeled cordova-ios-4.1.1), but that shouldn't hold up
> > >> releasing often, keep the train running...
> > >>
> > >> Ideally it should be accompanied with the patches I did yesterday for
> > >> cordova-common (since cordova-common is bundled in to cordova-ios),
> > >> but those bugs only really affect cordova-cli functionality
> > >>
> > >> On Thu, Mar 17, 2016 at 11:09 AM, Edna Y Morales mailto:eymor...@us.ibm.com%0b>> >
> > >> wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> We are interested in a cordova-ios release, specifically for this
> jira
> > >>> item: *https://issues.apache.org/jira/browse/CB-10773*
> >
> > >>>
> > >>> Is there any opposition to this or any reason to wait? Steve would it
> > >> make
> > >>> sense to wait for a cordova-common release to happen first, before
> > doing
> > >>> the cordova-ios release?
> > >>>
> > >>> Would i

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media-capture/pull/59


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...

[bhandaribhumin]

Github user bhandaribhumin commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-205434835
  
@guillaumedev please give me full code i'm having issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Paramedic improvements

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/3#discussion_r58423149
  
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,122 @@
+var Q = require('q'),
--- End diff --

Apache license needed in comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205437708
  
This works, but it brings us back to when we used to have to exit lldb 
manually. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205438249
  
I'd prefer this PR be merged into ios-deploy: 
https://github.com/phonegap/ios-deploy/pull/218
That way, we wouldn't have to fix this issue here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[akofman]

Github user akofman commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205441390
  
Sure I 100% agree with that. That's why I asked to @shazron what he thinks. 
If we have to wait 6 months more, I think it's better to keep something working 
instead of the actual situation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205441624
  
Okay, finally got around to testing this on Jelly bean and I found an 
issue: content URIs don't always end in a file type (like .jpg). We try and get 
the filename in `ouputModifiedBitmap` from `getRealPath` (see 
[here](https://github.com/elsewhat/cordova-plugin-camera/blob/CB-10857cordova-plugin-camera/src/android/CameraLauncher.java#L600))
 and so we end up writing to a temporary image without a file extension. I 
don't know if we make assumptions like that anywhere else, but we need to 
address that before merging this. Reproducing camera options:
```
{
mediaType: Camera.MediaType.PICTURE,
destinationType: Camera.DestinationType.FILE_URI,
sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
quality: 50,
allowEdit: false,
encodingType: 0,
correctOrientation: true
saveToPhotoAlbum: true
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/420#issuecomment-205453861
  
@omefire, ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-windows patch release

[Carlos Santana]

bump
Do we have a ETA on this Vote?

On Thu, Mar 31, 2016 at 8:09 AM Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> The PR has been merged. I'm going to start Vote thread soon.
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Tuesday, March 29, 2016 10:33 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] cordova-windows patch release
>
> Can you merge and include CB-10927 [1] ?
>
> [1]: https://github.com/apache/cordova-windows/pull/163
>
>
>
> On Tue, Mar 29, 2016 at 10:47 AM Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > Hi all
> >
> > We'd like to do a cordova-windows patch release to fix the following
> > issues:
> >   * CB-10845 Invalidate manifest cache in prepare (a4c673e3)
> >   * CB-10714 Ignore case for --archs (49812d44)
> >   * CB-10138 Adds missing plugin metadata to plugin_list module for
> > Windows (45e5bd13)
> >
> > The proposed version number for this release is 4.3.2
> >
> > Does anyone have any reason to delay this release? Any other patches I
> > need to include into this release?
> >
> > -
> > Best regards, Vladimir
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

RE: [DISCUSS] cordova-windows patch release

[Vladimir Kotikov (Akvelon)]

I'll start it tomorrow
-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Monday, April 4, 2016 10:23 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] cordova-windows patch release

bump
Do we have a ETA on this Vote?

On Thu, Mar 31, 2016 at 8:09 AM Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> The PR has been merged. I'm going to start Vote thread soon.
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Tuesday, March 29, 2016 10:33 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] cordova-windows patch release
>
> Can you merge and include CB-10927 [1] ?
>
> [1]: https://github.com/apache/cordova-windows/pull/163
>
>
>
> On Tue, Mar 29, 2016 at 10:47 AM Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > Hi all
> >
> > We'd like to do a cordova-windows patch release to fix the following
> > issues:
> >   * CB-10845 Invalidate manifest cache in prepare (a4c673e3)
> >   * CB-10714 Ignore case for --archs (49812d44)
> >   * CB-10138 Adds missing plugin metadata to plugin_list module for 
> > Windows (45e5bd13)
> >
> > The proposed version number for this release is 4.3.2
> >
> > Does anyone have any reason to delay this release? Any other patches 
> > I need to include into this release?
> >
> > -
> > Best regards, Vladimir
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Apache Cordova CI Build Summary - 03/28/16 - 04/04/16

[Sarangan Rajamanickam]

Build Status (Pass/Total):

428/428 - Android on Mac

428/428 - Android on Windows

419/419 - iOS

419/419 - WP 8.1

419/419 - Windows



JIRAs that need attention:

- CB-11016: Android Emulator in Windows has some issues in CI



Next build sheriff: riknoll


Regards
Sarangan Rajamanickam

RE: Apache Cordova CI Build Summary - 03/28/16 - 04/04/16

[Sarangan Rajamanickam]

The iOS has to be 407/419. Sorry for the typo.

Regards
Sarangan Rajamanickam

From: Sarangan Rajamanickam
Sent: Monday, April 4, 2016 12:39 PM
To: 'dev@cordova.apache.org' 
Cc: Richard Knoll ; Nikhil Khandelwal 

Subject: Apache Cordova CI Build Summary - 03/28/16 - 04/04/16


Build Status (Pass/Total):

428/428 - Android on Mac

428/428 - Android on Windows

419/419 - iOS

419/419 - WP 8.1

419/419 - Windows



JIRAs that need attention:

- CB-11016: Android Emulator in Windows has some issues in CI



Next build sheriff: riknoll


Regards
Sarangan Rajamanickam

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58437055
  
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) 
version of File, and you have pre
 cdvfile://localhost/persistent/path/to/file
 
 which can be used in place of the absolute file path in both `download()` 
and `upload()` methods.
+
+## Sample: Download and Upload Files
+
+Use the File-Transfer plugin to upload and download files. In these 
examples, we demonstrate several tasks like:
+
+* Downloading a binary file to the application cache
+* Uploading a file created in your application's root
+* Downloading the uploaded file
+
+## Download a Binary File to the application cache
+
+Use the File plugin with the File-Transfer plugin to provide a target for 
the files that you download (the target must be a FileEntry object). Before you 
download the file, create a DirectoryEntry object by using 
`resolveLocalFileSystemURL` and calling `fs.root` in the success callback. Use 
the `getFile` method of DirectoryEntry to create the target file.
+
+```
--- End diff --

Please add language hints here: js`. This helps with syntax 
highlighting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58437220
  
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) 
version of File, and you have pre
 cdvfile://localhost/persistent/path/to/file
 
 which can be used in place of the absolute file path in both `download()` 
and `upload()` methods.
+
+## Sample: Download and Upload Files
+
+Use the File-Transfer plugin to upload and download files. In these 
examples, we demonstrate several tasks like:
+
+* Downloading a binary file to the application cache
+* Uploading a file created in your application's root
+* Downloading the uploaded file
+
+## Download a Binary File to the application cache
+
+Use the File plugin with the File-Transfer plugin to provide a target for 
the files that you download (the target must be a FileEntry object). Before you 
download the file, create a DirectoryEntry object by using 
`resolveLocalFileSystemURL` and calling `fs.root` in the success callback. Use 
the `getFile` method of DirectoryEntry to create the target file.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+
+// Make sure you add the domain name to the Content-Security-Policy 
 element.
+var url = 'http://cordova.apache.org/static/img/cordova_bot.png';
+fs.root.getFile('downloaded-image.png', { create: true, exclusive: 
false }, function (fileEntry) {
+download(fileEntry, url, true);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+>*Note* For persistent storage, pass LocalFileSystem.PERSISTENT to 
requestFileSystem.
+
+When you have the FileEntry object, download the file using the `download` 
method of the FileTransfer object. The 3rd argument to the function is the 
success handler, which you can use to call the app's `readBinaryFile` function. 
In this code example, the `entry` variable is a new FileEntry object that 
receives the result of the download operation.
+
+```
+function download(fileEntry, uri) {
+
+var fileTransfer = new FileTransfer();
+var fileURL = fileEntry.toURL();
+
+fileTransfer.download(
+uri,
+fileURL,
+function (entry) {
+console.log("download complete: " + entry.toURL());
+readBinaryFile(entry);
+},
+function (error) {
+console.log("download error source " + error.source);
+console.log("download error target " + error.target);
+console.log("upload error code" + error.code);
+},
+null, // or, pass false
+{
+//headers: {
+//"Authorization": "Basic 
dGVzdHVzZXJuYW1lOnRlc3RwYXNzd29yZA=="
+//}
+}
+);
+}
+```
+
+To support operations with binary files, FileReader supports two methods, 
`readAsBinaryString` and `readAsArrayBuffer`. In this example, use 
`readAsArrayBuffer` and pass the FileEntry object to the method. Once you read 
the file successfully, construct a Blob object using the result of the read.
+
+```
+function readBinaryFile(fileEntry) {
+fileEntry.file(function (file) {
+var reader = new FileReader();
+
+reader.onloadend = function (e) {
+
+console.log("Successful file read: " + this.result);
+displayFileData(fileEntry.fullPath + ": " + this.result);
+
+var blob = new Blob([new Uint8Array(this.result)], { type: 
"image/png" });
+displayImageData(blob);
+};
+
+reader.readAsArrayBuffer(file);
+
+}, onErrorReadFile);
+}
+```
+
+Once you read the file successfully, create a DOM URL string using 
`createObjectURL`, and then display the image.
+
+```
+function displayImageData(blob) {
+
+// Note: Use window.URL.revokeObjectURL when finished with image.
+var objURL = window.URL.createObjectURL(blob);
+
+// Displays image if result is a valid DOM string for an image.
+var elem = document.getElementById('imageFile');
+elem.src = objURL;
+}
+```
+
+## Upload a File
+
+When you upload a File using the File-Transfer plugin, use the File plugin 
to provide files for upload (again, they must be FileEntry objects). Before you 
can upload anything, create a file for upload using the `getFile` method of 
DirectoryEntry. In this example, create the file in the application's cache 
(fs.root). Then call the app's writeFile function so you have some content to 
upload.
+
+```
+function on

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58437200
  
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) 
version of File, and you have pre
 cdvfile://localhost/persistent/path/to/file
 
 which can be used in place of the absolute file path in both `download()` 
and `upload()` methods.
+
+## Sample: Download and Upload Files
+
+Use the File-Transfer plugin to upload and download files. In these 
examples, we demonstrate several tasks like:
+
+* Downloading a binary file to the application cache
+* Uploading a file created in your application's root
+* Downloading the uploaded file
+
+## Download a Binary File to the application cache
+
+Use the File plugin with the File-Transfer plugin to provide a target for 
the files that you download (the target must be a FileEntry object). Before you 
download the file, create a DirectoryEntry object by using 
`resolveLocalFileSystemURL` and calling `fs.root` in the success callback. Use 
the `getFile` method of DirectoryEntry to create the target file.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+
+// Make sure you add the domain name to the Content-Security-Policy 
 element.
+var url = 'http://cordova.apache.org/static/img/cordova_bot.png';
+fs.root.getFile('downloaded-image.png', { create: true, exclusive: 
false }, function (fileEntry) {
+download(fileEntry, url, true);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+>*Note* For persistent storage, pass LocalFileSystem.PERSISTENT to 
requestFileSystem.
+
+When you have the FileEntry object, download the file using the `download` 
method of the FileTransfer object. The 3rd argument to the function is the 
success handler, which you can use to call the app's `readBinaryFile` function. 
In this code example, the `entry` variable is a new FileEntry object that 
receives the result of the download operation.
+
+```
+function download(fileEntry, uri) {
+
+var fileTransfer = new FileTransfer();
+var fileURL = fileEntry.toURL();
+
+fileTransfer.download(
+uri,
+fileURL,
+function (entry) {
+console.log("download complete: " + entry.toURL());
+readBinaryFile(entry);
+},
+function (error) {
+console.log("download error source " + error.source);
+console.log("download error target " + error.target);
+console.log("upload error code" + error.code);
+},
+null, // or, pass false
+{
+//headers: {
+//"Authorization": "Basic 
dGVzdHVzZXJuYW1lOnRlc3RwYXNzd29yZA=="
+//}
+}
+);
+}
+```
+
+To support operations with binary files, FileReader supports two methods, 
`readAsBinaryString` and `readAsArrayBuffer`. In this example, use 
`readAsArrayBuffer` and pass the FileEntry object to the method. Once you read 
the file successfully, construct a Blob object using the result of the read.
+
+```
+function readBinaryFile(fileEntry) {
+fileEntry.file(function (file) {
+var reader = new FileReader();
+
+reader.onloadend = function (e) {
+
+console.log("Successful file read: " + this.result);
+displayFileData(fileEntry.fullPath + ": " + this.result);
+
+var blob = new Blob([new Uint8Array(this.result)], { type: 
"image/png" });
+displayImageData(blob);
+};
+
+reader.readAsArrayBuffer(file);
+
+}, onErrorReadFile);
+}
+```
+
+Once you read the file successfully, create a DOM URL string using 
`createObjectURL`, and then display the image.
+
+```
+function displayImageData(blob) {
+
+// Note: Use window.URL.revokeObjectURL when finished with image.
+var objURL = window.URL.createObjectURL(blob);
+
+// Displays image if result is a valid DOM string for an image.
+var elem = document.getElementById('imageFile');
+elem.src = objURL;
+}
+```
+
+## Upload a File
+
+When you upload a File using the File-Transfer plugin, use the File plugin 
to provide files for upload (again, they must be FileEntry objects). Before you 
can upload anything, create a file for upload using the `getFile` method of 
DirectoryEntry. In this example, create the file in the application's cache 
(fs.root). Then call the app's writeFile function so you have some content to 
upload.
+
+```
+function on

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58438965
  
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an 
earlier spec was current:
 It also implements the FileWriter spec :
 
[http://dev.w3.org/2009/dap/file-system/file-writer.html](http://dev.w3.org/2009/dap/file-system/file-writer.html)
 
-For usage, please refer to HTML5 Rocks' excellent [FileSystem 
article.](http://www.html5rocks.com/en/tutorials/file/filesystem/)
+>*Note* For browser targets, some of the file system APIs are deprecated, 
but many of the APIs are supported in Cordova for the non-browser platforms 
listed in the _Supported Platforms_ list (see below).
--- End diff --

I'm concerned that many readers of this may be unfamiliar with the 
"browser" target platform of Cordova, and potentially confused because Cordova 
apps on all platforms are rendered in a web browser control. Can this be made 
clearer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Core Plugins and Android API 23

[Simon MacDonald]

I'm moving forward with 1 as I've requested a new git repo and github
mirror from infra:

https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-11592
https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-11593

once that is done I'll get on to migrating the core plugins to use this as
a dependency once published to NPM.


Simon Mac Donald
http://hi.im/simonmacdonald

On Mon, Apr 4, 2016 at 1:38 PM, Richard Knoll  wrote:

> That sounds right to me. No major version bumps needed.
>
> Richard
>
> -Original Message-
> From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> Sent: Monday, April 4, 2016 10:35 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Core Plugins and Android API 23
>
> In cordova-android? No, I don't think so. For the plugins I'd bump their
> minor version. Make sense?
>
>
> Simon Mac Donald
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c8bdd5fa551a84275174b08d35caf7ef9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Tx2MCYz9NAhmUMBCaa6fPoOLPb8R%2be5%2f6hCvsHapVaI%3d
>
> On Mon, Apr 4, 2016 at 1:32 PM, Joe Bowser  wrote:
>
> > Does this require a major version change?
> >
> > On Mon, Apr 4, 2016, 10:30 AM Richard Knoll 
> wrote:
> >
> > > Sorry for being late to comment on this. If we were the only ones
> > > using the class, I would say we should just keep copying around.
> > > However, since other plugins are using it I think it's a good idea
> > > to put it in a common place and a plugin is the best way to do it.
> > > LGTM! Should someone write
> > up
> > > a blog post about this so that third-party plugins know to update?
> > >
> > > Thanks,
> > > Richard
> > >
> > > -Original Message-
> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > > Sent: Sunday, April 3, 2016 12:26 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
> > >
> > > Seems like we have momentum on this. So barring any negative
> > > comments
> > from
> > > Microsoft about this approach whom do I contact to setup a new repo
> > > on Apache GIT?
> > >
> > >
> > > Simon Mac Donald
> > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> > 2fsimonmacdonald&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f45
> > 4da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yGzi
> > Fs1bd1KAZjUEloAiJ07c9EipxtrtSYxU8e5oO7M%3d
> > >
> > > On Sun, Apr 3, 2016 at 2:26 PM, julio cesar sanchez <
> > > jcesarmob...@gmail.com>
> > > wrote:
> > >
> > > > I like it too
> > > > A lot of 3rd party plugins are adding that classes too
> > > >
> > > > BTW, there is a JIRA issue to add
> > > > https://na01.safelinks.protection.outlook.com/?url=PermissionHelpe
> > > > r.ja
> > > > va&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f454da19d7f08
> > > > d35b
> > > > f5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KXea2ILjY6Ja2Q
> > > > r4XF %2b8FoLrOpCRvinHQIaqi%2faMSXw%3d to cordova-android
> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
> > > > ssue
> > > > s.apache.org%2fjira%2fbrowse%2fCB-10656&data=01%7c01%7criknoll%40m
> > > > icro
> > > > soft.com%7c6d4d4a706f454da19d7f08d35bf5d1e8%7c72f988bf86f141af91ab
> > > > 2d7c
> > > > d011db47%7c1&sdata=Y6ygyF0AqvvK2VqTcTRSNflpowAn89Xaa%2fTaMFC%2fqlI
> > > > %3d
> > > >
> > > >
> > > >
> > > > 2016-04-03 18:43 GMT+02:00 Carlos Santana :
> > > >
> > > > > Simon I like approach
> > > > > Can we move to this approach now? Yes Then once the downstream
> > > > > distro's support API 23 and the new API methods in
> > > > > CordovaInterface we can move this into Cordova Android proper?
> > > > > Yes
> > > > >
> > > > > +1
> > > > >
> > > > > On Thu, Mar 31, 2016 at 6:38 PM Joe Bowser 
> > wrote:
> > > > >
> > > > > > LGTM!
> > > > > >
> > > > > > On Thu, Mar 31, 2016 at 3:02 PM, Simon MacDonald <
> > > > > > simon.macdon...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > I really hate the fact we need to add that
> > > > > > > https://na01.safelinks.protection.outlook.com/?url=Permissio
> > > > > > > nHel
> > > > > > > per.java&data=01%7c01%7criknoll%40microsoft.com%7c6d4d4a706f
> > > > > > > 454d
> > > > > > > a19d7f08d35bf5d1e8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sd
> > > > > > > ata= KXea2ILjY6Ja2Qr4XF%2b8FoLrOpCRvinHQIaqi%2faMSXw%3d file
> > > > > to
> > > > > > > each and every plugin that requires API 23 permission support.
> > > > > Especially
> > > > > > > since the package the class is in is different for each
> > > > > > > plugin so we
> > > > > can
> > > > > > > two, three or more copies of the same code in an app. That's
> > > > > > > just
> > > > > > wasteful.
> > > > > > >
> > > > > > > Joe responded to my bitching by saying "Maybe we should
> > > > > > > create a permissions plugin for this and make everything go
> through that"
> > > > which
> > > > > > set
> > > > > > > my mind a racing (perhaps I was just over 

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58439895
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
--- End diff --

That's not accurate. It's possible to use 
window.resolveLocalFileSystemURL() to get DirectoryEntry and FileEntry objects 
that you can read and write without ever calling window.requestFileSystem() 
first. You may even request a persistent or temporary path using 
cdvfile://localhost/persistent/ or cdvfile://localhost/temporary/. It's 
unfortunately confusing that there is more than one way to do the same thing, 
although each of those 2 APIs can do some things that the other can't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58440889
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
+
+When you get file system access, access is granted for the sandboxed file 
system only (the sandbox limits access to the app itself), not for general 
access to any file system location on the device.
--- End diff --

It's certainly possible to use the file plugin APIs to access some paths 
outside the application sandbox areas, though it may require additional 
permissions, for example READ/WRITE_EXTERNAL_STORAGE on Android. And you would 
need to use resolveLocalFileSystemURL() rather than requestFileSystem().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441476
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
+
+When you get file system access, access is granted for the sandboxed file 
system only (the sandbox limits access to the app itself), not for general 
access to any file system location on the device.
+
+Here is a request for persistent storage.
+
+>*Note* When targeting devices (instead of a browser), you dont need to 
use `requestQuota` before using persistent storage.
+
+```
+window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function (fs) {
+
+console.log('file system open: ' + fs.name);
+fs.root.getFile("newPersistentFile.txt", { create: true, exclusive: 
false }, function (fileEntry) {
+
+console.log("fileEntry is file?" + fileEntry.isFile.toString());
+// fileEntry.name == 'someFile.txt'
+// fileEntry.fullPath == '/someFile.txt'
+writeFile(fileEntry, null);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+The success callback receives FileSystem object (fs). Use `fs.root` to 
return a DirectoryEntry object, which you can use to create or get a file (by 
calling `getFile`). In this example, `fs.root` is a DirectoryEntry object that 
represents the persistent storage in the sandboxed file system.
+
+The success callback for `getFile` receives a FileEntry object. You can 
use this to perform file write and file read operations.
+
+## Create a temporary file
+
+Here is an example of a request for temporary storage. Temporary storage 
may be deleted by the operating system if the device runs low on memory.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+createFile(fs.root, "newTempFile.txt");
+
+}, onErrorLoadFs);
+```
+When you are using temporary storage, you can create or get the file by 
calling `getFile`. As in the persistent storage example, this will give you a 
FileEntry object that you can use for read or write operations.
+
+```
+// Creates a new file or returns the file if it already exists.
+dirEntry.getFile(fileName, {create: true, exclusive: false}, 
function(fileEntry) {
+
+writeFile(fileEntry);
+
+}, onErrorCreateFile);
+```
+
+## Write to a file
+
+Once you have a FileEntry object, you can write to the file by calling 
`createWriter`, which returns a FileWriter object in the success callback. Call 
the `write` method of FileWriter to write to the file.
+
+```
+function writeFile(fileEntry, dataObj) {
+// Create a FileWriter object for our FileEntry (log.txt).
+fileEntry.createWriter(function (fileWriter) {
+
+fileWriter.onwriteend = function (e) {
--- End diff --

Remove the (e) parameter from this callback function, since there is not an 
error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441628
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
+
+When you get file system access, access is granted for the sandboxed file 
system only (the sandbox limits access to the app itself), not for general 
access to any file system location on the device.
+
+Here is a request for persistent storage.
+
+>*Note* When targeting devices (instead of a browser), you dont need to 
use `requestQuota` before using persistent storage.
+
+```
+window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function (fs) {
+
+console.log('file system open: ' + fs.name);
+fs.root.getFile("newPersistentFile.txt", { create: true, exclusive: 
false }, function (fileEntry) {
+
+console.log("fileEntry is file?" + fileEntry.isFile.toString());
+// fileEntry.name == 'someFile.txt'
+// fileEntry.fullPath == '/someFile.txt'
+writeFile(fileEntry, null);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+The success callback receives FileSystem object (fs). Use `fs.root` to 
return a DirectoryEntry object, which you can use to create or get a file (by 
calling `getFile`). In this example, `fs.root` is a DirectoryEntry object that 
represents the persistent storage in the sandboxed file system.
+
+The success callback for `getFile` receives a FileEntry object. You can 
use this to perform file write and file read operations.
+
+## Create a temporary file
+
+Here is an example of a request for temporary storage. Temporary storage 
may be deleted by the operating system if the device runs low on memory.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+createFile(fs.root, "newTempFile.txt");
+
+}, onErrorLoadFs);
+```
+When you are using temporary storage, you can create or get the file by 
calling `getFile`. As in the persistent storage example, this will give you a 
FileEntry object that you can use for read or write operations.
+
+```
+// Creates a new file or returns the file if it already exists.
+dirEntry.getFile(fileName, {create: true, exclusive: false}, 
function(fileEntry) {
+
+writeFile(fileEntry);
+
+}, onErrorCreateFile);
+```
+
+## Write to a file
+
+Once you have a FileEntry object, you can write to the file by calling 
`createWriter`, which returns a FileWriter object in the success callback. Call 
the `write` method of FileWriter to write to the file.
+
+```
+function writeFile(fileEntry, dataObj) {
+// Create a FileWriter object for our FileEntry (log.txt).
+fileEntry.createWriter(function (fileWriter) {
+
+fileWriter.onwriteend = function (e) {
--- End diff --

Same for a few more non-error callbacks below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442202
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
+
+When you get file system access, access is granted for the sandboxed file 
system only (the sandbox limits access to the app itself), not for general 
access to any file system location on the device.
+
+Here is a request for persistent storage.
+
+>*Note* When targeting devices (instead of a browser), you dont need to 
use `requestQuota` before using persistent storage.
+
+```
+window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function (fs) {
+
+console.log('file system open: ' + fs.name);
+fs.root.getFile("newPersistentFile.txt", { create: true, exclusive: 
false }, function (fileEntry) {
+
+console.log("fileEntry is file?" + fileEntry.isFile.toString());
+// fileEntry.name == 'someFile.txt'
+// fileEntry.fullPath == '/someFile.txt'
+writeFile(fileEntry, null);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+The success callback receives FileSystem object (fs). Use `fs.root` to 
return a DirectoryEntry object, which you can use to create or get a file (by 
calling `getFile`). In this example, `fs.root` is a DirectoryEntry object that 
represents the persistent storage in the sandboxed file system.
+
+The success callback for `getFile` receives a FileEntry object. You can 
use this to perform file write and file read operations.
+
+## Create a temporary file
+
+Here is an example of a request for temporary storage. Temporary storage 
may be deleted by the operating system if the device runs low on memory.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+createFile(fs.root, "newTempFile.txt");
+
+}, onErrorLoadFs);
+```
+When you are using temporary storage, you can create or get the file by 
calling `getFile`. As in the persistent storage example, this will give you a 
FileEntry object that you can use for read or write operations.
+
+```
+// Creates a new file or returns the file if it already exists.
+dirEntry.getFile(fileName, {create: true, exclusive: false}, 
function(fileEntry) {
+
+writeFile(fileEntry);
+
+}, onErrorCreateFile);
+```
+
+## Write to a file
+
+Once you have a FileEntry object, you can write to the file by calling 
`createWriter`, which returns a FileWriter object in the success callback. Call 
the `write` method of FileWriter to write to the file.
+
+```
+function writeFile(fileEntry, dataObj) {
+// Create a FileWriter object for our FileEntry (log.txt).
+fileEntry.createWriter(function (fileWriter) {
+
+fileWriter.onwriteend = function (e) {
+console.log("Successful file read...");
+readFile(fileEntry);
+};
+
+fileWriter.onerror = function (e) {
+console.log("Failed file read: " + e.toString());
+};
+
+// If data object is not passed in,
+// create a new Blob instead.
+if (!dataObj) {
+dataObj = new Blob(['some file data'], { type: 'text/plain' });
+}
+
+fileWriter.write(dataObj);
+});
+}
+```
+
+## Read a file
+
+You also need a FileEntry object to read an existing file. Use the file 
property of FileEntry to get the file reference

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442531
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
+
+When you get file system access, access is granted for the sandboxed file 
system only (the sandbox limits access to the app itself), not for general 
access to any file system location on the device.
+
+Here is a request for persistent storage.
+
+>*Note* When targeting devices (instead of a browser), you dont need to 
use `requestQuota` before using persistent storage.
+
+```
+window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function (fs) {
+
+console.log('file system open: ' + fs.name);
+fs.root.getFile("newPersistentFile.txt", { create: true, exclusive: 
false }, function (fileEntry) {
+
+console.log("fileEntry is file?" + fileEntry.isFile.toString());
+// fileEntry.name == 'someFile.txt'
+// fileEntry.fullPath == '/someFile.txt'
+writeFile(fileEntry, null);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+The success callback receives FileSystem object (fs). Use `fs.root` to 
return a DirectoryEntry object, which you can use to create or get a file (by 
calling `getFile`). In this example, `fs.root` is a DirectoryEntry object that 
represents the persistent storage in the sandboxed file system.
+
+The success callback for `getFile` receives a FileEntry object. You can 
use this to perform file write and file read operations.
+
+## Create a temporary file
+
+Here is an example of a request for temporary storage. Temporary storage 
may be deleted by the operating system if the device runs low on memory.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+createFile(fs.root, "newTempFile.txt");
+
+}, onErrorLoadFs);
+```
+When you are using temporary storage, you can create or get the file by 
calling `getFile`. As in the persistent storage example, this will give you a 
FileEntry object that you can use for read or write operations.
+
+```
+// Creates a new file or returns the file if it already exists.
+dirEntry.getFile(fileName, {create: true, exclusive: false}, 
function(fileEntry) {
+
+writeFile(fileEntry);
+
+}, onErrorCreateFile);
+```
+
+## Write to a file
+
+Once you have a FileEntry object, you can write to the file by calling 
`createWriter`, which returns a FileWriter object in the success callback. Call 
the `write` method of FileWriter to write to the file.
+
+```
+function writeFile(fileEntry, dataObj) {
+// Create a FileWriter object for our FileEntry (log.txt).
+fileEntry.createWriter(function (fileWriter) {
+
+fileWriter.onwriteend = function (e) {
+console.log("Successful file read...");
+readFile(fileEntry);
+};
+
+fileWriter.onerror = function (e) {
+console.log("Failed file read: " + e.toString());
+};
+
+// If data object is not passed in,
+// create a new Blob instead.
+if (!dataObj) {
+dataObj = new Blob(['some file data'], { type: 'text/plain' });
+}
+
+fileWriter.write(dataObj);
+});
+}
+```
+
+## Read a file
+
+You also need a FileEntry object to read an existing file. Use the file 
property of FileEntry to get the file reference

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442897
  
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files ##
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage). The code snippets 
in this section demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you can use the File plugin APIs, you must get access to the file 
system using `requestFileSystem`. When you do this, you can request either 
persistent or temporary storage. Persistent storage will not be removed unless 
permission is granted by the user.
+
+When you get file system access, access is granted for the sandboxed file 
system only (the sandbox limits access to the app itself), not for general 
access to any file system location on the device.
+
+Here is a request for persistent storage.
+
+>*Note* When targeting devices (instead of a browser), you dont need to 
use `requestQuota` before using persistent storage.
+
+```
+window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function (fs) {
+
+console.log('file system open: ' + fs.name);
+fs.root.getFile("newPersistentFile.txt", { create: true, exclusive: 
false }, function (fileEntry) {
+
+console.log("fileEntry is file?" + fileEntry.isFile.toString());
+// fileEntry.name == 'someFile.txt'
+// fileEntry.fullPath == '/someFile.txt'
+writeFile(fileEntry, null);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+The success callback receives FileSystem object (fs). Use `fs.root` to 
return a DirectoryEntry object, which you can use to create or get a file (by 
calling `getFile`). In this example, `fs.root` is a DirectoryEntry object that 
represents the persistent storage in the sandboxed file system.
+
+The success callback for `getFile` receives a FileEntry object. You can 
use this to perform file write and file read operations.
+
+## Create a temporary file
+
+Here is an example of a request for temporary storage. Temporary storage 
may be deleted by the operating system if the device runs low on memory.
+
+```
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+createFile(fs.root, "newTempFile.txt");
+
+}, onErrorLoadFs);
+```
+When you are using temporary storage, you can create or get the file by 
calling `getFile`. As in the persistent storage example, this will give you a 
FileEntry object that you can use for read or write operations.
+
+```
+// Creates a new file or returns the file if it already exists.
+dirEntry.getFile(fileName, {create: true, exclusive: false}, 
function(fileEntry) {
+
+writeFile(fileEntry);
+
+}, onErrorCreateFile);
+```
+
+## Write to a file
+
+Once you have a FileEntry object, you can write to the file by calling 
`createWriter`, which returns a FileWriter object in the success callback. Call 
the `write` method of FileWriter to write to the file.
+
+```
+function writeFile(fileEntry, dataObj) {
+// Create a FileWriter object for our FileEntry (log.txt).
+fileEntry.createWriter(function (fileWriter) {
+
+fileWriter.onwriteend = function (e) {
+console.log("Successful file read...");
+readFile(fileEntry);
+};
+
+fileWriter.onerror = function (e) {
+console.log("Failed file read: " + e.toString());
+};
+
+// If data object is not passed in,
+// create a new Blob instead.
+if (!dataObj) {
+dataObj = new Blob(['some file data'], { type: 'text/plain' });
+}
+
+fileWriter.write(dataObj);
+});
+}
+```
+
+## Read a file
+
+You also need a FileEntry object to read an existing file. Use the file 
property of FileEntry to get the file reference

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205487325
  
The thing is that this used to work just fine. Some recent changes might 
have broken it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Plugin Dev Issues

[Michael Lapinski]

Hello,
 I am trying to find the appropriate forum to get support regarding plugin 
development, specifically the proper way to include .so shared objects in a 
plugin.

I have posted in the stack overflow community with the cordova tag and had no 
response. Is there another place that is more regularly monitored and active?

Please reply to m...@mit.edu or michae...@samsung.com as I am not subscribed to 
the list.

-thank you
-mtl

[GitHub] cordova-docs pull request: Changing docs styling.

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/567#issuecomment-205501906
  
@nikhilkh @sarangan12 @riknoll @rakatyal: whenever any of you have any 
time, please give this a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding both Chinese versions.

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/569#discussion_r58451039
  
--- Diff: www/.htaccess ---
@@ -18,29 +18,31 @@ RewriteEngine on
 #   pages to new pages.
 
 # 302 (temp):
-#   docs -> docs/en/latest/
-#   docs/-> docs/en/latest/
-#   docs/XX  -> docs/XX/latest/
-#   docs/XX/ -> docs/XX/latest/
+#   docs/  -> docs/[default language]/
+#   docs/XX-> docs/XX/
+#   docs/XX/   -> docs/XX/latest
+#   docs/XX/latest -> docs/XX/latest/
 #
 # NOTE:
-#   these can both apply, turning "/docs" into "/docs/en/latest/"
-RewriteRule ^.*docs/$ {{site.baseurl}}/docs/en/
-RewriteRule ^.*docs/(\w\w)/$ {{site.baseurl}}/docs/$1/latest/ [R=302,L]
-
-# 302 (temp):
-#   docs/XX/latest -> docs/XX/latest/
-RewriteRule ^.*docs/(\w\w)/latest$ {{site.baseurl}}/docs/$1/latest/ 
[R=302,L]
+#   these can all apply, turning "/docs" into "/docs/[default 
language]/latest/"
+RewriteRule ^.*docs/$ {{site.baseurl}}/docs/{{site.language}}/
+RewriteRule ^.*docs/(\w\w(?:-\w\w)?)$ {{site.baseurl}}/docs/$1/
--- End diff --

@riknoll I've made the change. How does it look now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205502326
  
Ok, so we should change 
```
String fileName = realPath != null ?
realPath.substring(realPath.lastIndexOf('/') + 1) :
"modified." + (this.encodingType == JPEG ? "jpg" : "png");
```
As realPath will not be null anymore it doesn't make any sense.

We have some options:
Detect if the fileName have an extension, if not, then use the 
"modified"... approach.
Try to get the real image name, I think that's possible even for Google 
Drive images.

Any other ideas?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[akofman]

Github user akofman commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205506966
  
Maybe it's related to the last XCode updates. What version are you using ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205507533
  
I'm using XCode Version 7.3 (7D175)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205510819
  
I tested the following PR: https://github.com/phonegap/ios-deploy/pull/218
and unfortunately, it didn't fix the issue for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[akofman]

Github user akofman commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205517434
  
h indeed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205527895
  
Could it be XCode update(from 7.2 to 7.3) that is causing this issue ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[akofman]

Github user akofman commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205528749
  
I think it's more than possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Plugin Dev Issues

[Jesse]

This StackOverflow issue?
http://stackoverflow.com/questions/36366915/cordova-plugin-development-how-to-include-so-libs-correctly-unsatisfiedlin




@purplecabbage
risingj.com

On Mon, Apr 4, 2016 at 1:51 PM, Michael Lapinski 
wrote:

> Hello,
>  I am trying to find the appropriate forum to get support regarding plugin
> development, specifically the proper way to include .so shared objects in a
> plugin.
>
> I have posted in the stack overflow community with the cordova tag and had
> no response. Is there another place that is more regularly monitored and
> active?
>
> Please reply to m...@mit.edu or michae...@samsung.com as I am not
> subscribed to the list.
>
> -thank you
> -mtl
>

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[akofman]

Github user akofman commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-20255
  
XCode 7.2 is using lldb-340.4.119.1 while XCode 7.3 is using 
lldb-350.0.21.3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/212#issuecomment-205559047
  
Hmmm, interesting 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Paramedic improvements

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/3#discussion_r58472035
  
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,205 @@
+#!/usr/bin/env node
+
+var exec = require('./utils').exec,
+shell = require('shelljs'),
+Server = require('./LocalServer'),
+Q = require('q'),
+tmp = require('tmp'),
+PluginsManager = require('./PluginsManager'),
+path = require('path'),
+Q = require('q'),
+fs = require('fs'),
+getReporters = require('./Reporters'),
+logger = require('./utils').logger;
+
+function ParamedicRunner(config, _callback) {
+this.tempFolder = null;
+this.pluginsManager = null;
+
+this.config = config;
+
+exec.setVerboseLevel(config.isVerbose());
+}
+
+ParamedicRunner.prototype.run = function() {
+var self = this;
+
+return Q().then(function() {
+self.createTempProject();
+self.prepareProjectToRunTests();
+return Server.startServer(self.config.getPorts(), 
self.config.getExternalServerUrl(), self.config.getUseTunnel());
+})
+.then(function(server) {
+self.server = server;
+
+self.injectReporters();
+self.subcribeForEvents();
+
+var connectionUrl = server.getConnectionUrl() || 
+
server.getStandartUrlForPlatform(self.config.getPlatformId());
+self.writeMedicConnectionUrl(connectionUrl);
+
+return self.runTests();
+})
+.fin(function() {
+self.cleanUpProject();
+});
+};
+
+ParamedicRunner.prototype.createTempProject = function() {
+this.tempFolder = tmp.dirSync();
+tmp.setGracefulCleanup();
+logger.info("cordova-paramedic: creating temp project at " + 
this.tempFolder.name);
+exec('cordova create ' + this.tempFolder.name);
+shell.pushd(this.tempFolder.name);
+};
+
+ParamedicRunner.prototype.prepareProjectToRunTests = function() {
+this.installPlugins();
+this.setUpStartPage();
+this.installPlatform();
+this.checkPlatformRequirements();
+};
+
+ParamedicRunner.prototype.installPlugins = function() {
+logger.info("cordova-paramedic: installing plugins");
+this.pluginsManager = new PluginsManager(this.tempFolder.name, 
this.storedCWD);
+this.pluginsManager.installPlugins(this.config.getPlugins());
+this.pluginsManager.installTestsForExistingPlugins();
+
this.pluginsManager.installSinglePlugin('cordova-plugin-test-framework');
+this.pluginsManager.installSinglePlugin('cordova-plugin-device');
+this.pluginsManager.installSinglePlugin(path.join(__dirname, 
'../paramedic-plugin'));
+};
+
+ParamedicRunner.prototype.setUpStartPage = function() {
+logger.normal("cordova-paramedic: setting app start page to test 
page");
+shell.sed('-i', 'src="index.html"', 'src="cdvtests/index.html"', 
'config.xml');
+};
+
+ParamedicRunner.prototype.installPlatform = function() {
+logger.normal("cordova-paramedic: adding platform : " + 
this.config.getPlatform());
+exec('cordova platform add ' + this.config.getPlatform());
+};
+
+ParamedicRunner.prototype.checkPlatformRequirements = function() {
+logger.normal("cordova-paramedic: checking requirements for platform " 
+ this.config.getPlatformId());
+var result = exec('cordova requirements ' + 
this.config.getPlatformId());
+
+if (result.code !== 0) 
+throw new Error('Platform requirements check has failed!');
+};
+
+ParamedicRunner.prototype.injectReporters = function() {
+var self = this;
+var reporters = getReporters(self.config.getReportSavePath());
+
+['jasmineStarted', 'specStarted', 'specDone',
+'suiteStarted', 'suiteDone', 'jasmineDone'].forEach(function(route) {
+reporters.forEach(function(reporter) {
+if (reporter[route] instanceof Function)
+self.server.on(route, reporter[route].bind(reporter));
+});
+});
+};
+
+ParamedicRunner.prototype.subcribeForEvents = function() {
+this.server.on('deviceLog', function(data) {
+logger.verbose('device|console.' + data.type + ': '  + 
data.msg[0]);
+});
+
+this.server.on('deviceInfo', function(data) {
+logger.info('cordova-paramedic: Device info: ' + 
JSON.stringify(data));
+});
+};
+
+ParamedicRunner.prototype.writeMedicConnectionUrl = function(url) {
+logger.normal("cordova-paramedic: writing medic log url to project " + 
url);
+fs.writeFileSync(path.join("www","medic.json"), 
JSON.stringify({logurl:url}));
+};

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/137

Removing flaky test assertions about abort callback latency

@nikhilkh @sarangan12 please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
remove-timeouts

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 1a21b4aa9abdeabde22488460b8f4884ccb98de7
Author: Richard Knoll 
Date:   2016-04-05T00:44:46Z

Removing flaky test assertions about abort callback latency




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10942 - Cannot

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/211


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205564464
  
If we can get the real image name, we should do that. However, since we are 
modifying it, we should also mark it as such and put `-modified` at the end or 
something. I've also noticed some weird behavior when we always use the same 
filename after modifying images, so we might need to timestamp those files as 
well. We just need to make sure the cache is cleared on a regular basis, I 
forget if Android handles that automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/137#issuecomment-205565973
  
Now with fewer CI failures! I think this is 
[CB-10536](https://issues.apache.org/jira/browse/CB-10536).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/137#issuecomment-205583342
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [ANNOUNCE] Tools release

[Vladimir Kotikov (Akvelon)]

Blog: http://cordova.apache.org/news/2016/04/04/tools-release.html
Tweet: https://twitter.com/apachecordova/status/71718881055602

-
Best regards, Vladimir

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Monday, April 4, 2016 12:05 PM
To: dev@cordova.apache.org
Subject: [ANNOUNCE] Tools release

Cordova-cli@6.1.1 & Plugman@1.2.1 has been released!
Check out 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwww.npmjs.com%2fpackage%2fcordova&data=01%7c01%7cv-vlkoti%40microsoft.com%7cee563827c0b6496e14a608d35c68442b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6DC0uqzAgg1I0WgEJuJqX1aCHUK1c9%2fIIYbJMxja5Jg%3d
 and 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwww.npmjs.com%2fpackage%2fplugman&data=01%7c01%7cv-vlkoti%40microsoft.com%7cee563827c0b6496e14a608d35c68442b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=y0t2A51KR7vUcOkWgCx%2bIwQEUlpVH74An5llYMrxPX0%3d

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205672785
  
I like the idea, if we can get the real name, then the new image should be 
realname-modified-timestap, if we can't get the real name, then just use 
modified-timestamp.

About the cache, it seems that we should clean it.

> When the device is low on internal storage space, Android may delete 
these cache files to recover space. However, you should not rely on the system 
to clean up these files for you. You should always maintain the cache files 
yourself and stay within a reasonable limit of space consumed, such as 1MB. 
When the user uninstalls your application, these files are removed.



http://developer.android.com/intl/es/guide/topics/data/data-storage.html#ExternalCache


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org