[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63143586
  
--- Diff: src/nightly.js ---
@@ -66,38 +82,19 @@ module.exports = function*(argv) {
 yield gitutil.resetFromOrigin();
 })
 
-//get SHAS from platforms
+// Get SHAS from repos
 var SHAJSON = yield retrieveSha(repos);
 
-//save SHAJSON in cordova-cli repo
-yield repoutil.forEachRepo([cli], function*() {
-//need to get the path to cordova-cli using executil
-var cordovaclidir = process.cwd();
-fs.writeFileSync((path.join(cordovaclidir, 'shas.json')), 
JSON.stringify(SHAJSON, null, 4), 'utf8', function(err) {
-if (err) return console.log (err);
-});
-
-});
-
-//Update platform references at 
cordova-lib/src/cordova/platformsConfig.json
-var cordovalibdir;
-yield repoutil.forEachRepo([cordovaLib], function*() {
-//need to get the path to cordova-lib using executil
-cordovalibdir = process.cwd();
-});
-
-yield updatePlatformsFile(path.join(cordovalibdir, 
'src/cordova/platformsConfig.json'), SHAJSON);
-
-
 var currentDate = new Date();
 var nightlyVersion = '-nightly.' + currentDate.getFullYear() + '.' +
-currentDate.getMonth() + '.' + 
currentDate.getDate();
+pad(currentDate.getMonth() + 1) + '.' + 
pad(currentDate.getDate());
 var cordovaLibVersion;
 //update package.json version for cli + lib, update lib reference for 
cli
 yield repoutil.forEachRepo([cordovaLib, cli], function*(repo) {
 var dir = process.cwd();
 var packageJSON = require(dir+'/package.json');
-packageJSON.version = versionutil.removeDev(packageJSON.version) + 
nightlyVersion;
+packageJSON.version = versionutil.removeDev(packageJSON.version) + 
nightlyVersion +
+'+' + SHAJSON[repo.id];
--- End diff --

> Generally, eight to ten characters are more than enough to be unique 
within a project

(from [Git 
book](https://git-scm.com/book/en/v2/Git-Tools-Revision-Selection#Short-SHA-1)) 
so stripping to 8 characters should be enough for our purposes 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63143895
  
--- Diff: src/nightly.js ---
@@ -45,19 +54,26 @@ module.exports = function*(argv) {
 desc: 'Don\'t actually publish to npm, just print what would 
be run.',
 type:'boolean'
 })
+.options('ignore-test-failures', {
+desc: 'Run the tests for cli and lib but don\'t fail the build 
if the tests are failing',
+type:'boolean',
+alias : 'ignoreTestFailures'
+})
 .argv;
 
 if(argv.h) {
 optimist.showHelp();
 process.exit(1);
 }
-
+
 //Grab currently published nightly version so we can unpublish it later
-//Assumes lib and cli have same version
-var oldNightlyVersion = yield executil.execHelper(executil.ARGS('npm 
view cordova dist-tags.nightly'));
-console.log(oldNightlyVersion);
+var oldNightlyVersions = {};
+oldNightlyVersions.cli = yield executil.execHelper(executil.ARGS('npm 
view cordova dist-tags.nightly'));
+oldNightlyVersions.lib = yield executil.execHelper(executil.ARGS('npm 
view cordova-lib dist-tags.nightly'));
+console.log('oldNightlyVersions: ' + 
JSON.stringify(oldNightlyVersions));
--- End diff --

Please use `apputil.print` to make logging consistent. Also could you 
please update this to print human-readable output instead of raw JSON


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63146122
  
--- Diff: src/nightly.js ---
@@ -128,7 +128,7 @@ module.exports = function*(argv) {
 yield npmpublish.publishTag(options);
 
 //unpublish old nightly
-options.version = oldNightlyVersion;
+options.version = oldNightlyVersions;
 yield npmpublish.unpublish(options);
--- End diff --

I'd rather just call this once per repo, specifying id and version 
separately for each repo. This way you don't need to change anything in 
`src/npm-publish.js`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63146261
  
--- Diff: src/nightly.js ---
@@ -139,13 +139,11 @@ function *updatePlatformsFile(file, shajson) {
 var repos = flagutil.computeReposFromFlag('active-platform');
 
 yield repoutil.forEachRepo(repos, function*(repo) {
-if(repo.id === 'windows') {
-platformsJS[repo.id].version = shajson[repo.id];
-platformsJS['windows8'].version = shajson[repo.id];
-} else if(repo.id === 'blackberry') {
+if (repo.id === 'blackberry') {
--- End diff --

This function is not used anywhere in the code, please remove it for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63147547
  
--- Diff: src/nightly.js ---
@@ -128,7 +128,7 @@ module.exports = function*(argv) {
 yield npmpublish.publishTag(options);
 
 //unpublish old nightly
-options.version = oldNightlyVersion;
+options.version = oldNightlyVersions;
 yield npmpublish.unpublish(options);
--- End diff --

`src/npm-publish.js` will be needed to be updated in this case too as it 
was initially handling a single version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63147626
  
--- Diff: src/nightly.js ---
@@ -45,19 +54,26 @@ module.exports = function*(argv) {
 desc: 'Don\'t actually publish to npm, just print what would 
be run.',
 type:'boolean'
 })
+.options('ignore-test-failures', {
+desc: 'Run the tests for cli and lib but don\'t fail the build 
if the tests are failing',
+type:'boolean',
+alias : 'ignoreTestFailures'
+})
 .argv;
 
 if(argv.h) {
 optimist.showHelp();
 process.exit(1);
 }
-
+
 //Grab currently published nightly version so we can unpublish it later
-//Assumes lib and cli have same version
-var oldNightlyVersion = yield executil.execHelper(executil.ARGS('npm 
view cordova dist-tags.nightly'));
-console.log(oldNightlyVersion);
+var oldNightlyVersions = {};
+oldNightlyVersions.cli = yield executil.execHelper(executil.ARGS('npm 
view cordova dist-tags.nightly'));
+oldNightlyVersions.lib = yield executil.execHelper(executil.ARGS('npm 
view cordova-lib dist-tags.nightly'));
+console.log('oldNightlyVersions: ' + 
JSON.stringify(oldNightlyVersions));
--- End diff --

OK, will this work?
`apputil.print('oldNightlyVersions: ' + JSON.stringify(oldNightlyVersions, 
null, 4));`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11232:

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11232 Appium tests: fixed e...

[alsorokin]

Github user alsorokin commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/214#issuecomment-218987173
  
Restarted the CI check. It passed this time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Nightly builds for Cordova

[Vladimir Kotikov (Akvelon)]

Hi list

I've created a proposal for releasing nightly builds for Cordova. Please find 
details here: https://github.com/cordova/cordova-discuss/pull/42.
I will appreciate any suggestions and feedback.

-
Best regards, Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11261 Cut out '-nightly' prerelease t...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/440

CB-11261 Cut out '-nightly' prerelease tag when checking plugin engines

See the background and explanation at 
[CB-11261](https://issues.apache.org/jira/browse/CB-11261)

This PR is required for tests to pass on nightly builds

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-11261

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #440


commit 2cfd1637882b441e6a4caf0975c1bf1135621afb
Author: Vladimir Kotikov 
Date:   2016-05-12T10:29:33Z

CB-11261 Cut out '-nightly' prerelease tag when checking plugin engines




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-coho/pull/116#issuecomment-219011241
  
LGTM :shipit:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Nightly builds for Cordova

[Carlos Santana]

Love it +1
Always wanted to be able to $ npm install -g cordova@canary

- Carlos
@csantanapr

> On May 13, 2016, at 5:14 AM, Vladimir Kotikov (Akvelon) 
>  wrote:
> 
> Hi list
> 
> I've created a proposal for releasing nightly builds for Cordova. Please find 
> details here: https://github.com/cordova/cordova-discuss/pull/42.
> I will appreciate any suggestions and feedback.
> 
> -
> Best regards, Vladimir
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11261 Cut out '-nightly' prerelease t...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/440#issuecomment-219013373
  
Looks like tests are failing due to not yet published 
`cordova-common@1.3.0` dependency for `cordova-fetch`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova Monthly Hangouts

[julio cesar sanchez]

+1

I'll be traveling the next two weeks (not pg day 😞), so I prefer after the
29th.

Steve, can you send the doodle?


El jueves, 12 de mayo de 2016, Shazron  escribió:

> +1
>
> On Wed, May 11, 2016 at 12:50 PM, Steven Gill  >
> wrote:
>
> > A hangout sounds good. We need to pick a date and time. Should I send
> out a
> > doodle?
> >
> > For me personally, I won't be able to attend until the first week of June
> > due to PGDAY EU travels.
> >
> > On Tue, May 10, 2016 at 11:55 AM, Parashuram N  >
> > wrote:
> >
> > > It has been a while since all of us met, so I was wondering if it would
> > > help to do a Cordova Monthly hangout ? I also understand that we have
> > > Phonegap day EU this month, and maybe we could use that timeframe to
> get
> > > more folks involved in the hangout ? For the rest of us who could not
> > > attend Phonegap day EU, we could do the hangount. It may also help
> other
> > > community members see how we do hangouts, and may be a way to encourage
> > > them to participate even more ?
> > >
> > > I was thinking that we could discuss some of the following topics
> > >
> > >
> > > 1.   Cordova Telemetry work that Mefire is working on - driving
> that
> > > to a Closure, and ensuring that all developers and toolsmiths are good
> > with
> > > the proposal and the data we collect
> > >
> > > 2.   Talk about our Bug Tirage bar, look at ways to reduce
> > outstanding
> > > bug count and look at the work around running tests on every PR
> > >
> > > 3.   Follow up on the idea of a Cordova Roadmap
> > >
> > > Any other ideas ? I could start a Cordova discuss.
> > >
> >
>

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/116


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7094 Use correct package name when u...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-coho/pull/120

CB-7094 Use correct package name when unpublishing old nightly



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-coho CB-7904

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #120


commit 6f57d6dc9f7f537d4717fff803fa2bae32e9a2b3
Author: Vladimir Kotikov 
Date:   2016-05-13T12:28:57Z

CB-7094 Use correct package name when unpublishing old nightly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7094 Use correct package name when u...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[mirko77]

Github user mirko77 commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-219067019
  
@shazron @stevengill 

Still not loading on iOS 9.3 (iPad Air 2 ) with Cordova iOS @4.1.0. It gets 
stuck at splashscreen. Loads fine via Xcode 7.3

steps to reproduce:


`cordova create hello com.example.hello HelloWorld`
`cd hello`
`cordova platform add ios@4.1.0`
'cordova run ios -device'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Remove zero-padding to make ver...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-coho/pull/121

CB-7904 Remove zero-padding to make version fully semver-compatible



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-coho CB-7904

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #121


commit 2fb8df07d427d2a50604564bf52c619d0b7b3622
Author: daserge 
Date:   2016-05-13T15:04:17Z

CB-7904 Remove zero-padding to make version fully semver-compatible




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[colonelchlorine]

Github user colonelchlorine commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/270#discussion_r6311
  
--- Diff: bin/templates/project/build.gradle ---
@@ -197,7 +197,12 @@ android {
 }
 }
 }
-} else if (!cdvVersionCode) {
+}
+/*
+
+ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
--- End diff --

Best piece of code ever written. Why is Cordova doing this in the first 
place?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[rpayanm]

Github user rpayanm commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-219073094
  
Do you test on iOS @4.1.1?
http://cordova.apache.org/announcements/2016/04/04/ios-4.1.1.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

[macdonst]

Github user macdonst commented on the pull request:

https://github.com/apache/cordova-lib/pull/432#issuecomment-219075301
  
@ktop, @stevengill my environment seems to be in a bad state. I've got 
problems with cordova-fetch and the new telemetry stuff I'm working through. 
Right now when I try to test this PR the lines get added multiple times instead 
of merged. I don't think that is a problem with the PR but rather my env right 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...

[alsorokin]

Github user alsorokin commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219080266
  
@riknoll I've updated the PR.
* De-duplicated specs code
* Implemented image type verification
* Added a couple of specs with quality 100 (adding it to combined specs 
would double their number)
* Implemented URI type verification for iOS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: Adding Instructions for Jenkins setup

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/104#discussion_r63209355
  
--- Diff: JENKINS.md ---
@@ -0,0 +1,123 @@
+# Jenkins Master Setup
+## Purpose
+The purpose of this document is to provide instructions on 
installation/deployment of the Jenkins master machine.
+
+## Jenkins Installation
+The Jenkins Installation instructions could be found [here][Jenkins 
Installation].
+
+## Plugins Installation
+* [GitHub Pull Request Builder Plugin][GitHub Pull Request Builder Plugin]
+* [Github Authentication plugin][Github Authentication plugin]
+* [Multiple SCMs plugin][Multiple SCMs plugin]
+
+These plugins, listed above, needs to be installed on the Jenkins master. 
These plugins are installed along with their dependencies (automatically). 
Steps on installing the plugins could be found [here][Jenkins Plugins].
+
+_Note_: A restart of the jenkins server is required after plugin 
installation
+
+## GitHub User Creation
+A new GitHub user has to be created for the purpose of CI. This user will 
be used for 2 purposes:
+
+* To update the status of the CI jobs in the PR (success/failure).
+* To create a new OAuth Application that is used to authenticate users 
into your CI system [This topic will be covered while configuring Github 
Authentication Plugin]
+
+For the initial setup, a new GitHub User has been created with id - 
[Cordova QA][Cordova QA] and associated with 
[apachecordova...@gmail.com][apachecordova...@gmail.com]
+
+## GitHub OAuth Application Creation
+Once a GitHub User has been created, it is time to create a new OAuth 
Application. This application will be used to login users into your CI system 
and provide them with the required access rights (such as admin, read only, 
etc.). The steps to create the OAuth Application could be found [here][OAuth 
Application Creation Instruction]
+
+## Authentication Configuration
+* Go to Jenkins Home Page -> Manage Jenkins -> Configure Global Security
+* Check *Enable Security* checkbox
+* Under Access Control ->  Security Realm, Select *Github Authentication 
Plugin*
+* The following items must be configured under *Global Github OAuth 
Settings*:
+* *GitHub Web URI*: https://github.com
+* *GitHub API URI*: https://api.github.com
+* *Client Id*: *Client Id from the newly created GitHub OAuth 
Application*
+* *Client Secret*: *Client Secret from the newly created GitHub OAuth 
Application*
+* *OAuth Scope*: read:org,user:email
+* Under Authorization, Select *GitHub Commiter Authorization Strategy*
+* The following items must be configured under *GitHub Authorization 
Settings*
+* *Admin User names*: Provide the github usernames of the persons to 
be designated as admins. 
+* Check *Grant READ permissions to all Authenticated Users*
+* Check *Grant READ permissions for Anonymous Users*
+* Check *Grant ViewStatus permissions for Anonymous Users* 
+
+__Note__: The OAuth scope could be modified per requirements. Details on 
the scopes could be found [here][GitHub OAuth Scopes]. But it is important to 
remember that "read:org,user:email" are basic and **mandatory** requirements 
for the Authentication plugin. If the scope does not contain them, then the 
authentication will fail. 
+
+## Port Configuration
+The Jenkins slaves uses a TCP Port to connect to the Master machine. 
Jenkins provides the option to use a fixed port or random port. If your master 
machine is on Cloud (such as Azure), you must choose the Fixed port and also 
open that port on the master machine in cloud.
+
+### On Jenkins
+* Go to Jenkins Home Page -> Manage Jenkins -> Configure Global Security
+* Check *Enable Security* checkbox
+* Under *TCP port for JNLP slave agents*, choose *Fixed* and provide the 
port number (such as 49666)
+
+### On Master Machine in cloud 
+In Azure cloud, you need to open this port as an end point. By default, 
this port will have an idle timeout of 4 minutes. This will not be sufficient. 
So, we need to use Azure Powershell Tools, to modify this value (There is no UI 
option to modify this). The following command could be used to create a port 
and set the idle timeout value. 
+
+```Get-AzureVM -ServiceName cordova-ci -Name cordova-ci | 
Add-AzureEndpoint -Name "JenkinsSlave" -Protocol "tcp" -PublicPort 49666 
-LocalPort 49666 -IdleTimeoutInMinutes 30 | Update-AzureVM```
+
+## Job Creation
+* Go to Jenkins Home Page -> New Item
+* Provide a *Item Name* (Such as "cordova-plugin-console")
+* Choose *Multi-configuration project*
+* Click *Ok*
+* Provide a *Description*
+* Check *GitHub Project*. Provide the correct project URL. (__Note__: This 
is an important parameter. GitHub Pull Request will not

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/270#discussion_r63209862
  
--- Diff: bin/templates/project/build.gradle ---
@@ -197,7 +197,12 @@ android {
 }
 }
 }
-} else if (!cdvVersionCode) {
+}
+/*
+
+ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
--- End diff --

If you're building multiple apks for different architectures (for 
Crosswalk) - there is a need to generate unique version codes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11262 Add a warning about prerelease ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-cli/pull/251

CB-11262 Add a warning about prerelease lib/cli usage

[Jira issue](https://issues.apache.org/jira/browse/CB-11262)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli CB-11262

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #251


commit 9939a0a69058a4bdfd6f4cce86629ff8bfbdee94
Author: daserge 
Date:   2016-05-13T16:07:14Z

CB-11262 Add a warning about prerelease lib/cli usage




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Extended LTS version

[Nikhil Khandelwal]

I wanted to bring this to the dev list's attention: 
https://github.com/cordova/cordova-discuss/issues/39.

The idea is to have an LTS version of cordova. It might be a good idea to 
re-visit & document our release cadence as well.

-Nikhil

[GitHub] cordova-lib pull request: Add language hint to fenced code blocks

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-lib/pull/441

Add language hint to fenced code blocks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nikhilkh/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #441


commit 17a49f52526c603c0041e4f4d00ad9b4021d9c0d
Author: Nikhil Khandelwal 
Date:   2016-05-13T16:45:28Z

Update README.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Add language hint to fenced code blocks

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/441


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Extended LTS version

[julio cesar sanchez]

But for the CLI? For each platform?

I don't think it makes sense on iOS platform where a new iOS version is
released every year and apple ends forcing to use latest SDK sooner or
later, and on new releases some things are broken and people needs to
update cordova-ios to make them work.
Might make sense on android wher google allows you to use the sdk you want
and things keep working in a "compatibility mode".

But making sure the plugins keep working on all the LTS versions for 3-5
years will need a lot of work

El viernes, 13 de mayo de 2016, Nikhil Khandelwal 
escribió:

> I wanted to bring this to the dev list's attention:
> https://github.com/cordova/cordova-discuss/issues/39.
>
> The idea is to have an LTS version of cordova. It might be a good idea to
> re-visit & document our release cadence as well.
>
> -Nikhil
>
>

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-windows/pull/177

CB-11204: Catch when SDK not present on build and provide appropriate…

… message

Currently we don't have any check before calling the build through msbuild 
which doesn't give a meaningful error when the required SDK is not installed. 
We should catch this before and respond with the appropriate error message.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows 
raghav/build_message

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #177


commit fa0bfa01491093a895e01edd2a4938bdc32d1b75
Author: Raghav Katyal 
Date:   2016-05-13T17:27:11Z

CB-11204: Catch when SDK not present on build and provide appropriate 
message




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219108455
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/252

CB-11263: 'cordova telemetry help' should display help text



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli CB-11263

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit 9158085fd98c6fc20d7e9e4d762dbfc3c6043e44
Author: Omar Mefire 
Date:   2016-05-13T17:32:24Z

CB-11263: 'cordova telemetry help' should display help text




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Extended LTS version

[Joe Bowser]

On Fri, May 13, 2016 at 10:19 AM, julio cesar sanchez <
jcesarmob...@gmail.com> wrote:

> But for the CLI? For each platform?
>
> I don't think it makes sense on iOS platform where a new iOS version is
> released every year and apple ends forcing to use latest SDK sooner or
> later, and on new releases some things are broken and people needs to
> update cordova-ios to make them work.
> Might make sense on android wher google allows you to use the sdk you want
> and things keep working in a "compatibility mode".
>

I don't think we have the resources to maintain a compatibility mode
version of Cordova for Android and a version that compiles against the edge
version.  Also, there's the whole problem with backporting security
vulnerabilities.  I know that a lot of people want things to just not
change ever, but that's completely unrealistic given that we have people
trying to attack Cordova-based applications.


>
> But making sure the plugins keep working on all the LTS versions for 3-5
> years will need a lot of work
>
> El viernes, 13 de mayo de 2016, Nikhil Khandelwal 
> escribió:
>
> > I wanted to bring this to the dev list's attention:
> > https://github.com/cordova/cordova-discuss/issues/39.
> >
> > The idea is to have an LTS version of cordova. It might be a good idea to
> > re-visit & document our release cadence as well.
> >
> > -Nikhil
> >
> >
>

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/252#issuecomment-219108920
  
@riknoll to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[codecov-io]

Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-windows/pull/177#issuecomment-219109183
  
## [Current coverage][cc-pull] is **72.71%**
> Merging [#177][cc-pull] into [master][cc-base-branch] will decrease 
coverage by **-0.70%**

```diff
@@ master   #177   diff @@
==
  Files14 14  
  Lines  1862   1880+18   
  Methods 342347 +5   
  Messages  0  0  
  Branches379384 +5   
==
  Hits   1367   1367  
- Misses  495513+18   
  Partials  0  0  
```



> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[f4e20a3...43831e5][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-windows/compare/f4e20a3a10dcdc038abe3699d7a4f6576cc8eded...43831e5ba819bfe05bef381b5ceb17fae8ad5a4e
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/177?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/252#issuecomment-219109613
  
travis-ci failure is not related to this change, it's related to 
cordova-fetch not being in npm.
I ran the tests locally and they do pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219111323
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova Monthly Hangouts

[Jesse]

Here's a doodle for a hangout. Let me know if I should extend the hours
past 8:00 AM - 7:00 PM Pacific.
http://doodle.com/poll/xvifrwwnqci2fti3


@purplecabbage
risingj.com

On Fri, May 13, 2016 at 4:09 AM, julio cesar sanchez  wrote:

> +1
>
> I'll be traveling the next two weeks (not pg day 😞), so I prefer after the
> 29th.
>
> Steve, can you send the doodle?
>
>
> El jueves, 12 de mayo de 2016, Shazron  escribió:
>
> > +1
> >
> > On Wed, May 11, 2016 at 12:50 PM, Steven Gill  > >
> > wrote:
> >
> > > A hangout sounds good. We need to pick a date and time. Should I send
> > out a
> > > doodle?
> > >
> > > For me personally, I won't be able to attend until the first week of
> June
> > > due to PGDAY EU travels.
> > >
> > > On Tue, May 10, 2016 at 11:55 AM, Parashuram N  > >
> > > wrote:
> > >
> > > > It has been a while since all of us met, so I was wondering if it
> would
> > > > help to do a Cordova Monthly hangout ? I also understand that we have
> > > > Phonegap day EU this month, and maybe we could use that timeframe to
> > get
> > > > more folks involved in the hangout ? For the rest of us who could not
> > > > attend Phonegap day EU, we could do the hangount. It may also help
> > other
> > > > community members see how we do hangouts, and may be a way to
> encourage
> > > > them to participate even more ?
> > > >
> > > > I was thinking that we could discuss some of the following topics
> > > >
> > > >
> > > > 1.   Cordova Telemetry work that Mefire is working on - driving
> > that
> > > > to a Closure, and ensuring that all developers and toolsmiths are
> good
> > > with
> > > > the proposal and the data we collect
> > > >
> > > > 2.   Talk about our Bug Tirage bar, look at ways to reduce
> > > outstanding
> > > > bug count and look at the work around running tests on every PR
> > > >
> > > > 3.   Follow up on the idea of a Cordova Roadmap
> > > >
> > > > Any other ideas ? I could start a Cordova discuss.
> > > >
> > >
> >
>

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219110936
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94/


**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/94//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219113129
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/95//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219113303
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/177#issuecomment-219113567
  
@vladimir-kotikov to help review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova Monthly Hangouts

[Kerri Shotts]

Thanks for posting the doodle! I've put in my availability.

*Kerri Shotts*, photoKandy Studios LLC • (312) 380–1035 • (618) 435–0823
*(mobile)*

http://www.photokandy.com/ • @photokandy  •
Github  • CoderWall


Apps on the Apple  Store →



→ *CONFIDENTIAL* ←

This email and any attachments may be confidential. If you are not the
intended recipient, please let us know by replying to this message, and
then remove the message and its attachments from your system. You should
not disseminate, distribute, or otherwise copy or release the information
contained herein, nor can we accept any liability for any loss or damages
resulting from the use, abuse, or mis-use of the information contained
herein.

→ *SECURITY* ←

Computer viruses can be distributed via email. It is the recipient’s
responsibility to check this email and any attachments for viruses. Email
transmission cannot be guaranteed to be secure or error-free as the email
could have been intercepted, corrupted, delayed, and/or re-transmitted. The
sender does not accept any liability for errors or omissions within this
message or its attachments, nor for any viruses which may be present.

*Note:* We do our very best to ensure that nothing we send contains
viruses. However, because of the nature of email and the way it is sent, we
can’t promise that some other party hasn’t intercepted our email and added
malicious content. Due to the nature of email, we can’t accept any
liability for any damage or loss arising from the use, abuse, or mis-use of
this email and any of its attachments.

→ *PRIVACY* ←

Email is not a secure communications medium. When replying to this or any
message, you should not include any information that you do not want the
entire world to be capable of seeing. In other words, don’t send financial
accounts (CC#s, Bank Account #s, etc.), passwords, social security numbers,
or the like, even when asked directly. photoKandy Studios LLC will *never*  ask
you for this information.

Information transmitted via email may be intercepted and retransmitted by
any number of other entities. This is the nature of email, and as such, we
can’t be held liable for any loss or damage incurred by replying to this
message with compromising information. Review your message prior to sending
it, and ensure that there is no information you wouldn’t be comfortable
with the entire world knowing.

On Fri, May 13, 2016 at 12:43 PM, Jesse  wrote:

> Here's a doodle for a hangout. Let me know if I should extend the hours
> past 8:00 AM - 7:00 PM Pacific.
> http://doodle.com/poll/xvifrwwnqci2fti3
>
>
> @purplecabbage
> risingj.com
>
> On Fri, May 13, 2016 at 4:09 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > +1
> >
> > I'll be traveling the next two weeks (not pg day 😞), so I prefer after
> the
> > 29th.
> >
> > Steve, can you send the doodle?
> >
> >
> > El jueves, 12 de mayo de 2016, Shazron  escribió:
> >
> > > +1
> > >
> > > On Wed, May 11, 2016 at 12:50 PM, Steven Gill  > > >
> > > wrote:
> > >
> > > > A hangout sounds good. We need to pick a date and time. Should I send
> > > out a
> > > > doodle?
> > > >
> > > > For me personally, I won't be able to attend until the first week of
> > June
> > > > due to PGDAY EU travels.
> > > >
> > > > On Tue, May 10, 2016 at 11:55 AM, Parashuram N <
> panar...@microsoft.com
> > > >
> > > > wrote:
> > > >
> > > > > It has been a while since all of us met, so I was wondering if it
> > would
> > > > > help to do a Cordova Monthly hangout ? I also understand that we
> have
> > > > > Phonegap day EU this month, and maybe we could use that timeframe
> to
> > > get
> > > > > more folks involved in the hangout ? For the rest of us who could
> not
> > > > > attend Phonegap day EU, we could do the hangount. It may also help
> > > other
> > > > > community members see how we do hangouts, and may be a way to
> > encourage
> > > > > them to participate even more ?
> > > > >
> > > > > I was thinking that we could discuss some of the following topics
> > > > >
> > > > >
> > > > > 1.   Cordova Telemetry work that Mefire is working on - driving
> > > that
> > > > > to a Closure, and ensuring that all developers and toolsmiths are
> > good
> > > > with
> > > > > the proposal and the data we collect
> > > > >
> > > > > 2.   Talk about our Bug Tirage bar, look at ways to reduce
> > > > outstanding
> > > > > bug count and look at the work around running tests on every PR
> > > > >
> > > > > 3.   Follow up on the idea of a Cordova Roadmap
> > > > >
> > > > > Any other ideas ? I could start a Cordova discuss.
> > > > >
> > > >
> > >
> >
>

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-cli/pull/252#issuecomment-219114198
  
LGTM. Returning help isn't really consistent with any other commands in the 
CLI. Platform-specific ones (prepare, build, clean, etc.) generally throw an 
error and the plugin/platform commands perform an `ls`. That being said, help 
seems like as good a response as any.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Extended LTS version

[Jesse]

... and platform updates that can break existing functionality, which come
out every about every 3 months between our various devices/platforms.
If people are willing to not update their devices or machines or software,
and there are never any security exploits then everything will just work
forever.
I think 3-5 years is absurd, browsers barely guarantee that 5 year old
html/css/js will work.







@purplecabbage
risingj.com

On Fri, May 13, 2016 at 10:33 AM, Joe Bowser  wrote:

> On Fri, May 13, 2016 at 10:19 AM, julio cesar sanchez <
> jcesarmob...@gmail.com> wrote:
>
> > But for the CLI? For each platform?
> >
> > I don't think it makes sense on iOS platform where a new iOS version is
> > released every year and apple ends forcing to use latest SDK sooner or
> > later, and on new releases some things are broken and people needs to
> > update cordova-ios to make them work.
> > Might make sense on android wher google allows you to use the sdk you
> want
> > and things keep working in a "compatibility mode".
> >
>
> I don't think we have the resources to maintain a compatibility mode
> version of Cordova for Android and a version that compiles against the edge
> version.  Also, there's the whole problem with backporting security
> vulnerabilities.  I know that a lot of people want things to just not
> change ever, but that's completely unrealistic given that we have people
> trying to attack Cordova-based applications.
>
>
> >
> > But making sure the plugins keep working on all the LTS versions for 3-5
> > years will need a lot of work
> >
> > El viernes, 13 de mayo de 2016, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> > escribió:
> >
> > > I wanted to bring this to the dev list's attention:
> > > https://github.com/cordova/cordova-discuss/issues/39.
> > >
> > > The idea is to have an LTS version of cordova. It might be a good idea
> to
> > > re-visit & document our release cadence as well.
> > >
> > > -Nikhil
> > >
> > >
> >
>

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219115890
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96/


**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/96//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219121203
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219123766
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/97//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11204: Updating windows platform req...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/602

CB-11204: Updating windows platform requirement instructions for inst…

…alling required SDKs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav/win_sdk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #602


commit b33fa769d1e49e9542b804bd123380fbcf7c2361
Author: Raghav Katyal 
Date:   2016-05-13T18:29:56Z

CB-11204: Updating windows platform requirement instructions for installing 
required SDKs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11204: Updating windows platform req...

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/602#issuecomment-219124007
  
@riknoll , @omefire : Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219124313
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219126335
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98/


**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/98//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Remove zero-padding to make ver...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-coho/pull/121#issuecomment-219127567
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219128085
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219130325
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99/


**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/99//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Remove zero-padding to make ver...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219130596
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10139 browser: Respect targ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/210


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11228 browser: Add classes ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/212


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219132562
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/100//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219132721
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: Adding Instructions for Jenkins setup

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/104#discussion_r63235948
  
--- Diff: JENKINS.md ---
@@ -0,0 +1,123 @@
+# Jenkins Master Setup
+## Purpose
+The purpose of this document is to provide instructions on 
installation/deployment of the Jenkins master machine.
+
+## Jenkins Installation
+The Jenkins Installation instructions could be found [here][Jenkins 
Installation].
+
+## Plugins Installation
+* [GitHub Pull Request Builder Plugin][GitHub Pull Request Builder Plugin]
+* [Github Authentication plugin][Github Authentication plugin]
+* [Multiple SCMs plugin][Multiple SCMs plugin]
+
+These plugins, listed above, needs to be installed on the Jenkins master. 
These plugins are installed along with their dependencies (automatically). 
Steps on installing the plugins could be found [here][Jenkins Plugins].
+
+_Note_: A restart of the jenkins server is required after plugin 
installation
+
+## GitHub User Creation
+A new GitHub user has to be created for the purpose of CI. This user will 
be used for 2 purposes:
+
+* To update the status of the CI jobs in the PR (success/failure).
+* To create a new OAuth Application that is used to authenticate users 
into your CI system [This topic will be covered while configuring Github 
Authentication Plugin]
+
+For the initial setup, a new GitHub User has been created with id - 
[Cordova QA][Cordova QA] and associated with 
[apachecordova...@gmail.com][apachecordova...@gmail.com]
+
+## GitHub OAuth Application Creation
+Once a GitHub User has been created, it is time to create a new OAuth 
Application. This application will be used to login users into your CI system 
and provide them with the required access rights (such as admin, read only, 
etc.). The steps to create the OAuth Application could be found [here][OAuth 
Application Creation Instruction]
+
+## Authentication Configuration
+* Go to Jenkins Home Page -> Manage Jenkins -> Configure Global Security
+* Check *Enable Security* checkbox
+* Under Access Control ->  Security Realm, Select *Github Authentication 
Plugin*
+* The following items must be configured under *Global Github OAuth 
Settings*:
+* *GitHub Web URI*: https://github.com
+* *GitHub API URI*: https://api.github.com
+* *Client Id*: *Client Id from the newly created GitHub OAuth 
Application*
+* *Client Secret*: *Client Secret from the newly created GitHub OAuth 
Application*
+* *OAuth Scope*: read:org,user:email
+* Under Authorization, Select *GitHub Commiter Authorization Strategy*
+* The following items must be configured under *GitHub Authorization 
Settings*
+* *Admin User names*: Provide the github usernames of the persons to 
be designated as admins. 
+* Check *Grant READ permissions to all Authenticated Users*
+* Check *Grant READ permissions for Anonymous Users*
+* Check *Grant ViewStatus permissions for Anonymous Users* 
+
+__Note__: The OAuth scope could be modified per requirements. Details on 
the scopes could be found [here][GitHub OAuth Scopes]. But it is important to 
remember that "read:org,user:email" are basic and **mandatory** requirements 
for the Authentication plugin. If the scope does not contain them, then the 
authentication will fail. 
+
+## Port Configuration
+The Jenkins slaves uses a TCP Port to connect to the Master machine. 
Jenkins provides the option to use a fixed port or random port. If your master 
machine is on Cloud (such as Azure), you must choose the Fixed port and also 
open that port on the master machine in cloud.
+
+### On Jenkins
+* Go to Jenkins Home Page -> Manage Jenkins -> Configure Global Security
+* Check *Enable Security* checkbox
+* Under *TCP port for JNLP slave agents*, choose *Fixed* and provide the 
port number (such as 49666)
+
+### On Master Machine in cloud 
+In Azure cloud, you need to open this port as an end point. By default, 
this port will have an idle timeout of 4 minutes. This will not be sufficient. 
So, we need to use Azure Powershell Tools, to modify this value (There is no UI 
option to modify this). The following command could be used to create a port 
and set the idle timeout value. 
+
+```Get-AzureVM -ServiceName cordova-ci -Name cordova-ci | 
Add-AzureEndpoint -Name "JenkinsSlave" -Protocol "tcp" -PublicPort 49666 
-LocalPort 49666 -IdleTimeoutInMinutes 30 | Update-AzureVM```
+
+## Job Creation
+* Go to Jenkins Home Page -> New Item
+* Provide a *Item Name* (Such as "cordova-plugin-console")
+* Choose *Multi-configuration project*
+* Click *Ok*
+* Provide a *Description*
+* Check *GitHub Project*. Provide the correct project URL. (__Note__: This 
is an important parameter. GitHub Pull Request will n

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63236780
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
--- End diff --

It seems like ```getInstalledWindowsSdks()``` doesn't return an array in 
all cases, i.e: when an exception occurs while running the registry query. 
Maybe, modify it to return an empty array in such a case, otherwise we'll error 
out here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219134801
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/101//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219134903
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63237158
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
--- End diff --

same goes for ```isPhoneSDKPresent()```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/215

Moving message in PR template to a comment

### Platforms affected
None!

### What does this PR do?
Change the template that I am currently filling out so that the checklist 
message is in a comment

### What testing has been done on this change?
Absolutely none.

### Checklist
Please make sure these boxes are checked before submitting the PR. This 
checklist is intended as a quick reference, for complete details please see our 
[Contributor 
Guidelines](http://cordova.apache.org/contribute/contribute_guidelines.html). 
Thanks!
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database 
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Add automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera 
template-to-comment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #215


commit 2eef09686173cb0ea6f62b29953b702769f88858
Author: Richard Knoll 
Date:   2016-05-13T19:14:03Z

Moving message in PR template to a comment




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136048
  
@nikhilkh please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136559
  
I wonder if we should shorten the commit message bullet so that it doesn't 
wrap lines like that? Maybe we can link to 
http://cordova.apache.org/contribute/contribute_guidelines.html instead of 
giving an example (though that page doesn't have anchors for the headings)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219137067
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/102//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219137559
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219137585
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219139232
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/103//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63247389
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
--- End diff --

In `getInstalledWindowsSdks` If registry search fails, `fail` handler 
passes empty string below, as if it didn't get any output. Due to this regex 
search fails to find any SDKs and the last line returns an empty array
```js
 var installedSdks = [];
 // ... skipped ...
 .thenResolve(installedSdks);
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63247817
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
+return installedSdk.eq(reqVersion);
+});
+
+return hasSdkInstalled ? true : false;
--- End diff --

This line is excess. `return installedSdks.some(function (installedSdk) 
{...` should be sufficient


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63247974
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
+return installedSdk.eq(reqVersion);
+});
+
+return hasSdkInstalled ? true : false;
+});
+};
+
+// Checks if min SDK required to build Windows Phone 8.1 project is present
+module.exports.isPhoneSDKPresent = function () {
+return getInstalledPhoneSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS['8.1'].phonesdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
+return installedSdk.eq(reqVersion);
+});
+
+return hasSdkInstalled ? true : false;
--- End diff --

Same here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[mirko77]

Github user mirko77 commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-219154823
  
I just did it, same problem, here is the last part of what it logs:

```
(lldb) command script add -f 
fruitstrap_939ce68a6e2237a195c4e6ec07744405e8d23685.connect_command connect
(lldb) command script add -s asynchronous -f 
fruitstrap_939ce68a6e2237a195c4e6ec07744405e8d23685.run_command run
(lldb) command script add -s asynchronous -f 
fruitstrap_939ce68a6e2237a195c4e6ec07744405e8d23685.autoexit_command autoexit
(lldb) command script add -s asynchronous -f 
fruitstrap_939ce68a6e2237a195c4e6ec07744405e8d23685.safequit_command safequit
(lldb) connect
(lldb) run
success
(lldb) safequit
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63250123
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 args.push('/p:' + key + '=' + otherConfigProperties[key]);
 });
 }
+var that = this;
 
-return spawn(path.join(this.path, 'msbuild'), [projFile].concat(args), 
{ stdio: 'inherit' });
+// Check if SDK required to build the respective platform is present. 
If not present, return with corresponding error, else call msbuild.
+if (projFile.indexOf('CordovaApp.Phone.jsproj') > -1) {
--- End diff --

These 3 blocks below are almost identical. It could more convenient if 
`checkPhoneSDK` and `checkWinSDK` would return a promise, rejected with 
corresponding error message if SDK is not found. Then you could just call 
`check` method and call `spawn` on success.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219165560
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-219166990
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/104//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/52

Dummy Commit to test CI

Dummy Commit to test CI

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-plugin-device dummy

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #52


commit 91be1d807b82461cac41a3529c841c824a01ac2b
Author: Sarangan Rajamanickam 
Date:   2016-05-13T21:51:59Z

Dummy Commit to test CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...

[riknoll]

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63256712
  
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
 }, opts);
 };
 
-module.exports.checkPicture = function (pid, cb) {
+// verifies taken picture when the promise is resolved,
+// calls a callback with 'OK' if everything is good,
+// calls a callback with 'ERROR: ' if something is wrong
+// note that this function is executed in the context of tested app
+// and not in the context of tests
+module.exports.checkPicture = function (pid, options, cb) {
+var isIos = cordova.platformId === "ios";
+var isAndroid = cordova.platformId === "android";
+// skip image type check if it's unmodified on Android:
+// https://github.com/apache/cordova-plugin-camera/#android-quirks-1
+var skipFileTypeCheck = isAndroid &&
+(!options.quality || options.quality === 100) &&
--- End diff --

Why check for `!options.quality`? The default quality is 80 on Android 
(though we document it as 50!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/52#issuecomment-219169780
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/52#issuecomment-219169821
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-219170112
  
What you are encountering is a separate issue with ios-deploy. Make sure 
you have the latest, version 1.8.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/52#issuecomment-219171367
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63258437
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 args.push('/p:' + key + '=' + otherConfigProperties[key]);
 });
 }
+var that = this;
 
-return spawn(path.join(this.path, 'msbuild'), [projFile].concat(args), 
{ stdio: 'inherit' });
+// Check if SDK required to build the respective platform is present. 
If not present, return with corresponding error, else call msbuild.
+if (projFile.indexOf('CordovaApp.Phone.jsproj') > -1) {
--- End diff --

I thought about something like that (assuming that `check*SDK` will throw 
if SDK not found):
```
var promise;

if (projFile.indexOf('CordovaApp.Phone.jsproj') > -1) {
promise = checkPhoneSDK();
} else if (projFile.indexOf('CordovaApp.Windows.jsproj') > -1) {
promise = checkWinSDK('8.1');
} else {
promise = checkWinSDK('10.0');
}

return promise.then(function () {
return spawn(path.join(that.path, 'msbuild'), [projFile].concat(args), 
{ stdio: 'inherit' });
})
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63258721
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 args.push('/p:' + key + '=' + otherConfigProperties[key]);
 });
 }
+var that = this;
 
-return spawn(path.join(this.path, 'msbuild'), [projFile].concat(args), 
{ stdio: 'inherit' });
+// Check if SDK required to build the respective platform is present. 
If not present, return with corresponding error, else call msbuild.
+if (projFile.indexOf('CordovaApp.Phone.jsproj') > -1) {
--- End diff --

Anyway, this is just a matter of taste, and i'm fine with your approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: - fix generate .ipa ios

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/62

Dummy Commit to test CI

Dummy Commit to test CI

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-plugin-media-capture dummy

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 3bf654ee0e0ccd75c5086aacd2a27c385943f93a
Author: Sarangan Rajamanickam 
Date:   2016-05-13T22:53:07Z

Dummy Commit to test CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Nightly builds for Cordova

[Shazron]

Is it here instead? https://github.com/cordova/cordova-discuss/pull/47

+1
Just to emphasize from the PR discussion, nightlies are fine, they are not
considered official releases and should have the appropriate disclaimers.

From: http://www.apache.org/dev/release.html#what
"Do not include any links on the project website that might encourage
non-developers to download and use nightly builds, snapshots, release
candidates, or any other similar package."

My interpretation is, don't put the nightly links on the main page to
install Cordova, which is the main page that we tell "users" to install it.
"Devs" is of course those developing Cordova itself.

Precedent (from what Vladimir K has posted):

https://ant.apache.org/nightlies.html --> Under "Contributing"
http://jmeter.apache.org/nightly.html --> Under "Downloads"
http://zookeeper.apache.org/releases.html --> Under "Releases" (mixed
stable, and alpha)
http://couchdb.apache.org/#download -> Under "Download", Developer Preview
section.

To be absolutely clear that this is a dev thing, we should put the nightly
link under http://cordova.apache.org/contribute/



On Fri, May 13, 2016 at 2:14 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Hi list
>
> I've created a proposal for releasing nightly builds for Cordova. Please
> find details here: https://github.com/cordova/cordova-discuss/pull/42.
> I will appreciate any suggestions and feedback.
>
> -
> Best regards, Vladimir
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/62#issuecomment-219179357
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-phone/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=android/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/62#issuecomment-219179412
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Extended LTS version

[Shazron]

>From iOS' point of view, 3-5 years is unsustainable. For example, a new
version of Xcode or a new version of iOS would kill support for a macOS
version or a phone model that was supported before (and that new version is
needed for App Store submission).
For this to be considered, it would have to be granular, perhaps by
platform and not Cordova-wide.

On Fri, May 13, 2016 at 10:53 AM, Jesse  wrote:

> ... and platform updates that can break existing functionality, which come
> out every about every 3 months between our various devices/platforms.
> If people are willing to not update their devices or machines or software,
> and there are never any security exploits then everything will just work
> forever.
> I think 3-5 years is absurd, browsers barely guarantee that 5 year old
> html/css/js will work.
>
>
>
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Fri, May 13, 2016 at 10:33 AM, Joe Bowser  wrote:
>
> > On Fri, May 13, 2016 at 10:19 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com> wrote:
> >
> > > But for the CLI? For each platform?
> > >
> > > I don't think it makes sense on iOS platform where a new iOS version is
> > > released every year and apple ends forcing to use latest SDK sooner or
> > > later, and on new releases some things are broken and people needs to
> > > update cordova-ios to make them work.
> > > Might make sense on android wher google allows you to use the sdk you
> > want
> > > and things keep working in a "compatibility mode".
> > >
> >
> > I don't think we have the resources to maintain a compatibility mode
> > version of Cordova for Android and a version that compiles against the
> edge
> > version.  Also, there's the whole problem with backporting security
> > vulnerabilities.  I know that a lot of people want things to just not
> > change ever, but that's completely unrealistic given that we have people
> > trying to attack Cordova-based applications.
> >
> >
> > >
> > > But making sure the plugins keep working on all the LTS versions for
> 3-5
> > > years will need a lot of work
> > >
> > > El viernes, 13 de mayo de 2016, Nikhil Khandelwal <
> > nikhi...@microsoft.com>
> > > escribió:
> > >
> > > > I wanted to bring this to the dev list's attention:
> > > > https://github.com/cordova/cordova-discuss/issues/39.
> > > >
> > > > The idea is to have an LTS version of cordova. It might be a good
> idea
> > to
> > > > re-visit & document our release cadence as well.
> > > >
> > > > -Nikhil
> > > >
> > > >
> > >
> >
>

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/62#issuecomment-219180619
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-phone/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=android/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-labs/pull/13#issuecomment-219181062
  
@daserge sorry for the delay, I am verifying something and then will do the 
deploy ASAP


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219182375
  
Awesome! LGTM other than the one comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org