Nightly build #96 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #96 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/96/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-lib and cordova-cli 6.3.1 release

[Steven Gill]

Do it!

On Mon, Aug 8, 2016 at 1:10 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Hi all.
>
> Last cordova-lib minor release introduced a regression w/ --nobuild option
> which has stopped working completely. This is very important scenario for
> VS Tools, so I'd like to roll out a patch release 6.3.1 with fix for this
> and a couple of other bugs. Here is the list of changes to include
> (basically all changes to cordova-lib since 6.3.0):
>
>   - CB-11652 Update run and emulate to skip build
>   - CB-11194 Defer creating of libDir folder until something actually
> requests it
>   - CB-11493: Add cordova emulate option to skip prepare
>   - CB-11205 Respect saved variables when installing plugin
>   - CB-11589: Fix missing plugin files after restore
>
> I plan to start release tomorrow. Does anyone has any objections?
>
> -
> Best regards, Vladimir
>

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
So this is the first step in adding `resource-file`.  Future updates to 
platform API's will use `getFileResources` to do the copying of these files 
`src`attribute to the `target` attribute. 

I'm not sure I like `null` argument for top level `resource-file`. I agree 
with you that I don't see much value in adding this as top-level. Maybe 
developers want to copy a top level `json` file? but why not just include it in 
`www` at that point? Maybe to copy a sensitive file that isn't under version 
control? I'm reaching a bit here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #466: Add general purpose ConfigParser.getAttribute...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/466


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

[olivercs]

Github user olivercs commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/115
  
Very useful when you have to send a token or Authorization header to access 
to a resource.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

[shazron]

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r73970701
  
--- Diff: tests/spec/unit/podMod.spec.js ---
@@ -0,0 +1,107 @@
+var fs = require('fs'),
+   path = require('path'),
+   cordova = require(path.resolve(__dirname, '..', '..', '..', '..', 
'cordova-lib/cordova-lib/src/cordova/cordova'));
--- End diff --

Reviewed podModSpec.js. It really should just import podMod.js and test 
those three functions, independent of anything else (thus unit-tests). Test the 
work products of the functions to verify since they may not return anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

[shazron]

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r73970418
  
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs'),
+path = require('path'),
+util = require('util'),
+events = require('cordova-common').events,
+superspawn = require('cordova-common').superspawn,
+CordovaError = require('cordova-common').CordovaError;
+
+var opts = {};
+/*
+-- After pods are installed in a .xcworkspace, all existing ios code needs 
to go into the WORKSPACE file -- will need to 
+create a workspace file and then embed the Xcode project  
+
+- Holly might have done some work on this, see the docs: 
+  https://github.com/phonegap/phonegap-webview-ios not sure how 
applicable it can be to our case
+*/
+function removeProjectFromPath (pathToProjectFile) {
+var arrayOfDirectories = [];
+//remove the project from the path
+arrayOfDirectories = pathToProjectFile.split(path.sep);
+arrayOfDirectories.pop();
+var pathToProjectDirectory = arrayOfDirectories.join(path.sep);
+return pathToProjectDirectory;
+}
+
+function createPodfile (projectName, pathToProjectFile) {
+var path = removeProjectFromPath(pathToProjectFile);
+var pathToPodfile = path + '/Podfile';
+var podfileText = util.format('platform :ios, \'8.0\'\n\ntarget \'%s\' 
do\n\n  project \'%s\'\n\n  \n\nend' , projectName, pathToProjectFile);
+fs.writeFileSync(pathToPodfile, podfileText);
+}
+
+function editPodfileSync (Podfile, pod, isRemoval) {
+var podfileContents = fs.readFileSync(Podfile, 'utf8');
+//split by \n, add in the pod after the project line, shift the rest 
down
+var podfileContentsArray = podfileContents.split('\n');
+
+if (isRemoval) {
+var linesInPodfileToKeep = 
podfileContentsArray.filter(function(lineInPodfile) {
+return (!lineInPodfile.includes(pod));
+});
+
+podfileContents = linesInPodfileToKeep.join('\n');
+} else {
+var lineNumberForInjectionWithinPodfile = 5;
+podfileContentsArray.splice(lineNumberForInjectionWithinPodfile, 
0, pod);
+podfileContents = podfileContentsArray.join('\n');
+}
+return podfileContents;
+}
+
+function installPodSuperspawn (path, isPathToProjectFile) {
+// change working directory for all calls of pod install to 
platforms/ios
+if (isPathToProjectFile){
+//if the path passed leads to the project, and not the dir that 
contains the proj
+ //remove the project from the path
+path = removeProjectFromPath(path);
+}
+opts.cwd = path;
+superspawn.spawn('pod', ['install'], opts);
+}
+
+function installPodSync (projectName, pathToProjectFile, nameOfPod, 
podSpec, podsJSON) {
+// called from cordova project directory-- when invoked, args are as 
follows
+//  projectName = cordovaProject (name) and 
+//  pathToProjectFile   = ./path/to/cordovaProject 
+//  nameOfPod   = obj.src   //from framework 
tag
+//  podSpec = obj.spec  //from framework 
tag   
+//  podsJSON= pods.json file in 
cordovaProjectDir/platforms/ios/
+
+// readFileSync will currently truncate the Podfile if it exists
+// if a Podfile doesn't exist, one will be created
+
+// this code will be run during cordova plugin add x -- which has to 
be run in the cordova project dir
+
+//---
+//ERROR
+//
+//if no podName is specified, console err 
+if (nameOfPod === '' || nameOfPod === ' '){
+throw new CordovaError('\nERROR: name of pod is not specified\n');
+}
+//---
+
+podSpec = podSpec || ''; //spec is optional
+
+var stringToWrite; //overwrites Podfile
+var lineToInjectInPodfile; //adds pod
+var path = removeProjectFromPath(pathToProjectFile);
+var podfile = path + '/Podfile';
+var podfileExistsInCurrentDirectory = fs.existsSync(podfile);
+var podExistsInPodsJSON = podsJSON[nameOfPod];
+var podRequestedForSpecChange;
+   
+if (podSpec === '') {
+lineToInjectInPodfile = util.format('pod \'%s\'', nameOfPod);
+podRequestedForSpecChange = false;
+} else {
+if (podExistsInPodsJSON){
+if (podsJSON[nameOfPod].spec == podSpec){
+//---
+//ERROR
+//
+// if pod spec is the one already in the Podfile,
+// do nothing to the 

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

[shazron]

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r73966499
  
--- Diff: tests/spec/unit/podMod.spec.js ---
@@ -0,0 +1,107 @@
+var fs = require('fs'),
+   path = require('path'),
+   cordova = require(path.resolve(__dirname, '..', '..', '..', '..', 
'cordova-lib/cordova-lib/src/cordova/cordova'));
--- End diff --

Found the issue. This reference will never work in a CI environment or 
testing in a single repo test. It probably worked in a dev environment where 
the cordova-lib repo was a sibling repo of cordova-ios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
Can't run the tests, I get:
```
Exception loading: 
/Users/shazron/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js
{ Error: Cannot find module 
'/Users/shazron/Desktop/cordova-lib/cordova-lib/src/cordova/cordova'
```
Looks like this PR needs to link to an updated cordova-lib - @juliascript 
will provide instructions for testers.

I did a clean repo clone, applied the 
[patch](https://github.com/apache/cordova-ios/pull/234.patch), npm install, npm 
test



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #31: CB-10645 The battery status handler...

[colonelchlorine]

Github user colonelchlorine commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/31
  
What's the status on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
Looking at this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #612: CB-11412 Added docs for template use and cre...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/612#discussion_r73905774
  
--- Diff: www/_data/redirects.yml ---
@@ -348,6 +348,7 @@ docs-global:
 "guide_appdev_privacy_index.md.html": "guide/appdev/privacy/index.html"
 "guide_appdev_whitelist_index.md.html": 
"guide/appdev/whitelist/index.html"
 "guide_cli_index.md.html": "guide/cli/index.html"
+"guide_cli_template.md.html": "guide/cli/template.html"
--- End diff --

Did this link exist in the past? If not, the redirect isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #613: CB-11477 Add a page about nightly builds

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/613#discussion_r73905131
  
--- Diff: www/contribute/index.html ---
@@ -22,6 +22,7 @@
 Join the Dev mailing 
list and send a brief introduction of yourself to it
 Join the discussion on http://slack.cordova.io/;>Slack
 Sign the http://www.apache.org/licenses/#clas;>Individual Contributor License 
Agreement (ICLA) and mailto:secret...@apache.org;>submit 
it
+Try out the next version of Cordova using nightly builds
--- End diff --

Maybe use an absolute link like `{{ site.baseurl 
}}/contribute/nightly_builds.html` here, in case this page ever moves.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #112: Fixed the position of spinner

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/112
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/112/commits/3a10e610d5b093c3892030aeb0e08f221fecddde)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/24//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #112: Fixed the position of spinner

[razam217]

GitHub user razam217 opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/112

Fixed the position of spinner



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

Fixed the position of spinner according to Abode Splash Screen

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/razam217/cordova-plugin-splashscreen 
razam217-patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #112


commit 3a10e610d5b093c3892030aeb0e08f221fecddde
Author: Muhammad Mehdi Raza 
Date:   2016-08-08T10:45:59Z

Fixed the position of spinner

Fixed the position of spinner according to Abode Splash Screen




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #111: fixing problem when trying to remove...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/111
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/111/commits/6288cea80e336285209ff5932594cc6e3c6493d8)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/23//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information pull request #46: CB-11300: (android) Rec...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-network-information/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #111: fixing problem when trying to...

[alexkoy]

GitHub user alexkoy opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/111

fixing problem when trying to remove splash screen

I get an java.lang.NullpointerException in the removeSplashScreen method. I 
am new to this Plugin and not able to describe why this happens. I think there 
are multiple instances of the SplashScreen, and the splashDialog is set, but 
the splashDialogView is null. Thats why I made this change and now it works for 
me, no Exceptions any more. Can you please check this?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alexkoy/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 6288cea80e336285209ff5932594cc6e3c6493d8
Author: Alexander Koy 
Date:   2016-08-08T09:18:09Z

fixing problem when trying to remove splash screen




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #476: CB-11679 Speed up save/restore tests

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/476
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/476?src=pr) is 80.69% 
(diff: 100%)
> Merging [#476](https://codecov.io/gh/apache/cordova-lib/pull/476?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #476   diff @@
==
  Files68 68  
  Lines  5407   5407  
  Methods 857857  
  Messages  0  0  
  Branches   1048   1048  
==
  Hits   4363   4363  
  Misses 1044   1044  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[a429358...f23b830](https://codecov.io/gh/apache/cordova-lib/compare/a429358eb76fef6597c35d4fdf69df7db79af31c...f23b830193b29748a2c18cbd98b80744fd5f486c?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information issue #46: CB-11300: (android) Recognize ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-network-information/pull/46
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #476: CB-11679 Speed up save/restore tests

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/476
  
@alsorokin, please take a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #476: CB-11679 Speed up save/restore tests

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/476

CB-11679 Speed up save/restore tests

JIRA issue [CB-11679](https://issues.apache.org/jira/browse/CB-11679)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-11679

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit f23b830193b29748a2c18cbd98b80744fd5f486c
Author: Vladimir Kotikov 
Date:   2016-04-19T13:27:32Z

CB-11679 Speed up save/restore tests

clone platform repos with --depth 1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova-lib and cordova-cli 6.3.1 release

[Vladimir Kotikov (Akvelon)]

Hi all.

Last cordova-lib minor release introduced a regression w/ --nobuild option 
which has stopped working completely. This is very important scenario for VS 
Tools, so I'd like to roll out a patch release 6.3.1 with fix for this and a 
couple of other bugs. Here is the list of changes to include (basically all 
changes to cordova-lib since 6.3.0):

  - CB-11652 Update run and emulate to skip build
  - CB-11194 Defer creating of libDir folder until something actually requests 
it
  - CB-11493: Add cordova emulate option to skip prepare
  - CB-11205 Respect saved variables when installing plugin
  - CB-11589: Fix missing plugin files after restore

I plan to start release tomorrow. Does anyone has any objections?

-
Best regards, Vladimir