[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/213#discussion_r92344993
  
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -53,18 +53,37 @@ var handlers = {
 },
 'resource-file':{
 install:function(obj, plugin, project, options) {
-// do not copy, but reference the file in the plugin folder. 
This allows to
-// have multiple source files map to the same target and 
select the appropriate
-// one based on the current build settings, e.g. architecture.
-// also, we don't check for existence. This allows to insert 
build variables
-// into the source file name, e.g.
-// 
-var relativeSrcPath = getPluginFilePath(plugin, obj.src, 
project.projectFolder);
-project.addResourceFileToProject(relativeSrcPath, obj.target, 
getTargetConditions(obj));
+var targetConditions = getTargetConditions(obj);
+if (targetConditions.reference) {
--- End diff --

I think that the object that `getTargetConditions` returns was originally 
meant to hold details about target platform (Win8.1, WP8.1, Win10) and 
architecture to create a `condition` attribute, so `reference` field  doesn't 
really fit here - you might just check `if (obj.reference) ...`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/213#discussion_r92344997
  
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -53,18 +53,37 @@ var handlers = {
 },
 'resource-file':{
 install:function(obj, plugin, project, options) {
-// do not copy, but reference the file in the plugin folder. 
This allows to
-// have multiple source files map to the same target and 
select the appropriate
-// one based on the current build settings, e.g. architecture.
-// also, we don't check for existence. This allows to insert 
build variables
-// into the source file name, e.g.
-// 
-var relativeSrcPath = getPluginFilePath(plugin, obj.src, 
project.projectFolder);
-project.addResourceFileToProject(relativeSrcPath, obj.target, 
getTargetConditions(obj));
+var targetConditions = getTargetConditions(obj);
+if (targetConditions.reference) {
+// do not copy, but reference the file in the plugin 
folder. This allows to
+// have multiple source files map to the same target and 
select the appropriate
+// one based on the current build settings, e.g. 
architecture.
+// also, we don't check for existence. This allows to 
insert build variables
+// into the source file name, e.g.
+// 
+var relativeSrcPath = getPluginFilePath(plugin, obj.src, 
project.projectFolder);
+project.addResourceFileToProject(relativeSrcPath, 
obj.target, targetConditions);
+} else {
+// if target already exists, emit warning to consider 
using a reference instead of copying
+if (fs.existsSync(path.resolve(project.root, obj.target))) 
{
+events.emit('warn', ' with target ' + 
obj.target + ' already exists and will be overwritten ' +
+'by a  with the same target. Consider 
using the attribute reference="true" in the ' +
+' tag to avoid overwriting files with 
the same target. ');
--- End diff --

Might be also useful to add that adding `reference` will not copy user 
files to destination directory. WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/213#discussion_r92344562
  
--- Diff: template/cordova/lib/JsprojManager.js ---
@@ -121,7 +121,12 @@ jsprojManager.prototype = {
 copyToOutputDirectory.text = 'Always';
 children.push(copyToOutputDirectory);
 
-var item = createItemGroupElement('ItemGroup/Content', sourcePath, 
targetConditions, children);
+var item;
--- End diff --

IMO it'd be better to calculate path for `content` element outside this 
method (in `'resource-file'.install`) - this way you will avoid checking the 
same condition (`if (targetConditions.reference) ...`) twice and won't need to 
modify this method at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/213#discussion_r92345318
  
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -188,7 +207,7 @@ module.exports.getUninstaller = function(type) {
 };
 
 function getTargetConditions(obj) {
-return { versions: obj.versions, deviceTarget: obj.deviceTarget, arch: 
obj.arch };
+return { versions: obj.versions, deviceTarget: obj.deviceTarget, arch: 
obj.arch, reference: obj.reference };
--- End diff --

As per comments above `reference` field is not really required - i's easier 
to use `obj.reference` directly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

[alsorokin]

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92348958
  
--- Diff: lib/appium/AppiumRunner.js ---
@@ -102,6 +102,24 @@ function getConfigPath(appPath) {
 return path.join(appPath, 'config.xml');
 }
 
+function installAppiumServer() {
+/*
+ * We install appium in this counter-intuitive way at runtime in order 
to
+ * not trigger massive dependency downloads via `npm install` for 
autotest
+ * execution. Installing appium only happens in the local-running 
case, and
+ * thus is not needed in our CI system. By using this method, we save 
the CI
+ * a lot of time.
+ * ALTERNATIVE: what if paramedic dependencies were installed via `npm 
install
+ * --production`, and appium was stuffed into `devDependencies`. That 
should
+ * also prevent this problem? 
--- End diff --

That is certainly a viable option, but I'm still reluctant to do so because 
paramedic is used not only in CI, but also by people who want to test things 
quickly and they would certainly run `npm i` and not `npm i --production` and 
end up with extra 5 minutes of installation and 250MB of dependencies which are 
not used in most cases. Not to mention various npm installation issues...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #281: Hard link instead of soft linking

[Mitko-Kerezov]

GitHub user Mitko-Kerezov opened a pull request:

https://github.com/apache/cordova-ios/pull/281

Hard link instead of soft linking

Softlinking resource files (.wav files [for 
example](https://github.com/apache/cordova-plugin-dialogs/tree/master/src/ios/CDVNotification.bundle))
 leads to some unexpected behavior. Said resource files are stored as symbolic 
links inside the .ipa and the app cannot be installed on iOS 10.
Instead of creating symbolic link create regular links - it is better than 
copying the files performance-wise and the solution is more robust.

Part of the fix for[CB-12247: Symlinking resource files leads to inability 
to install app on iOS 10](https://issues.apache.org/jira/browse/CB-12247)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-ios 
kerezov/hardlink-instead-symlink

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit 4b7609f8055a03f7b110e4d3a3092d0fb8807421
Author: Dimitar Kerezov 
Date:   2016-12-13T10:50:22Z

Hard link instead of soft linking

Softlinking resource files (.wav files for example) leads to some 
unexpected behavior. Said resource files are stored as symbolic links inside 
the .ipa and the app cannot be installed on iOS 10.
Instead of creating symbolic link create regular links - it is better than 
copying the files performance-wise and the solution is more robust.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #281: Hard link instead of soft linking

[Mitko-Kerezov]

Github user Mitko-Kerezov commented on the issue:

https://github.com/apache/cordova-ios/pull/281
  
Note: I've tested this with `cordova-android` and it doesn't seem to 
reproduce - for one reason or another `gradle` seems to follow symlinks when 
zipping up the `.apk` file, so this fix may be enough to mitigate the whole 
problem. E.g. there's no need to propagate it to all the other platforms and to 
plugman as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/217#discussion_r92389331
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 '/p:Configuration=' + buildType,
 '/p:Platform=' + buildarch];
 
-if (otherConfigProperties) {
-var keys = Object.keys(otherConfigProperties);
-keys.forEach(function(key) {
-args.push('/p:' + key + '=' + otherConfigProperties[key]);
--- End diff --

Has this code moved? Or don't we need to prefix keys with `/p` anymore?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/217#discussion_r92399214
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 '/p:Configuration=' + buildType,
 '/p:Platform=' + buildarch];
 
-if (otherConfigProperties) {
-var keys = Object.keys(otherConfigProperties);
-keys.forEach(function(key) {
-args.push('/p:' + key + '=' + otherConfigProperties[key]);
--- End diff --

The former one. Please see 
[build.js:344](https://github.com/apache/cordova-windows/pull/217/files/6308e6974f5499857254fb79c91ded422b46486f#diff-9d172d6844120225b6cfb763491e4e03R344)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/217#discussion_r92399420
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 '/p:Configuration=' + buildType,
 '/p:Platform=' + buildarch];
 
-if (otherConfigProperties) {
-var keys = Object.keys(otherConfigProperties);
-keys.forEach(function(key) {
-args.push('/p:' + key + '=' + otherConfigProperties[key]);
--- End diff --

Also it's expected that user should provide already prefixed flags (since 
`/p:` is not the only prefix available)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/217#discussion_r92402062
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, 
buildType, buildarch, o
 '/p:Configuration=' + buildType,
 '/p:Platform=' + buildarch];
 
-if (otherConfigProperties) {
-var keys = Object.keys(otherConfigProperties);
-keys.forEach(function(key) {
-args.push('/p:' + key + '=' + otherConfigProperties[key]);
--- End diff --

OK, thanks for explanation!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

[filmaj]

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92402784
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
 
 describe('Picking contacts', function () {
 afterEach(function (done) {
-checkSession(done);
--- End diff --

Sigh, yes, you are correct. I don't know why I keep butting my head against 
this. Thank you for your patience. Re-added once more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/143
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/c6dcdda9663a322a38cc7a1cf3fe39013568215b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/64//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #281: Hard link instead of soft linking

[kerrishotts]

Github user kerrishotts commented on the issue:

https://github.com/apache/cordova-ios/pull/281
  
Can you update the title so that it includes the issue number with the 
following form:

issue#: description

That way the issue tracker will get all the updates here automatically.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #281: CB-12247: Hard link instead of soft linking

[Mitko-Kerezov]

Github user Mitko-Kerezov commented on the issue:

https://github.com/apache/cordova-ios/pull/281
  
Sure thing @kerrishotts 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

[ktop]

Github user ktop commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/213#discussion_r92438038
  
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -53,18 +53,37 @@ var handlers = {
 },
 'resource-file':{
 install:function(obj, plugin, project, options) {
-// do not copy, but reference the file in the plugin folder. 
This allows to
-// have multiple source files map to the same target and 
select the appropriate
-// one based on the current build settings, e.g. architecture.
-// also, we don't check for existence. This allows to insert 
build variables
-// into the source file name, e.g.
-// 
-var relativeSrcPath = getPluginFilePath(plugin, obj.src, 
project.projectFolder);
-project.addResourceFileToProject(relativeSrcPath, obj.target, 
getTargetConditions(obj));
+var targetConditions = getTargetConditions(obj);
+if (targetConditions.reference) {
+// do not copy, but reference the file in the plugin 
folder. This allows to
+// have multiple source files map to the same target and 
select the appropriate
+// one based on the current build settings, e.g. 
architecture.
+// also, we don't check for existence. This allows to 
insert build variables
+// into the source file name, e.g.
+// 
+var relativeSrcPath = getPluginFilePath(plugin, obj.src, 
project.projectFolder);
+project.addResourceFileToProject(relativeSrcPath, 
obj.target, targetConditions);
+} else {
+// if target already exists, emit warning to consider 
using a reference instead of copying
+if (fs.existsSync(path.resolve(project.root, obj.target))) 
{
+events.emit('warn', ' with target ' + 
obj.target + ' already exists and will be overwritten ' +
+'by a  with the same target. Consider 
using the attribute reference="true" in the ' +
+' tag to avoid overwriting files with 
the same target. ');
--- End diff --

I agree it would make it clearer for users. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #669: Update spec.md

[p-w]

GitHub user p-w opened a pull request:

https://github.com/apache/cordova-docs/pull/669

Update spec.md

### Platforms affected
None

### What does this PR do?
Better understanding of German translation of plugin.xml spec.

### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

Anpassung Beschreibung

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/p-w/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #669


commit 0530e0f9571e1e04feca5e5245773cf9a75a495e
Author: Peter 
Date:   2016-12-14T17:15:42Z

Update spec.md

Anpassung Beschreibung




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DRAFT] [REPORT] Cordova - December 2016

[Shazron]

Thanks for the edit suggestions everyone, sending the report now.

On Tue, Dec 13, 2016 at 7:02 PM, Filip Maj  wrote:

> LGTM
>
> On Tue, Dec 13, 2016 at 5:11 PM, Shazron  wrote:
> > I will send this out later tonight/early tomorrow if there are no
> comments:
> >
> > https://github.com/cordova/apache-board-reports/blob/
> master/2016/2016-12.md
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/668#discussion_r92459442
  
--- Diff: www/docs/en/dev/guide/platforms/win8/index.md ---
@@ -287,6 +287,37 @@ powershell -Command " & {dir -path 
cert:\LocalMachine\My | where { $_.Subject -l
 
 Once these final values are provided. Cordova should successfully package 
and sign the app.
 
+## MSBuild build flags
+
+Similar to other platforms ([`--gradleArg` on 
Android](../android/index.html#setting-gradle-properties), [`--buildFlag` on 
iOS](../ios/index.html#xcode-build-flags)) you can pass custom flags to 
MSBuild. To do this you have two options:
+
+- add one or more `--buildFlag` options to `cordova build windows` or 
`cordova run windows` commands:
+
+  ```
+  cordova build windows -- --buildFlag /clp:Verbosity=normal 
--buildFlag /p:myCustomProperty=Value
--- End diff --

I think there is no big difference since `nopt`, which we use under the 
hood, understands both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #213: CB-12163 Make resource-file copy files again

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/213
  
Looks good 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Plugins Release Dec 12th, 2016

[Shazron]

Two plugins that were omitted from the last released are planned for this
one:
1) Updates in cordova-plugin-battery-status that we discussed (--browserify
fixes for Windows)
2) The package.json update in cordova-plugin-inappbrowser (same version,
1.6.0)

cordova-plugin-screen-orientation release has been postponed for the next
one.

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92469947
  
--- Diff: lib/appium/AppiumRunner.js ---
@@ -102,6 +102,24 @@ function getConfigPath(appPath) {
 return path.join(appPath, 'config.xml');
 }
 
+function installAppiumServer() {
+/*
+ * We install appium in this counter-intuitive way at runtime in order 
to
+ * not trigger massive dependency downloads via `npm install` for 
autotest
+ * execution. Installing appium only happens in the local-running 
case, and
+ * thus is not needed in our CI system. By using this method, we save 
the CI
+ * a lot of time.
+ * ALTERNATIVE: what if paramedic dependencies were installed via `npm 
install
+ * --production`, and appium was stuffed into `devDependencies`. That 
should
+ * also prevent this problem? 
--- End diff --

I agree with @alsorokin here. Can we avoid sacrificing the individual 
plugin developer for the sake of the CI server?
This seems like it's maybe a case where we could/should use a *-connect 
approach and have another module that provides the connection to appium.  Or 
maybe we use feature detection to poke for the appium module and use it if it's 
present. ... not sure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/510

Fixjasmine : CB:12018 - updating tests in cordova-lib to use jasmine 
instead of jasmine-node



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib fixjasmine

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #510


commit bda891918bdc8ad172a08090a5325a16113f659e
Author: audreyso 
Date:   2016-12-14T17:33:47Z

fixjasmine : CB-12018 modifying to switch from jasmine node to jasmine

commit 75a666dccb67398b3ae01fe29a016bb928d8c507
Author: audreyso 
Date:   2016-12-14T17:36:28Z

fixjasmine : CB-12018 : updated tests to work with jasmine

commit 767af3392b797f803550d2a07ac87c8a022738f3
Author: audreyso 
Date:   2016-12-14T18:27:13Z

 fixjasmine : CB-12018 : updated tests in spec-cordova to function with 
jasmine

commit ef096b83814e3bed88be62945ba86c74d7763bc5
Author: audreyso 
Date:   2016-12-14T18:55:34Z

fixjasmine : CB:12018 : updated plugin_fetch to work with jasmine testing

commit d3eb9ae6a11f4be7429e77366c5a79dd8af57f2e
Author: audreyso 
Date:   2016-12-14T19:17:43Z

 fixjasmine : CB-12018 : updated spec-plugman tests to work with jasmine 
(spyOn and return, callThrough, callFake, describe)

commit b0e427c675dc6f0d112cb91c961780b27677a8c2
Author: audreyso 
Date:   2016-12-14T19:45:17Z

fixjasmine : CB-12018 : updated cordova-common/spec to work with jasmine 
(spyOn, return, callFake, this.after)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #510: Fixjasmine : CB:12018 - updating tests in cordova-li...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/510
  
Can you also update package.json for cordova-lib and cordova-common, 
removing jasmine-node and adding jasmine, + updating the package.json scripts 
(like test) to use jasmine instead of jasmine-node


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92480348
  
--- Diff: cordova-common/spec/CordovaCheck.spec.js ---
@@ -30,11 +30,12 @@ describe('findProjectRoot method', function() {
 process.env.PWD = origPWD;
 process.chdir(cwd);
 });
+function removeDir(someDirectory) {
+shell.rm('-rf', someDirectory);
+}
 it('should return false if it hits the home directory', function() {
 var somedir = path.join(home, 'somedir');
-this.after(function() {
--- End diff --

Here does this.after remove the somedir similarly to how we are using in 
for testing save/fetch? In the beforeEach, I have ``` shell.rm('-rf', project); 
``` to clear the previous temp project? Maybe I should just use my function in 
a beforeEach?  But then how will the someDir get updated if it changes from 
test to test? (if that makes sense)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release Dec 12th, 2016

[julio cesar sanchez]

+1

2016-12-14 20:01 GMT+01:00 Shazron :

> Two plugins that were omitted from the last released are planned for this
> one:
> 1) Updates in cordova-plugin-battery-status that we discussed (--browserify
> fixes for Windows)
> 2) The package.json update in cordova-plugin-inappbrowser (same version,
> 1.6.0)
>
> cordova-plugin-screen-orientation release has been postponed for the next
> one.
>

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92480797
  
--- Diff: cordova-lib/spec-cordova/lazy_load.spec.js ---
@@ -34,8 +34,8 @@ var lazy_load = require('../src/cordova/lazy_load'),
 describe('lazy_load module', function() {
 var custom_path, cachePackage, fakeLazyLoad;
 beforeEach(function() {
-custom_path = spyOn(config, 'has_custom_path').andReturn(false);
-cachePackage = spyOn(npmHelper, 
'cachePackage').andReturn(Q(path.join('lib', 'dir')));
+custom_path = spyOn(config, 
'has_custom_path').and.returnValue(false);
+cachePackage = spyOn(npmHelper, 
'cachePackage').and.returnValue(false);
--- End diff --

Ah! Thanks will fix this part!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] Plugins Release (Dec 12th 2016)

[Shazron]

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-12237

The plugins have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-12237/

The packages were published from their corresponding git tags:
cordova-plugin-inappbrowser: 1.6.1 (b6e575be32)
cordova-plugin-battery-status: 1.2.2 (ee2388710d)

Upon a successful vote I will upload the archives to dist/, upload them to
npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged

[GitHub] cordova-docs pull request #670: CB-12237 - Blog post for Dec 12 Plugins Rele...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-docs/pull/670

CB-12237 - Blog post for Dec 12 Plugins Release

### Platforms affected

None

### What does this PR do?

Blog post for Dec 12 Plugins Release

### What testing has been done on this change?

Local preview

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.

![screen shot 2016-12-14 at 12 51 12 
pm](https://cloud.githubusercontent.com/assets/36107/21200440/0d921e00-c1fc-11e6-9954-81e8a2b16870.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-docs CB-12237

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #670


commit 7b5912c200d686962ce60d513d826186b9bd4990
Author: Shazron Abdullah 
Date:   2016-12-14T20:40:34Z

CB-12237 - Blog post for Dec 12 Plugins Release




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DRAFT] [BLOG POST] Plugins Release Dec 12th 2016

[Shazron]

https://github.com/apache/cordova-docs/pull/670

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/143


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92491112
  
--- Diff: lib/appium/AppiumRunner.js ---
@@ -102,6 +102,24 @@ function getConfigPath(appPath) {
 return path.join(appPath, 'config.xml');
 }
 
+function installAppiumServer() {
+/*
+ * We install appium in this counter-intuitive way at runtime in order 
to
+ * not trigger massive dependency downloads via `npm install` for 
autotest
+ * execution. Installing appium only happens in the local-running 
case, and
+ * thus is not needed in our CI system. By using this method, we save 
the CI
+ * a lot of time.
+ * ALTERNATIVE: what if paramedic dependencies were installed via `npm 
install
+ * --production`, and appium was stuffed into `devDependencies`. That 
should
+ * also prevent this problem? 
--- End diff --

@purplecabbage Can you elaborate how either of the current approach or 
putting appium into devDependencies sacrifices the individual plugin developer? 
I don't follow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release Dec 12th, 2016

[Filip Maj]

+1

On Wed, Dec 14, 2016 at 12:19 PM, julio cesar sanchez
 wrote:
> +1
>
> 2016-12-14 20:01 GMT+01:00 Shazron :
>
>> Two plugins that were omitted from the last released are planned for this
>> one:
>> 1) Updates in cordova-plugin-battery-status that we discussed (--browserify
>> fixes for Windows)
>> 2) The package.json update in cordova-plugin-inappbrowser (same version,
>> 1.6.0)
>>
>> cordova-plugin-screen-orientation release has been postponed for the next
>> one.
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #670: CB-12237 - Blog post for Dec 12 Plugins Release

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/670
  
lgtm!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

(CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number

[Kerri Shotts]

Please see https://issues.apache.org/jira/browse/CB-12241 
.

Based on a quick Google search, I turned this up: 
http://stackoverflow.com/questions/14161282/serial-number-from-samsung-device-running-android
 
,
 which implies there’s no standard here, which would make creating a solution 
that works correctly all the time problematic and a bug magnet (to me, anyway). 
Given that, I’m inclined to close this issue as “not a problem” and suggest the 
user fork as needed.

BUT, I’m far from an android expert, so thought I would ask for any Android 
dev’s out there and see what they think. Thoughts on leaving the bug open or 
closing it?

~ Kerri

Re: (CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number

[Jesse]

I am replying on the issue in JIRA, because there is no way to know if the
issue creator is on the dev list, and these replies don't seem to make it
back.



@purplecabbage
risingj.com

On Wed, Dec 14, 2016 at 8:13 PM, Kerri Shotts  wrote:

> Please see https://issues.apache.org/jira/browse/CB-12241 <
> https://issues.apache.org/jira/browse/CB-12241>.
>
> Based on a quick Google search, I turned this up:
> http://stackoverflow.com/questions/14161282/serial-
> number-from-samsung-device-running-android  questions/14161282/serial-number-from-samsung-device-running-android>,
> which implies there’s no standard here, which would make creating a
> solution that works correctly all the time problematic and a bug magnet (to
> me, anyway). Given that, I’m inclined to close this issue as “not a
> problem” and suggest the user fork as needed.
>
> BUT, I’m far from an android expert, so thought I would ask for any
> Android dev’s out there and see what they think. Thoughts on leaving the
> bug open or closing it?
>
> ~ Kerri
>
>