Re: CB-12099 (android) SplashScreen Screen Flicker

[Joe Bowser]

OK, I read the PR, and I'll admit that I misunderstood part of the
problem.  I have a few concerns about this change:

1. Why does Android need to have a PR at all? The splashscreen plugin can
use edit-config tag to change the manifest to add the theme, which it
really should anyway and the XML files can be copied by the plugin.xml.
2. The bug refers to the flicker, which I haven't seen in quite a while,
but can be attributed to the splashscreen disappearing at the wrong time
and the WebView not being made visible or not rendering properly.  CB-12099
explicitly refers to the weird behaviour of the SplashScreenDelay not
actually being followed, which is why I made my initial comment. It's not
its own bug, but a part of CB-12099
3. I'm not sure why we need the prepare step and why the drawable's colour
can't be changed programmatically in Java instead of pulling it from the
config.xml in prepare.js, which isn't guaranteed to work in earlier
versions of Cordova.

I know this seems like more work, but I think it's possible to do this
without having to change the Plugin API for Splashscreen, also doing so
will also work on existing versions of Cordova, and this fix would probably
consist of a major version bump, because the new splashscreen wouldn't work
on the old versions of Cordova-Android.

On Fri, Dec 16, 2016 at 10:34 PM, Sergey Shakhnazarov 
wrote:

> Hello Joe,
>
> Could you please elaborate - is there a Jira item corresponding to that
> duration issue?
>
> Thanks,
> Sergey.
>
> 16 Дек 2016 г. 23:38 пользователь "Joe Bowser" 
> написал:
>
> I think we should figure out why the duration of the Splashscreen is messed
> up before we start messing with the background colour of the application,
> especially since the last time we did that, we broke Hello World!
>
> On Fri, Dec 16, 2016 at 11:32 AM, Sergey Shakhnazarov 
> wrote:
>
> > Hi guys!
> >
> >
> >
> > There’s an issue with Android splashscreen that every app has a black
> flash
> > on start [1].
> >
> > I propose to fix this using the android:windowBackground composed as
> splash
> > image (which we use in splashscreen plugin) laid on top of
> > SplashScreenBackgroundColor
> > [2] (this preference is supported on Windows only as of now and will be
> > particularly useful for transparent images).
> >
> > I would appreciate any feedback on the proposal and prototype
> > implementation [3, 4].
> >
> >
> >
> > [1]: https://issues.apache.org/jira/browse/CB-12099
> >
> > [2]: https://cordova.apache.org/docs/en/dev/config_ref/index.html
> >
> > [3]: https://github.com/daserge/cordova-android/tree/CB-12099
> >
> > [4]: https://github.com/daserge/cordova-plugin-splashscreen/
> tree/CB-12099
> >
> >
> >
> > Please let me know if you have any questions or considerations.
> >
> >
> > Best regards,
> >
> > Sergey Shakhnazarov,
> >
> > Akvelon developer.
> >
>

Re: CB-12099 (android) SplashScreen Screen Flicker

[Sergey Shakhnazarov]

Hello Joe,

Could you please elaborate - is there a Jira item corresponding to that
duration issue?

Thanks,
Sergey.

16 Дек 2016 г. 23:38 пользователь "Joe Bowser"  написал:

I think we should figure out why the duration of the Splashscreen is messed
up before we start messing with the background colour of the application,
especially since the last time we did that, we broke Hello World!

On Fri, Dec 16, 2016 at 11:32 AM, Sergey Shakhnazarov 
wrote:

> Hi guys!
>
>
>
> There’s an issue with Android splashscreen that every app has a black flash
> on start [1].
>
> I propose to fix this using the android:windowBackground composed as splash
> image (which we use in splashscreen plugin) laid on top of
> SplashScreenBackgroundColor
> [2] (this preference is supported on Windows only as of now and will be
> particularly useful for transparent images).
>
> I would appreciate any feedback on the proposal and prototype
> implementation [3, 4].
>
>
>
> [1]: https://issues.apache.org/jira/browse/CB-12099
>
> [2]: https://cordova.apache.org/docs/en/dev/config_ref/index.html
>
> [3]: https://github.com/daserge/cordova-android/tree/CB-12099
>
> [4]: https://github.com/daserge/cordova-plugin-splashscreen/tree/CB-12099
>
>
>
> Please let me know if you have any questions or considerations.
>
>
> Best regards,
>
> Sergey Shakhnazarov,
>
> Akvelon developer.
>

[GitHub] cordova-lib issue #511: CB-12261: Fix subdirectories deprecated warning alwa...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/511
  
yes, those are known issues in the CI right now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #511: CB-12261: Fix subdirectories deprecated warning alwa...

[yyfearth]

Github user yyfearth commented on the issue:

https://github.com/apache/cordova-lib/pull/511
  
I think the CI has issue for the android sdk.
Travis-CI got:
`Failed to find 'ANDROID_HOME' environment variable. Try setting setting it 
manually.
Failed to find 'android' command in your 'PATH'. Try update your 'PATH' to 
include path to valid SDK directory.`
Appveyor got:
`You have not accepted the license agreements of the following SDK 
components:
[Android SDK Platform 25].
Before building your project, you need to accept the license agreements and 
complete the installation of the missing components using the Android Studio 
SDK Manager.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

[yyfearth]

Github user yyfearth commented on the issue:

https://github.com/apache/cordova-lib/pull/504
  
I have create RP #511 CB-12261 to fix the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #511: CB-12261: Fix subdirectories deprecated warni...

[yyfearth]

GitHub user yyfearth opened a pull request:

https://github.com/apache/cordova-lib/pull/511

CB-12261: Fix subdirectories deprecated warning always shows and stop fetch 
for…

### Platforms affected
All

### What does this PR do?
Fix the issue created by CB-11979, the subdirectories deprecated warning 
always shows and stop fetch

### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

_Not sure how the test should be written since the original PR does not 
comes with a test._


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yyfearth/cordova-lib CB-12261

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #511


commit 581bd6a5ce0e15fde2ebb3192fdd1a4b62954929
Author: Wilson Yang 
Date:   2016-12-16T23:18:52Z

CB-12261: fix subdirectories deprecated warning always shows and stop fetch 
caused by CB-11979




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92903756
  
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
 
 it('should not check custom engine version that is not supported 
for platform', function() {
 var spy = spyOn(semver, 'satisfies').and.returnValue(true);
-runs(function() {
-installPromise( install('blackberry10', project, 
plugins['com.cordova.engine']) );
-});
-waitsFor(function() { return done; }, 'install promise never 
resolved', 200);
-runs(function() {
+install('blackberry10', project, 
plugins['com.cordova.engine']).then(function(done) {
+expect(false).toBe(true);
+done();
+},
+function err(errMsg) {
 expect(spy).not.toHaveBeenCalledWith('','>=3.0.0');
--- End diff --

Thanks @stevengill ... It looks like in some of the other tests, it is 
going right to fail on purpose? I can rewrite the test like this 

```
it('should not check custom engine version that is not supported 
for platform', function() {
var spy = spyOn(semver, 'satisfies').and.returnValue(true);

install('blackberry10', project, plugins['com.cordova.engine'])
.then(function() {
}).fail(function(error) {
expect(spy).not.toHaveBeenCalledWith('','>=3.0.0');
}).fin (done); 
}); ```

Is this better? It still goes right to the fail.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92901285
  
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
 
 it('should not check custom engine version that is not supported 
for platform', function() {
 var spy = spyOn(semver, 'satisfies').and.returnValue(true);
-runs(function() {
-installPromise( install('blackberry10', project, 
plugins['com.cordova.engine']) );
-});
-waitsFor(function() { return done; }, 'install promise never 
resolved', 200);
-runs(function() {
+install('blackberry10', project, 
plugins['com.cordova.engine']).then(function(done) {
+expect(false).toBe(true);
+done();
+},
+function err(errMsg) {
 expect(spy).not.toHaveBeenCalledWith('','>=3.0.0');
--- End diff --

on line 348, your purposely getting it to fail?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92901030
  
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
 
 it('should not check custom engine version that is not supported 
for platform', function() {
 var spy = spyOn(semver, 'satisfies').and.returnValue(true);
-runs(function() {
-installPromise( install('blackberry10', project, 
plugins['com.cordova.engine']) );
-});
-waitsFor(function() { return done; }, 'install promise never 
resolved', 200);
-runs(function() {
+install('blackberry10', project, 
plugins['com.cordova.engine']).then(function(done) {
+expect(false).toBe(true);
+done();
+},
+function err(errMsg) {
 expect(spy).not.toHaveBeenCalledWith('','>=3.0.0');
--- End diff --

is this being run? Why call it err and pass errMsg? You don't seem to be 
using errMsg


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #:

[yyfearth]

Github user yyfearth commented on the pull request:


https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20221128
  
In cordova-lib/src/plugman/fetch.js:
In cordova-lib/src/plugman/fetch.js on line 72:
it will always trigger since options.subdir === "." due to `options.subdir 
= options.subdir || '.';`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/244
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/244/commits/f4616d88cd1b87433f0f8b98a1d228253be461aa)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

[yyfearth]

Github user yyfearth commented on the issue:

https://github.com/apache/cordova-lib/pull/504
  
This fix has issue now since 
```
options.subdir = options.subdir || '.';
...
if (result[2]) options.subdir = result[2]; // not work if it is empty
...
if(options.subdir) { // it become always true, since subdir will be "."
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #670: CB-12237 - Blog post for Dec 12 Plugins Rele...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/670


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/243
  
What device does this happen to? We've seen reports of Samsung devices that 
have had that problem, and if we're already writing the EXIF with the rest of 
the data, there's no need to write EXIF twice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/178
  
FWIW I had this problem when using an Android emulator but forgot to 
specify the SD card size in its AVD definition. In that situation, the emulator 
acts like the SD card is mounted in read-only mode and thus the 
`/storage/sdcard` mount is empty (and lacks the expected `./Pictures` 
subdirectory).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/244

Android Appium test tweaks



### Platforms affected

Android

### What does this PR do?

- updated comments on how to run the tests.
- extra comments around functionality at certain points in the automation.
- stub of a resolution checker on test startup - still need to figure out 
acceptable values.
- moved session shutdown to an `afterAll` clause. 
- changed resolution determiner from using webview-based values to using 
the native windows dimensions. this helps as the webview values may be scaled 
down intentionally by manufacturers (via changing `window.devicePixelRatio`, 
for example). furthermore, since the screen dimensions are used purely for 
native UI automation using direct coordinates, better to use the dimensions 
reported by the native context rather than the web context.
- removed duplicate element calls.

### What testing has been done on this change?

Tested on local appium 1.6.3 environment on Android 4.4 and 5.1 stock 
emulators.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-plugin-camera 
android-appium-tweaks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #244


commit f4616d88cd1b87433f0f8b98a1d228253be461aa
Author: filmaj 
Date:   2016-12-16T22:33:59Z

[Appium] [Android] updated comments on how to run the tests. extra comments 
around functionality at certain points in the automation. stub of a resolution 
checker on test startup - still need to figure out acceptable values. moved 
session shutdown to an afterAll clause. changed resolution determiner from 
using webview-based values to using the native windows dimensions - this helps 
as the webview values may be scaled down intentionally by manufacturers (via 
changing devicePixelRatio). furthermore, since the screen dimension automation 
is used purely for native UI automation, better to use the dimensions reported 
by the native context rather than the web context. removed duplicate element 
calls.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Plugins Release (Dec 12th 2016)

[Shazron]

The vote has now closed. The results are:

Positive Binding Votes: 3

Shazron Abdullah
Alex Sorokin
Filip Maj

The vote has passed.

On Thu, Dec 15, 2016 at 4:52 PM, Filip Maj  wrote:

I vote +1:


 - successfully created android and ios projects with the plugins


 - ran through the manual tests for both plugins on Android 5.1 and


iOS 9.3 emusims.





On Thu, Dec 15, 2016 at 2:13 AM,   wrote:


> I vote +1


>


> * Verified signatures and hashes


> * Verified tags


> * Verified that plugins can be added correctly to blank app


> * Verified that blank app can be successfully built and ran (windows, ios
and android)


> * Verified that browserified app can be successfully built and ran
(windows, ios and android)


> * Ran smoke testing of paramedic app (windows, ios and android)


>


> -Original Message-


> From: Shazron [mailto:shaz...@apache.org]


> Sent: Wednesday, December 14, 2016 11:35 PM


> To: dev@cordova.apache.org


> Subject: [VOTE] Plugins Release (Dec 12th 2016)


>


> Please review and vote on the release of this plugins release by replying
to this email (and keep discussion on the DISCUSS thread)


>


> Release issue:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12237&data=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387&sdata=dXJxLumDRghnCq3LfybY3ru%2ByIe2t%2FTlWthNDn2IHkU%3D&reserved=0


>


> The plugins have been published to dist/dev:


>
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12237%2F&data=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387&sdata=JnMywcZKS1gAGjNeJ%2BeEEktHPxDD6tmZuR9hc4l938Q%3D&reserved=0


>


> The packages were published from their corresponding git tags:


> cordova-plugin-inappbrowser: 1.6.1 (b6e575be32)


> cordova-plugin-battery-status: 1.2.2 (ee2388710d)


>


> Upon a successful vote I will upload the archives to dist/, upload them
to npm, and post the corresponding blog post.


>


> Voting guidelines:


>
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md&data=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387&sdata=yqsclPrWPStZ49EH4QeY88ULbU7sLmLPFCgOm3h%2BC8U%3D&reserved=0


>


> How to vote on a plugins release at


>
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Fplugins-release-process.md%23voting&data=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387&sdata=L%2BvUXLPr9qWtslHcjQDKnUMP2pnNw0R0%2FXqsRl%2F9b%2Fs%3D&reserved=0


>


> Voting will go on for a minimum of 48 hours.


>


> I vote +1:


> * Ran coho audit-license-headers over the relevant repos


> * Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses


> * Ensured continuous build was green when repos were tagged


>


>


> -


> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org


> For additional commands, e-mail: dev-h...@cordova.apache.org


>





-


To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org


For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #202: Stevemeetswest patch nolocati...

[stevemeetswest]

Github user stevemeetswest closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/202


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #202: Stevemeetswest patch nolocati...

[stevemeetswest]

GitHub user stevemeetswest opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/202

Stevemeetswest patch nolocation



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevemeetswest/cordova-plugin-inappbrowser 
stevemeetswest-patch-nolocation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #202


commit b372117ef624b648f9aca5f82b899f030a6a1ff1
Author: stevemeetswest 
Date:   2016-12-16T18:23:50Z

Update InAppBrowser.java

Forced location bar to be false.

commit e7e1b18fda883abeab51aa2545db62048a5c0533
Author: stevemeetswest 
Date:   2016-12-16T20:38:54Z

Set LOCATION = null




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: CB-12099 (android) SplashScreen Screen Flicker

[Joe Bowser]

I think we should figure out why the duration of the Splashscreen is messed
up before we start messing with the background colour of the application,
especially since the last time we did that, we broke Hello World!

On Fri, Dec 16, 2016 at 11:32 AM, Sergey Shakhnazarov 
wrote:

> Hi guys!
>
>
>
> There’s an issue with Android splashscreen that every app has a black flash
> on start [1].
>
> I propose to fix this using the android:windowBackground composed as splash
> image (which we use in splashscreen plugin) laid on top of
> SplashScreenBackgroundColor
> [2] (this preference is supported on Windows only as of now and will be
> particularly useful for transparent images).
>
> I would appreciate any feedback on the proposal and prototype
> implementation [3, 4].
>
>
>
> [1]: https://issues.apache.org/jira/browse/CB-12099
>
> [2]: https://cordova.apache.org/docs/en/dev/config_ref/index.html
>
> [3]: https://github.com/daserge/cordova-android/tree/CB-12099
>
> [4]: https://github.com/daserge/cordova-plugin-splashscreen/tree/CB-12099
>
>
>
> Please let me know if you have any questions or considerations.
>
>
> Best regards,
>
> Sergey Shakhnazarov,
>
> Akvelon developer.
>

CB-12099 (android) SplashScreen Screen Flicker

[Sergey Shakhnazarov]

Hi guys!



There’s an issue with Android splashscreen that every app has a black flash
on start [1].

I propose to fix this using the android:windowBackground composed as splash
image (which we use in splashscreen plugin) laid on top of
SplashScreenBackgroundColor
[2] (this preference is supported on Windows only as of now and will be
particularly useful for transparent images).

I would appreciate any feedback on the proposal and prototype
implementation [3, 4].



[1]: https://issues.apache.org/jira/browse/CB-12099

[2]: https://cordova.apache.org/docs/en/dev/config_ref/index.html

[3]: https://github.com/daserge/cordova-android/tree/CB-12099

[4]: https://github.com/daserge/cordova-plugin-splashscreen/tree/CB-12099



Please let me know if you have any questions or considerations.


Best regards,

Sergey Shakhnazarov,

Akvelon developer.

[GitHub] cordova-plugin-contacts pull request #144: [Appium] Add support for iOS' XCU...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/144


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #243: Double exif rotation on android wit...

[Webpal]

GitHub user Webpal opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/243

Double exif rotation on android with camera



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

This solves the "correctOrientation not rotating / wrong orientation with 
Android camera bug"

If flag correctOrientation is set the image is rotated according to 
EXIF-data. After this, the original EXIF-data is added back to the image where 
the rotation is stil there. Result is that instead of a wrongly rotated image 
with EXIF-data to correct you end up with a correctly rotated image with 
EXIF-data that tilts the image 90 degrees.

Removing the EXIF completely solves this for me - there should be a more 
elegant solution to just remove the "orientation" data from the EXIF to make 
this a more general purpose solution.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Webpal/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit 60853d620f713651eaa2f82cf2b329b6c7730d21
Author: Webpal 
Date:   2016-12-16T13:35:11Z

Double exif rotation on android with camera

This solves the "correctOrientation not rotating / wrong orientation with 
Android camera bug"

If flag correctOrientation is set the image is rotated according to 
EXIF-data. After this, the original EXIF-data is added back to the image where 
the rotation is stil there. Result is that instead of a wrongly rotated image 
with EXIF-data to correct you end up with a correctly rotated image with 
EXIF-data that tilts the image 90 degrees.

Removing the EXIF completely solves this for me - there should be a more 
elegant solution to just remove the "orientation" data from the EXIF to make 
this a more general purpose solution.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

[vladimir-kotikov]

Github user vladimir-kotikov closed the pull request at:

https://github.com/apache/cordova-docs/pull/668


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #668: CB-12239 (windows) Add documentation about build fl...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-docs/pull/668
  
This has been merged in 
https://github.com/apache/cordova-docs/commit/bedbcc1f42a57fd1bd5f71c4dba9010faf1aae07


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/217
  
Cool! Merging...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

[daserge]

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/217
  
Sure 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/217
  
@daserge, is this good to go?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org