[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

[hengwoon]

Github user hengwoon commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/83
  
This would be extremely useful since it allows re-scrolling while a 
momentum scroll is in progress. Would be great if we can get this support in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #439 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #439 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/439/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #83: CB-13124: Add option for native s...

[lunaru]

GitHub user lunaru opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/83

CB-13124: Add option for native scroll-to-top on WebView

### Platforms affected
iOS

### What does this PR do?
Adds "StatusBarDefaultScrollToTop" option to allow developer to re-enable 
native scroll-to-top behavior on the WebView

The motivation for this is described here: 
https://issues.apache.org/jira/browse/CB-13124


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lunaru/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit d215a30bc143c163651914d16426d952ff90d677
Author: Lu Wang 
Date:   2017-07-26T22:59:36Z

scrollViewShouldScrollToTop to YES

Make scroll to top happen

commit 5719ab8acfee0fda3da94dd7ecb4071f8b650633
Author: Lu Wang 
Date:   2017-07-27T00:22:30Z

Add preference for native scroll to top

Allow default web scroll view to use native scroll to top

commit 09887dea712162cf50134d3f192ff61de636274a
Author: Lu Wang 
Date:   2017-07-27T00:30:49Z

Update Readme for StatusBarDefaultScrollToTop




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/577#discussion_r129730654
  
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('cordova-common').events;
+var Q = require('q');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_list = rewire('../../../src/cordova/platform/list');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var fail;
+
+describe('cordova/platform/list', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+spyOn(cordova_util, 
'getInstalledPlatformsWithVersions').and.callThrough();
+spyOn(events, 'emit');
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+
+it('should fire the before_platform_ls hook', function () {
+platform_list(hooks_mock, projectRoot, {save : true});
+expect(hooks_mock.fire).toHaveBeenCalledWith('before_platform_ls', 
Object({ save: true }));
+});
+
+it('should file the after_platform_ls hook',function (done) {
+platform_list(hooks_mock, projectRoot, {save : true})
+.then(function(result) {
+
expect(hooks_mock.fire).toHaveBeenCalledWith('after_platform_ls', Object({ 
save: true }));
+}).fail(function (err) {
+console.log(err.message);
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should print results of available platforms',function (done) {
+platform_list(hooks_mock, projectRoot, {save : true})
+.then(function(result) {
+expect(events.emit).toHaveBeenCalledWith('results', 
jasmine.stringMatching(/Installed platforms:/));
+}).fail(function (err) {
+console.log(err.message);
--- End diff --

I don't think your fail function should `console.log(err.message)` and 
`console.log(err)`. Just `console.log(err)` is sufficient. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/577#discussion_r129730691
  
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('cordova-common').events;
+var Q = require('q');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_list = rewire('../../../src/cordova/platform/list');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var fail;
+
+describe('cordova/platform/list', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+spyOn(cordova_util, 
'getInstalledPlatformsWithVersions').and.callThrough();
+spyOn(events, 'emit');
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+
+it('should fire the before_platform_ls hook', function () {
+platform_list(hooks_mock, projectRoot, {save : true});
+expect(hooks_mock.fire).toHaveBeenCalledWith('before_platform_ls', 
Object({ save: true }));
+});
+
+it('should file the after_platform_ls hook',function (done) {
+platform_list(hooks_mock, projectRoot, {save : true})
+.then(function(result) {
+
expect(hooks_mock.fire).toHaveBeenCalledWith('after_platform_ls', Object({ 
save: true }));
+}).fail(function (err) {
+console.log(err.message);
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should print results of available platforms',function (done) {
+platform_list(hooks_mock, projectRoot, {save : true})
+.then(function(result) {
+expect(events.emit).toHaveBeenCalledWith('results', 
jasmine.stringMatching(/Installed platforms:/));
+}).fail(function (err) {
+console.log(err.message);
--- End diff --

This is the same case as the previous test too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/130
  
Confirmed that this patch fixes the crash. Merged it in.

Thanks for the contribution @SharUpOff! + on your first ever GitHub PR, too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #130: CB-13094: (android) Don't sho...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/130


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/130
  
Going to about:blank is done as a garbage collection technique before 
closing out the WebView entirely so that the memory is freed.  There's a 
hilarious TODO here saying that it shouldn't destroy the WebView until 
about:blank is done loading.  

But yeah, I agree with the fix.  The Splashscreen shouldn't try to attach a 
UI element to the Activity while the Activity is basically killing itself on a 
backbutton, or some other exit event, and that's clearly what's causing this 
behaviour.  

Of course, if we never made this a plugin in the first place, we wouldn't 
have such a weird disconnect between this plugin and the platform code, so 
there is that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/576


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #576: CB-12361 : added unit tests for remove platform

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-lib/pull/576
  
Thanks @stevengill I will merge it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/576#discussion_r129713116
  
--- Diff: spec/cordova/platform/remove.spec.js ---
@@ -0,0 +1,160 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_remove = rewire('../../../src/cordova/platform/remove');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var promiseutil = require('../../../src/util/promise-util');
+var fail;
+
+describe('cordova/platform/remove', function () {
+var projectRoot = '/some/path';
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var hooks_mock;
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.dependencies = {};
+package_json_mock.cordova = {};
+
+var hooksRunnerRevert;
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+hooksRunnerRevert = platform_remove.__set__('HooksRunner', 
function () {});
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
mock', ['write', 'removeEngine']);
+cfg_parser_revert_mock = platform_remove.__set__('ConfigParser', 
cfg_parser_mock);
+spyOn(fs, 'existsSync').and.returnValue(false);
+spyOn(fs, 'writeFileSync');
+spyOn(cordova_util, 'removePlatformPluginsJson');
+spyOn(events, 'emit');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+afterEach(function () {
+cfg_parser_revert_mock();
+hooksRunnerRevert();
+});
+describe('error/warning conditions', function () {
+it('should require specifying at least one platform', function 
(done) {
+platform_remove('remove', hooks_mock).then(function () {
+fail('remove success handler unexpectedly invoked');
+}).fail(function (e) {
+expect(e.message).toContain('No platform(s) specified.');
+}).done(done);
+});
+});
+describe('happy path (success conditions)', function () {
+it('should fire the before_platform_* hook', function () {
--- End diff --

for some reason, when i run this test I get `Parsing false failed`. But the 
test passes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Incompatible plugin should reject the build

[Steven Gill]

Just created an issue for swapping to cordovaDependency from engine.
https://issues.apache.org/jira/browse/CB-13123

I agree that we should switch the behavior to fail. It would need to be a
major version of cordova. Chatted with Shaz & Simon and decided it would
make sense to add a flag to current cordova that allows plugin add to fail
if the dependency fails. So cordova@7 the default behavior will be skip the
plugin or dep that doesn't satisfy the requirement and fail will be behind
a flag. Once we hit cordova@8, we can swap the behavior so fail is default
and skip is behind the flag.

I will update https://issues.apache.org/jira/browse/CB-12122 with this
proposal.

Let us know what y'all think.

On Wed, Jul 26, 2017 at 12:50 PM, Filip Maj  wrote:

> OMG late to this thread but yes, this should fail and freakout. My
> assumption is the same as the person who reported CB-12122 is: any
> dependent plugins that fail constraint checking would bubble the
> failure up the dependency chain. Unfortunately, the behaviour is not
> _super_ explicit in the docs [1] - we should fix that. Currently it is
> "The CLI aborts with a non-zero code for any plugin whose target
> project does not meet the engine's constraints." To me that implies
> fail+freakout, but we could elaborate on the wording here a bit more.
>
> This issue is closely entangled with how to integrate certain plugins
> into platform code, esp. if the plugin is a common dependency. In
> particular looking at cordova-plugin-compat [2]. The decision in this
> thread would determine whether future versions of core plugins that
> currently depend on compat (camera, geo, and others) would need to
> depend on compat forever, or could remove the dependency altogether.
> If we keep current behaviour, future versions of e.g. camera need to
> keep a  on compat. If we change the behaviour to fail and
> freak out, we can remove the dependency after integrating compat into
> cordova-android. Strict engine constraints would need to land in
> plugins moving forward in either case.
>
> I would also like to push for aligning cordovaDependency and 
> behaviour ASAP. As per our docs today [3], we already say "[the
> cordovaDependencies] feature is intended to eventually replace the
> engines element in plugin.xml." Do we have an issue filed to do that?
>
> [1] https://cordova.apache.org/docs/en/latest/plugin_ref/
> spec.html#engines-and-engine
> [2] https://issues.apache.org/jira/browse/CB-12730
> [3] https://cordova.apache.org/docs/en/latest/guide/hybrid/
> plugins/index.html#specifying-cordova-dependencies
>
> On Fri, Jun 2, 2017 at 12:15 PM, Kerri Shotts 
> wrote:
> > +1 Fail (I think principle of least surprise applies here; most devs
> would expect an incompatible plugin to fail the build.)
> >
> > ~ Kerri
> >
> >> On Jun 2, 2017, at 12:15, Shazron  wrote:
> >>
> >> Consensus on this long stewing issue of 7 months?
> >>
> >> If you deleted the thread:
> >> 1. Issue https://issues.apache.org/jira/browse/CB-12122
> >> 2. Thread https://s.apache.org/ofqR
> >>
> >> +1 on engine check failing the build.
> >> Questions that need answered: Does cordova-fetch on cordova@7 do this
> >> already, like Simon said?
> >>
> >>
> >> On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald <
> simon.macdon...@gmail.com>
> >> wrote:
> >>
> >>> I think an engine check should fail the build. If there plugin version
> >>> they are trying to use will not work with the version of cordova or
> >>> platform they are currently using in their project it should not
> >>> build. Folks can screw up their semver in config.xml and end up
> >>> pulling in a plugin version that doesn't work with the CLI they are
> >>> currently using so stuff will just be horribly broken without them
> >>> knowing.
> >>>
> >>> Also, I thought the new cordova-fetch was supposed to prevent this
> >>> sort of thing?
> >>> Simon Mac Donald
> >>> http://simonmacdonald.com
> >>>
> >>>
> >>> On Mon, Nov 7, 2016 at 8:24 PM, Shazron  wrote:
>  See https://issues.apache.org/jira/browse/CB-12122
> 
>  Right now if a plugin fails an  check, it just warns. Should
> we
>  make engine checks fail the build?
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>>
> >>>
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/583

CB-12361 : added tests for plugin/index.js



### Platforms affected


### What does this PR do?

Added tests for plugin/index.js

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-15-plugin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #583


commit aa955945048b0fac8287ee715e30a49f7219eb5c
Author: Audrey So 
Date:   2017-07-26T18:36:21Z

CB-12361 : added tests for plugin/index.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/130
  
And @SharUpOff your intuition is confirmed: the logcat logs show that after 
pressing the back button in my app after loading it up, Cordova tries to load 
about:url:

```
07-26 12:59:40.652  9214  9214 D CordovaActivity: Stopped the activity.
07-26 12:59:40.652  9214  9214 D CordovaActivity: 
CordovaActivity.onDestroy()
07-26 12:59:40.653  9214  9214 D CordovaWebViewImpl: >>> 
loadUrl(about:blank)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/130
  
OK, I've been able to reproduce the behaviour - sort of. In my case, it 
wasn't that the my app showed the splashscreen, but that the app crashed while 
exiting!

My test app was a fresh cordova project with cordova-android 6.2.3 and 
cordova-plugin-splashscreen 4.0.3 added. I added nothing to the default cordova 
app code other than attaching `splashscreen.show()` to the `beforeunload` 
method, as per your above comment.

Here's my stack trace:

```
07-26 12:59:40.652  9214  9214 D CordovaActivity: Stopped the activity.
07-26 12:59:40.652  9214  9214 D CordovaActivity: 
CordovaActivity.onDestroy()
07-26 12:59:40.653  9214  9214 D CordovaWebViewImpl: >>> 
loadUrl(about:blank)
07-26 12:59:40.663  9214  9214 W cr_AwContents: WebView.destroy() called 
while WebView is still attached to window.
07-26 12:59:40.726  1162  5658 W WindowManager: Attempted to add 
application window with unknown token Token{760cced ActivityRecord{f0b0f04 u0 
io.cordova.hellocordova/.MainActivity t129 f}}.  Aborting.
07-26 12:59:40.727  9214  9214 D AndroidRuntime: Shutting down VM
- beginning of crash
07-26 12:59:40.728  9214  9214 E AndroidRuntime: FATAL EXCEPTION: main
07-26 12:59:40.728  9214  9214 E AndroidRuntime: Process: 
io.cordova.hellocordova, PID: 9214
07-26 12:59:40.728  9214  9214 E AndroidRuntime: 
android.view.WindowManager$BadTokenException: Unable to add window -- token 
android.os.BinderProxy@1012df7 is not valid; is your activity running?
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.view.ViewRootImpl.setView(ViewRootImpl.java:679)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:342)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.view.WindowManagerImpl.addView(WindowManagerImpl.java:93)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.app.Dialog.show(Dialog.java:329)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
org.apache.cordova.splashscreen.SplashScreen$5.run(SplashScreen.java:318)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.app.Activity.runOnUiThread(Activity.java:5869)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
org.apache.cordova.splashscreen.SplashScreen.showSplashScreen(SplashScreen.java:281)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:189)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
org.apache.cordova.PluginManager.postMessage(PluginManager.java:312)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
org.apache.cordova.CordovaWebViewImpl.postMessage(CordovaWebViewImpl.java:377)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:169)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.os.Handler.handleCallback(Handler.java:751)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.os.Handler.dispatchMessage(Handler.java:95)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.os.Looper.loop(Looper.java:154)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
android.app.ActivityThread.main(ActivityThread.java:6121)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
java.lang.reflect.Method.invoke(Native Method)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
07-26 12:59:40.728  9214  9214 E AndroidRuntime:at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
```

This was on a Google Pixel running Android 7.1.2.

Next up I'll test out your patch and see how the behaviour differs.

FYI @infil00p.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Incompatible plugin should reject the build

[Filip Maj]

OMG late to this thread but yes, this should fail and freakout. My
assumption is the same as the person who reported CB-12122 is: any
dependent plugins that fail constraint checking would bubble the
failure up the dependency chain. Unfortunately, the behaviour is not
_super_ explicit in the docs [1] - we should fix that. Currently it is
"The CLI aborts with a non-zero code for any plugin whose target
project does not meet the engine's constraints." To me that implies
fail+freakout, but we could elaborate on the wording here a bit more.

This issue is closely entangled with how to integrate certain plugins
into platform code, esp. if the plugin is a common dependency. In
particular looking at cordova-plugin-compat [2]. The decision in this
thread would determine whether future versions of core plugins that
currently depend on compat (camera, geo, and others) would need to
depend on compat forever, or could remove the dependency altogether.
If we keep current behaviour, future versions of e.g. camera need to
keep a  on compat. If we change the behaviour to fail and
freak out, we can remove the dependency after integrating compat into
cordova-android. Strict engine constraints would need to land in
plugins moving forward in either case.

I would also like to push for aligning cordovaDependency and 
behaviour ASAP. As per our docs today [3], we already say "[the
cordovaDependencies] feature is intended to eventually replace the
engines element in plugin.xml." Do we have an issue filed to do that?

[1] 
https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine
[2] https://issues.apache.org/jira/browse/CB-12730
[3] 
https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#specifying-cordova-dependencies

On Fri, Jun 2, 2017 at 12:15 PM, Kerri Shotts  wrote:
> +1 Fail (I think principle of least surprise applies here; most devs would 
> expect an incompatible plugin to fail the build.)
>
> ~ Kerri
>
>> On Jun 2, 2017, at 12:15, Shazron  wrote:
>>
>> Consensus on this long stewing issue of 7 months?
>>
>> If you deleted the thread:
>> 1. Issue https://issues.apache.org/jira/browse/CB-12122
>> 2. Thread https://s.apache.org/ofqR
>>
>> +1 on engine check failing the build.
>> Questions that need answered: Does cordova-fetch on cordova@7 do this
>> already, like Simon said?
>>
>>
>> On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald 
>> wrote:
>>
>>> I think an engine check should fail the build. If there plugin version
>>> they are trying to use will not work with the version of cordova or
>>> platform they are currently using in their project it should not
>>> build. Folks can screw up their semver in config.xml and end up
>>> pulling in a plugin version that doesn't work with the CLI they are
>>> currently using so stuff will just be horribly broken without them
>>> knowing.
>>>
>>> Also, I thought the new cordova-fetch was supposed to prevent this
>>> sort of thing?
>>> Simon Mac Donald
>>> http://simonmacdonald.com
>>>
>>>
>>> On Mon, Nov 7, 2016 at 8:24 PM, Shazron  wrote:
 See https://issues.apache.org/jira/browse/CB-12122

 Right now if a plugin fails an  check, it just warns. Should we
 make engine checks fail the build?
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>>
>>>
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r129673561
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,173 @@
+
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+- invoking this script would create a platform-specific, 
cordova-compatible project shell
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json must export a 'main'. `"main": "src/cordova/Api.js"`
+- A 'main' must exist, and it must be an instance of the `PlatformApi` 
with methods as you define later.
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+
+- The PlatformApi class
+- The `PlatformApi` class is an abstraction around a particular 
platform that exposes all the actions, properties, and methods for this 
platform so they are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single `prepare` method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform. It 
interpolates metadata, such as application name or description from a `Cordova` 
project's config.xml into the format expected by the platform. See [config.xml 
documentation](https://cordova.apache.org/docs/en/latest/config_ref/).
+- The `PlatformApi` class should be implemented by each platform that 
wants to use the new API flow.
+- Platforms that implement their own `PlatformApi` instance should 
implement all prototype methods of this class to be fully compatible with 
`cordova-lib`.
--- End diff --

This should probably be "must implement all prototype methods", not 
"should"? Can we be explicit about which of these methods are required? Off the 
top of my head, a platform _needs_ `create`, `requirements`, `prepare`, 
`addPlugin` and `removePlugin`... are those the only necessary ones? `build`, 
`run` and others may not be required. But perhaps it is worth having 
implementers create, at the minimum, functions that return resolved promises 
for the method that are considered "no-op" for a platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r129671498
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,173 @@
+
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+- invoking this script would create a platform-specific, 
cordova-compatible project shell
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json must export a 'main'. `"main": "src/cordova/Api.js"`
+- A 'main' must exist, and it must be an instance of the `PlatformApi` 
with methods as you define later.
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+
+- The PlatformApi class
+- The `PlatformApi` class is an abstraction around a particular 
platform that exposes all the actions, properties, and methods for this 
platform so they are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single `prepare` method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform. It 
interpolates metadata, such as application name or description from a `Cordova` 
project's config.xml into the format expected by the platform. See [config.xml 
documentation](https://cordova.apache.org/docs/en/latest/config_ref/).
+- The `PlatformApi` class should be implemented by each platform that 
wants to use the new API flow.
--- End diff --

I'm not sure we need this point. Do new users looking to implement a 
platform care that the platform API is "new" or that there used to be a 
different, legacy approach to implementation? In the "Package Expectations" 
section we already state that the platform package _must_ expose a `main` 
module that returns an instance of `PlatformApi` - that tells me that the 
requirement for using/implementing the `PlatformApi` class is a _must_, not a 
_should_.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/130
  
Ah, great! Thanks for describing that. I will take a look at that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #66: deviceready has not fired after 5 se...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #230: when i use cordova.InAppBrows...

[jjjachyty]

Github user jjjachyty closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #230: when i use cordova.InAppBrowser.open...

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/230
  
You have send a pull request, can you close it?

You just have to add gap: to your Content-Security-Policy meta tag


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #230: when i use cordova.InAppBrows...

[jjjachyty]

GitHub user jjjachyty opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/230

when i use cordova.InAppBrowser.open() ios not open browser,but when i  
Double click the Home button then open



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit c630159c2201f566c881add1ed7f8445ef664011
Author: filmaj 
Date:   2017-04-27T19:51:10Z

Set VERSION to 1.7.2-dev (via coho)

commit 711c60521279397c8ceb55a4dd036504b10a35ad
Author: filmaj 
Date:   2017-05-25T10:22:39Z

CB-12847: added `bugs` entry to package.json.

commit b6ed0bbaca9c3dfde83e0322e4efcf5d826f5791
Author: Nikita Matrosov 
Date:   2017-01-20T10:39:52Z

Add 'hide' method in typing definitions

commit 4f144d9e82bcead3a820fd3ec10ca022d9335951
Author: Alexander Sorokin 
Date:   2017-06-26T10:31:31Z

CB-12935: (ios, android) Enable paramedic builds on Travis CI

commit 15685d7a218f99a6e88ee725fc4f3aef06a71161
Author: Alexander Sorokin 
Date:   2017-06-30T06:31:52Z

CB-12935: (windows) Enable paramedic builds on AppVeyor

commit aa82a5d6c8486ed52b92a35e78b2a0ab4509d0a2
Author: Alexander Sorokin 
Date:   2017-07-07T07:54:24Z

CB-12991: (CI) Updated CI badges

commit ed139eeb3415be3be2953592b60e46781493a8da
Author: Alexander Sorokin 
Date:   2017-07-10T07:34:27Z

CB-13000: (CI) Speed up android builds

commit 6e058624d693206ccbfeff5dd7845001c2954249
Author: Julio César 
Date:   2017-07-23T15:29:57Z

CB-13035 fix Create issue Link

 This closes #228

commit 32d867f8e45c2b14580b64c48d8f963b6b1d594f
Author: Julio César 
Date:   2017-07-23T16:03:06Z

CB-12586 (iOS) fix method hide doesn't work

 This closes #229




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-android/pull/397
  
@filmaj, updated. But I little doubt about folders names after prepare, 
this PR just skips the removal of an original package if names (manifestId and 
androidPkgName) differ in casing only. So, 
`platforms\android\src\com\example\testapp` is still in the lower case despite 
appropriate changes in the manifest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request #95: CB-13028 (CI) Browser builds on Tra...

[alsorokin]

Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-dialogs/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request #95: CB-13028 (CI) Browser builds on Tra...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-dialogs/pull/95

CB-13028 (CI) Browser builds on Travis and AppVeyor

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-dialogs CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-dialogs/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #95


commit 74820a630a7089aa54064b3718989e63181a4813
Author: Alexander Sorokin 
Date:   2017-07-26T11:10:21Z

CB-13028 (CI) Browser builds on Travis and AppVeyor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #56: CB-13115 (browser) Fixed getC...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device-motion/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #56: CB-13115 (browser) Fixed getC...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device-motion/pull/56

CB-13115 (browser) Fixed getCurrentAcceleration() on Firefox, Safari …

…and Edge

### Platforms affected
Browser

### What does this PR do?
https://issues.apache.org/jira/browse/CB-13115
Makes getCurrentAcceleration() properly fire a `devicemotion` event on some 
browsers

### What testing has been done on this change?
Manual and automatic testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device-motion 
CB-13115

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device-motion/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit c9642ff2a1a02a079a264e9ec4fe83ce2a126e77
Author: Alexander Sorokin 
Date:   2017-07-26T10:06:40Z

CB-13115 (browser) Fixed getCurrentAcceleration() on Firefox, Safari and 
Edge




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #55: CB-13028 (CI) Browser builds ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device-motion/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #55: CB-13028 (CI) Browser builds ...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device-motion/pull/55

CB-13028 (CI) Browser builds on Travis and AppVeyor

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device-motion 
CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device-motion/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit 756d0db28bb1fba7320e934758c4f67e5081fc51
Author: Alexander Sorokin 
Date:   2017-07-26T08:34:25Z

CB-13028 (CI) Browser builds on Travis and AppVeyor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #69: CB-13113 (browser) device.isVirtual ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/69


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #69: CB-13113 (browser) device.isVirtual ...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/69

CB-13113 (browser) device.isVirtual is always false

### Platforms affected
Browser

### What does this PR do?
Introduces device.isVirtual to browser platform and makes it always equal 
`false`

### What testing has been done on this change?
an automated test run on browser platform

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device CB-13113

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #69


commit a886200d3f9a56a4de21090effca050c94613a2b
Author: Alexander Sorokin 
Date:   2017-07-26T07:49:05Z

CB-13113 (browser) device.isVirtual is always false




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #68: CB-13028 (CI) Browser builds on Trav...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/68


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #68: CB-13028 (CI) Browser builds on Trav...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/68

CB-13028 (CI) Browser builds on Travis and AppVeyor

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #68


commit f32cfc288b3669893f4fb239cc98cbf1552ef151
Author: Alexander Sorokin 
Date:   2017-07-26T07:11:34Z

CB-13028 (CI) Browser builds on Travis and AppVeyor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request #24: CB-13028 (CI) Browser builds on Tra...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-console/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Accepting new apps into the App Showcase

[Tommy Williams]

+1 to drop it

On Wed, Jul 26, 2017 at 10:01 AM, Simon MacDonald  wrote:

> +1 to drop it.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Tue, Jul 25, 2017 at 7:00 PM, Shazron  wrote:
>
> > +1 drop it altogether.
> > We can't be the arbiter of what's good or bad, and of course we don't
> have
> > the time nor desire to do so IMO.
> >
> > On Tue, Jul 25, 2017 at 2:32 PM, Steven Gill 
> > wrote:
> >
> > > +1000 I was strongly against having an app showcase when it was
> proposed
> > > for the new site. Nobody ever wants to maintain it.
> > >
> > > On Tue, Jul 25, 2017 at 2:08 PM, Jesse 
> wrote:
> > >
> > > > +1 to dropping it from cordova
> > > > Let's just link to phonegap-showcase, onsenui-showcase and
> > ionic-showcase
> > > > pages ... I think we should focus on being the best engine and let
> the
> > > > downstreams do the marketing.
> > > >
> > > >
> > > > @purplecabbage
> > > > risingj.com
> > > >
> > > > On Tue, Jul 25, 2017 at 12:43 PM, julio cesar sanchez <
> > > > jcesarmob...@gmail.com> wrote:
> > > >
> > > > > I liked Kerri's idea about only posting open source apps. I think
> > users
> > > > can
> > > > > benefit of it.
> > > > >
> > > > > El 25 jul. 2017 7:52 p. m., "Joe Bowser" 
> > escribió:
> > > > >
> > > > > > +1 to no longer supporting the Apps section.  Downstream projects
> > get
> > > > > more
> > > > > > benefit from this than we do, IMO.
> > > > > >
> > > > > > On Tue, Jul 25, 2017 at 10:36 AM, Filip Maj 
> > > wrote:
> > > > > >
> > > > > > > I'm of the opinion that we, the cordova devs are already
> sinking
> > > > under
> > > > > > > the amount of incoming PRs and TODOs just with maintaining the
> > > > > > > tooling, platforms, plugins, and docs.
> > > > > > >
> > > > > > > I think it would be better to turf it and let downstream
> projects
> > > do
> > > > > > > that stuff if they wish. I think PhoneGap has one, so does
> ionic.
> > > > > > >
> > > > > > > On Tue, Jul 25, 2017 at 9:58 AM, Kerri Shotts <
> > > kerrisho...@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > > > If we’re going to have an apps section on the website, it
> would
> > > be
> > > > > good
> > > > > > > to keep it updated. For example, the ReactEurope app goes to a
> > 404
> > > > > page.
> > > > > > > Buildr navigates to an iTunes page that is not available in the
> > US
> > > > > > region,
> > > > > > > so doesn’t tell me anything (would be better to link to a
> website
> > > > > > instead).
> > > > > > > >
> > > > > > > > Personally, it might be better just to drop the section
> > entirely,
> > > > > since
> > > > > > > it will require maintenance, would end up with some subjective
> > > > criteria
> > > > > > > (leading to “why them and not us?”), and would need to be
> rotated
> > > as
> > > > > new
> > > > > > > apps are added to prevent a huge list of apps on the front
> page.
> > I
> > > > like
> > > > > > the
> > > > > > > idea, but maybe it would be better to have a Cordova App
> gallery
> > > > (akin
> > > > > to
> > > > > > > Plugin search, cocoapods, etc.)… but that could easily be done
> by
> > > the
> > > > > > > community, since we’re tight on resources as it is.
> > > > > > > >
> > > > > > > > That said, if we’re going to accept apps, we need some
> > > (reasonable)
> > > > > > > criteria for acceptance, along with the proviso that we won’t
> > > > > necessarily
> > > > > > > always feature the app (since we don’t want to end up featuring
> > > 1000
> > > > > apps
> > > > > > > on the front page).
> > > > > > > >
> > > > > > > > Some starting criteria:
> > > > > > > >
> > > > > > > > * Should currently be available for sale/download on the
> > > > appropriate
> > > > > > app
> > > > > > > stores.
> > > > > > > > * The product needs to have a website where we can link
> > > > (redirecting
> > > > > > > into iTunes is not ideal).
> > > > > > > > * The product should fit with Cordova’s CoC, since it’s being
> > > > > featured
> > > > > > > on the front page.
> > > > > > > > * The app itself should:
> > > > > > > > * be visually appealing and well designed (this is
> > > subjective,
> > > > > but
> > > > > > > no getting around that…)
> > > > > > > > * actually work (this would require someone downloading &
> > > > testing
> > > > > > > it. Paid apps would need to supply a review copy for free.)
> > > > > > > > * be performant (no jank, quick response to user input,
> > etc.)
> > > > > > > > * be in production (not just a demo app)
> > > > > > > > * be more than just wrapping a remote website
> > > > > > > > * Plusses for (but not required):
> > > > > > > > * Available source code (so others can learn from the
> app)
> > > > > > > > * Multiple platform support
> > > > > > > > * Free or usable trial version so that users can get a
> good
> > > > feel
> > > > > > for
> > > > > > > a performant Cordova app
> > > > > >