Re: OSX store rejects cordova apps
I think I would just exit the app, that might be a single line of code and thus even easier? Yes, there's a chance of ping pong, but that's my risk. If there's another issue we'll have to deal with it and worst case I'll have to throw in some more cash. If you can take care of the mentioned issue, here's what I would expect: 1. Quit the app as described (or add the window menu as described, I don't care) 2. Create a PR 3. Make sure it gets accepted 4. Let me know how I can use the unreleased cordova version (there's probably a tutorial, just haven't tried it yet). I assume it would take a while till there's an official release. 5. Send me an paypal email address and I'll send you some dollars
Re: [DISCUSS] Plugins release
Hi, thanks for promoting this issue and clearing this up. I am happy to help where I can. How do you become a commiter or start supporting you? Regards Niklas Am 18. Apr. 2018, 04:50, um 04:50, Joe Bowser schrieb: >Hey > >This is technically off-topic, but I commented on the PR asking for a >new >PR and discussion on the list. However, without additional committers, >I >don't see this happening in the short term. If people are interested >in >becoming committers on this project, people should let us know on this >mailing list. We can definitely use the help. > >I hope this clears things up a bit. > > > >On Tue, Apr 17, 2018 at 11:27 AM, Niklas Merz >wrote: > >> Hello everyone, >> >> I am watching another issue for some time and I would like to see it >going >> forward. >> >> Cordova InAppBrowser WKWebview support >> https://issues.apache.org/jira/browse/CB-7179?page=com.atlas >> sian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel& >> focusedCommentId=16160433#comment-16160433 >> >> Dave Alden did some great work and commented it, but now it seems >stuck. >> How can we promote the effort to get WKWebview for the IAB plugin? Or >is >> there no chance to get that in the official plugin? >> >> Thanks for your help. >> >> Best regards >> Niklas >> >> - >> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >>
Re: OSX store rejects cordova apps
I can't work on it -- but just be clear on the issue what needs to be done so whomever takes it up won't waste any time. On Wed, Apr 18, 2018 at 3:43 PM, Remo Laubacher wrote: > I think I would just exit the app, that might be a single line of code and > thus even easier? > > Yes, there's a chance of ping pong, but that's my risk. If there's another > issue we'll have to deal with it and worst case I'll have to throw in some > more cash. > If you can take care of the mentioned issue, here's what I would expect: > >1. Quit the app as described (or add the window menu as described, I >don't care) >2. Create a PR >3. Make sure it gets accepted >4. Let me know how I can use the unreleased cordova version (there's >probably a tutorial, just haven't tried it yet). I assume it would take > a >while till there's an official release. >5. Send me an paypal email address and I'll send you some dollars >
Re: [DISCUSS] Plugins release
Hi Joe, I m interested in becoming a committer and also submitted few PRs too. Do let me know how to proceed about this? On Wednesday, April 18, 2018, Joe Bowser wrote: > Hey > > This is technically off-topic, but I commented on the PR asking for a new > PR and discussion on the list. However, without additional committers, I > don't see this happening in the short term. If people are interested in > becoming committers on this project, people should let us know on this > mailing list. We can definitely use the help. > > I hope this clears things up a bit. > > > > On Tue, Apr 17, 2018 at 11:27 AM, Niklas Merz > wrote: > > > Hello everyone, > > > > I am watching another issue for some time and I would like to see it > going > > forward. > > > > Cordova InAppBrowser WKWebview support > > https://issues.apache.org/jira/browse/CB-7179?page=com.atlas > > sian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel& > > focusedCommentId=16160433#comment-16160433 > > > > Dave Alden did some great work and commented it, but now it seems stuck. > > How can we promote the effort to get WKWebview for the IAB plugin? Or is > > there no chance to get that in the official plugin? > > > > Thanks for your help. > > > > Best regards > > Niklas > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > -- Regards, Gandhi "The best way to find urself is to lose urself in the service of others !!!"
Re: [DISCUSS] Android & iOS release
I've sent a PR for the Android Studio detection problem, it just makes isAndroidStudioProject return true, removed the non Android Studio tests/files (or updated some to be Android Studio tests) https://github.com/apache/cordova-android/pull/437 That wont fix incompatible plugins, but at least will point to the bad one or the bad one won't work, instead of pointing to the next one to be installed. What I say about the mapping is we have a check for .java and .xml, and we copy those files to the new location, I don't think we should expect plugin authors to map other files, I'll try to send another PR for that when I have time, but if you feel we need to do a release before that, feel free to do it. 2018-04-18 0:03 GMT+02:00 Steven Gill : > Joe or myself don't currently have the time to fix this problem and > probably won't for the foreseeable future. Plugin maintainers can send PRs > to cordova-android adding their mapping if they want or update their > plugins. > > But I'd like to get this release out because of the bug fixes that have > landed and because the release train should keep rolling. A future release > can happen with those fixes once PRs come in > > On Tue, Apr 17, 2018 at 2:59 PM, Joe Bowser wrote: > > > On Tue, Apr 17, 2018 at 2:54 PM, julio cesar sanchez < > > jcesarmob...@gmail.com > > > wrote: > > > > > Yeah, but our plugins work because we have put some code to copy our > > files > > > to a new location instead of updating the paths in the plugins' > > plugin.xml. > > > This is handled for what our plugins need, but not for all the possible > > > cases, so I don't think it's ok to make a patch to just make our > plugins > > > work but don't do the same for other allowed files. If we didn't update > > the > > > core plugins for the new path we shouldn't ask users to do it in their > > > plugins. > > > > > > > > Fair, we should really be updating all our plugins and figuring out how > to > > remove the patch. The last thing I want to see is this code growing like > > a cancer, which it very well could. I don't think we should be delaying > > the release because of third party plugins not being able to be > installed. > > > > > > > Also there is the problem I told you about the false positive making it > > > think it's an Eclipse project and making our plugins fail to install if > > > they are installed after a plugin with the previos problem. > > > > > > > > Yeah, that's a pretty major failure that we never saw when we were > testing > > 7.0. I don't think this should delay the release either unless a PR > > arrives that fixes this. > > > > > > > > > > > > 2018-04-17 23:30 GMT+02:00 Joe Bowser : > > > > > > > I disagree. We have our core plugins installing and uninstalling > > without > > > > issue currently, and we can't babysit everyone with their third party > > > > plugins. The community needs to come up with a plan on deprecating > the > > > old > > > > project structure and communicating that to the third party plugin > > > > maintainers. > > > > > > > > > > > > On Tue, Apr 17, 2018 at 2:28 PM, julio cesar sanchez < > > > > jcesarmob...@gmail.com > > > > > wrote: > > > > > > > > > Before doing an Android release we should fix the problems with > > plugins > > > > > installs, people is not updating because of it > > > > > > > > > > 2018-04-17 3:31 GMT+02:00 gandhi rajan : > > > > > > > > > > > Hi Steve, > > > > > > > > > > > > Can you please have a look at this PR - > > > > > > https://github.com/apache/cordova-docs/pull/811 > > > > > > > > > > > > It's related to Cordova doc changes. > > > > > > > > > > > > On Tuesday, April 17, 2018, Steven Gill stevengil...@gmail.com> > > > wrote: > > > > > > > > > > > > > Going to aim to do a release this week. Let me know if there > are > > > any > > > > > PRs > > > > > > I > > > > > > > should look at. > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Regards, > > > > > > Gandhi > > > > > > > > > > > > "The best way to find urself is to lose urself in the service of > > > others > > > > > > !!!" > > > > > > > > > > > > > > > > > > > > >
Re: [DISCUSS] Android & iOS release
Looks good. I'll do a quick sanity check later today, but it should be fine. On Wed, Apr 18, 2018 at 5:26 AM, julio cesar sanchez wrote: > I've sent a PR for the Android Studio detection problem, it just makes > isAndroidStudioProject return true, removed the non Android Studio > tests/files (or updated some to be Android Studio tests) > https://github.com/apache/cordova-android/pull/437 > > That wont fix incompatible plugins, but at least will point to the bad one > or the bad one won't work, instead of pointing to the next one to be > installed. > > What I say about the mapping is we have a check for .java and .xml, and we > copy those files to the new location, I don't think we should expect plugin > authors to map other files, I'll try to send another PR for that when I > have time, but if you feel we need to do a release before that, feel free > to do it. > > > 2018-04-18 0:03 GMT+02:00 Steven Gill : > > > Joe or myself don't currently have the time to fix this problem and > > probably won't for the foreseeable future. Plugin maintainers can send > PRs > > to cordova-android adding their mapping if they want or update their > > plugins. > > > > But I'd like to get this release out because of the bug fixes that have > > landed and because the release train should keep rolling. A future > release > > can happen with those fixes once PRs come in > > > > On Tue, Apr 17, 2018 at 2:59 PM, Joe Bowser wrote: > > > > > On Tue, Apr 17, 2018 at 2:54 PM, julio cesar sanchez < > > > jcesarmob...@gmail.com > > > > wrote: > > > > > > > Yeah, but our plugins work because we have put some code to copy our > > > files > > > > to a new location instead of updating the paths in the plugins' > > > plugin.xml. > > > > This is handled for what our plugins need, but not for all the > possible > > > > cases, so I don't think it's ok to make a patch to just make our > > plugins > > > > work but don't do the same for other allowed files. If we didn't > update > > > the > > > > core plugins for the new path we shouldn't ask users to do it in > their > > > > plugins. > > > > > > > > > > > Fair, we should really be updating all our plugins and figuring out how > > to > > > remove the patch. The last thing I want to see is this code growing > like > > > a cancer, which it very well could. I don't think we should be > delaying > > > the release because of third party plugins not being able to be > > installed. > > > > > > > > > > Also there is the problem I told you about the false positive making > it > > > > think it's an Eclipse project and making our plugins fail to install > if > > > > they are installed after a plugin with the previos problem. > > > > > > > > > > > Yeah, that's a pretty major failure that we never saw when we were > > testing > > > 7.0. I don't think this should delay the release either unless a PR > > > arrives that fixes this. > > > > > > > > > > > > > > > > > 2018-04-17 23:30 GMT+02:00 Joe Bowser : > > > > > > > > > I disagree. We have our core plugins installing and uninstalling > > > without > > > > > issue currently, and we can't babysit everyone with their third > party > > > > > plugins. The community needs to come up with a plan on deprecating > > the > > > > old > > > > > project structure and communicating that to the third party plugin > > > > > maintainers. > > > > > > > > > > > > > > > On Tue, Apr 17, 2018 at 2:28 PM, julio cesar sanchez < > > > > > jcesarmob...@gmail.com > > > > > > wrote: > > > > > > > > > > > Before doing an Android release we should fix the problems with > > > plugins > > > > > > installs, people is not updating because of it > > > > > > > > > > > > 2018-04-17 3:31 GMT+02:00 gandhi rajan >: > > > > > > > > > > > > > Hi Steve, > > > > > > > > > > > > > > Can you please have a look at this PR - > > > > > > > https://github.com/apache/cordova-docs/pull/811 > > > > > > > > > > > > > > It's related to Cordova doc changes. > > > > > > > > > > > > > > On Tuesday, April 17, 2018, Steven Gill stevengil...@gmail.com > > > > > > wrote: > > > > > > > > > > > > > > > Going to aim to do a release this week. Let me know if there > > are > > > > any > > > > > > PRs > > > > > > > I > > > > > > > > should look at. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Regards, > > > > > > > Gandhi > > > > > > > > > > > > > > "The best way to find urself is to lose urself in the service > of > > > > others > > > > > > > !!!" > > > > > > > > > > > > > > > > > > > > > > > > > > > >
Re: [DISCUSS] Android & iOS release
Is this related to the difference between targets in config.xml and plugin.xml? In config.xml, target attribute values are relative to the base platform directory. In plugin.xml, they are relative to app/src/main in the base platform directory. Would it be useful to document this? -Terence On 4/18/2018 10:28 AM, Joe Bowser wrote: Looks good. I'll do a quick sanity check later today, but it should be fine. On Wed, Apr 18, 2018 at 5:26 AM, julio cesar sanchez wrote: I've sent a PR for the Android Studio detection problem, it just makes isAndroidStudioProject return true, removed the non Android Studio tests/files (or updated some to be Android Studio tests) https://github.com/apache/cordova-android/pull/437 That wont fix incompatible plugins, but at least will point to the bad one or the bad one won't work, instead of pointing to the next one to be installed. What I say about the mapping is we have a check for .java and .xml, and we copy those files to the new location, I don't think we should expect plugin authors to map other files, I'll try to send another PR for that when I have time, but if you feel we need to do a release before that, feel free to do it. 2018-04-18 0:03 GMT+02:00 Steven Gill : Joe or myself don't currently have the time to fix this problem and probably won't for the foreseeable future. Plugin maintainers can send PRs to cordova-android adding their mapping if they want or update their plugins. But I'd like to get this release out because of the bug fixes that have landed and because the release train should keep rolling. A future release can happen with those fixes once PRs come in On Tue, Apr 17, 2018 at 2:59 PM, Joe Bowser wrote: On Tue, Apr 17, 2018 at 2:54 PM, julio cesar sanchez < jcesarmob...@gmail.com wrote: Yeah, but our plugins work because we have put some code to copy our files to a new location instead of updating the paths in the plugins' plugin.xml. This is handled for what our plugins need, but not for all the possible cases, so I don't think it's ok to make a patch to just make our plugins work but don't do the same for other allowed files. If we didn't update the core plugins for the new path we shouldn't ask users to do it in their plugins. Fair, we should really be updating all our plugins and figuring out how to remove the patch. The last thing I want to see is this code growing like a cancer, which it very well could. I don't think we should be delaying the release because of third party plugins not being able to be installed. Also there is the problem I told you about the false positive making it think it's an Eclipse project and making our plugins fail to install if they are installed after a plugin with the previos problem. Yeah, that's a pretty major failure that we never saw when we were testing 7.0. I don't think this should delay the release either unless a PR arrives that fixes this. 2018-04-17 23:30 GMT+02:00 Joe Bowser : I disagree. We have our core plugins installing and uninstalling without issue currently, and we can't babysit everyone with their third party plugins. The community needs to come up with a plan on deprecating the old project structure and communicating that to the third party plugin maintainers. On Tue, Apr 17, 2018 at 2:28 PM, julio cesar sanchez < jcesarmob...@gmail.com wrote: Before doing an Android release we should fix the problems with plugins installs, people is not updating because of it 2018-04-17 3:31 GMT+02:00 gandhi rajan : Hi Steve, Can you please have a look at this PR - https://github.com/apache/cordova-docs/pull/811 It's related to Cordova doc changes. On Tuesday, April 17, 2018, Steven Gill stevengil...@gmail.com wrote: Going to aim to do a release this week. Let me know if there are any PRs I should look at. -- Regards, Gandhi "The best way to find urself is to lose urself in the service of others !!!" - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Plugins release
Hello, I have found this document: https://github.com/apache/cordova-new-committer-and-pmc/blob/master/README.md Is this still current? Regards Niklas Am 18. Apr. 2018, 11:52, um 11:52, gandhi rajan schrieb: >Hi Joe, I m interested in becoming a committer and also submitted few >PRs >too. Do let me know how to proceed about this? > >On Wednesday, April 18, 2018, Joe Bowser wrote: > >> Hey >> >> This is technically off-topic, but I commented on the PR asking for a >new >> PR and discussion on the list. However, without additional >committers, I >> don't see this happening in the short term. If people are interested >in >> becoming committers on this project, people should let us know on >this >> mailing list. We can definitely use the help. >> >> I hope this clears things up a bit. >> >> >> >> On Tue, Apr 17, 2018 at 11:27 AM, Niklas Merz >> wrote: >> >> > Hello everyone, >> > >> > I am watching another issue for some time and I would like to see >it >> going >> > forward. >> > >> > Cordova InAppBrowser WKWebview support >> > https://issues.apache.org/jira/browse/CB-7179?page=com.atlas >> > sian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel& >> > focusedCommentId=16160433#comment-16160433 >> > >> > Dave Alden did some great work and commented it, but now it seems >stuck. >> > How can we promote the effort to get WKWebview for the IAB plugin? >Or is >> > there no chance to get that in the official plugin? >> > >> > Thanks for your help. >> > >> > Best regards >> > Niklas >> > >> > >- >> > >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > For additional commands, e-mail: dev-h...@cordova.apache.org >> > >> > >> > > >-- >Regards, >Gandhi > >"The best way to find urself is to lose urself in the service of others >!!!"
Re: [DISCUSS] Plugins release
That's the process to invite someone, but if you have not been invited, you can write an email to this mail list or to priv...@cordova.apache.org if you don't want it to be public, or to some Cordova PMC you already know telling why you want to become a committer and link previous contributions. 2018-04-18 22:49 GMT+02:00 Niklas Merz : > Hello, > > I have found this document: https://github.com/apache/ > cordova-new-committer-and-pmc/blob/master/README.md > > Is this still current? > > Regards Niklas > > Am 18. Apr. 2018, 11:52, um 11:52, gandhi rajan > schrieb: > >Hi Joe, I m interested in becoming a committer and also submitted few > >PRs > >too. Do let me know how to proceed about this? > > > >On Wednesday, April 18, 2018, Joe Bowser wrote: > > > >> Hey > >> > >> This is technically off-topic, but I commented on the PR asking for a > >new > >> PR and discussion on the list. However, without additional > >committers, I > >> don't see this happening in the short term. If people are interested > >in > >> becoming committers on this project, people should let us know on > >this > >> mailing list. We can definitely use the help. > >> > >> I hope this clears things up a bit. > >> > >> > >> > >> On Tue, Apr 17, 2018 at 11:27 AM, Niklas Merz > >> wrote: > >> > >> > Hello everyone, > >> > > >> > I am watching another issue for some time and I would like to see > >it > >> going > >> > forward. > >> > > >> > Cordova InAppBrowser WKWebview support > >> > https://issues.apache.org/jira/browse/CB-7179?page=com.atlas > >> > sian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel& > >> > focusedCommentId=16160433#comment-16160433 > >> > > >> > Dave Alden did some great work and commented it, but now it seems > >stuck. > >> > How can we promote the effort to get WKWebview for the IAB plugin? > >Or is > >> > there no chance to get that in the official plugin? > >> > > >> > Thanks for your help. > >> > > >> > Best regards > >> > Niklas > >> > > >> > > >- > >> > > >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> > For additional commands, e-mail: dev-h...@cordova.apache.org > >> > > >> > > >> > > > > > >-- > >Regards, > >Gandhi > > > >"The best way to find urself is to lose urself in the service of others > >!!!" >
Nightly build #694 for cordova has succeeded!
Nightly build #694 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/694/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
