Re: [DISCUSS] cordova-lib minor tools release - 8.1.0

[raphinesse]

Hey Chris!

Could you please include the changes from
https://github.com/apache/cordova-lib/pull/688 in the patch?

They have already been approved by Jan and I think we should release it as
an intermediate solution until
https://github.com/apache/cordova-common/pull/50 lands.

Thanks in Advance,
Raphael

Chris Brody  schrieb am So., 16. Sep. 2018, 23:32:

> Does anyone have any reason to delay a cordova-lib minor tools release?
>
> Any outstanding patches to land?
>
> If not, I will start the release tomorrow (in 24 hours), with changes
> merged from: https://github.com/apache/cordova-lib/pull/693
>
> The versions to be released are:
>  - cordova-lib@8.1.0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Nightly build #852 for cordova has failed

[Apache Jenkins Server]

Nightly build #852 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/852/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/852/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BOARD REPORT DRAFT] Sept 2018 Cordova Board Report

[Shazron]

Copy pasta mistake. Should be:
PRs closed/merged - 299 closed/merged --> 9 issues less from 308 above
On Mon, Sep 17, 2018 at 9:36 AM Shazron  wrote:
>
> Thanks Jan!
> Some issues with the queries, the math doesn't add up.
>
> Referring to Sept Q3.
>
> Issues created - 103 open, 62 closed --> 165 total issues created
> Issues closed -   53 closed --> 9 issues less from 62 above
>
> PRs created - 51 open, 257 closed/merged -->  308 total PRs created
> PRs closed/merged - 299 closed/merged --> 9 issues less from 62 above
>
> The small discrepancy is no big deal for now -- I'll take the stats from the 
> 'Created' query for the board report.
> On Sat, Sep 15, 2018 at 2:32 AM Jan Piotrowski  wrote:
> >
> > http://cordova.betamo.de/cordova-board-reports-issue-and-pr-searches.php
> > now exists and displays for multiple quarters (past and present) links
> > to GitHub searches that show:
> >
> > - Issues created in quarter (displays individually how many of those
> > still open and how many closed)
> > - Issues closed in quarter
> > - PRs created in quarter (displays individually how many of those
> > still open and how many closed/merged)
> > - PRs merged in quarter
> > - PRs closed in quarter
> > - PRs closed or merged in quarter
> >
> > Anything missing?
> > Please check my queries an logic - I might have a knot in my brain now
> > from the unmerged/closed/merged stuff now.
> >
> > It might be worth reporting "open issues and open PRs right now", but
> > I was not able to think how to build this in a search query for any
> > point of time. Anyone an idea?
> >
> > -J
> >
> > 2018-09-14 18:56 GMT+02:00 Shazron :
> > > Let's get this process down right for next quarter, if we don't get it
> > > in time for this one.
> > > Yes, the reporting dates are in the README for tge repo for the draft 
> > > report.
> > > On Fri, Sep 14, 2018 at 7:32 PM Jan Piotrowski  
> > > wrote:
> > >>
> > >> Thanks for pulling me in here julio.
> > >>
> > >> http://cordova.betamo.de/cordova-github-issues-search-strings.php
> > >> creates the search strings for all issues on all repositories (bottom
> > >> left).
> > >>
> > >> Just adding the time frame doesn't work, with `created:>2018-06-01
> > >> created:<2018-09-01` added at the end, it seems the second `created`
> > >> is overwriting the first one and returns all issues until 09-01.
> > >>
> > >> But you can exclude all before and after the relevant dates with
> > >> `-created:<2018-06-01 -created:>2018-09-01`:
> > >> https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+repo%3Aapache%2Fcordova-android+repo%3Aapache%2Fcordova-ios+repo%3Aapache%2Fcordova-windows+repo%3Aapache%2Fcordova-browser+repo%3Aapache%2Fcordova-osx+repo%3Aapache%2Fcordova-test-platform+repo%3Aapache%2Fcordova-electron+repo%3Aapache%2Fcordova-blackberry+repo%3Aapache%2Fcordova-firefoxos+repo%3Aapache%2Fcordova-ubuntu+repo%3Aapache%2Fcordova-wp8+repo%3Aapache%2Fcordova-tizen+repo%3Aapache%2Fcordova-qt+repo%3Aapache%2Fcordova-webos+repo%3Aapache%2Fcordova-amazon-fireos+repo%3Aapache%2Fcordova-wp7+repo%3Aapache%2Fcordova-bada+repo%3Aapache%2Fcordova-bada-wac+repo%3Aapache%2Fcordova-plugin-battery-status+repo%3Aapache%2Fcordova-plugin-camera+repo%3Aapache%2Fcordova-plugin-device+repo%3Aapache%2Fcordova-plugin-dialogs+repo%3Aapache%2Fcordova-plugin-file+repo%3Aapache%2Fcordova-plugin-geolocation+repo%3Aapache%2Fcordova-plugin-inappbrowser+repo%3Aapache%2Fcordova-plugin-media+repo%3Aapache%2Fcordova-plugin-media-capture+repo%3Aapache%2Fcordova-plugin-network-information+repo%3Aapache%2Fcordova-plugin-screen-orientation+repo%3Aapache%2Fcordova-plugin-splashscreen+repo%3Aapache%2Fcordova-plugin-statusbar+repo%3Aapache%2Fcordova-plugin-vibration+repo%3Aapache%2Fcordova-plugin-whitelist+repo%3Aapache%2Fcordova-plugin-wkwebview-engine+repo%3Aapache%2Fcordova-plugins+repo%3Aapache%2Fcordova-plugin-console+repo%3Aapache%2Fcordova-plugin-contacts+repo%3Aapache%2Fcordova-plugin-device-motion+repo%3Aapache%2Fcordova-plugin-device-orientation+repo%3Aapache%2Fcordova-plugin-file-transfer+repo%3Aapache%2Fcordova-plugin-globalization+repo%3Aapache%2Fcordova-plugin-legacy-whitelist+repo%3Aapache%2Fcordova-cli+repo%3Aapache%2Fcordova-plugman+repo%3Aapache%2Fcordova-coho+repo%3Aapache%2Fcordova-js+repo%3Aapache%2Fcordova-lib+repo%3Aapache%2Fcordova-common+repo%3Aapache%2Fcordova-create+repo%3Aapache%2Fcordova-fetch+repo%3Aapache%2Fcordova-serve+repo%3Aapache%2Fcordova-plugin-test-framework+repo%3Aapache%2Fcordova-paramedic+repo%3Aapache%2Fcordova-mobile-spec+repo%3Aapache%2Fcordova-app-hello-world+repo%3Aapache%2Fcordova-template-reference+repo%3Aapache%2Fcordova-docs+repo%3Aapache%2Fcordova-status+repo%3Aapache%2Fcordova-contribute+repo%3Aapache%2Fcordova-discuss+repo%3Aapache%2Fcordova-apache-board-reports+repo%3Aapache%2Fcordova-new-committer-and-pmc+repo%3Aapache%2Fcordova-node-xcode+repo%3Aapache%2Fcordova-medic+repo%3Aapache%2Fcordova-labs+repo%3Aapache%2Fcordova-weinre+repo%3Aapache%2Fcordova-app-harness+repo%3Aapache%2Fcordov

Re: [BOARD REPORT DRAFT] Sept 2018 Cordova Board Report

[Shazron]

Thanks Jan!
Some issues with the queries, the math doesn't add up.

Referring to Sept Q3.

Issues created - 103 open, 62 closed --> 165 total issues created
Issues closed -   53 closed --> 9 issues less from 62 above

PRs created - 51 open, 257 closed/merged -->  308 total PRs created
PRs closed/merged - 299 closed/merged --> 9 issues less from 62 above

The small discrepancy is no big deal for now -- I'll take the stats
from the 'Created' query for the board report.
On Sat, Sep 15, 2018 at 2:32 AM Jan Piotrowski  wrote:
>
> http://cordova.betamo.de/cordova-board-reports-issue-and-pr-searches.php
> now exists and displays for multiple quarters (past and present) links
> to GitHub searches that show:
>
> - Issues created in quarter (displays individually how many of those
> still open and how many closed)
> - Issues closed in quarter
> - PRs created in quarter (displays individually how many of those
> still open and how many closed/merged)
> - PRs merged in quarter
> - PRs closed in quarter
> - PRs closed or merged in quarter
>
> Anything missing?
> Please check my queries an logic - I might have a knot in my brain now
> from the unmerged/closed/merged stuff now.
>
> It might be worth reporting "open issues and open PRs right now", but
> I was not able to think how to build this in a search query for any
> point of time. Anyone an idea?
>
> -J
>
> 2018-09-14 18:56 GMT+02:00 Shazron :
> > Let's get this process down right for next quarter, if we don't get it
> > in time for this one.
> > Yes, the reporting dates are in the README for tge repo for the draft 
> > report.
> > On Fri, Sep 14, 2018 at 7:32 PM Jan Piotrowski  wrote:
> >>
> >> Thanks for pulling me in here julio.
> >>
> >> http://cordova.betamo.de/cordova-github-issues-search-strings.php
> >> creates the search strings for all issues on all repositories (bottom
> >> left).
> >>
> >> Just adding the time frame doesn't work, with `created:>2018-06-01
> >> created:<2018-09-01` added at the end, it seems the second `created`
> >> is overwriting the first one and returns all issues until 09-01.
> >>
> >> But you can exclude all before and after the relevant dates with
> >> `-created:<2018-06-01 -created:>2018-09-01`:
> >> https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+repo%3Aapache%2Fcordova-android+repo%3Aapache%2Fcordova-ios+repo%3Aapache%2Fcordova-windows+repo%3Aapache%2Fcordova-browser+repo%3Aapache%2Fcordova-osx+repo%3Aapache%2Fcordova-test-platform+repo%3Aapache%2Fcordova-electron+repo%3Aapache%2Fcordova-blackberry+repo%3Aapache%2Fcordova-firefoxos+repo%3Aapache%2Fcordova-ubuntu+repo%3Aapache%2Fcordova-wp8+repo%3Aapache%2Fcordova-tizen+repo%3Aapache%2Fcordova-qt+repo%3Aapache%2Fcordova-webos+repo%3Aapache%2Fcordova-amazon-fireos+repo%3Aapache%2Fcordova-wp7+repo%3Aapache%2Fcordova-bada+repo%3Aapache%2Fcordova-bada-wac+repo%3Aapache%2Fcordova-plugin-battery-status+repo%3Aapache%2Fcordova-plugin-camera+repo%3Aapache%2Fcordova-plugin-device+repo%3Aapache%2Fcordova-plugin-dialogs+repo%3Aapache%2Fcordova-plugin-file+repo%3Aapache%2Fcordova-plugin-geolocation+repo%3Aapache%2Fcordova-plugin-inappbrowser+repo%3Aapache%2Fcordova-plugin-media+repo%3Aapache%2Fcordova-plugin-media-capture+repo%3Aapache%2Fcordova-plugin-network-information+repo%3Aapache%2Fcordova-plugin-screen-orientation+repo%3Aapache%2Fcordova-plugin-splashscreen+repo%3Aapache%2Fcordova-plugin-statusbar+repo%3Aapache%2Fcordova-plugin-vibration+repo%3Aapache%2Fcordova-plugin-whitelist+repo%3Aapache%2Fcordova-plugin-wkwebview-engine+repo%3Aapache%2Fcordova-plugins+repo%3Aapache%2Fcordova-plugin-console+repo%3Aapache%2Fcordova-plugin-contacts+repo%3Aapache%2Fcordova-plugin-device-motion+repo%3Aapache%2Fcordova-plugin-device-orientation+repo%3Aapache%2Fcordova-plugin-file-transfer+repo%3Aapache%2Fcordova-plugin-globalization+repo%3Aapache%2Fcordova-plugin-legacy-whitelist+repo%3Aapache%2Fcordova-cli+repo%3Aapache%2Fcordova-plugman+repo%3Aapache%2Fcordova-coho+repo%3Aapache%2Fcordova-js+repo%3Aapache%2Fcordova-lib+repo%3Aapache%2Fcordova-common+repo%3Aapache%2Fcordova-create+repo%3Aapache%2Fcordova-fetch+repo%3Aapache%2Fcordova-serve+repo%3Aapache%2Fcordova-plugin-test-framework+repo%3Aapache%2Fcordova-paramedic+repo%3Aapache%2Fcordova-mobile-spec+repo%3Aapache%2Fcordova-app-hello-world+repo%3Aapache%2Fcordova-template-reference+repo%3Aapache%2Fcordova-docs+repo%3Aapache%2Fcordova-status+repo%3Aapache%2Fcordova-contribute+repo%3Aapache%2Fcordova-discuss+repo%3Aapache%2Fcordova-apache-board-reports+repo%3Aapache%2Fcordova-new-committer-and-pmc+repo%3Aapache%2Fcordova-node-xcode+repo%3Aapache%2Fcordova-medic+repo%3Aapache%2Fcordova-labs+repo%3Aapache%2Fcordova-weinre+repo%3Aapache%2Fcordova-app-harness+repo%3Aapache%2Fcordova-plugin-compat+repo%3Aapache%2Fcordova-registry-web+repo%3Aapache%2Fcordova-registry+repo%3Aapache%2Fcordova-fauxton-server+-created%3A%3C2018-06-01+-created%3A%3E2018-09-01+
> >> (via https://stackoverflow.com/a/50183610/252627)
> >>
> >> Is that what we are looking for

[DISCUSS] Windows experts badly needed

[Chris Brody]

I think it is self-evident from the stalled cordova-windows@6.0.1
patch vote that we do not have enough Windows experts on the PMC. I
think it is really unfortunate that the Microsoft team pulled out
after the amount of work they did to improve support for Windows.

I hope we can identify and invite some more Windows experts in the near future.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS cordova-windows@6.0.1 patch release

[Chris Brody]

Thanks Julio.

Considering that this is a *patch* release, issued to resolve a few
issues, I would really favor a quick review from a couple
cordova-windows experts to ensure that I didn't break anything major.

Changes are from the following PRs:
* https://github.com/apache/cordova-windows/pull/287
* https://github.com/apache/cordova-windows/pull/285
* https://github.com/apache/cordova-windows/pull/281
On Sun, Sep 16, 2018 at 6:55 PM julio cesar sanchez
 wrote:
>
> Just a reminder that any discussion about a release should be done on the
> discuss thread and not on the vote thread, even if the comment is to try to
> get more votes for that release. Vote threads should only be used to vote,
> and close the vote once it reaches the minimum number of votes.
>
> So Brody still needs some votes for this release.
>
> Looks like some of you had some troubles testing, that could be -1 votes if
> you think something is not right.
>
>
>
>
>
> El jue., 16 ago. 2018 a las 10:59, Shazron () escribió:
>
> > I'm still investigating this splashscreen issue -- not sure if
> > something broke, or I haven't defined something
> > (am n00b on Windows platform...)
> > On Wed, Aug 15, 2018 at 4:19 PM Jan Piotrowski 
> > wrote:
> > >
> > > > I had to set the MSBUILDDIR env var explicitly to C:\Program Files
> > > > (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since
> > > > our code fails to detect the MSBuild version installed with that,
> > > > v15.8.
> > > >
> > > > The registry entry it checks still has MSBuild v4 from the .NET
> > > > Framework -- so perhaps our detection is outdated.
> > >
> > > From what I remember our MSBuild detection logic is a bit more
> > > complicated and does many, many things to find it.
> > > My best guess here is that somewhere `15.8` would have to be added to
> > > a list - when cordova-windows 6.0.0 was released the correct MSBuild
> > > was autodetected.
> > > Should probably be rewritten completely :/
> > >
> > > > I had also noticed this issue, with Visual Studio 2017, from our
> > AppVeyor tests.
> > > > The AppVeyor configuration is set to accept the failures as a passing
> > result if using Visual Studio 2017.
> > > > I had been wanting to fix this so the tests would actually run and
> > pass properly but didn’t have too much time to look into this.
> > >
> > > AppVeyor fails for Visual Studio 2017 because of one unexplained test
> > > failure, that only happens on CI.
> > > (I thought there already was an issue, seems I was wrong. Created
> > > https://github.com/apache/cordova-windows/issues/290).
> > >
> > > J
> > >
> > > 2018-08-15 8:16 GMT+02:00 Bryan Ellis :
> > > > I had also noticed this issue, with Visual Studio 2017, from our
> > AppVeyor tests.
> > > >
> > > >
> > https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.1020
> > > >
> > > > The AppVeyor configuration is set to accept the failures as a passing
> > result if using Visual Studio 2017.
> > > >
> > > > I had been wanting to fix this so the tests would actually run and
> > pass properly but didn’t have too much time to look into this.
> > > >
> > > >
> > > >> On Aug 15, 2018, at 14:54, Shazron  wrote:
> > > >>
> > > >> https://github.com/apache/cordova-windows/issues/274 which is not a
> > > >> blocker IMO, but I'm not sure of the splash screen. Technically the
> > > >> app builds and runs...
> > > >> On Wed, Aug 15, 2018 at 1:40 PM Shazron  wrote:
> > > >>>
> > > >>> You can debug what requirements it tries to detect for MSBUILD by
> > running:
> > > >>>cordova requirements --verbose
> > > >>> On Wed, Aug 15, 2018 at 1:39 PM Shazron  wrote:
> > > 
> > >  Repro steps:
> > > 
> > >  ```
> > >  npm install -g cordova
> > >  cordova create foo
> > >  cd foo
> > >  cordova platform add
> > https://github.com/apache/cordova-windows#6.0.1
> > >  cordova run
> > >  ```
> > > 
> > >  Pre-requisites:
> > >  - Visual Studio 2017 Community installed with defaults
> > >  - Windows 10 SDK
> > >  - Set env var `MSBUILDDIR` to 'C:\Program Files
> > >  (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin'
> > > 
> > >  On Wed, Aug 15, 2018 at 1:36 PM Shazron  wrote:
> > > >
> > > > Had trouble meeting the requirements to build, using VS 2017
> > Community edition
> > > > I had to set the MSBUILDDIR env var explicitly to C:\Program Files
> > > > (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since
> > > > our code fails to detect the MSBuild version installed with that,
> > > > v15.8.
> > > >
> > > > The registry entry it checks still has MSBuild v4 from the .NET
> > > > Framework -- so perhaps our detection is outdated.
> > > >
> > > > After I added the env var, I could `cordova build`.
> > > > `cordova run` guided me to change some settings and run in elevated
> > > > permissions, and I ran `cordova run` again.
> > > >
> > > > The app launches, an

Re: [DISCUSS cordova-windows@6.0.1 patch release

[julio cesar sanchez]

Just a reminder that any discussion about a release should be done on the
discuss thread and not on the vote thread, even if the comment is to try to
get more votes for that release. Vote threads should only be used to vote,
and close the vote once it reaches the minimum number of votes.

So Brody still needs some votes for this release.

Looks like some of you had some troubles testing, that could be -1 votes if
you think something is not right.





El jue., 16 ago. 2018 a las 10:59, Shazron () escribió:

> I'm still investigating this splashscreen issue -- not sure if
> something broke, or I haven't defined something
> (am n00b on Windows platform...)
> On Wed, Aug 15, 2018 at 4:19 PM Jan Piotrowski 
> wrote:
> >
> > > I had to set the MSBUILDDIR env var explicitly to C:\Program Files
> > > (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since
> > > our code fails to detect the MSBuild version installed with that,
> > > v15.8.
> > >
> > > The registry entry it checks still has MSBuild v4 from the .NET
> > > Framework -- so perhaps our detection is outdated.
> >
> > From what I remember our MSBuild detection logic is a bit more
> > complicated and does many, many things to find it.
> > My best guess here is that somewhere `15.8` would have to be added to
> > a list - when cordova-windows 6.0.0 was released the correct MSBuild
> > was autodetected.
> > Should probably be rewritten completely :/
> >
> > > I had also noticed this issue, with Visual Studio 2017, from our
> AppVeyor tests.
> > > The AppVeyor configuration is set to accept the failures as a passing
> result if using Visual Studio 2017.
> > > I had been wanting to fix this so the tests would actually run and
> pass properly but didn’t have too much time to look into this.
> >
> > AppVeyor fails for Visual Studio 2017 because of one unexplained test
> > failure, that only happens on CI.
> > (I thought there already was an issue, seems I was wrong. Created
> > https://github.com/apache/cordova-windows/issues/290).
> >
> > J
> >
> > 2018-08-15 8:16 GMT+02:00 Bryan Ellis :
> > > I had also noticed this issue, with Visual Studio 2017, from our
> AppVeyor tests.
> > >
> > >
> https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.1020
> > >
> > > The AppVeyor configuration is set to accept the failures as a passing
> result if using Visual Studio 2017.
> > >
> > > I had been wanting to fix this so the tests would actually run and
> pass properly but didn’t have too much time to look into this.
> > >
> > >
> > >> On Aug 15, 2018, at 14:54, Shazron  wrote:
> > >>
> > >> https://github.com/apache/cordova-windows/issues/274 which is not a
> > >> blocker IMO, but I'm not sure of the splash screen. Technically the
> > >> app builds and runs...
> > >> On Wed, Aug 15, 2018 at 1:40 PM Shazron  wrote:
> > >>>
> > >>> You can debug what requirements it tries to detect for MSBUILD by
> running:
> > >>>cordova requirements --verbose
> > >>> On Wed, Aug 15, 2018 at 1:39 PM Shazron  wrote:
> > 
> >  Repro steps:
> > 
> >  ```
> >  npm install -g cordova
> >  cordova create foo
> >  cd foo
> >  cordova platform add
> https://github.com/apache/cordova-windows#6.0.1
> >  cordova run
> >  ```
> > 
> >  Pre-requisites:
> >  - Visual Studio 2017 Community installed with defaults
> >  - Windows 10 SDK
> >  - Set env var `MSBUILDDIR` to 'C:\Program Files
> >  (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin'
> > 
> >  On Wed, Aug 15, 2018 at 1:36 PM Shazron  wrote:
> > >
> > > Had trouble meeting the requirements to build, using VS 2017
> Community edition
> > > I had to set the MSBUILDDIR env var explicitly to C:\Program Files
> > > (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since
> > > our code fails to detect the MSBuild version installed with that,
> > > v15.8.
> > >
> > > The registry entry it checks still has MSBuild v4 from the .NET
> > > Framework -- so perhaps our detection is outdated.
> > >
> > > After I added the env var, I could `cordova build`.
> > > `cordova run` guided me to change some settings and run in elevated
> > > permissions, and I ran `cordova run` again.
> > >
> > > The app launches, and I get a 'broken image` icon for the splash
> > > screen. Is this a known issue?
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > >>
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > F

Re: Commit package-lock.json in next major Cordova release or not?

[Chris Brody]

> Please double check the docs for the use cases of
> package-lock.json vs npm-shrinkwrap.json.

Adding links to some resources I found, for the sake of clarity:

* 
* 

(I just made an edit to update a link, now waiting for peer review)
* 
*  (with link to a
long "so you want to write a package manager" article which looks
worth reading)

This could probably be a bit better organized, hope I get a chance to
take a better look (someday).

On Fri, Sep 14, 2018 at 6:39 PM Jesse  wrote:
>
> +1
> Thank you for the clarity! I am completely supportive of this.
>
> @purplecabbage
> risingj.com
>
>
> On Fri, Sep 14, 2018 at 3:28 PM  wrote:
>
> > Please note that I'm not suggesting to commit shrinkwrap to the master of
> > every repository. That is what had been discussed in the mailing list
> > thread from 2014 that you shared. That option was dismissed then, and
> > rightly so. It is also strongly advised against in the npm docs.
> >
> > I suggest using it only in release branches of CLI or other non-library
> > releases, so they are immutable and don't mutate over time. _This is
> > exactly the intended use_. And it comes at no cost other than having to run
> > `npm shrinkwrap` right before the release.
> >
> > Plus, it allows us to override transitive dependency versions for a release
> > if absolutely necessary.
> >
> > Am Sa., 15. Sep. 2018 um 00:16 Uhr schrieb Jesse  > >:
> >
> > > I personally see shrinkwrap as a step in the wrong direction, I feel like
> > > it has been explored in the past, and the general consensus is that it is
> > > something to avoid.
> > > If committing package-lock is contentious, I am okay with skipping it,
> > but
> > > we need to be careful to lock down our own dependencies and not use
> > > wildcards.
> > >
> > > We have flexibility in our current GitHub repos, which allow us to remix
> > > and freely link other dependent packages so we can debug right through
> > our
> > > deps.  I agree we need more stability around the release/publish steps so
> > > we can move more quickly through the collection of packages that make up
> > a
> > > 'tools' release.
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > >
> > > On Fri, Sep 14, 2018 at 2:56 PM  wrote:
> > >
> > > > No. This won't fix anything. Plus it goes directly against npm's
> > > > recommendation. Please double check the docs for the use cases of
> > > > package-lock.json vs npm-shrinkwrap.json.
> > > >
> > > > Am Fr., 14. Sep. 2018 um 23:48 Uhr schrieb Chris Brody <
> > > > chris.br...@gmail.com>:
> > > >
> > > > > A really nice alternative may be to turn the generated
> > > > > package-lock.json into npm-shrinkwrap.json (using npm shrinkwrap
> > > > > command) then commit npm-shrinkwrap.json. Then I think any other npm
> > > > > install updates would update npm-shrinkwrap.json instead of
> > > > > package-lock.json. Could be more predictable and easier to
> > understand.
> > > > >
> > > > > This was already discussed in 2014 [1], thanks to Jesse for the link
> > in
> > > > > [2].
> > > > >
> > > > > Thanks for the suggestion to use npm shrinkwrap as a solution for
> > > > > cordova-cli 8.1.0 minor release in [2].
> > > > >
> > > > > [1]
> > > > >
> > > >
> > >
> > https://lists.apache.org/thread.html/99184622129935eb473e843e583bf6648faff279a014e8508cc2c660@1411013202@%3Cdev.cordova.apache.org%3E
> > > > >
> > > > > [2]
> > > > >
> > > >
> > >
> > https://lists.apache.org/thread.html/f89a074add24f2ace7006b0211cf43a47cc5c1a0a65932fc22515828@%3Cdev.cordova.apache.org%3E
> > > > > On Fri, Sep 14, 2018 at 3:53 PM Chris Brody 
> > > > wrote:
> > > > > >
> > > > > > To be honest I have pretty limited experience with package lock
> > file
> > > > > > and it is now starting to show. From Oliver's very unfortunate
> > > > > > experience I would conclude that this is something we should do
> > very
> > > > > > carefully and not just on a whim. Some things I can think of:
> > > > > >
> > > > > > * always use recent version of npm such as npm@6.4.1 to generate
> > or
> > > > > > update package-lock.json
> > > > > > * do not use. npm cache when generating or updating
> > > package-lock.json,
> > > > > > or use the npm cache with extreme care (also limited experience for
> > > > > > me)
> > > > > > * be extremely careful with assumptions; I think we should both
> > > > > > double-check the documentation and do our own experimentation,
> > like I
> > > > > > did in  to
> > validate
> > > as
> > > > > > best we can
> > > > > > * semver package seems to be a major library package used by npm;
> > we
> > > > > > should both read the documentation and experiment, ideally with its
> > > > > > own test cas

Re: [VOTE] cordova-windows@6.0.1 patch release (subject fixed)

[Chris Brody]

Is there any way we can get a couple review votes on this patch
release that I made in August?
On Wed, Aug 1, 2018 at 2:56 AM Chris Brody  wrote:
>
> Can I get a couple reviews on this one, cordova-osx@4.0.2, and
> cordova-browser@5.0.4 in their respective [VOTE] threads?
>
> On Sun, Jul 29, 2018 at 10:56 PM Chris Brody  wrote:
> >
> > Please review and vote on this 6.0.1 Windows patch release by replying
> > to this email (and keep discussion on the DISCUSS thread).
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-14226
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-14226/
> >
> > The package was published from its corresponding git tag:
> >
> > cordova-windows: 6.0.1 (cc4733ef64)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-windows#6.0.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * tested with cordova-sqlite-storage plugin using npm@2.15.11
> > (packaged with node@4.9.1) and npm@5.6.0 (packaged with node@8.11.3) -
> > more details in: https://github.com/apache/cordova-windows/pull/287
> >
> > Proposed blog post in: https://github.com/apache/cordova-docs/pull/854

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] cordova-lib minor tools release - 8.1.0

[Chris Brody]

Does anyone have any reason to delay a cordova-lib minor tools release?

Any outstanding patches to land?

If not, I will start the release tomorrow (in 24 hours), with changes
merged from: https://github.com/apache/cordova-lib/pull/693

The versions to be released are:
 - cordova-lib@8.1.0

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] cordova-fetch patch release (tools) - 1.3.1

[Chris Brody]

I would like to make 1.3.1 patch release tomorrow (in 24 hours), with
changes from: https://github.com/apache/cordova-fetch/pull/38

Does anyone have any reason to delay a cordova-fetch patch release (tools)?

Any outstanding patches to land?

If not, I will start the release tomorrow (in 24 hours).

The versions to be released are:
 - cordova-fetch@1.3.1

On Mon, Jul 30, 2018 at 7:27 AM  wrote:
>
> Yes, makes perfect sense. We do need to ensure that we use the exact same
> cordova-common version everywhere.
>
> Thanks for the clarification.
>
> Chris Brody  schrieb am Mo., 30. Juli 2018, 13:24:
>
> > I would like to make cordova-fetch patch release before dependant
> > cordova-lib patch release for a couple reasons:
> > * fix project URL on npm
> > * use the same version of cordova-common (2.2.5) as latest platforms
> > being published and upcoming cordova-lib patch
> >
> > Does this make sense?
> > On Mon, Jul 30, 2018 at 5:20 AM  wrote:
> > >
> > > What is supposed to go into this release?
> > >
> > > As I already mentioned in
> > > https://issues.apache.org/jira/browse/CB-14145#comment-16522279 there
> > were
> > > no audit issues in cordova-fetch last time I checked. Has this changed?
> > >
> > > Chris Brody  schrieb am Mo., 30. Juli 2018,
> > 06:41:
> > >
> > > > Does anyone have any reason to delay a cordova-fetch patch release
> > (tools)?
> > > >
> > > > Any outstanding patches to land?
> > > >
> > > > If not, I will start the release tomorrow (or the day after).
> > > >
> > > > The versions to be released are:
> > > >  - cordova-fetch@1.3.1
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: GitHub Project Board: Pull Requests

[Jan Piotrowski]

I had a few hours and created two additional project boards based on
the existing project boards, this time for the plugins with the most
PRs:

https://github.com/orgs/apache/projects/9?fullscreen=true = camera,
file, inappbrowser, media splashscreen
https://github.com/orgs/apache/projects/10?fullscreen=true = dialogs,
geolocation, media-capture, statusbar, whitelist
These cover ~95% of all available plugin PRs I think.

I already labeled all the PRs for the impacted platform and sorted
them into the correct columns based on the test status (which was a
real pain, as the plugin tests seem to fail for no reason at all or
even all the time - we should look into this in the neat future if we
ever want to get this under control) and if there is a conflict. There
is no priorization of the PRs inside a column, I just dropped stuff
into the correct one.

I had also started to comment on some to get the original creator to
fix conflicts or failing tests, but stopped after Julio mentioned it
might not be the smartest thing to get people to do additional work on
PRs that will never be merged. He is of course rightd. We will have to
look at the conflicted PRs as well and close those with no chance of
merge.

Best,
Jan



2018-09-05 16:56 GMT+02:00  :
> Thanks again, Jan.
>
> Am Mi., 5. Sep. 2018 um 16:44 Uhr schrieb Jan Piotrowski <
> piotrow...@gmail.com>:
>
>> > I'd rather link cordova-create than cordova-js since the latter is not
>> > really tooling (it's kind of an outlier).
>>
>> Ok, changed. Makes sense.
>>
>> > But what's the difference between linked and unlinked repos anyway?
>>
>> 1. "Add Cards" has a nice "Only show results from linked repositories"
>> checkbox which makes it easier to add those PRs to the board.
>> 2. Automation rules are only triggered for linked repositories. So if
>> someone merges a PR, the card/PR is only moved to the respective lane
>> if it belongs to one of the linked repositories.
>>
>> No idea why GitHub had to limit this to 5.
>> There are workarounds/tools which I will test in the near future. They
>> are not really pretty though :/
>>
>> -J
>>
>> 2018-09-05 14:58 GMT+02:00  :
>> > Thanks for creating this Jan!
>> >
>> > I'd rather link cordova-create than cordova-js since the latter is not
>> > really tooling (it's kind of an outlier).
>> > But what's the difference between linked and unlinked repos anyway?
>> >
>> > Cheers,
>> > Raphael
>> >
>> > Am Mi., 5. Sep. 2018 um 12:39 Uhr schrieb Jan Piotrowski <
>> > piotrow...@gmail.com>:
>> >
>> >> Having (🤖/👩‍🔧) in the column title turned out to be a bad idea as
>> >> it made the messages added to PRs very noisy.
>> >> I removed them and added a card with the same information ("column
>> >> managed by 👩‍🔧 + 🤖") instead.
>> >>
>> >> As I personally did benefit from having the Platforms PR board in
>> >> going through all the existing PRs, I created another one for tooling:
>> >>
>> >> Apache Cordova: Tooling Pull Requests
>> >> https://github.com/orgs/apache/projects/8?fullscreen=true
>> >> Linked repositories: cordova-js cordova-cli cordova-lib cordova-common
>> >> cordova-fetch
>> >>
>> >> Unfortunately we hit the "5 linked repositories limit" here as
>> >> predicted, and cordova-create and cordova-serve, so I had to "Add
>> >> Cards" to them manually by searching for their PRs: `is:open is:pr
>> >> repo:apache/cordova-serve`. Will do some research to see if there is a
>> >>  workaround for that.
>> >>
>> >> Best,
>> >> Jan
>> >>
>> >> 2018-09-04 11:34 GMT+02:00 Jan Piotrowski :
>> >> > Thanks Raphael, good questions:
>> >> >
>> >> >> - What's the difference between: "Waiting for Review" and "Pending
>> >> Approval"?
>> >> >
>> >> > Yep, that was a new thing for me as well. Let me explain:
>> >> > "Waiting for Review" is a state we manually give to a PR after we had
>> >> > a look and the title and description is ok, the changes make sense and
>> >> > there are no conflicts or failing tests.
>> >> > "Pending Approval" is a state that the automation gives to a PR when
>> >> > there was some review activity (e.g. "comment" or "request changes")
>> >> > but the PR is not _approved_ (yet).
>> >> > This also applies in the case that the repo has a "3 approvals before
>> >> > merge" requirement for example, then a PR with 1 approval would move
>> >> > to that column.
>> >> > Maybe also if someone leaves a review who is not a maintainer - but I
>> >> > am not 100% sure about that.
>> >> > One could also call the column "Review in progress" maybe - but I
>> >> > wanted to see it in practice first to be honest.
>> >> >
>> >> >> - Do we need to distinguish "Blocked: Tests failing" and "Blocked:
>> >> Conflict"?
>> >> >
>> >> > We don't need to, but I thought it might be handy.
>> >> > A PR in the "tests failing" can be moved to "waiting for review" when
>> >> > there is not red x any more that indicates a failing test (because
>> >> > there was a new commit or tests were rerun). For conflicts, there is
>> >> > no visual indicator and the