Re: [VOTE] Cordova-Electron 1.0.0 Release

[Gearóid M]

+1
* added to existing app, builds and runs
* npm test
* npm audit

On Tue, 26 Feb 2019, at 01:44, Jesse wrote:
> +1
> * coho verify-archive
> * CI green
> * npm test
> * npm audit
> * coho check-license
> 
> @purplecabbage
> risingj.com
> 
> 
> On Sun, Feb 24, 2019 at 11:37 PM Bryan Ellis  wrote:
> 
> > Please review and vote on this Electron Release v1.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://github.com/apache/cordova/issues/10
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/GH-10
> >
> > The package was published from its corresponding git tag:
> > cordova-electron: 1.0.0 (b6dc52124e)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-electron#1.0.0
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Test
> >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Nomination for a new chair for Apache Cordova

[Gearóid M]

+1

Thanks for your hard work steering Cordova. I think Jesse will do a great job 
continuing this role too.

On Fri, 7 Dec 2018, at 17:31, kerrisho...@gmail.com wrote:
> +1 
> 
> Thanks for everything you’ve done for Cordova. Jesse will do an amazing 
> job, I have no doubt! 
> 
> Best,
> ~ Kerri 
> 
> Sent from my phone. 
> 
> 
>   
> 
> > On Dec 7, 2018, at 08:36, Oliver Salzburg  wrote:
> > 
> > +1
> > 
> > Thanks for everything!
> > 
> >> On Fri, Dec 7, 2018 at 10:22 AM Jan Piotrowski  
> >> wrote:
> >> 
> >> +1
> >> 
> >> Thanks to you both!
> >> Am Fr., 7. Dez. 2018 um 10:05 Uhr schrieb julio cesar sanchez
> >> :
> >>> 
> >>> +1
> >>> 
> >>> And thanks to you for all this years and to him for taking over
> >>> 
> >>> El El vie, 7 dic 2018 a las 8:02, Toplak Daniel 
> >>> escribió:
> >>> 
>  Hello Shazron,
>  
>  thank you for your hard work the last few years and I will totally
> >> agree
>  with the nomination of Jesse :-)
>  +1
>  
>  Grüße / Regards
>  Daniel Toplak
>  Head of Mobile Development
>  
> > -Ursprüngliche Nachricht-
> > Von: Shazron 
> > Gesendet: Friday, December 7, 2018 03:30
> > An: dev@cordova.apache.org
> > Betreff: Nomination for a new chair for Apache Cordova
> > 
> > Hello beloved Community!
> > I have been the chair of Apache Cordova since around April 2014 (~4.5
>  years).
> > 
> > The duties are mostly administrative: board reports, PMC management
> >> etc.
>  Some
> > of it is listed here in the README:
> > https://github.com/apache/cordova-apache-board-reports
> > 
> > I think it is time for new leadership. I have decided to resign my
>  duties as the
> > Apache Cordova chair, hopefully for the upcoming new year of 2019.
> > 
> > I nominate Jesse MacFadyen as the next chair. Jesse has been with me
> >> at
>  the start
> > when Cordova was PhoneGap. Although we didn't give birth to it, we
>  helped work
> > on improving Cordova from being an infant to adulthood (together with
>  our great
> > team), particularly on cordova-ios.
> > 10 years is adulthood in software!
> > 
> > He has also contributed greatly to the other platforms and tooling,
>  particularly
> > cordova-windows. He has the most experience with helping run the
> >> Cordova
> > project out of the remaining active contributors.
> > 
> > As an Apache Member (https://www.apache.org/foundation/members.html)
> > he also understands and helps uphold 'The Apache Way'
> > (https://www.apache.org/foundation/how-it-works.html) and will be a
>  great liaison
> > with the Board.
> > 
> > I'm not going anywhere and I will still contribute to the project in
> >> my
>  areas of
> > expertise.
> > 
> > Thank you.
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
>  
>  
> >> 
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >> 
> >> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [dev] Introduce ES6 classes or not?

[Gearóid M]

I'm definitely in favour of using classes. Personally I find them easier to 
read and write. We are already using them in at least one place, the 
ProjectBuilder in cordova-android.[1] This came about from a refactor I did a 
few months ago, and since we dropped support for Node 6, it made sense to me to 
use a class. I don't think we need to go refactoring everything, but if there 
are new features to be added, I would strongly favour using classes in those 
cases.

[1] 
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/ProjectBuilder.js

On Fri, 30 Nov 2018, at 15:49, Oliver Salzburg wrote:
> I'm in favor of ES6 classes.
> 
> But that doesn't mean that everything that _can_ be written with classes 
> should. Pick the right tool for the job.
> 
> While you can achieve the same object structure by just extending the 
> prototype, classes have the benefit of keeping related code parts close 
> to each other. A class is usually defined in a single `class {}` block. 
> With prototype extensions that is not required and it can be a lot 
> harder to determine how an object is constructed.
> 
> So, as a language feature, they might not provide any benefits, but from 
> a code point of view, I think there are several. I'd put some of that 
> syntactic sugar in my tea.
> 
> On 2018-11-30 03:20, Chris Brody wrote:
> > I was wondering what our sentiment should be about using ES6 classes?
> >
> > My own opinion in coming in a response email.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Contributing to Cordova open source

[Gearóid M]

Hi Kalana,

Welcome! It's always great to have new contributors to Cordova. If you're not 
sure where to get started, take a look at the Contributor Guide at 
https://cordova.apache.org/contribute/. There are also plenty of issues on 
GitHub which you could get started with. I'm looking forward to your 
contributions!

Gearóid

On Sun, 11 Nov 2018, at 02:14, Kalana Wijethunga wrote:
> Hi,
> 
> I am Kalana Wijethunga from Sri Lanka. I am currently a student 
> following a BSc Engineering Degree under Computer Science and 
> Engineering.I would like to contribute to open source and would like to 
> contribute to Cordova
> 
> Thanks
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Cordova Android 7.1.2 Release

[Gearóid M]

+1

- created new project from Github tag, ran as expected
- tests passing on 7.1.2 branch on Travis CI

On Tue, 6 Nov 2018, at 06:43, Jesse wrote:
> +1
> 
> - coho verify-archive
> - CI green
> - created a project, added cordova-android@7.1.2 ( via tagged repo ), ran
> without issue
> 
> 
> 
> 
> On Mon, Nov 5, 2018 at 1:18 PM Chris Brody  wrote:
> 
> > +1
> >
> > -
> >
> > https://github.com/apache/cordova-android/commit/725e75fa0dc35a1b9bbc56c8621121e6dbc4fbdf
> > (cordova-android@7.1.2
> > )
> > is green, passes its own tests OK ✓
> >
> > On Mon, Nov 5, 2018 at 3:41 PM Darryl Pogue  wrote:
> >
> > > Please review and vote on this 7.1.2 Android Release by replying to
> > > this email (and keep discussion on the DISCUSS thread).
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/android-712
> > >
> > > Blog post for review:
> > > https://github.com/apache/cordova-docs/pull/901
> > >
> > > The package was published from its corresponding git tag:
> > > - cordova-android: 7.1.2 (725e75fa0d)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add https://github.com/apache/cordova-android#7.1.2
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > >
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [proposal] Remove tool generated docs from camera plugin?

[Gearóid M]

+1 for simplicity and consistency with other readme files

On Wed, 31 Oct 2018, at 09:40, Jesse wrote:
> +1 to a hand written readme!
> 
> @purplecabbage
> risingj.com
> 
> 
> On Tue, Oct 30, 2018 at 5:18 PM julio cesar sanchez 
> wrote:
> 
> > Bumping this old thread again as I accidentally "undid" some manual changes
> > Jan did on cordova-plugin-camera README.
> >
> > Part of the cordova-plugin-camera README is generated from here
> >
> > https://github.com/daserge/dmd-plugin-cordova-plugin/blob/master/partial/cdv-header.hbs
> > and some other files on that repo. So I think we should remove that
> > dependency and switch to a regular README without automatic generation as
> > it's the only plugin doing that.
> >
> > Thoughts?
> >
> >
> >
> > El mié., 18 oct. 2017 a las 0:52, Steven Gill ()
> > escribió:
> >
> > > I'm fine with going back to a simple readme
> > >
> > > On Sun, Oct 15, 2017 at 12:52 AM, julio cesar sanchez <
> > > jcesarmob...@gmail.com> wrote:
> > >
> > > > The README.md already have a section
> > > >  > > > documentation-is-generated-by-a-tool>
> > > > about how the README.md is generated. But maybe it should be more clear
> > > and
> > > > say that the README.md shouldn't be updated manually.
> > > >
> > > > BTW, I sent a PR <
> > > https://github.com/apache/cordova-plugin-camera/pull/291
> > > > >
> > > > to make the template be in sync with the README.md changes. If anybody
> > > can
> > > > take a look it would be good. Not sure if I can merge while the tests
> > are
> > > > failing, but I only changed the template, so I'm pretty sure I didn't
> > > break
> > > > anything and tests are failing in all other plugins, but that's another
> > > > topic.
> > > >
> > > > About if it's a good idea, I've found the original cordova-discuss
> > issue
> > > >  and proposal
> > > >  and reading them I
> > > > think it's a good idea as I understand that the API part of the docs
> > are
> > > > automatically generated from the js files, which avoids them to be out
> > of
> > > > sync if a js change is made.
> > > >
> > > >
> > > > 2017-10-15 1:07 GMT+02:00 Jan Piotrowski :
> > > >
> > > > > The "not aware" problem can probably be resolved (80/20) by adding
> > > > > comments to the template that are also in the generated output.
> > > > >
> > > > > But it the TEMPLATE.md actually a good idea? Is it worth the extra
> > > > effort?
> > > > >
> > > > > -J
> > > > >
> > > > > 2017-10-15 0:01 GMT+02:00 julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > >:
> > > > > > cordova-plugin-camera docs work on a different way than other
> > > plugins.
> > > > > The
> > > > > > README.md is generated from jsdoc2md/TEMPLATE.md when the commit is
> > > > done.
> > > > > > I think it was a proof of concept to be done in all the plugins,
> > but
> > > it
> > > > > the
> > > > > > end it was only done in camera plugin.
> > > > > > The problem is most people is not aware of this, so they just
> > update
> > > > the
> > > > > > README.md manually as on any other plugins, and most of the
> > > committers
> > > > > > aren't aware neither or forgot about it and just merge those
> > changes.
> > > > > >
> > > > > > So, I was about to send a new PR and the jsdoc2md/TEMPLATE.md is
> > out
> > > of
> > > > > > sync with the README.md.
> > > > > >
> > > > > > So, we have two options, we can move back to a regular README.md
> > like
> > > > the
> > > > > > other plugins, or do this in all the plugins and not accept
> > README.md
> > > > > file
> > > > > > changes without the corresponding jsdoc2md/TEMPLATE.md.
> > > > > >
> > > > > > What do you think?
> > > > >
> > > > > -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > >
> > > > >
> > > >
> > >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Supported iOS Versions

[Gearóid M]

Apologies, my last reply (and thus Julio's follow up) was accidentally
not to the list.
To sum up, we only support iOS 9+ since 4.4.0. I'll update the docs to
reflect this. I think a lot of the docs are in a poor state, and I hope
to improve them over the next few months.

On Fri, 31 Aug 2018, at 15:47, julio cesar sanchez wrote:
> Ah, sorry, it was in 4.4.0
> 
> https://cordova.apache.org/announcements/2017/04/26/ios-release.html
> 
> El El vie, 31 ago 2018 a las 1:21, Gearóid M 
> escribió:>> Ah I see, so the versioning is more of a documentation issue 
> then. I
>> had checked the cordova-ios RELEASE NOTES.md and didn't see anything
>> about dropping support for iOS 8.>> 
>>  On Wed, 29 Aug 2018, at 18:35, julio cesar sanchez wrote:
>>  > We dropped support for iOS 8 on cordova-ios 4.5 and as far as I
>>  > remember,>>  > dropping iOS 9 was on the list of next major release 
>> schedule.
>>  > 
>>  > 
>>  > El El mié, 29 ago 2018 a las 11:28, Gearóid M 
>>  > escribió:>>  > 
>>  > > The topic of supported iOS version came up in a docs PR recently
>>  > > [1]. I>>  > > was surprised to find that we still  support iOS 8. I 
>> imagine if
>>  > > someone>>  > > came along with an issue on iOS 8, we wouldn't bother 
>> fixing it.>>  > >
>>  > > In the Android docs, we say "As a general rule, Android versions
>>  > > become>>  > > unsupported by Cordova as they dip below 5% on Google's
>>  > > distribution>>  > > dashboard".[2] Should we adopt the same model for 
>> iOS? According
>>  > > to>>  > > Apple[3], 95% of users are on iOS 10 or 11.
>>  > >
>>  > > I suggest that the next major version of cordova-ios only
>>  > > supports iOS>>  > > 10+, and that in future we continue to follow this 
>> 5% rule
>>  > > across all>>  > > platforms to lower our maintenance burden.
>>  > >
>>  > > [1] https://github.com/apache/cordova-docs/pull/873
>>  > > [2]
>>  > > 
>> https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#requirements-and-support>>
>>   > > [3] https://developer.apple.com/support/app-store/
>>  > >
>>  > > 
>>  > > ->>  > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>  > > For additional commands, e-mail: dev-h...@cordova.apache.org
>>  > >
>>  > >

[DISCUSS] Supported iOS Versions

[Gearóid M]

The topic of supported iOS version came up in a docs PR recently [1]. I was 
surprised to find that we still  support iOS 8. I imagine if someone came along 
with an issue on iOS 8, we wouldn't bother fixing it.

In the Android docs, we say "As a general rule, Android versions become 
unsupported by Cordova as they dip below 5% on Google's distribution 
dashboard".[2] Should we adopt the same model for iOS? According to Apple[3], 
95% of users are on iOS 10 or 11. 

I suggest that the next major version of cordova-ios only supports iOS 10+, and 
that in future we continue to follow this 5% rule across all platforms to lower 
our maintenance burden.

[1] https://github.com/apache/cordova-docs/pull/873
[2] 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#requirements-and-support
[3] https://developer.apple.com/support/app-store/

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Support questions in GitHub issues

[Gearóid M]

I agree, Github issues should only be for bug reports and feature requests. For 
Onsen UI, we have an issue template [1], which specifically explains where to 
go for support. Additionally, the template is geared towards bug reporting, 
which further discourages people from asking for support. Of course, some 
people ignore the template and file issues looking for support anyway, but 
having the clear template means we can just close the issue and point them 
again in the right direction.

[1] 
https://raw.githubusercontent.com/OnsenUI/OnsenUI/master/.github/ISSUE_TEMPLATE.md

On Sat, 11 Aug 2018, at 16:30, raphine...@gmail.com wrote:
> Jan proposed a support label for issues more than once. That fit me
> thinking. Do we really want to allow support questions like this one [1] in
> the issues?
> 
> I'm definitely against it. I think we should make that clear in the issue
> template and direct people to slack or stackoverflow. We might still use a
> support label as closing reason.
> 
> What do you think?
> 
> [1]: https://github.com/apache/cordova-android/issues/474

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Dealing with deprecated repos

[Gearóid M]

+1 on archiving deprecated repos, it's an easy way to make it very clear that 
it is no longer maintained

On Wed, 8 Aug 2018, at 01:37, Chris Brody wrote:
> +1
> On Tue, Aug 7, 2018 at 11:32 AM julio cesar sanchez
>  wrote:
> >
> > Archived repos are read only.
> >
> > People can still clone and/or fork them, they just can't send PRs or create
> > new issues.
> >
> > I'm +1 on archiving them.
> >
> >
> >
> > El mar., 7 ago. 2018 a las 17:25,  escribió:
> >
> > > I suggest archiving them all and deal with any issues as they appear. 
> > > After
> > > all, repos can be unarchived if necessary.
> > >
> > > Chris Brody  schrieb am Di., 7. Aug. 2018, 17:16:
> > >
> > > > Continuation of discussion from
> > > >
> > > >
> > > https://lists.apache.org/thread.html/affbc74f0ff4d34bc09657c3c302e185cc98b946d260184847fdf191@%3Cdev.cordova.apache.org%3E
> > > >
> > > > I think it is not desired to actively support deprecated repos. I
> > > > think the easiest solution is to simply make those repos archived.
> > > >
> > > > But what if there are people still using the deprecated repos who are
> > > > motivated to take them over?
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Reviving Face-to-Face video meetings?

[Gearóid M]

Great idea, I'd like to get to know the Cordova contributors. I probably 
will not be available in the next few weeks, but I would like to join in 
in the future if it becomes a regular occurrence.


On 2018/07/18 3:59, raphine...@gmail.com wrote:

Definitely!

Chris Brody  schrieb am Di., 17. Juli 2018, 20:30:


+1, would be really nice!
On Tue, Jul 17, 2018 at 2:19 PM Darryl Pogue  wrote:

Hey folks,

In the days of old, the Cordova project tried to have semi-regular
video conference meetings on Hangouts for coordinating work and
getting to know fellow collaborators a bit better. Those dropped off
as people became less active on the project, but with a bunch of new
and eager faces it probably makes sense to set up a meeting to discuss
the roadmap and release timeline.

Historically we used Google Hangouts because there was a way to make
the meeting publicly viewable, but we could also use
Skype/Zoom/whatever is popular these days. Ideally something that can
just work by clicking a link.

We have a wide range on contributors from across the globe, but we
will try our best to find a time that works for as many people as
possible. Let's gauge interest and pick a rough timeframe and then we
can set up a Doodle poll for people to pick specific hours.

Is there interest in trying to schedule a video call sometime between
now and August 3rd?

~Darryl

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Contributor Introduction

[Gearóid M]

Hi all,

My name is Gearóid. I've been building apps with Cordova for many years, and am 
hoping to now start contributing to the project. I am currently working at 
Monaca, and I am also the maintainer of the Onsen UI framework.

I have a lot of experience with Javascript, HTML and CSS, as well as experience 
creating several Cordova plugins with Java. I hope to be able to make some 
contributions in these areas.

P.S. I see many familiar names on the mailing list from previous Phonegap Days 
in Amsterdam -- looking forward to collaborating with you all!

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org