[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/236#discussion_r55312985
--- Diff: doc/readme.md ---
@@ -315,6 +315,7 @@ cordova {plugin | plugins} [
| |--link | When installing from a local path,
creates a symbolic link instead of copying files. The extent to which files are
linked varies by platform. Useful for plugin development.
| |--save | Save the `` as part of
the `plugin` element into `config.xml`.
| |--browserify | Compile plugin JS at build time using
browserify instead of runtime.
+| |--force | Forces copying source files from the
plugin even if the same file already exists in the target directory.
--- End diff --
Yup, I rebased and changed readme.md as you requested.
Please merge all 5 pull requests in CLI, LIB, ANDROID, IOS, WINDOWS.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/402#issuecomment-192706126 Thanks for merging, @vladimir-kotikov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-192706090 Thank you for merging, @vladimir-kotikov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-192567709 @vladimir-kotikov , Just a friendly reminder. This is still not merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/402#issuecomment-19288 @vladimir-kotikov , I added an e2e test that is described in CB-10328. The test fails without my fix, and passes with my fix. Could you merge this pull request? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10673 fixed conflicting plugin in...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-windows/pull/154#issuecomment-192389824 @nikhilkh, Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10673 added --force-copying-src optio...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/404#issuecomment-192389465 @nikhilkh, Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10673 fixed conflicting plugin instal...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-ios/pull/199#issuecomment-192389706 @nikhilkh, Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-cli/pull/236#issuecomment-192151135 Hi @nikhilkh Thanks for reviewing. I changed all 5 pull requests (CLI, LIB, android, ios, windows) to accommodate your comments using --force. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/402#discussion_r54902889
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -71,7 +71,8 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
project_dir = cordovaUtil.convertToRealPathSafe(project_dir);
plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir);
options = options || {};
-options.is_top_level = true;
+if (options.is_top_level === undefined)
--- End diff --
I changed as you suggested.
Do you mean you want to set options.is_top_level = true if
options.is_top_level is set to null ?
In fact, the is_top_level is a boolean property, so a null value for this
property is a bug although null is falsy in Javascript.
When options.is_top_level is set to null for some reason,
options.hasOwnProperty('is_top_level') is true.
That means, the new condition (options.hasOwnProperty('is_top_level') ===
false) will not change options.is_top_level from the null value to true.
Just wanted clarify.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-android/pull/264#issuecomment-191616111 Since now I created the --force-copying-src option, the current behavior of throwing exception is preserved. To get around this issue, the user can use this new command-line option. I have created several related pull requests. Please review them together. https://github.com/apache/cordova-cli/pull/236 https://github.com/apache/cordova-lib/pull/404 https://github.com/apache/cordova-ios/pull/199 https://github.com/apache/cordova-windows/pull/154 Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10673 added --force-copying-src optio...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/404 CB-10673 added --force-copying-src option This option is need to rescue some Cordova users who has trouble installing two conflicting plugins that use the same source-file target. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-10673 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #404 commit 3d8281865ffa2d0c54e7c0886e3c926df515e923 Author: Byoungro So Date: 2016-03-02T07:23:19Z CB-10673 added --force-copying-src option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-cli/pull/236 CB-10673 added --force-copying-src option This option is need to rescue some Cordova users who has trouble installing two conflicting plugins that use the same source-file target. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-cli CB-10673 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit 4309a60ebd4b5282d55b25ab8f7be8c5e0e74970 Author: Byoungro So Date: 2016-03-02T07:19:59Z CB-10673 added --force-copying-src option commit 89246a76fec97f400b866e5d275d8a21dfa99a8a Author: Byoungro So Date: 2016-03-03T06:22:39Z CB-10673 added --force-copying-src option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/402#issuecomment-191536082 @vladimir-kotikov Could you review this pull request? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-android/pull/264#issuecomment-191319864 I am working on adding a command-line option --force-copying-src to allow the Cordova user to try overwriting the conflicting file. I hope this gives some breathing room for those users who need to use two conflicting plugins. The default value of this option is false, so the existing behavior is unchanged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190952289
Right. I agree that silently passing is not good.
So, I said that we should print the warning message to the user "Warning:
in the already exists. {Skipped copying/Overwrote} that
file".
My proposal leaves some options to make the plugins runnable without
changing the Cordova source code.
I am not sure how the current behavior of throwing an exception is better
than this proposal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-android/pull/264#issuecomment-190937260 Hi nikhill, I am not a plugin writer so I don't know whether the plugin write can use other tags for their purposes. This issue was reported from one of the Intel xdk users who needed to use both plugins in his app. It looks to me that tag is quite frequently used for some library files (as Vladimir pointed out). Whenever the user complains about this issue, we (Cordova) can't blame the plugin developers for not checking with possible conflicts with other plugins. I think the users will understand the new warning message (once aded), and if any issue arise by skipping/overwriting the existing files, and they can try a different order to resolve the issue. However, when Cordova CLI throws an exception, it just leaves no option for the user. It is going to be a dead end for this use case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-android/pull/264#issuecomment-190778940 @vladimir-kotikov, This is just one example of the conflicting plugins. There could be so many plugins out there that requires the same library files. Usually, the library files are very commonly used in many plugins. Those files usually come from the same cordova- templates. The problem is that we disallow those plugins to be installed with an exception that says "Uh oh! stacktrace...". This makes impossible to use two plugins that use the same library files. This is not plugin writer's fault or app developer's fault. We may have to print the warning log that says "the library file already exists. skipped copying them" or "overwrote it.". Throwing an exception is too strict in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/402 CB-10328 set top-level property of plugins when adding new platforms The problem is caused by not setting the top-level property of plugins from cordova/platform.js-installPluginsForNewPlatform() function and by always setting is_top_level to true in plugman/install.js-installPlugin. This caused all plugins that exist in the plugins directory to be set top-level in plugins/.json files. The uninstallation process relies on this metadata file to see if there is any dependency plugin was installed when removing a top-level plugin. By setting the top-level correctly in .json files, this uninstallation process worked correctly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-10328 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/402.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #402 commit c7b3f4e5ce74c4cf79c14fa8239ad7a7cc07ebfe Author: Byoungro So Date: 2016-02-28T15:59:49Z CB-10328 set top-level property of plugins when adding new platforms --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10673 CB-10673 fixed conflicting ...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-windows/pull/154 CB-10673 CB-10673 fixed conflicting plugin install issue with overlapped The problem is that copyNewFile is too strict for tag. You will never know which two plugins will write the library to the same target-dir of the source-file. We should let it copy the library to the same location. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-windows CB-10673 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit fb18ccd50e25246d039ffdcbae59db9ce0cff316 Author: Byoungro So Date: 2016-02-27T06:34:29Z CB-10673 fixed conflicting plugin install issue with overlapped tag commit 73da0e419fedd15595d348b0953f18f334732a21 Author: Byoungro So Date: 2016-02-28T01:48:06Z CB--10673 fixed jshint error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-android/pull/264 CB-10673 fixed conflicting plugin install issue with overlapped tag The problem is that copyNewFile is too strict for tag. You will never know which two plugins will write the library to the same target-dir of the source-file. We should let it copy the library to the same location. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-android CB-10673 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/264.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #264 commit 06f167efd91e17e1f3125056bb1da85efae165e2 Author: Byoungro So Date: 2016-02-27T06:32:37Z CB-10673 fixed conflicting plugin install issue with overlapped tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10673 fixed conflicting plugin instal...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-ios/pull/199 CB-10673 fixed conflicting plugin install issue with overlapped tag The problem is that copyNewFile is too strict for tag. You will never know which two plugins will write the library to the same target-dir of the source-file. We should let it copy the library to the same location. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-ios CB-10673 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #199 commit a666932219e1547321d2b41a0540fc4038b9b4d9 Author: Byoungro So Date: 2016-02-27T06:33:54Z CB-10673 fixed conflicting plugin install issue with overlapped tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54334968
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
var splitVersion = plugin_src.split('@');
var newID = pluginMapperotn[splitVersion[0]];
if(newID) {
-events.emit('warn', 'Notice: ' + splitVersion[0] + ' has
been automatically converted to ' + newID + ' to be fetched from npm. This is
due to our old plugins registry shutting down.');
plugin_src = newID;
if (splitVersion[1]) {
plugin_src += '@'+splitVersion[1];
}
-}
-return registry.fetch([plugin_src])
+}
+var P, skipCopyingPlugin;
+plugin_dir = path.join(plugins_dir, splitVersion[0]);
--- End diff --
I agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-189672357 Yes, please merge this for me. I don't have committer privilege, which I wish to get. :) Thanks, Vladimir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-android/pull/261#issuecomment-189579252 Thanks for merging, Vladimir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-189578539 Hi Vladimir, I updated the code to accommodate your comments. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328731
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
}
var current_stack = new action_stack();
-
// Split @Version from the plugin id if it exists.
var splitVersion = id.split('@');
//Check if a mapping exists for the plugin id
//if it does, convert id to new name id
-var newId = pluginMapper[splitVersion[0]];
+var newId = pluginMapper.oldToNew[splitVersion[0]];
if(newId) {
-events.emit('warn', 'Notice: ' + id + ' has been automatically
converted to ' + newId + ' and fetched from npm. This is due to our old plugins
registry shutting down.');
if(splitVersion[1]) {
id = newId +'@'+splitVersion[1];
} else {
id = newId;
}
- }
-return possiblyFetch(id, plugins_dir, options)
+}
+var P;
+var plugin_dir = path.join(plugins_dir, splitVersion[0]);
+// if the plugin has already been fetched, use it.
+if (fs.existsSync(plugin_dir)) {
+P = Q(plugin_dir);
+} else {
+var alias = pluginMapper.newToOld[splitVersion[0]] || newId;
+// if the plugin alias has already been fetched, use it.
+if (alias && fs.existsSync(path.join(plugins_dir, alias))) {
+P = Q(path.join(plugins_dir, alias));
--- End diff --
I actually added a warning message in the fetch.js file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328707
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
}
var current_stack = new action_stack();
-
// Split @Version from the plugin id if it exists.
var splitVersion = id.split('@');
//Check if a mapping exists for the plugin id
//if it does, convert id to new name id
-var newId = pluginMapper[splitVersion[0]];
+var newId = pluginMapper.oldToNew[splitVersion[0]];
if(newId) {
-events.emit('warn', 'Notice: ' + id + ' has been automatically
converted to ' + newId + ' and fetched from npm. This is due to our old plugins
registry shutting down.');
if(splitVersion[1]) {
id = newId +'@'+splitVersion[1];
} else {
id = newId;
}
- }
-return possiblyFetch(id, plugins_dir, options)
+}
+var P;
--- End diff --
Yes, that's a good idea.
I revised the code as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328698
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
var splitVersion = plugin_src.split('@');
var newID = pluginMapperotn[splitVersion[0]];
if(newID) {
-events.emit('warn', 'Notice: ' + splitVersion[0] + ' has
been automatically converted to ' + newID + ' to be fetched from npm. This is
due to our old plugins registry shutting down.');
plugin_src = newID;
if (splitVersion[1]) {
plugin_src += '@'+splitVersion[1];
}
-}
-return registry.fetch([plugin_src])
+}
+var P, skipCopyingPlugin;
+plugin_dir = path.join(plugins_dir, splitVersion[0]);
--- End diff --
In fact, cordova-plugin.js invokes plugman-fetch first and then
plugman-install.
So, we need to check existence of the plugin here.
The same checking in plugman-install is still needed because
plugman-install can be invoked directly from plugin CLI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-189123404 @vladimir-kotikov Could you review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-android/pull/261#issuecomment-189122310 @vladimir-kotikov , Could you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-ios/pull/195#issuecomment-189121892 Hi @nikhilkh Thanks for testing. Could you merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-android/pull/261 CB-10660 fixed the exception when removing a non-existing directory It is ALWAYS safer to check if the directory exists before it tires to remove the directory. The uninstallation of the plugin with a tag failed because of this issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-android CB-10660 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/261.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #261 commit 8604829854b59f14938796c109e446c36de9720f Author: Byoungro So Date: 2016-02-22T00:25:21Z CB-10660 fixed the exception when removing a non-existing directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-ios/pull/195 CB-10659 changed project name to fix the platform add failure The project name "Hello Cordova" does not match with template project "HelloCordova", and it causes failure when finding the .xcodeproj file as a part of installing plugin files. By matching the project names with the template, platform add worked fine. After the fix is applied, the platforms/ios directory contains the following files: ``` [ios] ls CordovaLib cordovawww HelloCordova ios.json HelloCordova.xcodeproj platform_www ``` The platform add ios worked fine now. ``` [t6.0.1] cordova platform add ~/cordova/bso-cordova-ios Adding ios project... iOS project created with cordova-ios@4.1.0-dev Installing "cordova-plugin-device" for ios Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the project Fetching plugin "cordova-plugin-whitelist@1" via npm Installing "cordova-plugin-whitelist" for ios ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-ios CB-10659 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #195 commit be3e2ea6ab69f890469e142f68457da056336cbb Author: Byoungro So Date: 2016-02-21T23:18:25Z CB-10659 changed project name to fix the platform add failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/396
CB-10314 avoid fetching plugins when oldId is already fetched
implement the fix to the issue in CB-10314.
Before start fetching the plugin, first check if the plugin with alias id
is already fetched in the project.
Otherwise, it is a waste of time fetching the plugin with newId and then
decide not to install.
This pull request also includes a fix to the issue of reporting the bogus
mismatched id error which is caused by fetching the new-Id when old-Id is
renamed to fetch. (checkID function in fetch.js)
After the fix, the plugin add is changed as follows:
{code}
[CB-10314] cordova plugin
cordova-plugin-whitelist 1.2.1 "Whitelist"
org.apache.cordova.device 0.3.0 "Device"
[CB-10314] cordova plugin add org.apache.cordova.device
Plugin "org.apache.cordova.device" already installed on ios.
{code}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bso-intel/cordova-lib CB-10314
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #396
commit e88e2a1050a770e594a8ac8e6b179836ca819323
Author: Byoungro So
Date: 2016-02-21T05:48:13Z
CB-10314 avoid fetching plugins when oldId is already fetched
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/395#issuecomment-186517246 It looks great assuming that before_platform_add and after_platform_add hooks could be platform specific. My understanding about the current convention is a little different, though. Thanks, Tony. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545261
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var platformsDir = path.join(projectRoot, 'platforms');
shell.mkdir('-p', platformsDir);
-return hooksRunner.fire('before_platform_' + cmd, opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its helper script.
-var parts = target.split('@');
-var platform = parts[0];
-var spec = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-spec = platform;
-platform = null;
-}
+return promiseutil.Q_chainmap(targets, function(target) {
+// For each platform, download it and call its helper script.
+var parts = target.split('@');
+var platform = parts[0];
+var spec = parts[1];
+var platDetails = '';
+
+return Q.when().then(function() {
+if (!(platform in platforms)) {
+spec = platform;
+platform = null;
+}
-if(platform === 'amazon-fireos') {
-events.emit('warn', 'amazon-fireos has been
deprecated. Please use android instead.');
-}
-if(platform === 'wp8') {
-events.emit('warn', 'wp8 has been deprecated. Please
use windows instead.');
-}
-if (platform && !spec && cmd == 'add') {
-events.emit('verbose', 'No version supplied.
Retrieving version from config.xml...');
-spec = getVersionFromConfigFile(platform, cfg);
-}
+if(platform === 'amazon-fireos') {
+events.emit('warn', 'amazon-fireos has been deprecated.
Please use android instead.');
+}
+if(platform === 'wp8') {
+events.emit('warn', 'wp8 has been deprecated. Please use
windows instead.');
+}
+if (platform && !spec && cmd == 'add') {
+events.emit('verbose', 'No version supplied. Retrieving
version from config.xml...');
+spec = getVersionFromConfigFile(platform, cfg);
+}
+
+// If --save/autosave on && no version specified, use the
pinned version
+// e.g: 'cordova platform add android --save', 'cordova
platform update android --save'
+if( (opts.save || autosave) && !spec ){
+spec = platforms[platform].version;
+}
-// If --save/autosave on && no version specified, use the
pinned version
-// e.g: 'cordova platform add android --save', 'cordova
platform update android --save'
-if( (opts.save || autosave) && !spec ){
-spec = platforms[platform].version;
+if (spec) {
+var maybeDir = cordova_util.fixRelativePath(spec);
+if (cordova_util.isDirectory(maybeDir)) {
+return getPlatformDetailsFromDir(maybeDir, platform);
+}
+}
+return downloadPlatform(projectRoot, platform, spec, opts);
+}).then(function(platformDetails) {
+platDetails = platformDetails;
+var hookOpts = {
+platforms :[platDetails.platform],
+nohooks :[opts.nohooks]
+};
+return hooksRunner.fire('before_platform_' + cmd, hookOpts);
--- End diff --
Now, the behavior is a little different than before.
Previously, the before_platform_add hook ran only once for all target
platforms.
This hook could be platform agnostic.
However, by moving the hookRunner inside per platform, this hook will run
every time each platform is added.
Not sure whether this is an issue or not, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545199
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var platformsDir = path.join(projectRoot, 'platforms');
shell.mkdir('-p', platformsDir);
-return hooksRunner.fire('before_platform_' + cmd, opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its helper script.
-var parts = target.split('@');
-var platform = parts[0];
-var spec = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-spec = platform;
-platform = null;
-}
+return promiseutil.Q_chainmap(targets, function(target) {
+// For each platform, download it and call its helper script.
+var parts = target.split('@');
+var platform = parts[0];
+var spec = parts[1];
+var platDetails = '';
+
+return Q.when().then(function() {
+if (!(platform in platforms)) {
+spec = platform;
+platform = null;
+}
-if(platform === 'amazon-fireos') {
-events.emit('warn', 'amazon-fireos has been
deprecated. Please use android instead.');
-}
-if(platform === 'wp8') {
-events.emit('warn', 'wp8 has been deprecated. Please
use windows instead.');
-}
-if (platform && !spec && cmd == 'add') {
-events.emit('verbose', 'No version supplied.
Retrieving version from config.xml...');
-spec = getVersionFromConfigFile(platform, cfg);
-}
+if(platform === 'amazon-fireos') {
+events.emit('warn', 'amazon-fireos has been deprecated.
Please use android instead.');
+}
+if(platform === 'wp8') {
+events.emit('warn', 'wp8 has been deprecated. Please use
windows instead.');
+}
+if (platform && !spec && cmd == 'add') {
+events.emit('verbose', 'No version supplied. Retrieving
version from config.xml...');
+spec = getVersionFromConfigFile(platform, cfg);
+}
+
+// If --save/autosave on && no version specified, use the
pinned version
+// e.g: 'cordova platform add android --save', 'cordova
platform update android --save'
+if( (opts.save || autosave) && !spec ){
+spec = platforms[platform].version;
+}
-// If --save/autosave on && no version specified, use the
pinned version
-// e.g: 'cordova platform add android --save', 'cordova
platform update android --save'
-if( (opts.save || autosave) && !spec ){
-spec = platforms[platform].version;
+if (spec) {
+var maybeDir = cordova_util.fixRelativePath(spec);
+if (cordova_util.isDirectory(maybeDir)) {
+return getPlatformDetailsFromDir(maybeDir, platform);
+}
+}
+return downloadPlatform(projectRoot, platform, spec, opts);
+}).then(function(platformDetails) {
+platDetails = platformDetails;
+var hookOpts = {
+platforms :[platDetails.platform],
+nohooks :[opts.nohooks]
+};
+return hooksRunner.fire('before_platform_' + cmd, hookOpts);
+}).then(function() {
+platform = platDetails.platform;
+var platformPath = path.join(projectRoot, 'platforms',
platform);
+var platformAlreadyAdded = fs.existsSync(platformPath);
+
+if (cmd == 'add') {
+if (platformAlreadyAdded) {
+throw new CordovaError('Platform ' + platform + '
already added.');
}
-if (spec) {
-var maybeDir
[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545185
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var platformsDir = path.join(projectRoot, 'platforms');
shell.mkdir('-p', platformsDir);
-return hooksRunner.fire('before_platform_' + cmd, opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its helper script.
-var parts = target.split('@');
-var platform = parts[0];
-var spec = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-spec = platform;
-platform = null;
-}
+return promiseutil.Q_chainmap(targets, function(target) {
+// For each platform, download it and call its helper script.
+var parts = target.split('@');
+var platform = parts[0];
+var spec = parts[1];
+var platDetails = '';
+
+return Q.when().then(function() {
+if (!(platform in platforms)) {
+spec = platform;
+platform = null;
+}
-if(platform === 'amazon-fireos') {
-events.emit('warn', 'amazon-fireos has been
deprecated. Please use android instead.');
-}
-if(platform === 'wp8') {
-events.emit('warn', 'wp8 has been deprecated. Please
use windows instead.');
-}
-if (platform && !spec && cmd == 'add') {
-events.emit('verbose', 'No version supplied.
Retrieving version from config.xml...');
-spec = getVersionFromConfigFile(platform, cfg);
-}
+if(platform === 'amazon-fireos') {
+events.emit('warn', 'amazon-fireos has been deprecated.
Please use android instead.');
+}
+if(platform === 'wp8') {
+events.emit('warn', 'wp8 has been deprecated. Please use
windows instead.');
+}
+if (platform && !spec && cmd == 'add') {
+events.emit('verbose', 'No version supplied. Retrieving
version from config.xml...');
+spec = getVersionFromConfigFile(platform, cfg);
+}
+
+// If --save/autosave on && no version specified, use the
pinned version
+// e.g: 'cordova platform add android --save', 'cordova
platform update android --save'
+if( (opts.save || autosave) && !spec ){
+spec = platforms[platform].version;
+}
-// If --save/autosave on && no version specified, use the
pinned version
-// e.g: 'cordova platform add android --save', 'cordova
platform update android --save'
-if( (opts.save || autosave) && !spec ){
-spec = platforms[platform].version;
+if (spec) {
+var maybeDir = cordova_util.fixRelativePath(spec);
+if (cordova_util.isDirectory(maybeDir)) {
+return getPlatformDetailsFromDir(maybeDir, platform);
+}
+}
+return downloadPlatform(projectRoot, platform, spec, opts);
+}).then(function(platformDetails) {
+platDetails = platformDetails;
+var hookOpts = {
+platforms :[platDetails.platform],
+nohooks :[opts.nohooks]
--- End diff --
opts.nohooks is already an array.
So you can change this line to the following
nohooks: opts.nohooks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Github user bso-intel closed the pull request at: https://github.com/apache/cordova-lib/pull/387 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10611 fixed the before_plugin_install...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/388#issuecomment-184999128 Thank you very much, Tim. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/387#issuecomment-184998947 Hi @TimBarham Thanks for reviewing this pull request. I updated the comment as you requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10611 fixed the before_plugin_install...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/388 CB-10611 fixed the before_plugin_install hook not disabled with --noh⦠â¦ooks The fix is to pass the command line option to the plugman when adding a plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-10611 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #388 commit aaa2e6143de412a3affba5bba8a4dd092de4a845 Author: Byoungro So Date: 2016-02-15T01:11:40Z CB-10611 fixed the before_plugin_install hook not disabled with --nohooks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/387 CB-10550 Fixed the issue of plugin id mapper not enforced when a vers⦠â¦ion is specified The issue is described in https://issues.apache.org/jira/browse/CB-10550 The fix is to inspect the given plugin_src if it contains the '@' before it tries to find the mapper database. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-10550 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/387.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #387 commit fab318eca7bf3aa7fe0c454628ecbbf058840ff9 Author: Byoungro So Date: 2016-02-14T20:52:10Z CB-10550 Fixed the issue of plugin id mapper not enforced when a version is specified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173474167 Hi @purplecabbage, Would you review this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172675243
Hi @purplecabbage,
Here is how you can reproduce the issue:
1. cordova platform add windows
2. cordova plugin add cordova-sqlite-storage
3. cordova plugin rm cordova-sqlite-storage
{code}
[CB-10381] cordova plugin add cordova-sqlite-storage
Fetching plugin "cordova-sqlite-storage" via npm
Installing "cordova-sqlite-storage" for windows
[CB-10381] cordova plugin rm cordova-sqlite-storage
Uninstalling cordova-sqlite-storage from windows
Error: Uh oh!
EISDIR, illegal operation on a directory
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-172667498 Hi @vladimir-kotikov Could you review this pull request? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-windows/pull/140 CB-10381 fix the bug when removing a plugin with a tag I fixed a simple bug that caused an exception EISDIR when removing a plugin that includes a tag. PluginHandler.js should have passed the project file instead of the plugin directory. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-windows CB-10381 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit d5079b99bdb0ab5fe7d75ed13853de762e0cf254 Author: Byoungro So Date: 2016-01-18T22:02:40Z CB-10381 fix the bug when removing a plugin with a tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 7183
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166444947 Thanks for merging, Shazron!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 7183
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166441171 Hi Shazron, I added a unit test that detects the security violation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 7183
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166405427 Got it. Sorry. I will add a unit test that detects the path escaping issue, and let you know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 7183
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/355#issuecomment-166404691
Hi Sharon,
Thanks for reviewing.
I don't see any failures for the test.
{quote}
[cordova-lib] node_modules/jasmine-node/bin/jasmine-node
spec-plugman/install.spec.js
Finished in 1.84 seconds
24 tests, 35 assertions, 0 failures, 0 skipped
{quote}
It seems CIs also show all checks passed.
Could you tell me how to reproduce the error you are seeing for the
install.spec.js?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-166358430 Thank you very much for merging, Vladimir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-166358228 Thank you very much for merging, Vladimir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-165950153 Hi Vladimir, Thank you for reviewing. I addressed your feedback, and updated the help doc, and created one unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-165950086 Hi Vladimir, Thank you very much for reviewing. I addressed your feedback and added several unit tests in LIB and CLI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-165622485 Hi Jesse and Vladimir, Could you review this together with my pull request in https://github.com/apache/cordova-lib/pull/353 for cordova-lib? Two of them should be pulled together for CB-8455. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 7183
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-165621005 Hi Shazron, Could you review this CB-7183? As we discussed we need some security check for plugins accessing outside the plugins directory. Please pull if it looks okay. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-165619803 HI Jesse and Vladimir, If there is no more comment, could you pull my branch CB-8455 so the next Cordova release contains this feature? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 7183
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/355 Cb 7183 CB-7183 security check for the scriptSrc property of the engine tag. The other src and target-dir path escape checks are already implemented in cordova-lib/src/plugman/platforms/common.js/copyFile() function. The only missing security check is in the scriptSrc of the tag. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-7183 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 commit 5fd5d275cd13ebe9eb3b7c86b71988cdcdfa4cf8 Author: Byoungro So Date: 2015-12-10T03:43:46Z CB-7183 prevent read/write/modify files outside project from plugins commit c03534aafc218923327ae7921eb75669927625d4 Author: Byoungro So Date: 2015-12-12T05:48:03Z CB-7183 security check for engine scriptSrc tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163324816 Hi Vladmir, Exactly. The pre-package hooks on for the windows* platforms run when LIB prepares for the source. To suppress this hook, HookRunner needs the option "--nohooks pre_package" that is propagated from the command line. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163090076 Hi Jesse, The CI failures actually were caused by not checking the existence of the opts parameter. In the spec unit tests, update_project() was invoked without the opts parameter that I added in windows_parser.js and wp8_parser.js. I have fixed the issues, and now all tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/353 CB-8455 added --nohooks option implemented --nohooks noption as described in CB-8455 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-8455 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/353.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #353 commit d77c2d27bbf785f1c2471156f36693e5ce06b9dd Author: Byoungro So Date: 2015-12-08T04:53:43Z added --nohooks option commit f8a430ccf5fc1db7f555dcbbd84651c3da7ca5f6 Author: Byoungro So Date: 2015-12-08T04:53:43Z CB-8455 added --nohooks option commit b4be9c724a70d819975f50b615da9a7203ad85e5 Author: Byoungro So Date: 2015-12-08T05:04:03Z Merge branch 'CB-8455' of https://github.com/bso-intel/cordova-lib into CB-8455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8455 added --nohooks option
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-cli/pull/230 CB-8455 added --nohooks option implemented --nohooks option described in CB-8455 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-cli CB-8455 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/230.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #230 commit 9e8fdd146bd6c2bd6df12eb96ad806a46df1bb7f Author: Byoungro So Date: 2015-12-08T04:50:11Z added --nohooks option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
