[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/185 Any reason why this can't be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #120: CB-11513: (ios) Fixed: iOS memory warning s...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/120 could this get merged? I have been maintaining a forked plugin for months with this PR merged and it works well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #120: CB-11513: (ios) Fixed: iOS memory warning s...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/120 I have merged this into my project and tested and confirm that it does what it says on the box. Before: simulate memory warning on the iOS simulator and audio stops instantly on the native side. App continues to function otherwise but no longer plays any audio After: simulate a memory warning on the iOS simulator and audio continues to play as expected, all works as normal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #136: mediaFile.play(); its not working
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/136 This is not a pull request. Please close this and try the Cordova slack channel or search around on stack overflow or similar resources for issues and support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 I haven't tested this yet, just found the PR while looking through various forks. I plan to test to mAke sure this is consistent with iOS and then will update here with suggestion to merge or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #99: Suppress warnings: Pass in the settings obje...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/99 I had a PR for the same issue which has just been merged and is in master. Installing the media plugin from github confirms the errors in xcode are resolved. This PR could be closed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #122: CB-12157: (android): Fix java.lang.NullPoin...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/122 @shazron thanks, sorry to bug you just figured you were kind of the gatekeeper here. @infil00p I have been running with this PR (and the other null point PR that was recently added) for a few days in all my apps testing and all works well. This has resolved the issue where another app taking audio focus just as a create/release of media was happening would cause the media plugin to throw a null pointer. I have not seen any ill effects and I can no longer reproduce the issue. Have tested on Android 5/6 on a 3 different devices and all good so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #129: (android) Fix NullPointerException in Audio...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/129 @TommiKetola #122 should catch most scenarios that would cause this one to occur. However, there is no validation that a value is passed in to the method that this PR patches either so there is always the change that we are comparing a NULL to something. I still think this patch should be included as well so that basic data validation is performed. @shazron - I have been testing this PR out over the last few days in my own apps and have had no issues. This could be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/130 CB-8098 & CB-7810:(android) Added media rate for android ### Platforms affected Android ### What does this PR do? adds set rate function for android this already exists on iOS there are long running issues in jira for this functionality ### What testing has been done on this change? tested in my own project, playback rate audibly changes. There are already automated tests for playback rate, this just adds another platform. ### Checklist - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/altaf933/cordova-plugin-media master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit e4e8a714bceaa58ed93b96bd69153adf5bd0975a Author: altaf Date: 2017-02-10T09:45:26Z Added media rate for android verion 6.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #122: CB-12157: (android): Fix java.lang.NullPoin...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/122 @shazron - this would be a great one to get in, I am having this issue frequently now on android with more apps having audible announcements and prompts. Nothing like having your music player crash mid run to annoy you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #122: CB-12157: (android): Fix java.lang.NullPoin...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/122 So I have started to encounter the problem this fixes recently. Using runkeeper along with my music app runkeeper will take the audio focus for it's announcements. If it happens to do this just as your media is being released or created then when it hands the focus back the app will fail as it will call play on a media that wasn't successfully created. Would be good to get this merged as it has resolved this issue for me on Android with no side effects that I have noticed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #124: CB-12319: (Android&iOS) Fix bug that record...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/124 This would be a nice one to get merged in for improving cross platform compatibility, need this for one of my apps to work smoothly when syncing audio recordings between multiple devices. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron I just checked Jira and CB-11817 is the correct Jira issue for this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This is a really trivial fix could it please get merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 I will look through the proposed changes next week and resolve conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 @jcesarmobile - updated to remove that duplicate code, tested in my app and it's working well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 Oh I see now, sorry I misunderstood. I can definitely make that change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/185 I have been using this pr as well and it works well, makes the toolbar have a much more native look and feel. This definitely seems like a no brainier to merge in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 The new methods follow what is implemented for close, where there are 2 close methods, one designed for the user to call and one for use with a selector that the done button will hit. In order to have minimal changes to the existing code and keep the logic consistent I have implemented the same for the hide method. You can just reuse the existing hide method as it expects a parameter which cannot be passed when it is used as a selector. Hence the 2 close methods as well. The browserHide method is implemented in line with the browserExit method again for consistent behaviour. While there is some code duplication it seems that it is necessary because of the different use cases, or called as selector vs called by user from javascript. I have implemented for iOS and android, I could possibly do windows as well but I don't have the devices to test other platforms. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
CB-12132: (android & ios) implement hidenotclose feature
### Platforms affected
android & ios
### What does this PR do?
This adds a new option hidenotclose which can be passed to the
inappbrowser.
When set to yes the done button on iOS or the X button android will
hide the web view instead of closing it.
This allows the user to show/hide the web view multiple times without
having to reload the content and you can clean up when you know they
are done by calling close once.
### What testing has been done on this change?
manually tested on both android and ios with both enabled and disabled
settings.
when disabled (as by default) existing behaviour is maintained
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [O] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghenry22/cordova-plugin-inappbrowser
hide_not_close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #197
commit ec563a7af77e9f74cc73be8fd1a606946d4b4809
Author: ghenry22
Date: 2016-11-11T07:39:35Z
CB-12132: (android & ios) implement hidenotclose feature
This adds a new option hidenotclose which can be passed to the
inappbrowser.
When set to yes the done button on iOS or the X button android will
hide the web view instead of closing it.
This allows the user to show/hide the web view multiple times without
having to reload the content and you can clean up when you know they
are done by calling close once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-android/pull/340 I have the same problem, after upgrading the platform I now get default cordova icons for my android build, even though with the previous version of the platform all icons and splash screen images were in place and all specified in config.xml. I use ionic framework to auto generate all splash / icon images and insert them into the config.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron any chance this could get merged? It's a really small change that basically just fixes an oversight in the current version, which makes recording much more efficient and stops xcode throwing warnings all over. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #116: CB-1187: (iOS) Fix unused recording setting...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 I didn't add any automated tests as it wasn't relevant, this was just a really simple bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #116: CB-1187: (iOS) Fix unused recording ...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/116 CB-1187: (iOS) Fix unused recording settings ### Platforms affected iOS ### What does this PR do? easy fix: audioSettings object wasn't being passed in when starting a recording. ### What testing has been done on this change? run automated tests, run in custom app. All works as expected. build in xcode. Cleared up 2 warnings for an unused variable and null argument passed to recorder. ### Checklist - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit 642aef774aa60a34b29d451f684ffc67bf732700 Author: ghenry22 Date: 2016-09-07T01:37:59Z CB-1187: (iOS) Fix unused recording settings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #104: Acc+
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/104 Those just seem to be all of the recent commits. I'm not entirely sure why they are attached to this PR but I don't think they are specific to what you are asking. Do you mean AAC format streams? Or is ACC something else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #97: CB-11314 android: avoid seeking on media wit...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/97 This is also a problem with MP3 files where android (for whatever reason) cannot read the duration of the file. This could be some slight corruption to the file over time or it could be simply an encoding format that android doesn't like. This is pretty well documented with people having to work around the same issue in native audioplayers that use the same underlying frameworks. I went insane trying to figure out why iOS would seek within a local file but Android intermittently wouldn't. I'm definitely going to give this PR a test! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #87: Fix for CB-10882 : Plugin Media - "cordova-p...
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/87 Just reading through your steps to reproduce in Jira and wanted to check where you are seeing the problem. First you make a recording (this seems to work). You then call getCurrentPosition(). Before calling getCurrentPosition(), have you stopped the recording, saved it and then created a new media object with the recording as SRC, called media.play() and then getCurrentPosition()? I am going to do some testing and have a look at it, I just want to be really clear about where the problem is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Make moveFile() always copy ins...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/96#issuecomment-220506090 @piyushkhare11 - this is not the right place for your question, I suggest that you log a ticket on the cordova jira or ask in the cordova slack channel. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Fix for CB-10822 : Plugin Media...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-207303423 @sonicwong it's not related to this as this PR is related to getPosition for recordings. There was however, recently a PR merged that fixed playback of local files where no protocol prefix was set. I would suggest trying the latest version of the plugin installed directly from github with: cordova plugin add https://github.com/apache/cordova-plugin-media.git --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Fixing issues on Android 6.0
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-207159923 @purplecabbage there are 2 single line changes on this PR, one of which is already incorporated into master from another commit. If the second one liner from here could be committed to trunk then this PR could be closed and media plugin would work normally on Marshmallow. Seems like a very quick and easily resolution. I have been using a fork of the plugin with change incorporated for around a month now (since I realised Marshmallow was broken!) with no issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-207159395 @purplecabbage comments on this PR could not possibly go further off topic :) Seems to have become defacto media plugin support for a while there. I had some odd permission issue on my mac initially and used sudo to install as well. No matter what I did always had that problem, probably because I installed something early on with Sudo and then all the permissions became a mess. Was resolved when I did a refresh of the OS on my mac and a clean install of all the tools without using sudo for anything. Doesn't seem to hurt anything either way though and all build tools etc work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-201359813 @ThunderTech-Avisolve I'm not sure what the exact limitations are with avplayer but you could look it up in apples docs, they do have documentation of the formats I will play. I generally work with MP3 files and have had no problems with variable or constant bitrate files anywhere between 64kbit and 256kbit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: By default always first check D...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-200148555 At this point it might be more sensible to drop the steps that auto search in a few folders and instead have a simple explicity behaviour. This would cut out a chunk of code base and would just require users to be specific about where a file is rather than assuming the plugin will find it in one of several places. Just like you would when opening a file on your local computer file system. no path = application root (ie www/ in your cordova app) otherwise http://, https://, rtsp:// for remote files or cdvfile:// for local files (potentially other platform specific format such as file:// on Android but still with a full internalURL to the file) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Handles the "playAudioWhenScree...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/54#issuecomment-200146892 Apparently playAudioWhenScreenIsLocked is deprecated on iOS (from the tickets I was reading today) anyway so this PR could probably be closed if that is correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-200146522 Just been testing this in my project, seems to work well. One issue with this PR is that you have deleted a closing bracket on line 510 that should still be present. Once I fixed that one small thing this PR works perfectly for my project with Android 6.0 and resolved some playback issues I was having that were not present on earlier versions of Android. I would recommend fixing that one bracket and then merging this too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Fixing issues on Android 6.0
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-200146217 Note that the first change in this PR is already included in master for v2.2.0, I have been testing with the second change also included and that combined with PR #72 has resolved my audio playback issues on Marshmallow where playback of local files was fine but playback of remote streaming files would fail 99% of the time silently. Only catch with this is that you can't seek before the file is ready to play, but that was already the case for non-local files anyway and local files are ready to play pretty much instantly so no difference really. Would recommend merging in the second change in this, it's only a single line commented out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-199633964 I have also hit this problem and it causes ongoing issues for my app. Could this be checked and merged soon? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-199568786 @tommy1688 that change will completely break streaming audio support. All it is doing is reverting to using avaudioplayer for everything and assuming that all addresses are local. There are 2 solutions to this 1) either use file:// or cdvfile:// paths to access local files, as the media plugin currently uses the prefix to determine the file type and hence type of player to use 2) update the media plugin to properly handle relative paths by defaulting any media source not starting with https:// or http:// or rtsp:// to use the local avaudioplayer and assume a local file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-192183151 cool I'll test this out when I have a chance and see if it still behaves as expected in my app as it uses a mix of local and streaming content --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191648550 The avPlayer.play code is there for playing from remote sources as a stream, it will only be triggered if the source starts with http or https. If the file is local an avPlayer object is not created and avaudioplayer is used through the audiofile object. You can see the play statement for this being triggered in the follow code block underneath this change. This change will break streaming playback from what I can see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182673242 I have an audioplayer service which creates the media object with media.play().then statement. In the then statement I wait for mediaStatus to hit 2 and then tell the service to respond that playing started. mediaStatus changes to 2 when the stream starts playing. Seems to work well. The same behaviour works well in Android and Windows 10. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182668004 That should fix the test for rate change as it will allow the media to buffer before starting to count play time. In reality actually using the media plugin in an audioplayer app I have not had any issues or crashes related to this ever. I listen for mediaStatus events from the plugin in my app and only start playing when it is ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-177704439 Awesome! Glad I could contribute something back to the project! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176651587 @purplecabbage sorry to bug you but if you could have a look at my previous comment that would be great, I really want to get this merged as it has been hanging for a long time and is starting to be difficult to maintain my fork and keep everything up to date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176651285 @imsingh where are you loading the m3u file from? If you are opening the m3u file from the local file system it will try to play it like a local file. If you open it from a http url then it will try to stream it. This is just the logic in the media plugin, it looks at the source prefix to determine if it should stream or play locally. If you haven't already done so I have a fork of the plugin here that you can install using the command below, this fork has the updated ios streaming code from this pull request build in. If you install from here and you're m3u file is being loaded from a url that starts with http or https you should see a message in the native console saying "playing stream with avplayer" instead of the normal message you see which is tied to "avaudioplayer". avaudioplayer is the original implementation that does not support streaming, avplayer is the framework implemented in this PR to add proper streaming support. cordova plugin add https://github.com/ghenry22/cordova-plugin-media.git#integrated_fixes that's the best that I can think to recommend, hope it helps a bit! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176512843 @imsingh That doesn't really have anything to do with this pull request. I'm not sure what "MPESG Radio" is that is generating the error messages, never seen that one before. From my experience with the media plugin you need to give it a single file or single source URL to play, I don't think it will handle an m3u file with multiple items. No idea what it would do with an m3u with multiple entries. You could always grab the m3u file, strip out the list of items and then manage them as a playlist in your app code feeding them to the media plugin as sources appropriately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-173504921 @purplecabbage I have added rate control when streaming from a URL using avplayer and tested that it works. However test case 19 still fails in the automated suite but I believe that is due to the way media is loaded and the success evaluator on the test. To explain: When setting rate to 0.5 and listening to a file it is audibly slower than normal playback rate. When setting rate to 2.0 and listening to a file it is audibly faster than normal playback rate. So rate can be set and adjusted and does change playback rate. The problem with the test is it plays for 4 seconds and expects the playback position to be >7 when playing at rate 2. This is fine when using the old avaudioplayer implementation as it will first download the entire file locally and then start paying immediately at rate 2, resulting in a final position generally around 8. When using avplayer though to stream properly we don't download the entire file in advance, we only start streaming when play is pushed so we now have a variance that throws the test out. If the file is slow to load from the source server for some reason we have a larger variance. GIven only 4 seconds play time there is not enough time for the stream to start buffering and play at 2x rate in order to reach the magic test passing number. This is completely normal and expected. If the length of the test run was extended to say 10 seconds you would find a lot less variance as it allows some time to buffer. If the mp3 source file is hosted on a local http server on the same machine running the emulator and tests it will also download almost instantly and pass the test. (I have tested this scenario). To test rate you could potentially play for 4 seconds at rate 1 and then play for 4 seconds at rate 2 and if the output of the second play is close to 2x the first play then you have success. Given that the tests are run one after the other they are likely to both have the same buffering time which mostly rules that out as a variable. I am not sure how to rewrite the test to do this though. If someone could help to rewrite the test then all tests will pass and this PR can finally get merged which would be fantastic! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-168602586 update your android platform and try again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-168566368 @nuruddinbadawi install my branch of the media plugin with this command: cordova plugin add https://github.com/ghenry22/cordova-plugin-media.git#avplayer_streaming That will get you the version with streaming support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161844312 @snstarosciak I'm not going to be much help to you on this one unfortunately. The media plugin is for audio and my app only plays audio not video so I haven't messed around with the video stuff so much. You may need to find something like this: https://github.com/moust/cordova-plugin-videoplayer I am not sure how well HTML5 video plays with cordova apps as I haven't really used it. You could try using safari debug tools while running on the emulator or on a device to get the JS Console and see if there are any errors being spit out, you may be hitting whitelisting errors or CORS or something as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-9452: Treat RTSP streams as ...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/63#issuecomment-161146771 It's been merged into master :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161146304 The problem is the rate feature was added as a PR after this was submitted. I have kept this branch up to date and merged those changes in but obviously they will only work with local file playback as the original author of the rate control features was working on a version of the media plugin that only used AVAudioPlayer. I will have a look at setting playback rate for AVPlayer streaming sources and see what I can do about adding it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: iOS play audio in background
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-160829534 @FherPie this PR has nothing to do with the Android platform. This PR is also 2 years old now. If you require background threading and streaming for iOS you can run my branch from the link above otherwise you would probably be better off asking elsewhere about the base media plugin and it's behaviour in different versions where you have a wider audience. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159777975 @purplecabbage conflicts resolved was just the version bump I put in plugin.xml conflicting with the new version 2.0.0 bump in master, so completely trivial. Please merge me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159765780 @dduwab @snstarosciak - glad I was able to help you guys out a bit. Good luck with your projects! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: fix CB-9884 & CB-9885 on window...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/74#issuecomment-159765701 These are really simple small fixes that do not change any default behaviour but fix fairly critical use cases, like being able to play sounds from a url that does not end in a specific file extension. I have been using this code daily in the windows port of my app and it works well with no issues. Could these get merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159765464 @purplecabbage - if I fix the conflicts with the latest updates in master can this finally get merged? I can't see any reason for this to be held back? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159431966
That function just gets the directory that you would store your files in.
You can then append any file name you want to access. For example you could
use the same with say pic.jpg to get a path to an image file to display, it's
just a path to a file, doesn't matter what type of file.
I imagine you could then just use html5 video tags to play the video file,
as long as it is in a format that the built in webview on the device can play.
You'd have to do some research though, I don't play any video in my apps so I
really don't know the best way to handle it or encoding requirements.
Cheers
Gaven
> On 25 Nov 2015, at 12:32 AM, Stevie Starosciak
wrote:
>
> @ghenry22 - If I could hug you...I would squeeze you until you popped,
like a balloon. I tested a combination of that code out with mine AND IT
WORKED. I never thought there was light at the end of the tunnel with this
problem haha thankyou so much :) I will answer this question on stackoverflow
and accept it so people can also have their problems solved
>
> One more thing, does this function:
>
> $window.resolveLocalFileSystemURL(src, function(dir){
> basePath = dir.toInternalURL();
> });
>
> Only work for mp3 files or something, because I'm utilizing this for a
.mov file but that function doesn't seem to resolve the URL for that, but will
with an mp3 file. Any idea?
>
> â
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159179817
Ok this discussion isn't really relevant to this PR at all but more related
to quirks of the file plugin that is used by the media plugin but let me try
and help you out a bit:
https://github.com/apache/cordova-plugin-file
Read the info about file paths here and how to access persistent storage,
cache storage etc.
Importantly look at the file paths for android, windows and ios and which
cordova.file.* value they map to. If you use cordova.file.dataDirectory for
example it will work to map to persistent storage across all 3 platforms in a
consistent way. If you use file://somedir/someotherdir/etc then it won't work.
If you use file:// you will find that it also doesn't work on windows
platform as it's native paths us ms-appdata:// prefixes. Android works because
it uses file:// paths for local files natively (the path mappings in the file
plugin readme even show this).
So here's an example that might help you out from my code:
//define a variable to store the resolved path where files will be stored
var basePath = false;
//get the path to the file to be used for later playback from file system
var musicDirectory = cordova.file.dataDirectory + 'musicCache/';
//resolve the path to a usable internalURL for the current platform
$window.resolveLocalFileSystemURL(musicDirectory, function(dir){
if (!basePath) {
basePath = dir.toInternalURL();
};
})
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159119183 @dduwab - this PR does not require any changes to the client at all, it all works exactly the same with all the same functions implemented in the same way. You can swap back and forth easily between this PR and the released plugin. I would suggest checking your file paths as per the file plugin documentation (media plugin uses the file plugin to access local files). You don't want to use a full path like you have defined, you really want to use one of the cordova.file.* aliases to get the correct path to the file consistently. Either way though you want to have file:// or cdvfile:// at the start of your path to the file as the plugin uses the prefix to determine whether the file is local or remote (this is the same in the master code as in this PR). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-158700040 It's trying to play a local file as a stream due to the path being used by the look of it. Please try using the cordova.file.* paths to get a cdvfile:// path to your audio file and play with that path, should resolve your issue and make sure that your app works properly across platforms and installs as the path is consistent. Check the file plugin for details on the file paths. Cheers Gaven > On 21 Nov 2015, at 8:29 PM, dduwab wrote: > > I'm having trouble hearing sound from a local mp3 on iOS. I can play a sound from a http:// address but not from the local file tree www/assets/titleMusic.mp3 > Resetting plugins due to page load. Log: > Finished load of: file:///Users/.../Devices/.../data/Containers/Bundle/Application/.../ccgame.app/www/main.html > Found resource '/Users/.../Devices/.../data/Containers/Bundle/Application/.../ccgame.app/www/assets/titleMusic.mp3' in the web folder. > Playing audio sample 'assets/titleMusic.mp3' > Playing stream with AVPlayer > > Yet I don't hear any sound in this case. I'm new to iOS development but I did my best to trace through the code and no errors appeared and everything looked like it should be playing. > Again, there were no problems playing/hearing a file off the web. > Thanks. > > â > Reply to this email directly or view it on GitHub. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: iOS play audio in background
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-158699476 That actually isn't something that this code changes, that's the default behaviour of the media plugin. Search for playing audio when locked or in background, there is a simple Little mod to some Cordova files and you need to add the background audio entitlement through Xcode and you're good to go. If you can't find it let me know and I'll dig up the details for you. Cheers Gaven > On 22 Nov 2015, at 9:16 AM, Dan Vera wrote: > > @ghenry22 > installed the plugin with your work, its able to place an icecast stream but it stops the stream when the device is locked. > > â > Reply to this email directly or view it on GitHub. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-157914770 seekTo definitely works on streams from other sources, my primary test is the subsonic media server but I have tried other random sources like free sample streams from spotify which also worked for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-157914628 Not sure about soundcloud as I haven't tried to stream from them before. Whether you can seek in a stream or not would probably depend on the source and the meta data it provides and if that is enough for the avplayer underlying framework of Apples to be happy. One case I have come across on Android with some streams is that if the length of the stream is unknown it assigns it a length of 0 and then any attempt to seek or a stall in streaming and then resume will reset back to start, I haven't hit the same with iOS yet on those same streams but there are probably other quirks / scenarios where the iOS framework would have a similar issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-153949837 PR #12 & PR #18 could also be closed out as duplicate once this one is merged which will help to clean up some older lingering PR's --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153926046 once merged you could also close out PR #121 as duplicate as it attempts to solve the same issue but generates absolute paths from c:\... which are not usable in the app and result in encoding errors when used with file or file transfer plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9851 Document cdvfile protoco...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/141#issuecomment-153925590 I reported this and can confirm it is the case on the windows platform. This is a trivial change to the docs but very useful information for anyone working with this cordova platform as it's a platform specific quirk. Would be good to get this merged as it may well save people porting apps a lot of time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153925057 MS docs confirm the same, should be ms-appx:/// Committing an update to fix now. reference: https://msdn.microsoft.com/en-us/library/windows.applicationmodel.package.installedlocation.aspx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153923917 CB-9020 does say they are targeting WP 8.1 which uses the new windows platform so this PR would also resolve CB-9020. CB8257 seems to refer specifically to the wp8 platform which uses different native code. Although I thought that wp8 support was deprecated so perhaps that could be closed with a will not fix deprecated and advice to update to target WP8.1 to resolve the issue? Regarding the path changes you mentioned you're probably right, or maybe it should be ms-appx-web? I'll do a bit of reading and update the PR if necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153922252 CB-9090 is for the whitelist plugin CB-8257 is the same issue but for the wp8 platform. This fix is for the windows platform, I don't have native code skills to update the wp8 plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153536161 @purplecabbage yep I have signed an ICLA and have already had a PR merged into the file plugin. I'll send you a direct message on slack with full name etc to make it easier to verify --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219744 added applicationStorageDirectory to defined paths and updated readme with relevant comments for this path. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219294 my understanding is that applicationStorageDirectory is a bit redundant. It is the same as the applicationDirectory but has a note that you can change to the specific subdirectories that might have write access (ie /local is the same as where dataDirectory already points). I can add it in case it's useful to someone purely for compatibility though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9887 cordova.file.* paths for...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/143 CB-9887 cordova.file.* paths for windows platform Update the plugin to define cordova.file.* paths for windows platform as appropriate. Documentation updated to show where to store things. Have tested this in my own app and the paths are detected as file plugin works as expected now. Means you can use cordova.file.dataDirectory in your app and then run that app on ios, android, windows with consistent behaviour without requiring platform specific code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-file windows_paths Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #143 commit 34a66b89d3e6b9f3c4c43b95adcd60227d2cdc19 Author: ghenry22 Date: 2015-10-28T04:55:14Z Add windows paths to cordova.file object add standard paths to cordova.file object for windows. Standardises behaviour for windows platform and resolves cordova.file is undefined errors. commit 1e4094a2b40f5803f9954bcd3f15664e471c12d4 Author: ghenry22 Date: 2015-10-28T05:01:57Z fix commit d7c0b0beb641a4db51a94235768e0c1873e9f6aa Author: ghenry22 Date: 2015-10-28T05:37:49Z update docs for windows platform details commit 442973f2646f5767b84dc1e57dc5244afba7db84 Author: ghenry22 Date: 2015-10-28T05:40:34Z fix docs formatting commit 03d9d32a28c0884fe61c16f4f976d9114c316ef7 Author: ghenry22 Date: 2015-10-28T05:42:00Z fix docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: fix CB-9884 & CB-9885 on window...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/74 fix CB-9884 & CB-9885 on windows platform CB-9884 - windows platform - add support for streaming url prefixes that do not end in a file extension, so the media plugin can playback streaming audio. CB-9885 - windows platform - add base requirements for enabling background audio in a windows app, does not change default behaviour of the plugin but adds the required configuration for the user to enable background audio in their app if they wish. See Jira issue for more details on enabling background audio. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media windows_media_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit c8a89fd712076a0e5f4bee9cf40ad19b79076808 Author: ghenry22 Date: 2015-10-28T03:28:52Z fix CB-9884 & CB-9885 add support for streaming url prefixes that do not end in a file extension add base requirements for enabling background audio in a windows app --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-windows/pull/123#issuecomment-151123814 tested with the mod as in the comments, resolved the error for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-windows/pull/123#issuecomment-151005434 Currently blocked preparing my first windows store submission by this one. I use an external path to x64 node in visual studio 2015 so that it uses an updated version that doesn't freak out over path depth but then you hit this error when building for store submission fails. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Windows prefix paths
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-150114300
Have tried this on a windows 10 universal app and had some issues.
cordova.file values seem to return a absolute path eg:
cordova.file.dataDirectory returns c:\... etc when I would expect it to
return ms-appdata:///local/ which is the accessible path for the app to reach
persistent storage.
with the absolute path returned functions like checkDir, checkFile always
fail.
window.resolvelocalfilesystemurl(cordova.file.dataDirectory) always throws
a error code 5 encoding error when using this PR.
If I remove this PR code and go back to master and manually specify the
value of cordova.file.dataDirectory to the ms-appdata url above then
resolvelocalfilesystemurl works as expected as do other core file plugin
functions like checkdir, checkfile etc.
so I have reverted back to using the current release of the file plugin
with the following code added to my app.js:
//Init file systems for Windows
if (cordova.platformId === "windows"){
console.log("platform is windows");
cordova.file = {
dataDirectory: "ms-appdata:///local/",
cacheDirectory: "ms-appdata:///temp/",
tempDirectory: "ms-appdata:///temp/",
applicationDirectory: "ms-appdata:///"
};
};
This resolve the immediate problem and the app works now when I build for
the windows platform and test on windows 10, but perhaps you could adjust this
PR to take this into account so that the cordova.file.* constants work as
expected for the file systems that are available on windows without requiring a
workaround.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-147894924 Alkashi - nope you were quite right. I realised I had a different branch of the plugin installed myself to test some things for Android and it was giving me correct durations, Hence I bumped the version number so I could see what I have running! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-147566101 @dts - thanks for the suggestion, I have implemented this and hopefully also fixed for playback from local files as well. @purplecabbage - updated with implementation for stop() for compliance as requested. incremented the version number so that I can see which version is actually installed. if you install from my branch it should show version 1.0.3-dev when you run cordova plugin list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: iOS play audio in background
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-147294883 master branch of the repo has no changes, changes for enabling streaming and backgrounding of play / stop commands is implemented in a specific branch on my repo (so that it can be easily merged as a PR). Just use this command to add the updated version from the right branch: cordova plugin add https://github.com/ghenry22/cordova-plugin-media.git#avplayer_streaming --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-147205639 This pull request doesn't make any changes to the behavior of get duration calls though, I see with my media some times 0 is returned for some files sometimes it's a full duration, seems to vary depending on what information is available in the file or stream. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-146384452 Alkashi - getDuration definitely works as expected on ios devices. I use it every day in my app and have tested it extensively on multiple devices and on the simulator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-8222 Background threading fo...
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/60#issuecomment-142136673
I made a new PR which covers this and proper streaming support, just check
the PR list and use that instead.
Cheers
Gaven
> On 21 Sep 2015, at 11:15 am, Simon MacDonald
wrote:
>
> @ghenry22 Why did you close this PR? It doesn't appear it ever got merged.
>
> â
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Add ability to play queue of so...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/18#issuecomment-132009862 This pull request could probably be closed. I have added an updated pull request which implements avplayer for streaming audio which has no conflicts, the info in these PR's was very useful to get that moving. There is already a seperate remote controls cordova plugin which allows you the handle setting metadata and receiving remote control events from the lock screen or control center. I think it's better to leave that as a seperate plugin as it has a specific purpose which is not playing media and is also ios only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-132005818 I'll look and putting something in that mimics the existing stop behavior applied to avaudioplayer. Any chance of this actually getting merged once that is done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-130505127 avplayer which is used for streaming does not have an equivalent stop method. You can just pause() and then release() there is no need to stop(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: iOS play audio in background
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-128978709 You need to install from the #avplayer_streaming branch, just google how to install Cordova plugins from a branch. The base plugin is just the same, the branch has the updates in it. Cheers Gaven > On 8 Aug 2015, at 1:02 am, Martin Spriggs wrote: > > ghenry22 I installed your version (https://github.com/ghenry22/cordova-plugin-media.git), but it doesn't seem to make a difference on the actual device. Do I need to do something more than rm the current plugin and add yours? > > â > Reply to this email directly or view it on GitHub. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-8222 Background threading fo...
Github user ghenry22 closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/62 Streaming & Background threading on play This fixes 2 issues in the Cordova Jira, both with iOS. It enables streaming support for media playback from URLs while retaining the existing playback for local media. The second part is the simply background thread the play function so it doesn't block the ui or lock up the app on load. Gets rid of some of those pesky warnings in xcode too. Tested with simulator and on iphone 5 and iphone 6 and ipad 2, with iOS 8.1, 8.3 & 8.4 Please merge these and bump the version of the media plugin so I can stop installing them from my own fork :) Fix for CB-57 Updated to use avplayer when url starts with http:// or https:// for full streaming support. All other urls will use the standard AVAudioplayer Fix for CB-8222 Background thread on play to prevent locking during initial load of media. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media avplayer_streaming Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 00ddb9372bf4c9b96ccea0dbd285499df1809277 Author: ghenry22 Date: 2015-07-29T07:14:59Z Streaming & Background threading on play Fix for CB-57 Updated to use avplayer when url starts with http:// or https:// for full streaming support. All other urls will use the standard AVAudioplayer Fix for CB-8222 Background thread on play to prevent locking during initial load of media. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: More background threading for a...
Github user ghenry22 closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Add ability to play queue of so...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/18#issuecomment-120969822 Background playlists can already be achieved by handling you playlist in you code, but what is really interesting here is implementing avplayer instead of avaudioplayer for iOS which actually supports playing streaming media at last rather than downloading the whole thing to a temp file then playing. With some clean up this could be a really big improvement for the media plugin on ios --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: iOS play audio in background
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-120227841 I've added a new pull request that backgrounds all media functions, this resolves all the "should use a background thread" warnings xcode that were occurring on play, pause, stop, create, seekTo, release, pretty much everything the user did with the plugin. It also resolves the UI being blocked while a file is loaded on play() (could be significant 10+ seconds when loading from a URL), resolves the same for all other actions which had much shorter delays usually less than 150ms but still worth cleaning up. I have also submitted and had my CLA approved so that this could finally be merged in. In the mean time anyone who needs this before it is merged you can just install the updated plugin from my fork: cordova plugin add https://github.com/ghenry22/cordova-plugin-media.git --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: More background threading for a...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/61#issuecomment-120190492 sorry this is for CB-8222 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: More background threading for a...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/61 More background threading for audio send more functions to background threads. The previous submission fixes the UI blocking on load from URL with play(), xcode still complains that other functions take too long and should use background threads even though this is much less noticeable as the delays are far shorter than loading an entire audio file from a URL they should still be backgrounded. this adds further backgrounding for most other playback methods. I haven't changed record as I have not been working with record and hence not been able to test. These changes work well on iphone5,6,ipad2 and the ios emulator and keep xcode happy. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media more-background-threading-for-audio Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit afb82b4bb841258408242409adcfe77557888459 Author: ghenry22 Date: 2015-07-07T07:27:35Z Add background threading to play command commit 10632de5bf55f3e4a9913193d8f06042b5c76e46 Author: ghenry22 Date: 2015-07-07T08:03:25Z Background other functions Stop / Pause / Seek were all showing warnings in xcode that they should use a background process so I have also wrapped those in a background process to stop them from blocking. commit ce803907a9d9a8eea20312e0644b7d49ddc1e103 Author: ghenry22 Date: 2015-07-10T00:52:44Z more background xcode still complains about: create release setvolume pushed all to background threads to make xcode happy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/125#issuecomment-119771695 Hi edades, I don't think that is relevant to this pull request, I have this plugin (with and without this pull request) in my project and it works fine. Please make sure that you are testing on a physical device, it looks like maybe you are testing on Chrome? Deviceready will not fire if you are not using a physical device (or an appropriate emulator). In your screenshot I see device ready has not fired which seems to confirm this. Anyway I would suggest searching around a bit as you won't be likely to get much response to a post here as the question doesn't relate to this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/125 CB-9331 cordova-plugin-file resolves CB-9331, correct the value queried on iOS devices so that free getFreeDiskSpace() returns a valid value instead of always returning 0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #125 commit 655ab124586a0431e21431f28ba02db1718fdeb3 Author: ghenry22 Date: 2015-07-07T10:29:28Z CB-6703cordova-plugin-file Fix getFreeSpace always returns 0 on iOS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6703cordova-plugin-file
Github user ghenry22 closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6703cordova-plugin-file
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/124 CB-6703cordova-plugin-file Fix as discussed in the comments on this Jira issue. Fix getFreeSpace always returns 0 on iOS Works on emulator and device now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-file CB-6703cordova-plugin-file Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit 655ab124586a0431e21431f28ba02db1718fdeb3 Author: ghenry22 Date: 2015-07-07T10:29:28Z CB-6703cordova-plugin-file Fix getFreeSpace always returns 0 on iOS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-8222 Background threading fo...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/60#issuecomment-119106407 This resolves the same issue as PR #12, as that has been hanging for a LONG time I have created a new pull request. The Jira ID for this issue is : CB-8222 my jira login is ghenry22 I have just completed the CLA and emailed it back so that should also not be an issue. This resolves the issue with the media plugin blocking the UI when loading media. Especially noticeable when loading from a URL as it will cause a long delay. Should resolve the "Media should use a background thread" warnings in Xcode as well as they are tied to the time the plugin blocks to load media. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
