[GitHub] cordova-plugin-camera pull request: CB-6958. Port camera tests to ...
Github user javierbb31 closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-dialogs pull request: CB-6965. Port notification te...
Github user javierbb31 closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: CB-6964. Port net...
Github user javierbb31 closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: CB-6964. Port net...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/12 CB-6964. Port network tests to test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-network-information master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 2bcb34135a2ba1224584e592a52daa466683f924 Author: javierbb31 Date: 2014-06-30T21:06:50Z CB-6964. Port network tests to test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-dialogs pull request: CB-6965. Port notification te...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/22 CB-6965. Port notification tests to test-framework Ported notification test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-dialogs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit d00470f79a926ab11801cfec12eb38db28ea9ba7 Author: javierbb31 Date: 2014-06-30T20:56:43Z CB-6965. Port notification tests to test-framework Ported notification test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB-6958. Port camera tests to ...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/36 CB-6958. Port camera tests to plugin-test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tes.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 7305c64db09c4c277bbe83a3b1341f6b70a938ec Author: javierbb31 Date: 2014-06-30T20:37:18Z CB-6958. Port camera tests to plugin-test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tes.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-dialogs pull request: Port notification tests to pl...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/21 Port notification tests to plugin-test-framework Ported test from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to plugin.xml Folder with tests working on jasmine 2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-dialogs CB-6965 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 3ca79b4ebb63d05133fc5354a7575ff5b3a76d74 Author: javierbb31 Date: 2014-06-23T15:03:27Z Port notification tests to plugin-test-framework Ported test from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to plugin.xml Folder with tests working on jasmine 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: Port network test...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/11 Port network tests to plugin-test-framework Ported test from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to plugin.xml Folder with tests working on jasmine 2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-network-information CB-6964 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 263e3bf21e2f39baa1675e5d1f110de3384db197 Author: javierbb31 Date: 2014-06-20T21:59:32Z Port network tests to plugin-test-framework Ported test from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to plugin.xml Folder with tests working on jasmine 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...
Github user javierbb31 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r14040361 --- Diff: plugin.xml --- @@ -202,6 +205,7 @@ + --- End diff -- I already removed this dependency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...
Github user javierbb31 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13984170 --- Diff: plugin.xml --- @@ -33,6 +33,9 @@ + + --- End diff -- Yes, it means that the tests are going to be added on every project that uses this plugin, however, this PR it should have to be addressed to another branch(cdvtest, as it is for the plugin-device, which already has the tests for the plugin-test framework. https://github.com/apache/cordova-plugin-device/tree/cdvtest Are you able to create the branch cdvtest for this repository? Is there any way to correctly address this PR to that branch once created? Thanks for the feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...
Github user javierbb31 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13983869 --- Diff: plugin.xml --- @@ -202,6 +205,7 @@ + --- End diff -- Yes, this is a mistake, I started to work on that 3 days ago. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/34 CB- 6958. Port camera test to plugin-test-framework Ported tests from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to plugin.xml Folder with tests working on jasmine 2.0 This changes are aimed to work with the new plugin-test framework. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-camera CB-6958 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit afd392f0f92b58bd2b89e374cb02fda998fd7dde Author: javierbb31 Date: 2014-06-19T16:29:33Z CB- 6958. Port camera test to plugin-test-framework Ported tests from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to plugin.xml Folder with tests working on jasmine 2.0 This changes are aimed to work with the new plugin-test framework. commit 279b8812d6d75d79f8e851262464c43846a01770 Author: javierbb31 Date: 2014-06-19T16:52:50Z Replaced tabs by spaces --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
